[Bug 967689] Review Request: tsung - A distributed multi-protocol load testing tool
https://bugzilla.redhat.com/show_bug.cgi?id=967689 --- Comment #12 from Fedora Update System --- tsung-1.5.0-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/tsung-1.5.0-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zlP7C33KEw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967689] Review Request: tsung - A distributed multi-protocol load testing tool
https://bugzilla.redhat.com/show_bug.cgi?id=967689 --- Comment #11 from Fedora Update System --- tsung-1.5.0-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/tsung-1.5.0-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QwhUuRSkZi&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967689] Review Request: tsung - A distributed multi-protocol load testing tool
https://bugzilla.redhat.com/show_bug.cgi?id=967689 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cFG7W7XBxh&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996462] Review Request: fix8 - Open Source C++ FIX Engine
https://bugzilla.redhat.com/show_bug.cgi?id=996462 David Dight changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #4 from David Dight --- (In reply to Michael Simacek from comment #3) > I won't review it now because it doesn't build for me (amd64): > *** Error in > `/home/msimacek/rpmbuild/BUILD/fix8-0.9.4/compiler/.libs/lt-f8c': double > free or corruption (!prev): 0x029b80f0 *** FYI builds on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5878120 However this issue has just been reported here... https://groups.google.com/forum/#!topic/fix8-developer/FvuCxWd4Cw8 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Jvy8KdQQ0j&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967689] Review Request: tsung - A distributed multi-protocol load testing tool
https://bugzilla.redhat.com/show_bug.cgi?id=967689 --- Comment #13 from Fedora Update System --- tsung-1.5.0-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/tsung-1.5.0-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TKZkXJ7zzw&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 995045] Review Request: wildfly - WildFly Application Server
https://bugzilla.redhat.com/show_bug.cgi?id=995045 Marek Goldmann changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #10 from Marek Goldmann --- Gerard, Both aether-connector-file and aether-connector-file are commented out. The jbossws-native package was retired after I submitted this src.rpm. I'll look at the spec file and fix the issues Mikołaj found next week and submit a new package. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TdRJgeXXif&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses
https://bugzilla.redhat.com/show_bug.cgi?id=736861 Mads Kiilerich changed: What|Removed |Added Flags||fedora-cvs? --- Comment #25 from Mads Kiilerich --- New Package SCM Request === Package Name: hgview Short Description: A fast Mercurial log navigator for qt4 or curses Owners: kiilerix Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EdZKjXdhXV&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863836] Review Request: NetworkManager-strongswan - NetworkManager VPN plugin for strongSwan
https://bugzilla.redhat.com/show_bug.cgi?id=863836 Andreas Bierfert changed: What|Removed |Added CC||andreas.bierfert@lowlatency ||.de --- Comment #19 from Andreas Bierfert --- https://koji.fedoraproject.org/koji/taskinfo?taskID=5878470 Seems to work just fine on f19 against strongswan 5.1.0 on my raspi... -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WpTOIOwlua&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003280] New: Review Request: libpostscriptbarcode - Barcode Writer in Pure PostScript
https://bugzilla.redhat.com/show_bug.cgi?id=1003280 Bug ID: 1003280 Summary: Review Request: libpostscriptbarcode - Barcode Writer in Pure PostScript Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mario.blaetterm...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/libpostscriptbarcode.spec SRPM URL: http://mariobl.fedorapeople.org/Review/SRPMS/libpostscriptbarcode-20130603-1.fc19.src.rpm Description: Barcode Writer in Pure Postscript generates all barcode formats entirely within PostScript so that the process of converting the input data into the printed output can be performed by the printer or RIP itself. This is ideal for variable data printing (VDP) and avoids the need to re-implement the barcode generation process whenever your language needs change. Fedora Account System Username: mariobl -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LAjb4v6V0Z&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003280] Review Request: libpostscriptbarcode - Barcode Writer in Pure PostScript
https://bugzilla.redhat.com/show_bug.cgi?id=1003280 Mario Blättermann changed: What|Removed |Added Blocks||1001799 (kbarcode) Alias||libpostscriptbarcode --- Comment #1 from Mario Blättermann --- Note, there's currently no permanent download link. The file can be fetched from Google Drive. I've contacted the upstream author to get a real link. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YSpoulhWoM&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003188] Review Request: eclipse-pdt - PHP Development Tools (PDT) Eclipse plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1003188 Mat Booth changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Mat Booth --- (In reply to Mat Booth from comment #1) > Scratch build in progress: > https://koji.fedoraproject.org/koji/taskinfo?taskID=5877033 That build hung on arm for some reason, here's one that actually completed: https://koji.fedoraproject.org/koji/taskinfo?taskID=5877949 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=DHJw7871y7&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 736861] Review Request: hgview - A fast Mercurial log navigator for qt4 or curses
https://bugzilla.redhat.com/show_bug.cgi?id=736861 Kevin Fenzi changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mV9jQUQDau&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996061] Review Request: python-sphinx-theme-flask - Sphinx Themes for Flask related projects and Flask itself
https://bugzilla.redhat.com/show_bug.cgi?id=996061 Fedora Update System changed: What|Removed |Added Fixed In Version|python-sphinx-theme-flask-g |python-sphinx-theme-flask-g |it20130715.1cc4468-2.fc19 |it20130715.1cc4468-2.el5 --- Comment #15 from Fedora Update System --- python-sphinx-theme-flask-git20130715.1cc4468-2.el5 has been pushed to the Fedora EPEL 5 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IjXHjRBPqp&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967689] Review Request: tsung - A distributed multi-protocol load testing tool
https://bugzilla.redhat.com/show_bug.cgi?id=967689 Fedora Update System changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- Package tsung-1.5.0-3.el6: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing tsung-1.5.0-3.el6' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2013-11397/tsung-1.5.0-3.el6 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AbxseLkGup&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 975309] Review Request: libcutl - C++ utility library from Code Synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=975309 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||libcutl-1.7.1-1.el5 Resolution|--- |ERRATA Last Closed||2013-09-01 14:46:35 --- Comment #33 from Fedora Update System --- libcutl-1.7.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=AM0wM4TgDD&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996186] Review Request: python-argh - Unobtrusive argparse wrapper with natural syntax
https://bugzilla.redhat.com/show_bug.cgi?id=996186 Fedora Update System changed: What|Removed |Added Fixed In Version|python-argh-0.23.2-1.fc18 |python-argh-0.23.2-1.el6 --- Comment #10 from Fedora Update System --- python-argh-0.23.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mP5pP12tAu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 975309] Review Request: libcutl - C++ utility library from Code Synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=975309 Fedora Update System changed: What|Removed |Added Fixed In Version|libcutl-1.7.1-1.el5 |libcutl-1.7.1-1.el6 --- Comment #34 from Fedora Update System --- libcutl-1.7.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2ZzNJVZi80&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996061] Review Request: python-sphinx-theme-flask - Sphinx Themes for Flask related projects and Flask itself
https://bugzilla.redhat.com/show_bug.cgi?id=996061 Fedora Update System changed: What|Removed |Added Fixed In Version|python-sphinx-theme-flask-g |python-sphinx-theme-flask-g |it20130715.1cc4468-2.el5|it20130715.1cc4468-2.el6 --- Comment #16 from Fedora Update System --- python-sphinx-theme-flask-git20130715.1cc4468-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fRw15O8ige&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996088] Review Request: python-pathtools - Pattern matching and various utilities for file systems paths
https://bugzilla.redhat.com/show_bug.cgi?id=996088 Fedora Update System changed: What|Removed |Added Fixed In Version|python-pathtools-0.1.2-1.fc |python-pathtools-0.1.2-1.el |18 |6 --- Comment #14 from Fedora Update System --- python-pathtools-0.1.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=J6PTXJPHYC&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 841266] Review Request: plink - whole genome association analysis toolset
https://bugzilla.redhat.com/show_bug.cgi?id=841266 Ray Pete changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2013-09-01 15:01:25 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1iDC0WIGJ2&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003210] Review Request: open-cobol - OpenCobol - Cobol Compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1003210 Jochen Schmitt changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags||fedora-cvs? --- Comment #1 from Jochen Schmitt --- Because the package was retired less then 2 weeks, I want to request the follwing SCM Admin Request: Package Change Request == Package Name: open-cobol New Branches: devel f20 Owners: bar s4504kr -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EYlitxKYtk&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003009] Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1003009 --- Comment #1 from Miro Hrončok --- Spec URL: https://raw.github.com/hroncok/SPECS/master/gnome-colors-icon-theme.spec SRPM URL: http://churchyard.fedorapeople.org/SRPMS/gnome-colors-icon-theme-5.5.1-5.fc19.src.rpm - Link the start-here icon to the Fedora icon -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=7knkGqTn7k&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002250] Review Request: nodejs-globule - An easy-to-use wildcard globbing library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1002250
Tom Hughes changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
archit
[Bug 1002254] Review Request: nodejs-jasmine-growl-reporter - Growl notifications when running Jasmine tests
https://bugzilla.redhat.com/show_bug.cgi?id=1002254
Tom Hughes changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||t...@compton.nu
Assignee|nob...@fedoraproject.org|t...@compton.nu
Flags||fedora-review?
--- Comment #1 from Tom Hughes ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 10240 bytes in 2 files.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
archit
[Bug 1002250] Review Request: nodejs-globule - An easy-to-use wildcard globbing library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1002250 Tom Hughes changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Tom Hughes --- All looks good. Package approved! -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=uMNjfdeAiO&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002254] Review Request: nodejs-jasmine-growl-reporter - Growl notifications when running Jasmine tests
https://bugzilla.redhat.com/show_bug.cgi?id=1002254 Tom Hughes changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Tom Hughes --- Looks good to me, so package approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ueZ4I10NvY&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002250] Review Request: nodejs-globule - An easy-to-use wildcard globbing library for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1002250 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-globule Short Description: An easy-to-use wildcard globbing library for Node.js Owners: jamielinux patches Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sQTa9ugiqu&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002254] Review Request: nodejs-jasmine-growl-reporter - Growl notifications when running Jasmine tests
https://bugzilla.redhat.com/show_bug.cgi?id=1002254 Jamie Nguyen changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jamie Nguyen --- New Package SCM Request === Package Name: nodejs-jasmine-growl-reporter Short Description: Growl notifications when running Jasmine tests Owners: jamielinux patches Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rmbiTQdWOJ&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003301] New: Review Request: glite-lb-ws-interface - gLite Logging and Bookkeeping web service interface
https://bugzilla.redhat.com/show_bug.cgi?id=1003301 Bug ID: 1003301 Summary: Review Request: glite-lb-ws-interface - gLite Logging and Bookkeeping web service interface Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/glite-lb-ws-interface-4.0.6-1/glite-lb-ws-interface.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-ws-interface-4.0.6-1/glite-lb-ws-interface-4.0.6-1.fc21.src.rpm Description: glite-lb-ws-interface contains the L&B web service interface specification (LB.wsdl and LBTypes.wsdl) Fedora Account System Username: valtri koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5880182 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QnnHb7OtiX&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003322] New: Review Request: glite-lbjp-common-server-bones - Skeleton of multi-process network server
https://bugzilla.redhat.com/show_bug.cgi?id=1003322 Bug ID: 1003322 Summary: Review Request: glite-lbjp-common-server-bones - Skeleton of multi-process network server Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: val...@civ.zcu.cz QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://scientific.zcu.cz/fedora/glite-lbjp-common-server-bones-2.3.8-1/glite-lbjp-common-server-bones.spec SRPM URL: http://scientific.zcu.cz/fedora/glite-lbjp-common-server-bones-2.3.8-1/glite-lbjp-common-server-bones-2.3.8-1.fc21.src.rpm Description: The multi-process network server. A server listening on multiple ports, passing inbound requests to slaves and maintaining connections to specific slaves if possible. The library provides callback handles on connection initialization, incoming request, etc. Fedora Account System Username: valtri koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5880256 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oijjm6VWx6&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003156] Review Request: kate-plugin-cpphelper - Plugin for Kate to simplify C/C++ programming
https://bugzilla.redhat.com/show_bug.cgi?id=1003156 Kevin Kofler changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||ke...@tigcc.ticalc.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=oWbwrYMpeI&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 975309] Review Request: libcutl - C++ utility library from Code Synthesis
https://bugzilla.redhat.com/show_bug.cgi?id=975309 Fedora Update System changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Fixed In Version|libcutl-1.7.1-1.el6 |libcutl-1.7.1-1.fc18 --- Comment #35 from Fedora Update System --- libcutl-1.7.1-1.fc18 has been pushed to the Fedora 18 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sFrzAx6SMU&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003156] Review Request: kate-plugin-cpphelper - Plugin for Kate to simplify C/C++ programming
https://bugzilla.redhat.com/show_bug.cgi?id=1003156 Kevin Kofler changed: What|Removed |Added CC||package-review@lists.fedora ||project.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hMuMms5Bra&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003009] Review Request: gnome-colors-icon-theme - GNOME-Colors icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1003009 Christopher Meng changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||mno...@redhat.com --- Comment #2 from Christopher Meng --- *** Bug 515280 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IbSoNAf2NL&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929254] Review Request: perl-Module-CPANfile - Parse cpanfile
https://bugzilla.redhat.com/show_bug.cgi?id=929254
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #8 from Petr Pisar ---
Spec file changes:
--- perl-Module-CPANfile.spec 2013-08-27 16:43:42.0 +0200
+++ perl-Module-CPANfile.spec.1 2013-08-30 15:53:23.0 +0200
@@ -1,6 +1,6 @@
Name: perl-Module-CPANfile
Version:1.0001
-Release:2%{?dist}
+Release:3%{?dist}
Summary:Parse cpanfile
License:GPL+ or Artistic
Group: Development/Libraries
@@ -14,6 +14,7 @@
BuildRequires: perl(CPAN::Meta) >= 2.12091
BuildRequires: perl(CPAN::Meta::Prereqs) >= 2.12091
BuildRequires: perl(CPAN::Meta::Feature) >= 2.12091
+BuildRequires: perl(Data::Dumper)
BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
BuildRequires: perl(strict)
BuildRequires: perl(warnings)
@@ -21,14 +22,13 @@
BuildRequires: perl(Exporter)
BuildRequires: perl(POSIX)
BuildRequires: perl(Test::More) >= 0.88
-BuildRequires: perl(Pod::Usage)
Requires: perl(CPAN::Meta) >= 2.12091
Requires: perl(CPAN::Meta::Prereqs) >= 2.12091
Requires: perl(CPAN::Meta::Feature) >= 2.12091
Requires: perl(Data::Dumper)
Requires: perl(Pod::Usage)
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
%?perl_default_filter
%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}perl\\(CPAN::Meta\\)$
@@ -62,6 +62,9 @@
%{_mandir}/man3/*
%changelog
+* Fri Aug 30 2013 Marcela Mašláňová 1.0001-3
+- fix all problems found in review rhbz#929254
+
* Tue Aug 27 2013 Marcela Mašláňová 1.0001-2
- fix all problems found in review rhbz#929254
> > TODO: You can use plain `perl' instead of macro `%{__perl}'.
> TODO: You can do that same at perl(:MODULE_COMPAT) definition.
-Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo
$version))
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
Ok.
> > FIX: Build-require `perl(Data::Dumper)' (lib/Module/CPANfile.pm:115).
> FIX: still issue.
+BuildRequires: perl(Data::Dumper)
Ok.
> > FIX: Do not build-require `perl(Pod::Usage)'. It's not needed at build-time.
> FIX: still issue.
-BuildRequires: perl(Pod::Usage)
Ok.
$ rpmlint perl-Module-CPANfile.spec
../SRPMS/perl-Module-CPANfile-1.0001-3.fc21.src.rpm
../RPMS/noarch/perl-Module-CPANfile-1.0001-3.fc21.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
Package builds in F21
(http://koji.fedoraproject.org/koji/taskinfo?taskID=5880768). Ok.
Package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=Sd4oKfWEd8&a=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718681] Review Request: luajit - Just-In-Time Compiler for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=718681 Muayyad Alsadi changed: What|Removed |Added CC||als...@ojuba.org Flags|needinfo?(alapshin@fastmail | |.fm)| --- Comment #22 from Muayyad Alsadi --- I've updated .spec to the latest upstream and fixed the issues .spec file http://pastebin.com/raw.php?i=fqgu34Pv https://docs.google.com/file/d/0B15QfS_FMZ1GcEs2X2xZSGE3RHc/edit?usp=sharing the .src.rpm file https://docs.google.com/file/d/0B15QfS_FMZ1GVWhlRFFwclRRakk/edit?usp=sharing -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zq10w7tjun&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 718681] Review Request: luajit - Just-In-Time Compiler for Lua
https://bugzilla.redhat.com/show_bug.cgi?id=718681 Muayyad Alsadi changed: What|Removed |Added Attachment #559690|0 |1 is obsolete|| Attachment #559691|0 |1 is obsolete|| --- Comment #23 from Muayyad Alsadi --- Created attachment 792723 --> https://bugzilla.redhat.com/attachment.cgi?id=792723&action=edit luajit-2.0.2.spec -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YRRFq61GqN&a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
