[Bug 860249] Review Request: adobe-source-code-pro-fonts - A set of mono-spaced OpenType fonts designed for coding environments
https://bugzilla.redhat.com/show_bug.cgi?id=860249 --- Comment #49 from Tobias Florek m...@ibotty.net --- i'm sorry for not pursuing that further, but i didn't have much time lately and i don't think that will change that year. there is quiet a bit to do. * development moved from sourceforge to github, so i am pretty sure i missed a few updates. https://github.com/adobe/source-code-pro * and if i understood the lwn article last (?) week correctly (i only skimmed it, so i might be wrong), it should now be possible to build the font with open source tools, so the packaging has to be remade as well. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=M59PkFUgD1a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005769] Review Request: python-w3lib - A Python Library of web-related functions
https://bugzilla.redhat.com/show_bug.cgi?id=1005769 Fabian Affolter m...@fabian-affolter.ch changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2013-09-09 14:39:30 --- Comment #2 from Fabian Affolter m...@fabian-affolter.ch --- *** This bug has been marked as a duplicate of bug 1003694 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=q0Ed94hE9Ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Blocks||1005906 ||(heisenbug-kde-theme), ||1000885 (DESIGN-SW), ||1005251 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q6MYvdjZWFa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816991] Review Request: rubygem-backports - Backports of Ruby 1.8.7+ for older ruby
https://bugzilla.redhat.com/show_bug.cgi?id=816991 --- Comment #10 from Axilleas Pipinellis axill...@archlinux.gr --- Btw if you want to add me as a co-maintainer I have no problem since I'll need this for gitlab. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=czO563TOKpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Martin Sourada martin.sour...@gmail.com changed: What|Removed |Added Depends On||1006041 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mGJhpAPUbha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #2 from Jaroslav Reznik jrez...@redhat.com --- Two issues I've found: 1. preview screenshots are not updated 2. heisenbug-backgrounds contains PNGs, this package refers to JPGs Please prepare also kde-settings update (bundle it together). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fOhWatXUnoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816991] Review Request: rubygem-backports - Backports of Ruby 1.8.7+ for older ruby
https://bugzilla.redhat.com/show_bug.cgi?id=816991 Axilleas Pipinellis axill...@archlinux.gr changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|axill...@archlinux.gr --- Comment #8 from Axilleas Pipinellis axill...@archlinux.gr --- I'll take it for a review. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=T5LttBpSsoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 816991] Review Request: rubygem-backports - Backports of Ruby 1.8.7+ for older ruby
https://bugzilla.redhat.com/show_bug.cgi?id=816991
Axilleas Pipinellis axill...@archlinux.gr changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #9 from Axilleas Pipinellis axill...@archlinux.gr ---
Apart from two issues (see below), this looks good, so I approve it. Consider
fixing them prior importing this to Fedora.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Gem should use %gem_install macro.
In general the whole %prep section uses the old style
- Package contain duplicates in %files.
Note: warning: File listed twice:
/usr/share/gems/gems/backports-3.3.3/test/README
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gems,
/usr/share/gems/doc
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[-]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
[x]: Package contains Requires: ruby(release).
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations
[Bug 1006041] New: Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 Bug ID: 1006041 Summary: Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: martin.sour...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mso.fedorapeople.org/packages/SPECS/heisenbug-backgrounds.spec SRPM URL: http://mso.fedorapeople.org/packages/SRPMS/heisenbug-backgrounds-19.90.0-1.fc19.src.rpm Description: This package contains desktop backgrounds for the Heisenbug theme. Pulls in themes for GNOME, KDE, Mate and Xfce desktops. Fedora Account System Username: mso Additional info: Package is basically clone of schroedinger-cat-backgrounds with Heisenbug wallpapers. Rpmlint complaints about the comments (warnings from lines 37 to 197), which is OK, it's a code that's supposed to be enabled at some later time. The artwork page on wiki also doesn't exist yet, even though it has a subpage (for supplemental wallpaper submissions). Dangling relative symlinks are ok, provided by required subpackage, the same goes for nodoc. I quick-tested it in xfce, gnome, mate and kde, on my NB it works on all of them. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=L6jxBpJGyPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added CC||jrez...@redhat.com --- Comment #1 from Jaroslav Reznik jrez...@redhat.com --- Schroedinger-cat-backgrounds review for reference https://bugzilla.redhat.com/show_bug.cgi?id=918801 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=js8OBfRiLca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957918] Review Request: libxmp - A multi-format module playback library
https://bugzilla.redhat.com/show_bug.cgi?id=957918 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=isma2L8Thra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 Tim Flink tfl...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Tim Flink tfl...@redhat.com --- Since we're a bit short on time and mso is asleep, making scm request. New Package SCM Request === Package Name: heisenbug-backgrounds Short Description: Heisenbug desktop backgrounds Owners: mso Branches: f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ek5cwxhTUZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5eDCU7sLZua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041 --- Comment #4 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jJzhOdq08ta=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006041] Review Request: heisenbug-backgrounds - Heisenbug desktop backgrounds
https://bugzilla.redhat.com/show_bug.cgi?id=1006041
Tim Flink tfl...@redhat.com changed:
What|Removed |Added
CC||tfl...@redhat.com
Assignee|nob...@fedoraproject.org|tfl...@redhat.com
Flags||fedora-review+
--- Comment #2 from Tim Flink tfl...@redhat.com ---
Mandatory review guidelines:
- rpmlint output:
[tflink@river heisenbug-backgrounds]$ rpmlint
heisenbug-backgrounds-19.90.0-1.fc19.src.rpm
heisenbug-backgrounds.src: W: invalid-url URL:
https://fedoraproject.org/wiki/F20_Artwork HTTP Error 404: Not Found
heisenbug-backgrounds.src:37: W: macro-in-comment %package
heisenbug-backgrounds.src:41: W: macro-in-comment %{name}
heisenbug-backgrounds.src:41: W: macro-in-comment %{version}
heisenbug-backgrounds.src:41: W: macro-in-comment %{release}
heisenbug-backgrounds.src:43: W: macro-in-comment %description
heisenbug-backgrounds.src:90: W: macro-in-comment %package
heisenbug-backgrounds.src:95: W: macro-in-comment %description
heisenbug-backgrounds.src:99: W: macro-in-comment %package
heisenbug-backgrounds.src:103: W: macro-in-comment %{name}
heisenbug-backgrounds.src:105: W: macro-in-comment %description
heisenbug-backgrounds.src:109: W: macro-in-comment %package
heisenbug-backgrounds.src:113: W: macro-in-comment %{name}
heisenbug-backgrounds.src:115: W: macro-in-comment %description
heisenbug-backgrounds.src:118: W: macro-in-comment %package
heisenbug-backgrounds.src:122: W: macro-in-comment %{name}
heisenbug-backgrounds.src:124: W: macro-in-comment %description
heisenbug-backgrounds.src:127: W: macro-in-comment %package
heisenbug-backgrounds.src:131: W: macro-in-comment %{name}
heisenbug-backgrounds.src:133: W: macro-in-comment %description
heisenbug-backgrounds.src:161: W: macro-in-comment %files
heisenbug-backgrounds.src:162: W: macro-in-comment %dir
heisenbug-backgrounds.src:162: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:162: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:163: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:163: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:164: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:164: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:165: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:165: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:166: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:166: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:166: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:180: W: macro-in-comment %files
heisenbug-backgrounds.src:181: W: macro-in-comment %doc
heisenbug-backgrounds.src:182: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:182: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:183: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:183: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:184: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:184: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:184: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:186: W: macro-in-comment %files
heisenbug-backgrounds.src:187: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:187: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:189: W: macro-in-comment %files
heisenbug-backgrounds.src:190: W: macro-in-comment %{_kde4_datadir}
heisenbug-backgrounds.src:190: W: macro-in-comment %{Bg_Name}
heisenbug-backgrounds.src:192: W: macro-in-comment %files
heisenbug-backgrounds.src:193: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:193: W: macro-in-comment %{bgname}
heisenbug-backgrounds.src:195: W: macro-in-comment %files
heisenbug-backgrounds.src:196: W: macro-in-comment %{_datadir}
heisenbug-backgrounds.src:197: W: macro-in-comment %{_datadir}
1 packages and 0 specfiles checked; 0 errors, 54 warnings.
as noted above, this is OK - the artwork for f20 isn't done yet and the
wiki page hasn't been created, the comment warnings are for code that's waiting
to be enabled at a later time. the package
- License is acceptable: yes, CC-BY-SA
- License field in spec is correct: yes
- License files included in package %docs if included in source package NA
- License files installed when any subpackage combination is installed: OK
- Spec written in American English: OK
- Spec is legible: OK
- Sources match upstream unless altered to fix permissibility issues
Upstream SHA256: ...
Your SHA256: ...
- Build succeeds on at least one primary arch: OK, tested on x86_64
- Build
[Bug 957573] Review Request: php-aws-sdk - amazon web services sdk for php
https://bugzilla.redhat.com/show_bug.cgi?id=957573 --- Comment #26 from Fedora Update System upda...@fedoraproject.org --- php-aws-sdk-2.4.5-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/php-aws-sdk-2.4.5-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9dB3ZODXoha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 927461] Review Request: ros - The Robot Operating System
https://bugzilla.redhat.com/show_bug.cgi?id=927461 Bug 927461 depends on bug 927458, which changed state. Bug 927458 Summary: Review Request: rospack - ROS package and stack tools https://bugzilla.redhat.com/show_bug.cgi?id=927458 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wgDFxsrqQNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957348] Review Request: python-pylibravatar - Python module for Libravatar
https://bugzilla.redhat.com/show_bug.cgi?id=957348 Ralph Bean rb...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Status|MODIFIED|CLOSED Resolution|--- |ERRATA Last Closed||2013-09-09 20:50:28 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1alOhe3imha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 860249] Review Request: adobe-source-code-pro-fonts - A set of mono-spaced OpenType fonts designed for coding environments
https://bugzilla.redhat.com/show_bug.cgi?id=860249 --- Comment #50 from Matt Rose mattr...@folkwolf.net --- Hey Tobias, I don't mind taking it over at all if you don't have time, I've been tracking the package on github. I also read that lwn article (here for those interested https://lwn.net/Articles/564803/), but I don't see any changes in the docs or build scripts on github, so, though I would love to redo the spec file to incorporate those changes, they're not (publically) available yet. I'm going to open up a new bug with my own submission, at which time I'll resolve this one as a dupe. Tobias, thanks for all your work on getting this going. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=g79tvA59DIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000583] Review Request: fcitx-anthy - Anthy Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=1000583
--- Comment #3 from Robin Lee robinlee.s...@gmail.com ---
Spec URL: http://cheeselee.fedorapeople.org/fcitx-anthy.spec
SRPM URL: http://cheeselee.fedorapeople.org/fcitx-anthy-0.2.0-2.fc19.src.rpm
Changes:
- Own the diretory %%{_datadir}/fcitx/anthy/
- description enlarged
(In reply to Christopher Meng from comment #2)
Directories without known owners:
%{_datadir}/fcitx/anthy/*.sty
---
%{_datadir}/fcitx/anthy
===
Suggestion:
Name: fcitx-anthy
Version: 0.2.0
Release: 1%{?dist}
Summary: Anthy Engine for Fcitx
Group:System Environment/Libraries
License: GPLv2+
URL: https://fcitx-im.org/wiki/Anthy
Source0:
http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz
BuildRequires:cmake
BuildRequires:fcitx-devel
BuildRequires:gettext
BuildRequires:intltool
BuildRequires:anthy-devel
Requires: fcitx
Auh, a bit ugly...
Name: fcitx-anthy
Version: 0.2.0
Release: 1%{?dist}
Summary: Anthy Engine for Fcitx
Group:System Environment/Libraries
License: GPLv2+
URL: https://fcitx-im.org/wiki/Anthy
Source0:
http://download.fcitx-im.org/fcitx-anthy/%{name}-%{version}.tar.xz
BuildRequires:anthy-devel
BuildRequires:cmake
BuildRequires:fcitx-devel
BuildRequires:gettext
BuildRequires:intltool
Requires: fcitx
The specfile is aligned with tabs. If you set tab as 4 spaces in you editor,
you will get a cleanly aligned view.
Also, %description is too short.
Orig:
Fcitx-anthy is an Anthy engine wrapper for Fcitx. It
provides a Japanese input method.
Mine:
Fcitx-anthy is an Anthy engine wrapper for Fcitx based on scim-anthy. It
provides a Japanese input method. Users can input Japanese hiragana and
katakana by inputting romaji via fcitx-anthy. Fcitx-anthy can also convert
hiragana or katakana to Japanese kanji after inputting hiragana or katakana.
OK. I have revised it with respect to your suggestion.
*
Please FIX the issue before SCM.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=qzdioaYRVqa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006104] New: Review Request: gqrx - Software defined radio receiver powered by GNU Radio and Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1006104 Bug ID: 1006104 Summary: Review Request: gqrx - Software defined radio receiver powered by GNU Radio and Qt Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: bress...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://people.fedoraproject.org/~bressers/gqrx-review/gqrx.spec SRPM URL: http://people.fedoraproject.org/~bressers/gqrx-review/gqrx-2.1_git_298_g0e78-1.fc19.src.rpm Description: Gqrx is a software defined radio receiver powered by the GNU Radio SDR framework and the Qt graphical toolkit. Fedora Account System Username: bressers -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NNDWgWyKAba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000583] Review Request: fcitx-anthy - Anthy Engine for Fcitx
https://bugzilla.redhat.com/show_bug.cgi?id=1000583 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Robin Lee robinlee.s...@gmail.com --- Thanks for your review! New Package SCM Request === Package Name: fcitx-anthy Short Description: Anthy Engine for Fcitx Owners: cheeselee Branches: f18 f19 f20 InitialCC: i18n-team -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nUQqrcqEvga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006104] Review Request: gqrx - Software defined radio receiver powered by GNU Radio and Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1006104 --- Comment #1 from Josh Bressers bress...@redhat.com --- As a note, the version is a bit odd, I'm using a modified version of how the package versions itself from git. I'm quite happy to use a more traditional snapshot versioning if needed, but found this quite clever and makes upgrading simple. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=mUUSUIm49ca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 963903] Review Request: perl-Net-INET6Glue - Make common modules IPv6 ready by hotpatching
https://bugzilla.redhat.com/show_bug.cgi?id=963903 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags||fedora-cvs? --- Comment #4 from Ken Dreyer ktdre...@ktdreyer.com --- New Package SCM Request === Package Name: perl-Net-INET6Glue Short Description: Make common modules IPv6 ready by hotpatching them Owners: ktdreyer Branches: f19 f20 el6 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Oeqtetsynca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006112] New: Review Request: rubygem-exception_notification - Exception notification for Rails apps
https://bugzilla.redhat.com/show_bug.cgi?id=1006112 Bug ID: 1006112 Summary: Review Request: rubygem-exception_notification - Exception notification for Rails apps Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ktdre...@ktdreyer.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-exception_notification-4.0.0-1.fc21.src.rpm Description: The Exception Notification gem provides a set of notifiers for sending notifications when errors occur in a Rack/Rails application. The built-in notifiers can deliver notifications by email, campfire rooms or via webhooks. Fedora Account System Username: ktdreyer Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916345 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=i69JE63O8ga=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006114] New: Review Request: ghc-pureMD5 - Pure Haskell MD5 digest implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1006114 Bug ID: 1006114 Summary: Review Request: ghc-pureMD5 - Pure Haskell MD5 digest implementation Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: peter...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://petersen.fedorapeople.org//ghc-pureMD5.spec SRPM URL: http://petersen.fedorapeople.org//ghc-pureMD5-2.1.2.1-1.fc19.src.rpm Description: A Haskell-only implementation of the MD5 digest (hash) algorithm. This now supports the crypto-api class interface. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Y8snp3lhVka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006114] Review Request: ghc-pureMD5 - Pure Haskell MD5 digest implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1006114 --- Comment #1 from Jens Petersen peter...@redhat.com --- This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916365 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cwsmcqyvcMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991693] Review Request: perl-Archive-Any-Lite - Simple CPAN package extractor
https://bugzilla.redhat.com/show_bug.cgi?id=991693
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
CC||ktdre...@ktdreyer.com
Assignee|nob...@fedoraproject.org|ktdre...@ktdreyer.com
Flags||fedora-review+
--- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[-]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required. Paul confirmed that he
is building for EL5.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.
= SHOULD items =
Generic:
[-]: Buildroot is not present
Paul is building for EL5.
[-]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required. Paul is building for EL5.
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded
[Bug 1006114] Review Request: ghc-pureMD5 - Pure Haskell MD5 digest implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1006114 Jens Petersen peter...@redhat.com changed: What|Removed |Added CC||haskell-devel@lists.fedorap ||roject.org Alias||ghc-pureMD5 Whiteboard||Ready --- Comment #2 from Jens Petersen peter...@redhat.com --- 44 reverse deps on hackage http://packdeps.haskellers.com/reverse/pureMD5 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=TOX39iBSWDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 923543] Review Request: ghc-yesod-platform - Meta package for Yesod
https://bugzilla.redhat.com/show_bug.cgi?id=923543 Jens Petersen peter...@redhat.com changed: What|Removed |Added Depends On||1006114 (ghc-pureMD5) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ebAml0077ba=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006114] Review Request: ghc-pureMD5 - Pure Haskell MD5 digest implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1006114 Jens Petersen peter...@redhat.com changed: What|Removed |Added Blocks||630303 (yesod), 712659 ||(yi), 923543 ||(yesod-platform) CC||maths...@gmail.com --- Comment #3 from Jens Petersen peter...@redhat.com --- *** Bug 630302 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rheLA3m4WUa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006116] New: Review Request: WALinuxAgent - The Windows Azure Linux Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1006116 Bug ID: 1006116 Summary: Review Request: WALinuxAgent - The Windows Azure Linux Agent Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: er...@ioerror.us QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://linux.ringingliberty.com/tmp/WALinuxAgent.spec SRPM URL: http://linux.ringingliberty.com/tmp/WALinuxAgent-1.4.0-3.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916363 Description: The Windows Azure Linux Agent supports the provisioning and running of Linux VMs in the Windows Azure cloud and Microsoft System Center Virtual Machine Manager private clouds. This package should be installed on Linux disk images that are built to run in the Windows Azure or SCVMM environments. Fedora Account System Username: error Additional information: This is my first package so I will need a sponsor. I created this package as part of my work to use Fedora on Windows Azure. This package will assist users in running Fedora on Windows Azure, as well as SCVMM private clouds. I've also created a public VHD which you can experiment with on Azure by adding it into your account as a virtual machine Image then creating a virtual machine using the image. It contains a previous build of this package but is still functionally identical. http://ringingtest.blob.core.windows.net/vhds/Fedora19.vhd Some additional work is necessary to automate cloud image builds for Azure; I plan to talk with the Cloud SIG about this at a later date. This package generates some spurious rpmlint warnings related to the systemd unit file; I haven't figured out yet if those are a problem with rpmlint or the package, but I suspect rpmlint. The package name is capitalized to match the upstream package name. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=svpyYoOuNPa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006116] Review Request: WALinuxAgent - The Windows Azure Linux Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1006116 Michael Hampton er...@ioerror.us changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fbhFJcBCRna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905240] Review Request: rubygem-log4r - Comprehensive and flexible logging library for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=905240 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||ing...@linpro.no, ||ktdre...@ktdreyer.com Flags||needinfo?(ing...@linpro.no) --- Comment #3 from Ken Dreyer ktdre...@ktdreyer.com --- It looks like this spec file needs to be updated for the newest Ruby guidelines for Fedora 19+. Ingvar, are you still interested in packaging this? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=auiFijaMAMa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895166] Review Request: rubygem-zbxapi - Ruby wrapper to the Zabbix API
https://bugzilla.redhat.com/show_bug.cgi?id=895166 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #4 from Ken Dreyer ktdre...@ktdreyer.com --- Hi Russell, Are you still interested in packaging this? It looks like we'll need a new .spec file for Fedora 19+. Also, upstream has released a new 0.3.0 version. Perhaps it includes the changes that you have in Patch0. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lIBDNic6tha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895166] Review Request: rubygem-zbxapi - Ruby wrapper to the Zabbix API
https://bugzilla.redhat.com/show_bug.cgi?id=895166 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||fed...@russellharrison.com Flags||needinfo?(fedora@russellhar ||rison.com) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OVjz0jaknca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006116] Review Request: WALinuxAgent - The Windows Azure Linux Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1006116
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
1. URL is invalid.
I don't know why you point the URL to a redirect page of
https://github.com/windows-azure/walinuxagent
--- https://github.com/WindowsAzure/WALinuxAgent
Please change to this. Add Microshit link doesn't mean this is valid.
2. Requires:python-pyasn1 openssh openssl util-linux sed grep sudo iptables
You don't need to add util-linux sed grep sudo
3. BuildRequires:systemd python-setuptools
missing python2-devel
4. %setup -q -n %{name}-%{name}-%{version}# github does this to
tarballs
github never does this unless some people like this kind of naming way. If you
can change it, I recommend %{name}-%{version} so you can use %setup -q
without %{name}-%{version} or even this weird one %{name}-%{name}-%{version}
5. Nothing to build?
No python setup.py build?
6. python setup.py install --prefix=%{_prefix} --lnx-distro='redhat'
--init-system='systemd' --root=%{buildroot}
should be
{__python2} setup.py install --prefix=%{_prefix} --lnx-distro='redhat'
--init-system='systemd' --root=%{buildroot}
7. %{buildroot}/%{_localstatedir}/log
you don't need to add slash between %{buildroot} and %{_localstatedir}
just %{buildroot}%{_localstatedir}/log as rpm -E %{_localstatedir} eq /var so
if you add a slash the URI will be:
//var/log
8. %post preun postun section are all not perfect for f18+
Please check
http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd
9. You should avoid using sth. like:
%defattr(0644,root,root,0755) and %attr(0755,root,root)
Make sure that these file perms are correct during installation, and correct
the wrong ones after installation.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=nMP0MgnQ8ea=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946862] Review Request: rubygem-git-up - git command to fetch and rebase all branches
https://bugzilla.redhat.com/show_bug.cgi?id=946862 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #1 from Ken Dreyer ktdre...@ktdreyer.com --- It looks like git-up has had a couple new releases since the time of this review request submission. Could you please update to the latest version (0.5.12)? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wcCpEbu6pDa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 946862] Review Request: rubygem-git-up - git command to fetch and rebase all branches
https://bugzilla.redhat.com/show_bug.cgi?id=946862 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||jv+fed...@fcelda.cz Flags||needinfo?(jv+fedora@fcelda. ||cz) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6tsmt48Y5va=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1006116] Review Request: WALinuxAgent - The Windows Azure Linux Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1006116 --- Comment #2 from Michael Hampton er...@ioerror.us --- Hi Christopher, Thanks for your comments. I have addressed them as follows: 1. This was leftover from upstream. I fixed the URL. 2. This was leftover from upstream. I removed these from the spec file. 3. I added this in to the spec file. 4. The upstream tarball really does have this directory structure. You can download it for yourself and look :) The packaging guidelines said I'm not supposed to alter the tarball (except for patents or binaries in the tarball or other really bad stuff). So that's why this is here in %setup. 5. Upstream doesn't have any build function in their setup.py script. But I added this in anyway, just in case they start doing something later. 6. I have made this change in the spec file. 7. I have made this change in the spec file. 8. I have made these changes in the spec file. 9. I have made these changes in the spec file and manually verified all the permissions in the resulting build. The resulting files can be found at: Spec URL: http://linux.ringingliberty.com/tmp/WALinuxAgent.spec SRPM URL: http://linux.ringingliberty.com/tmp/WALinuxAgent-1.4.0-4.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5916543 Thanks -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RrSo4mubMfa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912960] Review Request: rubygem-gdk3 - Ruby binding of GDK-3.x
https://bugzilla.redhat.com/show_bug.cgi?id=912960 Toshio Ernie Kuratomi a.bad...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #34 from Toshio Ernie Kuratomi a.bad...@gmail.com --- Few comments: About the definition of hiding: The patch doesn't hide the test failure. It attempts to fix the test failure. Hiding it would be to comment out that test or disabling the test suite. About verifying with upstream: The rationale for not applying the patches is that you're not able to evaluate whether the patches to the test case are correct and that's worrisome enough that you won't apply a proposed fix for it because it might break the package more. However, that means that the package you are building could be severely broken. Severely broken packages aren't supposed to pass review. So enough review of the issue needs to take place so that we know whether the issue is one that compromises the operation of the package. But once someone does that it becomes apparent whether the patch is okay to apply or not: if the issue is really serious, the patch to the test case is incorrect and the package should not be approved until the actual issue is fixed. If the issue is minor, the proposed fix to the test case is something that can be applied and the problem and proposed solution sent upstream. It can be changed if upstream's evaluation turns out to be different. There's two places where our expectations might not match up here. The first would be that we have different implicit rankings of solutions to test failure. Here's mine from most desirable to least desirable: 1) Fix the bug the right way. 2) Potentially fix the bug the right way (unsure enough to need further evaluation) 3) Fix the bug in a way that you know is too hacky for upstream but fixes the problem on Fedora 4) Disable the specific case that's provoking the issue. 5) Disable the entire test suite. The second place where our thoughts might mismatch is in the definition of disable. For me, a disabled test or test suite is one that does not fail the build if the test or test suite doesn't pass. I think that your definition is slightly different; I'm guessing you'd say that not running the test at all is what constitutes disabling. The reasons I'd give for my view are: * On rawhide if the build succeeds the new build will replace the old package no matter what the test suite printed to the logs. * When someone else rebuilds the package for some reason (releng rebuild, provenpackagers rebuilding for changes to guidelines Fedora Change Owner rebuilding dependent packages), they won't know that they have to look at the build log of this package to see the test suite results. Even if they do, they won't know what the old baseline was, only what the current results are. * If you should give up maintaining the package and someone else take over (maybe just to satisfy the deps in their own package) they won't know that a failing test suite will not fail the build. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2wuOck1Ifua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 855780] Review Request: apacheds-daemon - Reusable Daemon Framework
https://bugzilla.redhat.com/show_bug.cgi?id=855780 Mikolaj Izdebski mizde...@redhat.com changed: What|Removed |Added Flags|needinfo?(mizdebsk@redhat.c | |om) | --- Comment #24 from Mikolaj Izdebski mizde...@redhat.com --- (In reply to Christopher Meng from comment #22) Ping? What do you need to know? If you want to take the review, feel free to do so. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xLWyD0pLQOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1004192] Review Request: python-queuelib - A collection of persistent (disk-based) queues
https://bugzilla.redhat.com/show_bug.cgi?id=1004192
Fabian Affolter m...@fabian-affolter.ch changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #2 from Fabian Affolter m...@fabian-affolter.ch ---
Thanks
(In reply to Dhiru Kholia from comment #1)
- %{__python} is deprecated, please use %{__python2} (see:
https://fedoraproject.org/wiki/Packaging:Python#Macros)
changed
Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-queuelib.spec
SRPM URL:
http://fab.fedorapeople.org/packages/SRPMS/python-queuelib-1.0-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=eetej5BO6Da=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989416] Review Request: ghc-pipes - Compositional pipelines
https://bugzilla.redhat.com/show_bug.cgi?id=989416 --- Comment #3 from Jens Petersen peter...@redhat.com --- Update to 4.0.0 release Spec: http://petersen.fedorapeople.org/reviews/ghc-pipes/ghc-pipes.spec SRPM: http://petersen.fedorapeople.org/reviews/ghc-pipes/ghc-pipes-4.0.0-1.fc19.src.rpm Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=5911858 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6KHDLIxBXJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005718] New: Review Request: faience-icon-theme - Faience icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005718 Bug ID: 1005718 Summary: Review Request: faience-icon-theme - Faience icon theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: chat-to...@raveit.de QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://raveit65.fedorapeople.org/Others/SPECS/faience-icon-theme.spec SRPM URL: http://raveit65.fedorapeople.org/Others/SRPM/faience-icon-theme-0.5.1-2.fc21.src.rpm Description: Faience icon theme Fedora Account System Username: raveit65 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4fC3hY3G4Ka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 987868] Review Request: bean-validation-api1 - Bean Validation API (JSR 303)
https://bugzilla.redhat.com/show_bug.cgi?id=987868 Marek Goldmann mgold...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DEFERRED Last Closed||2013-09-09 05:22:18 --- Comment #2 from Marek Goldmann mgold...@redhat.com --- I don't see any packages that would require this package, closing. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=O5JyIliuqoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172
--- Comment #4 from Sergio Pascual sergio.pa...@gmail.com ---
Hi, thanks for the review. I have added the test in check.
The documentation is small, less than 300k, so for the moment I don't think we
need a -doc subpackage.
Regarding the name, there was an exception for python packages having a py in
the name, they could remain with their name. But the exception was removed so
now all python packages need to follow python-%{name} rule.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mmcK0qmXGfa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Sergio Pascual sergio.pa...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Sergio Pascual sergio.pa...@gmail.com --- New Package SCM Request === Package Name: python-llvmpy Short Description: Python bindings for LLVM Owners: sergiopr Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=5umm2JV0o6a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848466] Review Request: qpdf - Command-line tools and library for transforming PDF files
https://bugzilla.redhat.com/show_bug.cgi?id=848466 Jiri Popelka jpope...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #11 from Jiri Popelka jpope...@redhat.com --- Package Change Request == Package Name: qpdf New Branches: el6 Owners: jpopelka twaugh EPEL-6 branch has been requested in bug #1004710. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vM3JkmKT4Ya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005499] Review Request: caja-terminal - Terminal embedded in Caja
https://bugzilla.redhat.com/show_bug.cgi?id=1005499 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #4 from Mohamed El Morabity pikachu.2...@gmail.com --- (In reply to Wolfgang Ulbrich from comment #3) I'm upstream and i decided to release on fedorapeople for this reason. # upstream is located at github, but links from tag releases doesn't match copied link in # web-browser, in result fedora-rewiew-tool will fail. # so i decided to release on fedorapeople to have a valid download link Is this really a problem for you? I can also release on raveit.de (my own server) If you're upstream, there's no problem then :). Putting the tarball on fedorapeople is OK. Maybe you could just mention on your Github project page the place to get proper tarballs on your fedorapeople space. It may be especially useful for any people interested in packaging caja-terminal for other Linux distributions. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qRxAr75IPna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005718] Review Request: faience-icon-theme - Faience icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005718 Mohamed El Morabity pikachu.2...@gmail.com changed: What|Removed |Added CC||pikachu.2...@gmail.com --- Comment #1 from Mohamed El Morabity pikachu.2...@gmail.com --- Hi, some comments: - expurging nonfree media files from the tarball is OK, but you should anyway document the way you drop those files from the original upstream tarball, as recommended by the guidelines: http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code I had the same issue with one of my packages (light-themes), you can have a look at the script I embedded in my src.rpm to generate a clean tarball from the original one: http://pkgs.fedoraproject.org/cgit/light-themes.git/tree/light-themes-generate-tarball.sh?h=f19 By the way, using a script will make easier future major updates of your package. - according to the index.theme files provided for each icon theme, Faience depends on Faenza, GNOME and hicolor themes for missing icons. As a result, you should add faenza-icon-theme and gnome-icon-theme as Requires (hicolor-icon-theme is already required by gnome-icon-theme). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8vfT7Ma3G9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1001028] Review Request: python-bna - Battle.net Authenticator routines in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1001028
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #3 from Christopher Meng cicku...@gmail.com ---
(In reply to Dhiru Kholia from comment #1)
I have some *informal* review comments,
- %{__python} is deprecated, please use %{__python2} (see:
https://fedoraproject.org/wiki/Packaging:Python#Macros)
Yep, thanks. I just got it from the list.
- Upstream releases don't include a separate LICENSE file. Can you please
contact upstream about fixing this?
Ah, they have added a LICENSE file on github, I will check again(maybe I forgot
to add it as %doc, or maybe caused by no such file, will check when possible.)
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=mUCLKWBOnFa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005599] Review Request: erfa - Essential Routines for Fundamental Astronomy
https://bugzilla.redhat.com/show_bug.cgi?id=1005599
Sergio Pascual sergio.pa...@gmail.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
--- Comment #2 from Sergio Pascual sergio.pa...@gmail.com ---
Updated.
For the pkgconfig thing, -devel contains erfa.pc that it's installed in
%{_libdir}/pkgconfig. This directory belongs to pkgconfig. If I leave out the
dependecy, %{_libdir}/pkgconfig would be unowned.
Spec URL: http://guaix.fis.ucm.es/~spr/erfa.spec
SRPM URL: http://guaix.fis.ucm.es/~spr/erfa-0.0.1-2.fc19.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=NDVlCm27uVa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005769] New: Review Request: python-w3lib - A Python Library of web-related functions
https://bugzilla.redhat.com/show_bug.cgi?id=1005769 Bug ID: 1005769 Summary: Review Request: python-w3lib - A Python Library of web-related functions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://fab.fedorapeople.org/packages/SRPMS/python-w3lib.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/python-w3lib-1.3-1.fc19.src.rpm Project URL: http://github.com/scrapy/w3lib Description: This is a Python library of web-related functions, such as: - remove comments, or tags from HTML snippets - extract base url from HTML snippets - translate entites on HTML strings - encoding mulitpart/form-data - convert raw HTTP headers to dicts and vice-versa - construct HTTP auth header - converting HTML pages to unicode - RFC-compliant url joining - sanitize urls (like browsers do) - extract arguments from urls Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=5912399 rpmlint output: [fab@laptop011 SRPMS]$ rpmlint python-w3lib-1.3-1.fc19.src.rpm python-w3lib.src: W: spelling-error %description -l en_US entites - entities, entitles, entices python-w3lib.src: W: spelling-error %description -l en_US mulitpart - multiparty python-w3lib.src: W: spelling-error %description -l en_US dicts - ducts, dicta, dict python-w3lib.src: W: spelling-error %description -l en_US versa - avers, verse, verso python-w3lib.src: W: spelling-error %description -l en_US auth - auto, Ruth, author python-w3lib.src:42: W: macro-in-comment %doc 1 packages and 0 specfiles checked; 0 errors, 6 warnings. [fab@laptop011 noarch]$ rpmlint python-w3lib-1.3-1.fc19.noarch.rpm python-w3lib.noarch: W: spelling-error %description -l en_US entites - entities, entitles, entices python-w3lib.noarch: W: spelling-error %description -l en_US mulitpart - multiparty python-w3lib.noarch: W: spelling-error %description -l en_US dicts - ducts, dicta, dict python-w3lib.noarch: W: spelling-error %description -l en_US versa - avers, verse, verso python-w3lib.noarch: W: spelling-error %description -l en_US auth - auto, Ruth, author python-w3lib.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 6 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zpx4P7uuFWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005718] Review Request: faience-icon-theme - Faience icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005718 --- Comment #2 from Wolfgang Ulbrich chat-to...@raveit.de --- (In reply to Mohamed El Morabity from comment #1) Hi, some comments: - expurging nonfree media files from the tarball is OK, but you should anyway document the way you drop those files from the original upstream tarball, as recommended by the guidelines: Cool, will do. http://fedoraproject.org/wiki/Packaging: SourceURL#When_Upstream_uses_Prohibited_Code I had the same issue with one of my packages (light-themes), you can have a look at the script I embedded in my src.rpm to generate a clean tarball from the original one: http://pkgs.fedoraproject.org/cgit/light-themes.git/tree/light-themes- generate-tarball.sh?h=f19 By the way, using a script will make easier future major updates of your package. Thanks, i will try this to avoid this work again :) - according to the index.theme files provided for each icon theme, Faience depends on Faenza, GNOME and hicolor themes for missing icons. As a result, you should add faenza-icon-theme and gnome-icon-theme as Requires (hicolor-icon-theme is already required by gnome-icon-theme). I need to check this, but faenza-icon-theme is droped. https://bugzilla.redhat.com/show_bug.cgi?id=1005176 For this reason i started this review, because i need faience or faenza for mate-themes-extras. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4MM23POhXLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 980960] Review Request: rpmgrill - A utility for catching problems in koji builds
https://bugzilla.redhat.com/show_bug.cgi?id=980960 Ed Santiago santi...@redhat.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #17 from Ed Santiago santi...@redhat.com --- Updated: http://www.edsantiago.com/f/rpmgrill.spec http://www.edsantiago.com/f/rpmgrill-0.24-1.fc19.src.rpm http://www.edsantiago.com/f/rpmgrill-0.24-1.fc19.noarch.rpm Changelog: * Mon Sep 9 2013 Ed Santiago santi...@redhat.com 0.24-1 - test suite: clamav output differs between f17 f19 - specfile: fix bad date in changelog; re-update some Requires -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ASPIHVPzbLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005778] New: Review Request: uima-build-resources - Apache UIMA Build Resources
https://bugzilla.redhat.com/show_bug.cgi?id=1005778 Bug ID: 1005778 Summary: Review Request: uima-build-resources - Apache UIMA Build Resources Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/uima-build-resources.spec SRPM URL: http://gil.fedorapeople.org/uima-build-resources-5-1.fc19.src.rpm Description: This Jar contains resources referred to by maven coordinates, needed during building. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZfMAuJ74RQa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005778] Review Request: uima-build-resources - Apache UIMA Build Resources
https://bugzilla.redhat.com/show_bug.cgi?id=1005778 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005779 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3JPPuTUH5Ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005779] Review Request: uima-parent-pom - Apache UIMA Parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1005779 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1005778 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Zz0QGzP2Eca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005779] New: Review Request: uima-parent-pom - Apache UIMA Parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1005779 Bug ID: 1005779 Summary: Review Request: uima-parent-pom - Apache UIMA Parent POM Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/uima-parent-pom.spec SRPM URL: http://gil.fedorapeople.org/uima-parent-pom-6-1.fc19.src.rpm Description: UIMA (Unstructured Information Management Architecture). UIMA promotes community development and reuse of annotators that extract meta-data from unstructured information (text, audio, video, etc.); it provides for externalized declaration of type systems, component configuration, aggregation, and more, supports scalablity, and provides tooling. This package provides Parent for Apache UIMA Projects. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=KeV65XDkROa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005782] New: Review Request: uimaj - Apache UIMA is an implementation of the OASIS-UIMA specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1005782 Bug ID: 1005782 Summary: Review Request: uimaj - Apache UIMA is an implementation of the OASIS-UIMA specifications Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/uimaj.spec SRPM URL: http://gil.fedorapeople.org/uimaj-2.4.2-1.fc19.src.rpm Description: Apache UIMA is an implementation of the OASIS-UIMA specifications. OASIS UIMA Committee: http://www.oasis-open.org/committees/uima/. Unstructured Information Management applications are software systems that analyze large volumes of unstructured information in order to discover knowledge that is relevant to an end user. An example UIM application might ingest plain text and identify entities, such as persons, places, organizations; or relations, such as works-for or located-at. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FsvuXircUCa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005779] Review Request: uima-parent-pom - Apache UIMA Parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1005779 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005782 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qLZFkLHVuKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005778] Review Request: uima-build-resources - Apache UIMA Build Resources
https://bugzilla.redhat.com/show_bug.cgi?id=1005778 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005782 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xGTAF3KMsAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005782] Review Request: uimaj - Apache UIMA is an implementation of the OASIS-UIMA specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1005782 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1005779, 1005778 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=4vIFw4UijZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005785] New: Review Request: snowball - Libstemmer Java bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1005785 Bug ID: 1005785 Summary: Review Request: snowball - Libstemmer Java bindings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/snowball.spec SRPM URL: http://gil.fedorapeople.org/snowball-0-0.1.20130902.fc19.src.rpm Description: Snowball contains all you need to include the snowball stemming algorithms into a Java project of your own. If you download this, you don't need to use the snowball compiler, or worry about the internals of the stemmers in any way. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pKdGeJA1e9a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848466] Review Request: qpdf - Command-line tools and library for transforming PDF files
https://bugzilla.redhat.com/show_bug.cgi?id=848466 --- Comment #12 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=EkiJm2ureja=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 848466] Review Request: qpdf - Command-line tools and library for transforming PDF files
https://bugzilla.redhat.com/show_bug.cgi?id=848466 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=034UNt5SZ2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977118] Review Request: nodejs-dateformat - Steven Levithan's excellent dateFormat() function for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=977118 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rVTI5297C3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005792] New: Review Request: uima-addons - Apache UIMA Addons components
https://bugzilla.redhat.com/show_bug.cgi?id=1005792 Bug ID: 1005792 Summary: Review Request: uima-addons - Apache UIMA Addons components Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/uima-addons.spec SRPM URL: http://gil.fedorapeople.org/uima-addons-2.3.1-1.fc19.src.rpm Description: UIMA Addons is a collection of Annotators extracted for sandbox for official distribution. It also provide Simple Server and Pear packaging tools. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OFKaXk99iOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005792] Review Request: uima-addons - Apache UIMA Addons components
https://bugzilla.redhat.com/show_bug.cgi?id=1005792 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1005782, 1005785 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=413Bjhi6Fma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005782] Review Request: uimaj - Apache UIMA is an implementation of the OASIS-UIMA specifications
https://bugzilla.redhat.com/show_bug.cgi?id=1005782 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005792 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=fHnSzxJKoOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005785] Review Request: snowball - Libstemmer Java bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1005785 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005792 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=YyEps4oQFSa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005796] New: Review Request: langdetect - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1005796 Bug ID: 1005796 Summary: Review Request: langdetect - Language Detection Library for Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/langdetect.spec SRPM URL: http://gil.fedorapeople.org/-1.1-0.1.20120112.fc19.src.rpm Description: This is a language detection library implemented in plain Java. (aliases: language identification, language guessing). Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=WVrHOlMCyAa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=iaGEDUheaea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005172] Review Request: python-llvmpy - Python bindings for LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1005172 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=xmFv5SdA6Oa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005800] New: Review Request: jsonic - Simple JSON encoder/decoder for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1005800 Bug ID: 1005800 Summary: Review Request: jsonic - Simple JSON encoder/decoder for Java Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jsonic.spec SRPM URL: http://gil.fedorapeople.org/jsonic-1.3.0-1.fc19.src.rpm Description: JSON library for Java, JSONIC is RFC 4627, while decoding/encoding in JSON format formal seconds, not including the information in JSON that is independent of the programming language POJO (Plain There is a feature that allows a natural transformation and Old Java Object). Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FrQFM4vyRHa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005796] Review Request: langdetect - Language Detection Library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1005796 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1005800 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wCoPTZtgdka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005800] Review Request: jsonic - Simple JSON encoder/decoder for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1005800 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005796 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=U8FoUw36bIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005769] Review Request: python-w3lib - A Python Library of web-related functions
https://bugzilla.redhat.com/show_bug.cgi?id=1005769 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #1 from Christopher Meng cicku...@gmail.com --- ??? https://bugzilla.redhat.com/show_bug.cgi?id=1003694 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vwM8iAQVB3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005718] Review Request: faience-icon-theme - Faience icon theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005718 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #3 from Wolfgang Ulbrich chat-to...@raveit.de --- I'm pretty shure that the author use gnome-icon-theme because of symbolic icons for GTK3 application, adding g-i-t as runtime require seems OK for me. I think i will remove faenza-icon-theme from faience index.theme file. First test in MATE shows me that no icons are missing. Maybe the author use faenza-icon-theme to avoid to add the tons of nonfree icons to his theme. :) See what i did yesterday for mate-icon-theme-faenza :) https://github.com/mate-desktop/mate-icon-theme-faenza/commit/c1478671383a3c7960714b31f2bdc480535e4f98 What do you think? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=6FN7m10Ae8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 920310] Review Request: apitrace - OpenGL(ES) tools for trace and replay
https://bugzilla.redhat.com/show_bug.cgi?id=920310
Rob Clark rcl...@redhat.com changed:
What|Removed |Added
CC|package-review@lists.fedora |
|project.org |
Flags|needinfo?(rcl...@redhat.com |
|) |
--- Comment #4 from Rob Clark rcl...@redhat.com ---
(In reply to Christopher Meng from comment #3)
3. Wrong:
%dir %{_libdir}/apitrace/wrappers
%{_libdir}/apitrace/wrappers
%{_libdir}/apitrace/wrappers/glxtrace.so
%{_libdir}/apitrace/wrappers/egltrace.so
%dir %{_libdir}/apitrace/scripts
%{_libdir}/apitrace/scripts/highlight.py
%{_libdir}/apitrace/scripts/unpickle.pyo
...
%{_libdir}/apitrace/scripts/highlight.pyc
%{_libdir}/apitrace/scripts/snapdiff.pyo
First, these files shouldn't be installed to libdir.
note that apitrace does not install it's py stuff to %{python_sitelib} like a
normal py package should, and changing this is beyond the scope of just
packaging. (Although it looks like I could use %py_byte_compile or something
similar to handle the byte compiled files properly.)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=G5BgG5nj4ma=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005792] Review Request: uima-addons - Apache UIMA Addons components
https://bugzilla.redhat.com/show_bug.cgi?id=1005792 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||977016 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8y2iM8FxmTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977016] Review Request: xmlbeans-maven-plugin - Maven XML Beans Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=977016 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005792 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=qAmXXSSaL8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912960] Review Request: rubygem-gdk3 - Ruby binding of GDK-3.x
https://bugzilla.redhat.com/show_bug.cgi?id=912960 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added CC||package-review@lists.fedora ||project.org -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2NaCwQ7Pgea=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=888385 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||cicku...@gmail.com Resolution|--- |DUPLICATE Flags|needinfo?(jama...@fc.up.pt) | Last Closed||2013-09-09 10:57:50 --- Comment #8 from Christopher Meng cicku...@gmail.com --- *** This bug has been marked as a duplicate of bug 998738 *** -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=avfIlgmsvLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 882482] Review Request: python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=882482 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Depends On||998738 (python-yapsy) -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=195pvvG813a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=888385 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Blocks|882482 | -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2y0vM900Bva=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=888385 --- Comment #7 from Ville Skyttä ville.sky...@iki.fi --- Looks like another review overtook this one, see bug 998738 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8ljmhNwmZKa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 888385] Review Request: python-yapsy - Fat-free DIY Python plugin management toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=888385 Pete Travis m...@petetravis.com changed: What|Removed |Added CC||m...@petetravis.com --- Comment #9 from Pete Travis m...@petetravis.com --- Sorry I missed this, José - I would welcome you as a comaintainer. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=NCgZ8inqQya=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] New: Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Bug ID: 1005906 Summary: Review Request: heisenbug-kde-theme - Heisenbug KDE Theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mbr...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mbriza.fedorapeople.org/themes/heisenbug-kde-theme.spec SRPM URL: http://mbriza.fedorapeople.org/themes/heisenbug-kde-theme-19.90.0-1.fc19.src.rpm Description: This is Heisenbug KDE Theme Artwork containing KDM theme, SDDM theme KSplash theme and Plasma Workspaces theme. Fedora Account System Username: mbriza -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QYtlbcEFiNa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Martin Bříza mbr...@redhat.com changed: What|Removed |Added CC||jrez...@redhat.com, ||mbr...@redhat.com Blocks||656997 (kde-reviews) Alias||heisenbug-kde-theme -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=BJ7GuypLFIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005901] New: Review Request: jsslutils - Java SSL utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1005901 Bug ID: 1005901 Summary: Review Request: jsslutils - Java SSL utilities Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/jsslutils.spec SRPM URL: http://gil.fedorapeople.org/jsslutils-1.0.5-1.fc19.src.rpm Description: This project aims to provide a set of utilities regarding the use of SSL in Java. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wDiCXAtU5la=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|jrez...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=OlaWWKc2KWa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 995995] Review Request: lunar-date - Chinese lunar date library
https://bugzilla.redhat.com/show_bug.cgi?id=995995
--- Comment #5 from Michael Schwendt bugs.mich...@gmx.net ---
Have rpmlint and/or fedora-review -b 995995 been run for this one yet?
%files data
%dir %{_datadir}/liblunar
%{_datadir}/liblunar/*
%files data
%{_datadir}/liblunar/
would be shorter and achieves the same.
Btw, here the subpackage includes only three tiny files, each below 1KB, and
the base package even strictly depends on this package. Is that really enough
reason to introduce a noarch subpackage?
%packagedocs
The guidelines recommend -doc not -docs:
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
The subpackage is 14788 bytes long. I would keep it in the -devel package.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=j2rFta1kZda=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005901] Review Request: jsslutils - Java SSL utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1005901 gil cattaneo punto...@libero.it changed: What|Removed |Added Blocks||1005904 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=2OtM6uvA8qa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005904] Review Request: restlet-jse - Open Source Lightweight REST framework
https://bugzilla.redhat.com/show_bug.cgi?id=1005904 gil cattaneo punto...@libero.it changed: What|Removed |Added Depends On||1005901 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=SCvGXnDRZ8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005904] New: Review Request: restlet-jse - Open Source Lightweight REST framework
https://bugzilla.redhat.com/show_bug.cgi?id=1005904 Bug ID: 1005904 Summary: Review Request: restlet-jse - Open Source Lightweight REST framework Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://gil.fedorapeople.org/restlet-jse.spec SRPM URL: http://gil.fedorapeople.org/restlet-jse-2.1.3-1.fc19.src.rpm Description: Restlet is a lightweight, comprehensive, REST framework for the Java platform. Restlet is suitable for both server and client Web applications. It supports major Internet transport, data format, and service description standards like HTTP and HTTPS, SMTP, XML, Atom, and WADL. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=sqpUZm2Illa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005906] Review Request: heisenbug-kde-theme - Heisenbug KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1005906 Jaroslav Reznik jrez...@redhat.com changed: What|Removed |Added Blocks||1005251 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=QOefhj8Y11a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 860249] Review Request: adobe-source-code-pro-fonts - A set of mono-spaced OpenType fonts designed for coding environments
https://bugzilla.redhat.com/show_bug.cgi?id=860249 --- Comment #44 from Dan Mashal dan.mas...@gmail.com --- Not even sure how I grabbed this but I'll try and do a review for you. I cannot sponsor though, will defer to rdieter on that one. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Cf0IXk6G59a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 863836] Review Request: NetworkManager-strongswan - NetworkManager VPN plugin for strongSwan
https://bugzilla.redhat.com/show_bug.cgi?id=863836 Thorsten Leemhuis fed...@leemhuis.info changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | --- Comment #20 from Thorsten Leemhuis fed...@leemhuis.info --- Sorry, seems I don't find enough time to drive this package forward properly :-/ @jamie, @pavel, @andreas: Wanna take over? Anyway, here is my latest WIP: Spec URL: http://www.leemhuis.info/files/fedora/NetworkManager-strongswan.spec SRPM URL: http://www.leemhuis.info/files/fedora/NetworkManager-strongswan-1.3.0-3.fc19.src.rpm (Sorry jamie, I had some of the changes lying around here already before you posted your 1.3.0-2 here :-/ And btw, why did you add a group tag?) Remaining problems: * rpmlint: NetworkManager-strongswan.x86_64: E: no-binary Could be fixed with making this a noarch subpackage of NetworkManager-strongswan-gnome -- but that's ugly and probably not worth the trouble * the NetworkManager configuration dialog in F19 (gnome) doesn't show the options to specify the key files anymore (jamie: same with your package); not sure when and why that broke :-/ * still seeing AVC denied msgs from Selinux; partly due to the location of the keyfiles, hence that might be my configuration up to a point -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=8asnuUUEEza=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
