[Bug 1013986] Review Request: bytecode-compatibility-transformer - Evolve modular codebase without losing compatibility
https://bugzilla.redhat.com/show_bug.cgi?id=1013986 Michal Srb m...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2013-10-03 03:11:44 --- Comment #4 from Michal Srb m...@redhat.com --- Thanks for the review and the repo, the package is now available in rawhide. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=c6WjUbvQ31a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 955804] Review Request: nzbget - Command-line based binary newsgrabber for nzb files
https://bugzilla.redhat.com/show_bug.cgi?id=955804 Marcel Wysocki m...@satgnu.net changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | Flags|fedora-cvs+ |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=RWtlUHrimua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639
--- Comment #6 from Mamoru TASAKA mtas...@fedoraproject.org ---
Thank you for comments!
http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf-0.1.2-1.fc.src.rpm
http://mtasaka.fedorapeople.org/Review_request/mechanize-related/rubygem-unf.spec
* Thu Oct 3 2013 Mamoru TASAKA mtas...@fedoraproject.org - 0.1.2-1
- 0.1.2
(In reply to Josef Stribny from comment #5)
1, There is a newer upstream version (0.1.2).
- Updated.
2, The %description section of -doc sub-package should end up with a dot(.).
- Fixed
3, You should use a macro %{gem_libdir} for lib dir instead of
%{gem_instdir}/lib/
- Well, I prefer to use %{gem_instdir}/lib/ because using %{gem_libdir}
makes it difficult to show that %{gem_libdir} is the subdirectory of
%{gem_instdir} (i.e. the parent directory of %{gem_libdir} is properly
owned), however modified.
4, And again license file is not separately listed. This requires more work
in the end (for me to check it, for you to check it with every update of the
gem) and it's prone to error.
- I always check this... (i.e. I always unpack both the previous version
and the new version of tarball / gem / etc, take diff to check what
actually changed, judge if it can safely be upgraded.)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=z1az8Zqo7Ta=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991753] Review Request: mph-2b-damase-fonts - Free font encoding many non-Latin scripts
https://bugzilla.redhat.com/show_bug.cgi?id=991753 Pravin Satpute psatp...@redhat.com changed: What|Removed |Added CC||psatp...@redhat.com --- Comment #18 from Pravin Satpute psatp...@redhat.com --- This package description is not very clear. From description it looks like font encoding rather than fonts itself. Proper description or short description may be.. Mark Williamson's MPH 2B Damase is a free font for many non-Latin scripts encoding. Please fix it. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ou7OCIurHda=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1008083] Review Request: hoogle - Haskell API Search
https://bugzilla.redhat.com/show_bug.cgi?id=1008083 --- Comment #6 from Shakthi Kannan shakthim...@gmail.com --- The scratch build got cancelled for F21 x86_64 and i686. The same with F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6019328 It fails on F18 because of: http-types =0.7 It builds fine on F19 though: http://koji.fedoraproject.org/koji/taskinfo?taskID=6019322 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=GDijjaGrEJa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Josef Stribny jstri...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Josef Stribny jstri...@redhat.com --- I always check this... (i.e. I always unpack both the previous version and the new version of tarball / gem / etc, take diff to check what actually changed, judge if it can safely be upgraded.) I believe you and it's a right thing to do :). But someone working on the package in the future can overlook it, that's my point :). Thanks for the fixes == APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=LuaLRbWinGa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989416] Review Request: ghc-pipes - Compositional pipelines
https://bugzilla.redhat.com/show_bug.cgi?id=989416
Shakthi Kannan shakthim...@gmail.com changed:
What|Removed |Added
Status|ASSIGNED|MODIFIED
Flags||fedora-review?
--- Comment #4 from Shakthi Kannan shakthim...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. No licenses
found. Please check the source files for licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 962560 bytes in 32 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQi9aLionIa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=1ZjbZbbg33a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014385] Review Request: openid-selector - A user-friendly way to select an OpenID
https://bugzilla.redhat.com/show_bug.cgi?id=1014385 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x581SJXgEpa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014385] Review Request: openid-selector - A user-friendly way to select an OpenID
https://bugzilla.redhat.com/show_bug.cgi?id=1014385 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JJFn9E31Ana=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996202] Review Request: nodejs-mongodb - A nodejs driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=996202
--- Comment #1 from Marek Mahut mma...@redhat.com ---
Package review list, including only relevant items.
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[x]: Package complies to the Packaging Guidelines
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory.
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces:
nodejs-mongodb.noarch: W: only-non-binary-in-usr-lib
Note: there has been a new release this month, version 1.3.19.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=OMcBgnLNKKa=cc_unsubscribe
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996202] Review Request: nodejs-mongodb - A nodejs driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=996202 Marek Mahut mma...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Marek Mahut mma...@redhat.com --- Troy, please update the package to the latest version at least in rawhide. Otherwise this package looks good to me, approved. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=PpGVzsWcMna=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966222] Review Request: nodejs-bignumber.js - Library for decimal and non-decimal arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=966222 Marek Mahut mma...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mma...@redhat.com, ||tdaw...@redhat.com Assignee|nob...@fedoraproject.org|mma...@redhat.com Flags||fedora-review? ||needinfo?(tdaw...@redhat.co ||m) --- Comment #1 from Marek Mahut mma...@redhat.com --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6019718 Troy, all looks good except for the name. The used convention looks to be -js instead of .js - can you please rename it? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VwLdXjMOrYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966223] Review Request: nodejs-mysql - pure node.js MySQL client
https://bugzilla.redhat.com/show_bug.cgi?id=966223 Marek Mahut mma...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mma...@redhat.com Assignee|nob...@fedoraproject.org|mma...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eseUNojKZYa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015162] New: Review Request: xorg-x11-drv-wayland - Xorg wayland driver
https://bugzilla.redhat.com/show_bug.cgi?id=1015162 Bug ID: 1015162 Summary: Review Request: xorg-x11-drv-wayland - Xorg wayland driver Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: a...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://ajax.fedorapeople.org/xorg-x11-drv-wayland/xorg-x11-drv-wayland.spec SRPM URL: http://ajax.fedorapeople.org/xorg-x11-drv-wayland/xorg-x11-drv-wayland-0-0.1.20131003.src.rpm Description: Fallback driver for X-under-wayland Fedora Account System Username: ajax -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tAgvIzmiECa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015162] Review Request: xorg-x11-drv-wayland - Xorg wayland driver
https://bugzilla.redhat.com/show_bug.cgi?id=1015162 --- Comment #1 from Adam Jackson a...@redhat.com --- Wrong srpm url. Right one: http://ajax.fedorapeople.org/xorg-x11-drv-wayland/xorg-x11-drv-wayland-0-0.1.20131003.fc20.src.rpm Note that this requires a fairly new xorg-x11-server-devel to build; I've not marked the exact version yet, but what's currently in F20 should be sufficient. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=cc9gknik5ua=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Mamoru TASAKA mtas...@fedoraproject.org --- Thank you! New Package SCM Request === Package Name: rubygem-unf Short Description: Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby Owners: mtasaka Branches: f18 f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=zj7xtauhV0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=wQtngflfBha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 904639] Review Request: rubygem-unf - Wrapper library to bring Unicode Normalization Form support to Ruby/JRuby
https://bugzilla.redhat.com/show_bug.cgi?id=904639 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Qk3iwL6p7Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015162] Review Request: xorg-x11-drv-wayland - Xorg wayland driver
https://bugzilla.redhat.com/show_bug.cgi?id=1015162 Adam Jackson a...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=D95500qTJ8a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015253] New: Review Request: rubygem-svn2git - A tool for migrating SVN projects to Git
https://bugzilla.redhat.com/show_bug.cgi?id=1015253 Bug ID: 1015253 Summary: Review Request: rubygem-svn2git - A tool for migrating SVN projects to Git Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ktdre...@ktdreyer.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-svn2git.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-svn2git-2.2.2-1.fc21.src.rpm Description: A tool for migrating SVN projects to Git Fedora Account System Username: ktdreyer Koji F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6022301 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=hk9wFcTUsOa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015261] New: Review Request: rubygem-just_paginate - Paginating collections of things for the web
https://bugzilla.redhat.com/show_bug.cgi?id=1015261 Bug ID: 1015261 Summary: Review Request: rubygem-just_paginate - Paginating collections of things for the web Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ktdre...@ktdreyer.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-just_paginate.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-just_paginate-0.2.2-1.fc21.src.rpm Description: Paginating collections of things for the web Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6022343 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=FoANZ63FJ2a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015263] New: Review request: lz4 Extremely fast compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1015263 Bug ID: 1015263 Summary: Review request: lz4 Extremely fast compression algorithm Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: pj.pan...@yahoo.co.in QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Hi, lz4 is a new extremely fast compression algorithm developed by Yann Collet - https://code.google.com/p/lz4/ SPEC: http://pjp.fedorapeople.org/lz4.spec SORC: http://pjp.fedorapeople.org/lz4-r106.tar.gz SRPM: http://pjp.fedorapeople.org/lz4-r106-1.fc19.src.rpm Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6022278 Could someone review it please? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=jdDKQMFqPca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015263] Review request: lz4 Extremely fast compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1015263 pjp pj.pan...@yahoo.co.in changed: What|Removed |Added URL||https://code.google.com/p/l ||z4/ -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=IoCy64aWHLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015263] Review request: lz4 Extremely fast compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1015263 pjp pj.pan...@yahoo.co.in changed: What|Removed |Added Assignee|nob...@fedoraproject.org|kumarpraveen.nitdgp@gmail.c ||om -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VXhPxIxxECa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009703] Review Request: roboJournal - Keep a journal/diary of day-to-day events in your life
https://bugzilla.redhat.com/show_bug.cgi?id=1009703 --- Comment #3 from Will Kraft pwiz...@gmail.com --- I've made the requested changes to my SPEC file and updated the source RPM (see SRPM/SPEC links in the original post). Here is the latest Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6014821 Hopefully all problems have been fixed and the package is ready for sponsorship. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=pYXaabhzpoa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996202] Review Request: nodejs-mongodb - A nodejs driver for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=996202 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Troy Dawson tdaw...@redhat.com --- New Package SCM Request === Package Name: nodejs-mongodb Short Description: A nodejs driver for MongoDB Owners: tdawson Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=9o0nHa1hx3a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added CC||ktdre...@ktdreyer.com --- Comment #1 from Ken Dreyer ktdre...@ktdreyer.com --- Hi Ankur, the .spec file link is a 404 at the moment. Are you still interested in packaging this? -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=bcJmVWTeYLa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966222] Review Request: nodejs-bignumber.js - Library for decimal and non-decimal arithmetic
https://bugzilla.redhat.com/show_bug.cgi?id=966222 Troy Dawson tdaw...@redhat.com changed: What|Removed |Added Flags|needinfo?(tdaw...@redhat.co | |m) | --- Comment #2 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js.spec SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-bignumber.js-1.2.0-1.fc20.src.rpm - Updated to the latest release - I don't understand what you mean by the convention is -js instead of .js. The name of the package is bignumber.js, and all the packages and dependencies expect it to have that name. Or am I not understanding what you are saying. -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=VwZ3QweYqEa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014353] Review Request: php-lightopenid - PHP OpenID library
https://bugzilla.redhat.com/show_bug.cgi?id=1014353 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=JVafkTwCs0a=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014344] Review Request: gallery3-openid - OpenID support for Gallery3
https://bugzilla.redhat.com/show_bug.cgi?id=1014344 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lDgj3X245ra=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014385] Review Request: openid-selector - A user-friendly way to select an OpenID
https://bugzilla.redhat.com/show_bug.cgi?id=1014385 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=x8bOutkFmRa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014344] Review Request: gallery3-openid - OpenID support for Gallery3
https://bugzilla.redhat.com/show_bug.cgi?id=1014344 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=b0kG5AKjlca=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014385] Review Request: openid-selector - A user-friendly way to select an OpenID
https://bugzilla.redhat.com/show_bug.cgi?id=1014385 --- Comment #4 from Fedora Update System upda...@fedoraproject.org --- gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/gallery3-openid-2.0-0.2.beta.fc19,php-lightopenid-0.6-1.fc19,openid-selector-1.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tKksZ27QWTa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014353] Review Request: php-lightopenid - PHP OpenID library
https://bugzilla.redhat.com/show_bug.cgi?id=1014353 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=o3qniENkSma=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 966223] Review Request: nodejs-mysql - pure node.js MySQL client
https://bugzilla.redhat.com/show_bug.cgi?id=966223 --- Comment #2 from Troy Dawson tdaw...@redhat.com --- Spec URL: http://tdawson.fedorapeople.org/nodejs/nodejs-mysql.spec SRPM URL: http://tdawson.fedorapeople.org/nodejs/nodejs-mysql-2.0.0-alpha9.1.fc20.src.rpm - Updated to latest release -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=3J5XENJ8BZa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 --- Comment #17 from Abdel Gadiel MartÃnez Lassonde abdel.g.martine...@gmail.com --- Hi Eduardo! Here are my updates for this packages: SRPM: http://potty.fedorapeople.org/Oplop/1.6.1-4/python-oplop-1.6.1-4.fc19.src.rpm SPEC: http://potty.fedorapeople.org/Oplop/1.6.1-4/python-oplop.spec Hope this time is OK. Regards, Abdel -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=vAmzVLoQdka=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015326] New: Review Request: main package name here - short summary here
https://bugzilla.redhat.com/show_bug.cgi?id=1015326 Bug ID: 1015326 Summary: Review Request: main package name here - short summary here Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ktdre...@ktdreyer.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-hipchat.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-hipchat-0.12.0-1.fc21.src.rpm Description: Ruby library to interact with HipChat Fedora Account System Username: ktdreyer F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6022828 -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=lwLyHAMpoXa=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015326] Review Request: rubygem-hipchat - Ruby library to interact with HipChat
https://bugzilla.redhat.com/show_bug.cgi?id=1015326 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Summary|Review Request: main |Review Request: |package name here - short |rubygem-hipchat - Ruby |summary here |library to interact with ||HipChat -- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=nRE575X81Ha=cc_unsubscribe ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015263] Review request: lz4 Extremely fast compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1015263 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-falcon-0.1.7-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc18 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039 --- Comment #2 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Ken, I've uploaded the spec/srpm again: http://ankursinha.fedorapeople.org/albumart/ http://ankursinha.fedorapeople.org/albumart/albumart.spec http://ankursinha.fedorapeople.org/albumart/albumart-1.6.6-1.fc20.src.rpm I just checked the website, and the project appears dead :( There hasn't been any newer releases since the 1.6.6 in 2008. I'm beginning to wonder if it's worth getting this into Fedora, or if it'd be better to look for another program that's better maintained? Thanks Ankur -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039 --- Comment #3 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- This still seems to be the only one for Linux though.. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-falcon-0.1.7-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009750] Review Request: python-falcon - High-performance cloud API framework
https://bugzilla.redhat.com/show_bug.cgi?id=1009750 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- python-falcon-0.1.7-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-falcon-0.1.7-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014353] Review Request: php-lightopenid - PHP OpenID library
https://bugzilla.redhat.com/show_bug.cgi?id=1014353
Remi Collet fed...@famillecollet.com changed:
What|Removed |Added
CC||fed...@famillecollet.com
--- Comment #8 from Remi Collet fed...@famillecollet.com ---
Review submitted 2013-10-01 15:19:16
Review approved 2013-10-01 16:42:10
This don't let other time to have a minimal look at it :-(
Obviously :
[!]: Package complies to the Packaging Guidelines
Please read: http://fedoraproject.org/wiki/Packaging:PHP
Requires: php = 5.1.2
= A PHP library must not have an explicit Requires on php or httpd..
From phpcompatinfo report should be
Requires: php(language) = 5.1.2 (but this one have no interest)
Requires: php-curl
Requires: php-pcre
%{_datadir}/lightopenid
= Non-PEAR PHP software which provides shared libraries should put its PHP
source files for such shared libraries in a subfolder of /usr/share/php
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
So ? no link to upstream request or bug report ?
[!]: Packages should try to preserve timestamps of original installed files.
So ?
Ok, the package have been fixed, but this is not traced here.
Otherwise, this package is APPROVED
Really ?
Reviews are not a speed competition !
Please fix the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015263] Review request: lz4 Extremely fast compression algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1015263
--- Comment #1 from Praveen Kumar kumarpraveen.nit...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
BSD (2 clause), GPL (v2 or later). Detailed output of licensecheck in
/home/prkumar/1015263-lz4/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned
[Bug 962651] Re-Review Request: bamf - Application matching framework
https://bugzilla.redhat.com/show_bug.cgi?id=962651 Praveen Kumar kumarpraveen.nit...@gmail.com changed: What|Removed |Added Flags||needinfo?(michel+fdr@sylves ||tre.me) --- Comment #12 from Praveen Kumar kumarpraveen.nit...@gmail.com --- Hi Salim, As per rel-eng ticket looks like it's unblocked, if this resolve your issue please close this bug or do needful. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
