[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025196



--- Comment #1 from Parag AN(पराग)  ---
Review:

+ Package builds in mock f21

+ rpmlint on generated rpms gave
fcitx-skk.src: W: spelling-error %description -l en_US libskk -> basilisk
fcitx-skk.src: W: strange-permission fcitx-skk-0.1.0.tar.xz 0600L
fcitx-skk.x86_64: W: spelling-error %description -l en_US libskk -> basilisk
fcitx-skk.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 4 warnings.


+ Source verified with upstream as (sha256sum)
srpm tarball : 41c433592e965c95d4b383b036a828c0646ae875540eb10b56ac63cd30a89630
upstream tarball :
41c433592e965c95d4b383b036a828c0646ae875540eb10b56ac63cd30a89630

+ License is valid and included as headers in source files.


Suggestions:
1) Group tag is no longer mandatory, you can remove it.

2) include COPYING as %doc


APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025196

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=878556

Miroslav Suchý  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



--- Comment #17 from Miroslav Suchý  ---
You can not request additional branches using new package request. You have to
use "change request". See:
http://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=878556

Jan Klepek  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #18 from Jan Klepek  ---
Package SCM Request
===
Package Name: rubygem-simplecov
Short Description: Code coverage analysis tool for Ruby 1.9
Owners: hpejakle
Branches: el5 el6
InitialCC: tdawson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023714



--- Comment #12 from Simone Caronni  ---
OK, figured out. It happens only in f19 mock:

+ /usr/share/lpf/scripts/lpf-setup-pkg
/builddir/build/BUILDROOT/lpf-skype-4.2.0.11-2.fc19.x86_64
/builddir/build/SOURCES/skype.spec.in
+ desktop-file-validate
/builddir/build/BUILDROOT/lpf-skype-4.2.0.11-2.fc19.x86_64/usr/share/applications/lpf-skype.desktop
/builddir/build/BUILDROOT/lpf-skype-4.2.0.11-2.fc19.x86_64/usr/share/applications/lpf-skype.desktop:
file does not exist
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.fKPQrS (%install)

Rebuilding lpf and lfp-skype in rawhide now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1014848] Review Request: python-mandrill - A CLI client and API library for Mandrill email service.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1014848

Christopher Meng  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||cicku...@gmail.com
 Resolution|--- |CURRENTRELEASE
Last Closed||2013-11-04 04:00:49



--- Comment #9 from Christopher Meng  ---
DO NOT forget to close the bug!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 987717] Review Request: perl-GraphViz2 - A wrapper for AT&T's Graphviz

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=987717



--- Comment #2 from Christopher Meng  ---
(In reply to Peter Oliver from comment #1)
> There's a newer upstream version of this module, 2.22, and version 2.14 is
> no-longer on CPAN proper.  Worth setting Source0 to
> "http://backpan.perl.org/authors/id/R/RS/RSAVAGE/GraphViz2-%{version}.tgz";?

Sorry for the late response, just saw it from SPAM...

Don't worry ;) I will update the URLs once all deps are resolved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=878556



--- Comment #19 from Jan Klepek  ---
Package Change Request
==
Package Name: rubygem-simplecov
Short Description: Code coverage analysis tool for Ruby 1.9
Owners: hpejakle
Branches: el5 el6
InitialCC: tdawson

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996489] Review Request: rubygem-tins - Useful tools library in Ruby

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=996489



--- Comment #14 from Jan Klepek  ---
Package Change Request
==
Package Name: rubygem-tins
Short Description: Useful tools library in Ruby
Owners: hpejakle
Branches: el6 el5
InitialCC: axilleas

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1005796] Review Request: langdetect - Language Detection Library for Java

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1005796



--- Comment #1 from gil cattaneo  ---
Spec URL: http://gil.fedorapeople.org/langdetect.spec
SRPM URL: http://gil.fedorapeople.org/langdetect-1.1-0.1.20120112.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023714



--- Comment #13 from Simone Caronni  ---
..because as it was suggested in the lpf-spotify-client review I was still
using the latest lpf package in the review which is quite old
(lpf-0-3.46ae0c3).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023714



--- Comment #14 from Simone Caronni  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /var/lib/lpf/packages/skype/state
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /var/lib/lpf/packages, /usr/share/lpf,
 /var/lib/lpf, /usr/share/lpf/packages
[-]: Package must own all directories that it creates.
 Note: Directories without known owners: /var/lib/lpf,
 /var/lib/lpf/packages, /usr/share/lpf, /usr/share/lpf/packages
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
 file-validate if there is such a file.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Spec use %global instead of %define unless justified.
 Note: %define requiring justification: %define target_pkg %(t=%{name};
 echo ${t#lpf-})
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]

[Bug 1023714] Review Request: lpf-skype: Skype internet phone client package bootstrap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023714



--- Comment #15 from Simone Caronni  ---
Issues:

> - Package does not contain duplicates in %files.
>  Note: warning: File listed twice: /var/lib/lpf/packages/skype/state
>  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles

Couple of issues in the %files section:

%{_datadir}/lpf/packages/%{target_pkg}
%attr(775,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg}
%attr(664,pkg-build,pkg-build) /var/lib/lpf/packages/%{target_pkg}/state

- First line is redundant with the second one.
- Third line is redundant with the second one; second one already includes the
path. If you want to own only the directory but not the files contained in it
please use %dir.

> [!]: If the source package does not include license text(s) as a separate file
> from upstream, the packager SHOULD query upstream to include it.
> [!]: Package does not include license text files separate from upstream.
> [!]: Package does not include license text files separate from upstream.

The license is MIT, but there's no license file installed. Please provide one
in %doc.

> lpf-skype.noarch: W: invalid-url URL: 
> http://leamas.fedorapeople.org/skype/4.2.0.11/skype.spec HTTP Error 404: Not 
> Found

Please fix.

Almost the same issues as in comment number 18 of the lfp-spotify-client
review:

https://bugzilla.redhat.com/show_bug.cgi?id=973069#c18

> Diff spec file in url and in SRPM

Please re-upload spec file or srpm file to match.

After these fixes I will review the "internal" spec file.

Thanks.
--Simone
-

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026252] New: Review Request: kluppe - a live looping instrument

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026252

Bug ID: 1026252
   Summary: Review Request: kluppe - a live looping instrument
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: brendan.jones...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



kluppe is a loop-player and recorder, designed for live use. It uses the
jack-audio-connection-kit and OSC sound control.

SRPM: http://bsjones.fedorapeople.org/reviews/kluppe-0.6.15-1.fc20.src.rpm
SPEC: http://bsjones.fedorapeople.org/reviews/kluppe.spec

Review: http://bsjones.fedorapeople.org/reviews/review-kluppe.txt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1022317] Review Request: mingw-hidapi - Library for communicating with USB and Bluetooth HID devices

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1022317

František Dvořák  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||val...@civ.zcu.cz
   Assignee|nob...@fedoraproject.org|val...@civ.zcu.cz
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002170] Review Request: morfologik-stemming - Morfologik stemming library

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002170

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||m...@redhat.com
   Assignee|nob...@fedoraproject.org|m...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002154] Review Request: spatial4j - A Geospatial Library for Java

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002154

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||m...@redhat.com
   Assignee|nob...@fedoraproject.org|m...@redhat.com



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 954108] Review Request: gimp-gap - The GIMP Animation Package

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=954108



--- Comment #28 from Mario Blättermann  ---
rpmlint output, omitting the wrong FSF address errors:

gimp-gap.i686: W: file-not-utf8 /usr/share/doc/gimp-gap-2.7.0/ChangeLog
gimp-gap.src: W: invalid-url Source0: gimp-gap-e75bd46.tar.xz
gimp-gap.x86_64: E: incorrect-fsf-address
/usr/share/gimp/2.0/scripts/gap-dup-continue.scm
gimp-gap.x86_64: W: file-not-utf8 /usr/share/doc/gimp-gap-2.7.0/ChangeLog
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_mov_exec.c
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_att_trans_dlg.c
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo_types.h
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo.h
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo.c
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_mov_xml_par.c
gimp-gap-debuginfo.i686: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_main.h
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_mov_exec.c
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_mov_dialog.c
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_att_trans_dlg.c
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo_types.h
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo.h
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_story_undo.c
gimp-gap-debuginfo.x86_64: W: spurious-executable-perm
/usr/src/debug/gimp-gap/gap/gap_mov_xml_par.c
gimp-gap.spec: W: invalid-url Source0: gimp-gap-e75bd46.tar.xz
6 packages and 1 specfiles checked; 286 errors, 25 warnings.


There are a few source files where the executable bit is set. Please remove
them. Besides that, convert the Changelog file to UTF-8. For the wrong FSF
addresses contact upstream.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095



--- Comment #3 from Mario Blättermann  ---
OK, I've changed the shebangs to python2, in case of doclifter even without
/usr/bin/env.

New files:
Spec URL: http://mariobl.fedorapeople.org/Review/SPECS/doclifter.spec
SRPM URL:
http://mariobl.fedorapeople.org/Review/SRPMS/doclifter-2.13-2.fc19.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095

Christopher Meng  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Christopher Meng  ---
PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095

Mario Blättermann  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Mario Blättermann  ---
Many thanks for the review!

New Package SCM Request
===
Package Name: doclifter
Short Description: Translates documents written in troff macros to DocBook
Owners: mariobl
Branches: f19 f20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885



--- Comment #8 from Matthias Runge  ---
Actually, it is available:
http://koji.fedoraproject.org/koji/packageinfo?packageID=14887

(for fedora 21 aka rawhide). Stable policy forbids to upgrade the version for
f20 and older.

Since it's required the package builds on rawhide, you can add the check and
skip it for later versions ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 635126] Review Request: rubygem-test-unit - Improved version of Test::Unit bundled in Ruby 1.8.x

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=635126

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 635126] Review Request: rubygem-test-unit - Improved version of Test::Unit bundled in Ruby 1.8.x

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=635126



--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 834127] Review Request: VirtualGL - A toolkit for displaying OpenGL applications to thin clients

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=834127

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 834127] Review Request: VirtualGL - A toolkit for displaying OpenGL applications to thin clients

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=834127



--- Comment #69 from Jon Ciesla  ---
Branch for EL-6 already exists.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=878556



--- Comment #20 from Jon Ciesla  ---
Git done (by process-git-requests).

Correctly formatted branches.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 878556] Review Request: rubygem-simplecov - Code coverage analysis tool for Ruby 1.9

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=878556

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894586] Review Request: coin-or-Osi - COIN-OR Open Solver Interface Library

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894586

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894586] Review Request: coin-or-Osi - COIN-OR Open Solver Interface Library

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894586



--- Comment #11 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 977128] Review Request: nodejs-grunt - The JavaScript Task Runner

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=977128



--- Comment #7 from Jon Ciesla  ---
No SCM request found, unsetting flag.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 977128] Review Request: nodejs-grunt - The JavaScript Task Runner

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=977128

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996489] Review Request: rubygem-tins - Useful tools library in Ruby

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=996489

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 996489] Review Request: rubygem-tins - Useful tools library in Ruby

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=996489



--- Comment #15 from Jon Ciesla  ---
Git done (by process-git-requests).

Corrected branch formatting.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1004231

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1004231] Review Request: lv2-sorcer - a wave-table synthesizer plugin

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1004231



--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1007099] Review Request: ardour3 - Digital Audio Workstation

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1007099

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1007099] Review Request: ardour3 - Digital Audio Workstation

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1007099



--- Comment #30 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015261] Review Request: rubygem-just_paginate - Paginating collections of things for the web

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015261

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015261] Review Request: rubygem-just_paginate - Paginating collections of things for the web

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015261



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015326] Review Request: rubygem-hipchat - Ruby library to interact with HipChat

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015326

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015326] Review Request: rubygem-hipchat - Ruby library to interact with HipChat

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015326



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095

Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de



--- Comment #6 from Ralf Corsepius  ---
Does this package also work with python3?

To me, it doesn't make much sense to introduce new python2 packages into Fedora
at this point in time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018004] Review Request: rubygem-descendants_tracker - Module that adds descendant tracking to a class

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018004



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018010] Review Request: rubygem-rails_autolink - Automatic generation of HTML links in texts

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018010

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018004] Review Request: rubygem-descendants_tracker - Module that adds descendant tracking to a class

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018004

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018010] Review Request: rubygem-rails_autolink - Automatic generation of HTML links in texts

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018010



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021261



--- Comment #12 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021261

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025368] Review Request: python-jira - A library to ease use of the JIRA 5 REST APIs.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025368

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025368] Review Request: python-jira - A library to ease use of the JIRA 5 REST APIs.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025368



--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025928] Review Request: rubygem-ice_nine - Deep Freeze Ruby Objects

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025928

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025928] Review Request: rubygem-ice_nine - Deep Freeze Ruby Objects

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025928



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025930] Review Request: rubygem-equalizer - Module to define equality, equivalence and inspection methods

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025930

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025930] Review Request: rubygem-equalizer - Module to define equality, equivalence and inspection methods

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025930



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025984] Review Request: rubygem-redis-namespace - Namespaces Redis commands

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025984



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025984] Review Request: rubygem-redis-namespace - Namespaces Redis commands

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025984

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026337] New: Review Requiest: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026337

Bug ID: 1026337
   Summary: Review Requiest: nfs-ganesha — a user-mode file server
for NFS (v3, 4.0,4.1 pNFS)
   Product: Fedora
   Version: 19
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: kkeit...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL: http://kkeithle.fedorapeople.org/nfs-ganesha.spec
SRPM URL: http://kkeithle.fedorapeople.org/nfs-ganesha-2.0.0-0.rc2.fc19.src.rpm

Description: Nfs-ganesha is a user-mode file server for NFS (v3, 4.0,4.1 pNFS)

 +:ok, =:needs attention, -:needs fixing

MUST Items:
[+] MUST: rpmlint must be run on every package.

rpmlint SPECS/nfs-ganesha.spec SRPMS/nfs-ganesha-2.0.0-0.rc2.fc19.src.rpm
RPMS/x86_64/nfs-ganesha-2.0.0-0.rc2.fc19.x86_64.rpm 
SPECS/nfs-ganesha.spec:50: W: rpm-buildroot-usage %prep cmake
-DCMAKE_BUILD_TYPE=Maintainer -DDEBUG_SYMS=ON -DBUILD_CONFIG=everything
-DCMAKE_INSTALL_PREFIX=%{buildroot}/usr ./src
nfs-ganesha.src: W: spelling-error %description -l en_US pNFS -> snuffs
nfs-ganesha.src:50: W: rpm-buildroot-usage %prep cmake
-DCMAKE_BUILD_TYPE=Maintainer -DDEBUG_SYMS=ON -DBUILD_CONFIG=everything
-DCMAKE_INSTALL_PREFIX=%{buildroot}/usr ./src
nfs-ganesha.x86_64: W: spelling-error %description -l en_US pNFS -> snuffs
nfs-ganesha.x86_64: W: no-manual-page-for-binary ganesha.nfsd
nfs-ganesha.x86_64: W: no-manual-page-for-binary ganestat.pl
2 packages and 1 specfiles checked; 0 errors, 6 warnings.

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL.

7d9352877359d53e89156ba7bfcb1a7d  libntirpc-0.1.11.tgz
06876b2c54c2d8e666f58a96738e3863  nfs-ganesha-2.0.0rc2.tgz

[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro.
[+] MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
[+] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
[+] MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: Each package must consistently use macros, as described in the macros
section of Packaging Guidelines.
[+] MUST: The package must contain code, or permissible content. This is
described in detail in the code vs. content section of Packaging Guidelines.
[+] MUST: Large documentation files should go in a doc subpackage.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Header files must be in a -devel package.
[+] MUST: Static libraries must be in a -static package.
[+] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
[+] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.
[+] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release} 
[+] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec.
[+] MUST: Packages containi

[Bug 1026337] Review Requiest: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026337

Kaleb KEITHLEY  changed:

   What|Removed |Added

   Priority|unspecified |medium
   Hardware|Unspecified |All



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026095] Review Request: doclifter - Translates documents written in troff macros to DocBook

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026095



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026342] New: Review Request: springframework-retry - Abstraction around retrying failed operations

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026342

Bug ID: 1026342
   Summary: Review Request: springframework-retry - Abstraction
around retrying failed operations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL: http://msrb.fedorapeople.org/review/springframework-retry.spec
SRPM URL:
http://msrb.fedorapeople.org/review/springframework-retry-1.0.3-1.fc21.src.rpm
Description: Spring Retry provides an abstraction around retrying failed
operations, 
with an emphasis on declarative control of the process and policy-based 
bahaviour that is easy to extend and customize. For instance, you can 
configure a plain POJO operation to retry if it fails, based on the type 
of exception, and with a fixed or exponential backoff.
Fedora Account System Username: msrb

Note this is package rename review request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002151] Review Request: jts - Java Topology Suite

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002151

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||m...@redhat.com
   Assignee|nob...@fedoraproject.org|m...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016753] Review Request: nodejs-bson - bson parser for node.js

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1016753

Marek Mahut  changed:

   What|Removed |Added

 CC||mma...@redhat.com
  Flags||needinfo?(yohangraterol92@g
   ||mail.com)



--- Comment #6 from Marek Mahut  ---
Yohan, any updates on this review request, please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016770] Review Request: nodejs-nan - Native Abstractions for Node.js

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1016770

Marek Mahut  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mma...@redhat.com
   Assignee|nob...@fedoraproject.org|mma...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002151] Review Request: jts - Java Topology Suite

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002151

Michal Srb  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #2 from Michal Srb  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
 when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: SourceX tarball generation or download is documented.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all suppo

[Bug 1023774] Review Request: golang-github-goerlang-port - Simple API to write Erlang ports in Go

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023774

Peter Lemenkov  changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023772] Review Request: golang-github-goerlang-etf - Erlang external term format encoding/decoding for Go

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023772

Peter Lemenkov  changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023773] Review Request: golang-github-goerlang-node - An implementation of Erlang node

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023773

Peter Lemenkov  changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023769

Peter Lemenkov  changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023771] Review Request: golang-github-goerlang-epmd - Erlang Port Mapper Daemon protocol

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023771

Peter Lemenkov  changed:

   What|Removed |Added

 Depends On||1010713




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1010713
[Bug 1010713] create and own %{_datadir}/gocode and %{_datadir}/gocode/src
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026342] Review Request: springframework-retry - Abstraction around retrying failed operations

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026342

Michal Srb  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1016753] Review Request: nodejs-bson - bson parser for node.js

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1016753

Yohan Graterol  changed:

   What|Removed |Added

  Flags|needinfo?(yohangraterol92@g |
   |mail.com)   |



--- Comment #7 from Yohan Graterol  ---
Hello Marek,

I waiting to nodejs-nan [0]

[0] https://bugzilla.redhat.com/show_bug.cgi?id=1016770

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021261



--- Comment #13 from Fedora Update System  ---
kipi-plugins-elegant-theme-1.4.0-2.fc19 has been submitted as an update for
Fedora 19.
https://admin.fedoraproject.org/updates/kipi-plugins-elegant-theme-1.4.0-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021261

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026376] New: Review Request: fontawesome-fonts - Iconic font set

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026376

Bug ID: 1026376
   Summary: Review Request: fontawesome-fonts - Iconic font set
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rle...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL:
http://ryanlerch.fedorapeople.org/packaging/fontawesome/fontawesome-fonts.spec
SRPM URL:
http://ryanlerch.fedorapeople.org/packaging/fontawesome/fontawesome-fonts-4.0.0-1.fc20.src.rpm
Description: Font Awesome gives you scalable vector icons that can instantly be 
customized — size, color, drop shadow, and anything that can be done with the 
power of CSS.
Fedora Account System Username: ryanlerch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021261] Review Request: kipi-plugins-elegant-theme - elegant theme for html export

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021261



--- Comment #14 from Fedora Update System  ---
kipi-plugins-elegant-theme-1.4.0-2.fc20 has been submitted as an update for
Fedora 20.
https://admin.fedoraproject.org/updates/kipi-plugins-elegant-theme-1.4.0-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026380] New: Review Request: corebird - Native GTK Twitter client

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026380

Bug ID: 1026380
   Summary: Review Request: corebird - Native GTK Twitter client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rle...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL: http://ryanlerch.fedorapeople.org/packaging/corebird/corebird.spec
SRPM URL:
http://ryanlerch.fedorapeople.org/packaging/corebird/corebird-0.3-20131101git2e2962f.fc20.src.rpm
Description: Native GTK Twitter client for the Linux desktop.
Fedora Account System Username: ryanlerch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885



--- Comment #9 from Jakub Ruzicka  ---
Created attachment 819183
  --> https://bugzilla.redhat.com/attachment.cgi?id=819183&action=edit
WIP %check

With rawhide tox 1.6.1 I get only a little further:

+ ./run_tests.sh
py27 create: /builddir/build/BUILD/python-openstackclient-0.2.2/.tox/py27   
py27 installdeps:
-r/builddir/build/BUILD/python-openstackclient-0.2.2/requirements.txt,
-r/builddir/build/BUILD/python-openstackclient-0.2.2/test-requirements.txt
py27 develop-inst: /builddir/build/BUILD/python-openstackclient-0.2.2   
py27 runtests: commands[0] | python setup.py testr --testr-args=
/usr/lib64/python2.7/distutils/dist.py:267: UserWarning: Unknown distribution
option: 'pbr'
  warnings.warn(msg)
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]   
   or: setup.py --help [cmd1 cmd2 ...]  
   or: setup.py --help-commands 
   or: setup.py cmd --help  
error: invalid command 'testr'  
ERROR: InvocationError:
'/builddir/build/BUILD/python-openstackclient-0.2.2/.tox/py27/bin/python
setup.py testr --testr-args='
___ summary

ERROR:   py27: commands failed  
chyba: Špatný návratový kód z /var/tmp/rpm-tm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1002154] Review Request: spatial4j - A Geospatial Library for Java

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1002154



--- Comment #1 from Michal Srb  ---
I am not doing full review yet, but from quick look at the spec file:

- ASL license text is missing
- "%mvn_file : %{name}" should be moved to %prep section

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026337] Review Requiest: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026337

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025977] Review Request: captcp - TCP Analyzer for PCAP Files

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025977

Mikolaj Izdebski  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mizde...@redhat.com
 Blocks|177841 (FE-NEEDSPONSOR) |
   Assignee|nob...@fedoraproject.org|mizde...@redhat.com
  Flags||fedora-review?



--- Comment #8 from Mikolaj Izdebski  ---
(In reply to Michele Baldessari from comment #5)
> It's rpmlint that is unfortunately not smart enough, the patch has been
> applied. Patch has been sent upstream but has not been applied there yet. 
> I tend to avoid %patch because 'git am' fits nicely in my workflow and
> brings the same result (like the x11 folks do)
> I've added a comment about the patch.

I understand that you may prefer "git am", I prefer it too, but that's not how
patches are applied in Fedora.  And there is a reason for that. Packages need
to follow common practices.  If every package had its own way of doing
everything then it would be hard to understand what they are doing and maintain
them.  In other words, when submitting a package to Fedora sometimes you need
to sacrifice some of your individual preferences in favor of distribution
practices.

chmod calls in %install should be avoided, please use %attr macro in %files
section instead.

You are packaging version 1.6, why not use this tarball?
http://github.com/hgn/%{name}/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
If you use it then you'll be able to get riod of commit and shortcommit macros
as well as reduce %setup macro call to just "%setup -q".

You are mixing some macro styles: %SOURCE2 vs %{_bindir}.  Please either use
%{SOURCE2} and %{_bindir} or %SOURCE2 and %_bindir (the first option if
preferred).

After having a quick look I think that license tag should be "GPL+" instead of
"GPLv3" as there is no explicit GPL version specified ("If the Program does not
specify a version number of the GNU General Public License, you may choose any
version ever published by the Free Software Foundation.").

There is some bundled MIT-licensed code in documentation.  It should either be
removed or its licensing corrected (which means installing license file as
documentation and adding "MIT" to license tag).


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 815001] Review Request: opennebula - Cloud computing tool to manage a distributed virtual data center to build private, public and hybrid IaaS clouds

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=815001

Haïkel Guémar  changed:

   What|Removed |Added

 CC||karlthe...@gmail.com
   Assignee|shawn.st...@rogers.com  |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025977] Review Request: captcp - TCP Analyzer for PCAP Files

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025977



--- Comment #9 from Mikolaj Izdebski  ---
(In reply to Mikolaj Izdebski from comment #8)
> After having a quick look I think that license tag should be "GPL+" instead
> of "GPLv3" as there is no explicit GPL version specified ("If the Program
> does not specify a version number of the GNU General Public License, you may
> choose any version ever published by the Free Software Foundation.").

After more detailed licensing review it looks like there is GPLv2+ code too,
making effective license tag "GPL+ and GPLv2+"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 693608] Review Request: icinga - Open Source host, service and network monitoring program

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=693608

Shawn Starr  changed:

   What|Removed |Added

   Assignee|shawn.st...@rogers.com  |nob...@fedoraproject.org



--- Comment #48 from Shawn Starr  ---
reset owner, reviewer will change this.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026337] Review Requiest: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026337



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
1. Remove %defattr(-,root,root)

2. Remove rm -rf %{buildroot}

3. Remove %clean

4. Why are libntirpc sources necessary? Shouldn't this be a separate package?

5. It would be nicer to use direct github url as Source0:
https://github.com/%{name}/%{name}/archive/pre-2.0-RC2.tar.gz. This way it's
easier to update, verify sources, etc.

6. %description could become Summary, and please extend the description a bit,
saying a bit more what the project is useful for etc.

8. There's no need to say %{__tar}, %{__rm}, %{__make}, %{__chmod}. Just use
plain tar, rm... Such indirection only makes sense for things that are likely
to be substituted at some point, like %{__python2}.

9. Please add Provides: bundled(gnulib).

10. Please split out big docs into a separate package (size ~ 2MB).

11. Please change cmake to %cmake.

12. Please change %{__make} to make VERBOSE=1 %{?_smp_mflags}.

13. libzfswrap cannot be bundled
(https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries). Please remove
it in %prep.

Oh, and I think you have a very old fedora-review, which is provided outdated
suggestions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894587] Review Request: coin-or-Clp - Coin-or linear programming

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894587



--- Comment #5 from Antonio Trande  ---
Hi Paulo.

There is a disagreement between the source archive 1.15.3 included in your src
rpm and that one provided by the upstream
http://www.coin-or.org/download/source/Clp/Clp-1.15.3.tgz (even though they
have the same release number).

In that one from the upstream website, there are various bundled software in
the ThirdParty directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026139] Review Request: appstream - Utilities to generate, maintain and access the AppStream Xapian database

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026139



--- Comment #2 from Rex Dieter  ---
Spec URL: http://rdieter.fedorapeople.org/rpms/appstream/appstream.spec
SRPM URL:
http://rdieter.fedorapeople.org/rpms/appstream/appstream-0.4.0-2.fc20.src.rpm

%changelog
* Mon Nov 04 2013 Rex Dieter  0.4.0-2
- -vala subpkg
- own %%{_libdir}/girepository-1.0, %%{_libdir}/packagekit-plugins (until
someone better comes along)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 894587] Review Request: coin-or-Clp - Coin-or linear programming

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=894587



--- Comment #6 from Antonio Trande  ---
(In reply to Antonio Trande from comment #5)
> Hi Paulo.
> 
> There is a disagreement between the source archive 1.15.3 included in your
> src rpm and that one provided by the upstream
> http://www.coin-or.org/download/source/Clp/Clp-1.15.3.tgz (even though they
> have the same release number).
> 
> In that one from the upstream website, there are various bundled software in
> the ThirdParty directory.

I hadn't read your comment#1.
Forget about my last comment. :P

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292



--- Comment #9 from Fedora Update System  ---
python-twiggy-0.4.5-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-twiggy-0.4.5-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292



--- Comment #10 from Fedora Update System  ---
python-twiggy-0.4.5-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/python-twiggy-0.4.5-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025292] Review Request: python-twiggy - A Pythonic logger

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025292



--- Comment #8 from Fedora Update System  ---
python-twiggy-0.4.5-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-twiggy-0.4.5-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026432] New: Review Request: ghc-pcap - Haskell bindings for libpcap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026432

Bug ID: 1026432
   Summary: Review Request: ghc-pcap - Haskell bindings for
libpcap
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: bugzi...@tecnocode.co.uk
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL: http://people.collabora.co.uk/~pwith/packaging/ghc-pcap.spec
SRPM URL:
http://people.collabora.co.uk/~pwith/packaging/ghc-pcap-0.4.5.2-1.fc19.src.rpm
Description: A system-independent interface for user-level packet capture.
Fedora Account System Username: pwithnall
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6136274

This is my first package and I need a sponsor. I’m not the upstream maintainer,
and am not a Haskell developer; I am merely packaging this as a dependency of
Bustle (http://willthompson.co.uk/bustle/).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026432] Review Request: ghc-pcap - Haskell bindings for libpcap

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026432

Philip Withnall  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025368] Review Request: python-jira - A library to ease use of the JIRA 5 REST APIs.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025368



--- Comment #7 from Fedora Update System  ---
python-jira-0.13-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-jira-0.13-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025368] Review Request: python-jira - A library to ease use of the JIRA 5 REST APIs.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025368

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025368] Review Request: python-jira - A library to ease use of the JIRA 5 REST APIs.

2013-11-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025368



--- Comment #8 from Fedora Update System  ---
python-jira-0.13-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-jira-0.13-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   3   >