[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 Ivan Romanov dr...@land.ru changed: What|Removed |Added CC|package-review@lists.fedora | |project.org | CC||dr...@land.ru --- Comment #14 from Ivan Romanov dr...@land.ru --- Remove Group: Applications/Internet. It is not used anymore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 --- Comment #15 from Ivan Romanov dr...@land.ru --- https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Group_tag -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1005459] Rename Review: wmdocker - KDE and GNOME2 system tray replacement docking application
https://bugzilla.redhat.com/show_bug.cgi?id=1005459 Andreas Bierfert andreas.bierf...@lowlatency.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Andreas Bierfert andreas.bierf...@lowlatency.de --- New Package SCM Request === Package Name: wmdocker Short Description: KDE and GNOME2 system tray replacement docking application Owners: awjb Branches: f20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 --- Comment #16 from Ivan Romanov dr...@land.ru --- Rename all QT to Qt. QT is not correct. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030107] Review Request: apitrace - Tools for tracing OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=1030107
--- Comment #5 from Sandro Mani manisan...@gmail.com ---
Thanks!
Spec URL: http://smani.fedorapeople.org/review/apitrace.spec
SRPM URL: http://smani.fedorapeople.org/review/apitrace-4.0-2.fc21.src.rpm
* Sat Nov 16 2013 Sandro Mani manisan...@gmail.com - 4.0-2
- Fix %%{_buildroot} - %%{buildroot} typo
- Remove explicit BRs which are implicit
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 --- Comment #17 from Ivan Romanov dr...@land.ru --- In description use GTK+ 3 not Gtk and not GTK3. Probably gtk subpackage should be renamed to gtk3 (because it uses GTK+ 3 library and requires gtk3 package) -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 --- Comment #18 from Ivan Romanov dr...@land.ru --- Why you don't use cli-xmlrpc -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030107] Review Request: apitrace - Tools for tracing OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=1030107 --- Comment #6 from Sandro Mani manisan...@gmail.com --- F19 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6187543 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821406] Review Request: eiskaltdcpp - QT Direct Connect client
https://bugzilla.redhat.com/show_bug.cgi?id=821406 --- Comment #19 from Ivan Romanov dr...@land.ru --- drop -DCMAKE_BUILD_TYPE=RelWithDebInfo. %cmake allready has CFLAGS and CXXFLAGS -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030107] Review Request: apitrace - Tools for tracing OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=1030107
--- Comment #7 from Ivan Romanov dr...@land.ru ---
# Install desktop file
desktop-file-install
--dir=%{buildroot}%{_datadir}/applications/qapitrace.desktop %{SOURCE1}
It is not work as you want. This command make
%{buildroot}%{_datadir}/applications/qapitrace.desktop dir and put
apitrace.desktop to this dir. So your desktop file after installing package
will be /usr/share/applications/qapitrace.desktop/apitrace.desktop
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972943] Review Request: lpf - Local package factory - build non-redistributable rpms
https://bugzilla.redhat.com/show_bug.cgi?id=972943 --- Comment #28 from Fedora Update System upda...@fedoraproject.org --- lpf-0-10.d18db6d.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/lpf-0-10.d18db6d.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026922] Review Request: ramond - Router advertisement monitoring daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1026922 Michael Scherer m...@zarb.org changed: What|Removed |Added CC||m...@zarb.org Assignee|nob...@fedoraproject.org|m...@zarb.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026922] Review Request: ramond - Router advertisement monitoring daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1026922
Michael Scherer m...@zarb.org changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Michael Scherer m...@zarb.org ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
- the patch should be sent upstream, with a comment. but given upstream seems
dormant and the patch is justified, i will not block on this, and accept the
package.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 9 files have unknown license. Detailed output of
licensecheck in
/home/misc/checkout/git/FedoraReview/1026922-ramond/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all
[Bug 1031250] Review Request: librcd - Library for autodection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 518317] Review Request: perdition - Mail Retrieval Proxy
https://bugzilla.redhat.com/show_bug.cgi?id=518317 --- Comment #29 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Ok, patch applied: https://github.com/Hubbitus/Fedora-packaging/commit/254026856dbec79ad716b58729e09f5b0363c922 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031078] Review Request: subnetcalc - An IPv4/IPv6 Subnet Calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1031078 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Christopher Meng cicku...@gmail.com --- Thank you s much! New Package SCM Request === Package Name: subnetcalc Short Description: An IPv4/IPv6 Subnet Calculator Owners: cicku Branches: f20 f19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026922] Review Request: ramond - Router advertisement monitoring daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1026922 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com --- Comment #2 from Christopher Meng cicku...@gmail.com --- Advice: You can move %global to the top so it will look more like global ;) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Mario Blättermann mario.blaetterm...@gmail.com --- $ rpmlint -i -v * librcd.src: I: checking librcd.src: W: spelling-error Summary(en_US) autodection - detection The value of this tag appears to be misspelled. Please double-check. librcd.src: W: spelling-error Summary(en_US) charset - char set, char-set, catharses The value of this tag appears to be misspelled. Please double-check. librcd.src: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd.src: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd.src: I: checking-url http://dside.dyndns.org/files/rusxmms/librcd-0.1.14.tar.bz2 (timeout 10 seconds) librcd.armv7hl: I: checking librcd.armv7hl: W: spelling-error Summary(en_US) autodection - detection The value of this tag appears to be misspelled. Please double-check. librcd.armv7hl: W: spelling-error Summary(en_US) charset - char set, char-set, catharses The value of this tag appears to be misspelled. Please double-check. librcd.armv7hl: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd.armv7hl: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd.i686: I: checking librcd.i686: W: spelling-error Summary(en_US) autodection - detection The value of this tag appears to be misspelled. Please double-check. librcd.i686: W: spelling-error Summary(en_US) charset - char set, char-set, catharses The value of this tag appears to be misspelled. Please double-check. librcd.i686: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd.i686: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd.x86_64: I: checking librcd.x86_64: W: spelling-error Summary(en_US) autodection - detection The value of this tag appears to be misspelled. Please double-check. librcd.x86_64: W: spelling-error Summary(en_US) charset - char set, char-set, catharses The value of this tag appears to be misspelled. Please double-check. librcd.x86_64: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd.x86_64: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) (none): E: no installed packages by name librcd-0.1.14.tar.bz2 librcd-debuginfo.armv7hl: I: checking librcd-debuginfo.armv7hl: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-debuginfo.i686: I: checking librcd-debuginfo.i686: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-debuginfo.x86_64: I: checking librcd-debuginfo.x86_64: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-devel.armv7hl: I: checking librcd-devel.armv7hl: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd-devel.armv7hl: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-devel.armv7hl: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. librcd-devel.i686: I: checking librcd-devel.i686: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd-devel.i686: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-devel.i686: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. librcd-devel.x86_64: I: checking librcd-devel.x86_64: W: spelling-error %description -l en_US cyrillic - Cyrillic The value of this tag appears to be misspelled. Please double-check. librcd-devel.x86_64: I: checking-url http://rusxmms.sourceforge.net (timeout 10 seconds) librcd-devel.x86_64: W: no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files. librcd.spec: I: checking-url http://dside.dyndns.org/files/rusxmms/librcd-0.1.14.tar.bz2 (timeout 10 seconds) 10 packages and 1 specfiles checked; 0 errors, 18 warnings. Some spelling errors: autodection autodetection or automatic detection cyrillic Cyrillic (to be considered as a language name which needs to be capitalized) You might add the ChangeLog file to the -devel package. It is not of real interest for users, but maybe for developers. - key: [+] OK [.] OK, not applicable [X] needs work - [+] MUST: rpmlint must be
[Bug 518317] Review Request: perdition - Mail Retrieval Proxy
https://bugzilla.redhat.com/show_bug.cgi?id=518317 --- Comment #30 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Spec: https://raw.github.com/Hubbitus/Fedora-packaging/254026856dbec79ad716b58729e09f5b0363c922/SPECS/perdition.spec Srpm: http://hubbitus.info/rpm/Fedora19/perdition/perdition-2.0-2.fc19.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6188063 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027506] Review Request: python-proboscis - A test framework that extends Python's built-in unit test
https://bugzilla.redhat.com/show_bug.cgi?id=1027506 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #9 from Mario Blättermann mario.blaetterm...@gmail.com --- Packages for the requested branches are now in the testing repos. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039 --- Comment #6 from Mario Blättermann mario.blaetterm...@gmail.com --- Any news here...? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 989791] Review Request: doublecmd-qt4 - Twin-panel (commander-style) file manager(Qt4)
https://bugzilla.redhat.com/show_bug.cgi?id=989791 --- Comment #8 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to Mario Blättermann from comment #7) Any progress here...? Same question again...? Anyway, you should open a new review ticket for doublecmd and mark doublecmd-qt4 and doublecmd-gtk2 as duplicates. In fact both of the current tickets are NotReady. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030710] Review Request: python-pgpdump - PGP packet parser library in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1030710 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||mario.blaetterm...@gmail.co ||m Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026922] Review Request: ramond - Router advertisement monitoring daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1026922 --- Comment #3 from Michael Scherer m...@zarb.org --- I also have a selinux policy for ramond, but I am not sure how we should handle the fact this can and should run commands ( ie, what kind of access should the command have ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #3 from Ivan Romanov dr...@land.ru --- thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030710] Review Request: python-pgpdump - PGP packet parser library in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1030710
Mario Blättermann mario.blaetterm...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6188123
$ rpmlint -i -v *python3-pgpdump.noarch: I: checking
python3-pgpdump.noarch: I: checking-url http://www.mew.org/~kazu/proj/pgpdump/
(timeout 10 seconds)
python-pgpdump.noarch: I: checking
python-pgpdump.noarch: I: checking-url http://www.mew.org/~kazu/proj/pgpdump/
(timeout 10 seconds)
python-pgpdump.src: I: checking
python-pgpdump.src: I: checking-url http://www.mew.org/~kazu/proj/pgpdump/
(timeout 10 seconds)
python-pgpdump.src: I: checking-url
https://pypi.python.org/packages/source/p/pgpdump/pgpdump-1.4.tar.gz (timeout
10 seconds)
python-pgpdump.spec: I: checking-url
https://pypi.python.org/packages/source/p/pgpdump/pgpdump-1.4.tar.gz (timeout
10 seconds)
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
No issues.
-
key:
[+] OK
[.] OK, not applicable
[X] needs work
-
[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
BSD
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use sha256sum for this task as it
is used by the sources file once imported into git. If no upstream URL can be
specified for this package, please see the Source URL Guidelines for how to
deal with this.
$ sha256sum *
d1aae24e3a6841239363dc52744dff3bcd766dab590dbafbb1ad70a8c100a657
pgpdump-1.4.tar.gz
d1aae24e3a6841239363dc52744dff3bcd766dab590dbafbb1ad70a8c100a657
pgpdump-1.4.tar.gz.orig
[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
[+] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
[.] MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[.] MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
[+] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory.
[+] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)
[+] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity).
[+] MUST: If a package includes something as %doc, it must
[Bug 1031250] Review Request: librcd - Library for autodection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Ivan Romanov dr...@land.ru changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Ivan Romanov dr...@land.ru --- New Package SCM Request === Package Name: librcd Short Description: Library for autodetection charset of Russian and Ukrainian text Owners: ivanromanov Branches: f18 f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Mario Blättermann mario.blaetterm...@gmail.com changed: What|Removed |Added Summary|Review Request: librcd -|Review Request: librcd - |Library for autodection |Library for autodetection |charset of Russian and |charset of Russian and |Ukrainian text |Ukrainian text -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #5 from Ivan Romanov dr...@land.ru --- yeah I allready have corrected it in my package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #6 from Ivan Romanov dr...@land.ru --- hm ... rpmlint says librcd.x86_64: W: spelling-error Summary(en_US) autodetection - auto detection, auto-detection, detection -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #7 from Mario Blättermann mario.blaetterm...@gmail.com --- (In reply to Ivan Romanov from comment #6) hm ... rpmlint says librcd.x86_64: W: spelling-error Summary(en_US) autodetection - auto detection, auto-detection, detection Then just use that what rpmlint proposes. I would prefer auto detection. Please don't forget to change the bug summary, as I did. If the summary in the ticket and the SCM request differ, the Git people will complain. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #8 from Ivan Romanov dr...@land.ru --- librcd.src: W: spelling-error Summary(en_US) charset - char set, char-set, catharses In this case what do you prefer? char set or char-set? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 --- Comment #9 from Ivan Romanov dr...@land.ru --- Hm ... I try to use wikipedia http://en.wikipedia.org/wiki/Autodetection http://en.wikipedia.org/wiki/Charset In the content you can find charset not char set and not char-set -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 998141] Review Request: sdformat - The Simulation Description Format
https://bugzilla.redhat.com/show_bug.cgi?id=998141 --- Comment #15 from Rich Mattes richmat...@gmail.com --- Updated to version 1.4.10 Spec URL: http://rmattes.fedorapeople.org/RPMS/sdformat/sdformat.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/sdformat/sdformat-1.4.10-1.fc20.src.rpm scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6188236 rpmlint: $ rpmlint sdformat.spec ../RPMS/x86_64/sdformat* sdformat.x86_64: W: spelling-error %description -l en_US sdf - sf, SD 3 packages and 1 specfiles checked; 0 errors, 1 warnings. I added a BuildRequires on tinyxml-devel, and the unit tests are now passing for me with release 1.4.10 but they're failing on koji for i686. I've made them informational for now while I figure out what's going on. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016753] Review Request: nodejs-bson - bson parser for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1016753 --- Comment #9 from Yohan Graterol yohangratero...@gmail.com --- You're right Troy, yes built in Fedora. But you do need rebuild the srpm, because upstream did a change and that provoke an error with MD5 checksum. Upstream only did a change, not up the version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030107] Review Request: apitrace - Tools for tracing OpenGL
https://bugzilla.redhat.com/show_bug.cgi?id=1030107 --- Comment #8 from Sandro Mani manisan...@gmail.com --- Thanks for catching that, it was already wrong in a previous package. Spec URL: http://smani.fedorapeople.org/review/apitrace.spec SRPM URL: http://smani.fedorapeople.org/review/apitrace-4.0-3.fc21.src.rpm * Sat Nov 16 2013 Sandro Mani manisan...@gmail.com - 4.0-3 - Fix desktop-file-install syntax -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1030710] Review Request: python-pgpdump - PGP packet parser library in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1030710 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Christopher Meng cicku...@gmail.com --- Thanks! New Package SCM Request === Package Name: python-pgpdump Short Description: PGP packet parser library in Python Owners: cicku Branches: f20 f19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031314] New: Review Request: rubygem-hikidoc - Text-to-HTML conversion tool for web writers
https://bugzilla.redhat.com/show_bug.cgi?id=1031314 Bug ID: 1031314 Summary: Review Request: rubygem-hikidoc - Text-to-HTML conversion tool for web writers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-hikidoc.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-hikidoc-0.0.6-1.fc.src.rpm Description: 'HikiDoc' is a text-to-HTML conversion tool for web writers. HikiDoc allows you to write using an easy-to-read, easy-to-write plain text format, then convert it to structurally valid HTML (or XHTML). Fedora Account System Username: mtasaka Copr build: http://copr-be.cloud.fedoraproject.org/results/mtasaka/rabbit-test/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031315] New: Review Request: rubygem-kramdown - Fast, pure-Ruby Markdown-superset converter
https://bugzilla.redhat.com/show_bug.cgi?id=1031315 Bug ID: 1031315 Summary: Review Request: rubygem-kramdown - Fast, pure-Ruby Markdown-superset converter Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-kramdown.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-kramdown-1.2.0-1.fc.src.rpm Description: kramdown is yet-another-markdown-parser but fast, pure Ruby, using a strict syntax definition and supporting several common extensions. Fedora Account System Username: mtasaka Copr build: http://copr-be.cloud.fedoraproject.org/results/mtasaka/rabbit-test/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031316] New: Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 Bug ID: 1031316 Summary: Review Request: rubygem-rdtool - Formatter for RD Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rdtool.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rdtool-0.6.38-1.fc.src.rpm Description: RD is multipurpose documentation format created for documentating Ruby and output of Ruby world. You can embed RD into Ruby script. And RD have neat syntax which help you to read document in Ruby script. On the other hand, RD have a feature for class reference. Fedora Account System Username: mtasaka Copr build: http://copr-be.cloud.fedoraproject.org/results/mtasaka/rabbit-test/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031317] New: Review Request: rubygem-rttool - Converter from RT into various formats
https://bugzilla.redhat.com/show_bug.cgi?id=1031317 Bug ID: 1031317 Summary: Review Request: rubygem-rttool - Converter from RT into various formats Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rttool.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rttool-1.0.3.0-1.fc.src.rpm Description: RT is a simple and human-readable table format. RTtool is a converter from RT into various formats. RT can be incorporated into RD. Fedora Account System Username: mtasaka Copr build: http://copr-be.cloud.fedoraproject.org/results/mtasaka/rabbit-test/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031317] Review Request: rubygem-rttool - Converter from RT into various formats
https://bugzilla.redhat.com/show_bug.cgi?id=1031317 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Depends On||1031316 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031316 [Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1031317 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031317 [Bug 1031317] Review Request: rubygem-rttool - Converter from RT into various formats -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031318] New: Review Request: rubygem-rabbit - RD-document-based presentation application
https://bugzilla.redhat.com/show_bug.cgi?id=1031318 Bug ID: 1031318 Summary: Review Request: rubygem-rabbit - RD-document-based presentation application Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rabbit.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-rabbit-2.1.1-1.fc.src.rpm Description: Rabbit is an RD-document-based presentation application. Fedora Account System Username: mtasaka Copr build: http://copr-be.cloud.fedoraproject.org/results/mtasaka/rabbit-test/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031315] Review Request: rubygem-kramdown - Fast, pure-Ruby Markdown-superset converter
https://bugzilla.redhat.com/show_bug.cgi?id=1031315 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1031318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031318 [Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967337] Review Request: rubygem-faraday - HTTP/REST API client library
https://bugzilla.redhat.com/show_bug.cgi?id=967337 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1031318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031318 [Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031317] Review Request: rubygem-rttool - Converter from RT into various formats
https://bugzilla.redhat.com/show_bug.cgi?id=1031317 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1031318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031318 [Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application
https://bugzilla.redhat.com/show_bug.cgi?id=1031318 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Depends On||967337, 1031317, 1031315, ||1031314 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=967337 [Bug 967337] Review Request: rubygem-faraday - HTTP/REST API client library https://bugzilla.redhat.com/show_bug.cgi?id=1031314 [Bug 1031314] Review Request: rubygem-hikidoc - Text-to-HTML conversion tool for web writers https://bugzilla.redhat.com/show_bug.cgi?id=1031315 [Bug 1031315] Review Request: rubygem-kramdown - Fast, pure-Ruby Markdown-superset converter https://bugzilla.redhat.com/show_bug.cgi?id=1031317 [Bug 1031317] Review Request: rubygem-rttool - Converter from RT into various formats -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031314] Review Request: rubygem-hikidoc - Text-to-HTML conversion tool for web writers
https://bugzilla.redhat.com/show_bug.cgi?id=1031314 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Blocks||1031318 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1031318 [Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967337] Review Request: rubygem-faraday - HTTP/REST API client library
https://bugzilla.redhat.com/show_bug.cgi?id=967337 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Flags||needinfo?(anujmorex@gmail.c ||om) --- Comment #12 from Mamoru TASAKA mtas...@fedoraproject.org --- What is the status of this bug? I see git procedure was already done, koji has this rpm name entry, however no build was done yet for more than 2 months. I need this package for the dependency of rabbit. I've prepared my srpm with a bit cleaning up the srpm on comment 5 . : http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-faraday.spec http://mtasaka.fedorapeople.org/Review_request/rabbit-related/rubygem-faraday-0.8.8-2.fc.src.rpm Achilleas, are you still interested in this package? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 967337] Review Request: rubygem-faraday - HTTP/REST API client library
https://bugzilla.redhat.com/show_bug.cgi?id=967337 --- Comment #13 from Mamoru TASAKA mtas...@fedoraproject.org --- (In reply to Mamoru TASAKA from comment #12) Achilleas, are you still interested in this package? Oops, I should ask Anuj, sorry. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027521] Review Request: rubygem-creole - Lightweight markup language
https://bugzilla.redhat.com/show_bug.cgi?id=1027521 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking. I would appreciate it if you would review one of my review requests. (e.g. bug 1031314 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- Taking. I would appreciate it if you would review one of my review requests (e.g. bug 1031315 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1028168] Review Request: rubygem-expression_parser - A math parser
https://bugzilla.redhat.com/show_bug.cgi?id=1028168 Mamoru TASAKA mtas...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1002092] Review Request: burp - A network backup and restore program
https://bugzilla.redhat.com/show_bug.cgi?id=1002092 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) pa...@hubbitus.info --- Still no systemd service(s). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031318] Review Request: rubygem-rabbit - RD-document-based presentation application
https://bugzilla.redhat.com/show_bug.cgi?id=1031318 --- Comment #1 from Mamoru TASAKA mtas...@fedoraproject.org --- (For F-20: rubygem-gettext-3.0.2-6.fc20.1 (FEDORA-2013-21126, now in testing) is needed to build this correctly) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027503] Review Request: rubygem-vegas - Create executable versions of Sinatra/Rack apps
https://bugzilla.redhat.com/show_bug.cgi?id=1027503 Ken Dreyer ktdre...@ktdreyer.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com --- Thank you very much Mario for the review! New Package SCM Request === Package Name: rubygem-vegas Short Description: Create executable versions of Sinatra/Rack apps Owners: ktdreyer Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1025977] Review Request: captcp - TCP Analyzer for PCAP Files
https://bugzilla.redhat.com/show_bug.cgi?id=1025977 --- Comment #14 from Michele Baldessari mich...@acksyn.org --- Hi Mikolaj, so I've discussed with upstream a few things and the package should be more or less ready at this point. Here are a couple of points that are worth noting and/or discussing: - License Tag: I've put GPLv2+ and MIT as it seemed the most concise way to describe it. Even though for the vast majority *is* GPLv3 and there are only a couple of exceptions: data/stap-scripts/tcp-trace.stp - GPLv2+ data/connection-animation-data/raphael-min.js - MIT I've got confirmation from upstream on the correctness of all the licenses and also had the GPLv3 preamble added to the main python file. - The two images' license has been clarified/changed: 1. data/connection-animation-data/images/old-computer.png CC AS Alike 3.0 Unported - https://en.wikipedia.org/wiki/File:Sperry-univac-uniscope-200-0a.jpg 2. data/connection-animation-data/images/router.png: Public Domain - http://openclipart.org/detail/1918/router-by-juanjo - I had to introduce the commit variables in the spec again as we need a commit to get the properly licensed images. - I've patched in the full MIT-LICENSE as upstream was not keen in adding it to the main git repo - All the patches I had around locally have been applied Both files are rpmlint -i -v clean: Spec URL: http://acksyn.org/files/rpms/captcp/captcp.spec SRPM URL: http://acksyn.org/files/rpms/captcp/captcp-1.7-1.fc20.src.rpm regards, Michele -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031326] New: Review Request: libkomparediff2 - Library to compare files and strings
https://bugzilla.redhat.com/show_bug.cgi?id=1031326 Bug ID: 1031326 Summary: Review Request: libkomparediff2 - Library to compare files and strings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ke...@tigcc.ticalc.org QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://repo.calcforge.org/f21/libkomparediff2.spec SRPM URL: http://repo.calcforge.org/f21/libkomparediff2-4.11.90-1.fc18.src.rpm Description: A shared library to compare files and strings using kdelibs and GNU diff, used in Kompare and KDevelop. Fedora Account System Username: kkofler Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6188768 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031326] Review Request: libkomparediff2 - Library to compare files and strings
https://bugzilla.redhat.com/show_bug.cgi?id=1031326 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||656997 (kde-reviews) Alias||libkomparediff2 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031326] Review Request: libkomparediff2 - Library to compare files and strings
https://bugzilla.redhat.com/show_bug.cgi?id=1031326 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter rdie...@math.unl.edu --- I can review this... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031326] Review Request: libkomparediff2 - Library to compare files and strings
https://bugzilla.redhat.com/show_bug.cgi?id=1031326 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter rdie...@math.unl.edu --- relatively simple library packaging... naming: ok license: ok sources: ok 1e71335bde79dd637743b6df764805d9 libkomparediff2-4.11.90.tar.xz scriptlets: ok macros: ok conflicts: ok Looks good, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031326] Review Request: libkomparediff2 - Library to compare files and strings
https://bugzilla.redhat.com/show_bug.cgi?id=1031326 Kevin Kofler ke...@tigcc.ticalc.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Kevin Kofler ke...@tigcc.ticalc.org --- New Package SCM Request === Package Name: libkomparediff2 Short Description: Library to compare files and strings Owners: kkofler than rdieter ltinkl jgrulich Branches: f20 f19 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031337] New: Review Request: notion - A tabbed, tiling window manager forked from Ion3
https://bugzilla.redhat.com/show_bug.cgi?id=1031337 Bug ID: 1031337 Summary: Review Request: notion - A tabbed, tiling window manager forked from Ion3 Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: jeff.bac...@gmail.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: https://www.dropbox.com/s/t40a8uz2qyg7f27/notion.spec SRPM URL: https://www.dropbox.com/s/1n6a089fynla2t5/notion-3.2013030200-2.fc18.src.rpm Description: Notion is a tabbed, tiling window manager for the X windows system. Features include: * Workspaces: each work space has its own tiling. * Multiheaded * RandR support * Extensible via Lua scripts. Fedora Account System Username: jsbackus I am a new maintainer and will need a sponsor. Notion is released under the same modified LGPLv2.1 license that its predecessor, Ion3, was released under. The modifications explicitly state that anything based on Ion3 cannot be named Ion3. I am still waiting on an official blessing from legal. Subpackages are included: * notion-devel * notion-contrib * notion-doc All packages pass rpmlint, with one exception. The base package issues a warning regarding one of the executables not having a manpage. Upstream does not currently provide a manpage for this executable. Koji Build Tasks: F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189344 F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189340 F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189343 F21: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189336 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031337] Review Request: notion - A tabbed, tiling window manager forked from Ion3
https://bugzilla.redhat.com/show_bug.cgi?id=1031337 Jeff Backus jeff.bac...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031341] New: Review Request: main package name here - short summary here
https://bugzilla.redhat.com/show_bug.cgi?id=1031341 Bug ID: 1031341 Summary: Review Request: main package name here - short summary here Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rcl...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://people.freedesktop.org/~robclark/rpmbuild/xorg-x11-drv-freedreno/xorg-x11-drv-freedreno.spec SRPM URL: http://people.freedesktop.org/~robclark/rpmbuild/SRPMS/xorg-x11-drv-freedreno-1.0.0-1.fc20.src.rpm Description: xorg ddx driver for snapdragon/adreno arm SoC's Fedora Account System Username: rclark (and in case it is useful, koji scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189592) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031342] New: Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's
https://bugzilla.redhat.com/show_bug.cgi?id=1031342 Bug ID: 1031342 Summary: Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rcl...@redhat.com QA Contact: extras...@fedoraproject.org CC: nott...@redhat.com, package-review@lists.fedoraproject.org Spec URL: http://people.freedesktop.org/~robclark/rpmbuild/xorg-x11-drv-freedreno/xorg-x11-drv-freedreno.spec SRPM URL: http://people.freedesktop.org/~robclark/rpmbuild/SRPMS/xorg-x11-drv-freedreno-1.0.0-1.fc20.src.rpm Description: xorg ddx driver for snapdragon/adreno arm SoC's Fedora Account System Username: rclark (and in case it is useful, koji scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=6189592) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031341] Review Request: main package name here - short summary here
https://bugzilla.redhat.com/show_bug.cgi?id=1031341 Christopher Meng cicku...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED CC||cicku...@gmail.com Resolution|--- |DUPLICATE Last Closed||2013-11-16 20:43:42 --- Comment #1 from Christopher Meng cicku...@gmail.com --- *** This bug has been marked as a duplicate of bug 1031342 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's
https://bugzilla.redhat.com/show_bug.cgi?id=1031342 --- Comment #1 from Christopher Meng cicku...@gmail.com --- *** Bug 1031341 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's
https://bugzilla.redhat.com/show_bug.cgi?id=1031342 Christopher Meng cicku...@gmail.com changed: What|Removed |Added CC||cicku...@gmail.com --- Comment #2 from Christopher Meng cicku...@gmail.com --- It's not ok to use git am -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's
https://bugzilla.redhat.com/show_bug.cgi?id=1031342 --- Comment #3 from Rob Clark rcl...@redhat.com --- (In reply to Christopher Meng from comment #2) It's not ok to use git am oh.. I just cargo-cult'd that over from Bastien's original .spec file. There aren't actually any patches applied in the package, so I guess I can just delete that line? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901365] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=901365 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- python-mongoengine-0.8.4-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-mongoengine-0.8.4-1.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901365] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=901365 --- Comment #24 from Fedora Update System upda...@fedoraproject.org --- python-mongoengine-0.8.4-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-mongoengine-0.8.4-1.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 901365] Review Request: python-mongoengine - A Python Document-Object Mapper for working with MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=901365 --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- python-mongoengine-0.8.4-1.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python-mongoengine-0.8.4-1.fc18 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's
https://bugzilla.redhat.com/show_bug.cgi?id=1031342
Peter Lemenkov lemen...@gmail.com changed:
What|Removed |Added
CC||lemen...@gmail.com
--- Comment #4 from Peter Lemenkov lemen...@gmail.com ---
(In reply to Rob Clark from comment #3)
(In reply to Christopher Meng from comment #2)
It's not ok to use git am
oh.. I just cargo-cult'd that over from Bastien's original .spec file.
There aren't actually any patches applied in the package, so I guess I can
just delete that line?
Yes, delete the entire block
==
git init
if [ -z $GIT_COMMITTER_NAME ]; then
git config user.email xorg-x11-drv-freedreno-ow...@fedoraproject.org
git config user.name Fedora xorg-x11-drv-freedreno maintainers
fi
git add .
git commit -a -q -m %{version} baseline.
git am -p1 %{patches} /dev/null
==
Looks like there were some patches some time, but they're gone.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039 --- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com --- Hi Mario, (In reply to Mario Blättermann from comment #6) Any news here...? The spec/srpm are available at the links given in comment#2 http://ankursinha.fedorapeople.org/albumart/ I'm willing to maintain the package, until the bugs crop up ;) Thanks Ankur -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031337] Review Request: notion - A tabbed, tiling window manager forked from Ion3
https://bugzilla.redhat.com/show_bug.cgi?id=1031337
Christopher Meng cicku...@gmail.com changed:
What|Removed |Added
CC||cicku...@gmail.com
Blocks||182235 (FE-Legal)
--- Comment #1 from Christopher Meng cicku...@gmail.com ---
-- --
## ##
##|Non FREE?|##
## ##
-- --
This package in Debian is in nonfree repo, have you noticed this fact? I just
blocked FE-Legal in order to get some information from RH Legal team.
0. Hope you will get familiar with fedorapeople.org so everytime I don't need
to download stuffs from dropbox. Dropbox can't display things directly, so it
will make people unsatisfied.
Even if you post your spec URL of this:
https://github.com/jsbackus/fedora_notion/blob/master/notion.spec
will be better than using some download-only services.
Also note that this is an informal review.
-- --
## ##
##|SPEC part|##
## ##
-- --
1. Source0:
http://downloads.sourceforge.net/project/notion/notion-3-2013030200-src.tar.bz2
Well, if you don't want to update URL each time you update it, you can:
%global majorver 3
%global datever 2013030200
then write your Version tag:
Version:%{majorver}.%{datever}
And source0:
Source0:
http://downloads.sourceforge.net/project/notion/%{name}-%{majorver}-%{datever}-src.tar.bz2
And %prep:
%setup -q -n %{name}-%{majorver}-%{datever}
#Source1:git://notion.git.sourceforge.net/gitroot/notion/notion-doc
Source1:
https://www.dropbox.com/sh/n1icl72l63dy9tr/jFYmjjqH-f/notion-doc-3-2013030200.tar.bz2
Well, this way is not allowed IMO.
# notion.desktop can also be found in git repo
https://github.com/jsbackus/fedora_notion.git
Source2:
https://www.dropbox.com/sh/n1icl72l63dy9tr/Qurc5REVFy/notion.desktop
2. No need to BuildRequires: pkgconfig, RPM can handle this well.
3.
BuildRequires: lua
BuildRequires: lua-devel
I think just
BuildRequires: lua-devel
should be fine.
4. # This package provides Helvetica 12px.
#Requires: xorg-x11-fonts-75dpi
Oh, so? Why don't delete these 2 lines?
5. sed -e 's|^\(PREFIX=\).*$|\1/usr|' \
-e 's|^\(ETCDIR=\).*$|\1/etc/notion|' \
-e 's|^\(LUA_DIR=\).*$|\1/usr|' \
-e 's|^\(X11_PREFIX=\).*$|\1/usr|' \
-e 's|^\(X11_LIBS=\).*$|\1`pkg-config --libs x11 xext`|' \
-e 's|^\(LIBDIR=\).*$|\1%{_libdir}|' \
-i system-autodetect.mk
Use macro consistently:
sed -e 's|^\(PREFIX=\).*$|\1%{_prefix}|' \
-e 's|^\(ETCDIR=\).*$|\1%{_sysconfdir}/%{name}|' \
-e 's|^\(LUA_DIR=\).*$|\1%{_prefix}|' \
-e 's|^\(X11_PREFIX=\).*$|\1%{_prefix}|' \
-e 's|^\(X11_LIBS=\).*$|\1`pkg-config --libs x11 xext`|' \
-e 's|^\(LIBDIR=\).*$|\1%{_libdir}|' \
-i system-autodetect.mk
6. mv $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}
$RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-%{version}
From Fedora 20 we change back to
%{_defaultdocdir}/%{name} instead of %{_defaultdocdir}/%{name}-%{version} used
before f20.
Please try %{_pkgdocdir} and see if it helps. Also, these can be handled in
system-autodetect.mk, please modify DOCDIR=$(PREFIX)/share/doc/notion to the
correct one.
7. # Install and verify desktop file
install -Dm0644 %SOURCE2 $RPM_BUILD_ROOT%{_datadir}/xsessions/%{name}.desktop
Ah, I don't think this should be put under %{_datadir}/xsessions, you can take
a look at what is stored under this location:
[rpmaker@fab xsessions]$ ll
total 52
-rw-r--r--. 1 root root 268 11月 11 23:40 cinnamon2d.desktop
-rw-r--r--. 1 root root 155 11月 11 23:40 cinnamon.desktop
-rw-r--r--. 1 root root 1092 11月 13 14:50 enlightenment.desktop
-rw-r--r--. 1 root root 5044 10月 16 21:29 gnome-classic.desktop
-rw-r--r--. 1 root root 7088 11月 4 08:37 gnome.desktop
-rw-r--r--. 1 root root 4785 11月 11 23:13 kde-plasma.desktop
-rw-r--r--. 1 root root 7202 11月 11 23:13 kde-plasma-safe.desktop
-rw-r--r--. 1 root root 6376 11月 3 01:15 mate.desktop
Yeah, all are desktop environments, and user applications should be put under:
%{_datadir}/applications
BUT, you should install desktop file with `desktop-file-install` command:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
8. mkdir -p $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-contrib-%{version}
for i in LICENSE README; do
install -Dm0644 $RPM_BUILD_DIR/%{buildsubdir}/contrib/$i
$RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-contrib-%{version}/
done
Please adapt to new fedora 20 and, learn how to use %doc macro in %files
section instead of doing this.
9. %files section not good:
9.1 %config(noreplace)
