[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015765



--- Comment #12 from Mosaab Alzoubi moc...@hotmail.com ---
It's fixed after first packaging :)
https://bugzilla.gnome.org/show_bug.cgi?id=688972

I'll update this package due to updating upstream.
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1015765



--- Comment #13 from Mosaab Alzoubi moc...@hotmail.com ---
This example of wine.spec:
http://pkgs.fedoraproject.org/cgit/wine.git/tree/wine.spec

Using only one line:
%config %{_sysconfdir}/xdg/menus/applications-merged/wine.menu

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025196

Daiki Ueno du...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Daiki Ueno du...@redhat.com ---
Thanks for the review, will reflect the suggestions when importing.

New Package SCM Request
===
Package Name: fcitx-skk
Short Description:  Japanese SKK (Simple Kana Kanji) Engine for Fcitx
Owners: ueno
Branches: f20
InitialCC: i18n-team

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026376



--- Comment #7 from Ankur Sinha (FranciscoD) sanjay.an...@gmail.com ---
(In reply to Tom spot Callaway from comment #6)
 I think given that A) the logos in this font are the ones with specific
 permissions granted by their owners and B) it is highly likely in the
 context of this font that such logos will only be used in compliance with
 those permissions, they are acceptable in Fedora.
 
 That said, please add a README-Trademarks.txt file which notes these marks,
 their owners, and provides links to their respective trademark use policies.

Thanks for the clarification Spot. 

Ryan, I see upstream has a branch called no-font where he's completely
removed fontawesome-fonts (or is trying to). Do you want to wait for him to
complete that and then package up corebird, if you're only looking to package
fontawesome-fonts because they're needed by corebird? If you'd like to maintain
the fonts even if corebird doesn't use them, I'll continue the review.

https://github.com/baedert/corebird/tree/no-font

Thanks,
Warm regards,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032479] New: Review Request: perl-Log-Report - Report a problem with exceptions and translation support

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032479

Bug ID: 1032479
   Summary: Review Request: perl-Log-Report - Report a problem
with exceptions and translation support
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL: http://ppisar.fedorapeople.org/perl-Log-Report/perl-Log-Report.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-Log-Report/perl-Log-Report-0.998-1.fc21.src.rpm
Description:
Handling messages directed to users can be a hassle, certainly when the same
software is used for command-line and in a graphical interfaces (you may not
now how it is used), or has to cope with internationalization; these modules
try to simplify this.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032479] Review Request: perl-Log-Report - Report a problem with exceptions and translation support

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032479

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Depends On||1032489




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1032489
[Bug 1032489] Hash-Case-1.02 bump
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032479] Review Request: perl-Log-Report - Report a problem with exceptions and translation support

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032479

Petr Pisar ppi...@redhat.com changed:

   What|Removed |Added

 Blocks||1032489
 Depends On|1032489 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1032489
[Bug 1032489] Hash-Case-1.02 bump
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1021733



--- Comment #15 from Christopher Meng cicku...@gmail.com ---
(In reply to Björn besser82 Esser from comment #14)
 (In reply to Mario Blättermann from comment #13)
  The test suite expects a running X server and a valid display number. As far
  as I can evaluate, the tests will fail again and again because a Koji server
  doesn't have the ability to start an X server. So we should disable the
  tests for now.
 
 One actually can start a framebuffer-based x-server on koji  ;)
 
 BuildRequires: xorg-x11-server-Xvfb
 
 ...
 
 %check
 xvfb-run -a %{your_testsuite_cmd}
 
 
 Cheers,
   Björn

BR added.

Still failed.

Using:

%check
pushd tests
PYTHONPATH=%{buildroot}%{python2_sitelib} xvfb-run -a
nosetests-%{python2_version}
popd
pushd %{py3dir}
PYTHONPATH=%{buildroot}%{python3_sitelib} xvfb-run -a
nosetests-%{python3_version}
popd

http://koji.fedoraproject.org/koji/taskinfo?taskID=6204843

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1005490] Review Request: SDL2_mixer - Simple DirectMedia Layer - Sample Mixer Library

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1005490



--- Comment #5 from Christopher Meng cicku...@gmail.com ---
Please:

1. Add these supports by BR:

i.  libmodplug-devel
ii. fluidsynth-devel
iii.libmikmod-devel

2. Remove

Requires:   pkgconfig

in -devel package.

3. License is not LGPLv2 of course, please correct.

4. This package should also be built with smpeg2 support, however this package
is not in Fedora and may never be included in Fedora due to legal issues;) ) So
ignore this comment...

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1023474] Review Request: efivar - utility and library for manipulating efi variables

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1023474



--- Comment #9 from Christopher Meng cicku...@gmail.com ---
A month passed, I still can't see any changes in SCM.

PING.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] New: Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Bug ID: 1032515
   Summary: Review Request: python-sphinxcontrib-adadomain – Ada
domain for the Sphinx documentation generator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: bj...@xn--rombobjrn-67a.se
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL:
https://www.rombobjörn.se/packages/python-sphinxcontrib-adadomain-0.1-1/python-sphinxcontrib-adadomain.spec
SRPM URL:
https://www.rombobjörn.se/packages/python-sphinxcontrib-adadomain-0.1-1/python-sphinxcontrib-adadomain-0.1-1.fc20.src.rpm
Description: The Ada domain for the Sphinx documentation generator adds support
for extracting API documentation from Ada code.
Fedora Account System Username: rombobeorn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Björn Persson bj...@xn--rombobjrn-67a.se changed:

   What|Removed |Added

  Alias||python-sphinxcontrib-adadom
   ||ain



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Christopher Meng cicku...@gmail.com ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 Unknown or generated. 3 files have unknown license. Detailed output of
 licensecheck:


Unknown or generated

/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/sphinxcontrib-adadomain-0.1/setup.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/sphinxcontrib-adadomain-0.1/sphinxcontrib/__init__.py
/var/lib/mock/fedora-rawhide-i386/root/builddir/build/BUILD/sphinxcontrib-adadomain-0.1/sphinxcontrib/adadomain.py


[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/lib/python2.7/site-
 packages/sphinxcontrib(python-sphinxcontrib-cheeseshop, python-
 sphinxcontrib-httpdomain)
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm  4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file 

[Bug 924682] Review Request: gimp-elsamuko - Elsamukos script collection for the GIMP

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=924682

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC|package-review@lists.fedora |
   |project.org |
 Status|NEW |ASSIGNED
 CC||cicku...@gmail.com
   Assignee|nob...@fedoraproject.org|cicku...@gmail.com
  Flags||fedora-review?



--- Comment #3 from Christopher Meng cicku...@gmail.com ---
v24 is out!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515



--- Comment #2 from Björn Persson bj...@xn--rombobjrn-67a.se ---
Wow, that was a fast review!

 Only issue: %{python_sitelib} -- %{python2_sitelib}

Oh? https://fedoraproject.org/wiki/Packaging:Python doesn't mention
python2_sitelib anywhere, but OK, the macro appears to exist.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032108] Review Request: Yarock - A Lightweight and Beautiful Qt Music Player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032108



--- Comment #5 from james jamescateg...@gmail.com ---
@Terje Røsten: I've applied all the changes you suggested except one. I had
already tried %cmake and it didn't work for me. In fact using %cmake would lead
to many errors during make. I played with it a lot but it didn't work so I
reverted to plain cmake. To make things even more complicated, the option
-DCMAKE_INSTALL_PREFIX:PATH=/usr actually does NOT work here (but I still
prefer to keep it just to remind the reviewers that I'm aware of it). In order
to make the package to be installed in /usr/bin (instead of the default
/usr/local/bin), I had to manually patch the cmakelists file (see the patch).
It's a dirty trick but the only solution ( I had a discussion on cmake irc
channel, made their head spin). Here is the updated spec: 
http://jam3s.fedorapeople.org/yarock.spec

Here is the link to koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6204882

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515



--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Simple package, why not fast...

Swap with bug 1001452.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #14 from Jose Pedro Oliveira j...@di.uminho.pt ---
(In reply to Christopher Meng from comment #13)
 (In reply to Jose Pedro Oliveira from comment #7)
 please add the test/default/*.c files
 (they can also serve as documentation)
 
 I think that just including .c is not enough, I see one core3.c requires
 cmptest.h, so I want your idea again.

You can also include the header file. Just add the following line

%doc test/default/*.{c,h}

 Except this, all fixed at:
 
 Spec URL: http://cicku.me/libsodium.spec
 SRPM URL: http://cicku.me/libsodium-0.4.5-1.fc21.src.rpm

 * Do we need to increase the verbosity level of make (V=1)?

 * Don't include the README file; the only one that matters is the 
   README.markdown

 * The specfile doesn't build for EPEL6. See comment #c7 and
   https://bugzilla.redhat.com/show_bug.cgi?id=1025972#c2

 * Please add the ticket number to the changelog entry (in particular
   when specfiles changes are driven by feedback posted on bugzilla tickets)

/jpo

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #15 from Jose Pedro Oliveira j...@di.uminho.pt ---
Specfile changes based on the previous comment:

--- libsodium.spec.chris2013-11-20 03:50:41.0 +
+++ libsodium.spec2013-11-20 12:13:15.240043289 +
@@ -23,9 +23,15 @@
 %prep
 %setup -q

+# The change below, which is already merged in the upstream codebase,
+# is only needed for RHEL6 which only has pkg-config 0.23
+%if 0%{?rhel} == 6
+sed -i 's|_pkg_min_version=0.25|_pkg_min_version=0.23|g' configure
+%endif
+
 %build
 %configure --disable-static
-make %{?_smp_mflags} V=1
+make %{?_smp_mflags}

 %install
 make install DESTDIR=%{buildroot}
@@ -39,10 +45,11 @@
 %postun -p /sbin/ldconfig

 %files
-%doc AUTHORS ChangeLog LICENSE README* THANKS
+%doc AUTHORS ChangeLog LICENSE README.markdown THANKS
 %{_libdir}/libsodium.so.*

 %files devel
+%doc test/default/*.{c,h}
 %{_includedir}/sodium.h
 %{_includedir}/sodium/
 %{_libdir}/libsodium.so
@@ -51,6 +58,8 @@
 %changelog
 * Wed Nov 20 2013 Christopher Meng r...@cicku.me - 0.4.5-1
 - New version.
+- Package the new pkgconfig file.
+- Small specfile improvements (#990423).

 * Wed Jul 10 2013 Christopher Meng r...@cicku.me - 0.4.2-2
 - Drop useless files.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1020839] Review Request: fedora-gooey-karma - GUI tool for adding karma to Bodhi system

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1020839

Miroslav Suchý msu...@redhat.com changed:

   What|Removed |Added

 CC||msu...@redhat.com
   Assignee|nob...@fedoraproject.org|msu...@redhat.com



--- Comment #18 from Miroslav Suchý msu...@redhat.com ---
Taking.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1001452] Review Request: makepp - Compatible but reliable and improved replacement for make

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1001452

Björn Persson bj...@xn--rombobjrn-67a.se changed:

   What|Removed |Added

 CC||bj...@xn--rombobjrn-67a.se
   Assignee|nob...@fedoraproject.org|bj...@xn--rombobjrn-67a.se
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Björn Persson bj...@xn--rombobjrn-67a.se changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Björn Persson bj...@xn--rombobjrn-67a.se ---
(In reply to Christopher Meng from comment #3)
 Swap with bug 1001452.

I will, but it may be a few days before I have time.

Using python2_sitelib:
https://www.rombobjörn.se/packages/python-sphinxcontrib-adadomain-0.1-2/python-sphinxcontrib-adadomain.spec
https://www.rombobjörn.se/packages/python-sphinxcontrib-adadomain-0.1-2/python-sphinxcontrib-adadomain-0.1-2.fc19.src.rpm

New Package SCM Request
===
Package Name: python-sphinxcontrib-adadomain
Short Description: Ada domain for the Sphinx documentation generator
Owners: rombobeorn
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1001452] Review Request: makepp - Compatible but reliable and improved replacement for make

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1001452

Björn Persson bj...@xn--rombobjrn-67a.se changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #16 from Christopher Meng cicku...@gmail.com ---
(In reply to Jose Pedro Oliveira from comment #14)
 %doc test/default/*.{c,h}

Fine.

  * Do we need to increase the verbosity level of make (V=1)?

Yes, it's a MUST.

  * Don't include the README file; the only one that matters is the 
README.markdown

Fine, dropped.

  * The specfile doesn't build for EPEL6. See comment #c7 and
https://bugzilla.redhat.com/show_bug.cgi?id=1025972#c2

You've said that it has been merged upstream, so why didn't they release with
the fix?

  * Please add the ticket number to the changelog entry (in particular
when specfiles changes are driven by feedback posted on bugzilla tickets)

Well,

 +- Package the new pkgconfig file.

1. Upstream started to provide a pkgconfig file, not me, I don't think we need
to say about that(unless libsodium is already included in Fedora, but still not
reasonable)

 +- Small specfile improvements (#990423).

2. This is OK. But I never do this. Because I need bodhi to send comments to
bugs from the latest changelog.


---

Spec URL: http://cicku.me/libsodium.spec
SRPM URL: http://cicku.me/libsodium-0.4.5-2.fc21.src.rpm

PS if you want to take this review, please assign.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028481] Review Request: libtsm - Terminal-emulator State Machine

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1028481



--- Comment #3 from Christopher Meng cicku...@gmail.com ---
Ok.

Try again from URLs in the original comment.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025196

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025196] Review Request: fcitx-skk - Japanese SKK (Simple Kana Kanji) Engine for Fcitx

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025196



--- Comment #3 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032515] Review Request: python-sphinxcontrib-adadomain – Ada domain for the Sphinx documentation generator

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032515



--- Comment #5 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
wondershaper-1.2.1-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498



--- Comment #14 from Fedora Update System upda...@fedoraproject.org ---
wondershaper-1.2.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498



--- Comment #12 from Fedora Update System upda...@fedoraproject.org ---
wondershaper-1.2.1-2.fc18 has been submitted as an update for Fedora 18.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc18

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498



--- Comment #13 from Fedora Update System upda...@fedoraproject.org ---
wondershaper-1.2.1-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/wondershaper-1.2.1-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #6 from gil cattaneo punto...@libero.it ---
hi
is available new release datanucleus-core 3.2.9

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885

Kashyap Chamarthy kcham...@redhat.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #21 from Kashyap Chamarthy kcham...@redhat.com ---
New changes look good to me, approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #7 from gil cattaneo punto...@libero.it ---
build fails, cause:
Failed to resolve artifact: javax.cache:cache-api:pom:0.9

please, remove cache-api references

http://kojipkgs.fedoraproject.org//work/tasks/5488/6205488/build.log
http://koji.fedoraproject.org/koji/taskinfo?taskID=6205486

i can proceed with a a manual review only, cause:
Error: No package found for mvn(javax.time:time-api)

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #8 from Pete MacKinnon pmack...@redhat.com ---
cache-api is disabled in the latest (.3). Are you reviewing an older version?

Anyway I will be updating to 3.2.9 (if possible) per comment #6.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #17 from Michael Schwendt bugs.mich...@gmx.net ---
   * Do we need to increase the verbosity level of make (V=1)?
 
 Yes, it's a MUST.

Really? Please link the packaging/review guidelines more often than not.

Verbose build output is beneficial (so e.g. one can review build details for
old/released packages by visiting the koji website), but it's not mandatory.
Note that some package maintainers refuse to enable verbose build output,
because they argue that verbose build logs contain too much noise.

Btw, 'V=1' does not work always. Sometimes --disable-silent-rules can be used.
In other cases, one would need to patch Makefiles, some old makefiles still use
the special .SILENT target.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #9 from Pete MacKinnon pmack...@redhat.com ---
Hmmm, maybe certain versions of xmvn are ignoring the optionaltrue/optional
attribute. I will explicitly remove the dep in next update.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032203] Review Request: jamon-parent - Jamon base pom

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032203

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 CC||punto...@libero.it
   Assignee|nob...@fedoraproject.org|punto...@libero.it
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885

Jakub Ruzicka jruzi...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #22 from Jakub Ruzicka jruzi...@redhat.com ---
New Package SCM Request
===
Package Name: python-openstackclient
Short Description: OpenStack Command-line Client
Owners: jruzicka
Branches: f20 el6
InitialCC: pbrady apevec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #10 from gil cattaneo punto...@libero.it ---
(In reply to Pete MacKinnon from comment #8)
 cache-api is disabled in the latest (.3). Are you reviewing an older version?
 
 Anyway I will be updating to 3.2.9 (if possible) per comment #6.

usually if you dont have a build dep you must remove this one references,
also if its use optionaltrue/optional

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032203] Review Request: jamon-parent - Jamon base pom

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032203

gil cattaneo punto...@libero.it changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from gil cattaneo punto...@libero.it ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE no apidocs availables for this package

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Each %files section contains %defattr if rpm  4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It is
 pulled in by maven-local
[x]: Bundled jar/class files should be removed before build

Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
 when building with ant
[x]: Pom files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: If the source package does not 

[Bug 1032670] New: Review Request: docker-registry - Registry server for Docker

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032670

Bug ID: 1032670
   Summary: Review Request: docker-registry - Registry server for
Docker
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mgold...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL:
http://goldmann.fedorapeople.org/package_review/docker-registry/1/docker-registry.spec
SRPM URL:
http://goldmann.fedorapeople.org/package_review/docker-registry/1/docker-registry-0.6.0-1.fc20.src.rpm
Fedora Account System Username: goldmann

Description:

Registry server for Docker (hosting/delivering of repositories and images).

Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6205675

P.S. This is my first python package, please be gentle :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858070] Review Request: mingw-qt5-qtmultimedia - Qt5 for Windows - QtMultimedia component

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858070

Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

 Blocks||858084




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=858084
[Bug 858084] Review Request: mingw-qt5-qtwebkit - Qt5 for Windows -
QtWebKit component
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 858084] Review Request: mingw-qt5-qtwebkit - Qt5 for Windows - QtWebKit component

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=858084

Erik van Pienbroek erik-fed...@vanpienbroek.nl changed:

   What|Removed |Added

 Depends On||858070




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=858070
[Bug 858070] Review Request: mingw-qt5-qtmultimedia - Qt5 for Windows -
QtMultimedia component
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031342



--- Comment #16 from Xavier Bachelot xav...@bachelot.org ---
@christopher, pkgconfig(libdrm_freedreno) is only available on ARM, so if you
don't have an ARM machine to run fedora-review, you'll have to manually run the
sanity checks using packages from a koji scratch build.
Are you still up for the review if you don't have ARM hardware at hand ?

@rob, rather than pointing at a git repo, I would suggest using :
Source0:
http://xorg.freedesktop.org/archive/individual/driver/xf86-video-freedreno-%{version}.tar.bz2
Again, this is cosmetic.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1027513] Review Request: rubygem-axiom-types - Abstract types for logic programming

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1027513



--- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com ---
The package now builds on F19.

Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-axiom-types.spec
SRPM URL:
http://ktdreyer.fedorapeople.org/reviews/rubygem-axiom-types-0.0.5-2.fc21.src.rpm

F19 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6205826

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031342

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC|cicku...@gmail.com  |
   Assignee|cicku...@gmail.com  |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #17 from Christopher Meng cicku...@gmail.com ---
Oops... 

I have many arm boards in my hand, but none of them are officially supported by
Fedora(or said that kernel Linux).

So I can't perform the review. Although I can say this package is fine, it's
improper and irresponsible to continue. 

Quitting.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #11 from Pete MacKinnon pmack...@redhat.com ---
Updated to 3.2.9, cache-api fully removed, tests disabled:

SPEC URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-core.spec
SRPM URL:
http://pmackinn.fedorapeople.org/datanucleus/datanucleus-core-3.2.9-1.fc19.src.rpm

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885

Jon Ciesla limburg...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1024885] Review Request: python-openstackclient - OpenStack Command-line Client

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1024885



--- Comment #23 from Jon Ciesla limburg...@gmail.com ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1010383] Review Request: time-api - javax.time JSR310 API (threeten)

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1010383



--- Comment #11 from Fedora Update System upda...@fedoraproject.org ---
time-api-0.6.4-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/time-api-0.6.4-3.fc19

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1010383] Review Request: time-api - javax.time JSR310 API (threeten)

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1010383

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1010383] Review Request: time-api - javax.time JSR310 API (threeten)

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1010383



--- Comment #10 from Fedora Update System upda...@fedoraproject.org ---
time-api-0.6.4-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/time-api-0.6.4-3.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #9 from Antonio Trande anto.tra...@gmail.com ---
Spec URL: http://sagitter.fedorapeople.org/snappy/snappy-player.spec
SRPM URL:
http://sagitter.fedorapeople.org/snappy/snappy-player-0.3.7-1.20131119git8ece98e0.fc19.src.rpm

Koji build in rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6206040

- Update to upstream git commit of the 2013-11-19
- Set CFLAGS (C compiler flags)
- Changed Name/Icon entries and added a category in the .desktop file

Autotools files are now provided in the source archive by upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011705] Review Request: datanucleus-core - Java persistence abstraction layer

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011705



--- Comment #12 from gil cattaneo punto...@libero.it ---
build fails

[INFO] --- xmvn-mojo:1.3.0:install (default-cli) @ datanucleus-core ---
[WARNING] Failed to resolve artifact: org.apache.ivy:ivy:pom:2.3.0
[WARNING] The POM for org.apache.ivy:ivy:jar:2.3.0 is missing, no dependency
information available
[ERROR] Reactor project org.datanucleus:datanucleus-core:jar:3.2.9 has
system-scoped dependencies: [
  org.eclipse.equinox:org.eclipse.equinox.registry::jar:3.5.0.v20100503,
  org.eclipse.equinox:org.eclipse.equinox.common::jar:3.6.0.v20100503,
  org.eclipse.equinox:org.eclipse.equinox.preferences::jar:3.3.0.v20100503,
  org.eclipse.core:org.eclipse.core.runtime::jar:3.6.0.v20100505,
  org.eclipse.core:org.eclipse.core.contenttype::jar:3.4.100.v20100505-1235,
  org.eclipse.core:org.eclipse.core.jobs::jar:3.5.0.v20100515
]
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 26.484s
[INFO] Finished at: Wed Nov 20 17:08:08 UTC 2013
[INFO] Final Memory: 25M/399M
[INFO] 
[ERROR] Failed to execute goal org.fedoraproject.xmvn:xmvn-mojo:1.3.0:install
(default-cli) on project datanucleus-core: Some reactor artifacts have
dependencies with scope system. Such dependencies are not supported by XMvn
installer. You should either remove any dependencies with scope system before
the build or not run XMvn instaler. - [Help 1]
[ERROR]

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031337] Review Request: notion - A tabbed, tiling window manager forked from Ion3

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031337



--- Comment #6 from Jeff Backus jeff.bac...@gmail.com ---
(In reply to Michael Schwendt from comment #2)
  For the legal issue, I really don't have idea, as Debian has said it's 
  nonfree.
 
 It's highly likely that they reject the licensing, which is LGPL with
 sublicensing terms. See beginning of file LICENSE. It is not permitted to
 sublicense the LGPL or GPL. If one wants to modify the license, one may
 derive an own and _renamed_ license from it.

Yes, this is the reason. At the time, Debian did not accept tweaked licenses.
I suspect that this is still the case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 863795] Review Request: kadu - An Gadu-Gadu client for online messaging

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=863795



--- Comment #14 from Dawid Gajownik gajow...@gmail.com ---
Please add below line
Requires:   qca-ossl%{?_isa}

otherwise encryption plugin will not load.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1018498] Review Request: wondershaper(NG) - Simple network shaper

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1018498

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System upda...@fedoraproject.org ---
wondershaper-1.2.1-2.el6 has been pushed to the Fedora EPEL 6 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 903246] Review Request: python-cpopen - Creates a subprocess in simpler safer manner

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=903246

Fedora Update System upda...@fedoraproject.org changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||python-cpopen-1.2.3-4.el6
 Resolution|--- |ERRATA
Last Closed||2013-11-20 12:25:44



--- Comment #38 from Fedora Update System upda...@fedoraproject.org ---
python-cpopen-1.2.3-4.el6 has been pushed to the Fedora EPEL 6 stable
repository.  If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] New: Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Bug ID: 1032750
   Summary: Review Request: golang-github-syndtr-gocapability -
POSIX Capability library for the Go programming
lanaguage
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: vba...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: nott...@redhat.com,
package-review@lists.fedoraproject.org



Spec URL:
http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-github-syndtr-gocapability.spec
SRPM URL:
http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm
Description: POSIX Capability library for the Go programming lanaguage
Fedora Account System Username: vbatts

$ rpmlint golang-github-syndtr-gocapability.spec
golang-github-syndtr-gocapability.spec: W: no-buildroot-tag
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ fedpkg scratch-build --srpm
/home/vbatts/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm
Exception AttributeError: '_read_only' in bound method write.__del__ of
git.config.write object at 0x1745c20 ignored
[] 100% 00:00:00  11.14 KiB  16.80 KiB/sec
Building golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm for
rawhide
Created task: 6206385
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6206385
Watching tasks (this may be safely interrupted)...
6206385 build (rawhide,
golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm): open
(arm02-builder20.arm.fedoraproject.org)
  6206388 buildArch
(golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm, i686): free
  6206387 buildArch
(golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm, x86_64): open
(buildvm-26.phx2.fedoraproject.org)
  6206388 buildArch
(golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm, i686): free -
open (buildvm-26.phx2.fedoraproject.org)
  6206388 buildArch
(golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm, i686): open
(buildvm-26.phx2.fedoraproject.org) - closed
  0 free  2 open  1 done  0 failed
  6206387 buildArch
(golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm, x86_64): open
(buildvm-26.phx2.fedoraproject.org) - closed
  0 free  1 open  2 done  0 failed
6206385 build (rawhide,
golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm): open
(arm02-builder20.arm.fedoraproject.org) - closed
  0 free  0 open  3 done  0 failed

6206385 build (rawhide,
golang-github-syndtr-gocapability-0-0.1.git3454319.el6.src.rpm) completed
successfully

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Vincent Batts vba...@redhat.com changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|l...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2013-11-20 13:07:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1017202] Review Request: ovirt-engine-sdk-java - oVirt Engine Software Development Kit (Java)

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1017202

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1028481] Review Request: libtsm - Terminal-emulator State Machine

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1028481

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review+



--- Comment #4 from Mario Blättermann mario.blaetterm...@gmail.com ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=6206349

$ rpmlint -i -v *
libtsm.armv7hl: I: checking
libtsm.armv7hl: W: spelling-error %description -l en_US konsole - console,
insole
The value of this tag appears to be misspelled. Please double-check.

libtsm.armv7hl: W: spelling-error %description -l en_US libvte - liberate
The value of this tag appears to be misspelled. Please double-check.

libtsm.armv7hl: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm.i686: I: checking
libtsm.i686: W: spelling-error %description -l en_US konsole - console, insole
The value of this tag appears to be misspelled. Please double-check.

libtsm.i686: W: spelling-error %description -l en_US libvte - liberate
The value of this tag appears to be misspelled. Please double-check.

libtsm.i686: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm.src: I: checking
libtsm.src: W: spelling-error %description -l en_US konsole - console, insole
The value of this tag appears to be misspelled. Please double-check.

libtsm.src: W: spelling-error %description -l en_US libvte - liberate
The value of this tag appears to be misspelled. Please double-check.

libtsm.src: I: checking-url http://freedesktop.org/wiki/Software/kmscon/libtsm/
(timeout 10 seconds)
libtsm.src: I: checking-url
http://freedesktop.org/software/kmscon/releases/libtsm-3.tar.xz (timeout 10
seconds)
libtsm.x86_64: I: checking
libtsm.x86_64: W: spelling-error %description -l en_US konsole - console,
insole
The value of this tag appears to be misspelled. Please double-check.

libtsm.x86_64: W: spelling-error %description -l en_US libvte - liberate
The value of this tag appears to be misspelled. Please double-check.

libtsm.x86_64: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-debuginfo.armv7hl: I: checking
libtsm-debuginfo.armv7hl: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-debuginfo.i686: I: checking
libtsm-debuginfo.i686: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-debuginfo.x86_64: I: checking
libtsm-debuginfo.x86_64: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-devel.armv7hl: I: checking
libtsm-devel.armv7hl: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-devel.armv7hl: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libtsm-devel.i686: I: checking
libtsm-devel.i686: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-devel.i686: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libtsm-devel.x86_64: I: checking
libtsm-devel.x86_64: I: checking-url
http://freedesktop.org/wiki/Software/kmscon/libtsm/ (timeout 10 seconds)
libtsm-devel.x86_64: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

libtsm.spec: I: checking-url
http://freedesktop.org/software/kmscon/releases/libtsm-3.tar.xz (timeout 10
seconds)
10 packages and 1 specfiles checked; 0 errors, 11 warnings.

No real issues, just a few ignorable spelling errors and missing docs in the
-devel package.


-
key:

[+] OK
[.] OK, not applicable
[X] needs work
-

[+] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
MIT
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.

[Bug 1016767] Review Request: htrace - Tracing framework for java based distributed systems

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1016767

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Depends On|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026342] Review Request: springframework-retry - Abstraction around retrying failed operations

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026342

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1011183] Review Request: sisu-mojos - Sisu plugin for Apache Maven

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1011183

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031437] Review Request: truecommons - Common components for open source projects

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031437

Gerard Ryan ger...@ryan.lt changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423

Ralf Corsepius rc040...@freenet.de changed:

   What|Removed |Added

 CC||rc040...@freenet.de



--- Comment #18 from Ralf Corsepius rc040...@freenet.de ---
(In reply to Michael Schwendt from comment #17)
* Do we need to increase the verbosity level of make (V=1)?
  
  Yes, it's a MUST.

 Verbose build output is beneficial
That's too weak. Without seeing each and every compiler call in verbosity it's
impossible to verify whether a package is compiled correctly from build.logs.

In other words, using verbosity should be common sense to everybody.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031337] Review Request: notion - A tabbed, tiling window manager forked from Ion3

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031337



--- Comment #7 from Jeff Backus jeff.bac...@gmail.com ---
(In reply to Christopher Meng from comment #1)
 
 This package in Debian is in nonfree repo, have you noticed this fact? I
 just blocked FE-Legal in order to get some information from RH Legal team.

Yes, see comment 6. Thanks!

 
 0. Hope you will get familiar with fedorapeople.org so everytime I don't
 need to download stuffs from dropbox. Dropbox can't display things directly,
 so it will make people unsatisfied.
 
 Even if you post your spec URL of this:
 
 https://github.com/jsbackus/fedora_notion/blob/master/notion.spec
 
 will be better than using some download-only services.
 

Yes, I'd prefer to use fedorapeople.org, but since I am not in a group (yet), I
cannot put anything there. Hopefully after I get things spec squared away,
though I'm open to suggestions on how to expedite the process :) 

I will make it a point to use direct links into GitHub until then.

 Also note that this is an informal review.

Noted. I am still grateful for any input.


 
 
 #Source1:git://notion.git.sourceforge.net/gitroot/notion/notion-doc
 Source1:   
 https://www.dropbox.com/sh/n1icl72l63dy9tr/jFYmjjqH-f/notion-doc-3-
 2013030200.tar.bz2
 
 Well, this way is not allowed IMO.

Unfortunately, the documentation wasn't released by upstream for this version.
It is possible that the documentation didn't change since the previous release,
in which case I can use that. I'll check it. 


 
 3. 
 BuildRequires:  lua
 BuildRequires:  lua-devel
 
 I think just 
 
 BuildRequires:  lua-devel
 
 should be fine.

I may have tried that, I can't remember. My memory is that when I tried it in
mock and koji it failed. I believe this is because luac (the Lua compiler) used
during build is in lua, not lua-devel.



 6. mv $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}
 $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-%{version}
 
 From Fedora 20 we change back to
 
 %{_defaultdocdir}/%{name} instead of %{_defaultdocdir}/%{name}-%{version}
 used before f20.
 
 Please try %{_pkgdocdir} and see if it helps. Also, these can be handled in
 system-autodetect.mk, please modify DOCDIR=$(PREFIX)/share/doc/notion to the
 correct one.

Ah, perhaps that explains why koji failed for the F20 and F21 targets when I
was using %doc. Does %{_pkgdocdir} handle subpackages?

 
 8. mkdir -p $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-contrib-%{version}
 for i in LICENSE README; do
   install -Dm0644 $RPM_BUILD_DIR/%{buildsubdir}/contrib/$i
 $RPM_BUILD_ROOT%{_defaultdocdir}/%{name}-contrib-%{version}/
 done
 
 Please adapt to new fedora 20 and, learn how to use %doc macro in %files
 section instead of doing this.

As I alluded to above, I made an attempt at this and it failed under F20 and
F21. I don't believe it was properly picking up the documentation for the
subpackages.

 
 9.3 %lang(cs) %{_mandir}/cs/*
 %lang(fi) %{_mandir}/fi/*
 %lang(cs) %{_datadir}/locale/cs/*
 %lang(de) %{_datadir}/locale/de/*
 %lang(fi) %{_datadir}/locale/fi/*
 %lang(fr) %{_datadir}/locale/fr/*
 
 Please learn how to use %find_lang:
 
 http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
 
 
 9.3.1 %lang(fi) %{_datadir}/%{name}/welcome.fi.txt
 %lang(cs) %{_datadir}/%{name}/welcome.cs.txt
 
 Not sure about these 2, but if you use the way mentioned in 9.4, will have
 duplicated files.

Sorry, rpmlint suggested %lang(). I'll update.


 
 13. You have a doc package using checkouted doc by yourself:
 
 cd $RPM_BUILD_DIR/%{buildsubdir}/notion-doc
 make TOPDIR=.. all
 
 You can add %{?_smp_mflags} to it, too. Consider get in touch with upstream
 to release tarball for notion or include them in one tarball.
 

Yes, I'll ping them.

 ***14. This package has bundled libtu and libextl, you are in trouble
 now...***
 

Yeah, I talked with upstream about this prior to writing the spec. According to
the project lead, these libraries aren't actually set up to be used outside
of Notion. The original developer of Ion intended to fully separate them out
into independent libraries but never did. So, in reality they aren't libraries
in the traditional sense and therefore I'd argue that the no bundled
libraries rule doesn't apply.


 
 
 Package has many issues, my brain is broken now. Many hidden issues are not
 found so far, please fix above and then let us run again.
 
 For the legal issue, I really don't have idea, as Debian has said it's
 nonfree.

Thanks for taking a look at this! Sorry I broke your brain. :) I'll make the
changes and update the spec and SRPM. It may be this weekend before I can
address all of the issues and verify that I didn't break anything else.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mario.blaetterm...@gmail.co
   ||m
  Flags||fedora-review?



--- Comment #10 from Mario Blättermann mario.blaetterm...@gmail.com ---
$ rpmlint -i -v *
snappy-player.armv7hl: I: checking
snappy-player.armv7hl: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.armv7hl: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.armv7hl: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.i686: I: checking
snappy-player.i686: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.i686: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.i686: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player.src: I: checking
snappy-player.src: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.src: I: checking-url http://projects.gnome.org/snappy/ (timeout
10 seconds)
snappy-player.src: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-8ece98e0b8b7ea8e79b0d181fb8f79bd8895d3ed.tar.gz
(timeout 10 seconds)
snappy-player.x86_64: I: checking
snappy-player.x86_64: W: spelling-error %description -l en_US gstreamer -
streamer, g streamer, steamer
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: W: spelling-error %description -l en_US minimalistic -
minimalist, minimalism, animistic
The value of this tag appears to be misspelled. Please double-check.

snappy-player.x86_64: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player.x86_64: W: no-manual-page-for-binary snappy
Each executable in standard binary directories should have a man page.

snappy-player-debuginfo.armv7hl: I: checking
snappy-player-debuginfo.armv7hl: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player-debuginfo.i686: I: checking
snappy-player-debuginfo.i686: I: checking-url http://projects.gnome.org/snappy/
(timeout 10 seconds)
snappy-player-debuginfo.x86_64: I: checking
snappy-player-debuginfo.x86_64: I: checking-url
http://projects.gnome.org/snappy/ (timeout 10 seconds)
snappy-player.spec: W: invalid-url Source10: snappy-Makefile.in-src.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source9: snappy-Makefile.in-data-L2.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source8:
snappy-Makefile.in-data-icons.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source7:
snappy-Makefile.in-data-icons-48.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source6:
snappy-Makefile.in-data-icons-256.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source5: snappy-m4-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source4: snappy-libltdl-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source3: snappy-config-Makefile-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source2: snappy-build-aux-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: W: invalid-url Source1: snappy-aclocal.m4-L1.tar.gz
The value should be a valid, public HTTP, HTTPS, or FTP URL.

snappy-player.spec: I: checking-url
https://git.gnome.org/browse/snappy/snapshot/snappy-0.3.7.tar.gz (timeout 10
seconds)
7 packages and 1 

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640



--- Comment #11 from Antonio Trande anto.tra...@gmail.com ---
There is a malfunctioning in snappy, it's documented by this warnings:

(snappy:27349): GLib-GObject-WARNING **: specified class size for type
`ClutterGstVideoSink' is smaller than the parent type's `GstBaseSink' class
size
(snappy:27349): GLib-GObject-WARNING **: cannot register existing type
`GstObject'
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GLib-GObject-CRITICAL **: g_type_register_static: assertion
`parent_type  0' failed
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GLib-GObject-WARNING **: interface type
`GstImplementsInterface' or prerequisite type `invalid' invalid
(snappy:27349): GLib-GObject-CRITICAL **: g_type_add_interface_static:
assertion `G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
(snappy:27349): GLib-GObject-CRITICAL **: g_type_add_interface_static:
assertion `G_TYPE_IS_INSTANTIATABLE (instance_type)' failed
(snappy:27349): GLib-CRITICAL **: g_once_init_leave: assertion `result != 0'
failed
(snappy:27349): GStreamer-CRITICAL **: gst_element_register: assertion
`g_type_is_a (type, GST_TYPE_ELEMENT)' failed

This problem seems caused by a conflict between gstreamer and gstreamer1 if
installed together.
snappy needs 'gstreamer1' but 'gstreamer-old' is required by 'clutter-gst' that
it is another required package.
So I changed 'clutter-gst' in 'clutter-gst2' (snappy requires  clutter-gst =
1.5.5) and conformed the .spec file to find the right header/libs files.
The warnings are disappeared and snappy works better.


I inform the upstream in order to know if this change is acceptable.

I'm sorry, Mario. I have just checked about this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 998141] Review Request: sdformat - The Simulation Description Format

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=998141

Mario Ceresa mrcer...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from Mario Ceresa mrcer...@gmail.com ---
I see no more problems, so the package is
APPROVED

Great work Rich!

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 947640] Review Request: snappy - An open-source Gnome media player

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=947640

Mario Blättermann mario.blaetterm...@gmail.com changed:

   What|Removed |Added

External Bug ID||GNOME Desktop 697640



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1005490] Review Request: SDL2_mixer - Simple DirectMedia Layer - Sample Mixer Library

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1005490



--- Comment #6 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
new SPEC: http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer.spec
new SRPM:
http://ignatenkobrain.fedorapeople.org/for-review/SDL2_mixer-2.0.0-3.fc20.src.rpm

* Wed Nov 20 2013 Igor Gnatenko i.gnatenko.br...@gmail.com - 2.0.0-3
- Add some BuildRequires (cicku)
- Delete pkgconfig from -devel subpackage (cicku)
- Removing external folder in prep section (ignatenkobrain)
- Fix license to correct zlib (cicku  ignatenkobrain)

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 579925] Review Request: tcl-tclreadline - GNU Readline extension for Tcl/Tk

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=579925

Cleber Rodrigues cr...@redhat.com changed:

   What|Removed |Added

 CC||cr...@redhat.com,
   ||redhat-bugzilla@linuxnetz.d
   ||e
  Flags||needinfo?(redhat-bugzilla@l
   ||inuxnetz.de)



--- Comment #6 from Cleber Rodrigues cr...@redhat.com ---
Shouldn't reviews that are stuck after a certain amount of time be closed?

I'm not aware of formal policies, but if the original submitter (Robert Scheck)
agrees this should be put out of the way. IMHO this is better than introducing
a package and then little time later deprecate it.

Robert, is this package still relevant after so much time without any upstream
activity?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 579925] Review Request: tcl-tclreadline - GNU Readline extension for Tcl/Tk

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=579925

Cleber Rodrigues cr...@redhat.com changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2013-11-20 15:38:13



--- Comment #7 from Cleber Rodrigues cr...@redhat.com ---
Answering myself and justifying the action here:

https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews?rd=Extras/Policy/StalledReviews

So I'm closing this BZ. Reopen if this is still a itch you want to scratch.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 579925] Review Request: tcl-tclreadline - GNU Readline extension for Tcl/Tk

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=579925

Cleber Rodrigues cr...@redhat.com changed:

   What|Removed |Added

  Flags|needinfo?(redhat-bugzilla@l |
   |inuxnetz.de)|



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 990423] Review Request: libsodium - A fork of networking and cryptography library with compatible APIs

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=990423



--- Comment #19 from Michael Schwendt bugs.mich...@gmx.net ---
What I meant is it is not in the guidelines [yet]. Some reviewers ask for
verbose build output (me included), but not because it's a MUST in the
guidelines.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #1 from Lokesh Mandvekar l...@redhat.com ---
1. The %{import_path} could be placed in Source0 as well if you wanna make it
shorter, but no biggie.

2. rm -rf $RPM_BUILD_ROOT lines should be removed (is it otherwise causing an
error on el6?) . Also, I remember you saying absence of %defattr complains on
el6, so leaving that in should be ok.

3. as per the prior packaged golang deps, we'd also need:
%dir %attr(755,root,root) %{gopath}/src/github.com
%dir %attr(755,root,root) %{gopath}/src/github.com/syndtr
..in addition to the already existing ones.

4. ls in %install is probably not needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 579925] Review Request: tcl-tclreadline - GNU Readline extension for Tcl/Tk

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=579925

Robert Scheck red...@linuxnetz.de changed:

   What|Removed |Added

 Status|CLOSED  |NEW
 Resolution|NOTABUG |---
   Keywords||Reopened



--- Comment #8 from Robert Scheck red...@linuxnetz.de ---
I am still interested in introducing this package into Fedora EPEL (and maybe
also into Fedora), reopening.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #2 from Vincent Batts vba...@redhat.com ---
1. fair
2. rpmlint noted it. i figured no harm. So i've left it to only the %clean
section.
3. added
4. debug leftover. removed.

spec:
http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-github-syndtr-gocapability.spec
srpm:
http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm

$ rpmlint ./golang-github-syndtr-gocapability.spec 
./golang-github-syndtr-gocapability.spec: W: no-cleaning-of-buildroot %install
./golang-github-syndtr-gocapability.spec: W: no-buildroot-tag
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

$ fedpkg scratch-build --srpm
/home/vbatts/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm
Exception AttributeError: '_read_only' in bound method write.__del__ of
git.config.write object at 0x2600c20 ignored
[] 100% 00:00:00  11.24 KiB  23.09 KiB/sec
Building golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm for
rawhide
Created task: 6207119
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6207119
Watching tasks (this may be safely interrupted)...
6207119 build (rawhide,
golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm): open
(arm02-builder02.arm.fedoraproject.org)
  6207120 buildArch
(golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): free
  6207120 buildArch
(golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): free
- open (buildvm-22.phx2.fedoraproject.org)
  6207121 buildArch
(golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, i686): open
(buildvm-15.phx2.fedoraproject.org)
  6207120 buildArch
(golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, x86_64): open
(buildvm-22.phx2.fedoraproject.org) - closed
  0 free  2 open  1 done  0 failed
  6207121 buildArch
(golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm, i686): open
(buildvm-15.phx2.fedoraproject.org) - closed
  0 free  1 open  2 done  0 failed
6207119 build (rawhide,
golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm): open
(arm02-builder02.arm.fedoraproject.org) - closed
  0 free  0 open  3 done  0 failed

6207119 build (rawhide,
golang-github-syndtr-gocapability-0-0.2.git3454319.el6.src.rpm) completed
successfully

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1026380] Review Request: corebird - Native GTK Twitter client

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1026380

Heiko Adams bugzi...@heiko-adams.de changed:

   What|Removed |Added

 CC||bugzi...@heiko-adams.de



--- Comment #12 from Heiko Adams bugzi...@heiko-adams.de ---
FYI: With todays commit #9fea73447ebb86d82242e104d7804d78e221dbe8 corebird no
longer uses fontawesome:
https://github.com/baedert/corebird/commit/9fea73447ebb86d82242e104d7804d78e221dbe8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 998141] Review Request: sdformat - The Simulation Description Format

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=998141

Rich Mattes richmat...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #19 from Rich Mattes richmat...@gmail.com ---
Thanks for the review Mario!

New Package SCM Request
===
Package Name: sdformat
Short Description: The Simulation Description Format
Owners: rmattes
Branches: f18 f19 f20 el6
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Lokesh Mandvekar l...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #3 from Lokesh Mandvekar l...@redhat.com ---
approved, but may need revision as and when golang packaging guidelines change

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #4 from Vincent Batts vba...@redhat.com ---
New Package SCM Request
===
Package Name: golang-github-syndtr-gocapability
Short Description: POSIX Capability library for the Go programming lanaguage
Owners: vbatts
Branches: f19 f20 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Vincent Batts vba...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #5 from Vincent Batts vba...@redhat.com ---
New Package SCM Request
===
Package Name: golang-github-syndtr-gocapability
Short Description: POSIX Capability library for the Go programming lanaguage
Owners: vbatts
Branches: f19 f20 el6
InitialCC: gol...@lists.fedoraproject.org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #7 from Vincent Batts vba...@redhat.com ---
New Package SCM Request
===
Package Name: golang-github-syndtr-gocapability
Short Description: POSIX Capability library for the Go programming language
Owners: vbatts
Branches: f19 f20 el6
InitialCC: golang-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming lanaguage

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750



--- Comment #6 from Vincent Batts vba...@redhat.com ---
spelling corrections in description

spec:
http://vbatts.fedorapeople.org/rpmbuild/SPECS/golang-github-syndtr-gocapability.spec
srpm:
http://vbatts.fedorapeople.org/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm

$ rpmlint ./golang-github-syndtr-gocapability.spec
./golang-github-syndtr-gocapability.spec: W: no-cleaning-of-buildroot %install
./golang-github-syndtr-gocapability.spec: W: no-buildroot-tag
0 packages and 1 specfiles checked; 0 errors, 2 warnings.

$ fedpkg scratch-build --srpm
/home/vbatts/rpmbuild/SRPMS/golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm
Exception AttributeError: '_read_only' in bound method write.__del__ of
git.config.write object at 0x2d09c20 ignored
[] 100% 00:00:00  11.30 KiB  27.42 KiB/sec
Building golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm for
rawhide
Created task: 6207211
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=6207211
Watching tasks (this may be safely interrupted)...
6207211 build (rawhide,
golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm): open
(arm02-builder14.arm.fedoraproject.org)
  6207213 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): free
  6207212 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): free
  6207212 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): free
- open (buildvm-20.phx2.fedoraproject.org)
  6207213 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): free -
open (buildvm-24.phx2.fedoraproject.org)
  6207213 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, i686): open
(buildvm-24.phx2.fedoraproject.org) - closed
  0 free  2 open  1 done  0 failed
  6207212 buildArch
(golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm, x86_64): open
(buildvm-20.phx2.fedoraproject.org) - closed
  0 free  1 open  2 done  0 failed
6207211 build (rawhide,
golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm): open
(arm02-builder14.arm.fedoraproject.org) - closed
  0 free  0 open  3 done  0 failed

6207211 build (rawhide,
golang-github-syndtr-gocapability-0-0.3.git3454319.el6.src.rpm) completed
successfully

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX Capability library for the Go programming language

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Vincent Batts vba...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-syndtr-gocapa |golang-github-syndtr-gocapa
   |bility - POSIX Capability   |bility - POSIX Capability
   |library for the Go  |library for the Go
   |programming lanaguage   |programming language



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1032750] Review Request: golang-github-syndtr-gocapability - POSIX capability library for the Go programming language

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1032750

Vincent Batts vba...@redhat.com changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-syndtr-gocapa |golang-github-syndtr-gocapa
   |bility - POSIX Capability   |bility - POSIX capability
   |library for the Go  |library for the Go
   |programming language|programming language



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031531

Ricky Elrod rel...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Ricky Elrod rel...@redhat.com ---
New Package SCM Request
===
Package Name: ghc-scotty
Short Description: Haskell web framework inspired by Ruby's Sinatra, using WAI
and Warp
Owners: codeblock petersen
Branches: f20 f19 el6
InitialCC: haskell-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 953514] Review Request: varnish-vmod-querystring - QueryString VMOD for Varnish

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=953514



--- Comment #14 from Ingvar Hagelund ing...@linpro.no ---
As this is not supported by upstream for varnish 3, and I have to find extra
time to work on varnish packaging, I would prefer to wait for varnish 4.

Ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 579925] Review Request: tcl-tclreadline - GNU Readline extension for Tcl/Tk

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=579925

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 Blocks|201449 (FE-DEADREVIEW)  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1000870] Review Request: nini - An uncommonly powerful .NET configuration library

2013-11-20 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1000870



--- Comment #4 from Fedora Update System upda...@fedoraproject.org ---
nini-1.1.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/nini-1.1.0-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >