[Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 Mamoru TASAKA changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Mamoru TASAKA --- Thank you! New Package SCM Request === Package Name: rubygem-rdtool Short Description: Formatter for RD Owners: mtasaka Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
https://bugzilla.redhat.com/show_bug.cgi?id=1034017 Mathieu Bridon changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #2 from Mathieu Bridon --- Thanks for the feedback Petr. All points should be fixed in this new package. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Name-FromLine-0.11-2.fc20.src.rpm -- On the summary/description, I agree that the original one was pretty terrible. The new one should be a bit better, but it's not very clear either. The idea is that you should name your tests when using Test::More: http://search.cpan.org/~rjbs/Test-Simple-1.001002/lib/Test/More.pm#Test_names With this package, tests are automatically named, based on the line of code that defines them. For example, the following test file: use Test::More; is(1, 1); done_testing(); Would output: ok 1 This is because the test is not named. Using Test::Name::FromLine, the output would become: ok 1 - L3: is 1, 1; That is, as if the test had been defined as follows: use Test::More; is(1, 1, "L3: is 1, 1;"); done_testing(); Now, I hope the new summary and description make that a bit more clear, but if you still find it lacking (and/or if you have ideas to improve it), I'll try harder. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
https://bugzilla.redhat.com/show_bug.cgi?id=1034017 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata --- Thanks for the explanation :) It's much better now. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
https://bugzilla.redhat.com/show_bug.cgi?id=1034017 Mathieu Bridon changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Mathieu Bridon --- Thanks for one more review, Petr! -- New Package SCM Request === Package Name: perl-Test-Name-FromLine Short Description: Automatically name tests from their source code Owners: bochecha Branches: devel InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033481] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1033481 --- Comment #3 from Mathieu Bridon --- A new package, removing the inc/ file from the MANIFEST (you asked for it in #1034017, I assumed you'd also ask for it here) Spec URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Test-Time-0.04-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #20 from Mosaab Alzoubi --- Thank You: SPEC URL: http://moceap.fedorapeople.org/islamic-menus.spec SRPM URL: http://moceap.fedorapeople.org/islamic-menus-1.0.6-3.oji.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 Mosaab Alzoubi changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Mosaab Alzoubi --- New Package SCM Request === Package Name: islamic-menus Short Description: Islamic menus for desktops conforming with xdg standards Owners: moceap Branches: f20 f19 f18 el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033494] Review Request:perl-Cache-Memory-Simple - Yet another on memory cache
https://bugzilla.redhat.com/show_bug.cgi?id=1033494 --- Comment #1 from Mathieu Bridon --- Based on your feedback on other review requests, here is a new package that adds missing build requirements and removes unneeded explicit requirements. Spec URL: http://bochecha.fedorapeople.org/packages/perl-Cache-Memory-Simple.spec SRPM URL: http://bochecha.fedorapeople.org/packages/perl-Cache-Memory-Simple-1.02-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034523] Review Request: sqlcli - a tool for running sql queries from the command line using sqlalchemy
https://bugzilla.redhat.com/show_bug.cgi?id=1034523
Kashyap Chamarthy changed:
What|Removed |Added
CC||kcham...@redhat.com
--- Comment #3 from Kashyap Chamarthy ---
Yes, agreed with Christopher Meng's comments, please address them, some more
comments below:
* The reasoning for s/python/python2 is here:
http://fedoraproject.org/wiki/Packaging:Python#Macros -- "The unversioned
macro, %{__python} is deprecated. You should use %{__python2} to explicitly
reference the python2 interpreter instead. This is future proofing for the time
when things will be switched over to python3 by default instead of python2."
* You need a sponsor (I notice you raised FE-NEEDSPONSOR). I'm not one. But I
can review the package.
Just for reference:
http://fedoraproject.org/wiki/How_to_sponsor_a_new_contributor
* And, here are a few rpmlint failures:
=
Rpmlint
---
Checking: sqlcli-1-1.fc20.noarch.rpm
sqlcli-1-1.fc20.src.rpm
sqlcli.noarch: W: summary-ended-with-dot C A SQL query utility.
sqlcli.noarch: W: invalid-license GPL
sqlcli.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/sqlcli/main.py 0644L /usr/bin/python
sqlcli.noarch: W: no-manual-page-for-binary sqlcli
sqlcli.src: W: summary-ended-with-dot C A SQL query utility.
sqlcli.src: W: invalid-license GPL
sqlcli.src: W: no-%build-section
2 packages and 0 specfiles checked; 1 errors, 6 warnings.
Rpmlint (installed packages)
# rpmlint sqlcli
sqlcli.noarch: W: summary-ended-with-dot C A SQL query utility.
sqlcli.noarch: W: invalid-license GPL
sqlcli.noarch: E: non-executable-script
/usr/lib/python2.7/site-packages/sqlcli/main.py 0644L /usr/bin/python
sqlcli.noarch: W: no-manual-page-for-binary sqlcli
1 packages and 0 specfiles checked; 1 errors, 3 warnings.
# echo 'rpmlint-done:'
=
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972943] Review Request: lpf - Local package factory - build non-redistributable rpms
https://bugzilla.redhat.com/show_bug.cgi?id=972943 Alec Leamas changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #30 from Alec Leamas --- Package Change Request == Package Name: lpf New Branches: el6 Owners: slaanesh InitialCC: slaanesh -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894413] Review Request: davmail - DavMail is a POP/IMAP/SMTP/Caldav/Carddav/LDAP gateway for Microsoft Exchange
https://bugzilla.redhat.com/show_bug.cgi?id=894413 --- Comment #47 from Marcel Wysocki --- Update: * Tue Nov 26 2013 maci - 4.4.0-1 - update to 4.4.0 Spec URL: https://raw.github.com/maci0/rpmbuild/master/SPECS/davmail.spec SRPM URL: https://raw.github.com/maci0/rpmbuild/master/SRPMS/davmail-4.4.0-1.fc19.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894413] Review Request: davmail - DavMail is a POP/IMAP/SMTP/Caldav/Carddav/LDAP gateway for Microsoft Exchange
https://bugzilla.redhat.com/show_bug.cgi?id=894413 Christopher Meng changed: What|Removed |Added CC|cicku...@gmail.com | --- Comment #48 from Christopher Meng --- Just a suggestion: Could you use Marcel Wysocki all the time instead of mixed maci? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 705587] Review Request: android-tools - Android platform tools (adb, fastboot, etc)
https://bugzilla.redhat.com/show_bug.cgi?id=705587 --- Comment #34 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=819687 --- Comment #30 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=819687 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 --- Comment #19 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972943] Review Request: lpf - Local package factory - build non-redistributable rpms
https://bugzilla.redhat.com/show_bug.cgi?id=972943 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 972943] Review Request: lpf - Local package factory - build non-redistributable rpms
https://bugzilla.redhat.com/show_bug.cgi?id=972943 --- Comment #31 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977128] Review Request: nodejs-grunt - The JavaScript Task Runner
https://bugzilla.redhat.com/show_bug.cgi?id=977128 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 977128] Review Request: nodejs-grunt - The JavaScript Task Runner
https://bugzilla.redhat.com/show_bug.cgi?id=977128 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #22 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words
https://bugzilla.redhat.com/show_bug.cgi?id=1033986 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033986] Review Request: perl-Lingua-EN-Syllable - Routine for estimating syllable count in words
https://bugzilla.redhat.com/show_bug.cgi?id=1033986 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034492] Review Request: asciinema - Record and upload terminal sessions
https://bugzilla.redhat.com/show_bug.cgi?id=1034492 --- Comment #2 from Jakub Jedelsky --- Thanks for first review Christopher. I know about python 3 support and want to add it, but I'm not sure with naming and file handling. Naming: This package isn't just a python module but a utility/program, so it looks weird to named it python-asciinema to me. Maybe we can named it asciinema and ( python3-asciinema or asciinema-python3 ) ? File handling: I tried to add python3 support, but there is problem with /usr/bin/asciinema file - the main script file - which should be included in both (python and python3) rpms. So one should install just one of them or .. i'm not sure how to solve this. 2., 3. and 4. are included in this pre-python3 version of SPEC: https://gist.github.com/jakubjedelsky/7654715 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
https://bugzilla.redhat.com/show_bug.cgi?id=1034017 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034017] Review Request: perl-Test-Name-FromLine - Auto fill test names from caller line
https://bugzilla.redhat.com/show_bug.cgi?id=1034017 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469317] Review request: lynis - Security and system auditing tool
https://bugzilla.redhat.com/show_bug.cgi?id=469317 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469317] Review request: lynis - Security and system auditing tool
https://bugzilla.redhat.com/show_bug.cgi?id=469317 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 469317] Review request: lynis - Security and system auditing tool
https://bugzilla.redhat.com/show_bug.cgi?id=469317 --- Comment #16 from Fedora Update System --- lynis-1.3.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/lynis-1.3.5-1.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 --- Comment #20 from Fedora Update System --- kyua-testers-0.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kyua-testers-0.1-1.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 --- Comment #21 from Julio Merino --- Package committed, new builds pushed to rawhide and f20 and update to f20 requested. Will leave it up to bodhi to close this bug when the latter happens. Thanks all! Now, to fix the build of kyua-cli... -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034523] Review Request: sqlcli - a tool for running sql queries from the command line using sqlalchemy
https://bugzilla.redhat.com/show_bug.cgi?id=1034523 --- Comment #4 from Lars Kellogg-Stedman --- Thanks for the comments! You'll find an updated spec file (and SRPM) here: https://github.com/larsks-packages/sqlcli/tree/review/sqlcli-2-2 The direct links are: - https://github.com/larsks-packages/sqlcli/raw/review/sqlcli-2-2/sqlcli.spec - https://github.com/larsks-packages/sqlcli/raw/review/sqlcli-2-2/sqlcli-2-2.fc19.src.rpm Validation: $ rpmlint sqlcli.spec ../../RPMS/noarch/sqlcli-2-2.fc19.noarch.rpm sqlcli-2-2.fc19.src.rpm sqlcli.noarch: W: no-manual-page-for-binary sqlcli 2 packages and 1 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1026337] Review Request: nfs-ganesha — a user-mode file server for NFS (v3, 4.0, 4.1 pNFS)
https://bugzilla.redhat.com/show_bug.cgi?id=1026337 Kaleb KEITHLEY changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2013-11-26 10:18:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996209] Review Request: knotter - A free and open source customizable interlace designer
https://bugzilla.redhat.com/show_bug.cgi?id=996209 --- Comment #13 from Miro Hrončok --- Are you still interested in this? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029565] Review Request: python3-cherrypy - Pythonic, object-oriented web development framework
https://bugzilla.redhat.com/show_bug.cgi?id=1029565 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029565] Review Request: python3-cherrypy - Pythonic, object-oriented web development framework
https://bugzilla.redhat.com/show_bug.cgi?id=1029565 --- Comment #11 from Fedora Update System --- python3-cherrypy-3.2.4-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python3-cherrypy-3.2.4-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029565] Review Request: python3-cherrypy - Pythonic, object-oriented web development framework
https://bugzilla.redhat.com/show_bug.cgi?id=1029565 --- Comment #12 from Fedora Update System --- python3-cherrypy-3.2.4-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python3-cherrypy-3.2.4-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029565] Review Request: python3-cherrypy - Pythonic, object-oriented web development framework
https://bugzilla.redhat.com/show_bug.cgi?id=1029565 --- Comment #13 from Fedora Update System --- python3-cherrypy-3.2.4-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/python3-cherrypy-3.2.4-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960645] Review Request: sanewall - A powerful firewall builder
https://bugzilla.redhat.com/show_bug.cgi?id=960645 --- Comment #26 from Susi Lehtola --- Ping. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034347] Review Request: libvirt-python - python binding for libvirt library
https://bugzilla.redhat.com/show_bug.cgi?id=1034347 --- Comment #2 from Cole Robinson --- Some bits flagged by fedora-review: libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod_qemu.so libvirtmod_qemu.so()(64bit) libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod_lxc.so libvirtmod_lxc.so()(64bit) libvirt-python.x86_64: W: private-shared-object-provides /usr/lib64/python2.7/site-packages/libvirtmod.so libvirtmod.so()(64bit) The %filter macros handle this, it's just not the 'newest' way. So that's fine. libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt_lxc.py 0644L /usr/bin/python libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt_qemu.py 0644L /usr/bin/python libvirt-python.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/libvirt.py 0644L /usr/bin/python Indeed /usr/bin/python should be dropped from these files upstream, but not a blocker really. Manual review looks fine. There's some stuff that could be dropped if the spec was only targeting modern Fedora, but given how libvirt tracks specs upstream and still targets RHEL5 it makes sense why devs would want to keep those bits. So ACK. When the official release is done I'll re-review and set the correct flags. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 999959] Review Request: zmap - Network scanner for Internet-wide network studies
https://bugzilla.redhat.com/show_bug.cgi?id=59 --- Comment #19 from Mario Blättermann --- Scratch build fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=6228078 From build.log: + sed -i 's/\r$//' examples/banner-grab examples/banner-grab-go examples/forge-socket examples/udp-probes sed: couldn't edit examples/banner-grab: not a regular file -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725292] Review Request: s3fs-fuse - FUSE-based file system backed by Amazon S3
https://bugzilla.redhat.com/show_bug.cgi?id=725292 --- Comment #28 from Jorge A Gallegos --- Status update: The migration to github already started here: https://github.com/s3fs-fuse/s3fs-fuse and the current maintainer plans on moving the existing docs and issues over (he's already closed a bunch). Regarding naming, the maintainers have already decided and they picked the name 's3fs-fuse' and used it. I hear the new version is nearing, once the whole thing is moved to github so there is a general issue cleanup. I will update the spec file again to point to the new sources when there's a new release. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 948359] Review Request: python-volatility - a digital artifact extraction framework
https://bugzilla.redhat.com/show_bug.cgi?id=948359 --- Comment #27 from Fedora Update System --- python-volatility-2.3.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-volatility-2.3.1-2.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1003301] Review Request: glite-lb-ws-interface - gLite Logging and Bookkeeping web service interface
https://bugzilla.redhat.com/show_bug.cgi?id=1003301 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- glite-lb-ws-interface-4.0.7-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1027512] Review Request: rubygem-tiltout - Tilt templates with layouts and helpers
https://bugzilla.redhat.com/show_bug.cgi?id=1027512 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- rubygem-tiltout-1.4.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 851810] Review Request: mingw-mpfr - MinGW C library for multiple-precision floating-point computations
https://bugzilla.redhat.com/show_bug.cgi?id=851810 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #24 from Fedora Update System --- Package mingw-mpfr-3.1.2-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mingw-mpfr-3.1.2-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-22148/mingw-mpfr-3.1.2-1.fc20 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility
https://bugzilla.redhat.com/show_bug.cgi?id=1033961 Antonio Trande changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029565] Review Request: python3-cherrypy - Pythonic, object-oriented web development framework
https://bugzilla.redhat.com/show_bug.cgi?id=1029565 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #14 from Fedora Update System --- python3-cherrypy-3.2.4-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 998469] Review Request: rubygem-unicode-display_width - Support for east_asian_width string widths
https://bugzilla.redhat.com/show_bug.cgi?id=998469 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- rubygem-unicode-display_width-0.1.1-9.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 912816] Review Request: kyua-testers - Scriptable tester interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=912816 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- kyua-testers-0.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033800] Review Request: rubygem-pkgwat - Check your gems against Fedora/EPEL
https://bugzilla.redhat.com/show_bug.cgi?id=1033800 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- rubygem-pkgwat-0.1.4-4.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034943] New: Review Request: python-elasticsearch - Client for Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1034943 Bug ID: 1034943 Summary: Review Request: python-elasticsearch - Client for Elasticsearch Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dbr...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch.spec SRPM URL: http://dbruno.fedorapeople.org/python-elasticsearch/python-elasticsearch-0.4.3-1.fc19.src.rpm Description: Low level client for Elasticsearch. It's goal is to provide common ground for all Elasticsearch-related code in Python. The client's features include: - Translating basic Python data types to and from json - Configurable automatic discovery of cluster nodes - Persistent connections - Load balancing (with pluggable selection strategy) across all available nodes - Failed connection penalization (time based - failed connections won't be retried until a timeout is reached) - Thread safety - Pluggable architecture Fedora Account System Username: dbruno -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034387] Review Request: lasso - Library that implements the Liberty alliance Single Sign On specification
https://bugzilla.redhat.com/show_bug.cgi?id=1034387
--- Comment #4 from Nalin Dahyabhai ---
Additional:
lasso-php is missing Requires: for php(zend-abi) = %{php_zend_api} and php(api)
= %{php_core_api}, per https://fedoraproject.org/wiki/Packaging:PHP.
lasso-java may be putting the shared object in the wrong location
(%{_libdir}/java vs %{_libdir}/%{name}), but I'd recommend checking with
someone more familiar with Java packaging before changing it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031337] Review Request: notion - A tabbed, tiling window manager forked from Ion3
https://bugzilla.redhat.com/show_bug.cgi?id=1031337 --- Comment #8 from Jeff Backus --- Updated Spec: http://jsbackus.fedorapeople.org/notion.spec Updated SRPM: http://jsbackus.fedorapeople.org/notion-3.2013030200-3.fc18.src.rpm Updated Koji Runs: * F18: http://koji.fedoraproject.org/koji/taskinfo?taskID=6228340 * F19: http://koji.fedoraproject.org/koji/taskinfo?taskID=6228343 * F20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6228346 * Rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6228350 Sorry for the delay. Thanks again for reviewing my package, regardless of formality :) I've made all requested changes, with the following notes: * I found alternatives for dropbox: - I'm moving the repo for maintaining patches, etc. to fedorahosted.org. I'll keep the GitHub one sync'd for now. - Moved transient files (spec and SRPM) to fedorapeople.org. * I split out the pseudo-libraries libtu/libmainloop/libextl to their own subpackages to better conform to Fedora policy. * %find_lang didn't pick up the welcome.[fi|cs].txt files, so I marked them with %lang. Hope that's okay. * No icon and several other WMs don't have one specified, so I'm assuming this is okay. Assuming I suitably addressed all concerns raised in Christopher's review, my understanding is that the only outstanding issue is Legal's blessing on the license. Is this correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #23 from Fedora Update System --- islamic-menus-1.0.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc20 --- Comment #24 from Fedora Update System --- islamic-menus-1.0.6-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #23 from Fedora Update System --- islamic-menus-1.0.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc20 --- Comment #24 from Fedora Update System --- islamic-menus-1.0.6-3.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc18 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #25 from Fedora Update System --- islamic-menus-1.0.6-3.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015765] Review Request: islamic-menus - Islamic menus for desktops conforming with xdg standards
https://bugzilla.redhat.com/show_bug.cgi?id=1015765 --- Comment #26 from Fedora Update System --- islamic-menus-1.0.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/islamic-menus-1.0.6-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033961] Review Request: powerline - The ultimate statusline/prompt utility
https://bugzilla.redhat.com/show_bug.cgi?id=1033961
--- Comment #10 from Antonio Trande ---
- .spec file and src rpm are not contiguous.
- %{_datadir}/vim/site|plugin directories are not owned
- Why not using %{name} instead of powerline in the Require tags ?
- You can use the commit direct download link for Source0
https://github.com/Lokaltog/powerline/archive/db80fc95ed01d2c559c4bdc7da8514ed3cc7fcd9.zip
- Please, leave a comment or an upstream link about the patches
> I see a BuildRoot tag so if your package must be built in EPEL5 too:
- Buildroot is not like those proposed by EPEL packaging guidelines for EPEL5
and below
(https://fedoraproject.org/wiki/EPEL:Packaging#BuildRoot_tag) and
- BuildRoot cleanings are missing
- 'fdupes' is not in EPEL*
- Consider that %{__python2} macro could not work
- In RHEL 5 and older, python2 packages that install python modules need to
define python_sitelib/python_sitearch macros
See https://fedoraproject.org/wiki/Packaging:Python#Macros
> else
- Remove Buildroot tag
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package contains BR: python2-devel or python3-devel
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 85 files have unknown license. Detailed output of
licensecheck in /home/sagitter/1033961-powerline/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/vim/site/plugin, /usr/share/vim/site
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/vim/site,
/usr/share/vim/site/plugin
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 860160 bytes in 81 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by ano
[Bug 1033967] Review Request: ShellCheck - Tool for checking common errors in shell scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1033967 Dridi Boukelmoune changed: What|Removed |Added Summary|Review Request: SchellCheck |Review Request: ShellCheck |- Tool for checking common |- Tool for checking common |errors in shell scripts |errors in shell scripts Alias|SchellCheck |ShellCheck -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032670] Review Request: docker-registry - Registry server for Docker
https://bugzilla.redhat.com/show_bug.cgi?id=1032670
Vincent Batts changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #5 from Vincent Batts ---
Perhaps in the *.service file, it needs some logic to evaluate `firewall-cmd
--add-port=${REGISTRY_PORT}/tcp` or similar for the configured port. Like a
ExecStartPost and ExecStopPost to --remove-port=${REGISTRY_PORT}/tcp. Though in
my trials of getting the docker-registry.service to handle this, the starting
and stopping of the service just hang.
Maybe this needs to just be a documentation point for folks running a registry
server, then they may want to have a permanent rule, like `firewall-cmd
--zone=public --permanent --add-port=5000/tcp` just to be explicit.
What do you think?
The %files should include a line like '%doc LICENSE README.md'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905396] Review Request: rubygem-vagrant - Provisioning and deployment of virtual instances
https://bugzilla.redhat.com/show_bug.cgi?id=905396 Mo Morsi changed: What|Removed |Added CC||ing...@linpro.no, ||mmo...@redhat.com Flags||needinfo?(ing...@linpro.no) --- Comment #4 from Mo Morsi --- Ingvar have you done any more work on the vagrant rpm front? I ask because its been >1/2 year since this updated, there have been a few releases of the vagrant rpm, and adrahon submitted a recent version of the package to BZ here: https://bugzilla.redhat.com/show_bug.cgi?id=1020456 Would you be fine w/ closing this and just going forward w/ 1020456? Once it's Fedora compliant, the package can have multiple owners depending on who wants to actually maintain the releases. Thanks, -Mo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1018384] Review Request: tinyca2 - TinyCA graphical openssl based CA
https://bugzilla.redhat.com/show_bug.cgi?id=1018384 --- Comment #19 from Michael J. Chudobiak --- So... is someone going to build some rpms? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905396] Review Request: rubygem-vagrant - Provisioning and deployment of virtual instances
https://bugzilla.redhat.com/show_bug.cgi?id=905396 Ingvar Hagelund changed: What|Removed |Added Flags|needinfo?(ing...@linpro.no) | --- Comment #5 from Ingvar Hagelund --- Hi Mo and all you others. I did some work on the newer versions of vagrant, and kept in sync with it during spring and summer, but there were always dependencies that were missing in f19 at the time, and it just took too much if my dayjob work time. Also, I have other work to focus on at the moment, so if Alex or any others are willing to provide updated versions to fedora, please go ahead. I'm interested in co-maintaining, so I will follow bug #1020456, but Alex may go forward with his package as main maintainer if he likes for my part. Ingvar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034387] Review Request: lasso - Library that implements the Liberty alliance Single Sign On specification
https://bugzilla.redhat.com/show_bug.cgi?id=1034387 --- Comment #5 from Simo Sorce --- I should have addressed most of the issues you raised here with this new set. I removed the docs as I realized the current code fails to build the html stuff it was supposed to go in the -doc package, so better to supporess it for now and I will make sure upstream fixes it for the next official release. Unfortunatley I am not sure all issues are fixed because my fedora-review (f20) tool does not return me the same results of yours, it return only a fraction of them. I have not addressed the rpmlint complaints about FSF addrss being wrong, I will take a shot at it later, but I wanted to post current spec file to see if we are getting closer to pass the review given I can;t check that myself. Spec URL: http://simo.fedorapeople.org/lasso/2/lasso.spec SRPM URL: http://simo.fedorapeople.org/lasso/2/lasso-2.3.6-0.20131125.2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991221] Review Request: numatop - Memory access locality characterization and analysis
https://bugzilla.redhat.com/show_bug.cgi?id=991221 --- Comment #36 from Peter Robinson --- (In reply to Dridi Boukelmoune from comment #35) > @Peter > > I'm not sure to understand the epel6 guidelines, especially around the > release number [1]. I have uploaded a spec [2] that could have worked for [1] only matters if mainline RHEL is shipping it for say x86-64 but not PPC. In this case it's not an issue. In the case of EL-6 builds it builds fine on x86 32/64 but there's issues with PPC (same as on Fedora) but the issue is in the package. I have a partial patch which gets it further along but it's not complete. I can add what I have if someone can help complete it. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 786636] Review Request: rubygem-unicorn - Rack HTTP server for fast clients and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=786636 --- Comment #11 from Ken Dreyer --- Hi Guillermo, I've pushed a couple more patches to Git: 15. use gem_docdir macro. This commit uses the gem_docdir macro in the %files list instead of manually specifying the same thing. 16. add missing dependency on rack. When testing this on an EL6 box, I found that I needed to have rubygem-rack installed. This commit adds the rack gem to Requires. 17. require rubygems during binary invocation. I found that I needed to have "require 'rubygems'" to make unicorn work properly on EL6. 18. add macros for el6. On RHEL 6 prior to 6.5, many of the modern Ruby and Gem RPM macros are not available. This commit conditionally defines these macros if they happen to be missing. 19. add EL6 conditionals. This commit allows the RPM to be built for EL6. It uses the ruby_sitearch technique I described in comment 6. With this commit, I can successfully run /usr/bin/unicorn on EL6. Git repo: http://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-unicorn.git/log/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031531] Review Request: ghc-scotty - Haskell web framework inspired by Ruby's Sinatra, using WAI and Warp
https://bugzilla.redhat.com/show_bug.cgi?id=1031531 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023605] Review Request: ghc-language-ecmascript - JavaScript parser and pretty-printer library
https://bugzilla.redhat.com/show_bug.cgi?id=1023605 Jens Petersen changed: What|Removed |Added Status|ASSIGNED|POST -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023601] Review Request: ghc-aeson-pretty - JSON pretty-printing library and command-line tool
https://bugzilla.redhat.com/show_bug.cgi?id=1023601 Jens Petersen changed: What|Removed |Added Whiteboard||NotReady -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1029161] Review Request: rubygem-linux_admin - A module to simplify management of Linux systems
https://bugzilla.redhat.com/show_bug.cgi?id=1029161 --- Comment #2 from Ken Dreyer --- Hi Mo, I found two issues that block the review: Requires: rubygem(activesupport) < 4.0 Rails 4 is in Fedora 20, so this means the package won't build on anything higher than F19. Requires: rubygem(more_core_extensions) => 1.1 Requires: rubygem(more_core_extensions) < 2 The more_core_extensions gem is not yet in Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032186] Review Request: rubygem-rack-openid - Provides a more HTTPish API around the ruby-openid library
https://bugzilla.redhat.com/show_bug.cgi?id=1032186 --- Comment #2 from Ken Dreyer --- (rubygem-rots is in F20 and F19, so rubygem-rack-openid can build on those versions of Fedora without issue.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||librcd-0.1.14-2.fc19 Resolution|--- |ERRATA Last Closed||2013-11-26 23:29:30 --- Comment #18 from Fedora Update System --- librcd-0.1.14-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=819687 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819687] Review Request: python-rtkit - Python Api for Request Tracker's REST interface
https://bugzilla.redhat.com/show_bug.cgi?id=819687 --- Comment #31 from Fedora Update System --- python-rtkit-0.6.0-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-rtkit-0.6.0-1.fc19 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1021733] Review Request: python-SecretStorage - Python module for secure storing of passwords and secrets
https://bugzilla.redhat.com/show_bug.cgi?id=1021733 Fedora Update System changed: What|Removed |Added Status|MODIFIED|CLOSED Fixed In Version||python-SecretStorage-1.1.0- ||1.fc19 Resolution|--- |ERRATA Last Closed||2013-11-26 23:38:05 --- Comment #26 from Fedora Update System --- python-SecretStorage-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031250] Review Request: librcd - Library for autodetection charset of Russian and Ukrainian text
https://bugzilla.redhat.com/show_bug.cgi?id=1031250 Fedora Update System changed: What|Removed |Added Fixed In Version|librcd-0.1.14-2.fc19|librcd-0.1.14-2.fc18 --- Comment #19 from Fedora Update System --- librcd-0.1.14-2.fc18 has been pushed to the Fedora 18 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032186] Review Request: rubygem-rack-openid - Provides a more HTTPish API around the ruby-openid library
https://bugzilla.redhat.com/show_bug.cgi?id=1032186 --- Comment #3 from Ken Dreyer --- I've updated to the latest upstream version. * Wed Nov 27 2013 Ken Dreyer - 1.4.1-1 - Update to rack-openid 1.4.1 - Ship license file from upstream Git Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-rack-openid.spec SRPM URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-rack-openid-1.4.1-1.fc21.src.rpm F21 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6230770 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010741] Review Request: python-nikola - Static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1010741 --- Comment #20 from Pete Travis --- Just checking in - are you waiting on something from me before continuing the review, Christopher? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1035129] New: Review Request: rubygem-ensure_valid_encoding - Replace bad bytes in given encoding with replacement strings
https://bugzilla.redhat.com/show_bug.cgi?id=1035129 Bug ID: 1035129 Summary: Review Request: rubygem-ensure_valid_encoding - Replace bad bytes in given encoding with replacement strings Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mtas...@fedoraproject.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-ensure_valid_encoding.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-ensure_valid_encoding-0.5.3-1.fc.src.rpm Description: Replace bad bytes in given encoding with replacement strings, _or_ fail quickly on invalid encodings -- _without_ a transcode to a different encoding. Fedora Account System Username: mtasaka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1032186] Review Request: rubygem-rack-openid - Provides a more HTTPish API around the ruby-openid library
https://bugzilla.redhat.com/show_bug.cgi?id=1032186 Mamoru TASAKA changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mtas...@fedoraproject.org Flags||fedora-review? --- Comment #4 from Mamoru TASAKA --- Taking. I would appreciate it if you would review one of my review requests (e.g. bug 1035129 ) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031316] Review Request: rubygem-rdtool - Formatter for RD
https://bugzilla.redhat.com/show_bug.cgi?id=1031316 Mamoru TASAKA changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2013-11-27 02:00:25 --- Comment #7 from Mamoru TASAKA --- Rebuilt on all branches, push request on F-20/19, closing. Thank you for review and git procedure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1031317] Review Request: rubygem-rttool - Converter from RT into various formats
https://bugzilla.redhat.com/show_bug.cgi?id=1031317 Bug 1031317 depends on bug 1031316, which changed state. Bug 1031316 Summary: Review Request: rubygem-rdtool - Formatter for RD https://bugzilla.redhat.com/show_bug.cgi?id=1031316 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
