[Bug 1026432] Review Request: ghc-pcap - Haskell bindings for libpcap
https://bugzilla.redhat.com/show_bug.cgi?id=1026432
Jens Petersen changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #3 from Jens Petersen ---
Sounds good.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 3 files have unknown license. Detailed output of
licensecheck in /home/petersen/pkgreview/1026432-ghc-
pcap/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
Missing "Requires: pcap-devel" in devel subpackage. I think it is needed.
I recommend appending %{?_isa} to ".*Requires: *libpcap-devel".
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 778240 bytes in 37 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Haskell:
[x]: Static libs in devel package
Yay initial Haskell plugin (output editted;)
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
Except issue listed above
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must b
[Bug 1021080] Review Request: php-horde-Horde-Socket-Client - Horde Socket Client
https://bugzilla.redhat.com/show_bug.cgi?id=1021080 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Socket-Client/php-horde-Horde-Socket-Client.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Socket-Client-1.1.0-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1000359] Review Request: php-horde-Horde-Smtp - Horde SMTP Client
https://bugzilla.redhat.com/show_bug.cgi?id=1000359 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Smtp/php-horde-Horde-Smtp.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Smtp-1.3.1-1.remi.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969438] Review Request: php-horde-Horde-Css-Parser - Horde CSS Parser
https://bugzilla.redhat.com/show_bug.cgi?id=969438 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Css-Parser/php-horde-Horde-Css-Parser.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Css-Parser-1.0.3-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047110] Review Request: php-doctrine-dbal - Doctrine Database Abstraction Layer (DBAL)
https://bugzilla.redhat.com/show_bug.cgi?id=1047110 --- Comment #21 from Adam Williamson --- sure, all's I really care about it for is OC. I didn't get time to do any more testing today, I'm sorry - turned out to be a busy day for errands :/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960849] Review Request: php-horde-Horde-Mongo - Horde Mongo Configuration
https://bugzilla.redhat.com/show_bug.cgi?id=960849 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Mongo/php-horde-Horde-Mongo.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Mongo-1.0.2-1.remi.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 960848] Review Request: php-horde-Horde-Service-Weather - Horde Weather Provider
https://bugzilla.redhat.com/show_bug.cgi?id=960848 --- Comment #1 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Service-Weather/php-horde-Horde-Service-Weather.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Service-Weather-2.0.5-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 949038] Review Request: php-horde-horde - Horde Application Framework
https://bugzilla.redhat.com/show_bug.cgi?id=949038 --- Comment #3 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-horde/php-horde-horde.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-horde-5.1.5-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 929041] Review Request: php-horde-Horde-Kolab-Storage - A package for handling Kolab data stored on an IMAP server
https://bugzilla.redhat.com/show_bug.cgi?id=929041 --- Comment #2 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Kolab-Storage/php-horde-Horde-Kolab-Storage.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Kolab-Storage-2.0.5-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713 --- Comment #4 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-History/php-horde-Horde-History.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-History-2.2.1-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662 --- Comment #6 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-View/php-horde-Horde-View.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-View-2.0.3-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 --- Comment #5 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Core/php-horde-Horde-Core.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Core-2.11.1-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895921] Review Request: php-horde-Horde-Timezone - Timezone library
https://bugzilla.redhat.com/show_bug.cgi?id=895921 --- Comment #3 from Remi Collet --- Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Timezone/php-horde-Horde-Timezone.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Timezone-1.0.4-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895880] Review Request: php-horde-Horde-Share - Horde Shared Permissions System
https://bugzilla.redhat.com/show_bug.cgi?id=895880 --- Comment #3 from Remi Collet --- Update Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Share/php-horde-Horde-Share.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Share-2.0.4-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 894561] Review Request: php-horde-Horde-ListHeaders - Horde List Headers Parsing Library
https://bugzilla.redhat.com/show_bug.cgi?id=894561 --- Comment #1 from Remi Collet --- Update to latest Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-ListHeaders/php-horde-Horde-ListHeaders.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-ListHeaders-1.1.0-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 --- Comment #4 from Remi Collet --- Update to latest Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-SessionHandler/php-horde-Horde-SessionHandler.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-SessionHandler-2.2.3-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API
https://bugzilla.redhat.com/show_bug.cgi?id=874677 --- Comment #6 from Remi Collet --- UPdate to latest version Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Rpc/php-horde-Horde-Rpc.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Rpc-2.1.1-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API
https://bugzilla.redhat.com/show_bug.cgi?id=874677 --- Comment #5 from Remi Collet --- UPdate to latest version Spec: https://raw.github.com/remicollet/remirepo/master/php/horde/php-horde-Horde-Rpc/php-horde-Horde-Rpc.spec Srpm: http://rpms.famillecollet.com/SRPMS/?C=M;O=D -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 490380] Review Request: qt-creator - Lightweight and cross-platform IDE for Qt
https://bugzilla.redhat.com/show_bug.cgi?id=490380 Dave Johansen changed: What|Removed |Added CC||davejohan...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #21 from Dave Johansen --- Package Change Request == Package Name: qt-creator New Branches: el6 Owners: daveisfera InitialCC: itamarjp Adding Qt Creator to EPEL for EL6 so it can be used for development on EL6 machines in addition to Fedora machines. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048667] Review Request: docker-py - An API client for docker written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1048667 --- Comment #1 from Lokesh Mandvekar --- Vincent, hope you don't mind me assigning it to you, feel free to reset it to default assignee :), if anyone else wants to pick it up for review, feel free to jump in :), thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048667] Review Request: docker-py - An API client for docker written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1048667 Lokesh Mandvekar changed: What|Removed |Added CC||fort...@gmail.com, ||mat...@redhat.com, ||mgold...@redhat.com, ||vba...@redhat.com Assignee|nob...@fedoraproject.org|vba...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048667] New: Review Request: docker-py - An API client for docker written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1048667 Bug ID: 1048667 Summary: Review Request: docker-py - An API client for docker written in Python Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://fedorapeople.org/cgit/lsm5/public_git/docker-py.git/plain/SOURCES/docker-py.spec SRPM URL: http://fedorapeople.org/cgit/lsm5/public_git/docker-py.git/tree/SRPMS/docker-py-0.2.3-1.fc21.src.rpm Description: An API client for docker written in Python Fedora Account System Username: lsm5 Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6363131 $ rpmlint SOURCES/docker-py.spec SRPMS/docker-py-0.2.3-1.fc21.src.rpm RPMS/x86_64/docker-py-devel-0.2.3-1.fc21.x86_64.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047110] Review Request: php-doctrine-dbal - Doctrine Database Abstraction Layer (DBAL)
https://bugzilla.redhat.com/show_bug.cgi?id=1047110 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #20 from Shawn Iwinski --- Remi -- THANKS for the review! Adam -- Are you OK for the entire new Doctrine tree to be built in rawhide? I would like to get an email out to the devel list for testing there. New Package SCM Request === Package Name: php-doctrine-dbal Short Description: Doctrine Database Abstraction Layer (DBAL) Owners: siwinski Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1045582] Review Request: php-doctrine-datafixtures - Data Fixtures for all Doctrine Object Managers
https://bugzilla.redhat.com/show_bug.cgi?id=1045582 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Shawn Iwinski --- THANKS for the review! New Package SCM Request === Package Name: php-doctrine-datafixtures Short Description: Data Fixtures for all Doctrine Object Managers Owners: siwinski Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047111] Review Request: php-doctrine-orm - Doctrine Object-Relational-Mapper (ORM)
https://bugzilla.redhat.com/show_bug.cgi?id=1047111 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Shawn Iwinski --- THANKS for the review! New Package SCM Request === Package Name: php-doctrine-orm Short Description: Doctrine Object-Relational-Mapper (ORM) Owners: siwinski Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047109] Review Request: php-doctrine-common - Common library for Doctrine projects
https://bugzilla.redhat.com/show_bug.cgi?id=1047109 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Shawn Iwinski --- THANKS for the review! New Package SCM Request === Package Name: php-doctrine-common Short Description: Common library for Doctrine projects Owners: siwinski Branches: f19 f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044894] Review Request: perl-Crypt-X509 - Parse a X.509 certificate
https://bugzilla.redhat.com/show_bug.cgi?id=1044894 --- Comment #2 from Ralf Corsepius --- (In reply to Christopher Meng from comment #1) > Why filter out perl(Convert::ASN1)? Any cons of removing this dep? This dep also is manually added: ... Requires: perl(Convert::ASN1) >= 0.19 ... Without filtering, the package carry this dep twice, the manually added (versioned) one and an automatically added (unversioned one). The latter is redundant to the former one and thus is unnecessary. As such redundant deps cause dependency bloat in yum metadata files and in rpmdb, its common practice to filter out less such redundant "Requires:". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1044894] Review Request: perl-Crypt-X509 - Parse a X.509 certificate
https://bugzilla.redhat.com/show_bug.cgi?id=1044894 --- Comment #1 from Christopher Meng --- Why filter out perl(Convert::ASN1)? Any cons of removing this dep? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 693137] Review Request: python-ffc - A compiler for finite element variational forms
https://bugzilla.redhat.com/show_bug.cgi?id=693137 Christopher Meng changed: What|Removed |Added Flags||needinfo?(jonathan.underwoo ||d...@gmail.com) --- Comment #7 from Christopher Meng --- Jonathan, are you still interested in taking this review? Since 1.2.0 is released, I hope you can review it again. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy
https://bugzilla.redhat.com/show_bug.cgi?id=1014738 --- Comment #31 from Orion Poplawski --- h5py-2.2.1-2.fc21 has been rebuilt with hdf5 1.8.12 and should fix that issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048621] New: Review Request: zabbix22 - Open-source monitoring solution for your IT infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1048621
Bug ID: 1048621
Summary: Review Request: zabbix22 - Open-source monitoring
solution for your IT infrastructure
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: volke...@gmx.at
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL: http://www.geofrogger.net/review/zabbix22.spec
SRPM URL: http://www.geofrogger.net/review/zabbix22-2.2.1-1.1.fc18.src.rpm
Description:
Zabbix is software that monitors numerous parameters of a network and the
health and integrity of servers. Zabbix uses a flexible notification mechanism
that allows users to configure e-mail based alerts for virtually any event.
This allows a fast reaction to server problems. Zabbix offers excellent
reporting and data visualization features based on the stored data.
This makes Zabbix ideal for capacity planning.
Zabbix supports both polling and trapping. All Zabbix reports and statistics,
as well as configuration parameters are accessed through a web-based front end.
A web-based front end ensures that the status of your network and the health of
your servers can be assessed from any location. Properly configured, Zabbix can
play an important role in monitoring IT infrastructure. This is equally true
for small organizations with a few servers and for large companies with a
multitude of servers.
Fedora Account System Username: volter
This package is intended for EPEL only. It provides the next major version of
Zabbix. A README file tries to explain the changes in packaging to the user and
guide him through the upgrade process.
There are some things I'm not sure about:
User zabbixsrv:zabbix was changed to zabbixsrv:zabbixsrv. I added a scriplet
that replaces the group. Is this acceptable and sane as I did it?
zabbix20 had no "Provides = %{version}-%{release}. I therefore add explicit
Conflicts on zabbix and zabbix20. It might be enough to add that Provides to
zabbix20.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048618] New: Review Request: wp34s - RPN programmable calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1048618 Bug ID: 1048618 Summary: Review Request: wp34s - RPN programmable calculator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: space...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s.spec SRPM URL: http://fedorapeople.org/~brouhaha/wp34s/wp34s-3.2-1.svn3467.fc19.src.rpm Description: The WP 34s project develops alternative scientific calculator firmware for the HP 20b and HP 30b calculators. This package is a build of WP 34s to run natively on Linux. Fedora Account System Username: brouhaha -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048616] Review Request: ocaml-core - Janet Street's OCaml Standard Library
https://bugzilla.redhat.com/show_bug.cgi?id=1048616 Edvard Fagerholm changed: What|Removed |Added URL||https://ocaml.janestreet.co ||m/ocaml-core/latest/doc/ Blocks||177841 (FE-NEEDSPONSOR) Depends On||1048535, 1048534, 1048533 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor https://bugzilla.redhat.com/show_bug.cgi?id=1048533 [Bug 1048533] Upgrade to newest release, needed to compile Jane Street's Core https://bugzilla.redhat.com/show_bug.cgi?id=1048534 [Bug 1048534] Upgrade to newest release, needed to compile Jane Street's Core https://bugzilla.redhat.com/show_bug.cgi?id=1048535 [Bug 1048535] Upgrade to newest release, needed to compile Jane Street's Core -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048616] New: Review Request: ocaml-core - Janet Street's OCaml Standard Library
https://bugzilla.redhat.com/show_bug.cgi?id=1048616 Bug ID: 1048616 Summary: Review Request: ocaml-core - Janet Street's OCaml Standard Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: edvard.fagerh...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://hans.math.upenn.edu/~edvardf/fedora-core/SPEC/ SRPM URL: http://hans.math.upenn.edu/~edvardf/fedora-core/SRPM/ Description: These files provide an alternative standard library for OCaml as well as a build system. This is my first package, so I'm seeking a sponsor. The packages depend on a new release of ocaml-bin-prot, ocaml-type-conv and ocaml-sexplib that are already available in Fedora. I've submitted bug reports asking for these to be updated. Fedora Account System Username: efagerho -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellaneous data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 Fl@sh changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellaneous data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #9 from Fl@sh --- New Package SCM Request === Package Name: sandbox-runner-data Short Description: Basic directories for Sandbox Runners miscellaneous data Owners: f1ash Branches: f19 f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellaneous data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 Fl@sh changed: What|Removed |Added Summary|Review Request: |Review Request: |sandbox-runner-data - Basic |sandbox-runner-data - Basic |directories for Sandbox |directories for Sandbox |Runners miscellanious data |Runners miscellaneous data -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #8 from Fl@sh --- New Package SCM Request === Package Name: sandbox-runner-data Short Description: summary of package Owners: foo bar Branches: f19 f20 el6 InitialCC: baz -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #7 from Fl@sh --- Fixed typo. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests
https://bugzilla.redhat.com/show_bug.cgi?id=866265 --- Comment #17 from Denis Arnaud --- (In reply to Michael Schwendt from comment #16) Many thanks Michael, that is very helpful. I will have a look whenever I can. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825409] Review Request: gazebo - 3D multi-robot simulator with dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=825409 --- Comment #23 from Rich Mattes --- Sorry for the delay, I've been on vacation for the past couple of weeks. I was able to start working on the package again today. The pointer for number of latex runs was helpful, I was able to patch the CMakeLists.txt file to ignore the error on the first run of doxygen then re-run with a larger number of passes until the cross-references settle. The new spec and srpm are at: Spec URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/gazebo/gazebo-2.1.0-1.fc20.src.rpm rpmlint: $ rpmlint gazebo.spec ./fedora-20-x86_64/gazebo-2.1.0-1.fc20/*.rpm gazebo.src: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.src: W: spelling-error %description -l en_US multi -> mulch, mufti gazebo.x86_64: W: spelling-error Summary(en_US) multi -> mulch, mufti gazebo.x86_64: W: spelling-error %description -l en_US multi -> mulch, mufti gazebo.x86_64: W: shared-lib-calls-exit /usr/lib64/libgazebo_ode.so.2.1.0 exit@GLIBC_2.2.5 gazebo.x86_64: W: no-manual-page-for-binary gzlog-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gazebo-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzsdf-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzclient-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzstats-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzserver-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gztopic-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzfactory-2.1.0 gazebo.x86_64: W: no-manual-page-for-binary gzmodel_create gazebo-devel.x86_64: W: no-documentation gazebo-media.noarch: W: no-documentation gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Skydome.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Clouds.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds_Lightning.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX.material gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Moon.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Clouds.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Lightning.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Moon.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Lightning.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Ground.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds_Lightning.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Lightning.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Skydome.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Ground.vertex gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Moon.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Ground.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds.hlsl gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_VolClouds_Lightning.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Clouds.fragment gazebo-media.noarch: E: incorrect-fsf-address /usr/share/gazebo-2.1/media/skyx/SkyX_Skydome.vertex gazebo-playerplugin.x86_64: W: no-documentation 7 packages and 1 specfiles checked; 22 errors, 17 warnings. scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6362361 I'm still looking into the unit test failures. Some of them look like they can be fixed by sourcing the setup.sh file in /usr/share/gazebo -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979124] Review Request: qbs - Qt Build Suite
https://bugzilla.redhat.com/show_bug.cgi?id=979124 --- Comment #23 from Erik Schilling --- Ok. Will fix it tomorrow or bundle it with other stuff you find. Thanks a lot for taking! Regards, Erik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy
https://bugzilla.redhat.com/show_bug.cgi?id=1014738 --- Comment #30 from Sergio Pascual --- I have disabled the HDF version check. The checks still pass Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-astropy.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-astropy-0.3-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1014738] Review Request: python-astropy - A Community Python Library for Astronomy
https://bugzilla.redhat.com/show_bug.cgi?id=1014738 --- Comment #29 from Sergio Pascual --- It may be due to h5py not being rebuilt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Christopher Meng --- Fix typo before SCM: sandbox-runner-data.noarch: W: spelling-error Summary(en_US) miscellanious -> miscellaneous, miscellany - PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045 Sandro Mani changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Sandro Mani --- Good point, I'll change the download link. Thanks for the review! New Package SCM Request === Package Name: python-sphinx-theme-better Short Description: A Better Sphinx Theme Owners: smani Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 797330] Review request: xsensors - An X11 interface to lm_sensors
https://bugzilla.redhat.com/show_bug.cgi?id=797330 --- Comment #30 from Jeremy Newton --- New Package SCM Request === Package Name: xsensors Short Description: An X11 interface to lm_sensors Owners: mystro256 Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Christopher Meng --- Ask upstream of patching these with license header: Unknown or generated sphinx-better-theme-0.1.5/better/__init__.py sphinx-better-theme-0.1.5/docs/conf.py sphinx-better-theme-0.1.5/setup.py And notify him of unusual 600 perms of the tarball. Hint: Instead of renaming the tarball everytime you download, why not directly download good-named one from pypi? https://pypi.python.org/pypi/sphinx-better-theme PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 Adam Williamson changed: What|Removed |Added Blocks||182235 (FE-Legal) --- Comment #13 from Adam Williamson --- adding legal for confirmation of my position in c#10 (if you're not going to confirm it, then go away :P) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #12 from Adam Williamson --- URL fixed for all phpseclib reviews (silent fix, same spec / SRPM URLs as before). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #5 from Fl@sh --- (In reply to Christopher Meng from comment #4) > 403 forbidden. Fixed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #11 from Adam Williamson --- if this was C and it was getting compiled, that might be different, because then there wouldn't necessarily be a copy of the license included with the binary distribution. but that doesn't apply here. whether you install the 'binary' .rpm or the 'source' .rpm, you get a copy of the license text along with the distribution. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #10 from Adam Williamson --- I'm an amateur license nerd. Really, it's fine. I wouldn't say the guidelines are 'ambiguous', I'd just say they're maybe a bit hard to read. But if you follow the logic... First paragraph starts with an 'if' clause: "If the source package includes the text of the license(s) in its own file" Ours doesn't. So we can completely disregard this paragraph. That's not a showstopper, though, the statement is not yet terminated. The following paragraph comes with an implied 'elseif' ;) The rest of the opening of that following paragraph reads: "In cases where the upstream has chosen a license that requires that a copy of the license text be distributed along with the binaries and/or source code, but does not provide a copy of the license text (in the source tree, or in some rare cases, anywhere)" We're not in one of *those* cases either. If you read it carefully this paragraph has an implied converse: "cases where the upstream has chosen a license that requires a copy of the license text...and does provide a copy of the license text (in the source tree or somewhere)". That's the case we're in. Upstream has chosen a license that requires a copy of the license text, and provided one. The license text being in line with the source is the strongest possible association you can have between license and source. Also providing a copy as a separate file is entirely redundant. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045
--- Comment #6 from Sandro Mani ---
Spec URL: http://smani.fedorapeople.org/review/python-sphinx-theme-better.spec
SRPM URL:
http://smani.fedorapeople.org/review/python-sphinx-theme-better-0.1.5-2.fc21.src.rpm
%changelog
* Sun Jan 05 2014 Sandro Mani - 0.1.5-2
- Use %%{__python2} and %%{python2_sitelib}, define these macros for rhel7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 979124] Review Request: qbs - Qt Build Suite
https://bugzilla.redhat.com/show_bug.cgi?id=979124 --- Comment #22 from Christopher Meng --- Please use qmake qt5 macro: [rpmaker@fab qbs]$ rpm -E %_qt5_qmake -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #9 from Remi Collet --- Yes openssl is optional. But as noted in the code: method 1. the fastest And, well, openssl is always here ;) so this is only cosmetic. Requires the prefered extension. About License https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text I will tend to agree with you that the License text is included in the single source script, but the Guidelines seems ambiguous. I will prefer to get confirmation from "legal", and probably fix the Guidelines for this specific case. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #4 from Christopher Meng --- 403 forbidden. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047600] Review Request: php-phpseclib-Crypt-AES - Pure-PHP implementation of AES
https://bugzilla.redhat.com/show_bug.cgi?id=1047600 --- Comment #5 from Adam Williamson --- The point of phpseclib is to be a pure PHP implementation of encryption for when non-PHP deps aren't available, so it seems wrong to depend on the optional non-PHP deps. But it's kind of a tough call. Again, *the license is in line in the source*, in all these packages. I'll fix all the URLs, no need to note on each review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #8 from Adam Williamson --- Again, the license *is included inline in the source*. Each of these packages ultimately contains a small number of PHP files and the XML file, and all the PHP files have the license at the top. There's no need to include the license text in a separate file if it''s already right there in the source. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604
--- Comment #7 from Adam Williamson ---
The use of openssl is also optional, I believe:
// method 1. the fastest
if (function_exists('openssl_random_pseudo_bytes')) {
return openssl_random_pseudo_bytes($length);
}
// method 2
static $fp = true;
if ($fp === true) {
all the openssl stuff just above it is irrelevant because it's for Windows.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048559] Review Request: qt-creator 1.3.1 - Lightweight and cross-platform IDE for Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1048559 Christopher Meng changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2014-01-05 11:29:33 --- Comment #4 from Christopher Meng --- Yes, all you need to do is open the previous qt-creator review request bug and add package change request there, then maintain the el6 branch on your own. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047600] Review Request: php-phpseclib-Crypt-AES - Pure-PHP implementation of AES
https://bugzilla.redhat.com/show_bug.cgi?id=1047600 --- Comment #4 from Remi Collet --- Issues: === [!]: Requires correct, justified where necessary. From package.xml, optional: php-mcrypt Packager choice, but probably better for perf, and available. [!]: Rpmlint is run on all rpms the build produces. W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_AES HTTP Error 404: Not Found [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. My though: this library stack is mostly a wrapper above mcrypt (probably used as some distro, like RHEL, don't have mcrypt), so It think it worth requiring it, as C implementation will be faster than pure PHP one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047600] Review Request: php-phpseclib-Crypt-AES - Pure-PHP implementation of AES
https://bugzilla.redhat.com/show_bug.cgi?id=1047600 --- Comment #3 from Remi Collet --- Created attachment 845784 --> https://bugzilla.redhat.com/attachment.cgi?id=845784&action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047600 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047600] Review Request: php-phpseclib-Crypt-AES - Pure-PHP implementation of AES
https://bugzilla.redhat.com/show_bug.cgi?id=1047600 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED CC||fed...@famillecollet.com Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #2 from Remi Collet --- Created attachment 845783 --> https://bugzilla.redhat.com/attachment.cgi?id=845783&action=edit phpci.log phpcompatinfo version 2.26.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047607] Review Request: php-phpseclib-Crypt-Rijndael - Pure-PHP implementation of Rijndael
https://bugzilla.redhat.com/show_bug.cgi?id=1047607 Remi Collet changed: What|Removed |Added Flags||fedora-review? --- Comment #4 from Remi Collet --- == Issues == [!]: Rpmlint is run on all rpms the build produces. W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Rijndael HTTP Error 404: Not Found [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047607] Review Request: php-phpseclib-Crypt-Rijndael - Pure-PHP implementation of Rijndael
https://bugzilla.redhat.com/show_bug.cgi?id=1047607 --- Comment #3 from Remi Collet --- Created attachment 845782 --> https://bugzilla.redhat.com/attachment.cgi?id=845782&action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047607 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047607] Review Request: php-phpseclib-Crypt-Rijndael - Pure-PHP implementation of Rijndael
https://bugzilla.redhat.com/show_bug.cgi?id=1047607 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED CC||fed...@famillecollet.com Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #2 from Remi Collet --- Created attachment 845781 --> https://bugzilla.redhat.com/attachment.cgi?id=845781&action=edit phpci.log phpcompatinfo version 2.26.0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048559] Review Request: qt-creator 1.3.1 - Lightweight and cross-platform IDE for Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1048559 --- Comment #3 from Michael Schwendt --- All that would be needed is a "Package Change Request": https://fedoraproject.org/wiki/Package_SCM_admin_requests#Package_Change_Requests_for_existing_packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048559] Review Request: qt-creator 1.3.1 - Lightweight and cross-platform IDE for Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1048559 --- Comment #2 from Dave Johansen --- I would like to add it to the EPEL for EL6. Is this not the right way to start that process? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests
https://bugzilla.redhat.com/show_bug.cgi?id=866265 --- Comment #16 from Michael Schwendt --- Re: comment 11 > Multilib support with opentrep-config opentrep-devel.i686 and opentrep-devel.x86_64 conflict with eachother, because this script contains a hardcoded libdir definition. There is no extra rule in the packaging guidelines for multilib conflicts in -devel packages, because they are treated like any other conflicts. Sometimes with lower priority. Sometimes with mass-filed tickets. There's even a tracker ticket for such issues in RHEL6 related repos. > why does the second warning occur? Because rpmlint cannot tell whether a .so file _really_ belongs into a -devel package. It's the responsibility of the packager to decide on that. If the .so file is private shared lib that's part of a Python module, certainly it must not be moved into an optional -devel package. > opentrep-0.5.3-3.fc19.src.rpm $ rpmls opentrep.x86_64|grep pyopentrep -rwxr-xr-x /usr/lib/python2.7/site-packages/opentrep/pyopentrep drwxr-xr-x /usr/lib64/python2.7/site-packages/libpyopentrep lrwxrwxrwx /usr/lib64/python2.7/site-packages/libpyopentrep/libpyopentrep.so lrwxrwxrwx /usr/lib64/python2.7/site-packages/libpyopentrep/libpyopentrep.so.0.5 -rwxr-xr-x /usr/lib64/python2.7/site-packages/libpyopentrep/libpyopentrep.so.0.5.3 -rw-r--r-- /usr/share/man/man1/pyopentrep.1.gz So, the man page covers a program, which is not available in $PATH. Trying to run it with full path: $ /usr/lib/python2.7/site-packages/opentrep/pyopentrep Traceback (most recent call last): File "/usr/lib/python2.7/site-packages/opentrep/pyopentrep", line 286, in import libpyopentrep ImportError: No module named libpyopentrep Additionally, it's stored in /usr/lib but contains a hardcoded /usr/lib64 (see comment 9) and therefore causes a multilib conflict. * "fedora-review -b 866265" reports one source file that is BSD 3-clause licensed and not LGPLv2+: *No copyright* BSD (3 clause) - /var/lib/mock/fedora-20-x86_64/root/builddir/build/BUILD/opentrep-0.5.3/opentrep/basic/float_utils_google.hpp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 --- Comment #3 from Fl@sh --- Added Licenses description; Spec URL: http://f1ash.fedorapeople.org/sandbox-runner-data/sandbox-runner-data.spec SRPM URL: http://f1ash.fedorapeople.org/sandbox-runner-data/sandbox-runner-data-0.2.1-1.fc20.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6361795 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests
https://bugzilla.redhat.com/show_bug.cgi?id=866265 Michael Schwendt changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|bugs.mich...@gmx.net|nob...@fedoraproject.org Flags|fedora-review? | --- Comment #15 from Michael Schwendt --- Sorry. I get too much mail from bugzilla, and an inflational number of "ping"s or non-verbose NEEDINFO requests is not helpful in that case either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047414] Review Request: ioping - Simple disk I/O latency monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1047414 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ioping-0.8-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866265] Review Request: opentrep - C++ API for parsing travel-focused requests
https://bugzilla.redhat.com/show_bug.cgi?id=866265 --- Comment #14 from Christopher Meng --- (In reply to Denis Arnaud from comment #13) > (In reply to Christopher Meng from comment #12) > > ping. > > the package works, and it would make sense to release (approve) it as is. Of > course, some more work would be needed to make it perfect. But, it also > needs quite a lot more time and energy, which I do not have right now... I ping Michael months ago... I don't this package can works fine on RHEL < 7: -- Requires PythonLibs-2.7 -- Found PythonLibs: /usr/lib64/libpython2.7.so (Required is at least version "2.7") -- Found PythonLibs 2.7 -- Requires Boost-1.41 -- Boost version: 1.46.0 -- Found the following Boost libraries: So you'd better optimize the SPEC of conditional lines and remove obsoleted lines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 804125] Review Request: rdkit - A toolkit for cheminformatics and machine learning
https://bugzilla.redhat.com/show_bug.cgi?id=804125
Christopher Meng changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|cicku...@gmail.com
Flags||fedora-review?
--- Comment #22 from Christopher Meng ---
I think package's cmake files should be put under %{_libdir}/cmake/, it
shouldn't be stored directly under libdir.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||cicku...@gmail.com Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #2 from Christopher Meng --- I can take this package, however there remains a question. Licenses file indicates most of them are "mix of oxygen", only 2 of them have URLs which points to pages without any license clarification. Once solved this problem, I will set +. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 916039] Review Request: albumart - Album Cover Art Downloader
https://bugzilla.redhat.com/show_bug.cgi?id=916039
--- Comment #13 from Ankur Sinha (FranciscoD) ---
Updated spec/srpm:
* Sun Jan 05 2014 Ankur Sinha 1.6.6-1
- Update as per review comments
- Patch for PIL support
http://ankursinha.fedorapeople.org/albumart/albumart.spec
http://ankursinha.fedorapeople.org/albumart/albumart-1.6.6-1.fc20.noarch.rpm
[asinha@ankur-laptop SRPMS]$ rpmlint ./albumart-1.6.6-1.fc20.src.rpm
/var/lib/mock/fedora-20-x86_64/result/*.rpm ../SPECS/albumart.spec
albumart.src:57: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/%{name}/*
albumart.noarch: E: explicit-lib-dependency python-urllib3
albumart.src:57: E: hardcoded-library-path in $RPM_BUILD_ROOT/usr/lib/%{name}/*
albumart-konqueror.noarch: W: no-documentation
../SPECS/albumart.spec:57: E: hardcoded-library-path in
$RPM_BUILD_ROOT/usr/lib/%{name}/*
4 packages and 1 specfiles checked; 4 errors, 1 warnings.
[asinha@ankur-laptop SRPMS]$
False positives and ignorable errors. I haven't tested the konqueror package
out, though since I haven't KDE on my system.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684239] Review Request: valadoc - Documentation generator for Vala source
https://bugzilla.redhat.com/show_bug.cgi?id=684239 --- Comment #20 from Christopher Meng --- Raul is a member of Apache, I will contact him off here. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 684239] Review Request: valadoc - Documentation generator for Vala source
https://bugzilla.redhat.com/show_bug.cgi?id=684239 Christopher Meng changed: What|Removed |Added Flags|fedora-review+ | --- Comment #19 from Christopher Meng --- (In reply to Michael Schwendt from comment #18) > This is an odd one. Is Raul a sponsored packager? I find no other review > requests, and the question how to get this published is an eye-brow raiser, > too. > > https://fedoraproject.org/wiki/Join_the_package_collection_maintainers > https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group It's a ludicrous one. I will continue my package review of this software. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048481] Review Request: sandbox-runner-data - Basic directories for Sandbox Runners miscellanious data
https://bugzilla.redhat.com/show_bug.cgi?id=1048481 Fl@sh changed: What|Removed |Added Whiteboard||Trivial --- Comment #1 from Fl@sh --- Fixed Group in spec-file; Marked as Trivial; Spec URL: http://f1ash.fedorapeople.org/sandbox-runner-data/sandbox-runner-data.spec SRPM URL: http://f1ash.fedorapeople.org/sandbox-runner-data/sandbox-runner-data-0.2-2.fc20.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6361639 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048523] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.redhat.com/show_bug.cgi?id=1048523 --- Comment #4 from Christopher Meng --- ffmpeg(BuildRequires: ffmpeg-devel) is "illicit" in Fedora. For packages which depends on ffmpeg(no matter ffmpeg support is optional or a forcible BR), you'd better send it to RPMFusion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048523] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.redhat.com/show_bug.cgi?id=1048523 --- Comment #3 from MartinKG --- are there forbidden items inside ? https://fedoraproject.org/wiki/Forbidden_items?rd=ForbiddenItems -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048523] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.redhat.com/show_bug.cgi?id=1048523 --- Comment #2 from MartinKG --- Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/vdr-softhddevice.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/vdr-softhddevice-0.6.0-2.20130718git1af52dd.fc20.src.rpm %changelog * Sun Jan 05 2014 Martin Gansser - 0.6.0-2.20130718git1af52dd - rebuild - changed license type - removed .git files @Christopher why is the ticket closed ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 951496] Review Request: gimp-lensfun - gimp plugin to correct lens distortion
https://bugzilla.redhat.com/show_bug.cgi?id=951496 Christopher Meng changed: What|Removed |Added CC||cicku...@gmail.com Depends On||1048570 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1048570 [Bug 1048570] lensfun-0.2.8 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048523] Review Request: vdr-softhddevice - A software and GPU emulated HD output device plugin for VDR
https://bugzilla.redhat.com/show_bug.cgi?id=1048523 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2014-01-05 04:52:47 --- Comment #1 from Christopher Meng --- I'm sorry, but this plugin should go to RPMFusion but not Fedora(FFmpeg). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #6 from Remi Collet --- Forget my comment about dependencies. Reading code, only "php-openssl" is needed All others (mcrypt, session, Crypt_*) are only fallbacks which will never be used. So please: -Requires: php-session +Requires: php-openssl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048045] Review Request: python-sphinx-theme-better - A Better Sphinx Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1048045
--- Comment #5 from Christopher Meng ---
Yes, add this line in the first block of %if 0%{?rhel} == 7, ALSO don't forget
%{python_sitelib}.
Once new SRPM uploaded, I'll do a full review.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #5 from Remi Collet --- Notice, could make sense to define and use everywhere: %global pear_channel phpseclib.sourceforge.net -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 Remi Collet changed: What|Removed |Added Flags||fedora-review? --- Comment #4 from Remi Collet --- [!]: Rpmlint is run on all rpms the build produces. invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Random HTTP Error 404: Not Found [!]: Requires correct, justified where necessary. # Optional, From package.xml Requires: php-openssl Requires: php-mcrypt Requires: php-pear(phpseclib.sourceforge.net/Crypt_AES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_TripleDES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_DES) >= 0.2.1 Requires: php-pear(phpseclib.sourceforge.net/Crypt_RC4) >= 0.2.1 This is your choice to require or not optional dep. I personnally think it's better for user experience, especially as this doesn't pull "huge" thing, only small pure PHP library. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. As you have a link to the license file in package.xml you can add this file to the package, which will avoid having to block this review for missing License. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 --- Comment #3 from Remi Collet --- Created attachment 845729 --> https://bugzilla.redhat.com/attachment.cgi?id=845729&action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047604 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED CC||fed...@famillecollet.com Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #2 from Remi Collet --- Created attachment 845728 --> https://bugzilla.redhat.com/attachment.cgi?id=845728&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047478] Review Request: php-irodsphp - PHP client API for iRODS
https://bugzilla.redhat.com/show_bug.cgi?id=1047478 Remi Collet changed: What|Removed |Added Flags||fedora-review+ --- Comment #12 from Remi Collet --- Yes, Naming is really simpler. [x]: Requires correct, justified where necessary. No blocker. == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047478] Review Request: php-irodsphp - PHP client API for iRODS
https://bugzilla.redhat.com/show_bug.cgi?id=1047478 --- Comment #11 from Adam Williamson --- OK, let's just call it php-irodsphp as discussed on IRC, it's a reasonable guess as to the 'project name' as it's in the upstream URL (and it's what OwnCloud decided on). New build with all issues addressed (I hope): https://www.happyassassin.net/reviews/php-irodsphp/php-irodsphp.spec https://www.happyassassin.net/reviews/php-irodsphp/php-irodsphp-3.3.0-0.3.beta1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047478] Review Request: php-irodsphp - PHP client API for iRODS
https://bugzilla.redhat.com/show_bug.cgi?id=1047478 Adam Williamson changed: What|Removed |Added Summary|Review Request: php-irods - |Review Request: |PHP client API for iRODS|php-irodsphp - PHP client ||API for iRODS -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047478] Review Request: php-irods - PHP client API for iRODS
https://bugzilla.redhat.com/show_bug.cgi?id=1047478 --- Comment #10 from Adam Williamson --- I can only have got the PHP version info from phpci; perhaps I ran it against the entire tree and something in the tests or tutorials requires 5.3. I forgot to add the 'missing' module requires to this package, oops, will do. I really don't freaking know what to do with the name any more, this project is such a pain in the ass. Debian calls it php-irods-prods . OwnCloud bundles it in the directory irodsphp . I've got three different names in different bits of my spec. I don't fucking know. Can we throw a dart at something and do whatever it says? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 --- Comment #4 from Remi Collet --- Also need to be fixed: php-phpseclib-crypt-blowfish.src: W: invalid-url URL: http://phpseclib.sourceforge.net/package/Crypt_Blowfish HTTP Error 404: Not Found -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 --- Comment #3 from Remi Collet --- For now build fails. ERROR: bad md5sum for file /dev/shm/extras/BUILDROOT/php-phpseclib-crypt-blowfish-0.3.5-2.fc19.remi.x86_64/usr/share/pear/Crypt/Blowfish-phpseclib.php sed -i -e 's,Blowfish.php,Blowfish-phpseclib.php,g' package.xml => OK. sed -i -e 's,Blowfish.php,Blowfish-phpseclib.php,g' ...Blowfish.php => KO If you change the content of a file, you need to clear the md5sum in the package.xml else the pear install fails. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
