[Bug 1026376] Review Request: fontawesome-fonts - Iconic font set
https://bugzilla.redhat.com/show_bug.cgi?id=1026376 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- fontawesome-fonts-4.0.3-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020467] Review Request: python-scss - A Scss compiler for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1020467 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-scss-1.2.0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-01-10 02:46:44 --- Comment #14 from Fedora Update System --- python-scss-1.2.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051372] Review Request: php-horde-Horde-Form - Horde Form API
https://bugzilla.redhat.com/show_bug.cgi?id=1051372 Remi Collet changed: What|Removed |Added Alias||Horde_Form -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785463] Review Request: php-horde-Horde-Form - Horde Form API
https://bugzilla.redhat.com/show_bug.cgi?id=785463 Remi Collet changed: What|Removed |Added Blocks|908329 (Horde_Core) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=908329 [Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 785463] Review Request: php-horde-Horde-Form - Horde Form API
https://bugzilla.redhat.com/show_bug.cgi?id=785463 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Alias|Horde_Form | Last Closed||2014-01-10 02:40:51 --- Comment #8 from Remi Collet --- Closing as stalled. *** This bug has been marked as a duplicate of bug 1051372 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 Bug 908329 depends on bug 785463, which changed state. Bug 785463 Summary: Review Request: php-horde-Horde-Form - Horde Form API https://bugzilla.redhat.com/show_bug.cgi?id=785463 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 Remi Collet changed: What|Removed |Added Depends On||1051372 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1051372 [Bug 1051372] Review Request: php-horde-Horde-Form - Horde Form API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 Remi Collet changed: What|Removed |Added Depends On|785463 | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=785463 [Bug 785463] Review Request: php-horde-Horde-Form - Horde Form API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051372] Review Request: php-horde-Horde-Form - Horde Form API
https://bugzilla.redhat.com/show_bug.cgi?id=1051372 Remi Collet changed: What|Removed |Added Blocks||908329 (Horde_Core) CC||n...@fedoraproject.org --- Comment #1 from Remi Collet --- *** Bug 785463 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=908329 [Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051372] New: Review Request: php-horde-Horde-Form - Horde Form API
https://bugzilla.redhat.com/show_bug.cgi?id=1051372 Bug ID: 1051372 Summary: Review Request: php-horde-Horde-Form - Horde Form API Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw2.github.com/remicollet/remirepo/370c30464c0ef44619291b359c795d098aaad2b9/php/horde/php-horde-Horde-Form/php-horde-Horde-Form.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Form-2.0.6-2.remi.src.rpm Description: The Horde_Form package provides form rendering, validation, and other functionality for the Horde Application Framework. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046692] Review Request: libcss - a CSS parser and selection engine
https://bugzilla.redhat.com/show_bug.cgi?id=1046692 David Tardon changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from David Tardon --- New Package SCM Request === Package Name: libcss Short Description: A CSS parser and selection engine Owners: dtardon caolanm Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 --- Comment #7 from Remi Collet --- Changes: https://github.com/remicollet/remirepo/commit/8eaa2a2bfe4e1c028f30a8a9871c3f96a176546d Spec: https://raw2.github.com/remicollet/remirepo/8eaa2a2bfe4e1c028f30a8a9871c3f96a176546d/php/horde/php-horde-Horde-Core/php-horde-Horde-Core.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Core-2.11.1-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
https://bugzilla.redhat.com/show_bug.cgi?id=895622 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #7 from Remi Collet --- Changes: https://github.com/remicollet/remirepo/commit/7e5f8feba09f7e9b202d430d52bb3f276bcb9370 Spec: https://raw2.github.com/remicollet/remirepo/7e5f8feba09f7e9b202d430d52bb3f276bcb9370/php/horde/php-horde-Horde-Mime-Viewer/php-horde-Horde-Mime-Viewer.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-Mime-Viewer-2.0.5-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Remi Collet --- Changes: https://github.com/remicollet/remirepo/commit/b86aa8e0e2576631cf9eddc29a0025dc5688403b Spec: https://raw2.github.com/remicollet/remirepo/b86aa8e0e2576631cf9eddc29a0025dc5688403b/php/horde/php-horde-Horde-History/php-horde-Horde-History.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-History-2.2.1-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #10 from Remi Collet --- Changes: https://github.com/remicollet/remirepo/commit/4e828ad0ab837ebf93fbab5a6d1490f0f17b3d4a (even if I'm used to drop the EL-5 stuff after import) Spec: https://raw2.github.com/remicollet/remirepo/4e828ad0ab837ebf93fbab5a6d1490f0f17b3d4a/php/horde/php-horde-Horde-View/php-horde-Horde-View.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-Horde-View-2.0.3-2.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
https://bugzilla.redhat.com/show_bug.cgi?id=895184 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #4 from Remi Collet --- Thanks for the review. Yes I have switch "most" of the Conflicts to Requires, will do on import for this one. New Package SCM Request === Package Name: php-horde-Horde-Text-Filter-Csstidy Short Description: Horde Text Filter API Owners: remmi Branches: f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Remi Collet --- Thanks for the review. I will take care of the cleanup on import New Package SCM Request === Package Name: php-horde-Horde-SessionHandler Short Description: Horde Session Handler API Owners: remi Branches: f20 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047599] Review Request: php-phpseclib-Math-BigInteger - Pure-PHP arbitrary precision integer arithmetic library
https://bugzilla.redhat.com/show_bug.cgi?id=1047599 --- Comment #13 from Remi Collet --- @shawn, what are the remaining blockers ? If only the missing license, you can probably approved this package, as I have approved the other, thinking having the license text inclued in the file header is enough for a script language. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047608] Review Request: php-phpseclib-Crypt-RSA - Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA
https://bugzilla.redhat.com/show_bug.cgi?id=1047608 --- Comment #8 from Remi Collet --- Created attachment 848058 --> https://bugzilla.redhat.com/attachment.cgi?id=848058&action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047608 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047608] Review Request: php-phpseclib-Crypt-RSA - Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA
https://bugzilla.redhat.com/show_bug.cgi?id=1047608 Remi Collet changed: What|Removed |Added Flags||fedora-review+ --- Comment #9 from Remi Collet --- [!] Package installs properly. Of course, wait for dependencies before importing the package. No Blocker == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036396] Review Request: python-social-auth - Social auth made simple
https://bugzilla.redhat.com/show_bug.cgi?id=1036396
--- Comment #6 from Christopher Meng ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Sources used to build the package match the upstream source, as provided in
the spec URL.
Note: Check did not completechecksum differs and there are problems running
diff. Please verify manually.
See: http://fedoraproject.org/wiki/Packaging/SourceURL
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 400 files have unknown license. Detailed output
of licensecheck:
Unknown or generated
python-social-auth-0.1.17/%{py3dir}/docs/conf.py
python-social-auth-0.1.17/%{py3dir}/setup.py
python-social-auth-0.1.17/%{py3dir}/social/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/actions.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/context_processors.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/admin.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/default/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/me/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/middleware.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/tests.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/urls.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/django_app/views.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/routes.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/template_filters.py
python-social-auth-0.1.17/%{py3dir}/social/apps/flask_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/__init__.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/pyramid_app/views.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/handlers.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/routes.py
python-social-auth-0.1.17/%{py3dir}/social/apps/tornado_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/app.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/fields.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/models.py
python-social-auth-0.1.17/%{py3dir}/social/apps/webpy_app/utils.py
python-social-auth-0.1.17/%{py3dir}/social/backends/amazon.py
python-social-auth-0.1.17/%{py3dir}/social/backends/angel.py
python-social-auth-0.1.17/%{py3dir}/social/backends/aol.py
python-social-auth-0.1.17/%{py3dir}/social/backends/appsfuel.py
python-social-auth-0.1.17/%{py3dir}/social/backends/base.py
python-social-auth-0.1.17/%{py3dir}/social/backends/behance.py
python-social-auth-0.1.17/%{py3dir}/social/backends/belgiumeid.py
python-social-auth-0.1.17/%{py3dir}/social/backends/bitbucket.py
python-social-auth-0.1.17/%{py3dir}/social/backends/box.py
python-social-auth-0.1.17/%{py3dir}/social/backends/dailymotion.py
python-social-auth-0.1.17/%{py3dir}/social/backends/disqus.py
python-social-auth-0.1.17/%{py3dir}/social/backends/douban.py
python-social-auth-0.1.17/%{py3dir}/social/backends/dropbox.py
python-social-auth-0.1.17/%{py3dir}/social/backends/email.py
python-social-auth-0.1.17/%{py3dir}/social/backends/evernote.py
python-social-auth-0.1.17/%{py3dir}/social/backends/exacttarget.py
python-social-auth-0.1.17/%{py3dir}/social/backends/facebook.py
python-social-auth-0.1.17/%{py3dir}/social/backends/fedora.py
python-social-auth-0.1.17/%{py3dir}/social/backends/fitbit.py
python-social-auth-0.1.17/%{py3dir}/social/backends/flickr.py
python-social-aut
[Bug 1047608] Review Request: php-phpseclib-Crypt-RSA - Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA
https://bugzilla.redhat.com/show_bug.cgi?id=1047608 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #7 from Remi Collet --- Created attachment 848057 --> https://bugzilla.redhat.com/attachment.cgi?id=848057&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047609] Review Request: php-phpseclib-Crypt-TripleDES - Pure-PHP implementation of Triple DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047609 Remi Collet changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Remi Collet --- [x]: Requires correct, justified where necessary. [x]: Package does not own files or directories owned by other packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047610] Review Request: php-phpseclib-Crypt-Twofish - Pure-PHP implementation of Twofish
https://bugzilla.redhat.com/show_bug.cgi?id=1047610 Remi Collet changed: What|Removed |Added Flags||fedora-review+ --- Comment #6 from Remi Collet --- [x]: Requires correct, justified where necessary. [x]: Package does not own files or directories owned by other packages. == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047602] Review Request: php-phpseclib-Crypt-DES - Pure-PHP implementation of DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047602 Remi Collet changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #8 from Remi Collet --- [x]: Requires correct, justified where necessary. [x]: Package does not own files or directories owned by other packages. == APPROVED == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 Remi Collet changed: What|Removed |Added Flags||fedora-review? --- Comment #9 from Remi Collet --- [!]: Requires correct, justified where necessary. From package.xml, option so package choice php-mcrypt From code, used in Crypt_Blowfish::setPawword() php-pear(phpseclib.sourceforge.net/Crypt_Hash) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. => License text is included in the single source header [x]: Package does not own files or directories owned by other packages. Ok, but if you add require on Crypt_Hash, you have to drop the ownership of /usr/share/pear/Crypt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 --- Comment #8 from Remi Collet --- Created attachment 848054 --> https://bugzilla.redhat.com/attachment.cgi?id=848054&action=edit review.txt Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review -b 1047610 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #7 from Remi Collet --- Created attachment 848052 --> https://bugzilla.redhat.com/attachment.cgi?id=848052&action=edit phpci.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046692] Review Request: libcss - a CSS parser and selection engine
https://bugzilla.redhat.com/show_bug.cgi?id=1046692 Christopher Meng changed: What|Removed |Added Flags||fedora-review+ --- Comment #2 from Christopher Meng --- Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 15 files have unknown license. Detailed output of licensecheck: MIT/X11 (BSD like) -- libcss-0.2.0/build/mkprops.pl libcss-0.2.0/include/libcss/computed.h libcss-0.2.0/include/libcss/errors.h libcss-0.2.0/include/libcss/font_face.h libcss-0.2.0/include/libcss/fpmath.h libcss-0.2.0/include/libcss/functypes.h libcss-0.2.0/include/libcss/hint.h libcss-0.2.0/include/libcss/libcss.h libcss-0.2.0/include/libcss/properties.h libcss-0.2.0/include/libcss/select.h libcss-0.2.0/include/libcss/stylesheet.h libcss-0.2.0/include/libcss/types.h libcss-0.2.0/src/bytecode/bytecode.h libcss-0.2.0/src/bytecode/opcodes.h libcss-0.2.0/src/charset/detect.c libcss-0.2.0/src/charset/detect.h libcss-0.2.0/src/lex/lex.c libcss-0.2.0/src/lex/lex.h libcss-0.2.0/src/parse/font_face.c libcss-0.2.0/src/parse/font_face.h libcss-0.2.0/src/parse/important.c libcss-0.2.0/src/parse/important.h libcss-0.2.0/src/parse/language.c libcss-0.2.0/src/parse/language.h libcss-0.2.0/src/parse/parse.c libcss-0.2.0/src/parse/parse.h libcss-0.2.0/src/parse/properties/azimuth.c libcss-0.2.0/src/parse/properties/background.c libcss-0.2.0/src/parse/properties/background_position.c libcss-0.2.0/src/parse/properties/border.c libcss-0.2.0/src/parse/properties/border_color.c libcss-0.2.0/src/parse/properties/border_spacing.c libcss-0.2.0/src/parse/properties/border_style.c libcss-0.2.0/src/parse/properties/border_width.c libcss-0.2.0/src/parse/properties/clip.c libcss-0.2.0/src/parse/properties/column_rule.c libcss-0.2.0/src/parse/properties/columns.c libcss-0.2.0/src/parse/properties/content.c libcss-0.2.0/src/parse/properties/css_property_parser_gen.c libcss-0.2.0/src/parse/properties/cue.c libcss-0.2.0/src/parse/properties/cursor.c libcss-0.2.0/src/parse/properties/elevation.c libcss-0.2.0/src/parse/properties/font.c libcss-0.2.0/src/parse/properties/font_family.c libcss-0.2.0/src/parse/properties/font_weight.c libcss-0.2.0/src/parse/properties/list_style.c libcss-0.2.0/src/parse/properties/list_style_type.c libcss-0.2.0/src/parse/properties/margin.c libcss-0.2.0/src/parse/properties/opacity.c libcss-0.2.0/src/parse/properties/outline.c libcss-0.2.0/src/parse/properties/padding.c libcss-0.2.0/src/parse/properties/pause.c libcss-0.2.0/src/parse/properties/play_during.c libcss-0.2.0/src/parse/properties/properties.c libcss-0.2.0/src/parse/properties/properties.h libcss-0.2.0/src/parse/properties/quotes.c libcss-0.2.0/src/parse/properties/text_decoration.c libcss-0.2.0/src/parse/properties/utils.c libcss-0.2.0/src/parse/properties/utils.h libcss-0.2.0/src/parse/properties/voice_family.c libcss-0.2.0/src/parse/propstrings.c libcss-0.2.0/src/parse/propstrings.h libcss-0.2.0/src/select/computed.c libcss-0.2.0/src/select/computed.h libcss-0.2.0/src/select/dispatch.c libcss-0.2.0/src/select/dispatch.h libcss-0.2.0/src/select/font_face.c libcss-0.2.0/src/select/font_face.h libcss-0.2.0/src/select/hash.c libcss-0.2.0/src/select/hash.h libcss-0.2.0/src/select/properties/azimuth.c libcss-0.2.0/src/select/properties/background_attachment.c libcss-0.2.0/src/select/properties/background_color.c libcss-0.2.0/src/select/properties/background_image.c libcss-0.2.0/src/select/properties/background_position.c libcss-0.2.0/src/select/properties/background_repeat.c libcss-0.2.0/src/select/properties/border_bottom_color.c libcss-0.2.0/src/select/properties/border_bottom_style.c libcss-0.2.0/src/select/properties/border_bottom_width.c libcss-0.2.0/src/select/properties/border_collapse.c libcss-0.2.0/src/select/properties/border_left_color.c libcss-0.2.0/src/select/properties/border_left_style.c libcss-0.2.0/src/select/properties/border_left_width.c libcss-0.2.0/src/select/properties/border_right_color.c libcss-0.2.0/src/select/properties/border_right_style.c libcss
[Bug 1036297] Review Request: python-libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297 --- Comment #29 from Fedora Update System --- python-libturpial-1.1.16-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-libturpial-1.1.16-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1036297] Review Request: python-libturpial - library needed to new turpial (twitter client) version
https://bugzilla.redhat.com/show_bug.cgi?id=1036297 --- Comment #30 from Fedora Update System --- python-libturpial-1.1.16-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-libturpial-1.1.16-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009842] Rename Request: ghc-highlighting-kate - Sourcecode syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1009842 --- Comment #8 from Jens Petersen --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6382826 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1009842] Rename Request: ghc-highlighting-kate - Sourcecode syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1009842 Jens Petersen changed: What|Removed |Added Status|MODIFIED|ASSIGNED Flags|needinfo?(petersen@redhat.c | |om) | --- Comment #7 from Jens Petersen --- Good catch, thanks. I had given the wrong executable name to %ghc_fix_dynamic_rpath. I filed bug 1051291: an cabal-rpm rfe to extract the executable name automatically. I also added a check to %ghc_fix_dynamic_rpath in Rawhide so that it now fails if the program name does not exist. The rpath issue should be fixed in: Spec: http://petersen.fedorapeople.org/reviews/ghc-highlighting-kate/ghc-highlighting-kate.spec SRPM: http://petersen.fedorapeople.org/reviews/ghc-highlighting-kate/ghc-highlighting-kate-0.5.6-1.fc20.src.rpm which also updates to 0.5.6. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1049634] Review Request: python-pymilter - Python interface to sendmail milter API
https://bugzilla.redhat.com/show_bug.cgi?id=1049634 --- Comment #2 from Paul Wouters --- * Fri Jan 10 2014 Paul Wouters - 0.9.8-4 - Add COPYING - Fix buildroot macros and dist macro Spec URL: ftp://ftp.nohats.ca/python-pymilter/python-pymilter.spec SRPM URL: ftp://ftp.nohats.ca/python-pymilter/python-pymilter-0.9.8-4.fc20.src.rpm This should address all issues found -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 Shawn Iwinski changed: What|Removed |Added Blocks||874677 (Horde_Rpc) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=874677 [Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 874677] Review Request: php-horde-Horde-Rpc - Horde RPC API
https://bugzilla.redhat.com/show_bug.cgi?id=874677 Shawn Iwinski changed: What|Removed |Added Depends On||908329 (Horde_Core) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=908329 [Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908329] Review Request: php-horde-Horde-Core - Horde Core Framework libraries
https://bugzilla.redhat.com/show_bug.cgi?id=908329 Shawn Iwinski changed: What|Removed |Added CC||shawn.iwin...@gmail.com --- Comment #6 from Shawn Iwinski --- Circular dependency with Horde_Form (bug 785463). Since Horde_Form is optional (and there seems to be no response to your pings from the owner), just comment it out until it is avail. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010557] Review Request: numix-themes - Numix themes for Gnome, Xfce and Openbox
https://bugzilla.redhat.com/show_bug.cgi?id=1010557 Christopher Meng changed: What|Removed |Added CC|cicku...@gmail.com | --- Comment #15 from Christopher Meng --- Please also read this link: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group Note that ypu should find a sponsor actively, not sponsors find you. I will remove myself from this bug as I can't sponsor you. Anyway, hope you can be sponsored soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
https://bugzilla.redhat.com/show_bug.cgi?id=895622
--- Comment #6 from Shawn Iwinski ---
Issues:
===
- EPEL5 requires explicit %clean with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
- EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
https://bugzilla.redhat.com/show_bug.cgi?id=895622 --- Comment #5 from Shawn Iwinski --- Created attachment 848000 --> https://bugzilla.redhat.com/attachment.cgi?id=848000&action=edit fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 895622 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, BATCH, DISTTA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
https://bugzilla.redhat.com/show_bug.cgi?id=895622 --- Comment #4 from Shawn Iwinski --- Created attachment 847999 --> https://bugzilla.redhat.com/attachment.cgi?id=847999&action=edit phpcompatinfo.log phpcompatinfo version 2.26.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895622] Review Request: php-horde-Horde-Mime-Viewer - Horde MIME Viewer Library
https://bugzilla.redhat.com/show_bug.cgi?id=895622 Shawn Iwinski changed: What|Removed |Added CC||shawn.iwin...@gmail.com Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010512] Review Request: mesos - Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1010512
--- Comment #16 from Will Benton ---
(In reply to Timothy St. Clair from comment #15)
> updated, with same urls.
>
> You will notice I conditionalized the .spec file around that.
I did! Thanks for changing the default behavior; you can remove those
conditionals and related comments when you make these last few changes. Here's
the rest of my updated review (reflecting the spec as of earlier today with the
generated tarball):
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- mesos must BuildRequire: python2-devel. See
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
- The spec must work from a pristine upstream tarball unless there are legal
reasons why we cannot. Please move all bundled library removal in the %prep
scriptlet and use an upstream tarball.
- Integration.patch is 1.8 mb and primarily consists of file moves, which makes
it tedious to inspect. Please move files in %prep rather than in a patch! In
addition, consider splitting up Fedora integration changes into several smaller
patches that each reflect a high-level change.
- mesos should not own %{_unitdir}.
- The python interface should go in %{python_sitearch}. As it stands, it looks
like it's getting built but not installed. (It looks like the makefile needs
to call out to setup.py.)
- I think %{python_sitelib} is a more appropriate place for the (internal?)
modules that get installed in libexecdir:
https://fedoraproject.org/wiki/Packaging:Guidelines#Libexecdir If these are
part of the mesos module (from the client library), I think they'll need to go
in sitearch since the rest of the mesos module is arch-specific.
- I'll buy that the rpmlint error is possibly spurious, and I see that you've
opened a JIRA upstream about it.
- Consider splitting the web UI out into a noarch subpackage. Also, you should
track the "handwavy future" of the Web Assets work, since that will impact this
package sooner or later:
http://fedoraproject.org/wiki/Changes/Web_Assets#Handwavy_Future
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "BSD (3 clause)", "Unknown or generated". 223 files have
unknown license. Detailed output of licensecheck in
/home/wibenton/devel/review/1010512-mesos/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/systemd, /etc/tmpfiles.d
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/systemd/system(systemd)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 81920 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(
[Bug 1010557] Review Request: numix-themes - Numix themes for Gnome, Xfce and Openbox
https://bugzilla.redhat.com/show_bug.cgi?id=1010557 Suchakra changed: What|Removed |Added CC||sucha...@gmail.com --- Comment #14 from Suchakra --- 1. Add a new changelog entry for each revision - even during review. Bump the release too. 2. This blocks FE-NEEDSPONSOR so your potential future sponsor has to do a formal review 3. Try to run rpmlint on the spec once. Some minor errors like the following can escape your eye: numix-themes.spec: E: specfile-error warning: bogus date in %changelog: Thu Jan 9 2013 Satyajit Sahoo - 2.1-1 4. Also, it would be beneficial if you can test builds in mock or koji. (I already checked using mock, it works for now) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 --- Comment #4 from Patrick Huang --- updated: Spec URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations.spec SRPM URL: http://fedorapeople.org/~pahuang/enunciate-core-annotations-1.27-2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713
--- Comment #7 from Shawn Iwinski ---
Issues:
===
- EPEL5 requires explicit %clean with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
- EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713 --- Comment #6 from Shawn Iwinski --- Created attachment 847991 --> https://bugzilla.redhat.com/attachment.cgi?id=847991&action=edit fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 909713 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713 --- Comment #5 from Shawn Iwinski --- Created attachment 847985 --> https://bugzilla.redhat.com/attachment.cgi?id=847985&action=edit phpcompatinfo.log phpcompatinfo version 2.26.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909713] Review Request: php-horde-Horde-History - API for tracking the history of an object
https://bugzilla.redhat.com/show_bug.cgi?id=909713 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662
--- Comment #9 from Shawn Iwinski ---
Issues:
===
- EPEL5 requires explicit %clean with rm -rf %{buildroot} (or $RPM_BUILD_ROOT)
- EPEL5: Package does run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
Allowable diff
Diff spec file in url and in SRPM
-
--- 909662-php-horde-Horde-View/srpm/php-horde-Horde-View.spec2014-01-06
15:41:41.08400 -0500
+++ 909662-php-horde-Horde-View/srpm-unpacked/php-horde-Horde-View.spec
2013-08-23 05:13:43.0 -0400
@@ -39,5 +39,5 @@
Requires: php-pear(%{pear_channel}/Horde_Util) >= 2.0.0
Requires: php-pear(%{pear_channel}/Horde_Util) < 3.0.0
-# Optional
+# Optionnal
Requires: php-pear(%{pear_channel}/Horde_Controller) >= 2.0.0
Requires: php-pear(%{pear_channel}/Horde_Controller) < 3.0.0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662 --- Comment #8 from Shawn Iwinski --- Created attachment 847984 --> https://bugzilla.redhat.com/attachment.cgi?id=847984&action=edit fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 909662 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662 --- Comment #7 from Shawn Iwinski --- Created attachment 847983 --> https://bugzilla.redhat.com/attachment.cgi?id=847983&action=edit phpcompatinfo.log phpcompatinfo version 2.26.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 909662] Review Request: php-horde-Horde-View - Horde View API
https://bugzilla.redhat.com/show_bug.cgi?id=909662 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
https://bugzilla.redhat.com/show_bug.cgi?id=895184 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Shawn Iwinski --- [x]: Package does not generate any conflict. Allowable max version conflict. Some other Horde pkgs do not use conflict for max version though. No blockers = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
https://bugzilla.redhat.com/show_bug.cgi?id=895184 --- Comment #2 from Shawn Iwinski --- Created attachment 847982 --> https://bugzilla.redhat.com/attachment.cgi?id=847982&action=edit fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 895184 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
https://bugzilla.redhat.com/show_bug.cgi?id=895184 --- Comment #1 from Shawn Iwinski --- Created attachment 847981 --> https://bugzilla.redhat.com/attachment.cgi?id=847981&action=edit phpcompatinfo.log phpcompatinfo version 2.26.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 895184] Review Request: php-horde-Horde-Text-Filter-Csstidy - Horde Text Filter API
https://bugzilla.redhat.com/show_bug.cgi?id=895184 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 Shawn Iwinski changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Shawn Iwinski --- A couple notes for after initial import: * Is there a reason you did not add "php-json" require? * PEAR require should be updated to "php-pear(PEAR) >= 1.7.0" to match package.xml and other Horde packages No blockers = APPROVED = -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 --- Comment #6 from Shawn Iwinski --- Created attachment 847980 --> https://bugzilla.redhat.com/attachment.cgi?id=847980&action=edit fedora-review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review --mock-config fedora-rawhide-x86_64 --define EPEL5 -b 890927 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, BATCH, DISTTAG -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 --- Comment #5 from Shawn Iwinski --- Created attachment 847979 --> https://bugzilla.redhat.com/attachment.cgi?id=847979&action=edit phpcompatinfo.log phpcompatinfo version 2.26.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 890927] Review Request: php-horde-Horde-SessionHandler - Horde Session Handler API
https://bugzilla.redhat.com/show_bug.cgi?id=890927 Shawn Iwinski changed: What|Removed |Added Assignee|nob...@fedoraproject.org|shawn.iwin...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010512] Review Request: mesos - Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #15 from Timothy St. Clair --- updated, with same urls. You will notice I conditionalized the .spec file around that. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 Ding-Yi Chen changed: What|Removed |Added Status|MODIFIED|ASSIGNED --- Comment #3 from Ding-Yi Chen --- Sorry, wrong number in bodhi update. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 --- Comment #2 from Fedora Update System --- cmake-fedora-1.2.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/cmake-fedora-1.2.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047414] Review Request: ioping - Simple disk I/O latency monitoring tool
https://bugzilla.redhat.com/show_bug.cgi?id=1047414 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||ioping-0.8-2.el6 Resolution|--- |ERRATA Last Closed||2014-01-09 20:10:35 --- Comment #10 from Fedora Update System --- ioping-0.8-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1034523] Review Request: sqlcli - a tool for running sql queries from the command line using sqlalchemy
https://bugzilla.redhat.com/show_bug.cgi?id=1034523 --- Comment #20 from Fedora Update System --- sqlcli-2-3.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048667] Review Request: python-docker-py - An API client for docker written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1048667 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #17 from Fedora Update System --- python-docker-py-0.2.3-5.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 Ding-Yi Chen changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Ding-Yi Chen --- Running rpmlint rpmlint -i RPMS/noarch/enunciate-core-annotations-1.27-1.fc20.noarch.rpm enunciate-core-annotations.noarch: W: spurious-executable-perm /usr/share/doc/enunciate-core-annotations/license.txt The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. enunciate-core-annotations.noarch: W: spurious-executable-perm /usr/share/doc/enunciate-core-annotations/notice.txt The file is installed with executable permissions, but was identified as one that probably should not be executable. Verify if the executable bits are desired, and remove if not. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050729] Review Request: enunciate-core-annotations - Build-time enhancement tool for Java-based Web services projects
https://bugzilla.redhat.com/show_bug.cgi?id=1050729 Ding-Yi Chen changed: What|Removed |Added CC||dc...@redhat.com Assignee|nob...@fedoraproject.org|dc...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033987] Review Request: perl-Lingua-EN-Fathom - Measure readability of English text
https://bugzilla.redhat.com/show_bug.cgi?id=1033987 Ruediger Landmann changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2014-01-09 18:57:29 --- Comment #6 from Ruediger Landmann --- Thanks Parag, Jeff, and Jon :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753577] Review Request: gmsh - finite element grid generator
https://bugzilla.redhat.com/show_bug.cgi?id=753577 --- Comment #23 from Alexey Vasyukov --- (In reply to Bruno Postle from comment #22) [skip] > Note that Open CASCADE has recently been relicenced as LGPL: > http://www.opencascade.org/getocc/download/loadocc/ Yes, and that's really good. As far as I understand, Eric Smith is going to package OpenCASCADE for Fedora - http://thread.gmane.org/gmane.linux.redhat.fedora.legal/2090 So, we can review other issues and update their status. If nothing bad (from legal point of view) happened recently with gmsh, we have only technical issues to work on. (Plus wait until OpenCASCADE becomes available in Fedora repos.) I'll try to review the latest gmsh upstream sources in the next few days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050953] Review Request: octave-parallel - Parallel execution package for cluster computers for Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1050953 --- Comment #9 from Fedora Update System --- octave-parallel-2.1.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050953] Review Request: octave-parallel - Parallel execution package for cluster computers for Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1050953 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1050953] Review Request: octave-parallel - Parallel execution package for cluster computers for Octave
https://bugzilla.redhat.com/show_bug.cgi?id=1050953 --- Comment #8 from Fedora Update System --- octave-parallel-2.1.1-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/octave-parallel-2.1.1-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047608] Review Request: php-phpseclib-Crypt-RSA - Pure-PHP PKCS#1 (v2.1) compliant implementation of RSA
https://bugzilla.redhat.com/show_bug.cgi?id=1047608 --- Comment #6 from Adam Williamson --- Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-rsa/php-phpseclib-crypt-rsa-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051254] New: Review Request: python-patsy - Describing statistical models in Python using symbolic formulas
https://bugzilla.redhat.com/show_bug.cgi?id=1051254 Bug ID: 1051254 Summary: Review Request: python-patsy - Describing statistical models in Python using symbolic formulas Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: sergio.pa...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://guaix.fis.ucm.es/~spr/fedora/python-patsy.spec SRPM URL: http://guaix.fis.ucm.es/~spr/fedora/python-patsy-0.2.1-1.fc20.src.rpm Description: A Python package for describing statistical models and for building design matrices. It is closely inspired by and compatible with the 'formula' mini-language used in R and S. Fedora Account System Username: sergiopr -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047609] Review Request: php-phpseclib-Crypt-TripleDES - Pure-PHP implementation of Triple DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047609 --- Comment #5 from Adam Williamson --- Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-tripledes/php-phpseclib-crypt-tripledes-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047602] Review Request: php-phpseclib-Crypt-DES - Pure-PHP implementation of DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047602 --- Comment #6 from Adam Williamson --- Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-des/php-phpseclib-crypt-des.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-des/php-phpseclib-crypt-des-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1010512] Review Request: mesos - Cluster Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1010512 --- Comment #14 from Will Benton --- The generated tarball policy doesn't apply in this case if there is nothing in the upstream tarball that we're legally encumbered from uploading to SCM. Please move the bundled library deletion to your %prep scriptlet and work from a pristine source. I'll update the rest of the review in a separate comment. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047602] Review Request: php-phpseclib-Crypt-DES - Pure-PHP implementation of DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047602 --- Comment #7 from Adam Williamson --- Stealth updated to also drop ownership of the Crypt/ dir. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047610] Review Request: php-phpseclib-Crypt-Twofish - Pure-PHP implementation of Twofish
https://bugzilla.redhat.com/show_bug.cgi?id=1047610 --- Comment #5 from Adam Williamson --- Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-twofish/php-phpseclib-crypt-twofish-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 --- Comment #5 from Adam Williamson --- Updated: https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish.spec https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib- crypt-blowfish-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 --- Comment #6 from Adam Williamson --- grr. https://www.happyassassin.net/reviews/php-phpseclib-crypt-blowfish/php-phpseclib-crypt-blowfish-0.3.5-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047599] Review Request: php-phpseclib-Math-BigInteger - Pure-PHP arbitrary precision integer arithmetic library
https://bugzilla.redhat.com/show_bug.cgi?id=1047599 --- Comment #12 from Adam Williamson --- So, is this one approved or not? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 753577] Review Request: gmsh - finite element grid generator
https://bugzilla.redhat.com/show_bug.cgi?id=753577 Bruno Postle changed: What|Removed |Added CC||br...@postle.net --- Comment #22 from Bruno Postle --- (In reply to T.C. Hollingsworth from comment #21) > > OpenCASCADE's non-freeness is described in detail here: > http://lists.fedoraproject.org/pipermail/legal/2011-September/001713.html > > > And FYI, here is a citation of the upstream reply to whether gmesh > > functionality will be severely reduced by not linking against open cascade: > > "Yes: not linking with opencascade means that Gmsh will not be able to > > import CAD models in STEP, IGES or BRep formats." > > Hmm, gmsh might do better in rpmfusion-nonfree then. If gmsh will have to > be stripped down so much to be useless to most end users, there's really no > point in shipping it in Fedora proper. Note that Open CASCADE has recently been relicenced as LGPL: http://www.opencascade.org/getocc/download/loadocc/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047607] Review Request: php-phpseclib-Crypt-Rijndael - Pure-PHP implementation of Rijndael
https://bugzilla.redhat.com/show_bug.cgi?id=1047607 Bug 1047607 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047610] Review Request: php-phpseclib-Crypt-Twofish - Pure-PHP implementation of Twofish
https://bugzilla.redhat.com/show_bug.cgi?id=1047610 Bug 1047610 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047605] Review Request: php-phpseclib-Crypt-RC4 - Pure-PHP implementation of RC4
https://bugzilla.redhat.com/show_bug.cgi?id=1047605 Bug 1047605 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047596] Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR
https://bugzilla.redhat.com/show_bug.cgi?id=1047596 Adam Williamson changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2014-01-09 17:10:13 --- Comment #9 from Adam Williamson --- Built in all branches. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047603] Review Request: php-phpseclib-Crypt-Hash - Pure-PHP implementations of keyed-hash message authentication codes (HMACs) and various cryptographic hashing functions
https://bugzilla.redhat.com/show_bug.cgi?id=1047603 Bug 1047603 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047599] Review Request: php-phpseclib-Math-BigInteger - Pure-PHP arbitrary precision integer arithmetic library
https://bugzilla.redhat.com/show_bug.cgi?id=1047599 Bug 1047599 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047602] Review Request: php-phpseclib-Crypt-DES - Pure-PHP implementation of DES
https://bugzilla.redhat.com/show_bug.cgi?id=1047602 Bug 1047602 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047601] Review Request: php-phpseclib-Crypt-Blowfish - Pure-PHP implementation of Blowfish
https://bugzilla.redhat.com/show_bug.cgi?id=1047601 Bug 1047601 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047604] Review Request: php-phpseclib-Crypt-Random - Random Number Generator
https://bugzilla.redhat.com/show_bug.cgi?id=1047604 Bug 1047604 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047600] Review Request: php-phpseclib-Crypt-AES - Pure-PHP implementation of AES
https://bugzilla.redhat.com/show_bug.cgi?id=1047600 Bug 1047600 depends on bug 1047596, which changed state. Bug 1047596 Summary: Review Request: php-channel-phpseclib - Adds the phpseclib channel to PEAR https://bugzilla.redhat.com/show_bug.cgi?id=1047596 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965417] Review Request: editorconfig-core-python - Clone of EditorConfig core written in Python
https://bugzilla.redhat.com/show_bug.cgi?id=965417 --- Comment #3 from Michael Schwendt --- > I'm not sure if we have a real Python module here Well, it is a Python Module with a public API *and* an executable. One could say this is "a program" named "EditorConfig" (upstream name) and package it as "editorconfig" in a single package. One could also make that the base package name and put the language specific APIs into subpackages. The web page tells: | Currently there is a C library and a Python library, and a Java binding | for the Python library. The Python Module is called "EditorConfig Python Core": http://pydocs.editorconfig.org/en/latest/ For Fedora, naming it "editorconfig-core-python" does not adhere to current guidelines, because there is no python- prefix. The conditional Python 3 build currently specifies the name "python3-editorconfig-core-python", which doesn't follow the guidelines either. The spec file is untested, however, since tags must start in the first column: error: line 25: Unknown tag: BuildRequires: python3-devel And fixing that results in a %build failure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047478] Review Request: php-irodsphp - PHP client API for iRODS
https://bugzilla.redhat.com/show_bug.cgi?id=1047478 Adam Williamson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-01-09 17:02:15 --- Comment #15 from Adam Williamson --- Built for Rawhide, will build for other branches as needed by OwnCloud (I requested f20 and el6 as it's possible we'll bump to OC 6 on those). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1051128] Review Request: R-TH.data - Data for other R packages
https://bugzilla.redhat.com/show_bug.cgi?id=1051128
Thomas Sailer changed:
What|Removed |Added
CC||t.sai...@alumni.ethz.ch
--- Comment #1 from Thomas Sailer ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
=> GPLv3
[X]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
=> package does not include license text
[!]: License field in the package spec file matches the actual license.
=> are you sure it is GPLv3+? DESCRIPTION simply says "GPL-3".
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[X]: Package contains desktop file if it is a GUI application.
=> no GUI app
[X]: Development files must be in a -devel package
=> no devel files
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[X]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[X]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
R:
[x]: Package contains the mandatory BuildRequires.
[x]: Package have the default element marked as %%doc :DESCRIPTION
[x]: The package has the standard %install section.
[x]: Package requires R-core.
= SHOULD items =
Generic:
[X]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
=> does this make sense? or how is it handled in the R domain?
[X]: Final provides and requires are sane (see attachments).
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[X]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly re
