[Bug 1071507] Review Request python-tuskarclient - Python bindings and CLI to Tuskar
https://bugzilla.redhat.com/show_bug.cgi?id=1071507 Mukundan Ragavan changed: What|Removed |Added CC||nonamed...@gmail.com --- Comment #1 from Mukundan Ragavan --- Hi Jordan, I can review this package if you do not have "time-related" objections -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070671] Review Request: perl-Test-Kwalitee-Extra - Run Kwalitee tests including optional indicators
https://bugzilla.redhat.com/show_bug.cgi?id=1070671 --- Comment #9 from Mukundan Ragavan --- My pleasure! Thanks for answering my doubts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1064657] Review Request: exciting - FP-LAPW Code
https://bugzilla.redhat.com/show_bug.cgi?id=1064657 --- Comment #1 from Mukundan Ragavan --- Hi marcin, I am interested in reviewing this package but it might be take me sometime to do that. If you do not have "time-related" objections, I can take this package for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1013095] Review Request: cube - CUBE Uniform Behavioral Encoding generic presentation component
https://bugzilla.redhat.com/show_bug.cgi?id=1013095
--- Comment #6 from Mukundan Ragavan ---
There are some issues with the package. Please see the detailed review below.
If I can clarify any points, please let me know.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Packages have proper BuildRequires/Requires on jpackage-utils
---> BuildRequires and cube-java has Requires: jpackage-utils - looks fine.
Does cube also require this? Requires does not show that below.
- gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in cube
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- Javadoc documentation files are generated and included in -javadoc
subpackage
Note: No javadoc subpackage present
See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
- This seems like a Java package, please install fedora-review-plugin-java to
get additional checks
---> I don't why fedora-review is saying this when it **is** using the java
plugin!
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 2068480 bytes in 29 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- update-desktop-database is invoked in %post and %postun if package contains
desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in cube
See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-
database
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or
generated". 696 files have unknown license. Detailed output of
licensecheck in
/home/mukundan/personal/pkgs/reviews/1013095-cube/licensecheck.txt
---> This is fine. The subset I checked all have BSD license.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is
[Bug 1033433] Review Request: budgie - Simple and distraction free GTK+3 media player
https://bugzilla.redhat.com/show_bug.cgi?id=1033433 Christopher Meng changed: What|Removed |Added Flags||needinfo?(sergio.pasra@gmai ||l.com) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 653917] Review Request: gimagereader - A tesseract OCR front-end
https://bugzilla.redhat.com/show_bug.cgi?id=653917 Fedora Update System changed: What|Removed |Added Fixed In Version|gimagereader-2.91-1.fc20|gimagereader-2.91-1.fc19 --- Comment #25 from Fedora Update System --- gimagereader-2.91-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065306] Review Request: pyxtrlock - The X transparent screen lock rewritten in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1065306 Fedora Update System changed: What|Removed |Added Fixed In Version|pyxtrlock-0.2-5.fc19|pyxtrlock-0.2-5.fc20 --- Comment #18 from Fedora Update System --- pyxtrlock-0.2-5.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1053222] Review Request: fedora-dockerfiles - Example dockerfiles to assist standing up containers quickly
https://bugzilla.redhat.com/show_bug.cgi?id=1053222 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||fedora-dockerfiles-0-0.3.gi ||t7753bdf.fc20 Resolution|--- |ERRATA Last Closed||2014-03-01 22:45:32 --- Comment #18 from Fedora Update System --- fedora-dockerfiles-0-0.3.git7753bdf.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 866260] Review Request: juel - Java Unified Expression Language Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=866260 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||juel-2.2.7-1.fc20 Resolution|--- |ERRATA Last Closed||2014-03-01 22:43:30 --- Comment #9 from Fedora Update System --- juel-2.2.7-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 968136] Review Request: camel - Apache Camel integration framework
https://bugzilla.redhat.com/show_bug.cgi?id=968136 Bug 968136 depends on bug 866260, which changed state. Bug 866260 Summary: Review Request: juel - Java Unified Expression Language Implementation https://bugzilla.redhat.com/show_bug.cgi?id=866260 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063044] Review Request: dh-autoreconf - debhelper add-on to call autoreconf and clean up after the build
https://bugzilla.redhat.com/show_bug.cgi?id=1063044 Bug 1063044 depends on bug 1063043, which changed state. Bug 1063043 Summary: Review Request: cdbs - Common build system for Debian packages https://bugzilla.redhat.com/show_bug.cgi?id=1063043 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063043] Review Request: cdbs - Common build system for Debian packages
https://bugzilla.redhat.com/show_bug.cgi?id=1063043 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||cdbs-0.4.122-2.fc20 Resolution|--- |ERRATA Last Closed||2014-03-01 22:42:14 --- Comment #11 from Fedora Update System --- cdbs-0.4.122-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065306] Review Request: pyxtrlock - The X transparent screen lock rewritten in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1065306 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pyxtrlock-0.2-5.fc19 Resolution|--- |ERRATA Last Closed||2014-03-01 22:42:23 --- Comment #17 from Fedora Update System --- pyxtrlock-0.2-5.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063044] Review Request: dh-autoreconf - debhelper add-on to call autoreconf and clean up after the build
https://bugzilla.redhat.com/show_bug.cgi?id=1063044 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dh-autoreconf-9-2.fc20 Resolution|--- |ERRATA Last Closed||2014-03-01 22:41:37 --- Comment #12 from Fedora Update System --- dh-autoreconf-9-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 653917] Review Request: gimagereader - A tesseract OCR front-end
https://bugzilla.redhat.com/show_bug.cgi?id=653917 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||gimagereader-2.91-1.fc20 Resolution|--- |ERRATA Last Closed||2014-03-01 22:40:22 --- Comment #24 from Fedora Update System --- gimagereader-2.91-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071581] Review Request: python-wikitools - Python package for interacting with a MediaWiki wiki
https://bugzilla.redhat.com/show_bug.cgi?id=1071581 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #1 from Mukundan Ragavan --- I will take it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 965007] Review Request: gedit-trailsave - Gedit plugin who strip trailing whitespace on save
https://bugzilla.redhat.com/show_bug.cgi?id=965007 Stephen changed: What|Removed |Added CC||fed...@nuclearsunshine.com --- Comment #21 from Stephen --- Per https://github.com/jonleighton/gedit-trailsave/issues/10 this was ported to Python 3 three months ago - any interest in reviving this bug? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071581] New: Review Request: python-wikitools - Python package for interacting with a MediaWiki wiki
https://bugzilla.redhat.com/show_bug.cgi?id=1071581 Bug ID: 1071581 Summary: Review Request: python-wikitools - Python package for interacting with a MediaWiki wiki Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: hho...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://hhorak.fedorapeople.org/python-wikitools/python-wikitools.spec SRPM URL: http://hhorak.fedorapeople.org/python-wikitools/python-wikitools-1.1.1-2.src.rpm Description: A Python package for interacting with a MediaWiki wiki using the MediaWiki API. Designed for MediaWiki version 1.16 and higher, should work on 1.13, older versions may have bugs. The edit-API must be enabled on the site to use editing features. Fedora Account System Username: hhorak -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1020457] Review Request: rubygem-vagrant-kvm - KVM plugin for Vagrant
https://bugzilla.redhat.com/show_bug.cgi?id=1020457 Achilleas Pipinellis changed: What|Removed |Added Status|ASSIGNED|NEW CC||axill...@axilleas.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1057766] Review Request: clustal-omega - command line tool for multiple sequence alignment
https://bugzilla.redhat.com/show_bug.cgi?id=1057766 --- Comment #16 from Mukundan Ragavan --- FPC ticket files requesting bundled library exception. https://fedorahosted.org/fpc/ticket/399 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065685] Review Request: rubygem-unicorn - Rack HTTP server for fast clients and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1065685 Achilleas Pipinellis changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875087] Review Request: pbsclusterviz - Visualise the status of PBS clusters
https://bugzilla.redhat.com/show_bug.cgi?id=875087
--- Comment #25 from Orion Poplawski ---
- You didn't bump release and add a new changelog entry for these changes. I
guess this hasn't be explicit, but I want it for any change to the spec.
- You only need to run desktop-file-install, not both it and
desktop-file-validate, it will validate the desktop file.
- If you wanted, you could just do:
# desktop files
%{datadir}/icons/hicolor/256x256/apps/
%{_datadir}/applications/pbsclusterviz.desktop
up to you.
- You need to update the icon cache:
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1012696] Review Request: opari2 - An OpenMP runtime performance measurement instrumenter
https://bugzilla.redhat.com/show_bug.cgi?id=1012696 Orion Poplawski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #13 from Orion Poplawski --- New Package SCM Request === Package Name: opari2 Short Description: An OpenMP runtime performance measurement instrumenter Owners: orion Branches: f20 f19 epel7 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060920] Review Request: openni2 - OpenNI libraries for 3D-sensing
https://bugzilla.redhat.com/show_bug.cgi?id=1060920 Christopher Meng changed: What|Removed |Added CC|cicku...@gmail.com | --- Comment #11 from Christopher Meng --- I removed myself from CC, hope you can find some people to finish the review soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 819480] Review Request: limesurvey - a web-based survey application
https://bugzilla.redhat.com/show_bug.cgi?id=819480 Christopher Meng changed: What|Removed |Added Status|ASSIGNED|CLOSED CC|cicku...@gmail.com | Blocks||201449 (FE-DEADREVIEW) Resolution|--- |NOTABUG Last Closed||2014-03-01 13:39:25 --- Comment #32 from Christopher Meng --- I can't see any updates from the submitter since 2012/06, so closing it should be the proper way. If you want to submit it, please reopen it. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 990544] Review Request: mangler - VOIP client capable of connecting to Ventrilo 3.x servers
https://bugzilla.redhat.com/show_bug.cgi?id=990544 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|cicku...@gmail.com Flags||fedora-review? --- Comment #8 from Christopher Meng --- 404. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1012696] Review Request: opari2 - An OpenMP runtime performance measurement instrumenter
https://bugzilla.redhat.com/show_bug.cgi?id=1012696 Christopher Meng changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #12 from Christopher Meng --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1057496] Review Request: senna - An embeddable fulltext search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1057496 Christopher Meng changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Christopher Meng --- New Package SCM Request === Package Name: senna Short Description: An embeddable fulltext search engine Owners: cicku Branches: f19 f20 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875087] Review Request: pbsclusterviz - Visualise the status of PBS clusters
https://bugzilla.redhat.com/show_bug.cgi?id=875087 --- Comment #24 from Paul Cochrane --- (In reply to Orion Poplawski from comment #21) Hi Orion, I've addressed the points you raised in Comment #21. The SRCRPM, SPEC and distribution tarball are at the usual location: - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a-4.el6.src.rpm - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz-0.7a.tar.gz - https://github.com/paultcochrane/pbsclusterviz/releases/download/v0.7a/pbsclusterviz.spec Thanks, Paul -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 908088] Review Request: ascend - ASCEND modelling environment
https://bugzilla.redhat.com/show_bug.cgi?id=908088 Antonio Trande changed: What|Removed |Added Flags||needinfo?(rdie...@math.unl. ||edu) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071554] Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1071554 --- Comment #2 from Erik Schilling --- Apply http://ablu.fedorapeople.org/0001-Updated-to-0.19-release-split-out-engine-code.patch to the fedora flare package repository if you want to test a packaged mod against the engine. Regards, Erik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071554] Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1071554 Erik Schilling changed: What|Removed |Added Assignee|nob...@fedoraproject.org|cicku...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071554] Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1071554 Erik Schilling changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #1 from Erik Schilling --- Trying to assign to Christopher Meng as he requested in #1052191. But no idea if i am doing it right... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071554] Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1071554 Erik Schilling changed: What|Removed |Added Blocks||1052191 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1052191 [Bug 1052191] flare-0.19 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071554] New: Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1071554 Bug ID: 1071554 Summary: Review Request: flare-engine - A single player, 2D-isometric, action Role-Playing Engine Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ablu.erikschill...@googlemail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://ablu.fedorapeople.org/flare-engine.spec SRPM URL: http://ablu.fedorapeople.org/flare-engine-0.19-1.fc20.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6583078 Fedora Account System Username: ablu Description: Flare (Free Libre Action Roleplaying Engine) is a simple game engine built to handle a very specific kind of game: single-player 2D action RPGs. Flare is not a re-implementation of an existing game or engine. It is a tribute to and exploration of the action RPG genre. Rather than building a very abstract, robust game engine, the goal of this project is to build several real games and harvest an engine from the common, reusable code. The first game, in progress, is a fantasy dungeon crawl. Flare uses simple file formats (INI style config files) for most of the game data, allowing anyone to easily modify game contents. Open formats are preferred (png, ogg). The game code is C++. This package contains the engine only. rpmlint: flare-engine.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.src: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.src: W: spelling-error %description -l en_US ogg -> egg, org, boggy flare-engine.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flare-engine.x86_64: W: spelling-error %description -l en_US png -> pg, ping, pang flare-engine.x86_64: W: spelling-error %description -l en_US ogg -> egg, org, boggy 3 packages and 0 specfiles checked; 0 errors, 6 warnings. This package is splitting out the engine out of the current flare package in order to allow other flare mods being packaged. Regards, Erik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1057496] Review Request: senna - An embeddable fulltext search engine
https://bugzilla.redhat.com/show_bug.cgi?id=1057496 Igor Gnatenko changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Igor Gnatenko --- No more issues here. Again, sorry for delay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022551] Review Request: bouncycastle-pkix - CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle
https://bugzilla.redhat.com/show_bug.cgi?id=1022551 --- Comment #16 from Ville Skyttä --- (In reply to gil cattaneo from comment #13) > This seem for me unnecessary because in Fedora bouncycastle 1.50 already > exist ... It might actually be unnecessary but not for that reason. 1.50 exists only in F-21/Rawhide at the moment and the obsoletes is necessary for people who upgrade from F-20 to F-21 so that functionality doesn't just disappear on yum upgrade. But why it actually could be considered unnecessary is that simply installing the pkix package (which is what the Obsoletes would accomplish) is almost never enough to keep software from breaking; classpath adjustments will be required as well. This is by the way a big reason why 1.50 should not be pushed to earlier distros than F-21/Rawhide. In addition to that, there are also quite a few API incompatibilities in 1.46 compared to 1.50 (as the author of Portecle, a piece which uses BouncyCastle APIs quite extensively I happen to be painfully aware of this). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071495] Review Request: spark - Lightning-fast cluster computing
https://bugzilla.redhat.com/show_bug.cgi?id=1071495 --- Comment #1 from Will Benton --- Added GraphX, Bagel, MLLib, and Spark Streaming: Spec URL: http://freevariable.com/spark/spark.spec SRPM URL: http://freevariable.com/spark/spark-0.9.0-0.2.fc19.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022551] Review Request: bouncycastle-pkix - CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle
https://bugzilla.redhat.com/show_bug.cgi?id=1022551 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from gil cattaneo --- Thanks! New Package SCM Request === Package Name: bouncycastle-pkix Short Description: CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle Owners: gil msrb Branches: f20 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1063428] Review Request: rubygem-bogus - Create fakes to make your isolated unit tests reliable
https://bugzilla.redhat.com/show_bug.cgi?id=1063428 Achilleas Pipinellis changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022551] Review Request: bouncycastle-pkix - CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle
https://bugzilla.redhat.com/show_bug.cgi?id=1022551 Mattias Ellert changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from Mattias Ellert --- Package Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071204] Review Request: perl-Gtk3-WebKit - WebKit bindings for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1071204 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- perl-Gtk3-WebKit-0.04-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065678] Review Request: ghc-crypto-cipher-types - Generic cryptography cipher types
https://bugzilla.redhat.com/show_bug.cgi?id=1065678 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- ghc-crypto-cipher-types-0.0.9-1.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062396] Review Request: rubygem-mizuho - Mizuho documentation formatting tool
https://bugzilla.redhat.com/show_bug.cgi?id=1062396 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- rubygem-mizuho-0.9.20-2.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022551] Review Request: bouncycastle-pkix - CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle
https://bugzilla.redhat.com/show_bug.cgi?id=1022551 --- Comment #13 from gil cattaneo --- (In reply to Ville Skyttä from comment #12) > "Obsoletes: bouncycastle < 1.50" (without corresponding provides) should > also be added so that this package gets pulled in on yum updates because > things in the org.bouncycastle.mozilla and org.bouncycastle.openssl packages > used to be in the main bouncycastle provider jar but are nowadays here. This seem for me unnecessary because in Fedora bouncycastle 1.50 already exist ... DEBUG util.py:281: --> bouncycastle-1.50-2.fc21.noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065685] Review Request: rubygem-unicorn - Rack HTTP server for fast clients and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1065685
--- Comment #3 from Achilleas Pipinellis ---
About my second query the answer is here [0]. So you must include the top level
directory which will include the entire tree below it. That addresses to
`%{gem_extdir_mri}/*`.
In my previous comment I missed that you don't include `%dir %{gem_instdir}`.
That would solve the `No known owner of /usr/share/gems/gems/unicorn-4.8.2/bin`
issue. Then i guess you could also omit the `%{gem_instdir}/bin/unicorn` and
`%{gem_instdir}/bin/unicorn_rails` macros.
Finally, you include Rakefile in -doc. I've seen that you usually remove it, so
I just point that in case you missed it.
[0]
https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1065685] Review Request: rubygem-unicorn - Rack HTTP server for fast clients and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1065685
--- Comment #2 from Achilleas Pipinellis ---
Ok, here are some comments.
- Use `cp -pa` to preserve timestamps, currently you do `cp -a`.
- rpmlint complains about: `No known owner of
/usr/share/gems/gems/unicorn-4.8.2/bin, /usr/lib64/gems/ruby/unicorn-4.8.2`.
Could it be that you should also include %{gem_instdir}/bin/ and
%{gem_extdir_mri}/lib under %files as well? Actually, I haven't really
understood how the dir ownership is defined. If I put a folder under %files it
includes all its subfolders as well, right?
- You don't exclude %{gem_cache}.
- rpmlint complains with `W: no-soname
/usr/lib64/gems/ruby/unicorn-4.8.2/lib/unicorn_http.so`. I have no idea what
this means and `rpmlint -I` doesn't give any info. Safe to ignore?
- Minor but fixable :) `W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab:
line 97)`
- E: specfile-error -e:1:in `': Use RbConfig instead of obsolete and
deprecated Config. Epel6 uses ruby1.8 which I assume uses Config so it's safe
to ignore?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1022551] Review Request: bouncycastle-pkix - CMS, PKCS, EAC, TSP, CMP, CRMF, OCSP for Bouncy Castle
https://bugzilla.redhat.com/show_bug.cgi?id=1022551
--- Comment #12 from Ville Skyttä ---
(In reply to gil cattaneo from comment #9)
> (In reply to Mattias Ellert from comment #8)
> Obsoletes: bouncycastle-tsp < 1.47
> Provides: bouncycastle-tsp = %{version}-%{release}
"Obsoletes: bouncycastle < 1.50" (without corresponding provides) should also
be added so that this package gets pulled in on yum updates because things in
the org.bouncycastle.mozilla and org.bouncycastle.openssl packages used to be
in the main bouncycastle provider jar but are nowadays here.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
