date:20140407

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #1 from Parag AN(पराग) panem...@gmail.com ---
Issues:

1) It's better to use subpackage name -common and not -license. See
http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts suggests
using -common for common files needed by all other packages.

2) Requires: fontpackages-filesystem is missing for -condensed-fonts
subpackage. 

The other simple way is to add it to -common and let -common be required by
google-roboto-fonts and google-roboto-condensed-fonts. This way -common will
provide LICENSE.txt file and you can also add RobotoSpecimenBook.pdf as a  %doc

If you add -common then let it alone Requires: fontpackages-filesystem

3) Group tag is no longer needed.

4) Summary can be Google Roboto fonts

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1070418] Review Request: python-mitmproxy - An interactive SSL-capable intercepting HTTP proxy

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1070418



--- Comment #7 from Fabian Affolter m...@fabian-affolter.ch ---
I'm unsure about the package name...from my point of view this is more a tool
written in python than a python lib and because of that mitmproxy seems more
suitable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083962] Review Request: maxscale - A database-centric proxy that works with MariaDB and MySQL

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1083962



--- Comment #9 from Oden Eriksson o...@nux.se ---
(In reply to Paulo Andrade from comment #8)
 On a quick look, I can say that I do not like when
 one does not run a proper make install in %install,
 this can easily break in subtle ways, if not in the
 first spec write, whenever the package is updated.
 I see the Makefile at least appears to respect
 $DESTDIR for the install target.

I know. The problem is that libtool for some reason swaps linking order when
relinking while doing make install. I'm not a autopoo or libtool guru enough to
fix that. Upstream knows that autopoo should be implemented and this might
happen in a future release.

 You should run make testall in %check and give
 good reasons if it does not work. This way both you
 and reviewer will at least have a good hint the
 package is functional if it pass %check.

Same here. Poor autopoo support.

 Please post a link to the failed arm build, to
 have an idea of why it fails.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6713406

 I suggest renaming the patches to maxscale-xyz.patch,
 and use PatchN: %{name}-xyz.patch, but this is a
 cosmetic change, just a common pattern in fedora
 packages.
 
 Instead of using CFLAGS=%{optflags} -fpie you
 should use https://fedoraproject.org/wiki/Packaging:Guidelines#PIE
 that automatically does it for you; could then just need
 to force CFLAGS=%{optflags} and LDFLAGS=%{__global_ldflags}
 But I am not sure if it is handled the same way for rhel.

No it doesn't. Sure, I could use conditionals here but...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007

David Tardon dtar...@redhat.com changed:

   What|Removed |Added

 CC||dtar...@redhat.com



--- Comment #2 from David Tardon dtar...@redhat.com ---
Spec URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts.spec
SRPM URL:
http://dtardon.fedorapeople.org/rpm/google-roboto-fonts-1.2-2.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079965] Review Request: python-dpath - python library for searching dictionaries using XPath-like expressions

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1079965

Stanislav Ochotnicky socho...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Stanislav Ochotnicky socho...@redhat.com ---
Thanks for the review

New Package SCM Request
===
Package Name: python-dpath
Short Description: A python library for accessing and searching dictionaries
via /slashed/paths ala xpath
Owners: sochotni
Branches: f20 el6
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1075822] Review Request: openstack-marconi - OpenStack Message Queuing Service

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1075822

Haïkel Guémar karlthe...@gmail.com changed:

   What|Removed |Added

  Flags|needinfo?(karlthered@gmail. |
   |com)|



--- Comment #12 from Haïkel Guémar karlthe...@gmail.com ---
FYI, we discussed with Jon on irc and by emails.
Basically, until we move forward with the sponsorship process, we can't finish
this review. He still need to come up with a good informal review so sponsors
may assess his knowledge about RPM packaging and Fedora guidelines.
As for the commitment part, I am affirmative that Jon will be committed to
maintain properly this package.

I'm pretty confident that the review will go well from my preliminary reviews.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007

Parag AN(पराग) panem...@gmail.com changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Parag AN(पराग) panem...@gmail.com ---
Review:

+ Package built fine in mock on rawhide

+ rpmlint on generated rpms gave
google-roboto-condensed-fonts.noarch: W: no-documentation
google-roboto-fonts.noarch: W: no-documentation
google-roboto-fonts.src: W: invalid-url Source0:
http://developer.android.com/downloads/design/roboto-1.2.zip HTTP Error 405:
Method Not Allowed
4 packages and 0 specfiles checked; 0 errors, 3 warnings.

+ Source verified with upstream as  (sha256sum)
source tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5
srpm tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5

+ fontconfig rules provided and follow fonts packaging guidelines.

APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 960056] Review Request: rubygem-debug_inspector - A Ruby wrapper for the MRI 2.0 debug_inspector API

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=960056



--- Comment #3 from Josef Stribny jstri...@redhat.com ---
I am sorry for such a delay.

* Both %description for the package and its sub-package should end with a dot
(.)
* %{gem_instdir}/README.md should be in the main package since it contains
license (ideally you should ask upstream to split the license to a separate
file)
* %{gem_instdir}/README.md should be marked as %doc
* Why do you state # TODO: move the extensions if you are moving it already?

Otherwise the package works as expected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083962] Review Request: maxscale - A database-centric proxy that works with MariaDB and MySQL

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1083962

Christopher Meng cicku...@gmail.com changed:

   What|Removed |Added

 CC||cicku...@gmail.com



--- Comment #10 from Christopher Meng cicku...@gmail.com ---
1. LDFLAGS? Try %{__global_ldflags} macro.

2. MaxScale is an open-source, database-centric proxy that works with MariaDB
and
MySQL

Dot should be at the end, right?

3. Do you manage your software with no configure system? I hope you can
persuade someone to do that(CMake or autocrap, up to you :)

ARM

Error output:

skygw_utils.cc: In function 'int atomic_add(int*, int)':
skygw_utils.cc:144:15: error: impossible constraint in 'asm'
   : memory );

Code block:

int atomic_add(
int *variable,
int value)
{
asm volatile(
lock; xaddl %%eax, %2;
:=a (value)
: a (value), m (*variable)
: memory );
return value;
}

Looks like it used some special hacks to suppress the compiler? I think that
volatile may bring some drastic effects to ARM platform.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007

David Tardon dtar...@redhat.com changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from David Tardon dtar...@redhat.com ---
New Package SCM Request
===
Package Name: google-roboto-fonts
Short Description: Google Roboto fonts
Owners: dtardon
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007



--- Comment #5 from Parag AN(पराग) panem...@gmail.com ---
I request please re-submit above request with addition as
IntialCC: fonts-sig i18n-team

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084007] Review Request: google-roboto-fonts - Google Roboto fonts

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084007



--- Comment #6 from David Tardon dtar...@redhat.com ---
New Package SCM Request
===
Package Name: google-roboto-fonts
Short Description: Google Roboto fonts
Owners: dtardon
Branches: f19 f20
InitialCC: fonts-sig i18n-team

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084942] New: Review Request: perl-Data-Tumbler - Dynamic generation of nested combinations

2014-04-07 Thread bugzilla

https://bugzilla.redhat.com/show_bug.cgi?id=1084942

Bug ID: 1084942
Summary: Review Request: perl-Data-Tumbler - Dynamic generation
of nested combinations
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: p...@city-fan.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org

Spec URL:
http://subversion.city-fan.org/repos/cfo-repo/perl-Data-Tumbler/branches/fedora/perl-Data-Tumbler.spec
SRPM URL:
http://www.city-fan.org/~paul/extras/perl-Data-Tumbler/perl-Data-Tumbler-0.005-2.fc21.src.rpm

Description:

The tumble() method calls a sequence of 'provider' code references, each of
which returns a hash. The first provider is called and then, for each hash item
it returns, the tumble() method recurses to call the next provider. The
recursion continues until there are no more providers to call, at which point
the consumer code reference is called. Effectively the providers create a tree
of combinations and the consumer is called at the leaves of the tree. If a
provider returns no items then that part of the tree is pruned. Further
providers, if any, are not called and the consumer is not called.

During a call to tumble() three values are passed down through the tree and
into the consumer: path, context, and payload. The path and context are derived
from the names and values of the hashes returned by the providers. Typically
the path defines the current path through the tree of combinations. The
providers are passed the current path, context, and payload. The payload is
cloned at each level of recursion so that any changes made to it by providers
are only visible within the scope of the generated sub-tree.

Fedora Account System Username: pghmcfc

--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

92 matches

Mail list logo