[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 David Dick changed: What|Removed |Added Status|NEW |ASSIGNED CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #1 from David Dick --- FIX: BR perl(Carp) # line 134 of XS.pm BR perl(Hash::Util) # line 13 of t/12_blessed.t Req perl(Carp) # line 134 of XS.pm Req perl(Data::Dump) # line 212 of bin/cpanel_json_xs Req perl(YAML) # line 180 of bin/cpanel_json_xs Req perl(Compress::LZF) # line 179 of bin/cpanel_json_xs Req perl(Convert::Bencode) # line 178 of bin/cpanel_json_xs Given that 1) i'm trying to package Compress::LZF at https://bugzilla.redhat.com/show_bug.cgi?id=1074129 2) i'm stalled b/c of missing files in liblzf at https://bugzilla.redhat.com/show_bug.cgi?id=1075911 3) Compress::LZF is an optional argument in a "test" command line client that will handle itself correctly if the "lzf" option is removed i don't mind if you resubmit with a patch to just remove the lzf option. Example patch attached. Or block on #1074129 and wait with me :) TODO: Maybe remove ", also for 5.6.2" from the summary? perl 5.6.2 was a while ago. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #2 from David Dick --- Created attachment 884806 --> https://bugzilla.redhat.com/attachment.cgi?id=884806&action=edit Proposed removal of lzf compression option from command line -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226324] Merge Review: psutils
https://bugzilla.redhat.com/show_bug.cgi?id=226324 --- Comment #20 from Ralf Corsepius --- (In reply to Ralf Corsepius from comment #19) > OK to apply this patch? I intend to apply it unless the nominal maintainer > objects within the next 24 hours. No response, patch applied to rawhide, now: http://koji.fedoraproject.org/koji/taskinfo?taskID=6723014 Still an open issue: The dysfunctional *-perl split. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086165] New: Review Request: nodejs-shelljs -Portable Unix shell commands for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1086165 Bug ID: 1086165 Summary: Review Request: nodejs-shelljs -Portable Unix shell commands for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://anishpatil.fedorapeople.org/nodejs-shelljs.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-shelljs-0.2.6-1.fc20.src.rpm Description: ShellJS is a portable implementation of Unix shell commands on top of the Node.js API. Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #34 from Pavel Alexeev (aka Pahan-Hubbitus) --- We with Rex mention early what if you provide in your package qjdns and qjdns-devel vith versions which are greater than current from iris all update should be smooth and no other manipulation will be needed (like Obsoletes/Provides). Then it may be just dropped in iris. Please try do it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086174] New: Review Request: nodejs-exit - A replacement for process.exit
https://bugzilla.redhat.com/show_bug.cgi?id=1086174 Bug ID: 1086174 Summary: Review Request: nodejs-exit - A replacement for process.exit Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://anishpatil.fedorapeople.org/nodejs-exit.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-exit-0.1.2-1.fc20.src.rpm Description: A replacement for process.exit that ensures stdio are fully drained before exiting. Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776 Mohamed El Morabity changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com --- Comment #1 from Mohamed El Morabity --- I will review your package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=669869 Paul Howarth changed: What|Removed |Added CC||p...@city-fan.org Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Paul Howarth --- Package Change Request == Package Name: perl-Convert-Bencode New Branches: el6 epel7 Owners: pghmcfc InitialCC: perl-sig This is needed for perl-Cpanel-JSON-XS (Bug #1085975). Iain is very busy and is happy for other people to look after his EPEL packages (https://lists.fedoraproject.org/pipermail/perl-devel/2014-January/082331.html). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #3 from Paul Howarth --- All issues addressed in -2: Spec URL: http://subversion.city-fan.org/repos/cfo-repo/perl-Cpanel-JSON-XS/branches/fedora/perl-Cpanel-JSON-XS.spec SRPM URL: http://www.city-fan.org/~paul/extras/perl-Cpanel-JSON-XS/perl-Cpanel-JSON-XS-2.3404-2.fc21.src.rpm When you eventually get Compress::LZF approved, do you plan to do EL-6/7 branches? If not, I would like to take them. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084021] Review Request: openjpeg2 - C-Library for JPEG 2000
https://bugzilla.redhat.com/show_bug.cgi?id=1084021 --- Comment #15 from Jaromír Cápík --- Maybe one of the last notes: https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define Even when the defines are commented out, it would be probably better to replace them with globals as stated in the guidelines ... but it's up to you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #12 from Dave Airlie --- New Package SCM Request === Package Name: libepoxy Short Description: OpenGL pointer management library Owners: airlied Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #4 from David Dick --- My plan is to do EL6 and EL7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Dave Airlie changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #5 from David Dick --- I've checked the git logs for liblzf and Steve Traylen (owner of liblzf) has only added lzfP.h to the package. Therefore, i have to strip out all the _best functionality of Compress::LZF as noted in that bug. I'm doing that at the moment and hope to have the Compress::LZF ready for re-submission soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084021] Review Request: openjpeg2 - C-Library for JPEG 2000
https://bugzilla.redhat.com/show_bug.cgi?id=1084021 --- Comment #16 from Jaromír Cápík --- The testsuite doesn't work correctly with the data cloned using the command in the comment. Only 11% of tests pass regardless of the data presence. But I suggest to fix that after the initial import so that we don't block the upgrades. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074129] Review Request: perl-Compress-LZF - Extremely light-weight Lempel-Ziv-Free compression
https://bugzilla.redhat.com/show_bug.cgi?id=1074129 --- Comment #6 from David Dick --- Steve Traylon has only added the lzfP.h header file. Therefore, as discussed, i've stripped out the _best files. Could you please review this again? koji builds follow; rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=6723429 el6 at http://koji.fedoraproject.org/koji/taskinfo?taskID=6723428 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084021] Review Request: openjpeg2 - C-Library for JPEG 2000
https://bugzilla.redhat.com/show_bug.cgi?id=1084021 --- Comment #17 from Jakub Čajka --- #define optional_components 1S When i uncomment this the S on end breaks optional components build And one file from optional components is not packaged RPM build errors: Installed (but unpackaged) file(s) found: /usr/share/opj_jpip_viewer.jar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086217] New: Review Request: nodejs-strip-json-comments - Strip comments from JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1086217 Bug ID: 1086217 Summary: Review Request: nodejs-strip-json-comments - Strip comments from JSON Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.1-1.fc20.src.rpm Description: Strip comments from JSON. Lets you use comments in your JSON files! Fedora Account System Username: anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 David Dick changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from David Dick --- At any rate, package APPROVED. I'll let you know when Compress::LZF is ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Antonio Trande --- (In reply to Miroslav Suchý from comment #5) > Updated: > Spec URL: http://miroslav.suchy.cz/copr/copr-backend.spec > SRPM URL: http://miroslav.suchy.cz/copr/copr-backend-1.31-1.fc20.src.rpm > > > I also fixed permission of cron.daily file as there was nothing secret. > > > > - /usr/share/doc/copr-backend is properly owned. > > - Package building provides file permission settings for non-standard > > group/user. > I am not sure I follow? These are issues? > No, since 'copr' is a non-standard group. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086231] New: Review Request: nodejs-jsonparse - Pure-js JSON streaming parser for node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1086231 Bug ID: 1086231 Summary: Review Request: nodejs-jsonparse - Pure-js JSON streaming parser for node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://anishpatil.fedorapeople.org/nodejs-jsonparse.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-jsonparse-0.0.6-1.fc20.src.rpm Description: This is a streaming JSON parser for Node.js Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 Paul Howarth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Paul Howarth --- New Package SCM Request === Package Name: perl-Cpanel-JSON-XS Short Description: JSON::XS for Cpanel, fast and correct serializing Owners: pghmcfc Branches: f19 f20 el6 epel7 InitialCC: perl-sig Thanks for the review David, -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397
--- Comment #35 from Ivan Romanov ---
Anyway will be need to manipalation with jdns package. I think it's not correct
to have in system jdns-2.0.0 and qjdns-1.0.0.
Now my jdns-devel subpackage uses
Provides: qjdns-devel = %{version}-%{release}
Obsoletes: qjdns-devel < 2.0.0
It's a standart way to rename package
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Renaming.2FReplacing_Existing_Packages
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776
--- Comment #2 from Mohamed El Morabity ---
The package looks quite good at first sight. Just one note about the release
tag: according to the guidelines, it should be: 0.7.git%{shortcommit}%{?dist}
(see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages).
These same guidelines recommend adding the commit date to the prerelease tag
too: 0.7.2014git%{shortcommit}(see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Non-Numeric_Version_in_Release).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 --- Comment #7 from Miroslav Suchý --- Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 Miroslav Suchý changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Miroslav Suchý --- New Package SCM Request === Package Name: copr-backend Short Description: Backend for Copr Owners: msuchy Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086245] New: Review Request: nodejs-jsonstream -streaming JSON.parse and stringify for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1086245 Bug ID: 1086245 Summary: Review Request: nodejs-jsonstream -streaming JSON.parse and stringify for Node.js Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: apa...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org This package requires jsonparse, which is in review https://bugzilla.redhat.com/show_bug.cgi?id=1086231 Spec URL: http://anishpatil.fedorapeople.org/nodejs-jsonstream.spec SRPM URL: http://anishpatil.fedorapeople.org/nodejs-jsonstream-0.8.0-1.fc20.src.rpm Description: http://anishpatil.fedorapeople.org/nodejs-jsonstream.spec Fedora Account System Username:anishpatil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1071456] Review Request: oozie - A work-flow scheduling system for Apache Hadoop
https://bugzilla.redhat.com/show_bug.cgi?id=1071456 --- Comment #1 from Robert Rati --- Updated to upstream version 4.0.1 Spec URL: http://rrati.fedorapeople.org/oozie.spec SRPM URL: http://rrati.fedorapeople.org/oozie-4.0.1-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=669869 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=669869 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1069335] Review Request: openstack-ironic - Management and provisioning of physical machines for Openstack
https://bugzilla.redhat.com/show_bug.cgi?id=1069335 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1069335] Review Request: openstack-ironic - Management and provisioning of physical machines for Openstack
https://bugzilla.redhat.com/show_bug.cgi?id=1069335 --- Comment #29 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047013] Review Request: eom - Eye of MATE image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1047013 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1074149] Review Request: libepoxy - OpenGL pointer management library
https://bugzilla.redhat.com/show_bug.cgi?id=1074149 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043290] Review Request: engrampa - MATE Desktop file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1043290 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046726] Rename Request: pluma - Text editor for the MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1046726 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1064486] Review Request: mozo - MATE Desktop menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1064486 Wolfgang Ulbrich changed: What|Removed |Added Blocks||1086149 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086149 [Bug 1086149] MATE Desktop 1.8 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084246] Review Request: python-saharaclient - client library for OpenStack Sahara API
https://bugzilla.redhat.com/show_bug.cgi?id=1084246 mimcc...@redhat.com changed: What|Removed |Added Attachment #883774|0 |1 is obsolete|| --- Comment #11 from mimcc...@redhat.com --- Created attachment 884955 --> https://bugzilla.redhat.com/attachment.cgi?id=884955&action=edit updated spec file changing __python to __python2 enabling some tests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084246] Review Request: python-saharaclient - client library for OpenStack Sahara API
https://bugzilla.redhat.com/show_bug.cgi?id=1084246 mimcc...@redhat.com changed: What|Removed |Added Attachment #883775|0 |1 is obsolete|| --- Comment #12 from mimcc...@redhat.com --- Created attachment 884956 --> https://bugzilla.redhat.com/attachment.cgi?id=884956&action=edit update source rpm rebuild after modifying spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 669869] Review Request: perl-Convert-Bencode - Functions for converting to/from bencoded strings
https://bugzilla.redhat.com/show_bug.cgi?id=669869 --- Comment #11 from Fedora Update System --- perl-Convert-Bencode-1.03-9.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Convert-Bencode-1.03-9.el6 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085752] Review Request: check-create-certificate - A script that checks for the existance of an SSL certificate
https://bugzilla.redhat.com/show_bug.cgi?id=1085752 Mohamed El Morabity changed: What|Removed |Added Status|NEW |ASSIGNED CC||pikachu.2...@gmail.com Assignee|nob...@fedoraproject.org|pikachu.2...@gmail.com --- Comment #4 from Mohamed El Morabity --- I will review your package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085132] Review Request: python-django-sahara - Sahara plugin for OpenStack dashboard
https://bugzilla.redhat.com/show_bug.cgi?id=1085132 --- Comment #3 from mimcc...@redhat.com --- Created attachment 884968 --> https://bugzilla.redhat.com/attachment.cgi?id=884968&action=edit spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085132] Review Request: python-django-sahara - Sahara plugin for OpenStack dashboard
https://bugzilla.redhat.com/show_bug.cgi?id=1085132 mimcc...@redhat.com changed: What|Removed |Added Attachment #884968|0 |1 is obsolete|| --- Comment #4 from mimcc...@redhat.com --- Created attachment 884969 --> https://bugzilla.redhat.com/attachment.cgi?id=884969&action=edit updated spec file changing __python to __python2 adding a note about testing -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085132] Review Request: python-django-sahara - Sahara plugin for OpenStack dashboard
https://bugzilla.redhat.com/show_bug.cgi?id=1085132 --- Comment #5 from mimcc...@redhat.com --- Created attachment 884970 --> https://bugzilla.redhat.com/attachment.cgi?id=884970&action=edit updated source rpm rebuilding after spec update -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776 --- Comment #3 from Craig Barnes --- Thanks for the review. I've just amended the spec file to address the 2 issues you mention and also to address the recently changed guidelines for GitHub sources. I've also truncated the old changelog to avoid any confusion between the 2 versioning schemes. The new spec and SRPM can be found at: http://cbb.fedorapeople.org/packages/dex.spec http://cbb.fedorapeople.org/packages/dex-0-0.1.20140410gitad89dc2.fc20.src.rpm There's also a diff of the changes to the spec file, in case it's useful: http://cbb.fedorapeople.org/packages/dex-spec-first-second.diff I have noticed the "incorrect-fsf-address" error given by rpmlint for /usr/share/doc/dex/COPYING, which I will report to upstream soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 522169] Review Request: netplug - Daemon that responds to network cables being plugged in and out
https://bugzilla.redhat.com/show_bug.cgi?id=522169 Jiri Popelka changed: What|Removed |Added CC|nott...@redhat.com | Flags|fedora-cvs+ |fedora-cvs? --- Comment #4 from Jiri Popelka --- Package Change Request == Package Name: netplug New Branches: el6 Owners: jpopelka I've been kindly asked to include netplug in EPEL-6. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084246] Review Request: python-saharaclient - client library for OpenStack Sahara API
https://bugzilla.redhat.com/show_bug.cgi?id=1084246 mimcc...@redhat.com changed: What|Removed |Added Attachment #884955|0 |1 is obsolete|| --- Comment #13 from mimcc...@redhat.com --- Created attachment 884974 --> https://bugzilla.redhat.com/attachment.cgi?id=884974&action=edit updated spec file removing unneeded python-virtualenv from BuildRequires -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084246] Review Request: python-saharaclient - client library for OpenStack Sahara API
https://bugzilla.redhat.com/show_bug.cgi?id=1084246 mimcc...@redhat.com changed: What|Removed |Added Attachment #884956|0 |1 is obsolete|| --- Comment #14 from mimcc...@redhat.com --- Created attachment 884975 --> https://bugzilla.redhat.com/attachment.cgi?id=884975&action=edit updated source rpm rebuilding after spec change -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085441] Review Request: openstack-sahara - Apache Hadoop cluster management on OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1085441 --- Comment #1 from mimcc...@redhat.com --- Created attachment 884976 --> https://bugzilla.redhat.com/attachment.cgi?id=884976&action=edit updated spec file changing __python to __python2 enabling some unittests -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085441] Review Request: openstack-sahara - Apache Hadoop cluster management on OpenStack
https://bugzilla.redhat.com/show_bug.cgi?id=1085441 --- Comment #2 from mimcc...@redhat.com --- Created attachment 884977 --> https://bugzilla.redhat.com/attachment.cgi?id=884977&action=edit updated source rpm rebuilding after spec change -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #36 from Pavel Alexeev (aka Pahan-Hubbitus) --- (In reply to Ivan Romanov from comment #35) > Anyway will be need to manipalation with jdns package. I think it's not > correct to have in system jdns-2.0.0 and qjdns-1.0.0. Why? If user want new jdns package - they just install it. If they want update qjdns newer version - update it (or whole system). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085752] Review Request: check-create-certificate - A script that checks for the existance of an SSL certificate
https://bugzilla.redhat.com/show_bug.cgi?id=1085752
--- Comment #5 from Mohamed El Morabity ---
Here are some comments.
The %defattr macro is obsolete for a long time (see
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions). You can
drop it in %files. You can also drop the %attr(...) macro on
%{_sbindir}/%{name}, the right permissions on this files are already defined at
package build automatically here.
You don't need to add coreutils to the BuildRequires: this package is already
part of the minimal build environment (see
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2).
You can also drop perl as Requires: The auto Provides system will detected Perl
requirements at build time. You can see it in the build logs:
[...]
Processing files: check-create-certificate-0.5-4.fc20.noarch
[...]
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /usr/bin/perl perl(File::Basename) perl(Getopt::Long) perl(strict)
[...]
As you can see, /usr/bin/perl, as well as the
File::Basename/Getopt::Long/strict Perl libraries, are detected and added as
automatic Provides to your package.
The check-create-certificate script calls the c_rehash command, which is
provided by the openssl-perl package. As a result, you can replace openssl by
openssl-perl in Requires (openssl-perl already requires openssl).
The install command can create on the fly the destination folder if it doesn't
exist (see -D option). You can replace these lines:
mkdir -p %{buildroot}%{_prefix}/sbin
install -m 755 script/%{name} %{buildroot}%{_sbindir}/
by this simpler one:
install -Dpm 755 script/%{name} %{buildroot}%{_sbindir}/%{name}
(notice the -p option to preserver the timestamp).
You don't need to manually deploy in %install the COPYING file (or any other
documentation file not installed by default). Just use the %doc macro in
%files: it will automatically deploy all its arguments to %{_docdir}/%{name}
(or %{_docdir}/%{name}-%{version} in Fedora < 20):
%files
%doc COPYING
%{_sbindir}/%{name}
The upstream versionning is quite weird. The upstream source packaging relies
on a .spec file which contains the current version for the project (0.5 now).
The project history shows instead that the version 0.5 was released 4 years ago
(see
https://github.com/jdsn/check-create-certificate/commit/160fc42e77d44ef39ba84dd6226f61184332a255).
Moreover, the way to retrieve the sources you gave in comments will always
bring you the latest snapshot available, it doesn't correspond to a defined
snapshot.
I suggest you:
- to rely instead on a Git commit to version your package; you can consider
here the latest snapshot available today
([d0971baf5d13e06aaa600581efe3adba6631e06a]) which brings some good
improvements
- as a result, to use a postrelease numbering schema for the release tag (see
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-Release_packages).
You can have a look at this .spec file to inspire you:
http://cbb.fedorapeople.org/packages/dex.spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #37 from Pavel Alexeev (aka Pahan-Hubbitus) --- On my mind it is incorrect obsoletes some functionality by other package which is not provided by him (and have just fake). What happened with software which use library from qjdns-1.0.0? In case user install just jdns-2.0.0 (without qjdns-2.0.0) it became broken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776
--- Comment #4 from Mohamed El Morabity ---
You can replace in %files these two lines:
%dir %{_datadir}/%{name}/
%{_datadir}/%{name}/*
simply by
%{_datadir}/%{name}/
The %{_datadir}/%{name} directory *and* all its contents will be owned by the
package, in the same way than with your two lines ;).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776
--- Comment #5 from Mohamed El Morabity ---
(In reply to Mohamed El Morabity from comment #4)
By the way, the build isn't verbous enough to check the compilation flags. You
can add "V=1" to the make command to fix it:
make %{?_smp_mflags} V=1
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 522169] Review Request: netplug - Daemon that responds to network cables being plugged in and out
https://bugzilla.redhat.com/show_bug.cgi?id=522169 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 522169] Review Request: netplug - Daemon that responds to network cables being plugged in and out
https://bugzilla.redhat.com/show_bug.cgi?id=522169 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #38 from Ivan Romanov --- Always when I am updating one package will be updated all others. For example if I want to update only qt package will be updated qt-devel also. No other options. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #11 from Fedora Update System --- perl-Cpanel-JSON-XS-2.3404-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #10 from Fedora Update System --- perl-Cpanel-JSON-XS-2.3404-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085975] Review Request: perl-Cpanel-JSON-XS - JSON::XS for Cpanel, fast and correct serializing, also for 5.6.2
https://bugzilla.redhat.com/show_bug.cgi?id=1085975 --- Comment #9 from Fedora Update System --- perl-Cpanel-JSON-XS-2.3404-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/perl-Cpanel-JSON-XS-2.3404-2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776 --- Comment #6 from Craig Barnes --- Fixed both of those issues. Thanks for pointing them out :) New files: http://cbb.fedorapeople.org/packages/dex.spec http://cbb.fedorapeople.org/packages/dex-0-0.2.20140410gitad89dc2.fc20.src.rpm http://cbb.fedorapeople.org/packages/dex-spec-second-third.diff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084397] Review Request: jdns - A simple DNS queries library
https://bugzilla.redhat.com/show_bug.cgi?id=1084397 --- Comment #39 from Pavel Alexeev (aka Pahan-Hubbitus) --- Right, because qt-devel have versioned dependency to qt. It is not your case, so jdns is not dependent from qjdns, so in install second will not be pulled. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084021] Review Request: openjpeg2 - C-Library for JPEG 2000
https://bugzilla.redhat.com/show_bug.cgi?id=1084021 --- Comment #18 from Sandro Mani --- Spec URL: http://smani.fedorapeople.org/review/openjpeg2.spec SRPM URL: http://smani.fedorapeople.org/review/openjpeg2-2.0.0-4.svn20140403.fc21.src.rpm * Thu Apr 10 2014 Sandro Mani - 2.0.0-4.svn20140403 - Replace define with global - Fix #define optional_components 1S typo - Fix %%(pwd) -> $PWD for test data - Added some BR for optional components - Include opj2_jpip_viewer.jar in %%files Regarding /usr/share/opj_jpip_viewer.jar: This only gets built if a JDK is detected. I've now added the java-devel BR, though for completeness I should also look at packaging the jpip server and provide an appropriate systemd service file. But I'd say lets leave that for when a use case comes up. Regarding the tests: there are still failing tests, which is not because of the data which cannot be found this time though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776
Mohamed El Morabity changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #7 from Mohamed El Morabity ---
here is at last the review:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[-]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
-> No license comment found in source code, relying on COPYING file
instead
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
->See http://koji.fedoraproject.org/koji/taskinfo?taskID=6724327
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[-]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
->See http://koji.fedoraproject.org/koji/taskinfo?taskID=6724327
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
->Tested in koji:
http:
[Bug 1085752] Review Request: check-create-certificate - A script that checks for the existance of an SSL certificate
https://bugzilla.redhat.com/show_bug.cgi?id=1085752
--- Comment #6 from MartinKG ---
(In reply to Mohamed El Morabity from comment #5)
> Here are some comments.
Thanks for your time and for the review
>
> The %defattr macro is obsolete for a long time (see
> https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions). You
> can drop it in %files. You can also drop the %attr(...) macro on
> %{_sbindir}/%{name}, the right permissions on this files are already defined
> at package build automatically here.
>
already done in package 0.5-4
> You don't need to add coreutils to the BuildRequires: this package is
> already part of the minimal build environment (see
> https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2).
>
done
> You can also drop perl as Requires: The auto Provides system will detected
> Perl requirements at build time. You can see it in the build logs:
> [...]
> Processing files: check-create-certificate-0.5-4.fc20.noarch
> [...]
> Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests)
> <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
> Requires: /usr/bin/perl perl(File::Basename) perl(Getopt::Long) perl(strict)
> [...]
> As you can see, /usr/bin/perl, as well as the
> File::Basename/Getopt::Long/strict Perl libraries, are detected and added as
> automatic Provides to your package.
>
done
>
> The check-create-certificate script calls the c_rehash command, which is
> provided by the openssl-perl package. As a result, you can replace openssl
> by openssl-perl in Requires (openssl-perl already requires openssl).
>
done
>
> The install command can create on the fly the destination folder if it
> doesn't exist (see -D option). You can replace these lines:
>mkdir -p %{buildroot}%{_prefix}/sbin
>install -m 755 script/%{name} %{buildroot}%{_sbindir}/
> by this simpler one:
>install -Dpm 755 script/%{name} %{buildroot}%{_sbindir}/%{name}
> (notice the -p option to preserver the timestamp).
>
done
>
> You don't need to manually deploy in %install the COPYING file (or any other
> documentation file not installed by default). Just use the %doc macro in
> %files: it will automatically deploy all its arguments to %{_docdir}/%{name}
> (or %{_docdir}/%{name}-%{version} in Fedora < 20):
> %files
> %doc COPYING
> %{_sbindir}/%{name}
>
done
>
> The upstream versionning is quite weird. The upstream source packaging
> relies on a .spec file which contains the current version for the project
> (0.5 now). The project history shows instead that the version 0.5 was
> released 4 years ago (see
> https://github.com/jdsn/check-create-certificate/commit/
> 160fc42e77d44ef39ba84dd6226f61184332a255).
> Moreover, the way to retrieve the sources you gave in comments will always
> bring you the latest snapshot available, it doesn't correspond to a defined
> snapshot.
> I suggest you:
> - to rely instead on a Git commit to version your package; you can consider
> here the latest snapshot available today
> ([d0971baf5d13e06aaa600581efe3adba6631e06a]) which brings some good
> improvements
> - as a result, to use a postrelease numbering schema for the release tag
> (see
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Post-
> Release_packages).
> You can have a look at this .spec file to inspire you:
>http://cbb.fedorapeople.org/packages/dex.spec
hope i translate it correct ?
New files:
Spec URL:
http://martinkg.fedorapeople.org/Review/SPECS/check-create-certificate.spec
SRPM URL:
http://martinkg.fedorapeople.org/Review/SRPMS/check-create-certificate-0.5-5.20140410gitd0971ba.fc20.src.rpm
%changelog
* Thu Apr 10 2014 Martin Gansser -
0.5-5.20140410gitd0971ba
- droped coreutils, perl BuildRequires
- replaced openssl by openssl-perl BuildRequires
- added -p option to preserver the timestamp in install section
- changed doc macro in files section
- used git commit for package version
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077795] Review Request: copr-selinux - SELinux module for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077795 Antonio Trande changed: What|Removed |Added CC||anto.tra...@gmail.com --- Comment #1 from Antonio Trande --- Have you followed specific packaging guidelines for this module? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958059] Review Request: yum-axelget - A plugin for Yum based on Axel that accelerates your download's rate
https://bugzilla.redhat.com/show_bug.cgi?id=958059 --- Comment #27 from Fedora Update System --- yum-axelget-0.2-5.20140407svn14.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/yum-axelget-0.2-5.20140407svn14.fc20 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958059] Review Request: yum-axelget - A plugin for Yum based on Axel that accelerates your download's rate
https://bugzilla.redhat.com/show_bug.cgi?id=958059 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079436] Review Request: openstack-tuskar-ui - The UI component for Tuskar
https://bugzilla.redhat.com/show_bug.cgi?id=1079436 --- Comment #10 from Jordan OMara --- Had an issue with upstream source challenges, corrected below + rebuild for rawhide srpm: http://fedorapeople.org/~jomara/openstack-tuskar-ui-0.1.0-8.fc21.src.rpm spec: http://fedorapeople.org/~jomara/openstack-tuskar-ui.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077795] Review Request: copr-selinux - SELinux module for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077795 --- Comment #2 from Miroslav Suchý --- No. Just common sense. Fedora does not have guidelines for selinux packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048493] Review Request: icecat - GNU version of Firefox browser
https://bugzilla.redhat.com/show_bug.cgi?id=1048493 --- Comment #26 from Antonio Trande --- Spec URL: http://sagitter.fedorapeople.org/Icecat/icecat.spec SRPM URL: http://sagitter.fedorapeople.org/Icecat/icecat-24.0-9.fc20.src.rpm Unless new Icecat 27 will disclosed in the meantime, this release should be ready for review. Although there are new specific criteria (https://fedoraproject.org/wiki/User:Toshio/Bundling_relaxation) for allowing bundling of code in Icecat (and Firefox), they need to be integrated and made official; for this reason, the FPC ticket (#391) is *not* positively closed yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1048493] Review Request: icecat - GNU version of Firefox browser
https://bugzilla.redhat.com/show_bug.cgi?id=1048493 Antonio Trande changed: What|Removed |Added External Bug ID||Mozilla Foundation 517422 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077795] Review Request: copr-selinux - SELinux module for COPR
https://bugzilla.redhat.com/show_bug.cgi?id=1077795 --- Comment #3 from Antonio Trande --- This wiki page is just a draft but has been recently updated: http://fedoraproject.org/wiki/SELinux_Policy_Modules_Packaging_Draft -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086378] New: Review Request: geard - Tool for installing Docker images as containers
https://bugzilla.redhat.com/show_bug.cgi?id=1086378 Bug ID: 1086378 Summary: Review Request: geard - Tool for installing Docker images as containers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: l...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://lsm5.fedorapeople.org/geard/geard.spec SRPM URL: http://lsm5.fedorapeople.org/geard/SRPMS/geard-0-0.1.fc21.src.rpm Description: geard is an opinionated tool for installing Docker images as containers onto a systemd-enabled Linux operating system (systemd 207 or newer). Fedora Account System Username: lsm5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 --- Comment #10 from Fedora Update System --- copr-backend-1.32-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/copr-backend-1.32-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1077791] Review Request: copr-backend - Backend for Copr
https://bugzilla.redhat.com/show_bug.cgi?id=1077791 --- Comment #10 from Fedora Update System --- copr-backend-1.32-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/copr-backend-1.32-1.fc20 --- Comment #11 from Fedora Update System --- copr-backend-1.32-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/copr-backend-1.32-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085881] Review Request: golang-github-spf13-cobra - A Commander for modern go CLI interactions
https://bugzilla.redhat.com/show_bug.cgi?id=1085881 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085019] Review Request: golang-github-kraman-libcontainer - Reference implementation for containers
https://bugzilla.redhat.com/show_bug.cgi?id=1085019 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085840] Review Request: golang-github-fsouza-go-dockerclient - Client for the Docker remote API
https://bugzilla.redhat.com/show_bug.cgi?id=1085840 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node
https://bugzilla.redhat.com/show_bug.cgi?id=1023769 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085890] Review Request: golang-github-spf13-pflag - Replacement for Go's flag package
https://bugzilla.redhat.com/show_bug.cgi?id=1085890 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085030] Review Request: golang-github-openshift-go-json-rest - A quick and easy way to setup a RESTful JSON API
https://bugzilla.redhat.com/show_bug.cgi?id=1085030 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085873] Review Request: golang-github-openshift-go-systemd - Go bindings to systemd D-BUS APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1085873 Lokesh Mandvekar changed: What|Removed |Added Blocks||1086378 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1086378 [Bug 1086378] Review Request: geard - Tool for installing Docker images as containers -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086378] Review Request: geard - Tool for installing Docker images as containers
https://bugzilla.redhat.com/show_bug.cgi?id=1086378 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||walt...@redhat.com Depends On||1085019, 1085030, 1085840, ||1085873, 1085881, 1085890, ||1023769 Assignee|nob...@fedoraproject.org|vba...@redhat.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1023769 [Bug 1023769] Review Request: golang-github-goerlang-dist - An implementation of Erlang node https://bugzilla.redhat.com/show_bug.cgi?id=1085019 [Bug 1085019] Review Request: golang-github-kraman-libcontainer - Reference implementation for containers https://bugzilla.redhat.com/show_bug.cgi?id=1085030 [Bug 1085030] Review Request: golang-github-openshift-go-json-rest - A quick and easy way to setup a RESTful JSON API https://bugzilla.redhat.com/show_bug.cgi?id=1085840 [Bug 1085840] Review Request: golang-github-fsouza-go-dockerclient - Client for the Docker remote API https://bugzilla.redhat.com/show_bug.cgi?id=1085873 [Bug 1085873] Review Request: golang-github-openshift-go-systemd - Go bindings to systemd D-BUS APIs https://bugzilla.redhat.com/show_bug.cgi?id=1085881 [Bug 1085881] Review Request: golang-github-spf13-cobra - A Commander for modern go CLI interactions https://bugzilla.redhat.com/show_bug.cgi?id=1085890 [Bug 1085890] Review Request: golang-github-spf13-pflag - Replacement for Go's flag package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079436] Review Request: openstack-tuskar-ui - The UI component for Tuskar
https://bugzilla.redhat.com/show_bug.cgi?id=1079436
--- Comment #11 from John Eckersberg ---
Previous issues:
- The upstream source tarball does not match the source tarball in the srpm
Looks good
- Extra unneeded Requires?
You reviewed and said it's ok, so fine by me
- No provided egg info
This was originally correct, I messed up.
- Use of deprecated %{__python} macro
Fixed, looks good.
- No %check section for tests
%check added, tests pass
- Use of 'mv' does not preserve timestamps
There's still one use of 'mv' in the spec file, but it's just to use the
.example file into place as config. For this purpose the original timestamp of
the example file doesn't really matter, so I'm fine with it staying like this.
- Group should be "Applications/System", not "Application/System" (note extra
's')
This is still incorrect
I think the Group is the only remaining packaging nit. I still need to
actually test the thing out and make sure it at least functionally works for
me.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776 --- Comment #9 from Craig Barnes --- Many thanks for the quick and pleasant review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1084776] Review Request: dex - Dextrous text editor
https://bugzilla.redhat.com/show_bug.cgi?id=1084776 Craig Barnes changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Craig Barnes --- New Package SCM Request === Package Name: dex Short Description: Dextrous text editor Owners: cbb Branches: f19 f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079436] Review Request: openstack-tuskar-ui - The UI component for Tuskar
https://bugzilla.redhat.com/show_bug.cgi?id=1079436 --- Comment #12 from Jordan OMara --- Applications corrected! srpm: http://fedorapeople.org/~jomara/openstack-tuskar-ui-0.1.0-9.fc21.src.rpm spec: http://fedorapeople.org/~jomara/openstack-tuskar-ui.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
