[Bug 920039] Review Request: atmosphere - Realtime Client Server Framework for the JVM, supporting WebSockets and Cross-Browser Fallbacks Support

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920039
Bug 920039 depends on bug 920038, which changed state.

Bug 920038 Summary: Review Request: infomas-asl - Java annotation scanner
https://bugzilla.redhat.com/show_bug.cgi?id=920038

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920038] Review Request: infomas-asl - Java annotation scanner

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920038

Michal Srb  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-05-07 02:31:55



--- Comment #8 from Michal Srb  ---
This should have been closed long time ago. Closing now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920129] Review Request: primefaces - Ultimate JSF Component Suite

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920129

Michal Srb  changed:

   What|Removed |Added

 Depends On|920039  |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=920039
[Bug 920039] Review Request: atmosphere - Realtime Client Server Framework
for the JVM, supporting WebSockets and Cross-Browser Fallbacks Support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920039] Review Request: atmosphere - Realtime Client Server Framework for the JVM, supporting WebSockets and Cross-Browser Fallbacks Support

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920039

Michal Srb  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks|652183 (FE-JAVASIG), 920129 |
 Resolution|--- |NOTABUG
Last Closed||2014-05-07 02:23:42



--- Comment #4 from Michal Srb  ---
Related to primefaces (#920129), closing as NOTABUG.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=920129
[Bug 920129] Review Request: primefaces - Ultimate JSF Component Suite
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920129] Review Request: primefaces - Ultimate JSF Component Suite

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920129

Michal Srb  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 920129] Review Request: primefaces - Ultimate JSF Component Suite

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=920129

Michal Srb  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2014-05-07 02:20:31



--- Comment #1 from Michal Srb  ---
Hmm, this should have been closed already. I have lost my interest in
(packaging) primefaces long time ago.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081434] Review Request: ip2location - IP2location library

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081434

Guruswamy Basavaiah  changed:

   What|Removed |Added

 Whiteboard|NotReady|



--- Comment #13 from Guruswamy Basavaiah  ---
 Spec  URL: http://www.ip2location.com/rpm/ip2location-c.spec
 SRPMS URL: http://www.ip2location.com/rpm/ip2location-c-6.0.3-1.fc20.src.rpm

Hello,
 Following issues are fixed in the above rpm.

 1) iMath library dependency is removed. 
 2) size checking long and off_t to 0 is fixed.
 3) "/usr/lib? " removed. 
 4) Ran rpmlint in F20, and fixed the date issue in spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095084] Review Request: perl-autobox-Junctions - Autoboxified junction-style operators

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095084

Petr Pisar  changed:

   What|Removed |Added

 Blocks||1094711




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1094711
[Bug 1094711] perl-MooseX-AttributeShortcuts-0.024 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095084] New: Review Request: perl-autobox-Junctions - Autoboxified junction-style operators

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095084

Bug ID: 1095084
   Summary: Review Request: perl-autobox-Junctions - Autoboxified
junction-style operators
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://ppisar.fedorapeople.org/perl-autobox-Junctions/perl-autobox-Junctions.spec
SRPM URL:
http://ppisar.fedorapeople.org/perl-autobox-Junctions/perl-autobox-Junctions-0.001-1.fc21.src.rpm
Description:
This is a simple autoboxifying wrapper around Syntax::Keyword::Junction Perl
module, that provides array and array references with the functions provided
by that package as methods for arrays: any, all, one, and none.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094581] Review Request: drupal7-admin_menu - Drupal7 Contrib Module

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094581



--- Comment #3 from Sam Wilson  ---
Updated to match guidelines at https://fedoraproject.org/wiki/Packaging:Drupal7

Spec URL:
http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.2/drupal7-admin_menu.spec
SRPM URL:
http://cycloptivity.fedorapeople.org/drupal7-admin_menu/3.0-0.2/drupal7-admin_menu-3.0-0.2.rc4.fc19.src.rpm

Build output: https://koji.fedoraproject.org/koji/taskinfo?taskID=6820861

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=613001



--- Comment #59 from Ken Dreyer  ---
Thanks very much for the review. I'm working on addressing the issues you
mentioned.

We kept %defattr() because we were going to support EL5. I'm on the fence about
supporting EL5 now, but let's keep it in for now.

I'll post an updated package in the next couple of days.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094415] Review Request: jai-imageio-core-standalone - Java Advanced Imaging Image I/O Tools API core (standalone)

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094415



--- Comment #2 from gil cattaneo  ---
(In reply to Orion Poplawski from comment #1)
> Looks like github based projects need to use the commit hash:
> https://fedoraproject.org/wiki/Packaging:SourceURL#Github

for "immutability, availability, uniqueness ... referring to the sources" 
should be sufficient to use the existing archive.
maybe this rule should be used with the repositories that do not have the
latest functionality of git*
and more than one package (even my), in http://pkgs.fedoraproject.org/cgit/
don't practice this rule

The really problem with this package is the bundled jj2000 library(
http://jpeg2000.epfl.ch/ , https://code.google.com/p/jj2000/ ), but
this one is a customization of the original. Maybe is necessary create/request
an FPC exception.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079618] Review Request: perl-MooX-late - Easily translate Moose code to Moo

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1079618



--- Comment #13 from Fedora Update System  ---
perl-MooX-late-0.014-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-MooX-late-0.014-3.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094581] Review Request: drupal7-admin_menu - Drupal7 Contrib Module

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094581



--- Comment #2 from Sam Wilson  ---
Hi Parag,

Thanks! I will work through a few reviews and upload a few more drupal7 contrib
modules.

First off is https://bugzilla.redhat.com/show_bug.cgi?id=1094042#c1

Cheers,

Sam

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094042] Review Request: skeleton-css - A beautiful CSS boilerplate for responsive, mobile-friendly development

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094042

Sam Wilson  changed:

   What|Removed |Added

 CC||cycloptiv...@internode.on.n
   ||et



--- Comment #1 from Sam Wilson  ---
Hi Jamie,

An informal review as I learn packaging guidelines. Notes are inline.

Cheers,

Sam

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
# Confirmed MIT licensed
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
# Builds OK https://koji.fedoraproject.org/koji/taskinfo?taskID=6820609
(Noarch)
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[ ]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
# Confirmed last commit is 7ab682091d1032035cfcb668e6bd4b465bfa4679
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[ ]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
 architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewe

[Bug 1095012] New: Review Request: jerasure - Erasure Coding library for storage applications

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095012

Bug ID: 1095012
   Summary: Review Request: jerasure - Erasure Coding library for
storage applications
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zait...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/zaitcev/tmp/jerasure-2.0-1.spec
SRPM URL: http://people.redhat.com/zaitcev/tmp/jerasure-2.0-1.fc20.src.rpm
Description: 
A library in C facilitating erasure coding for storage applications.
Fedora Account System Username: zaitcev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083941] Review Request: giac - Computer Algebra System

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1083941



--- Comment #24 from Han Frederic  ---
Add a scratch build link of the latest version:
https://koji.fedoraproject.org/koji/taskinfo?taskID=6820481

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1086790] Review Request: gnudos - A GNU library to help new users of the GNU system

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1086790



--- Comment #11 from Michael Schwendt  ---
Transaction check error:
  file /usr/share/info/dir from install of gnudos-1.1-3.fc20.x86_64 conflicts
with file from package info-5.1-4.fc20.x86_64


fedora-review tells:

Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Texinfo files are installed using install-info in %post and %preun if
  package has .info files.
  Note: Texinfo .info file(s) in gnudos
  See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Texinfo

Rpmlint
---
gnudos.x86_64: E: info-dir-file /usr/share/info/dir
gnudos-devel.x86_64: W: no-dependency-on gnudos/gnudos-libs/libgnudos
gnudos-devel.x86_64: W: spelling-error %description -l en_US corelib -> core
lib, core-lib, scoreline
gnudos-devel.x86_64: E: description-line-too-long C This package contains files
necessary to develop programs using the GnuDOS corelib library of functions.

The "no-dependency-on" warning refers to what has been linked at the top of
comment 6 of this ticket.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 881590] Review Request: leveldbjni - A Java Native Interface to LevelDB

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=881590

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version||leveldbjni-1.8-1.fc20
 Resolution|RAWHIDE |ERRATA



--- Comment #12 from Fedora Update System  ---
leveldbjni-1.8-1.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094417] Review Request: levigo-jbig2-imageio - A Java ImageIO plugin for the JBIG2 bi-level image format

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094417

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com
 Blocks||182235 (FE-Legal)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=182235
[Bug 182235] Fedora Legal Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079615] Review Request: perl-MooX-HandlesVia - NativeTrait-like behavior for Moo

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1079615

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|perl-MooX-HandlesVia-0.0010 |perl-MooX-HandlesVia-0.0010
   |05-2.fc20   |05-2.fc19



--- Comment #10 from Fedora Update System  ---
perl-MooX-HandlesVia-0.001005-2.fc19 has been pushed to the Fedora 19 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087740] Review Request: php-horde-nag - A web based task list manager

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087740
Bug 1087740 depends on bug 1087046, which changed state.

Bug 1087046 Summary: Review Request: php-horde-content - Tagging application
https://bugzilla.redhat.com/show_bug.cgi?id=1087046

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087046] Review Request: php-horde-content - Tagging application

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087046

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
   Fixed In Version||php-horde-content-2.0.3-2.f
   ||c20
 Resolution|--- |ERRATA
Last Closed||2014-05-06 17:33:08



--- Comment #9 from Fedora Update System  ---
php-horde-content-2.0.3-2.fc20 has been pushed to the Fedora 20 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087772] Review Request: php-horde-kronolith - A web based calendar

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087772
Bug 1087772 depends on bug 1087046, which changed state.

Bug 1087046 Summary: Review Request: php-horde-content - Tagging application
https://bugzilla.redhat.com/show_bug.cgi?id=1087046

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #22 from Fedora Update System  ---
gnome-code-assistance-0.3.1-5.fc20 has been pushed to the Fedora 20 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079618] Review Request: perl-MooX-late - Easily translate Moose code to Moo

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1079618



--- Comment #12 from Fedora Update System  ---
perl-MooX-late-0.014-3.fc20 has been pushed to the Fedora 20 stable repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1058941] Review Request: GtkAda3 - Ada binding to GTK+ 3

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1058941

Pavel Zhukov  changed:

   What|Removed |Added

 CC||bj...@xn--rombobjrn-67a.se
  Flags||needinfo?(bjorn@xn--rombobj
   ||rn-67a.se)



--- Comment #5 from Pavel Zhukov  ---
Issues:
===
- Header files in -devel subpackage, if present.
  Note: GtkAda3-doc : /usr/share/doc/GtkAda3/examples/testgtk/opengl/lw.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages

It's OK https://fedoraproject.org/wiki/Packaging_tricks#Examples

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2 or later)
 (with incorrect FSF address)", "Unknown or generated". 17 files have
 unknown license. Detailed output of licensecheck in /home/pavel/repo
 /GtkAda-review/review-GtkAda3/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by: /usr/share/gps(GtkAda-devel),
 /usr/lib64/gtkada(GtkAda-devel), /usr/include/gtkada(GtkAda-devel),
 /usr/share/gps/plug-ins(GtkAda-devel)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in GtkAda3-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate fr

[Bug 1085130] Review Request: kcm_systemd - Systemd control module for KDE

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085130

Kevin Kofler  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Kevin Kofler  ---
New Package SCM Request
===
Package Name: kcm_systemd
Short Description: Systemd control module for KDE
Owners: kkofler
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025977] Review Request: captcp - TCP Analyzer for PCAP Files

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025977



--- Comment #23 from Fedora Update System  ---
captcp-1.7-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/captcp-1.7-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1025977] Review Request: captcp - TCP Analyzer for PCAP Files

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1025977

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085130] Review Request: kcm_systemd - Systemd control module for KDE

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085130



--- Comment #5 from Kevin Kofler  ---
Thank you for your review!

This is technically not a GUI *application*, but a plugin for (KDE) System
Settings. As such, it doesn't need a menu entry. It is already reachable
through menu / System Settings / systemd.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085130] Review Request: kcm_systemd - Systemd control module for KDE

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085130

Joseph Marrero  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #4 from Joseph Marrero  ---
All seems OK

ACCEPTED


on a side note: since this is a GUI app It would be nice if upstream added the
app to the menu :) and a nice icon or maybe just use the standard gear icon.
-just an opinion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1060920] Review Request: openni2 - OpenNI libraries for 3D-sensing

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1060920



--- Comment #16 from Scott K Logan  ---
PrimeSense was bought by Apple and they shut down the website [1]. The article
specifically mentions that the code on GitHub will stay there. I'll change the
SPEC file to point there instread.

It looks like freenect has a version of the OpenNI2 driver that is supposed to
be placed in the %{_libdir}/openni2 directory. Is there such a thing as a
directory conflict, or can both packages provide that directory?

[1] http://www.i-programmer.info/news/194-kinect/7004-openni-to-close-.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085130] Review Request: kcm_systemd - Systemd control module for KDE

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085130



--- Comment #3 from Joseph Marrero  ---
f20: http://koji.fedoraproject.org/koji/taskinfo?taskID=6820162
rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=6820157

rpmlint:
SPECS]# rpmlint kcm_systemd.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

Installs OK

Macros OK

License OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085441] Review Request: openstack-sahara - Apache Hadoop cluster management on OpenStack

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085441



--- Comment #23 from Fedora Update System  ---
openstack-sahara-2014.1.0-12.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/openstack-sahara-2014.1.0-12.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1031342] Review Request: xorg-x11-drv-freedreno - xorg ddx driver for snapdragon/adreno arm SoC's

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1031342

Dennis Gilmore  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-05-06 15:46:57



--- Comment #31 from Dennis Gilmore  ---
package is now available in rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094415] Review Request: jai-imageio-core-standalone - Java Advanced Imaging Image I/O Tools API core (standalone)

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094415

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #1 from Orion Poplawski  ---
Looks like github based projects need to use the commit hash:
https://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1071653] Review Request: kmscon - KMS/DRM based System Console

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1071653

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #16 from Nicolas Chauvet (kwizart)  ---
New Package SCM Request
===
Package Name: kmscon
Short Description: KMS/DRM based System Console
Owners: kwizart
Branches: f20 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] Review Request: pam_script - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804



--- Comment #5 from Jason Taylor  ---
scratch builds with the updated spec and src rpm are successful:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819858 (f20)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819874 (el6)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6819892 (el5)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094905] Review Request: eclipse-remote - Eclipse Remote Services plug-in

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094905



--- Comment #3 from Mat Booth  ---
Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-remote.spec
SRPM URL:
http://fedorapeople.org/~mbooth/reviews/eclipse-remote-1.0.0-0.3.git19f4d9.fc21.src.rpm

Fresh scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6819869

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 957527] Review Request: unifying-receiver-udev - udev rules for user access to Logitech Unifying Receiver

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=957527

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|unifying-receiver-udev-0.2- |unifying-receiver-udev-0.2-
   |2.fc18  |2.el6



--- Comment #11 from Fedora Update System  ---
unifying-receiver-udev-0.2-2.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094905] Review Request: eclipse-remote - Eclipse Remote Services plug-in

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094905



--- Comment #2 from Mat Booth  ---
Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-remote.spec
SRPM URL:
http://fedorapeople.org/~mbooth/reviews/eclipse-remote-1.0.0-0.2.gite09793.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1082193] Review Request: perl-Date-Easter - Calculates Easter for any given year

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1082193

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|perl-Date-Easter-1.20-1.fc2 |perl-Date-Easter-1.20-1.el6
   |0   |



--- Comment #13 from Fedora Update System  ---
perl-Date-Easter-1.20-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1089178] Review Request: perl-Digest-Bcrypt - Perl interface to the bcrypt digest algorithm

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1089178

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version|perl-Digest-Bcrypt-1.0.1-1. |perl-Digest-Bcrypt-1.0.1-1.
   |fc20|el6



--- Comment #9 from Fedora Update System  ---
perl-Digest-Bcrypt-1.0.1-1.el6 has been pushed to the Fedora EPEL 6 stable
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094905] Review Request: eclipse-remote - Eclipse Remote Services plug-in

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094905



--- Comment #1 from Mat Booth  ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6819768

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094905] New: Review Request: eclipse-remote - Eclipse Remote Services plug-in

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094905

Bug ID: 1094905
   Summary: Review Request: eclipse-remote - Eclipse Remote
Services plug-in
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://fedorapeople.org/~mbooth/reviews/eclipse-remote.spec
SRPM URL:
http://fedorapeople.org/~mbooth/reviews/eclipse-remote-1.0.0-0.1.gite09793.fc21.src.rpm
Description: Remote Services provides an extensible remote services framework.
Fedora Account System Username: mbooth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079753] Review Request: perl-LWP-Protocol-connect - Provides HTTP/CONNECT proxy support for LWP::UserAgent

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1079753



--- Comment #11 from Sven Nierlein  ---
alright, sorry for the delay. Everything should be in place now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1065641] Review Request: libhttpserver - Library embedding RESTful HTTP server functionality

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1065641

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1065641] Review Request: libhttpserver - Library embedding RESTful HTTP server functionality

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1065641



--- Comment #14 from Fedora Update System  ---
libhttpserver-0.7.1-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/libhttpserver-0.7.1-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1071653] Review Request: kmscon - KMS/DRM based System Console

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1071653

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1071653] Review Request: kmscon - KMS/DRM based System Console

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1071653



--- Comment #15 from Jon Ciesla  ---
WARNING: "foo" is not in the packager group.
WARNING: "bar" is not a valid FAS account.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093407] Review Request: vdr-epg-daemon - A daemon to download EPG data from internet and manage it in a mysql database

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093407



--- Comment #20 from Fedora Update System  ---
vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc20 has been submitted as an update
for Fedora 20.
https://admin.fedoraproject.org/updates/vdr-epg-daemon-0.1.0-8.20140505gitd7fb6ca.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093407] Review Request: vdr-epg-daemon - A daemon to download EPG data from internet and manage it in a mysql database

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093407

MartinKG  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2014-05-06 12:39:55



--- Comment #19 from MartinKG  ---
vdr-epg-daemon has been built successfully on fc20 and fc21.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812



--- Comment #20 from marcindulak  ---
I prefer to wait with epel7 until openblas/libxc are in epel7.x86_64.
I also exclude el6.ppc64 from the spec.
Fedora %arm builds (with atlas).

Other problems fixed:
- openssh-clients BR is needed for mpiexec to run (see
http://koji.fedoraproject.org/koji/taskinfo?taskID=6817438 - this is an epel6
build where there is no openssh-clients dependency pulled in and mpiexec fails
with "ORTE_ERROR_LOG: Not found in file ess_hnp_module.c at line 194").
I experienced the same issue on the opensuse build system.
- gcc BR removed
- _gpaw.so permissions fixed
- COPYING will be included in the gpaw tarball (from the next release)
https://trac.fysik.dtu.dk/projects/gpaw/changeset/11439
- %files glob more explicit

Spec URL: http://marcindulak.fedorapeople.org/packages/gpaw/r02/gpaw.spec
SRPM URL:
http://marcindulak.fedorapeople.org/packages/gpaw/r02/gpaw-0.10.0.11364-2.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094864] New: Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094864

Bug ID: 1094864
   Summary: Review Request: php-pecl-xmldiff - Pecl package for
XML diff and merge
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pa...@hubbitus.info
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/91d764fa902cedfa1f8bddb32f844409290035d1/SPECS/php-pecl-xmldiff.spec
SRPM URL:
http://hubbitus.info/rpm/Fedora20/php-pecl-xmldiff/php-pecl-xmldiff-0.9.2-1.fc20.src.rpm
Description: The extension is able to produce diffs of two XML documents and
then to apply the difference to the source document. The diff is a XML document
containing copy/insert/delete instruction nodes in human readable format.
DOMDocument objects, local files and strings in memory can be processed.

Fedora Account System Username: hubbitus

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094329] Review Request: kf5-kcoreaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtCore

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094329



--- Comment #1 from Jan Grulich  ---
Build fine on Rawhide. License should be GPLv2+ and LGPLv2+.

Rpmlint shows errors:
kf5-kcoreaddons.x86_64: W: shared-lib-calls-exit
/usr/lib64/libKF5CoreAddons.so.4.99.0 exit@GLIBC_2.2.5

Not sure whether this one is false positive.

kf5-kcoreaddons.x86_64: E: incorrect-locale-subdir
/usr/share/locale/x-test/LC_MESSAGES/kcoreaddons5_qt.qm

This should be false positive.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1060920] Review Request: openni2 - OpenNI libraries for 3D-sensing

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1060920

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at



--- Comment #15 from Volker Fröhlich  ---
http://www.openni.org/ seems to be unreachable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] Review Request: pam_script - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804



--- Comment #4 from Jason Taylor  ---
Thanks Christopher! I have made the adjustments as requested, the links now
reflect the latest changes.

https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam_script.spec

https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam_script-1.1.7-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094320] Review Request: kf5-karchive - KDE Frameworks 5 Tier 1 addon with archive functions

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094320



--- Comment #2 from Jan Grulich  ---
Also it's not necessary to install INSTALL documentation file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1084246] Review Request: python-saharaclient - client library for OpenStack Sahara API

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1084246



--- Comment #22 from Fedora Update System  ---
python-saharaclient-0.7.0-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-saharaclient-0.7.0-3.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094329] Review Request: kf5-kcoreaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtCore

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094329

Jan Grulich  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1010613] Review Request: ck - Concurrency Kit

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1010613



--- Comment #14 from Joseph Marrero  ---
ping? Still going to work on this or lost interest?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094325] Review Request: kf5-kconfig - KDE Frameworks 5 Tier 1 addon with advanced configuration system

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094325



--- Comment #1 from Jan Grulich  ---
Doesn't build, because it cannot find /usr/libexec/kf5/kconf_update, because
this file is installed to /usr/lib64/libexec/kf5/kconf_update.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1085130] Review Request: kcm_systemd - Systemd control module for KDE

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1085130

Joseph Marrero  changed:

   What|Removed |Added

 CC||jmarr...@gmail.com
   Assignee|nob...@fedoraproject.org|jmarr...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1071653] Review Request: kmscon - KMS/DRM based System Console

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1071653

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #14 from Nicolas Chauvet (kwizart)  ---
New Package SCM Request
===
Package Name: kmscon
Short Description: KMS/DRM based System Console
Owners: foo bar
Branches: f20 epel7
InitialCC: kwizart

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094323] Review Request: kf5-kcodecs - KDE Frameworks 5 Tier 1 addon with string manipulation methods

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094323

Jan Grulich  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jan Grulich  ---
Same minor issues like in kf5-kauth. License should be GPLv2+ and LGPLv2+ and
BSD.

Rpmlint shows error:
kf5-kcodecs.x86_64: E: incorrect-locale-subdir
/usr/share/locale/x-test/LC_MESSAGES/kcodecs5_qt.qm

This should be false positive error, because x-test is KDE specific, as
described here [1].

[1] http://techbase.kde.org/Development/Tools

All above can be simply fixed before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1089425] Review Request: keepass - Password manager

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1089425

David King  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||amigad...@amigadave.com
   Assignee|nob...@fedoraproject.org|amigad...@amigadave.com
  Flags||fedora-review?



--- Comment #3 from David King  ---
Works fine, just some packaging guideline fixes required.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.

It seems that this is a requirement, and pretty easy to fix:
https://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

- License file not installed when -doc subpackage is installed

I do not know which license the documentation would be under, but my guess
would be (implicitly) the same as the rest of the package. I suggest including
License.txt in the -doc subpackage.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing

- Calls rm -rf %{buildroot} and mkdir %{buildroot} at the start of %install.

Is there a reason to do this? It looks like it just duplicates what RPM does,
according the the build log, and upsets fedora-review. Related to
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

- The -doc subpackage does not own /usr/share/doc/keepass

I suppose that the -doc subpackage should own the directory, in addition to the
keepass package.
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

- Icon theme directory ownership

Similar to the -doc subpackage ownership, the keepass package should own the
icon directories.

Optional issues:

- Preserve modification time of installed files. Adding "-p" to install and cp
arguments should help.

- The -doc subpackage should be noarch, as there is nothing
architecture-specific there. Also, it would be nice to move the %package for
the subpackage closer to the top of the file.

- Incorrect line-endings in -doc subpackage. I suppose that the same sed as for
the .txt files would be appropriate.

Bogus issues:

- The rpmlint errors are all bogus and can be ignored.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "GPL (v2 or later) (with incorrect FSF address)", "GPL (v2 or later)",
 "Unknown or generated". 73 files have unknown license. Detailed output of
 licensecheck in
 /home/david/checkout/rpms/1089425-keepass/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/doc/keepass
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/icons/hicolor/256x256/apps, /usr/share/mime/packages,
 /usr/share/mime, /usr/share/doc/keepass,
 /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in keepass
[x]: gtk-update-icon-cache is inv

[Bug 1094804] Review Request: pam_script - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804

Christopher Meng  changed:

   What|Removed |Added

Summary|Review Request: |Review Request: pam_script
   |pam-script-1.1.7 - PAM  |- PAM module for executing
   |module for executing|scripts
   |scripts |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] Review Request: pam-script-1.1.7 - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804



--- Comment #3 from Christopher Meng  ---
Use your real name in Bugzilla, not only an email address.

This package should be named pam_script instead of the current one you are
using.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] Review Request: pam-script-1.1.7 - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804



--- Comment #2 from jmtaylo...@gmail.com  ---
Thanks for the review Michael! I have updated the spec file and resultant srpm
as indicated. 

https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec

https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm

JT

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1089409



--- Comment #1 from Orion Poplawski  ---
* Mon May 5 2014 Orion Poplawski  - 5.5.1-1
- Update to 5.5.1

* Fri May 2 2014 Orion Poplawski  - 5.5-2
- Add EL support

* Thu May 1 2014 Orion Poplawski  - 5.5-1
- Update to 5.5

Spec URL: http://www.cora.nwra.com/~orion/fedora/Lmod.spec
SRPM URL: http://www.cora.nwra.com/~orion/fedora/Lmod-5.5.1-1.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094320] Review Request: kf5-karchive - KDE Frameworks 5 Tier 1 addon with archive functions

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094320

Jan Grulich  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jan Grulich  ---
Build fine on Rawhide and looks good to me. Just fix the version in your last
entry in %changelong, it should be 4.99.0-1 at the end of line and license
should be LGPLv2+ and BSD (in examples). Those are minor fixes, so it can be
simply done before import.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] Review Request: pam-script-1.1.7 - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804



--- Comment #1 from Michael Cronenworth  ---
Looks good. One note: Your Source0 line needs either a comment or adjusting.

See: http://fedoraproject.org/wiki/Packaging:SourceURL#Github

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087401] Review Request:perl-Signal-Mask - Signal masks made easy

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087401

David Shea  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from David Shea  ---
Looks good.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "Unknown or generated". 2 files have unknown license. Detailed output of
 licensecheck in /home/dshea/1087401-perl-Signal-Mask/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown must
 be documented in the spec.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requi

[Bug 1094804] Review Request: pam-script-1.1.7 - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804

jmtaylo...@gmail.com  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094804] New: Review Request: pam-script-1.1.7 - PAM module for executing scripts

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094804

Bug ID: 1094804
   Summary: Review Request: pam-script-1.1.7 - PAM module for
executing scripts
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jason.tay...@secure-24.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/jmtaylor90/pam-script-rpm/blob/master/specs/pam-script.spec
SRPM URL:
https://github.com/jmtaylor90/pam-script-rpm/blob/master/rpm/pam-script-1.1.7-1.fc20.src.rpm
Description: pam_script is a module which allows to execute scripts after
opening
and/or closing a session using PAM.

Fedora Account System Username: jtaylor

History:

https://bugzilla.redhat.com/show_bug.cgi?id=624705

This is my first package and need a sponsor. The goal is to have this package
in Fedora and EPEL 5/6. Successful koji scratch builds can be found here:

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818625 (f20)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818641 (el6)

http://koji.fedoraproject.org/koji/taskinfo?taskID=6818658 (el5)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087401] Review Request:perl-Signal-Mask - Signal masks made easy

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087401

David Shea  changed:

   What|Removed |Added

 CC||ds...@redhat.com
   Assignee|nob...@fedoraproject.org|ds...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087379] Review Request: perl-Thread-SigMask - Thread specific signal masks

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087379

David Shea  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from David Shea  ---
Looks good. The rpmlint warnings about spelling are obviously worthless, and
everything else is copacetic.

Here comes some text:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "Unknown or generated". 2 files have unknown license. Detailed output of
 licensecheck in /home/dshea/1087379-perl-Thread-SigMask/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown must
 be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
[x]: CPAN urls should be non-versioned.

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is presen

[Bug 1087379] Review Request: perl-Thread-SigMask - Thread specific signal masks

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087379

David Shea  changed:

   What|Removed |Added

 CC||ds...@redhat.com
   Assignee|nob...@fedoraproject.org|ds...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1060920] Review Request: openni2 - OpenNI libraries for 3D-sensing

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1060920

Jiri Kastner  changed:

   What|Removed |Added

 Depends On||1094787




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1094787
[Bug 1094787] kinect drivers path for openni
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054



--- Comment #21 from Fedora Update System  ---
gnome-code-assistance-0.3.1-5.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/gnome-code-assistance-0.3.1-5.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054



--- Comment #20 from Jon Ciesla  ---
NOTE: Misformatted request; using 'Branches' instead.
WARNING: No new branches requested.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094323] Review Request: kf5-kcodecs - KDE Frameworks 5 Tier 1 addon with string manipulation methods

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094323

Jan Grulich  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094325] Review Request: kf5-kconfig - KDE Frameworks 5 Tier 1 addon with advanced configuration system

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094325

Jan Grulich  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094320] Review Request: kf5-karchive - KDE Frameworks 5 Tier 1 addon with archive functions

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094320

Jan Grulich  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jgrul...@redhat.com
   Assignee|nob...@fedoraproject.org|jgrul...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094261] Review Request: perl-Module-Path - Get the full path to a locally installed module

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094261

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Module-Path-0.13-1.fc2
   ||1
 Resolution|--- |RAWHIDE
Last Closed||2014-05-06 08:44:32



--- Comment #6 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054

Elad Alfassa  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #19 from Elad Alfassa  ---
Package Change Request
==
Package Name: gnome-code-assistance
Owners: elad,nacho

I made a mistake in my SCM request and only listed nacho instead of listing
nacho and myself. Can you please change that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1070702] Review Request: lmdb - memory-mapped key-value database

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1070702

Honza Horak  changed:

   What|Removed |Added

 CC||hho...@redhat.com



--- Comment #8 from Honza Horak  ---
(In reply to Jan Staněk from comment #7)
> However as I stated, the naming scheme is not clear, and since I am not
> aware of any official guideline, it could be renamed back to "lmdb".

Just expressing my bigger sympathy for lmdb, which better aligns with other
*dbm packages like qdbm, gdbm, ..

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094261] Review Request: perl-Module-Path - Get the full path to a locally installed module

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094261



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1094261] Review Request: perl-Module-Path - Get the full path to a locally installed module

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1094261

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093640] Review Request: perl-Protocol-WebSocket - WebSocket protocol

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093640

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093407] Review Request: vdr-epg-daemon - A daemon to download EPG data from internet and manage it in a mysql database

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093407



--- Comment #18 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093640] Review Request: perl-Protocol-WebSocket - WebSocket protocol

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093640



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1093407] Review Request: vdr-epg-daemon - A daemon to download EPG data from internet and manage it in a mysql database

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1093407

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054



--- Comment #18 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1072054] Review Request: gnome-code-assistance - Common code assistance services for code editors

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1072054

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1065641] Review Request: libhttpserver - Library embedding RESTful HTTP server functionality

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1065641



--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 972568] Review Request: uthash - A hash table for C structures

2014-05-06 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=972568



--- Comment #21 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >