[Bug 1097985] Rename Request: naver-nanum-fonts - Nanum family of Korean TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1097985 Parag AN(पराग) changed: What|Removed |Added CC||fonts-bugs@lists.fedoraproj ||ect.org, ||i18n-bugs@lists.fedoraproje ||ct.org, panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097985] New: Rename Request: naver-nanum-fonts - Nanum family of Korean TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=1097985 Bug ID: 1097985 Summary: Rename Request: naver-nanum-fonts - Nanum family of Korean TrueType fonts Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: du...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://ueno.fedorapeople.org//naver-nanum-fonts.spec SRPM URL: http://ueno.fedorapeople.org//naver-nanum-fonts-20131007-1.fc20.src.rpm Description: Nanum fonts are collection of commonly-used Myeongjo and Gothic Korean font families, designed by Sandoll Communication and Fontrix. The publisher is Naver Corporation. This is a Rename request for the former package 'nhn-nanum-fonts' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092629] Review Request: jmapviewer
https://bugzilla.redhat.com/show_bug.cgi?id=1092629 Fedora Update System changed: What|Removed |Added Fixed In Version|jmapviewer-1.03-1.fc20 |jmapviewer-1.03-1.fc19 --- Comment #17 from Fedora Update System --- jmapviewer-1.03-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 MinGW Maintenance Account changed: What|Removed |Added CC|fedora-mingw@lists.fedorapr | |oject.org | Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- Package mingw-physfs-2.0.3-4.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing mingw-physfs-2.0.3-4.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-6368/mingw-physfs-2.0.3-4.fc20 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System changed: What|Removed |Added Fixed In Version|jortho-1.0-2.fc20 |jortho-1.0-2.fc19 --- Comment #16 from Fedora Update System --- jortho-1.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092096] Review Request: jortho - A spell checker for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1092096 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jortho-1.0-2.fc20 Resolution|--- |ERRATA Last Closed||2014-05-14 19:59:27 --- Comment #15 from Fedora Update System --- jortho-1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088882] Review Request: python-humanize - Turns dates in to human readable format, e.g '3 minutes ago'
https://bugzilla.redhat.com/show_bug.cgi?id=102 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- python-humanize-0.5-4.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092629] Review Request: jmapviewer
https://bugzilla.redhat.com/show_bug.cgi?id=1092629 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||jmapviewer-1.03-1.fc20 Resolution|--- |ERRATA Last Closed||2014-05-14 19:58:24 --- Comment #16 from Fedora Update System --- jmapviewer-1.03-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097943] Review Request: vdr-vnsiserver5 - VDR plugin to handle XBMC clients via VNSI, protocol version 5
https://bugzilla.redhat.com/show_bug.cgi?id=1097943 --- Comment #1 from Dr. Tilmann Bubeck --- And here is the rpmlint output: [bubeck@frodo rpmbuild]$ rpmlint SPECS/vdr-vnsiserver5.spec SPECS/vdr-vnsiserver5.spec: W: invalid-url Source0: vdr-vnsiserver5.tar.xz 0 packages and 1 specfiles checked; 0 errors, 1 warnings. [bubeck@frodo rpmbuild]$ rpmlint SRPMS/vdr-vnsiserver5-1.0.0-1.fc20.src.rpm vdr-vnsiserver5.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end vdr-vnsiserver5.src: W: spelling-error %description -l en_US backend -> backed, back end, back-end vdr-vnsiserver5.src: W: spelling-error %description -l en_US xbmc -> ICBM vdr-vnsiserver5.src: W: spelling-error %description -l en_US pvr -> pvt, pr, per vdr-vnsiserver5.src: W: spelling-error %description -l en_US vnsi -> ANSI vdr-vnsiserver5.src: W: invalid-url Source0: vdr-vnsiserver5.tar.xz 1 packages and 0 specfiles checked; 0 errors, 6 warnings. So only false positives -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097943] New: Review Request: vdr-vnsiserver5 - VDR plugin to handle XBMC clients via VNSI, protocol version 5
https://bugzilla.redhat.com/show_bug.cgi?id=1097943 Bug ID: 1097943 Summary: Review Request: vdr-vnsiserver5 - VDR plugin to handle XBMC clients via VNSI, protocol version 5 Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tilm...@bubecks.de QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://bubeck.fedorapeople.org/vdr-vnsiserver5.spec SRPM URL: http://bubeck.fedorapeople.org/vdr-vnsiserver5-1.0.0-1.fc20.src.rpm Description: This is a plugin for VDR, the video disk recorder. It is very similar to the existing package vdr-vnsiserver3, which I already maintain for Fedora. The difference is, that it offers protocol version 5 which is needed for XBMC 13. The existing package offers protocol version 3 which is used by XBMC 12. So depending on the XBMC version used, the user has to choose the appropriate package. Because XBMC and VDR can run on different machines, we have to maintain both versions, therefore two packages. The SPEC is closely modelled after the existing vdr-vnsiserver3, no great changes. Fedora Account System Username: bubeck -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1057766] Review Request: clustal-omega - command line tool for multiple sequence alignment
https://bugzilla.redhat.com/show_bug.cgi?id=1057766 --- Comment #22 from Mukundan Ragavan --- Ping as discussed! :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #23 from Mukundan Ragavan --- ---> client-devel is fixed. looks good here. But qpid-qmf pulls in qpid-cpp-client from the repos, conflicts with compat-* (as expected) and does not install. :( ---> Package python-qpid.noarch 0:0.24-1.fc20 will be installed --> Processing Dependency: python-qpid-common = 0.24-1.fc20 for package: python-qpid-0.24-1.fc20.noarch ---> Package python-qpid-qmf.x86_64 0:0.24-17.fc20 will be installed ---> Package qpid-cpp-client.x86_64 0:0.26-3.fc20 will be installed --> Running transaction check ---> Package python-qpid-common.noarch 0:0.24-1.fc20 will be installed --> Processing Conflict: compat-qpid-cpp-client-0.24-8.fc20.x86_64 conflicts qpid-cpp-client No package matched to upgrade: compat-qpid-cpp-client --> Finished Dependency Resolution Error: compat-qpid-cpp-client conflicts with qpid-cpp-client-0.26-3.fc20.x86_64 Or, am I doing something wrong here? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095404] Review Request: opendial - Toolkit for building dialog systems
https://bugzilla.redhat.com/show_bug.cgi?id=1095404 --- Comment #3 from Jerry James --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #1) > Bundled parts: > ./src/opendial/utils/AudioUtils.java have header: > * This file is part of jsresources.org jsresources.org has a collection of sample code for using the Java Sound API. It is intended to illustrate usage of various parts of the API to code authors. In this case, the upstream example code has been modified quite a bit by the opendial author. In that case (it is not vanilla upstream code, and the upstream code is not intended to be production code anyway), I believe the code does not run afoul of the no-bundling rule. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095404] Review Request: opendial - Toolkit for building dialog systems
https://bugzilla.redhat.com/show_bug.cgi?id=1095404 --- Comment #2 from Jerry James --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #1) > Bundled parts: > ./src/opendial/utils/AudioUtils.java have header: > * This file is part of jsresources.org Thanks, I will check into this one. > ./src/opendial/inference/approximate/SamplingProcess.java > * @author Pierre Lison (pli...@ifi.uio.no) Pierre Lison is the author of opendial. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 Igor Gnatenko changed: What|Removed |Added Flags||fedora-cvs? --- Comment #15 from Igor Gnatenko --- Thank you for the review! New Package SCM Request === Package Name: shiny Short Description: Shader and material management library for OGRE Owners: ignatenkobrain hobbes1069 Branches: f20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #22 from Darryl L. Pierce --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6850238 Updated spec: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp.spec Updated SRPM: http://mcpierce.fedorapeople.org/rpms/compat-qpid-cpp-0.24-8.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583
--- Comment #21 from Darryl L. Pierce ---
(In reply to Mukundan Ragavan from comment #20)
> That sounds fine to me.
>
> I was able to install most of the packages quite fine except
> compat-qpid-cpp-client-devel, compat-qpid-cpp-server-ha and
> compat-qpid-tools because of conflicts.
>
> For client-devel,
>
> %package client-devel
> Conflicts: qpid-cpp-client-devel
> Summary: Header files, documentation and testing tools for developing Qpid
> C++ clients
>
> Requires: qpid-cpp-client%{?_isa} = %{version}-%{release}
>
> This should be compat-qpid-cpp-client, I think.
>
> -server-ha and -tools both have dependency on qpid-qmf which pulls in qpid*
> and conflicts. :(
>
> Other than these two(or three?), I have no more issues and can approve the
> package pending these.
Excellent, thank you! I fixed those packages by marking them as providing the
qpid-cpp-* package with which they conflict and then verified that such would
work.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584
Richard Shaw changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #14 from Richard Shaw ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 50 files have unknown license. Detailed output of
licensecheck in /home/build/fedora-review/shiny/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[-]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-Engl
[Bug 1093408] Review Request: vdr-scraper2vdr - A client plugin which provides scraped metadata from EPGD to other plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1093408 --- Comment #15 from Fedora Update System --- vdr-scraper2vdr-0.1.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vdr-scraper2vdr-0.1.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1069259] Review Request: ndoutils - Store Nagios configuration and event data in a database
https://bugzilla.redhat.com/show_bug.cgi?id=1069259 --- Comment #15 from Simone Caronni --- Many thanks! Will update the spec file tomorrow. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1069259] Review Request: ndoutils - Store Nagios configuration and event data in a database
https://bugzilla.redhat.com/show_bug.cgi?id=1069259 Tom "spot" Callaway changed: What|Removed |Added Blocks|182235 (FE-Legal) | --- Comment #14 from Tom "spot" Callaway --- Update: * The nagios package in fedora does not contain any libpqueue code, so there is no issue there. * libpqueue upstream today relicensed their code as BSD to resolve compatibility issues, and since the ndoutils copy of pqueue.h is almost identical, the core can also be considered to be BSD, with the changes from ndoutils/nagios being GPLv2. Thus, if we include a comment in the spec file pointing to the libpqueue upstream relicensing commit, I think we can move forward with this item without legal concern. # libpqueue has been relicensed to BSD to resolve this issue: # https://github.com/vy/libpqueue/commit/de6480009c60afff22d4c7edf4353ef87797e497 Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825409] Review Request: gazebo - 3D multi-robot simulator with dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=825409 Scott K Logan changed: What|Removed |Added Assignee|nob...@fedoraproject.org|log...@cottsay.net Flags||fedora-review? --- Comment #31 from Scott K Logan --- Tim, I would be happy to review this package. I'll try to take a look tonight. Thanks for testing this package! I'm excited to see this brought into Fedora proper. --scott -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 982705] Review Request: meme - Use the command line to generate memes on memegenerator.co
https://bugzilla.redhat.com/show_bug.cgi?id=982705 Douglas Schilling Landgraf changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |INSUFFICIENT_DATA Last Closed||2014-05-14 13:11:10 --- Comment #4 from Douglas Schilling Landgraf --- No answer, closing for now as insufficient data, fell free to reopen it when you have spec/src.rpm ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge
https://bugzilla.redhat.com/show_bug.cgi?id=1094864 Remi Collet changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #14 from Remi Collet --- [x]: Package must own all directories that it creates. === APPROVED === -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge
https://bugzilla.redhat.com/show_bug.cgi?id=1094864 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Flags|fedora-cvs? |fedora-review? --- Comment #13 from Pavel Alexeev (aka Pahan-Hubbitus) --- Changes: https://github.com/Hubbitus/Fedora-packaging/commit/84b526b1d6149e7a771e597ae5d794b2a5f36b40 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/84b526b1d6149e7a771e597ae5d794b2a5f36b40/SPECS/php-pecl-xmldiff.spec Srpm: http://hubbitus.info/rpm/Fedora20/php-pecl-xmldiff/php-pecl-xmldiff-0.9.2-4.fc20.src.rpm P.S. I assume you are by mistake set flag fedora-cvs=?, I change it on fedora-review=? Instead. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 825409] Review Request: gazebo - 3D multi-robot simulator with dynamics
https://bugzilla.redhat.com/show_bug.cgi?id=825409 Tim Niemueller changed: What|Removed |Added CC||t...@niemueller.de --- Comment #30 from Tim Niemueller --- We've been using the package for a while now and it works like a charm. We'd really like to see this included to make it easy for everybody to use. Scott, do you want to proceed with the review? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #13 from Richard Shaw --- Done. I didn't bother with bumping the release for such a small problem though. Should be ready for fedora-review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583
--- Comment #20 from Mukundan Ragavan ---
That sounds fine to me.
I was able to install most of the packages quite fine except
compat-qpid-cpp-client-devel, compat-qpid-cpp-server-ha and compat-qpid-tools
because of conflicts.
For client-devel,
%package client-devel
Conflicts: qpid-cpp-client-devel
Summary: Header files, documentation and testing tools for developing Qpid
C++ clients
Requires: qpid-cpp-client%{?_isa} = %{version}-%{release}
This should be compat-qpid-cpp-client, I think.
-server-ha and -tools both have dependency on qpid-qmf which pulls in qpid* and
conflicts. :(
Other than these two(or three?), I have no more issues and can approve the
package pending these.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097426] Review Request: dpdk - dataplane development toolkit for optimized network appliances
https://bugzilla.redhat.com/show_bug.cgi?id=1097426 --- Comment #2 from Neil Horman --- new SPEC: http://people.redhat.com/nhorman/dpdk.spec new SRPM: https://people.redhat.com/nhorman/dpdk-1.7.0-0.1.20140513gitb20539d68.src.rpm Listed problems fixed. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1081434] Review Request: ip2location - IP2location library
https://bugzilla.redhat.com/show_bug.cgi?id=1081434
Paulo Andrade changed:
What|Removed |Added
CC||paulo.cesar.pereira.de.andr
||a...@gmail.com
--- Comment #15 from Paulo Andrade
---
You can run something like "fedora-review -b 1081434" to
mimic what a reviewer would do.
You should have a %check section. This helps the reviewer
to be more confident that the package is functional. Should
be somewhat like:
%check
LD_LIBRARY_PATH=%{buildroot}%{_libdir}:$LD_LIBRARY_PATH make check
---%<---
I did run it directly from the build, and it fails:
$ LD_LIBRARY_PATH=../libIP2Location/.libs make check
[...]
$ cat test-suite.log
===
IP2Loc 6.0.3: test/test-suite.log
===
# TOTAL: 1
# PASS: 0
# SKIP: 0
# XFAIL: 0
# FAIL: 1
# XPASS: 0
# ERROR: 0
.. contents:: :depth: 2
FAIL: test-IP2Location
==
IP2Location IPv4 Testing passed.
Test IP Address 2001:0D30:010E:: (Test 11) failed. We got - but expected LA,
Test IP Address 2001:4830:00EA:: (Test 12) failed. We got - but expected US,
Test IP Address 2001:0200:0b01:: (Test 13) failed. We got - but expected JP,
Test IP Address 2001:0388:f000:: (Test 14) failed. We got - but expected AU,
---%<---
There is a bogus wrapper.log file in the tarball btw, that apparently is
from some failed java interface test.
I did a quick look in the sources, and this is a really bad way
to check for big endian :-)
---%<---
#ifdef _SUN_
char * p = (char *) &ret;
/* for SUN SPARC, have to reverse the byte order */
[...]
#else
[...]
#endif
---%<---
This will fail for fedora powerpc64 that is big endian.
It could be interesting if you talk with geoip and geoip-lite
packages maintainer. Apparently a Red Hat employee that should
also be well aware of all issues (as well as legal ones, as I
understand you cannot distribute for free the full database).
But the geoip* packages appear to be in an inconsistent state...
https://admin.fedoraproject.org/pkgdb/package/geoip-geolite/
http://pkgs.fedoraproject.org/cgit/geoip-geolite.git/
and being replaced by a geoip package:
https://bugzilla.redhat.com/show_bug.cgi?id=968074
Do you have any pointers to packages/projects using ip2location?
That could help in bringing more interest from people on it, e.g.
apparently spamassassin uses geoip.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1069259] Review Request: ndoutils - Store Nagios configuration and event data in a database
https://bugzilla.redhat.com/show_bug.cgi?id=1069259 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com --- Comment #13 from Tom "spot" Callaway --- Emailed libpqueue upstream to see if there is any chance of resolving the licensing concern. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge
https://bugzilla.redhat.com/show_bug.cgi?id=1094864
Remi Collet changed:
What|Removed |Added
Flags||fedora-cvs?
--- Comment #12 from Remi Collet ---
MUST
[!]: Package must own all directories that it creates.
Must own /usr/share/doc/pecl/xmldiff
-%doc %{pecl_docdir}/%peclName/CREDITS
-%doc %{pecl_docdir}/%peclName/LICENSE
+%doc %{pecl_docdir}/%peclName
Notice:
[!]: Development files must be in a -devel package
Not provided on packager choice.
Could be add later.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge
https://bugzilla.redhat.com/show_bug.cgi?id=1094864 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|fed...@famillecollet.com --- Comment #11 from Remi Collet --- Created attachment 895520 --> https://bugzilla.redhat.com/attachment.cgi?id=895520&action=edit review.txt Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1094864 Buildroot used: fedora-20-x86_64 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #12 from Igor Gnatenko --- Ok. now we have one rpmlint error: shiny.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libshiny.so.0 /lib64/libm.so.6 Could you fix it ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092018] Review Request: rubygem-comp_tree - A simple framework for automatic parallelism
https://bugzilla.redhat.com/show_bug.cgi?id=1092018 Jan Pradac changed: What|Removed |Added CC||jan.pra...@gmail.com Assignee|nob...@fedoraproject.org|jan.pra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #11 from Igor Gnatenko --- New SPEC: http://ignatenkobrain.fedorapeople.org/for-review/shiny.spec New SRPM: http://ignatenkobrain.fedorapeople.org/for-review/shiny-0.2-2.gitf41178f.fc21.src.rpm * Wed May 14 2014 Richard Shaw - 0.2-2.gitf41178f - Add patch to set soversion, install targets, and linking with Boost. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 831881] Review Request: ovirt-iso-uploader - Tool for uploading files into ISO domains
https://bugzilla.redhat.com/show_bug.cgi?id=831881 Sandro Bonazzola changed: What|Removed |Added Flags|needinfo?(kroberts@redhat.c | |om) | --- Comment #3 from Sandro Bonazzola --- Spec URL: http://gerrit.ovirt.org/gitweb?p=ovirt-iso-uploader.git;a=blob_plain;f=ovirt-iso-uploader.spec.in;h=a927e52a407d0d0261c95d8434f9f15222b2d1fd;hb=HEAD Nightly sources: http://resources.ovirt.org/pub/ovirt-master-snapshot/src/ovirt-iso-uploader/ Stable release sources: http://resources.ovirt.org/pub/src/ovirt-iso-uploader/ Let me know if something is still missing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 Richard Shaw changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #10 from Richard Shaw --- (In reply to Igor Gnatenko from comment #9) > Probably I will give you permissions to fedorapeople git repo and we can > work there? Sure. I just know enough git to get by (haha) but sounds good to me. Richard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584
--- Comment #9 from Igor Gnatenko ---
(In reply to Richard Shaw from comment #6)
> Yes, already working on it :)
>
> I also had to add install targets since cmake doesn't automatically create
> the symbolic links unless you have cmake install the libraries. Right now
> I'm leaving the header install alone since your method is easier.
>
> I'm having more trouble with the private library, libshiny.OgrePlatform.so.
> Are you sure it needs to go into a subdirectory of /usr/lib{64}? There's no
> chance of a name clash...
take a look ogre-pading There the same library installing to
/usr/lib64/OGRE/.
(In reply to Richard Shaw from comment #8)
> Created attachment 895501 [details]
> Updated spec file, soversion is set from spec file.
Thank you!
(In reply to Richard Shaw from comment #7)
> Created attachment 895500 [details]
> Patch to fix install, soversion, and boost linking.
Thank you!
Probably I will give you permissions to fedorapeople git repo and we can work
there?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #8 from Richard Shaw --- Created attachment 895501 --> https://bugzilla.redhat.com/attachment.cgi?id=895501&action=edit Updated spec file, soversion is set from spec file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #7 from Richard Shaw --- Created attachment 895500 --> https://bugzilla.redhat.com/attachment.cgi?id=895500&action=edit Patch to fix install, soversion, and boost linking. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584
--- Comment #6 from Richard Shaw ---
Yes, already working on it :)
I also had to add install targets since cmake doesn't automatically create the
symbolic links unless you have cmake install the libraries. Right now I'm
leaving the header install alone since your method is easier.
I'm having more trouble with the private library, libshiny.OgrePlatform.so. Are
you sure it needs to go into a subdirectory of /usr/lib{64}? There's no chance
of a name clash...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584
--- Comment #5 from Martin Gieseking ---
I agree with Richard. If upstream doesn't want to offer shlib support, it's
also possible to manage it locally, but that's not necessarily required IMHO.
Just a short note:
Your patch looks good so far. In order to set the soversion, you have to add
something like the following to CMakeLists.txt. Just put it somewhere after
set(SHINY_LIBRARY ${SHINY_LIBRARY} PARENT_SCOPE):
set_target_properties(
shiny
PROPERTIES
VERSION 0.0.0
SOVERSION 0
)
As a result, you get the three files libshiny.so.0.0.0, libshiny.so.0, and
libshiny.so where the last two are symlinks. libshiny.so is a development file
and should go to the devel package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 Richard Shaw changed: What|Removed |Added CC||hobbes1...@gmail.com Assignee|nob...@fedoraproject.org|hobbes1...@gmail.com Flags||fedora-review? --- Comment #4 from Richard Shaw --- I think I can help you out here, the only problem is what soversion to set? I also have package that does not set a soversion nor maintains ABI compatibility so what I have ended up doing is setting the soversion arbitrarily and then on new releases use abi-compliance-checker (that I also maintain) to check for ABI breakages, if found then I increment the soversion and rebuild dependencies. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1073017] Review Request: parquet - Java readers/writers for Parquet columnar file formats to use with Map-Reduce
https://bugzilla.redhat.com/show_bug.cgi?id=1073017 --- Comment #1 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/parquet.spec SRPM URL: http://gil.fedorapeople.org/parquet-1.4.3-1.fc19.src.rpm - update to 1.4.3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1073014] Review Request: parquet-format - Columnar file format for Hadoop
https://bugzilla.redhat.com/show_bug.cgi?id=1073014 --- Comment #2 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/parquet-format.spec SRPM URL: http://gil.fedorapeople.org/parquet-format-2.1.0-1.fc19.src.rpm - update to 2.1.0 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #19 from Darryl L. Pierce --- (In reply to Mukundan Ragavan from comment #18) > ---> obsoletes fixed. > > * $ rpmls compat-qpid-cpp-client-0.24-7.fc21.x86_64.rpm > > [ ... ] > -rwxr-xr-x /usr/lib64/libqpidtypes.so.1.0.0 > drwxr-xr-x /usr/lib64/qpid > drwxr-xr-x /usr/lib64/qpid/client > drwxr-xr-x /usr/share/doc/compat-qpid-cpp-client > -rw-r--r-- /usr/share/doc/compat-qpid-cpp-client/DESIGN > [ ... ] > > ---> So, qpid directories ownerships are fine. > > ---> -ha issue seems reasonable to me. > > * compat-qpid-cpp-server-store.x86_64: W: dangling-relative-symlink > /usr/lib64/qpid/daemon/store.so store.so.0.24 > > ---> store.so.0.24 is part of server which is a dependency. So, this is fine. > > > > Could you please clarify the following - > > * compat-qpid-cpp-server-ha.x86_64: E: subsys-not-used > /etc/rc.d/init.d/qpidd-primary > > No lock file? The file uses the same lockfile as /etc/rc.d/init.d/qpidd. This particular script is for starting up the primary broker in a cluster, so you can't run both it and qpidd at the same time. Hence the single lock file between them. > * Lastly, there is this unversioned -so files not in a devel package. > > Unversioned so-files > > compat-qpid-cpp-server: /usr/lib64/qpid/daemon/ha.so > compat-qpid-cpp-server: /usr/lib64/qpid/daemon/legacystore.so > compat-qpid-cpp-server: /usr/lib64/qpid/daemon/store.so > compat-qpid-cpp-server: /usr/lib64/qpid/daemon/xml.so > compat-qpid-cpp-server-ha: /usr/lib64/qpid/daemon/ha.so > compat-qpid-cpp-client-rdma: /usr/lib64/librdmawrap.so > compat-qpid-cpp-client-rdma: /usr/lib64/qpid/client/rdmaconnector.so > compat-qpid-cpp-server-rdma: /usr/lib64/qpid/daemon/rdma.so > compat-qpid-cpp-server-xml: /usr/lib64/qpid/daemon/xml.so > compat-qpid-cpp-server-store: /usr/lib64/qpid/daemon/store.so They're not development libraries (which is why they're not public) but are plugins to for the broker and the client libraries. That's why they all live in the qpid subdirectory (except rdmawrap, which should be in the qpid directory, so I'll file a bug upstream to fix that install location). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097733] Review Request: python-rply - Pure Python parser generator
https://bugzilla.redhat.com/show_bug.cgi?id=1097733 Robert Kuska changed: What|Removed |Added Status|NEW |ASSIGNED CC||rku...@redhat.com Docs Contact||rku...@redhat.com Flags||fedora-review? --- Comment #1 from Robert Kuska --- I'll take this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097733] New: Review Request: python-rply - Pure Python parser generator
https://bugzilla.redhat.com/show_bug.cgi?id=1097733 Bug ID: 1097733 Summary: Review Request: python-rply - Pure Python parser generator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mstuc...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://mstuchli.fedorapeople.org/python-rply.spec SRPM URL: http://mstuchli.fedorapeople.org/python-rply-0.7.2-1.fc20.src.rpm Description: rply is a pure python parser generator, that also works with Python. It is a more-or-less direct port of David Beazley's awesome PLY, with a new public API, and RPython support. Fedora Account System Username: mstuchli -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097714] Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you build a flexible logging system
https://bugzilla.redhat.com/show_bug.cgi?id=1097714 Matej Stuchlik changed: What|Removed |Added Status|NEW |ASSIGNED CC||mstuc...@redhat.com Flags||fedora-review? --- Comment #1 from Matej Stuchlik --- I'll take this. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097714] New: Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you build a flexible logging system
https://bugzilla.redhat.com/show_bug.cgi?id=1097714 Bug ID: 1097714 Summary: Review Request: golang-github-spacemonkeygo-spacelog - Designed to help you build a flexible logging system Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rku...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog.spec SRPM URL: http://rkuska.fedorapeople.org/pkgs/golang-github-spacemonkeygo-spacelog-0-0.1.gitda2b15a.fc20.src.rpm Description: Package spacelog is a collection of interface lego bricks designed to help you build a flexible logging system. Spacelog is loosely inspired by the Python logging library. Fedora Account System Username: rkuska Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6848397 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079751] Review Request: perl-Date-Calc-XS - XS wrapper and C library plug-in for Date::Calc
https://bugzilla.redhat.com/show_bug.cgi?id=1079751
--- Comment #11 from David Dick ---
Hi Sven,
The following is a patch summarizing the remaining work for this bug.
--- perl-Date-Calc-XS.spec 2014-04-21 23:42:28.0 +1000
+++ perl-Date-Calc-XS.proposed 2014-05-14 21:35:30.415071204 +1000
@@ -6,27 +6,43 @@
Group: Development/Libraries
URL:http://search.cpan.org/dist/Date-Calc-XS/
Source0:
http://www.cpan.org/modules/by-module/Date/Date-Calc-XS-%{version}.tar.gz
+# glibc-common contains the iconv binary
+BuildRequires: glibc-common
BuildRequires: perl
+BuildRequires: perl(Bit::Vector)
+BuildRequires: perl(bytes)
+BuildRequires: perl(Config)
+BuildRequires: perl(Date::Calc::Object)
+BuildRequires: perl(Date::Calendar)
+BuildRequires: perl(Date::Calendar::Profiles)
+BuildRequires: perl(Date::Calendar::Year)
+BuildRequires: perl(DynaLoader)
+BuildRequires: perl(Exporter)
BuildRequires: perl(Test::More) >= 0.47
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Carp::Clan) >= 6.01
BuildRequires: perl(Bit::Vector) >= 7.1
BuildRequires: perl(Date::Calc) >= 6.3
+BuildRequires: perl(strict)
+BuildRequires: perl(vars)
+Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
%description
Date::Calc::XS is a XS wrapper and C library plug-in for Date::Calc
%prep
%setup -q -n Date-Calc-XS-%{version}
+iconv --from=ISO-8859-1 --to=UTF-8 CREDITS.txt >CREDITS.fixed
+mv CREDITS.fixed CREDITS.txt
%build
-%{__perl} Makefile.PL INSTALLDIRS=vendor
+%{__perl} Makefile.PL INSTALLDIRS=vendor OPTIMIZE="$RPM_OPT_FLAGS"
make %{?_smp_mflags}
%install
make pure_install DESTDIR=$RPM_BUILD_ROOT
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;
+find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \;
%{_fixperms} $RPM_BUILD_ROOT/*
%check
Hope this helps.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1095662 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1095662 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094331] Review Request: kf5-kdbusaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtDBus
https://bugzilla.redhat.com/show_bug.cgi?id=1094331 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094331] Review Request: kf5-kdbusaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtDBus
https://bugzilla.redhat.com/show_bug.cgi?id=1094331 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088882] Review Request: python-humanize - Turns dates in to human readable format, e.g '3 minutes ago'
https://bugzilla.redhat.com/show_bug.cgi?id=102 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088882] Review Request: python-humanize - Turns dates in to human readable format, e.g '3 minutes ago'
https://bugzilla.redhat.com/show_bug.cgi?id=102 --- Comment #9 from Fedora Update System --- python-humanize-0.5-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-humanize-0.5-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088882] Review Request: python-humanize - Turns dates in to human readable format, e.g '3 minutes ago'
https://bugzilla.redhat.com/show_bug.cgi?id=102 --- Comment #10 from Fedora Update System --- python-humanize-0.5-4.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-humanize-0.5-4.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502
--- Comment #4 from Lubomir Rintel ---
The above review makes sense. Just some random extra things I've verified
manually:
* Package is named correctly
* The version tag makes sense
* License tag is correct
* License is fine
* License text included
* rpmlint is happy
* SPEC file is clean and legible
Nothing severe really stands out; basically a couple of style issues:
0.) The description is a bit weird: Please do not repeat the summary and omit
the hyperlinks.
%description
This (cli) is the library for implementing powerful command-line
interfaces in Go. It's used by Self and Packer.
%description devel
This package contains the library for implementing powerful command-line
interfaces in Go. It's intended for building other packages which use these
functions.
1.) Please move BuildRequires ourside %package section.
2.) The package should always be noarch.
It only ships architecture-independent files. See [1]
[1]
https://fedoraproject.org/wiki/Packaging:Guidelines#Noarch_with_unported_dependencies
-%if 0%{?fedora} >= 19 || 0%{?rhel} >= 7
-BuildArch: noarch
-%else
-ExclusiveArch: %{ix86} x86_64 %{arm}
-%endif
+BuildArch: noarch
+%if 0%{?fedora} < 19 && 0%{?rhel} < 7
+ExclusiveArch: %{ix86} x86_64 %{arm} noarch
+%endif
3.) No need for the %attr macro; install files with correct mode in %install.
You won't need to list the whole hierarchy too.
-%dir %attr(755,root,root) %{gopath}
-%dir %attr(755,root,root) %{gopath}/src
-%dir %attr(755,root,root) %{gopath}/src/github.com
-%dir %attr(755,root,root) %{gopath}/src/github.com/mitchellh
-%dir %attr(755,root,root) %{gopath}/src/%{import_path}
-%attr(644,root,root) %{gopath}/src/%{import_path}/*.go
+%{gopath}
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096704] Review Request: python-bintrees - Binary-, RedBlack- and AVL-Trees in Python and Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1096704 --- Comment #2 from Matej Stuchlik --- I'm getting a bunch of errors from rpmlint, we should get rid of those, first: python3-bintrees.x86_64: W: spelling-error %description -l en_US dicts -> ducts, dicta, dict python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/rbtree.py 0644L /usr/bin/env python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/treeslice.py 0644L /usr/bin/env python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/abctree.py 0644L /usr/bin/env python3-bintrees.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/python3.3/site-packages/bintrees/abctree.py python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/bintree.py 0644L /usr/bin/env python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/__init__.py 0644L /usr/bin/env python3-bintrees.x86_64: E: non-standard-executable-perm /usr/lib64/python3.3/site-packages/bintrees/cython_trees.cpython-33m.so 0775L python3-bintrees.x86_64: E: non-executable-script /usr/lib64/python3.3/site-packages/bintrees/avltree.py 0644L /usr/bin/env python-bintrees.x86_64: W: spelling-error %description -l en_US dicts -> ducts, dicta, dict python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/treeslice.py 0644L /usr/bin/env python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/__init__.py 0644L /usr/bin/env python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/abctree.py 0644L /usr/bin/env python-bintrees.x86_64: E: wrong-script-end-of-line-encoding /usr/lib64/python2.7/site-packages/bintrees/abctree.py python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/bintree.py 0644L /usr/bin/env python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/rbtree.py 0644L /usr/bin/env python-bintrees.x86_64: E: non-executable-script /usr/lib64/python2.7/site-packages/bintrees/avltree.py 0644L /usr/bin/env python-bintrees.x86_64: E: non-standard-executable-perm /usr/lib64/python2.7/site-packages/bintrees/cython_trees.so 0775L 2 packages and 0 specfiles checked; 16 errors, 2 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060502] Review Request: golang-github-mitchellh-cli - A library for implementing powerful command-line interfaces in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1060502 Lubomir Rintel changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk Assignee|nob...@fedoraproject.org|lkund...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #3 from Igor Gnatenko --- (In reply to Martin Gieseking from comment #2) > > shiny.x86_64: E: invalid-soname /usr/lib64/libshiny.so libshiny.so > > If libshiny is supposed to be linked dynamically (and not just accessed via > dlopen), it should get a proper soname reflecting the ABI version, e.g. > something like libshiny.so.1. As long as future versions of the library > don't change the interface, the soversion should be constant while the > version of the package may increase, of course. I suggest to ask the > upstream developer whether he/she can add support for building the shared > library including a reliable ABI versioning. > > Since there is no proper shlib support yet, you can also package the static > library. I've sent bugreport[0] to upstream. I'm packaging this because stuntrally using bundled shiny. It just compiling shiny and linking with it. Probably you can help me write correctly patch for providing shared libraries ? [0]https://github.com/scrawl/shiny/issues/20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1095662 David Dick changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from David Dick --- New Package SCM Request === Package Name: perl-Sys-Detect-Virtualization Short Description: Detect if a UNIX system is running as a virtual machine Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig Thanks for the review Petr. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094331] Review Request: kf5-kdbusaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtDBus
https://bugzilla.redhat.com/show_bug.cgi?id=1094331 Dan Vrátil changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Dan Vrátil --- New Package SCM Request === Package Name: kf5-kdbusaddons Short Description: KDE Frameworks Tier 1 addon with various classes on top of QtDBus Owners: dvratil jgrulich kkofler rdieter ltinkl Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095404] Review Request: opendial - Toolkit for building dialog systems
https://bugzilla.redhat.com/show_bug.cgi?id=1095404 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added CC||pa...@hubbitus.info --- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) --- Bundled parts: ./src/opendial/utils/AudioUtils.java have header: * This file is part of jsresources.org ./src/opendial/inference/approximate/SamplingProcess.java * @author Pierre Lison (pli...@ifi.uio.no) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 Martin Gieseking changed: What|Removed |Added CC||martin.giesek...@uos.de --- Comment #2 from Martin Gieseking --- > shiny.x86_64: E: invalid-soname /usr/lib64/libshiny.so libshiny.so If libshiny is supposed to be linked dynamically (and not just accessed via dlopen), it should get a proper soname reflecting the ABI version, e.g. something like libshiny.so.1. As long as future versions of the library don't change the interface, the soversion should be constant while the version of the package may increase, of course. I suggest to ask the upstream developer whether he/she can add support for building the shared library including a reliable ABI versioning. Since there is no proper shlib support yet, you can also package the static library. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 --- Comment #11 from Fedora Update System --- mingw-physfs-2.0.3-4.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mingw-physfs-2.0.3-4.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 --- Comment #10 from Fedora Update System --- mingw-physfs-2.0.3-4.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/mingw-physfs-2.0.3-4.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1095662 Petr Šabata changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Petr Šabata --- Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092022] Review Request: rubygem-drake - A branch of Rake supporting automatic parallelizing of tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1092022 Miroslav Spousta changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1092022] Review Request: rubygem-drake - A branch of Rake supporting automatic parallelizing of tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1092022 Miroslav Spousta changed: What|Removed |Added CC||q...@ucw.cz Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094864] Review Request: php-pecl-xmldiff - Pecl package for XML diff and merge
https://bugzilla.redhat.com/show_bug.cgi?id=1094864 --- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) --- Thanks. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/ef13554c5447c41db42bd3224a507dc975de297c Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/ef13554c5447c41db42bd3224a507dc975de297c/SPECS/php-pecl-xmldiff.spec Srpm: http://hubbitus.info/rpm/Fedora20/php-pecl-xmldiff/php-pecl-xmldiff-0.9.2-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1095662 --- Comment #4 from David Dick --- (In reply to Petr Šabata from comment #3) > (In reply to David Dick from comment #2) > > (In reply to Petr Šabata from comment #1) > > > Are the explicit run-requires in the virtdetect package necessary? > > > > It was the only way i knew to remove the requires for Getopt::Long, POSIX, > > etc from perl-Sys-Detect-Virtualization (where they are not required) and > > keep them in virtdetect (where they are). Suggestions? > > You don't need to remove them at all; they're not there :) > Just drop the req filters in the main package and explicit run requires in > the virtdetect one. It will work like a charm. The dependencies (and > provides) are put in the packages according to what files they include. Hmmm... yes it does.. filters and explicit run requires removed. > > > It might not be obvious to the user that virtdetect is a subpackage of > > > this > > > one; maybe packaging the README in its own %doc would be a good idea? > > > > Okay. Along the same sort of line, i thought including the Changelog would > > be useful too? > > Could be but I find it somewhat less important; the README points the user > to the main package which is installed and provides the Changelog already. Okay. removed Changelog file. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 --- Comment #1 from Igor Gnatenko --- I have no idea how to fix this: shiny.x86_64: E: invalid-soname /usr/lib64/libshiny.so libshiny.so shiny.x86_64: W: undefined-non-weak-symbol /usr/lib64/libshiny.so boost::filesystem::absolute(boost::filesystem::path const&, boost::filesystem::path const&) shiny.x86_64: W: undefined-non-weak-symbol /usr/lib64/libshiny.so boost::thread_detail::commit_once_region(boost::once_flag&) shiny.x86_64: W: undefined-non-weak-symbol /usr/lib64/libshiny.so boost::wave::grammars::expression_grammar_gen, std::allocator, boost::wave::util::CowString >, char*> > > > >::evaluate(std::_List_const_iterator, std::allocator, boost::wave::util::CowString >, char*> > > > > const&, std::_List_const_iterator, std::allocator, boost::wave::util::CowString >, char*> > > > > const&, boost::wave::util::file_position, std::allocator, boost::wave::util::CowString >, char*> > > const&, bool, boost::wave::grammars::value_error&) shiny.x86_64: W: undefined-non-weak-symbol /usr/lib64/libshiny.so boost::filesystem::path::root_directory() const shiny.x86_64: W: undefined-non-weak-symbol /usr/lib64/libshiny.so boost::filesystem::detail::directory_iterator_construct(boost::filesystem::directory_iterator&, boost::filesystem::path const&, boost::system::error_code*) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
