[Bug 1079745] Review Request: perl-Excel-Template - Create Excel files from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1079745 Ralf Corsepius rc040...@freenet.de changed: What|Removed |Added Flags||fedora-review? --- Comment #9 from Ralf Corsepius rc040...@freenet.de --- (In reply to Sven Nierlein from comment #8) Ok, now i understand. I've corrected this. Updated src.rpm, please. There is one Requires: perl(Test::More) left which i am unsure about. You need to distinguish run-time requirements (Requires:) from build-time requirements. In almost all cases, Test::More is a build-time-only requirement, which is required to exercise a perl module's tests (commonly found under t/ in a source-tree), but is not required at run-time (commonly found under lib/ in a source-tree). FYI: Unlike other reviewers I do not provide you with spec-patches for didactical reasons, because I want you to understand what you are doing and do not want you blindly copy and paste others' works. Sorry, if this feels inconvenient to you. I am doing so for your own sake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062542] Review Request: libdatrie - Implementation of Double-Array structure for representing trie
https://bugzilla.redhat.com/show_bug.cgi?id=1062542
Ralf Corsepius rc040...@freenet.de changed:
What|Removed |Added
CC||rc040...@freenet.de
--- Comment #11 from Ralf Corsepius rc040...@freenet.de ---
I hate packages, which install docs into a different directory but
/usr/share/doc/package. These days, there isn't any reason for not doing so.
All you need to do is to install these docs just like normal files and to
reference them as normal files.
This basically boils donw to not use %doc relative path in %files but to use
%{_pkgdocdir}/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101409] New: Review Request: perl-CGI-Fast - CGI Interface for Fast CGI
https://bugzilla.redhat.com/show_bug.cgi?id=1101409 Bug ID: 1101409 Summary: Review Request: perl-CGI-Fast - CGI Interface for Fast CGI Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jples...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://jplesnik.fedorapeople.org/perl-CGI-Fast/perl-CGI-Fast.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-CGI-Fast/perl-CGI-Fast-2.00-1.fc21.src.rpm Description: CGI::Fast is a subclass of the CGI object created by CGI.pm. It is specialized to work well FCGI module, which greatly speeds up CGI scripts by turning them into persistently running server processes. Scripts that perform time-consuming initialization processes, such as loading large modules or opening persistent database connections, will see large performance improvements. Fedora Account System Username: jplesnik -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096206] Review Request: python-click - A simple wrapper around optparse
https://bugzilla.redhat.com/show_bug.cgi?id=1096206 Robert Kuska rku...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Robert Kuska rku...@redhat.com --- New Package SCM Request === Package Name: python-click Short Description: A simple wrapper around optparse Upstream URL: https://github.com/mitsuhiko/click Owners: rkuska Branches: f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101409] Review Request: perl-CGI-Fast - CGI Interface for Fast CGI
https://bugzilla.redhat.com/show_bug.cgi?id=1101409 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096704] Review Request: python-bintrees - Binary-, RedBlack- and AVL-Trees in Python and Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1096704 --- Comment #3 from Robert Kuska rku...@redhat.com --- I have updated the specfile and srpmfile. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097733] Review Request: python-rply - Pure Python parser generator
https://bugzilla.redhat.com/show_bug.cgi?id=1097733 --- Comment #2 from Robert Kuska rku...@redhat.com --- You run tests but there are none in Source0. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- 1) License should be LGPLv2+ and BSD 2) Wrong source url, kjs is in http://download.kde.org/unstable/frameworks/4.99.0/portingAids/ 3) Shouldn't be create_hash_table script executable? Rpmlint says: E: non-executable-script /usr/share/kf5/kjs/create_hash_table 0644L /usr/bin/perl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094345] Review Request: kf5-kplotting - KDE Frameworks 5 Tier 1 addon for plotting
https://bugzilla.redhat.com/show_bug.cgi?id=1094345 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Good to go, please fix these small issues before import. 1) License should be GPLv2+ and LGPLv2+ 2) Wrong version the last entry in %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094352] Review Request: kf5-threadweaver - KDE Frameworks 5 Tier 1 addon for advanced thread management
https://bugzilla.redhat.com/show_bug.cgi?id=1094352 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Good to go, please fix these small issues before import. 1) License should be GPLv2+ and LGPLv2+ 2) Wrong version in the last entry in %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Good to go, please fix these small issues before import. 1) License should be GPLv2+ and LGPLv2+ 2) Wrong version in the last entry in %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Good to go, please fix these small issues before import. 1) License should be LGPLv2+ 2) Wrong version the last entry in %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079745] Review Request: perl-Excel-Template - Create Excel files from templates
https://bugzilla.redhat.com/show_bug.cgi?id=1079745 --- Comment #10 from Sven Nierlein sven.nierl...@consol.de --- thanks, i am not expecting a patch file and i am familiar with perl modules, i was just wondering how to deal with such situations when there is a useless requirement in the Makefile.PL. The Makefile.PL contains: test_requires 'Test::More' = '0.47'; requires 'Test::More' = 0; Test::More is only used for tests below t/. Would we still add Test::More as runtime requirement because the Makefile.PL says so? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 --- Comment #2 from Jan Grulich jgrul...@redhat.com --- 1) License should be GPLv2+ and MIT -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 --- Comment #3 from Jan Grulich jgrul...@redhat.com --- Sorry, it's LGPLv2+ instead of GPLv2+ and MIT. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 --- Comment #2 from Dan Vrátil dvra...@redhat.com --- Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kjs-4.99.0-3.fc20.src.rpm - Fixed license - Fixed changelog - Fixed source URL - chmod +x create_hash_table -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094345] Review Request: kf5-kplotting - KDE Frameworks 5 Tier 1 addon for plotting
https://bugzilla.redhat.com/show_bug.cgi?id=1094345 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-kplotting Short Description: KDE Frameworks 5 Tier 1 addon for plotting Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-kwindowsystem Short Description: KDE Frameworks 5 Tier 1 integration module with classes for windows management Upstream URL: http://www.kde.org Owners: dvratil rdieter jgrulich kkofler ltinkl Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-kwidgetsaddons Short Description: KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Grulich jgrul...@redhat.com --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-kjs Short Description: KDE Frameworks 5 Tier 1 functional module with JavaScript interpret Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-solid Short Description: KDE Frameworks 5 Tier 1 integration module that provides hardware information Upstream URL: http://www.kde.org Owners: dvratil ltinkl jgrulich rdieter kkofler Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- 1) License should be LGPLv2+ 2) Missing call of ldconfig for subpackages 3) Wrong version in the last entry in changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 --- Comment #2 from Jan Grulich jgrul...@redhat.com --- 2) Also you don't need to call ldconfig for main package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094352] Review Request: kf5-threadweaver - KDE Frameworks 5 Tier 1 addon for advanced thread management
https://bugzilla.redhat.com/show_bug.cgi?id=1094352 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Good to go, please fix these small issues before import. 1) License should be LGPLv2+ 2) Wrong version in the last entry in %changelog -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 --- Comment #3 from Dan Vrátil dvra...@redhat.com --- Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-sonnet.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-sonnet-4.99.0-3.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Jan Grulich jgrul...@redhat.com --- Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094352] Review Request: kf5-threadweaver - KDE Frameworks 5 Tier 1 addon for advanced thread management
https://bugzilla.redhat.com/show_bug.cgi?id=1094352 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-threadweaver Short Description: KDE Frameworks 5 Tier 1 addon for advanced thread management Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-sonnet Short Description: KDE Frameworks 5 Tier 1 solution for spell checking Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1098097 David Dick dd...@cpan.org changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from David Dick dd...@cpan.org --- Done. Thanks Petr! New Package SCM Request === Package Name: perl-Crypt-PBKDF2 Short Description: PBKDF2 password hashing algorithm Owners: ddick Branches: f20 el6 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925
--- Comment #2 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
Source: http://downloads.sourceforge.net/libwpd/%{name}-%{version}.tar.xz
use Source0 instead of Source.
%autosetup -p1
use %setup -q and %patch0 -p1, %patch1 -p1
make install DESTDIR=%{buildroot}
you could use %make_install instead, but that's not should item.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925 Igor Gnatenko i.gnatenko.br...@gmail.com changed: What|Removed |Added Flags||fedora-review? --- Comment #3 from Igor Gnatenko i.gnatenko.br...@gmail.com --- You should do some work ;) Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: === - Package contains BR: python2-devel or python3-devel - I don't know what happens.. - librevenge.x86_64: W: unused-direct-shlib-dependency /usr/lib64/librevenge-generators-0.0.so.0.0.0 /lib64/libm.so.6 - See: http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency - GPL (v3 or later) - - - librevenge-0.0.0/data/gdb/auto-load/librevenge-0.0.py - librevenge-0.0.0/data/gdb/auto-load/librevenge-stream-0.0.py - I think you forget to add this license to list. Probably you should replace LGPLv2+ with GPLv3+ or something - Patches link to upstream bugs/comments/lists or are otherwise justified. - there no links. could you provide it ? If no - sent to upstream. NOT BLOCKER. - Packages should try to preserve timestamps of original installed files. - I think you could patch it. there need '-p' for `install` command. NOT BLOCKER. - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gdb - I think for -devel subpackage should be Requires: libstdc++ - Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gdb/auto- load/usr(libstdc++), /usr/share/gdb/auto-load(libstdc++, gdb), /usr/share/gdb/auto-load/usr/lib64(libstdc++) - do not own this dirs. it will be owned by libstdc++. own only files in this directories = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: GPL (v2 or later), GPL (v3 or later), Unknown or generated, *No copyright* MPL (v2.0), BSD (3 clause), MPL (v2.0). 2 files have unknown license. Detailed output of licensecheck in /home/brain/1100925-librevenge/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gdb [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gdb/auto- load/usr(libstdc++), /usr/share/gdb/auto-load(libstdc++, gdb), /usr/share/gdb/auto-load/usr/lib64(libstdc++) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [?]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 266240 bytes in 5 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925
--- Comment #4 from David Tardon dtar...@redhat.com ---
(In reply to Igor Gnatenko from comment #2)
Source: http://downloads.sourceforge.net/libwpd/%{name}-%{version}.tar.xz
use Source0 instead of Source.
Why? 19 of my 30 packages (not all of them created by myself) use just Source
and nobody has ever complained to me.
%autosetup -p1
use %setup -q and %patch0 -p1, %patch1 -p1
No. There is no chance this is ever going to be backported to EPEL-6.
make install DESTDIR=%{buildroot}
you could use %make_install instead, but that's not should item.
I am pretty sure that the use of %make_install is prohibited in Fedora.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101409] Review Request: perl-CGI-Fast - CGI Interface for Fast CGI
https://bugzilla.redhat.com/show_bug.cgi?id=1101409 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata psab...@redhat.com --- NOTE: The README file refers to an 'examples' directory which isn't present in the distribution. Perhaps you should let upstream know. No real issues. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] New: Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 Bug ID: 1101521 Summary: Review Request: geomorph - A height field editor for Linux Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: didier.fab...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph.spec SRPM URL: https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph-0.60.1-1.fc20.src.rpm Description: Geomorph is a height field generator and editor for the Linux operating system. A height field is a kind of topographic map. It is a 2D projection of a 3D landscape. Geomorph generates square images and shows a 3D preview of the resulting landscape. The resulting 2D image can be processed with a tool like Povray for rendering the landscape. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101409] Review Request: perl-CGI-Fast - CGI Interface for Fast CGI
https://bugzilla.redhat.com/show_bug.cgi?id=1101409 Jitka Plesnikova jples...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jitka Plesnikova jples...@redhat.com --- New Package SCM Request === Package Name: perl-CGI-Fast Short Description: CGI Interface for Fast CGI Upstream URL: http://search.cpan.org/dist/CGI-Fast/ Owners: jplesnik ppisar psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925 --- Comment #5 from David Tardon dtar...@redhat.com --- (In reply to Igor Gnatenko from comment #3) - Package contains BR: python2-devel or python3-devel - I don't know what happens.. Nonsense. There is no such BR. - librevenge.x86_64: W: unused-direct-shlib-dependency /usr/lib64/librevenge-generators-0.0.so.0.0.0 /lib64/libm.so.6 - See: http://fedoraproject.org/wiki/Common_Rpmlint_issues#unused-direct-shlib-dependency readelf -d review-librevenge/rpms-unpacked/librevenge-0.0.0-1.fc20.x86_64.rpm/usr/lib64/librevenge-0.0.so.0 | grep NEEDED 0x0001 (NEEDED) Shared library: [libstdc++.so.6] 0x0001 (NEEDED) Shared library: [libm.so.6] 0x0001 (NEEDED) Shared library: [libc.so.6] 0x0001 (NEEDED) Shared library: [libgcc_s.so.1] I do not see any explicit dependency on librevenge-generators... And I do not see libm.so.6 as a problem, as libstdc++.so.6 already needs it anyway. - GPL (v3 or later) - - - librevenge-0.0.0/data/gdb/auto-load/librevenge-0.0.py - librevenge-0.0.0/data/gdb/auto-load/librevenge-stream-0.0.py - I think you forget to add this license to list. Probably you should replace LGPLv2+ with GPLv3+ or something This is apparently checked on unpatched tarball. Patch1 changes these licenses to MPLv2.0/LGPLv2+. (I adapted the pretty printers code from another project of mine and forgot to change the licenses originally.) - Patches link to upstream bugs/comments/lists or are otherwise justified. - there no links. could you provide it ? If no - sent to upstream. NOT BLOCKER. These patches come from upstream. - Packages should try to preserve timestamps of original installed files. - I think you could patch it. there need '-p' for `install` command. NOT BLOCKER. I do not call install manually anywhere... - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gdb libstdc++ owns this on my system. - I think for -devel subpackage should be Requires: libstdc++ libstdc++ is already required through librevenge. - Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/gdb/auto- load/usr(libstdc++), /usr/share/gdb/auto-load(libstdc++, gdb), /usr/share/gdb/auto-load/usr/lib64(libstdc++) - do not own this dirs. it will be owned by libstdc++. own only files in this directories All right, removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925 --- Comment #6 from David Tardon dtar...@redhat.com --- Spec URL: http://dtardon.fedorapeople.org/rpm/librevenge.spec SRPM URL: http://dtardon.fedorapeople.org/rpm/librevenge-0.0.0-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100925] Review Request: librevenge - a base library for writing document import filters
https://bugzilla.redhat.com/show_bug.cgi?id=1100925 --- Comment #7 from David Tardon dtar...@redhat.com --- (In reply to David Tardon from comment #5) (In reply to Igor Gnatenko from comment #3) - librevenge.x86_64: W: unused-direct-shlib-dependency /usr/lib64/librevenge-generators-0.0.so.0.0.0 /lib64/libm.so.6 Or does this mean that librevenge-generators-0.0.so.0.0.0 needs on libm.so.6, even though it does not use it? If so, then I can only repeat that libm.so.6 is already needed by libstdc++.so.6, so I do not see this as a problem. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 217484] Review Request: rlwrap - Wrapper for GNU readline
https://bugzilla.redhat.com/show_bug.cgi?id=217484 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 459125] Review Request: freecad - A general purpose 3D CAD modeler
https://bugzilla.redhat.com/show_bug.cgi?id=459125 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 460615] Review Request: bti - Bash Twitter Idiocy
https://bugzilla.redhat.com/show_bug.cgi?id=460615 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 459125] Review Request: freecad - A general purpose 3D CAD modeler
https://bugzilla.redhat.com/show_bug.cgi?id=459125 --- Comment #29 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 460615] Review Request: bti - Bash Twitter Idiocy
https://bugzilla.redhat.com/show_bug.cgi?id=460615 --- Comment #14 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 468189] Review Request: rear - Relax and Recovery (disaster recovery framework)
https://bugzilla.redhat.com/show_bug.cgi?id=468189 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 468189] Review Request: rear - Relax and Recovery (disaster recovery framework)
https://bugzilla.redhat.com/show_bug.cgi?id=468189 --- Comment #60 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631874] Review Request: liboauth - OAuth library functions
https://bugzilla.redhat.com/show_bug.cgi?id=631874 --- Comment #17 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 631874] Review Request: liboauth - OAuth library functions
https://bugzilla.redhat.com/show_bug.cgi?id=631874 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 --- Comment #20 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 875506] Review Request: python-fdb - Firebird RDBMS bindings for Python
https://bugzilla.redhat.com/show_bug.cgi?id=875506 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046995] Review Request: rubygem-escape_utils - Faster string escaping routines for your web apps
https://bugzilla.redhat.com/show_bug.cgi?id=1046995 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046995] Review Request: rubygem-escape_utils - Faster string escaping routines for your web apps
https://bugzilla.redhat.com/show_bug.cgi?id=1046995 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070702] Review Request: lmdb - memory-mapped key-value database
https://bugzilla.redhat.com/show_bug.cgi?id=1070702 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070702] Review Request: lmdb - memory-mapped key-value database
https://bugzilla.redhat.com/show_bug.cgi?id=1070702 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079718] Review Request: perl-Catalyst-Plugin-Compress - Compress Catalyst response
https://bugzilla.redhat.com/show_bug.cgi?id=1079718 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079718] Review Request: perl-Catalyst-Plugin-Compress - Compress Catalyst response
https://bugzilla.redhat.com/show_bug.cgi?id=1079718 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message
https://bugzilla.redhat.com/show_bug.cgi?id=1079732 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079732] Review Request: perl-Catalyst-Plugin-CustomErrorMessage - Catalyst plugin to have more cute error message
https://bugzilla.redhat.com/show_bug.cgi?id=1079732 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079749] Review Request: perl-Test-Image-GD - A module for testing images using GD
https://bugzilla.redhat.com/show_bug.cgi?id=1079749 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 --- Comment #36 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094337] Review Request: kf5-kidletime - KDE Frameworks 5 Tier 1 integration module for idle time detection
https://bugzilla.redhat.com/show_bug.cgi?id=1094337 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094337] Review Request: kf5-kidletime - KDE Frameworks 5 Tier 1 integration module for idle time detection
https://bugzilla.redhat.com/show_bug.cgi?id=1094337 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|NEW |ASSIGNED CC||lkund...@v3.sk QA Contact|extras...@fedoraproject.org |lkund...@v3.sk Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094341] Review Request: kf5-kimageformats - KDE Frameworks 5 Tier 1 addon with additional image plugins for QtGui
https://bugzilla.redhat.com/show_bug.cgi?id=1094341 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094341] Review Request: kf5-kimageformats - KDE Frameworks 5 Tier 1 addon with additional image plugins for QtGui
https://bugzilla.redhat.com/show_bug.cgi?id=1094341 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094342] Review Request: kf5-kitemmodels - KDE Frameworks 5 Tier 1 addon with item models
https://bugzilla.redhat.com/show_bug.cgi?id=1094342 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094342] Review Request: kf5-kitemmodels - KDE Frameworks 5 Tier 1 addon with item models
https://bugzilla.redhat.com/show_bug.cgi?id=1094342 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521
--- Comment #1 from Lubomir Rintel lkund...@v3.sk ---
1.) %define major_ver 0.60
You want to use %global here instead. (See
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define)
2.) You can drop old RPM artifacts
These are not necessary anymore:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(on top of %install:)
%{__rm} -rf %{buildroot}
(whole %clean scriptlet)
%clean
rm -rf $RPM_BUILD_ROOT
%defattr(-,root,root,-)
3.) Extra dependencies
[lkundrak@odvarok SPECS]$ rpm -qp --requires
/home/lkundrak/rpmbuild/RPMS/x86_64/geomorph-0.60.1-1.fc20.x86_64.rpm |grep
gtkglext
gtkglext-libs
libgtkglext-x11-1.0.so.0()(64bit)
AutoReq generator creats proper library dependence, you should not require
gtkglext-libs explicitely.
The same applies to mesa-libGLU.
4.) Consistent use of macros:
Use either $RPM_BUILD_ROOT or %{buildroot}. Not both.
Also, you're using both make and %{__make}. The double underscore denotes
that it's an internal rpm macro -- I suggest you don't needlessly use it.
5.) Locale files dragged in manually:
%{_datadir}/locale/*/LC_MESSAGES/geomorph.mo
You should use %find_lang instead:
http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
6.) Please use desktop-file-install to copy the .desktop file
It will validate it's correct:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
7.) RPMLint unhappy.
Here's (apart from the things already mentioned above) what needs addressing:
geomorph.x86_64: E: arch-dependent-file-in-usr-share
/usr/share/geomorph/0.60.1/scenes/colmap
This package installs an ELF binary in the /usr/share hierarchy, which is
reserved for architecture-independent files.
It should go to %_bindir or be %excluded.
geomorph.x86_64: W: devel-file-in-non-devel-package
/usr/share/geomorph/0.60.1/scenes/colmap.c
A development file (usually source code) is located in a non-devel package. If
you want to include source code in your package, be sure to create a
development package.
Just drop this.
You may want to address the other warnings too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #2 from Lubomir Rintel lkund...@v3.sk --- Also, this won't build in f21 due to format-security bugs: http://kojipkgs.fedoraproject.org//work/tasks/5966/6895966/build.log See this: http://fedoraproject.org/wiki/Changes/FormatSecurity f20 build is successful. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094343] Review Request: kf5-kitemviews - KDE Frameworks 5 Tier 1 addon with item views
https://bugzilla.redhat.com/show_bug.cgi?id=1094343 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094343] Review Request: kf5-kitemviews - KDE Frameworks 5 Tier 1 addon with item views
https://bugzilla.redhat.com/show_bug.cgi?id=1094343 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) --- Comment #3 from Lubomir Rintel lkund...@v3.sk --- Adding FE_NEEDSPONSOR. I'm willing to sponsor the packager if he wishes. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094344] Review Request: kf5-kjs - KDE Frameworks 5 Tier 1 functional module with JavaScript interpret
https://bugzilla.redhat.com/show_bug.cgi?id=1094344 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094345] Review Request: kf5-kplotting - KDE Frameworks 5 Tier 1 addon for plotting
https://bugzilla.redhat.com/show_bug.cgi?id=1094345 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094346] Review Request: kf5-kwidgetsaddons - KDE Frameworks 5 Tier 1 addon with various classes on top of QtWidgets
https://bugzilla.redhat.com/show_bug.cgi?id=1094346 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094345] Review Request: kf5-kplotting - KDE Frameworks 5 Tier 1 addon for plotting
https://bugzilla.redhat.com/show_bug.cgi?id=1094345 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094348] Review Request: kf5-kwindowsystem - KDE Frameworks 5 Tier 1 integration module with classes for windows management
https://bugzilla.redhat.com/show_bug.cgi?id=1094348 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094350] Review Request: kf5-solid - KDE Frameworks 5 Tier 1 integration module that provides hardware information
https://bugzilla.redhat.com/show_bug.cgi?id=1094350 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094351] Review Request: kf5-sonnet - KDE Frameworks 5 Tier 1 solution for spell checking
https://bugzilla.redhat.com/show_bug.cgi?id=1094351 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094352] Review Request: kf5-threadweaver - KDE Frameworks 5 Tier 1 addon for advanced thread management
https://bugzilla.redhat.com/show_bug.cgi?id=1094352 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096206] Review Request: python-click - A simple wrapper around optparse
https://bugzilla.redhat.com/show_bug.cgi?id=1096206 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1094352] Review Request: kf5-threadweaver - KDE Frameworks 5 Tier 1 addon for advanced thread management
https://bugzilla.redhat.com/show_bug.cgi?id=1094352 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096206] Review Request: python-click - A simple wrapper around optparse
https://bugzilla.redhat.com/show_bug.cgi?id=1096206 --- Comment #7 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1098097 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100461] Review Request: rubygem-minitest-stub-const - Stub constants for the duration of a block in MiniTest
https://bugzilla.redhat.com/show_bug.cgi?id=1100461 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100199] Review Request: drupal7-google_analytics - Adds the Google Analytics web statistics tracking system to your website
https://bugzilla.redhat.com/show_bug.cgi?id=1100199 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
