[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1058019



--- Comment #18 from Milan Bouchet-Valat  ---
Orion, would you do the review? Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100768] Review Request: rubygem-fog-core - Shared classes and tests for fog providers and services.

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100768
Bug 1100768 depends on bug 1100461, which changed state.

Bug 1100461 Summary: Review Request: rubygem-minitest-stub-const - Stub 
constants for the duration of a block in MiniTest
https://bugzilla.redhat.com/show_bug.cgi?id=1100461

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100461] Review Request: rubygem-minitest-stub-const - Stub constants for the duration of a block in MiniTest

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100461

Vít Ondruch  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
   Fixed In Version||rubygem-minitest-stub-const
   ||-0.1-1.fc21
 Resolution|--- |RAWHIDE
Last Closed||2014-05-28 04:08:29



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1095662] Review Request: perl-Sys-Detect-Virtualization - Detect if a UNIX system is running as a virtual machine

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1095662



--- Comment #10 from Fedora Update System  ---
perl-Sys-Detect-Virtualization-0.106-1.el6 has been submitted as an update for
Fedora EPEL 6.
https://admin.fedoraproject.org/updates/perl-Sys-Detect-Virtualization-0.106-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1086217] Review Request: nodejs-strip-json-comments - Strip comments from JSON

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1086217



--- Comment #4 from anish  ---
Hi Tom Hughes!

Thank you for package review and review comments, I have incorporated few the
comments please find new spec and SRPM file on


Spec URL: http://anishpatil.fedorapeople.org/nodejs-strip-json-comments.spec


SRPM URL:
http://anishpatil.fedorapeople.org/nodejs-strip-json-comments-0.1.2-3.fc20.src.rpm

I have created upstream bug for inclusion of
license,https://github.com/sindresorhus/strip-json-comments/issues/5

I have included test.js because test cases are broken that is why they have not
included in release, i have created bug for that as well

https://github.com/sindresorhus/strip-json-comments/issues/6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #5 from Didier  ---
(In reply to Lubomir Rintel from comment #3)
> Adding FE_NEEDSPONSOR.
> I'm willing to sponsor the packager if he wishes.

Yes I wish (Look's like a wedding...)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098097

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098097



--- Comment #7 from Fedora Update System  ---
perl-Crypt-PBKDF2-0.140890-1.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/perl-Crypt-PBKDF2-0.140890-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1086231] Review Request: nodejs-jsonparse - Pure-js JSON streaming parser for node.js

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1086231



--- Comment #4 from anish  ---
Thanks for review comments, please find new spec file and SRPM file 


SPEC file:-  http://anishpatil.fedorapeople.org/nodejs-jsonparse.spec

SRPM file :-
http://anishpatil.fedorapeople.org/nodejs-jsonparse-0.0.6-3.fc20.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098097



--- Comment #8 from Fedora Update System  ---
perl-Crypt-PBKDF2-0.140890-1.el6 has been submitted as an update for Fedora
EPEL 6.
https://admin.fedoraproject.org/updates/perl-Crypt-PBKDF2-0.140890-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 821917] Review Request: mu - maildir utility with Emacs support

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=821917

Ville Skyttä  changed:

   What|Removed |Added

 CC||ville.sky...@iki.fi



--- Comment #18 from Ville Skyttä  ---
(In reply to Christopher Meng from comment #14)
> And, will you continue packaging? If not I can take it.

Any news to report here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100899] Review Request: ratools - Framework for IPv6 Router Advertisements

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100899



--- Comment #6 from Björn "besser82" Esser  ---
Created attachment 899924
  --> https://bugzilla.redhat.com/attachment.cgi?id=899924&action=edit
fix Makefile for parallelized make-jobs

Package looks almost fine now.  =)


Just a few little things:

  * Please update to new upstream version 0.5.1 (as tagged in git) and
drop current `Patch0`, as this is fixed in the new release.

  * Have a look a my attached patch and apply it to the sources.  This
will fix parallelized make-jobs, so you can append `%{?_smp_mflags}`
again to the invocation of `make`.  The patch has already been
upstreamed by me as you can see in my pull-request [1].

  * You will need to add a blackslash '\' to the line which sets
{C,LD}FLAGS, like:
  `CFLAGS="%{?optflags}" LDFLAGS="%{?__global_ldflags}" \`
In other cases the flags are not properly injected into make's
default $ENV.

  * Setting `%config(noreplace)` for the bash-completion is a bad idea,
since this file is NOT config as meant to be customized by the user.
On newer versions of ratools there might be changes in CLI and the
bash-completion WILL change.  The `noreplace` is meant for cases when
you ship some default config to be customized by the user with the
package, so the customized config will NOT be overwritten on pkg-updates.
In this case this config must be replaced on updates for said reasons.
So please drop the `noreplace` and just use `%config` for this file.


Before I'm going to sponsor you into the package-group, I want to see some
*INFORMAL* package-reviews made by you.  You can find packages, which need a
review, over here [2].  Just pick 3 or 4 from that list and try to do a
fully-featured review, but without assigning the bug to you or raising the
fedora-review-flag in rhbz.

[1]  https://github.com/danrl/ratools/pull/2
[2]  http://fedoraproject.org/PackageReviewStatus/NEW.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #6 from Christopher Meng  ---
1. g++ colmap.c -o colmap

Use %{_cxx} instead of g++.

2. %{__install} %{SOURCE1} $RPM_BUILD_ROOT%{_datadir}/applications

Please read:

http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100899] Review Request: ratools - Framework for IPv6 Router Advertisements

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100899



--- Comment #7 from Christopher Meng  ---
Please use your real name instead of some alphbets like "flo" in bugzilla which
is a serious place exactly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 731191] Review Request: libspnav - Open source alternative to 3DConnextion drivers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=731191



--- Comment #18 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 731191] Review Request: libspnav - Open source alternative to 3DConnextion drivers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=731191

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 731519] Review Request: spacenavd - A free, compatible alternative for 3Dconnexion's input drivers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=731519



--- Comment #18 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 731519] Review Request: spacenavd - A free, compatible alternative for 3Dconnexion's input drivers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=731519

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835432] Review Request: python-pycxx - Write Python extensions in C++

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=835432



--- Comment #43 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 835432] Review Request: python-pycxx - Write Python extensions in C++

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=835432

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083344] Review Request: hub - A command-line wrapper for git with github shortcuts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1083344



--- Comment #10 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083344] Review Request: hub - A command-line wrapper for git with github shortcuts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1083344

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100925] Review Request: librevenge - a base library for writing document import filters

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100925



--- Comment #13 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100925] Review Request: librevenge - a base library for writing document import filters

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100925

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1090188] Review Request: rubygem-openscap - A FFI wrapper around the OpenSCAP library

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1090188



--- Comment #9 from Fedora Update System  ---
rubygem-openscap-0.1.0-5.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/rubygem-openscap-0.1.0-5.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #7 from Didier  ---
Created attachment 899943
  --> https://bugzilla.redhat.com/attachment.cgi?id=899943&action=edit
Spec file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812



--- Comment #25 from Fedora Update System  ---
gpaw-0.10.0.11364-3.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/gpaw-0.10.0.11364-3.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812



--- Comment #26 from Fedora Update System  ---
gpaw-0.10.0.11364-3.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/gpaw-0.10.0.11364-3.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812



--- Comment #27 from Fedora Update System  ---
gpaw-0.10.0.11364-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/gpaw-0.10.0.11364-3.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100899] Review Request: ratools - Framework for IPv6 Router Advertisements

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100899



--- Comment #8 from Björn "besser82" Esser  ---
(In reply to Christopher Meng from comment #7)
> Please use your real name instead of some alphbets like "flo" in bugzilla
> which is a serious place exactly.

And please make sure your email-address in rhbz is identical to the one used
for your FAS-account.  That is important for the privileges-management-system; 
otherwise privileges granted in FAS won't be applied correctly for rhbz.

Cheers,
  Björn

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1089409



--- Comment #5 from Mukundan Ragavan  ---
Sorry I could not get to this yesterday. A couple of quick questions before I
run fedora-review - 

Provides:   environment(modules)

Should this be versioned instead?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Ralf Corsepius  changed:

   What|Removed |Added

 CC||rc040...@freenet.de



--- Comment #8 from Ralf Corsepius  ---
(In reply to Christopher Meng from comment #6)
> 1. g++ colmap.c -o colmap
> 
> Use %{_cxx} instead of g++.

1. This is a c-program => you are supposed to use a c compiler.
2. The correct rpm-macro corresponding to "g++" would be %{__cxx}, not %{_cxx}.
3. Compilation needs to take into account $RPM_OPT_FLAGS

=> The spec should use something similar to this:
%{__cc} ${RPM_OPT_FLAGS} -o colmap colmap.c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063040] Review Request: rubygem-em-socksify - Transparent proxy support for any EventMachine protocol

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063040



--- Comment #18 from Mo Morsi  ---
(In reply to Ken Dreyer from comment #17)

> With the latest Ruby guidelines for Fedora 21, you will not need to
> explicitly declare Requires or Provides for your gem. Please use dist tags
> to wrap the Requires and Provides, like so:
> 
>   %if 0%{?fc19} || 0%{?fc20}
>   Requires: ruby(release)
>   Requires: rubygems
>   Requires: rubygem(eventmachine) >= 1.0.0.beta.4
>   %endif
> 

Am a little confused as to whether ruby(release) should or should not be
included, brought up the issue on the ruby sig mailing list:

https://lists.fedoraproject.org/pipermail/ruby-sig/2014-May/001588.html


> As a separate issue, please mark the %{gem_instdir}/README.md file as
> "%doc", since it is documentation, not code. (that one's confusing since
> it's already in a -doc subpackage...)

It was my understanding that files in the 'doc' subpackage didn't need to be
marked as %doc (since that is the whole intent of the subpackage). I could be
wrong on this, and know that it is ok to mark doc subpkg files as %doc, so am
fine either way.



> 
> Please make these changes and I'll approve the package and sponsor you (with
> the caveat that mmorsi will be your main mentor and responsible for your
> actions in Fedora going forward).
> 

Thanks Ken, yes I am fine w/ this. Nitesh I just ask that if you are unsure
about something, just ask me before committing / building. Most likely after a
while this will be unnecessary but at the beginning there are many
gotcha's/edge cases. Thanks again for the new package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063038



--- Comment #9 from Mo Morsi  ---
Went through this and compared it to the updated guidelines for rawhide

https://fedoraproject.org/w/index.php?title=PackagingDrafts%2FRuby

From what I see the only change that is needed is removing the automatic
requires. If you are just submitting this to rawhide you can remove the
following completely:

Requires: ruby(release)
Requires: rubygems

As well as

Provides: rubygem(%{gem_name}) = %{version}


If you plan on including this package in F19 & F20, you will need to add the
conditional around these, similar to here:

https://bugzilla.redhat.com/show_bug.cgi?id=1063040

Other than that the spec still looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063038] Review Request: rubygem-cookiejar - The Ruby CookieJar is a library to help manage client-side cookies in pure Ruby

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063038



--- Comment #10 from Mo Morsi  ---
Note, while I linked the draft guidelines, they have been approved and are just
pending the move over to the main ruby guidelines page on the Fedora wiki:

https://fedorahosted.org/fpc/ticket/409

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 459125] Review Request: freecad - A general purpose 3D CAD modeler

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=459125

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 458974] Review Request: OCE - OpenCASCADE Community Edition

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=458974

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1097368] Review Request: smesh - OpenCascade based MESH framework

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1097368

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 459125] Review Request: freecad - A general purpose 3D CAD modeler

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=459125



--- Comment #30 from Fedora Update System  ---
OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20 has been
submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 458974] Review Request: OCE - OpenCASCADE Community Edition

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=458974



--- Comment #54 from Fedora Update System  ---
OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20 has been
submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1097368] Review Request: smesh - OpenCascade based MESH framework

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1097368



--- Comment #23 from Fedora Update System  ---
OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20 has been
submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/OCE-0.15-3.fc20.1,smesh-5.1.2.2-10.svn55.fc20,freecad-0.13-6.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1089409



--- Comment #6 from Orion Poplawski  ---
Nope - see https://fedoraproject.org/wiki/Packaging:EnvironmentModules

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908088] Review Request: ascend - ASCEND modelling environment

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=908088



--- Comment #12 from Rex Dieter  ---
License: OK

Item 3 above not completely fixed, there's still one reference to 
%{python_sitearch}

8.  -libs subpkg MUST include ldconfig scriptlets (and now main pkg no longer
needs them)

9.  nothing depends on new -libs subpkg.  You probably want to add a dependency
to at least the main and -devel subpkgs:
Requires: %{name}-libs%{?_isa} = %{version}-%{release}

(and have -devel drop dep on main pkg).

While we're at it, make -libs, -data dep on main pkg *not* use %_isa (else you
lose the whole point of making a -libs subpkg to be multilib -friendly)

10.  nothing depends on -data subpkg, should main pkg depend on it?  Or is it
optional addon?

11. While on the topic of -libs, I'd recommend it *only* include the shared
library here, plus any essential resources the library may require.  Is there a
reason you added all that other stuff too?

12.  MUST omit extraneous python dep
Requires: python >= 2.4
https://fedoraproject.org/wiki/Packaging:Python#Multiple_Python_Runtimes
(it'll get an automatic dependency on python(abi) instead)

13. MUST omit gcc-c++ dependency,
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2

14. URL: http://ascend.cheme.cmu.edu/
seems inaccessible (at the moment?).  Googling found me http://ascend4.org/
too, but it's not working either.  Please verify which URL is correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 908088] Review Request: ascend - ASCEND modelling environment

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=908088

Rex Dieter  changed:

   What|Removed |Added

  Flags|needinfo?(rdie...@math.unl. |
   |edu)|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100925] Review Request: librevenge - a base library for writing document import filters

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100925

David Tardon  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-05-28 09:25:26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1102098] New: Review Request: lua-cyrussasl - Cyrus SASL library for Lua

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1102098

Bug ID: 1102098
   Summary: Review Request: lua-cyrussasl - Cyrus SASL library for
Lua
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: redhat-bugzi...@linuxnetz.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org,
robert.sch...@etes.de



Spec URL: http://labs.linuxnetz.de/bugzilla/lua-cyrussasl.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/lua-cyrussasl-1.0.0-1.src.rpm
Description:
Lua bindings for the Cyrus SASL APIs.


This package is intended for all branches including Fedora EPEL 5.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #9 from Didier  ---
Spec URL: https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph.spec

SRPM URL:
https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph-0.60.1-2.fc20.src.rpm

rpmlint report only 2 warnings about missing man page. Upstream don't provide
them.

Thanks for your help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1071456] Review Request: oozie - A work-flow scheduling system for Apache Hadoop

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1071456

Darryl L. Pierce  changed:

   What|Removed |Added

 CC||dpie...@redhat.com
   Assignee|nob...@fedoraproject.org|dpie...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081468] Review Request: perl-Term-ProgressBar-Simple - Simpler progress bars

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081468

Petr Šabata  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-05-28 09:39:32



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081465] Review Request: perl-Term-ProgressBar-Quiet - Provide a progress meter if run interactively

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081465

Petr Šabata  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2014-05-28 09:40:43



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081468] Review Request: perl-Term-ProgressBar-Simple - Simpler progress bars

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081468
Bug 1081468 depends on bug 1081465, which changed state.

Bug 1081465 Summary: Review Request: perl-Term-ProgressBar-Quiet - Provide a 
progress meter if run interactively
https://bugzilla.redhat.com/show_bug.cgi?id=1081465

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081447] Review Request: perl-IO-Interactive - Utilities for interactive I/O

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081447

Petr Šabata  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2014-05-28 09:45:08



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1081465] Review Request: perl-Term-ProgressBar-Quiet - Provide a progress meter if run interactively

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1081465
Bug 1081465 depends on bug 1081447, which changed state.

Bug 1081447 Summary: Review Request: perl-IO-Interactive - Utilities for 
interactive I/O
https://bugzilla.redhat.com/show_bug.cgi?id=1081447

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100768] Review Request: rubygem-fog-core - Shared classes and tests for fog providers and services.

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100768

Vít Ondruch  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
   Fixed In Version||rubygem-fog-core-1.22.0-1.f
   ||c21
 Resolution|--- |RAWHIDE
Last Closed||2014-05-28 09:48:04



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100795] Review Request: rubygem-fog-brightbox - Module for `fog` or standalone provider to use the Brightbox Cloud

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100795
Bug 1100795 depends on bug 1100768, which changed state.

Bug 1100768 Summary: Review Request: rubygem-fog-core - Shared classes and 
tests for fog providers and services.
https://bugzilla.redhat.com/show_bug.cgi?id=1100768

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100776] Review Request: rubygem-fog-json - JSON parsing for fog providers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100776
Bug 1100776 depends on bug 1100768, which changed state.

Bug 1100768 Summary: Review Request: rubygem-fog-core - Shared classes and 
tests for fog providers and services.
https://bugzilla.redhat.com/show_bug.cgi?id=1100768

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1051157] Review Request: mozjs24 - JavaScript interpreter and libraries

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1051157

Debarshi Ray  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #9 from Debarshi Ray  ---
mozjs24 is required for updating 0ad. See bug 1100875

Package Change Request
==
Package Name: mozjs24
New Branches: f20 f19
Owners: rishi
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1051157] Review Request: mozjs24 - JavaScript interpreter and libraries

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1051157

Debarshi Ray  changed:

   What|Removed |Added

 Blocks||1101618
 CC||paulo.cesar.pereira.de.andr
   ||a...@gmail.com



--- Comment #10 from Debarshi Ray  ---
*** Bug 1100875 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1101618
[Bug 1101618] 0.0.16-2 Latest Alpha Not In Fedora 20
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Lubomir Rintel  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Lubomir Rintel  ---
Seems reasonably good to me now. I see that you've added the format-security
patch; which is great.

I'm a bit concerned about amount of stuff done in %prep. I understand it's not
very easy to get rid of those, but you still might want to open a ticket
upstream (to fix their encodings & FSF address, etc.).

(By the way, your server seems to have SSL misconfigured:
$ curl https://didier.dnsdynamic.net/repository/fc20/geomorph/geomorph.spec
curl: (60) The certificate was signed using a signature algorithm that is
disabled because it is not secure.
More details here: http://curl.haxx.se/docs/sslcerts.html)

Also, there's two tiny issues that you should address before importing the
package:

1.) Adding --prefix to %configure is redundant; see 'rpm --eval %configure'

2.) You should take care not to modify timestamps of shared files when
converting their encodings: 'mv -f $file.utf8 $file' should be preceded by by
'touch -r $file $file.utf8'

I can't see that blocking the review though. Please proceed with
http://fedoraproject.org/wiki/Package_SCM_admin_requests

APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Lubomir Rintel  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|lkund...@v3.sk



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Lubomir Rintel  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 902086] Review request: Elasticsearch

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=902086

Lukas Zapletal  changed:

   What|Removed |Added

 CC||l...@redhat.com



--- Comment #18 from Lukas Zapletal  ---
Please go ahead, our team is interested as well. I will be writing SELinux
policy in the incoming months for it.
(https://bugzilla.redhat.com/show_bug.cgi?id=1102119)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101308] Review Request: drupal7-panels - The Panels module allows a site administrator to create customized layouts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101308

Jared Smith  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jared Smith  ---
Package is approved.  rpmlint complains about zero-length files, but
those are indeed needed by this module.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

= EXTRA items =

Generic:
[x]: Rpmlint is run on all installed packages.
 Note: There are rpmlint messages (see a

[Bug 1100901] Review Request: rpm-ostree-toolbox - Extra tools for rpm-ostree

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100901

Patrick Uiterwijk  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Patrick Uiterwijk  ---
Okay, thanks for fixing those.

Package has been


APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101764] Review Request: drupal7-devel - A suite of modules containing fun for module developers and themers

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101764

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com,
   ||peter.bo...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?
   ||needinfo?(peter.borsa@gmail
   ||.com)



--- Comment #1 from Jared Smith  ---
Package is *not* approved.  Please check the "Issues" section below.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s) in
  its own file, then that file, containing the text of the license(s) for the
  package is included in %doc.
  Note: Cannot find LICENSE in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- JQuery and Krumo are currently bundled, and should be split out into their
  own packages, using the Javascript Packaging guidelines at
  http://fedoraproject.org/wiki/Packaging:JavaScript

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 4 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Ven

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Volker Fröhlich  changed:

   What|Removed |Added

 CC||volke...@gmx.at



--- Comment #11 from Volker Fröhlich  ---
What do you think? Does it make sense to mention geomorph on the GIS special
interest page, or would you say it's more of an art and 3d design thing?

https://fedoraproject.org/wiki/GIS

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100901] Review Request: rpm-ostree-toolbox - Extra tools for rpm-ostree

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100901



--- Comment #6 from Colin Walters  ---
New Package SCM Request
===
Package Name: rpm-ostree-toolbox
Short Description: Extra tools for rpm-ostree
Upstream URL: https://github.com/cgwalters/rpm-ostree-toolbox
Owners: walters
Branches: epel7 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100901] Review Request: rpm-ostree-toolbox - Extra tools for rpm-ostree

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100901

Colin Walters  changed:

   What|Removed |Added

  Flags||fedora-cvs?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #12 from Ralf Corsepius  ---
(In reply to Lubomir Rintel from comment #10)
> Seems reasonably good to me now. I see that you've added the format-security
> patch; which is great.

I am quite concerned about the source code's quality. To me it looks like a ca.
10 years pld student's work, which has never been adjusted to modern Linux
demands nor seen actual keep-alive maintainance since then == Low quality and
unsafe code.

Openly said, I would not have approved this package because of the code
quality.

> I'm a bit concerned about amount of stuff done in %prep. I understand it's
> not very easy to get rid of those, but you still might want to open a ticket
> upstream (to fix their encodings & FSF address, etc.).

You can simply ignore these FSF address warnings. Addressing these are upstream
busyness, but otherwise are of not of any importance to Fedora. The fact
rpmlint is complaining about these is an rpmlint sillyness.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 709328] Review Request: psi-plus - Jabber client based on Qt

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=709328

Rex Dieter  changed:

   What|Removed |Added

  Flags||needinfo?(dr...@land.ru)



--- Comment #89 from Rex Dieter  ---
ok, jdns is unbundled, please update psi-plus.spec to use it, and we can
continue/finish the review.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101030] Review Request: drupal7-xmlsitemap - The XML sitemap module creates a sitemap

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101030

Peter Borsa  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Peter Borsa  ---
New Package SCM Request
===
Package Name: drupal7-xmlsitemap
Short Description: The XML sitemap module creates a sitemap
Upstream URL: https://drupal.org/project/xmlsitemap
Owners: asrob jsmith siwinski
Branches: f20 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100973] Review Request: drupal7-honeypot - Honeypot uses both the honeypot and timestamp methods of deterring spam bots

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100973

Peter Borsa  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Peter Borsa  ---
New Package SCM Request
===
Package Name: drupal7-honeypot
Short Description: Honeypot uses both the honeypot and timestamp methods of
deterring spam bots
Upstream URL: https://drupal.org/project/honeypot
Owners: asrob jsmith siwinski
Branches: f20 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1051157] Review Request: mozjs24 - JavaScript interpreter and libraries

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1051157



--- Comment #11 from adam.saund...@hushmail.com ---
As Debarshi has mentioned, the latest release of the game 0ad depends on
mozjs24. Any chance that this bug could be reopened for packaging mozjs24 for
Fedora 20? With Fedora 21 still several months away, I fear that Fedora may
stay behind on 0ad developments. 

The next 0ad alpha release, which could very well happen a few weeks after
Fedora 21 goes stable, might then require a newer versions of mozjs. This could
lead us back to the same unfortunate situation.

Thank you very much for any efforts that could be made on this issue.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101308] Review Request: drupal7-panels - The Panels module allows a site administrator to create customized layouts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101308

Peter Borsa  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Peter Borsa  ---
New Package SCM Request
===
Package Name: drupal7-panels
Short Description: The Panels module allows a site administrator to create
customized layouts
Upstream URL: http://drupal.org/project/panels
Owners: asrob jsmith siwinski
Branches: f20 el6 epel7
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #13 from Lubomir Rintel  ---
(In reply to Ralf Corsepius from comment #12)
> (In reply to Lubomir Rintel from comment #10)
> > Seems reasonably good to me now. I see that you've added the format-security
> > patch; which is great.
> 
> I am quite concerned about the source code's quality. To me it looks like a
> ca. 10 years pld student's work, which has never been adjusted to modern
> Linux demands nor seen actual keep-alive maintainance since then == Low
> quality and unsafe code.

Well, it's not exactly a secret that as far as it goes for academic/scientific
software, code quality is often not vast and authors tend not to keep up with
toolchain developments (I just updated siril today...).

That said, this is solemnly packager's responsibility. If he's able to cope
with the issues (and it seems to me he is) and the package serves its purpose
(would it be submitted for the review if it didn't?) it's good to go.

> Openly said, I would not have approved this package because of the code
> quality.

Thanks for sharing your attitude, but this would be just you making up
guidelines. I'm positive that if someone challenged your decision given the
relevance of your reasoning it would be overturned.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1051157] Review Request: mozjs24 - JavaScript interpreter and libraries

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1051157

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1051157] Review Request: mozjs24 - JavaScript interpreter and libraries

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1051157



--- Comment #12 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100901] Review Request: rpm-ostree-toolbox - Extra tools for rpm-ostree

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100901



--- Comment #7 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100901] Review Request: rpm-ostree-toolbox - Extra tools for rpm-ostree

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100901

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521



--- Comment #14 from Didier  ---
(In reply to Volker Fröhlich from comment #11)
> What do you think? Does it make sense to mention geomorph on the GIS special
> interest page, or would you say it's more of an art and 3d design thing?
> 
> https://fedoraproject.org/wiki/GIS

In my opinion, it's not a GIS tool, because the primary goal of this app is to
create from scratch a pixmap which can be used to generate landscape with 3d
tool like povray and co. Landscapes are realistic but not real.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100973] Review Request: drupal7-honeypot - Honeypot uses both the honeypot and timestamp methods of deterring spam bots

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100973

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100973] Review Request: drupal7-honeypot - Honeypot uses both the honeypot and timestamp methods of deterring spam bots

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100973



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101030] Review Request: drupal7-xmlsitemap - The XML sitemap module creates a sitemap

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101030

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101030] Review Request: drupal7-xmlsitemap - The XML sitemap module creates a sitemap

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101030



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101308] Review Request: drupal7-panels - The Panels module allows a site administrator to create customized layouts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101308

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101308] Review Request: drupal7-panels - The Panels module allows a site administrator to create customized layouts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101308



--- Comment #3 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100873] Review Request: drupal7-views_slideshow - Views Slideshow can be used to create a slideshow of any content

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100873



--- Comment #7 from Fedora Update System  ---
drupal7-views_slideshow-3.1-1.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/drupal7-views_slideshow-3.1-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100873] Review Request: drupal7-views_slideshow - Views Slideshow can be used to create a slideshow of any content

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100873

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100873] Review Request: drupal7-views_slideshow - Views Slideshow can be used to create a slideshow of any content

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100873



--- Comment #8 from Fedora Update System  ---
drupal7-views_slideshow-3.1-1.el6 has been submitted as an update for Fedora
EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-views_slideshow-3.1-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1058019

Orion Poplawski  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #19 from Orion Poplawski  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown
 license. Detailed output of licensecheck in
 /export/home/orion/redhat/utf8proc-1.1.6/1058019-utf8proc/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is prese

[Bug 1100199] Review Request: drupal7-google_analytics - Adds the Google Analytics web statistics tracking system to your website

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100199



--- Comment #5 from Fedora Update System  ---
drupal7-google_analytics-1.4-1.fc20 has been submitted as an update for Fedora
20.
https://admin.fedoraproject.org/updates/drupal7-google_analytics-1.4-1.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100899] Review Request: ratools - Framework for IPv6 Router Advertisements

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100899

Björn "besser82" Esser  changed:

   What|Removed |Added

 Attachment #899924|0   |1
is obsolete||



--- Comment #9 from Björn "besser82" Esser  ---
Created attachment 900078
  --> https://bugzilla.redhat.com/attachment.cgi?id=900078&action=edit
fix Makefile for parallelized make-jobs

I reworked my patch a bit to fix one corner-case fail…

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1100199] Review Request: drupal7-google_analytics - Adds the Google Analytics web statistics tracking system to your website

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1100199



--- Comment #6 from Fedora Update System  ---
drupal7-google_analytics-1.4-1.el6 has been submitted as an update for Fedora
EPEL 6.
https://admin.fedoraproject.org/updates/drupal7-google_analytics-1.4-1.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1098625] Review Request: php-pear-text-wiki - Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098625

Pavel Alexeev (aka Pahan-Hubbitus)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus)  ---
Great.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1101521] Review Request: geomorph - A height field editor for Linux

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1101521

Didier  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #15 from Didier  ---
New Package SCM Request
===
Package Name: geomorph
Short Description: A height field editor for Linux
Upstream URL: http://geomorph.sourceforge.net
Owners: tartare
Branches: f19 f20
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1102297] New: Review Request: drupal7-module_filter - Module filter gives the ability to quickly find the module

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1102297

Bug ID: 1102297
   Summary: Review Request: drupal7-module_filter - Module filter
gives the ability to quickly find the module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: peter.bo...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-module_filter.spec
SRPM URL:
http://asrob.fedorapeople.org/SOURCES/drupal7-module_filter-2.0-0.1.alpha2.fc21.src.rpm
Description: The modules list page can become quite big when dealing with a
fairly large site or even just a dev site meant for testing new and various
modules being considered. What this module aims to accomplish is the ability to
quickly find the module you are looking for without having to rely on the
browsers search feature which more times than not shows you the module name in
the 'Required by' or 'Depends on' sections of the various modules or even some
other location on the page like a menu item.
Fedora Account System Username: asrob

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1098097] Review Request: perl-Crypt-PBKDF2 - PBKDF2 password hashing algorithm

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1098097

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
perl-Crypt-PBKDF2-0.140890-1.el6 has been pushed to the Fedora EPEL 6 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1087812] Review Request: gpaw - A grid-based real-space PAW method DFT code

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1087812

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #28 from Fedora Update System  ---
gpaw-0.10.0.11364-3.el6 has been pushed to the Fedora EPEL 6 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1083344] Review Request: hub - A command-line wrapper for git with github shortcuts

2014-05-28 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1083344

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >