[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #19 from Lubomir Rintel lkund...@v3.sk --- (In reply to Ralf Corsepius from comment #17) (In reply to Lubomir Rintel from comment #13) (In reply to Ralf Corsepius from comment #12) (In reply to Lubomir Rintel from comment #10) That said, this is solemnly packager's responsibility. No. One of the basic prerequisites of a package to be packaged for Fedora is function. It's one of the core purposes of a review to asure this. If he's able to cope with the issues (and it seems to me he is) I can't judge - The packager is a new-comer. He may-be, he may-be not. That's fine, noone expects you to judge anyone, especially in a packaging review ticket. Apart from that, the packager was quick to address the format string issue once the need to do so arose. (would it be submitted for the review if it didn't?) We have seen a lot of low qualtity junk going into Fedora, just because somebody wanted it, because a reviewer and a submitter were playing review ping-pong, or because reviewers were working carelessly. Well, in this case the packager was already maintaining a public repository of the packages he's importing. I'm assuming it had a purpose. Luckily I, as well as you, don't have to do arbitrary decisions based upon wild guesses. Openly said, I would not have approved this package because of the code quality. Thanks for sharing your attitude, but this would be just you making up guidelines. I'm positive that if someone challenged your decision given the relevance of your reasoning it would be overturned. OK, you leave me no joice but to file bugs against this package. As I was in a position to give you choices. You're always more than welcome to file tickets about issues you encounter. I strongly suggest that you care about quality of the bug reports and only report and demonstrate actual malfunctions -- not merely reporting potential issues from compiler warnings. (In reply to Ralf Corsepius from comment #18) FYI: All these warnings are serious and likely to be causing malfunctions: As far as my C knowledge goes, they might be not be serious and might not cause malfunctions. I haven't inspected the code. Note that I'm not advocating writing shitty code or encouraging anyone to ignore the warnings. I'm merely implying you're bringing too much drama into the play. That said, you're very welcome to inspect the code, decide upon actual impact and report bugs. Please don't jump into premature judgements from the presence of warnings themselves! utils.c:409:191: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] menus_n_tools.c:44:55: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] menus_n_tools.c:110:85: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] If nothing uses the full integer range, an actual issue might not be hit. x_alloc.c:256:5: warning: suggest explicit braces to avoid ambiguous 'else' [-Wparentheses] Are you serious? This is a style issue, not necessarily an actual bug. gl_preview.c:1040:4: warning: too many arguments for format [-Wformat-extra-args] Well, an extra value pushed to stack. If it's the last one, noone is going to notice. render.c:122:4: warning: format '%d' expects argument of type 'int', but argument 3 has type 'long int' [-Wformat=] render.c:122:4: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long int' [-Wformat=] render.c:201:3: warning: pointer targets in passing argument 3 of 'write_png' differ in signedness [-Wpointer-sign] Again, if the full range is not used, noone will encounter issues with these. hf_dialog_options.c:47:4: warning: format '%d' expects argument of type 'int', but argument 2 has type 'struct GtkWidget *' [-Wformat=] hf_dialog_options.c:49:3: warning: format '%d' expects argument of type 'int', but argument 2 has type 'struct GtkWidget *' [-Wformat=] Well, a bit weird to represent a pointer in decimal; but wouldn't it be weird to communicate an address to the user in the first place? main.c:113:6: warning: too many arguments for format [-Wformat-extra-args] Again, extra stack value. Weird, but potentially no biggie. stack.c:33:34: warning: assignment from incompatible pointer type thisappinit.c:78:2: warning: initialization from incompatible pointer type thisappinit.c:78:2: warning: (near initialization for 'doc_type_list[0].defaults') thisappinit.c:83:2: warning: initialization from incompatible pointer type thisappinit.c:83:2: warning: (near initialization for 'doc_type_list[0].set_creation_container') You can cast pointer types back and forth via incompatible one and noone will notice any issue. thisappinit.c:663:15: warning: array subscript is above array bounds [-Warray-bounds] This is the only one that it is really hard to excuse. It might be that it's not exploitable and leads to
[Bug 1060924] Review Request: rubygem-unicode - Unicode normalization library for Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1060924 --- Comment #2 from Dan Callaghan dcall...@redhat.com --- Hmm Rubygem packaging might have moved on since I posted this. I will take a look and fix it up. Thanks for taking the review, Ken. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #20 from Lubomir Rintel lkund...@v3.sk --- (In reply to Ralf Corsepius from comment #17) (In reply to Lubomir Rintel from comment #13) (In reply to Ralf Corsepius from comment #12) (In reply to Lubomir Rintel from comment #10) That said, this is solemnly packager's responsibility. No. One of the basic prerequisites of a package to be packaged for Fedora is function. It's one of the core purposes of a review to asure this. Worry not, Ralf, it functions! I've tried it; see my review input above. If you're able to make it do funny things with carefully crafted input does not change the fact. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315 --- Comment #36 from Michael Schwendt bugs.mich...@gmx.net --- Issues: === - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages Unversioned so-files nuvolaplayer: /usr/lib64/libnuvolaplayerprivate.so nuvolaplayer: /usr/lib64/nuvolaplayer/libnuvolaplayerprivate.so Careful reviewing needed here. The DevelPackages guidelines try to cover this in the bottom half of that section. Is this library needed at runtime as some sort of plugin library? If so, it must _not_ be stored in a -devel subpackage. Also note that the lib is found in two paths: in runtime linker's search path, %_libdir, and in a private subdir that is not within runtime linker's search path, %_libdir/nuvolaplayer. Why is that? Are the files linked or copies of eachother? Requires nuvolaplayer (rpmlib, GLIBC filtered): … libnuvolaplayerprivate.so()(64bit) … -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100409] Review Request: libixion - a general purpose formula parser interpreter library
https://bugzilla.redhat.com/show_bug.cgi?id=1100409 David Tardon dtar...@redhat.com changed: What|Removed |Added CC||dtar...@redhat.com Flags||fedora-cvs? --- Comment #4 from David Tardon dtar...@redhat.com --- New Package SCM Request === Package Name: libixion Short Description: A general purpose formula parser interpreter library Upstream URL: https://gitorious.org/ixion/pages/Home Owners: dtardon Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315
--- Comment #37 from MartinKG mgans...@alice.de ---
(In reply to Michael Schwendt from comment #36)
Issues:
===
- Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files directly in %_libdir.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
Unversioned so-files
nuvolaplayer: /usr/lib64/libnuvolaplayerprivate.so
nuvolaplayer: /usr/lib64/nuvolaplayer/libnuvolaplayerprivate.so
Careful reviewing needed here. The DevelPackages guidelines try to cover
this in the bottom half of that section.
Is this library needed at runtime as some sort of plugin library? If so, it
must _not_ be stored in a -devel subpackage.
Also note that the lib is found in two paths: in runtime linker's search
path, %_libdir, and in a private subdir that is not within runtime linker's
search path, %_libdir/nuvolaplayer. Why is that? Are the files linked or
copies of eachother?
Requires
nuvolaplayer (rpmlib, GLIBC filtered):
…
libnuvolaplayerprivate.so()(64bit)
…
when i exclude the second libnuvolaplayerprivate.so in rpm spec file
%exclude %{_libdir}/%{name}/libnuvolaplayerprivate.so
an want to install the package i get this error message:
rpm -ivh nuvolaplayer-2.3.3-2.fc20.x86_64.rpm
error: Failed dependencies:
libnuvolaplayerprivate.so()(64bit) is needed by
nuvolaplayer-2.3.3-2.fc20.x86_64
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097733] Review Request: python-rply - Pure Python parser generator
https://bugzilla.redhat.com/show_bug.cgi?id=1097733 --- Comment #3 from Matej Stuchlik mstuc...@redhat.com --- Correct you are, I've run the tests from upstream repo: they pass just fine under Python2 and two fail under Python3, however they failures are not a problem according to upstream [0]. I've updated the spec. https://github.com/alex/rply/issues/26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096704] Review Request: python-bintrees - Binary-, RedBlack- and AVL-Trees in Python and Cython
https://bugzilla.redhat.com/show_bug.cgi?id=1096704 Matej Stuchlik mstuc...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Matej Stuchlik mstuc...@redhat.com --- Looks good now, approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1058019 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1058019 --- Comment #22 from Fedora Update System upda...@fedoraproject.org --- utf8proc-1.1.6-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/utf8proc-1.1.6-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1058019 --- Comment #23 from Fedora Update System upda...@fedoraproject.org --- utf8proc-1.1.6-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/utf8proc-1.1.6-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1058019 --- Comment #24 from Milan Bouchet-Valat nalimi...@club.fr --- Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315 --- Comment #38 from MartinKG mgans...@alice.de --- I asked upstream, here is the answer: https://answers.launchpad.net/nuvola-player/+question/249469 Jiří Janoušek (fenryxo) %libdir%/libnuvolaplayerprivate.so is installed as a symlink to %libdir%/nuvolaplayer/libnuvolaplayerprivate.so unless build proccess has been modified somehow. The libnuvolaplayerprivate.so is a private runtime library required by the nuvolaplayer binary. Right now, I'm not sure whtether the library has to be directly in %libdir to be found by the nuvolaplayer binary or %libdir/nuvolaplayer is enough. However, it is not considered to be used as a development library for third party plugins, hence the suffix private. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #21 from Didier didier.fab...@gmail.com --- (In reply to Lubomir Rintel from comment #19) Didier, if you are listening, I'm wondering if you could consider addressing at least the last one and communicate these upstream? Done (just for the last one), a patch was created but I'm working to solve the others warnings. A lot of files must be modified (principally adding missing include files) and the only test I found is to test all features one by one to be sure I'm not breaking something. Communication with upstream is started successfully. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #22 from Didier didier.fab...@gmail.com --- Created attachment 900330 -- https://bugzilla.redhat.com/attachment.cgi?id=900330action=edit Solve array bounds -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100409] Review Request: libixion - a general purpose formula parser interpreter library
https://bugzilla.redhat.com/show_bug.cgi?id=1100409 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100409] Review Request: libixion - a general purpose formula parser interpreter library
https://bugzilla.redhat.com/show_bug.cgi?id=1100409 --- Comment #5 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 --- Comment #23 from Lubomir Rintel lkund...@v3.sk --- You might have noticed your repository has been created. Please go ahead, import and build the package; you can close this ticket then. Feel free to address the issues in the git repository as the fixes are ready. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100409] Review Request: libixion - a general purpose formula parser interpreter library
https://bugzilla.redhat.com/show_bug.cgi?id=1100409 David Tardon dtar...@redhat.com changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2014-05-29 08:35:39 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] New: Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Bug ID: 1102723 Summary: Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dvra...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdnssd.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kdnssd-4.99.0-1.fc20.src.rpm Description: KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf) Fedora Account System Username: dvratil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Blocks||656997 (kde-reviews), ||1086148 (kf5) Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Alias||kf5-kdnssd Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1086148 [Bug 1086148] KDE Frameworks 5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315 --- Comment #39 from Michael Schwendt bugs.mich...@gmx.net --- Well, %excluding a file that is a symlink target makes no sense, because that breaks the symlink. ;) rpmls nuvolaplayer would be one convenient command to examine the file types in the package. The libnuvolaplayerprivate.so is a private runtime library required by the nuvolaplayer binary. https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jan Grulich jgrul...@redhat.com --- Looks good, approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Dan Vrátil dvra...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Dan Vrátil dvra...@redhat.com --- New Package SCM Request === Package Name: kf5-kdnssd Short Description: KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf) Upstream URL: http://www.kde.org Owners: dvratil jgrulich ltinkl rdieter kkofler Branches: InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1101521] Review Request: geomorph - A height field editor for Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1101521 Didier didier.fab...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-05-29 09:50:44 --- Comment #24 from Didier didier.fab...@gmail.com --- Successfully built on koji for f19, f20 and rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097426] Review Request: dpdk - dataplane development toolkit for optimized network appliances
https://bugzilla.redhat.com/show_bug.cgi?id=1097426 --- Comment #6 from Neil Horman nhor...@redhat.com --- Flavio, the ExcludeArch directive is because of this: https://fedoraproject.org/wiki/Packaging:Guidelines#Architecture_Support though, they do use an ExclusiveArch example right below it, and dpdk is never going to run on anything non-x86, so I may as well change it. As for the Dual licensing, All the items in DPDK that are GPL or LGPL licensed are actually out of tree kernel modules, that I've configured to not build (for obvious reasons). As such everything that makes it into the manifest is BSD licensed, but I can add a comment to that effect. Will update the buildrequires, thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102723] Review Request: kf5-kdnssd - KDE Frameworks 5 Tier 1 integration module for DNS-SD services (Zeroconf)
https://bugzilla.redhat.com/show_bug.cgi?id=1102723 --- Comment #3 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315
--- Comment #40 from MartinKG mgans...@alice.de ---
(In reply to Michael Schwendt from comment #39)
Well, %excluding a file that is a symlink target makes no sense, because
that breaks the symlink. ;) rpmls nuvolaplayer would be one convenient
command to examine the file types in the package.
ok, rpmls show it:
# rpmls nuvolaplayer
lrwxrwxrwx /usr/bin/nuvolaplayer
-rwxr-xr-x /usr/bin/nuvolaplayer-client
lrwxrwxrwx /usr/lib64/libnuvolaplayerprivate.so
drwxr-xr-x /usr/lib64/nuvolaplayer
-rwxr-xr-x /usr/lib64/nuvolaplayer/libnuvolaplayerprivate.so
The libnuvolaplayerprivate.so is a private runtime library required
by the nuvolaplayer binary.
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
I added ldconfig script to the post ans postun section.
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/nuvolaplayer.spec
SRPM URL:
http://martinkg.fedorapeople.org/Review/SRPMS/nuvolaplayer-2.3.3-2.fc20.src.rpm
%changelog
* Thu May 29 2014 Martin Gansser marti...@fedoraproject.org - 2.3.3-2
- replaced %%RPM_BUILD_ROOT by %%{buildroot}
- delete BR bzr
- added /sbin/ldconfig calls in %%post and %%postun
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098754] Review Request: python-brian - A simulator for spiking neural networks
https://bugzilla.redhat.com/show_bug.cgi?id=1098754
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
CC||d...@der-flo.net
--- Comment #1 from Florian der-flo Lehner d...@der-flo.net ---
This is an *INFORMAL* package-review.
Due to some issues I wouldn't APPROVE so far.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Header files in -devel subpackage, if present.
Note: python-brian : /usr/lib64/python2.7/site-
packages/brian/experimental/cspikequeue/spikequeue.h
See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Large documentation must go in a -doc subpackage. Large could be size (~1MB)
or number of files.
Note: Documentation size is 7270400 bytes in 707 files.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation
- For the Buildrequire 'numpy' please refer to
https://bugzilla.gnome.org/show_bug.cgi?id=591745
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[!]: License field in the package spec file matches the actual license.
--- it would be great, if all sourcefiles would include a note about
the license. For example: brian-1.4.1/brian/(base.py||group.py)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
--- on May 17 2014 something happend
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory names).
--- Please replace the hard coded paths with macros from:
https://fedoraproject.org/wiki/Packaging:RPMMacros
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
http://koji.fedoraproject.org/koji/taskinfo?taskID=6907480
[!]: Package complies to the Packaging Guidelines
--- there are some issues. Please fix them first.
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any
[Bug 1102795] New: Review Request: libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1102795 Bug ID: 1102795 Summary: Review Request: libbtbb - A Bluetooth baseband decoding library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://jsmith.fedorapeople.org/Packaging/libbtbb/libbtbb.spec SRPM URL: http://jsmith.fedorapeople.org/Packaging/libbtbb/libbtbb-2014.02.R2-1.fc21.src.rpm Description: This is the Bluetooth baseband decoding library, forked from the GR-Bluetooth project. It can be used to extract Bluetooth packet and piconet information from Ubertooth devices as well as GR-Bluetooth/USRP. Fedora Account System Username: jsmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102795] Review Request: libbtbb - A Bluetooth baseband decoding library
https://bugzilla.redhat.com/show_bug.cgi?id=1102795 --- Comment #1 from Jared Smith jsmith.fed...@gmail.com --- Please note that I'm willing to swap reviews with someone else if they'd like to swap reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409
--- Comment #7 from Mukundan Ragavan nonamed...@gmail.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
--- Only MIT included although LGPL2 is mentioned (not included) in atleast
one source file.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 6 files have unknown license. Detailed output of
licensecheck in
/home/mukundan/personal/pkgs/reviews/1089409-Lmod/licensecheck.txt
--- License is correct.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/rpm/macros.d,
/usr/lib/rpm, /etc/profile.d
--- This is correct.
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /etc/modulefiles(environment-
modules)
--- Is this correct? Please clarify.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot}
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 Petr Šabata psab...@redhat.com changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #32 from Petr Šabata psab...@redhat.com --- Alright, looks good enough now, approving. I've also just sponsored you into the Packager group. Welcome aboard. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #33 from Petr Šabata psab...@redhat.com --- You may now submit the SCM request for this package. See the following guide: http://fedoraproject.org/wiki/Package_SCM_admin_requests Also, since this is a perl package, add `perl-sig' to `InitialCC', please. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102812] New: Review Request: Ubertooth - A Bluetooth wireless development platform for experimentation
https://bugzilla.redhat.com/show_bug.cgi?id=1102812 Bug ID: 1102812 Summary: Review Request: Ubertooth - A Bluetooth wireless development platform for experimentation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jsmith.fed...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://jsmith.fedorapeople.org/Packaging/ubertooth/ubertooth.spec SRPM URL: http://jsmith.fedorapeople.org/Packaging/ubertooth/ubertooth-2014.04.R1-1.fc21.src.rpm Description: Project Ubertooth is an open source wireless development platform suitable for Bluetooth experimentation. Ubertooth ships with a capable BLE (Bluetooth Smart) sniffer and can sniff some data from Basic Rate (BR) Bluetooth Classic connections. Fedora Account System Username: jsmith -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 613001] Review Request: Heimdal - Alternative Kerberos implementation
https://bugzilla.redhat.com/show_bug.cgi?id=613001 --- Comment #65 from Orion Poplawski or...@cora.nwra.com --- Also, the xinetd stuff should be replaced with systemd configs. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089494] Review Request: nodejs-weak-map - A WeakMap shim for Node.js and browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1089494 --- Comment #4 from Tom Hughes t...@compton.nu --- Bundling exception has been approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098625] Review Request: php-pear-text-wiki - Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text
https://bugzilla.redhat.com/show_bug.cgi?id=1098625 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #9 from Remi Collet fed...@famillecollet.com --- Thanks ! New Package SCM Request === Package Name: php-pear-text-wiki Short Description: Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text Upstream URL: http://pear.php.net/package/Text_Wiki Owners: remi Branches: f19 f20 el5 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102812] Review Request: Ubertooth - A Bluetooth wireless development platform for experimentation
https://bugzilla.redhat.com/show_bug.cgi?id=1102812 Mukundan Ragavan nonamed...@gmail.com changed: What|Removed |Added Assignee|nob...@fedoraproject.org|nonamed...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100873] Review Request: drupal7-views_slideshow - Views Slideshow can be used to create a slideshow of any content
https://bugzilla.redhat.com/show_bug.cgi?id=1100873 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- drupal7-views_slideshow-3.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102812] Review Request: Ubertooth - A Bluetooth wireless development platform for experimentation
https://bugzilla.redhat.com/show_bug.cgi?id=1102812 --- Comment #1 from Mukundan Ragavan nonamed...@gmail.com --- Unfortunately, the package does not build. :( http://koji.fedoraproject.org/koji/taskinfo?taskID=6908813 -- Found LIBBLUETOOTH: /usr/lib64/libbluetooth.so -- Could NOT find PythonInterp (missing: PYTHON_EXECUTABLE) CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: LIBBTBB_INCLUDE_DIR (ADVANCED) used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/libubertooth/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src used as include directory in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src LIBBTBB_LIBRARIES (ADVANCED) linked by target ubertooth in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/libubertooth/src linked by target ubertooth-btle in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-debug in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-dump in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-follow in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-rx in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-scan in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src linked by target ubertooth-util in directory /builddir/build/BUILD/ubertooth-2014-04-R1/host/ubertooth-tools/src -- Configuring incomplete, errors occurred! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102858] New: Review Request: python-repoze-sphinx-autointerface - Auto-generate Sphinx API docs from Zope interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1102858 Bug ID: 1102858 Summary: Review Request: python-repoze-sphinx-autointerface - Auto-generate Sphinx API docs from Zope interfaces Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface.spec SRPM URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface-0.7.1-1.fc21.src.rpm Fedora Account System Username: jjames Description: This package defines an extension for the Sphinx documentation system. The extension allows generation of API documentation by introspection of zope.interface instances in code. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098625] Review Request: php-pear-text-wiki - Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text
https://bugzilla.redhat.com/show_bug.cgi?id=1098625 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098625] Review Request: php-pear-text-wiki - Transforms Wiki and BBCode markup into XHTML, LaTeX or plain text
https://bugzilla.redhat.com/show_bug.cgi?id=1098625 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1040517] Review Request: julia - High-level, high-performance dynamic language for technical computing
https://bugzilla.redhat.com/show_bug.cgi?id=1040517 --- Comment #37 from Milan Bouchet-Valat nalimi...@club.fr --- Temporary bundling exceptions granted for libuv and Rmath. dSFMT is going to be packaged and Julia will use that instead (which may need changes upstream since currently dSFMT does not produce a library). https://fedorahosted.org/fpc/ticket/427#comment:3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 877096] Review Request: perl-Fsdb - A set of commands for manipulating flat-text databases from the shell
https://bugzilla.redhat.com/show_bug.cgi?id=877096 --- Comment #34 from John Heidemann jo...@isi.edu --- Thanks! New Package SCM Request === Package Name: perl-Fsdb Short Description: A set of commands for manipulating flat-text databases from the shell Upstream URL: https://www.isi.edu/~johnh/SOFTWARE/FSDB/Fsdb-2.50.tar.gz Owners: johnh Branches: f19 f20 epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102882] New: Review Request: drupal7-field_group - Fieldgroup will, as the name implies, group fields together
https://bugzilla.redhat.com/show_bug.cgi?id=1102882 Bug ID: 1102882 Summary: Review Request: drupal7-field_group - Fieldgroup will, as the name implies, group fields together Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: peter.bo...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://asrob.fedorapeople.org/SOURCES/drupal7-field_group.spec SRPM URL: http://asrob.fedorapeople.org/SOURCES/drupal7-field_group-1.3-1.fc21.src.rpm Description: Fieldgroup will, as the name implies, group fields together. All fieldable entities will have the possibility to add groups to wrap their fields together. Fieldgroup comes with default HTML wrappers like vertical tabs, horizontal tabs, accordions, fieldsets or div wrappers. Fedora Account System Username: asrob koji url: https://koji.fedoraproject.org/koji/taskinfo?taskID=6909084 rpmlint output: $ rpmlint drupal7-field_group.spec ~/Downloads/drupal7-field_group-1.3-1.fc21.src.rpm drupal7-field_group.src: W: spelling-error Summary(en_US) Fieldgroup - Field group, Field-group, Outfielder drupal7-field_group.src: W: spelling-error %description -l en_US Fieldgroup - Field group, Field-group, Outfielder drupal7-field_group.src: W: spelling-error %description -l en_US fieldable - field able, field-able, battlefield drupal7-field_group.src: W: spelling-error %description -l en_US fieldsets - field sets, field-sets, Fields 1 packages and 1 specfiles checked; 0 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096206] Review Request: python-click - A simple wrapper around optparse
https://bugzilla.redhat.com/show_bug.cgi?id=1096206 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096206] Review Request: python-click - A simple wrapper around optparse
https://bugzilla.redhat.com/show_bug.cgi?id=1096206 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-click-1.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-click-1.1-2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078327] Review Request: github2fedmsg - Pubsubhubbub app that rebroadcasts GH events over fedmsg
https://bugzilla.redhat.com/show_bug.cgi?id=1078327 --- Comment #8 from Ralph Bean rb...@redhat.com --- Temporary bundling exception granted: https://fedorahosted.org/fpc/ticket/428#comment:2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 --- Comment #8 from Orion Poplawski or...@cora.nwra.com --- (In reply to Mukundan Ragavan from comment #7) = MUST items = Generic: [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /etc/modulefiles(environment- modules) --- Is this correct? Please clarify. Yes - both Lmod and environment-modules implement the modules concept. Common module files go in /etc/modulefiles or /usr/share/modulefiles. Lmod.noarch: W: install-file-in-docs /usr/share/doc/Lmod/INSTALL --- I guess this could be removed. Any specific reason why INSTALL file is included? There is some extra usage information in there that I think could be helpful. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 Mukundan Ragavan nonamed...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #9 from Mukundan Ragavan nonamed...@gmail.com --- Sounds good to me. Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Orion Poplawski or...@cora.nwra.com --- Thanks for the review. New Package SCM Request === Package Name: Lmod Short Description: Environmental Modules System in Lua Upstream URL: https://www.tacc.utexas.edu/tacc-projects/lmod Owners: orion Branches: f19 f20 epel7 el6 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 --- Comment #11 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089409] Review Request: Lmod - Environmental Modules System in Lua
https://bugzilla.redhat.com/show_bug.cgi?id=1089409 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||Lmod-5.6-1.fc21 Resolution|--- |NEXTRELEASE Last Closed||2014-05-29 16:42:27 --- Comment #12 from Orion Poplawski or...@cora.nwra.com --- Checked in and built. Thanks all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088696] Review Request: octave-ncarray - Access NetCDF files as a multi-dimensional array
https://bugzilla.redhat.com/show_bug.cgi?id=1088696 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-05-29 16:45:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102941] New: Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives
https://bugzilla.redhat.com/show_bug.cgi?id=1102941 Bug ID: 1102941 Summary: Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: shawn.iwin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/siwinski/rpms/f2002c6480c0a6a5ab718720fbdfbe17a3c06142/php-pclzip.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-pclzip-2.8.2-1.fc20.src.rpm Description: PclZip library offers compression and extraction functions for Zip formatted archives (WinZip, PKZIP). PclZip gives you the ability to manipulate zip formatted archives. You can create an archive, list the content and extract all its content in the file system. PclZip defines an object class which represent a Zip Archive. This class manages the archive properties and offers access method and actions on the archive. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102941] Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives
https://bugzilla.redhat.com/show_bug.cgi?id=1102941 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Alias||php-pclzip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102942] New: Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files
https://bugzilla.redhat.com/show_bug.cgi?id=1102942 Bug ID: 1102942 Summary: Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: shawn.iwin...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/siwinski/rpms/f1636de9a2caf5c8ee109a4fb0f727286e51ac5a/php-phpoffice-phpexcel.spec SRPM URL: http://siwinski.fedorapeople.org/SRPMS/php-phpoffice-phpexcel-1.8.0-1.20140526git4ab61ad.fc20.src.rpm Description: Project providing a set of classes for the PHP programming language, which allow you to write to and read from different spreadsheet file formats, like Excel (BIFF) .xls, Excel 2007 (OfficeOpenXML) .xlsx, CSV, Libre/OpenOffice Calc .ods, Gnumeric, PDF, HTML, ... This project is built around Microsoft's OpenXML standard and PHP. Fedora Account System Username: siwinski -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102941] Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives
https://bugzilla.redhat.com/show_bug.cgi?id=1102941 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Blocks||1102942 ||(php-phpoffice-phpexcel) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1102942 [Bug 1102942] Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102942] Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files
https://bugzilla.redhat.com/show_bug.cgi?id=1102942 Shawn Iwinski shawn.iwin...@gmail.com changed: What|Removed |Added Depends On||1102941 (php-pclzip) Alias||php-phpoffice-phpexcel Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1102941 [Bug 1102941] Review Request: php-pclzip - Compression and extraction functions for Zip formatted archives -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102950] New: Review Request: python-persistent - Translucent persistent python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1102950 Bug ID: 1102950 Summary: Review Request: python-persistent - Translucent persistent python objects Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://jjames.fedorapeople.org/python-persistent/python-persistent.spec SRPM URL: http://jjames.fedorapeople.org/python-persistent/python-persistent-4.0.8-1.fc21.src.rpm Fedora Account System Username: jjames Description: This package contains a generic persistence implementation for Python. It forms the core protocol for making objects interact transparently with a database such as python-ZODB3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102950] Review Request: python-persistent - Translucent persistent python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1102950 Jerry James loganje...@gmail.com changed: What|Removed |Added Depends On||1102858 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1102858 [Bug 1102858] Review Request: python-repoze-sphinx-autointerface - Auto-generate Sphinx API docs from Zope interfaces -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102858] Review Request: python-repoze-sphinx-autointerface - Auto-generate Sphinx API docs from Zope interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1102858 Jerry James loganje...@gmail.com changed: What|Removed |Added Blocks||1102950 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1102950 [Bug 1102950] Review Request: python-persistent - Translucent persistent python objects -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080411] Review Request: trojita - Qt IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1080411 --- Comment #12 from Kevin Kofler ke...@tigcc.ticalc.org --- We indeed do not care about cross builds for Fedora packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1057766] Review Request: clustal-omega - command line tool for multiple sequence alignment
https://bugzilla.redhat.com/show_bug.cgi?id=1057766 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||clustal-omega-1.2.1-2.fc20 Resolution|--- |ERRATA Last Closed||2014-05-29 19:22:49 --- Comment #30 from Fedora Update System upda...@fedoraproject.org --- clustal-omega-1.2.1-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1097584] Review Request: shiny - Shader and material management library for OGRE
https://bugzilla.redhat.com/show_bug.cgi?id=1097584 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||shiny-0.3-1.gitdc53364.fc20 Resolution|--- |ERRATA Last Closed||2014-05-29 19:23:58 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- shiny-0.3-1.gitdc53364.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080583] Review Request: compat-qpid-cpp - Compatibility modules for Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1080583 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #39 from Fedora Update System upda...@fedoraproject.org --- compat-qpid-cpp-0.24-11.fc19 has been pushed to the Fedora 19 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058019] Review Request: utf8proc - Library for processing UTF-8 encoded Unicode strings
https://bugzilla.redhat.com/show_bug.cgi?id=1058019 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #25 from Fedora Update System upda...@fedoraproject.org --- utf8proc-1.1.6-3.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-physfs-2.0.3-4.fc19 Resolution|--- |ERRATA Last Closed||2014-05-29 19:26:27 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mingw-physfs-2.0.3-4.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Bug 1096809 depends on bug 1096796, which changed state. Bug 1096796 Summary: Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library https://bugzilla.redhat.com/show_bug.cgi?id=1096796 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096807] Review Request: mingw-SDL2_image - MinGW Windows port of the Image loading library for SDL2
https://bugzilla.redhat.com/show_bug.cgi?id=1096807 Bug 1096807 depends on bug 1096796, which changed state. Bug 1096796 Summary: Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library https://bugzilla.redhat.com/show_bug.cgi?id=1096796 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096796] Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library
https://bugzilla.redhat.com/show_bug.cgi?id=1096796 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-SDL2-2.0.3-3.fc19 Resolution|--- |ERRATA Last Closed||2014-05-29 19:27:25 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2-2.0.3-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096796] Review Request: mingw-SDL2 - MinGW Windows port of SDL2 cross-platform multimedia library
https://bugzilla.redhat.com/show_bug.cgi?id=1096796 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mingw-SDL2-2.0.3-3.fc19 |mingw-SDL2-2.0.3-3.fc20 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2-2.0.3-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 957346] Review Request: mingw-physfs - MinGW compiled physfs library to provide abstract access to various archives
https://bugzilla.redhat.com/show_bug.cgi?id=957346 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|mingw-physfs-2.0.3-4.fc19 |mingw-physfs-2.0.3-4.fc20 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- mingw-physfs-2.0.3-4.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058587] Review Request: drawpile - A collaborative drawing program
https://bugzilla.redhat.com/show_bug.cgi?id=1058587 --- Comment #16 from Kevin Kofler ke...@tigcc.ticalc.org --- Krita is an application, not a library, so calling code from Krita a bundled library is a bit of a stretch, even if it happens to be somewhere in calligra-krita-libs. I don't think depending on Krita makes any sense for this package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
