[Bug 1115365] Review Request: python-pluginbase - A support library for building plugins sytems in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1115365 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114212] Review Request: glite-lb-server - gLite Logging and Bookkeeping server
https://bugzilla.redhat.com/show_bug.cgi?id=1114212 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me --- Comment #1 from Christopher Meng i...@cicku.me --- I'm here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113712] Review Request: lua-bitop - C extension module for Lua 5.1/5.2 which adds bitwise operations on numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1113712 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me Assignee|nob...@fedoraproject.org|i...@cicku.me -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123399] Review Request: python-botocore - The low-level, core functionality of boto 3
https://bugzilla.redhat.com/show_bug.cgi?id=1123399 --- Comment #4 from Lubomir Rintel lkund...@v3.sk --- As much as I hate to add unrelated noise here (as there doesn't really seem to be anything to solve in this respect), I'd like to ask you to be a bit more considerate next time. Please don't assume bad intentions when something sounds a bit too harsh or rude -- it might very easily be a language barrier. (e.g.: I've seen a person suggesting that something is none of my business/concern when he sincerelly meant that I just don't need to spend my time dealing with an issue :) Christopher is a rather active contributor and reviewer and I can imagine him running a search on tickets in NEW state. It takes some time then to determine if the ticket is actually reviewable (it might not be, as Haïkel correctly points out), and if this happens a lot, the time spent might be quite considerable. Have a nice weekend! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116071] Review Request: libpsl - C library for the Publix Suffix List
https://bugzilla.redhat.com/show_bug.cgi?id=1116071 --- Comment #5 from Christopher Meng i...@cicku.me --- Ooops, I failed to see that ;) Same URLs with a new changelog entry. NEW SPEC URL: http://us-la.cicku.me/libpsl.spec NEW SRPM URL: http://us-la.cicku.me/libpsl-0.5.0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123268] Review Request: perl-Database-DumpTruck - Relaxing interface to SQLite
https://bugzilla.redhat.com/show_bug.cgi?id=1123268 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||panem...@gmail.com, ||ppi...@redhat.com --- Comment #6 from Parag AN(पराग) panem...@gmail.com --- Petr, Do we still have any updated guidelines for having all the BuildRequires specified in perl module specs? I see some of you are recommending to have all such buildtime requirement added to the spec file. As I see its still not in the Perl packaging guidelines, there should not be any issue to approve such packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 991294] Review Request: python-appdirs - A small Python module for determining appropriate platform-specific dirs
https://bugzilla.redhat.com/show_bug.cgi?id=991294 --- Comment #7 from Eduardo Echeverria echevemas...@gmail.com --- Marcelo it is very bad thing not answer to a reviewer, please if you are not interested anymore in one package please close the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098700] Review Request: inkscape-table - Table support for inkscape
https://bugzilla.redhat.com/show_bug.cgi?id=1098700 Lubomir Rintel lkund...@v3.sk changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-07-26 03:28:07 --- Comment #7 from Lubomir Rintel lkund...@v3.sk --- Imported and built now. Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123399] Review Request: python-botocore - The low-level, core functionality of boto 3
https://bugzilla.redhat.com/show_bug.cgi?id=1123399 --- Comment #5 from Haïkel Guémar karlthe...@gmail.com --- I shouldn't have reacted like that but I stand that Christopher's This will save my time. was inappropriate and rude. I won't go further, but I don't think I have to take lessons from him. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123268] Review Request: perl-Database-DumpTruck - Relaxing interface to SQLite
https://bugzilla.redhat.com/show_bug.cgi?id=1123268 Richard Marko rma...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||rma...@redhat.com Assignee|nob...@fedoraproject.org|rma...@redhat.com Flags||fedora-review+ --- Comment #7 from Richard Marko rma...@redhat.com --- - Good license - Sane spec - Builds and installs correctly - rpmlint happy ACK. Regarding the BRs - I think this shouldn't block the review and the maintainer can easily fix this if needed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 783016] Review Request: pilas - A simple to use video game framework
https://bugzilla.redhat.com/show_bug.cgi?id=783016 --- Comment #37 from Eduardo Echeverria echevemas...@gmail.com --- This package have many time of review. Many people has given you advices in your build. I've talked some time ago with you in IRC about the package. Do you think that is already enough time for finishing the review? this is the only stalled review that I have. In the latest FISL in brazil I've talked with one of the developers of this application and him has shown much interest to see this package in Fedora. I wondering if you has seen that your latest build has failed for cause of a unfulfilled BR? Please tell me if you can finish the package or let to other people to do a new review. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123398] Review Request: python-jmespath - JSON Matching Expressions
https://bugzilla.redhat.com/show_bug.cgi?id=1123398
Haïkel Guémar karlthe...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Haïkel Guémar karlthe...@gmail.com ---
Since this package complies with Fedora packaging guidelines, and works as
expected, I hereby approve it. Formal review is below.
Please submit a scm request.
I'll finish the reviews blocked by this one as soon as python{,3}-jmespath is
imported in rawhide.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated. 22 files have unknown license. Detailed output of
licensecheck in /home/haikel/1123398-python-jmespath/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-jmespath
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
[Bug 1123550] New: Review Request: infernal - An implementation of Covariance Models
https://bugzilla.redhat.com/show_bug.cgi?id=1123550 Bug ID: 1123550 Summary: Review Request: infernal - An implementation of Covariance Models Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: i...@cicku.me QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://us-la.cicku.me/infernal.spec SRPM URL: http://us-la.cicku.me/infernal-1.1.1-1.fc22.src.rpm Description: Infernal is an implementation of covariance models (CMs), which are statistical models of RNA secondary structure and sequence consensus. You give Infernal a multiple sequence alignment of a conserved structural RNA family, annotated with the consensus secondary structure. The cmbuild program builds a statistical profile of your alignment. That CM can be used as a query in a database search to find more homologs of your RNAs (the cmsearch program). You can also use a CM of a representative alignment of your sequence family to create a larger consensus alignment of any number of RNAs (the cmalign program). Infernal is the software engine underlying the Rfam RNA database (http://rfam.janelia.org). Fedora Account System Username: cicku -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123550] Review Request: infernal - An implementation of Covariance Models
https://bugzilla.redhat.com/show_bug.cgi?id=1123550 Christopher Meng i...@cicku.me changed: What|Removed |Added Whiteboard||NotReady --- Comment #1 from Christopher Meng i...@cicku.me --- I just got needs of the MPI, so I will fix it later when Ready comes. I also need to scratch a build for non-x86 arch as it uses SIMD feature. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123397] Review Request: python-bcdoc - Tools to help document botocore-based projects
https://bugzilla.redhat.com/show_bug.cgi?id=1123397 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? --- Comment #2 from Haïkel Guémar karlthe...@gmail.com --- Few minor things: * please fix the summary for the python3 subpackage ;) * bcdoc belongs to boto project which is independent from Amazon. I think that the appropriate url would be: https://github.com/boto/boto From my preliminary review, the package builds, installs and works as expected. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123402] Review Request: awscli - AWS Command Line Interface
https://bugzilla.redhat.com/show_bug.cgi?id=1123402 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120791] Review Request: freesteam - Calculate the properties of water and steam
https://bugzilla.redhat.com/show_bug.cgi?id=1120791 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- freesteam-2.1-3.20140724svn753.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/freesteam-2.1-3.20140724svn753.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107127] Review Request: procenv - Utility to show process environment
https://bugzilla.redhat.com/show_bug.cgi?id=1107127
--- Comment #5 from Michael Schwendt bugs.mich...@gmx.net ---
I notice that the RPM tries to use the user dlove.
It would be similar with your own src.rpm packages, because it's entirely
normal for the included files to be owned by the user that builds the src.rpm,
e.g. mockbuild or your ordinary user account.
$ strings ./srpm/procenv-0.35-2.el6.src.rpm | grep dlove
Examine: rpm -qlvp procenv-0.35-2.el6.src.rpm
%doc
An empty %doc line makes no sense, since it's a no-op.
%{_mandir}/man1/procenv.1.gz
Not a big issue, but prefer
%{_mandir}/man1/procenv.1*
to allow for disabled/changed/customized compression of manual pages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1109390] Review Request: llvm3.3 - Versioned LLVM
https://bugzilla.redhat.com/show_bug.cgi?id=1109390 --- Comment #10 from Milan Bouchet-Valat nalimi...@club.fr --- As I said in the description: This package is just a modification of the llvm package version 3.3 which was included in F20. All paths have been changed to include the version, so that they do not conflict with other LLVM packages. The only exceptions are the -devel packages, which need to conflict since they determine with LLVM compilers will use. -devel packages need to conflict since usually programs call llvm-config to determine which version of LLVM should be used when building. If they did not conflict, they would have to be adapted to call a special versioned llvm-config. I don't think this is a problem since you can easily remove llvm-devel without removing many dependencies. For a Julia package, see http://copr.fedoraproject.org/coprs/nalimilan/julia/ (details on Bug 1040517) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123511] Review Request: nanomsg - A fast, scalable, and easy to use socket library
https://bugzilla.redhat.com/show_bug.cgi?id=1123511
--- Comment #2 from Michael Schwendt bugs.mich...@gmx.net ---
A couple of minor issues:
BuildRoot: %(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
%defattr(-,root,root)
%clean
rm -fR %{buildroot}
These are only needed for EL5, so unless you want to build for EL5, consider
dropping them:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
%if %{with static}
%configure --enable-doc --enable-debug --enable-static
%else
%configure --enable-doc --enable-debug --disable-static
%endif
IMO, the following would be smarter (since you would not need to modify two
%configure calls whenever you wanted to change the options):
%configure --enable-doc --enable-debug \
%{?_with_static:--enable-static}%{!?_with_static:--disable-static}
make %{?_smp_mflags}
The build.log output is non-verbose (=silent). One cannot see which
preprocessor/compiler flags and parameters are active.
One work-around would be to call the configure script with option
--disable-silent-rules, another would be to call make with V=1.
Doing that, it turns out the package is built without Fedora's global flags:
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags
%files devel
%doc ChangeLog COPYING README
%files utils
%doc ChangeLog COPYING README
Both subpackages don't need to duplicate these %doc files, because they (unlike
the -doc subpkg) depend on the base package already. Plus, note that many users
prefer changelog files to be included in the base runtime package anyway.
%{_libdir}/pkgconfig/*.pc
Umm, ... it says Version: 2.0.2 which is neither the package %version (0.4
beta) nor the lib SONAME version (0, 0.2.0). Anything known about this
confusing versioning?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043290] Review Request: engrampa - MATE Desktop file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1043290 Bug 1043290 depends on bug 1038773, which changed state. Bug 1038773 Summary: Review Request: caja - File manager for MATE desktop https://bugzilla.redhat.com/show_bug.cgi?id=1038773 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Bug 1043297 depends on bug 1038773, which changed state. Bug 1038773 Summary: Review Request: caja - File manager for MATE desktop https://bugzilla.redhat.com/show_bug.cgi?id=1038773 What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #11 from Wolfgang Ulbrich chat-to...@raveit.de --- New Package SCM Request === Package Name: caja Short Description: File manager for MATE desktop Owners: raveit65 vicodan Branches: f20 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Wolfgang Ulbrich chat-to...@raveit.de --- Opps, sorry. Package Change Request == Package Name: caja New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #8 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: atril New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #7 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: caja-extensions New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043290] Review Request: engrampa - MATE Desktop file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1043290 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #6 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: engrampa New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047013] Review Request: eom - Eye of MATE image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1047013 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #10 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: eom New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #5 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: marco New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1064486] Review Request: mozo - MATE Desktop menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1064486 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #7 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: mozo New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046726] Rename Request: pluma - Text editor for the MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1046726 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #15 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: pluma New Branches: f20 Owners: raveit65 vicodan InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1088645] Review Request: thc-ipv6 - An toolkit for attacking the IPv6 protocol suite
https://bugzilla.redhat.com/show_bug.cgi?id=1088645
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|d...@der-flo.net
Flags|fedora-review? |fedora-review+
--- Comment #9 from Florian der-flo Lehner d...@der-flo.net ---
General
===
[ ] There are a lot of warning during compilation. Please try to fix
this in further versions
[ ] Whats about DEADJOE in the Makefile?
[ ] Sorry for not setting the Assigned-To at the beginning
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
Unknown or generated.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
--- http://koji.fedoraproject.org/koji/taskinfo?taskID=7199229
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of
[Bug 1116071] Review Request: libpsl - C library for the Publix Suffix List
https://bugzilla.redhat.com/show_bug.cgi?id=1116071 Jerry James loganje...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Jerry James loganje...@gmail.com --- Everything looks good now. This package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1086406] Review Request: python-nose-testconfig - Test configuration plugin for nosetests
https://bugzilla.redhat.com/show_bug.cgi?id=1086406 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123575] New: Review Request: golang-github-levigo - Go wrapper for LevelDB
https://bugzilla.redhat.com/show_bug.cgi?id=1123575 Bug ID: 1123575 Summary: Review Request: golang-github-levigo - Go wrapper for LevelDB Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: e...@mayorgalinux.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://mayorga.fedorapeople.org/golang-github-levigo.spec SRPM URL: https://mayorga.fedorapeople.org/golang-github-levigo-0-0.1.0.git4f0dc98.fc20.src.rpm Description: levigo is a Go wrapper for LevelDB. Fedora Account System Username: mayorga -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium
https://bugzilla.redhat.com/show_bug.cgi?id=1113310 --- Comment #9 from Sergio Pascual sergio.pa...@gmail.com --- The package does not build in rawhide, look https://kojipkgs.fedoraproject.org//work/tasks/9648/7199648/build.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123579] New: Review Request: rubygem-colorize - Add color methods to String class
https://bugzilla.redhat.com/show_bug.cgi?id=1123579 Bug ID: 1123579 Summary: Review Request: rubygem-colorize - Add color methods to String class Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ctria...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize.spec SRPM URL: https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.7.3-1.fc20.src.rpm Fedora 20 RPMS: https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-0.7.3-1.fc20.noarch.rpm https://ctria.fedorapeople.org/packaging/rubygem-colorize/rubygem-colorize-doc-0.7.3-1.fc20.noarch.rpm Description: Ruby String class extension. Adds methods to set text color, background color and, text effects on ruby console and command line output, using ANSI escape sequences. Fedora Account System Username: ctria -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038773] Review Request: caja - File manager for MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1038773 --- Comment #13 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038817] Review Request: caja-extensions - Set of extensions for caja file manager
https://bugzilla.redhat.com/show_bug.cgi?id=1038817 --- Comment #8 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 --- Comment #6 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1042995] Review Request: marco - MATE Desktop window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1042995 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043290] Review Request: engrampa - MATE Desktop file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1043290 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043290] Review Request: engrampa - MATE Desktop file archiver
https://bugzilla.redhat.com/show_bug.cgi?id=1043290 --- Comment #7 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1043297] Review Request: atril - MATE Document viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1043297 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046726] Rename Request: pluma - Text editor for the MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1046726 --- Comment #16 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1046726] Rename Request: pluma - Text editor for the MATE desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1046726 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1064486] Review Request: mozo - MATE Desktop menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1064486 --- Comment #8 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047013] Review Request: eom - Eye of MATE image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1047013 --- Comment #11 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1047013] Review Request: eom - Eye of MATE image viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1047013 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122749] EPEL7 branch erlang-oauth erlang-mochiweb erlang-snappy
https://bugzilla.redhat.com/show_bug.cgi?id=1122749 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122749] EPEL7 branch erlang-oauth erlang-mochiweb erlang-snappy
https://bugzilla.redhat.com/show_bug.cgi?id=1122749 --- Comment #5 from Kevin Fenzi ke...@scrye.com --- Git done (by process-git-requests). You had a 'and' in there that might have confused the script. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1064486] Review Request: mozo - MATE Desktop menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1064486 Kevin Fenzi ke...@scrye.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123583] New: Review Request: perl-Data-Printer - Pretty printer for Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1123583 Bug ID: 1123583 Summary: Review Request: perl-Data-Printer - Pretty printer for Perl data structures Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dd...@cpan.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ddick.fedorapeople.org/packages/perl-Data-Printer.spec SRPM URL: https://ddick.fedorapeople.org/packages/perl-Data-Printer-0.35-1.fc20.src.rpm Description: Pretty printer for Perl data structures Fedora Account System Username: ddick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122484] Review Request: perl-Date-Handler - Easy but complete date object
https://bugzilla.redhat.com/show_bug.cgi?id=1122484 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1123583 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123583 [Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl data structures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123546] Review Request: perl-DateTime-Incomplete - Representing partial dates and times
https://bugzilla.redhat.com/show_bug.cgi?id=1123546 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1123583 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123583 [Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl data structures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types
https://bugzilla.redhat.com/show_bug.cgi?id=1118960 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1123583 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123583 [Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl data structures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty
https://bugzilla.redhat.com/show_bug.cgi?id=1122735 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1123583 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1123583 [Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl data structures -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1123583] Review Request: perl-Data-Printer - Pretty printer for Perl data structures
https://bugzilla.redhat.com/show_bug.cgi?id=1123583 David Dick dd...@cpan.org changed: What|Removed |Added Depends On||1123546, 1122484, 1118960, ||1122735 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1118960 [Bug 1118960] Review Request: perl-Clone-PP - Recursively copy Perl data-types https://bugzilla.redhat.com/show_bug.cgi?id=1122484 [Bug 1122484] Review Request: perl-Date-Handler - Easy but complete date object https://bugzilla.redhat.com/show_bug.cgi?id=1122735 [Bug 1122735] Review Request: perl-IO-Pty-Easy - Easy interface to IO::Pty https://bugzilla.redhat.com/show_bug.cgi?id=1123546 [Bug 1123546] Review Request: perl-DateTime-Incomplete - Representing partial dates and times -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 997829] Review Request: caja-actions - Caja extension for customizing the context menu
https://bugzilla.redhat.com/show_bug.cgi?id=997829 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|CLOSED |ASSIGNED Resolution|ERRATA |--- Flags|fedora-cvs+ |fedora-cvs? Keywords||Reopened --- Comment #10 from Wolfgang Ulbrich chat-to...@raveit.de --- Package Change Request == Package Name: caja-actions New Branches: f20 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1116018] Review Request: rubygem-ansi - ruby ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1116018
Christos Triantafyllidis ctria...@redhat.com changed:
What|Removed |Added
CC||ctria...@redhat.com,
||steve.tray...@cern.ch
Assignee|nob...@fedoraproject.org|ctria...@redhat.com
Flags||fedora-review?
||needinfo?(steve.traylen@cer
||n.ch)
--- Comment #1 from Christos Triantafyllidis ctria...@redhat.com ---
Hello Steve,
I'll do the review on that.
First I suspect that the correct URL for SRPM is (I did the review based on
that):
http://cern.ch/straylen/rpms/rubygem-ansi/rubygem-ansi-1.4.3-1.fc20.src.rpm
I did a scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7199724
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- gems should require rubygems package
Note: Requires: rubygems missing in rubygem-ansi, rubygem-ansi-doc
See: http://fedoraproject.org/wiki/Packaging:Ruby#RubyGems
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[!]: License file installed when any subpackage combination is installed.
That needs additional check, I don't see it in the resulted packages but no
obvious reason why this is not included although it is available in upstream
source. I suspect that it is simply not included in the .gem file. (I'll return
to that later)
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gems,
/usr/share/gems/doc
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
rubygems package requires is missing.
[x]: Spec file is legible and written in American English.
Looks American English to me, minor issue: description is not splitted in 80
(or about 80) chars. It would look better as:
~~~
The ANSI project is a superlative collection of ANSI escape code related
libraries enabling ANSI colorization and styling of console output. Byte for
byte ANSI is the best ANSI code library available for the Ruby programming
language.
~~~
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
As stated above, license file exists upstream but probably not in .gem file,
I'll re-visit this.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec
[Bug 997829] Review Request: caja-actions - Caja extension for customizing the context menu
https://bugzilla.redhat.com/show_bug.cgi?id=997829 Wolfgang Ulbrich chat-to...@raveit.de changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |ERRATA Flags|fedora-cvs? |fedora-cvs+ Last Closed|2013-08-27 19:27:21 |2014-07-26 20:28:51 --- Comment #11 from Wolfgang Ulbrich chat-to...@raveit.de --- Sorry..for that noise--please ignore -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 958132] Review Request: soxr - The SoX Resampler library
https://bugzilla.redhat.com/show_bug.cgi?id=958132 Richard Shaw hobbes1...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #14 from Richard Shaw hobbes1...@gmail.com --- Package Change Request == Package Name: soxr New Branches: epel7 Owners: hobbes1069 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117562] Review Request: golang-github-tchap-go-patricia - A generic patricia trie implemented in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1117562 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117562] Review Request: golang-github-tchap-go-patricia - A generic patricia trie implemented in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1117562 --- Comment #6 from Lokesh Mandvekar l...@fedoraproject.org --- New Package SCM Request === Package Name: golang-github-tchap-go-patricia Short Description: A generic patricia trie implemented in Go Upstream URL: https://github.com/tchap/go-patricia Owners: lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
