[Bug 1148816] Review Request: python-XStatic-Bootstrap-Datepicker - Bootstrap-Datepicker (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148816 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Matthias Runge mru...@redhat.com --- Thank you very much for the review! New Package SCM Request === Package Name: python-XStatic-Bootstrap-Datepicker Short Description: Bootstrap-Datepicker (XStatic packaging standard) Upstream URL: https://github.com/eternicode/bootstrap-datepicker/ Owners: mrunge Branches: f20 f21 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150512] Review Request: gr-fcdproplus - GNURadio support for FUNcube Dongle Pro+
https://bugzilla.redhat.com/show_bug.cgi?id=1150512
--- Comment #2 from Jan Synacek jsyna...@redhat.com ---
(In reply to Jan Synacek from comment #1)
Issues:
===
- Package contains BR: python2-devel or python3-devel
I don't see any direct usage of python during the build. I don't think
any of these are required.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
This is a python subdirectory with included swig bindings. I don't see
any problem with that.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/udev,
/usr/lib/udev/rules.d
These are owned by another package (systemd). No problem.
[!]: Uses parallel make %{?_smp_mflags} macro.
There is a clear mention in the spec file that the parallel build is broken. No
problem.
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-
fcdproplus-devel , gr-fcdproplus-doc
PROBLEM: probably doesn't matter for -doc, but -devel should have the %{?_isa}
part.
Rpmlint
---
Checking: gr-fcdproplus-0-0.1.20140920git1edbe523.fc20.x86_64.rpm
gr-fcdproplus-devel-0-0.1.20140920git1edbe523.fc20.x86_64.rpm
gr-fcdproplus-doc-0-0.1.20140920git1edbe523.fc20.noarch.rpm
gr-fcdproplus-0-0.1.20140920git1edbe523.fc20.src.rpm
gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib
gr-fcdproplus-devel.x86_64: W: no-documentation
gr-fcdproplus.src: W: invalid-url Source0:
gr-fcdproplus-0-20140920git1edbe523.tar.bz2
4 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
# rpmlint gr-fcdproplus-doc gr-fcdproplus gr-fcdproplus-devel
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libusb-1.0.so.0
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0
/lib64/libboost_filesystem.so.1.54.0
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libm.so.6
gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib
gr-fcdproplus-devel.x86_64: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.
# echo 'rpmlint-done:'
I don't see any problems with these.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ghc-cmdtheline-0.2.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-cmdtheline-0.2.3-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- ghc-cmdtheline-0.2.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-cmdtheline-0.2.3-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- ghc-cmdtheline-0.2.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-cmdtheline-0.2.3-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- ghc-cmdtheline-0.2.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-cmdtheline-0.2.3-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149550] Review Request: ghc-cmdtheline - Declarative command-line option parsing and documentation library
https://bugzilla.redhat.com/show_bug.cgi?id=1149550 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-cmdtheline-0.2.3-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-cmdtheline-0.2.3-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- ghc-monad-unify-0.2.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-monad-unify-0.2.2-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ghc-pattern-arrows-0.0.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-pattern-arrows-0.0.2-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- ghc-pattern-arrows-0.0.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-pattern-arrows-0.0.2-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-pattern-arrows-0.0.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/ghc-pattern-arrows-0.0.2-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- ghc-pattern-arrows-0.0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-pattern-arrows-0.0.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 --- Comment #10 from Fedora Update System upda...@fedoraproject.org --- ghc-pattern-arrows-0.0.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-pattern-arrows-0.0.2-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- ghc-monad-unify-0.2.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/ghc-monad-unify-0.2.2-1.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- ghc-monad-unify-0.2.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/ghc-monad-unify-0.2.2-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- ghc-monad-unify-0.2.2-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/ghc-monad-unify-0.2.2-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149556] Review Request: ghc-pattern-arrows - Arrows for Pretty Printing
https://bugzilla.redhat.com/show_bug.cgi?id=1149556 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149554] Review Request: ghc-monad-unify - Generic first-order unification
https://bugzilla.redhat.com/show_bug.cgi?id=1149554 --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- ghc-monad-unify-0.2.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ghc-monad-unify-0.2.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1120982] Review Request: scythestat - Scythe Statistical Library
https://bugzilla.redhat.com/show_bug.cgi?id=1120982 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #5 from Christopher Meng i...@cicku.me --- (In reply to Dominik 'Rathann' Mierzejewski from comment #4) Ping? Sorry, I haven't received any replies so far. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #65 from Christopher Meng i...@cicku.me --- PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144178] Review Request: mlogc - ModSecurity Audit Log Collector
https://bugzilla.redhat.com/show_bug.cgi?id=1144178 Christopher Meng i...@cicku.me changed: What|Removed |Added Component|Package Review |Package Review Version|epel7 |rawhide Product|Fedora EPEL |Fedora --- Comment #2 from Christopher Meng i...@cicku.me --- Please don't modify some fields. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115365] Review Request: python-pluginbase - A support library for building plugins sytems in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1115365 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #3 from Christopher Meng i...@cicku.me --- Will finish this soon, sorry. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1039315] Review Request: nuvolaplayer - Cloud Music Integration for your Linux Desktop
https://bugzilla.redhat.com/show_bug.cgi?id=1039315 MartinKG mgans...@alice.de changed: What|Removed |Added Flags||fedora-cvs? --- Comment #66 from MartinKG mgans...@alice.de --- @Christopher many thanks for the review. New Package SCM Request === Package Name: nuvolaplayer Short Description: Cloud Music Integration for your Linux Desktop Owners: martinkg Branches: f20 f21 devel InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131825] Review Request: qtile - Small, flexible, scriptable tiling window manager
https://bugzilla.redhat.com/show_bug.cgi?id=1131825 Christopher Meng i...@cicku.me changed: What|Removed |Added Flags|needinfo?(i...@cicku.me) | --- Comment #6 from Christopher Meng i...@cicku.me --- (In reply to Tomas Dabašinskas from comment #5) Scratch build ok: [packager@33b32ae1ef19 ~]$ koji build --scratch rawhide qtile-0.8.0-1.fc22.src.rpm Uploading srpm: qtile-0.8.0-1.fc22.src.rpm [] 100% 00:00:03 276.85 KiB 73.45 KiB/sec Created task: 7752110 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=7752110 Watching tasks (this may be safely interrupted)... 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) 7752111 buildArch (qtile-0.8.0-1.fc22.src.rpm, noarch): open (buildvm-03.phx2.fedoraproject.org) - closed 0 free 1 open 1 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm): open (buildvm-19.phx2.fedoraproject.org) - closed 0 free 0 open 2 done 0 failed 7752110 build (rawhide, qtile-0.8.0-1.fc22.src.rpm) completed successfully /bin/qtile has import pkg_resources which is in python-setuptools, should it be included as Requires? Having trouble with mock, unable to run fedora-review I will ask upstream about that. Will you take this review? If so you can assign and change the bug status. Thanks, I'm busy... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147921] Review Request: mongo-cxx-driver - A C++ driver for MondgoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1147921 Christopher Meng i...@cicku.me changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151369] New: Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1151369 Bug ID: 1151369 Summary: Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Crypt-URandom/perl-Crypt-URandom.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Crypt-URandom/perl-Crypt-URandom-0.34-1.fc22.src.rpm Description: This Module is intended to provide an interface to the strongest available source of non-blocking randomness on the current platform. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149767] Review Request: rubygem-twitter - A Ruby interface to the Twitter API.
https://bugzilla.redhat.com/show_bug.cgi?id=1149767 --- Comment #1 from Marek Mahut mma...@redhat.com --- New spec file rebased on latest guidelines. Spec URL: http://people.redhat.com/mmahut/packages/rubygem-twitter/rubygem-twitter.spec SRPM URL: http://people.redhat.com/mmahut/packages/rubygem-twitter/rubygem-twitter-5.11.0-2.fc18.src.rpm Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7820488 EPEL scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7820476 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149767] Review Request: rubygem-twitter - A Ruby interface to the Twitter API.
https://bugzilla.redhat.com/show_bug.cgi?id=1149767 Michal Fojtik mfoj...@redhat.com changed: What|Removed |Added CC||mfoj...@redhat.com Flags||fedora-review? --- Comment #2 from Michal Fojtik mfoj...@redhat.com --- Taking this for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149767] Review Request: rubygem-twitter - A Ruby interface to the Twitter API.
https://bugzilla.redhat.com/show_bug.cgi?id=1149767 --- Comment #3 from Michal Fojtik mfoj...@redhat.com --- Marek: Requires: rubygem(faraday) = 0.9.0 Requires: rubygem(faraday) 0.10 and the others... do you really want to do this? In case there is an update to faraday, this RPM will blows up. In general, I think it is OK to just use the first one and not the VERSION. Also this RPM need tests, there are couple in: https://github.com/sferik/twitter/tree/master/spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149767] Review Request: rubygem-twitter - A Ruby interface to the Twitter API.
https://bugzilla.redhat.com/show_bug.cgi?id=1149767 --- Comment #4 from Marek Mahut mma...@redhat.com --- Spec file updated. Spec URL: http://people.redhat.com/mmahut/packages/rubygem-twitter/rubygem-twitter.spec SRPM URL: http://people.redhat.com/mmahut/packages/rubygem-twitter/rubygem-twitter-5.11.0-2.fc18.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905240] Review Request: rubygem-log4r - Comprehensive and flexible logging library for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=905240 --- Comment #14 from Ingvar Hagelund ing...@linpro.no --- Updated package here: http://users.linpro.no/ingvar/vagrant/f20/src/rubygem-log4r-1.1.11-2.fc20.src.rpm Ingvar -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150512] Review Request: gr-fcdproplus - GNURadio support for FUNcube Dongle Pro+
https://bugzilla.redhat.com/show_bug.cgi?id=1150512
--- Comment #3 from Jaroslav Škarvada jskar...@redhat.com ---
(In reply to Jan Synacek from comment #2)
Thanks for the review.
Issues:
===
- Package contains BR: python2-devel or python3-devel
I don't see any direct usage of python during the build. I don't think
any of these are required.
The python-devel packages is not mentioned in the spec, it seems it is
installed as gnuradio-devel dependency:
$ grep python ./gr-fcdproplus.spec
%{python_sitearch}/*
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
This is a python subdirectory with included swig bindings. I don't see
any problem with that.
My opinion is the same, the lib is not provided by the rpm package.
There is a clear mention in the spec file that the parallel build is broken.
No problem.
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-
fcdproplus-devel , gr-fcdproplus-doc
PROBLEM: probably doesn't matter for -doc, but -devel should have the
%{?_isa} part.
Thanks, fixed.
Rpmlint (installed packages)
# rpmlint gr-fcdproplus-doc gr-fcdproplus gr-fcdproplus-devel
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libusb-1.0.so.0
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0
/lib64/libboost_filesystem.so.1.54.0
gr-fcdproplus.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libgnuradio-fcdproplus.so.0.0.0 /lib64/libm.so.6
These should be fixed now.
gr-fcdproplus-devel.x86_64: W: only-non-binary-in-usr-lib
This is rpmlint bug, other seems harmless.
New version:
Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-fcdproplus.spec
SRPM URL:
https://fedorapeople.org/~jskarvad/gnuradio/gr-fcdproplus-0-0.2.20140920git1edbe523.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151369] Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1151369 David Dick dd...@cpan.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||dd...@cpan.org Assignee|nob...@fedoraproject.org|dd...@cpan.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956
Alan Pevec ape...@gmail.com changed:
What|Removed |Added
CC||mru...@redhat.com
Flags||fedora-review+
||needinfo?(mru...@redhat.com
||)
--- Comment #1 from Alan Pevec ape...@gmail.com ---
APPROVED
xstatic/pkg ownership will be fixed in python-XStatic update.
As with all xstatic packages, please request that xstatic upstream keeps
license files in the tarball.
Also to be fixed upstream is
Home-page: http://getbootstrap.org/
in PKG-INFO, it's bogus parked domain, correct is getbootstrap.com
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
See above, getbootstrap.com claims MIT.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/lib/python2.7/site-packages/xstatic/pkg
TO BE fixed in python-XStatic update
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/python2.7/site-
packages/xstatic/pkg
TO BE fixed in python-XStatic update
[x]: Package contains no bundled libraries without FPC exception.
Contains javascript files which have exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
BUT /usr/share/javascript/bootstrap_scss/fonts/ are not meant to be
used as general purpose fonts, so waiving this.
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
As noted above, this needs to be fixed for xstatic packages.
[x]:
[Bug 1117025] Review Request: rubygem-joiner - Builds ActiveRecord joins from association paths
https://bugzilla.redhat.com/show_bug.cgi?id=1117025
--- Comment #1 from František Dvořák val...@civ.zcu.cz ---
Issues or changes for consideration:
1) new version of joiner is available (0.3.3)
2) (cosmetic) you can consider using unified way of excluding files (replacing
rm .%{gem_instdir}/%{gem_name}.gemspec by %exclude macro?)
3) (cosmetic) you can consider using %license macro for license file
4) (future work) I think combustion gem requires bundler. Removing bundler from
spec_helper.rb may break things, or there will be needed some way of disabling
bundler in combustion?
But it is not used now anyway, so it is not needed neither for build nor
passing the review. :-)
5) (question) there is not used require 'active_record' anywere in joiner
sources, but I guess it's OK (developers using joiner will require rails or
activerecord anyway?)
mock-chroot[root@forkys /]# ruby -e require 'joiner'
/usr/share/gems/gems/joiner-0.3.0/lib/joiner/joins.rb:2:in `class:Joins':
uninitialized constant ActiveRecord (NameError)
from /usr/share/gems/gems/joiner-0.3.0/lib/joiner/joins.rb:1:in `top
(required)'
from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in
`require'
from /usr/share/rubygems/rubygems/core_ext/kernel_require.rb:55:in
`require'
from /usr/share/gems/gems/joiner-0.3.0/lib/joiner.rb:6:in `top
(required)'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151369] Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1151369 David Dick dd...@cpan.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from David Dick dd...@cpan.org --- License is correct Builds correctly at http://koji.fedoraproject.org/koji/taskinfo?taskID=7820878 Build and Run Time requires are correct rpmlint is clean Package APPROVED. Petr, can you build this package for EPEL7? It's a dependency for Dancer2, which i'm going to try to get into EPEL7. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Alan Pevec ape...@gmail.com changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #2 from Alan Pevec ape...@gmail.com --- [!]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files BUT /usr/share/javascript/bootstrap_scss/fonts/ are not meant to be used as general purpose fonts, so waiving this. This might be blocking issue after all, http://getbootstrap.com/components/ says: Includes 200 glyphs in font format from the Glyphicon Halflings set. Glyphicons Halflings are normally not available for free, but their creator has made them available for Bootstrap free of cost. As a thank you, we only ask that you include a link back to Glyphicons whenever possible. This needs to be raised with fedora-legal, exact wording of boostrap/glyphicons agreement is unknown to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151414] New: Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1151414 Bug ID: 1151414 Summary: Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Number-Tolerant/perl-Number-Tolerant.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Number-Tolerant/perl-Number-Tolerant-1.703-1.fc22.src.rpm Description: These Perl modules create a number-like object whose value refers to a range of possible values, each equally acceptable. It overloads comparison operations to reflect this. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151415] New: Review Request: perl-Return-MultiLevel - Return across multiple call levels
https://bugzilla.redhat.com/show_bug.cgi?id=1151415 Bug ID: 1151415 Summary: Review Request: perl-Return-MultiLevel - Return across multiple call levels Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dd...@cpan.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ddick.fedorapeople.org/packages/perl-Return-MultiLevel.spec SRPM URL: https://ddick.fedorapeople.org/packages/perl-Return-MultiLevel-0.04-1.fc20.src.rpm Description: Return across multiple call levels Fedora Account System Username: ddick -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150512] Review Request: gr-fcdproplus - GNURadio support for FUNcube Dongle Pro+
https://bugzilla.redhat.com/show_bug.cgi?id=1150512 Jan Synacek jsyna...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Jan Synacek jsyna...@redhat.com --- All seems fine now, approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149978] Review Request: perl-Data-Munge - Utility functions for working with perl data structures and code references
https://bugzilla.redhat.com/show_bug.cgi?id=1149978 David Dick dd...@cpan.org changed: What|Removed |Added Blocks||1151415 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1151415 [Bug 1151415] Review Request: perl-Return-MultiLevel - Return across multiple call levels -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151415] Review Request: perl-Return-MultiLevel - Return across multiple call levels
https://bugzilla.redhat.com/show_bug.cgi?id=1151415 David Dick dd...@cpan.org changed: What|Removed |Added Depends On||1149978 --- Comment #1 from David Dick dd...@cpan.org --- koji builds rawhide at http://koji.fedoraproject.org/koji/taskinfo?taskID=7820968 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1149978 [Bug 1149978] Review Request: perl-Data-Munge - Utility functions for working with perl data structures and code references -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151414] Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1151414 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151419] New: Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
https://bugzilla.redhat.com/show_bug.cgi?id=1151419 Bug ID: 1151419 Summary: Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-String-Compare-ConstantTime/perl-String-Compare-ConstantTime.spec SRPM URL: https://ppisar.fedorapeople.org/perl-String-Compare-ConstantTime/perl-String-Compare-ConstantTime-0.310-1.fc22.src.rpm Description: This module provides one function equals which works like perl's eq, but which does not provide a timing side-channel. Such comparison is useful when matching against a secret string. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags|needinfo?(mru...@redhat.com | |) | --- Comment #3 from Matthias Runge mru...@redhat.com --- http://glyphicons.com/license/ says: ... License for GLYPHICONS Halflings in Twitter Bootstrap GLYPHICONS Halflings are also a part of Bootstrap from Twitter, and they are released under the same license as Bootstrap. While you are not required to include attribution on your Bootstrap-based projects, I would certainly appreciate a visible link back to GLYPHICONS.com in any place you find appropriate (footer, docs, etc). In my understanding, the author appreciates to include a link, but it's not a requirement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Alan Pevec ape...@gmail.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Alan Pevec ape...@gmail.com --- Ok, strings are not attached, it's just a nag to include a link back :) re-approving -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151414] Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1151414 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata psab...@redhat.com --- Okay, looks good. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151419] Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
https://bugzilla.redhat.com/show_bug.cgi?id=1151419 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151419] Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
https://bugzilla.redhat.com/show_bug.cgi?id=1151419 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata psab...@redhat.com --- No blockers, approving. Just add commas around `equals' in your %description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151415] Review Request: perl-Return-MultiLevel - Return across multiple call levels
https://bugzilla.redhat.com/show_bug.cgi?id=1151415 Petr Šabata psab...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148956] Review Request: python-XStatic-Bootstrap-SCSS - Bootstrap-SCSS (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1148956 Matthias Runge mru...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Matthias Runge mru...@redhat.com --- New Package SCM Request === Package Name: python-XStatic-Bootstrap-SCSS Short Description: Bootstrap-SCSS (XStatic packaging standard) Upstream URL: http://getbootstrap.com/ Owners: mrunge Branches: epel7 f20 f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151415] Review Request: perl-Return-MultiLevel - Return across multiple call levels
https://bugzilla.redhat.com/show_bug.cgi?id=1151415 Petr Šabata psab...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Petr Šabata psab...@redhat.com --- I don't think that %perl_default_filter macro is needed. Everything else looks fine. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150512] Review Request: gr-fcdproplus - GNURadio support for FUNcube Dongle Pro+
https://bugzilla.redhat.com/show_bug.cgi?id=1150512 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jaroslav Škarvada jskar...@redhat.com --- New Package SCM Request === Package Name: gr-fcdproplus Short Description: GNURadio support for FUNcube Dongle Pro+ Upstream URL: https://github.com/dl1ksv/gr-fcdproplus Owners: jskarvad Branches: f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150653] Review Request: libosmo-dsp - A library with SDR DSP primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1150653 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-review+ --- Comment #2 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to Dan Horák from comment #1) Thanks for the review. - please run make with V=1 to see compiler command line in logs Will do. The package is APPROVED. According this comment, changig fedora-cvs to ? and fedora-review to +. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150653] Review Request: libosmo-dsp - A library with SDR DSP primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1150653 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from Jaroslav Škarvada jskar...@redhat.com --- New Package SCM Request === Package Name: libosmo-dsp Short Description: libosmo-dsp - A library with SDR DSP primitives Upstream URL: http://cgit.osmocom.org/libosmo-dsp/ Owners: jskarvad Branches: f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149767] Review Request: rubygem-twitter - A Ruby interface to the Twitter API.
https://bugzilla.redhat.com/show_bug.cgi?id=1149767 Marek Mahut mma...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2014-10-10 08:24:33 --- Comment #5 from Marek Mahut mma...@redhat.com --- Closing as this is not needed anymore. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151369] Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1151369 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Petr Pisar ppi...@redhat.com --- New Package SCM Request === Package Name: perl-Crypt-URandom Short Description: Non-blocking randomness for Perl Upstream URL: http://search.cpan.org/dist/Crypt-URandom/ Owners: ppisar jplesnik psabata Branches: epel7 InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150610] Review Request: kalibrate-rtl - GSM based frequency calibration for rtl-sdr
https://bugzilla.redhat.com/show_bug.cgi?id=1150610 --- Comment #2 from Jaroslav Škarvada jskar...@redhat.com --- (In reply to Florian der-flo Lehner from comment #1) Thanks for the review. New version: Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl.spec SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/kalibrate-rtl-0.4.1-2.20141008gitaae11c8a.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151414] Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1151414 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Petr Pisar ppi...@redhat.com --- New Package SCM Request === Package Name: perl-Number-Tolerant Short Description: Tolerance ranges for inexact numbers Upstream URL: http://search.cpan.org/dist/Number-Tolerant/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151419] Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
https://bugzilla.redhat.com/show_bug.cgi?id=1151419 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Petr Pisar ppi...@redhat.com --- New Package SCM Request === Package Name: perl-String-Compare-ConstantTime Short Description: Timing side-channel protected string compare Upstream URL: http://search.cpan.org/dist/String-Compare-ConstantTime/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151456] New: Review Request: libgltf - a library for rendering glTF models
https://bugzilla.redhat.com/show_bug.cgi?id=1151456 Bug ID: 1151456 Summary: Review Request: libgltf - a library for rendering glTF models Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dtar...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://dtardon.fedorapeople.org/rpm/libgltf.spec SRPM URL: https://dtardon.fedorapeople.org/rpm/libgltf-0.0.2-0.fc20.src.rpm Description: libgltf is a library for rendering glTF models -- development glTF, the GL Transmission Format, is the runtime asset format for the GL APIs: WebGL, OpenGL ES, and OpenGL. glTF bridges the gap between formats used by modeling tools and the GL APIs. libgltf provides methods to load the OpenGL scene from glTF format and render it into an existing OpenGL context. libgltf also allows to change the camera position so the scene can be displayed from different points of view. Fedora Account System Username: dtardon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150393] Review Request: tengine - A high performance web server and reverse proxy server
https://bugzilla.redhat.com/show_bug.cgi?id=1150393 --- Comment #5 from Marcela Mašláňová mmasl...@redhat.com --- But still it's questionable. I know why you need it, but it's ugly :-/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151462] New: Review Request: belen - GUI of youtube-dl command - FE-NEEDSPONSOR
https://bugzilla.redhat.com/show_bug.cgi?id=1151462 Bug ID: 1151462 Summary: Review Request: belen - GUI of youtube-dl command - FE-NEEDSPONSOR Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: morel.rique...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://n0oir.fedorapeople.org/belen.spec SRPM URL: https://n0oir.fedorapeople.org/belen-0.1-2.fc21.src.rpm Description: belen is a GUI of youtube-dl command for linux, this is made in Ruby/GTK+3. with this you can download multimedia content (audio,video,playlist) from many sites (ex youtube,vimeo,dailymotion). Now this is my first package to fedora community for the same reason i need a FE-NEEDSPONSOR. Fedora Account System Username: n0oir -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151462] Review Request: belen - GUI of youtube-dl command
https://bugzilla.redhat.com/show_bug.cgi?id=1151462 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Summary|Review Request: belen - GUI |Review Request: belen - GUI |of youtube-dl command -|of youtube-dl command |FE-NEEDSPONSOR | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151464] New: Review Request: ballerburg - Two players, two castles, and a hill in between
https://bugzilla.redhat.com/show_bug.cgi?id=1151464 Bug ID: 1151464 Summary: Review Request: ballerburg - Two players, two castles, and a hill in between Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: musur...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://dl.dropboxusercontent.com/u/12575912/reviews/ballerburg.spec SRPM URL: https://dl.dropboxusercontent.com/u/12575912/reviews/ballerburg-1.1.0-1.fc20.src.rpm Description: Two castles, separated by a mountain, try to defeat each other with their cannonballs, either by killing the opponent's king or by weakening the opponent enough so that the king capitulates. Ballerburg was originally written 1987 by Eckhard Kruse, for the Atari ST machines (which were brand new computers at that point in time). Over 25 years later, here's finally the adaption of the original source code to modern operating systems. Fedora Account System Username: musuruan -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 860424] Review Request: octave-general - General tools for Octave, string dictionary, parallel computing
https://bugzilla.redhat.com/show_bug.cgi?id=860424 Orion Poplawski or...@cora.nwra.com changed: What|Removed |Added Flags|fedora-cvs- |fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 893165] Review Request: mod_qos - Quality of service module for Apache
https://bugzilla.redhat.com/show_bug.cgi?id=893165 Athmane Madjoudj athma...@gmail.com changed: What|Removed |Added CC||athma...@gmail.com Flags|fedora-cvs+ |fedora-cvs? --- Comment #17 from Athmane Madjoudj athma...@gmail.com --- Package Change Request == Package Name: mod_qos New Branches: el5 epel7 Owners: athmane -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135502] Review Request: rubygem-rack-cors - Middleware for enabling Cross-Origin Resource Sharing in Rack apps
https://bugzilla.redhat.com/show_bug.cgi?id=1135502
Ken Dreyer ktdre...@ktdreyer.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com ---
Package APPROVED. No blocking issues, just two suggestions:
1. The URL can be HTTPS.
2. When you change the files in the test suite, I recommend putting a comment
already fixed upstream in 9851d59089971e9a1c28a6b68e3b9359f7005535 so it is
clear to future maintainers that this sort of patching doesn't need to be
submitted upstream. I find this just makes communication a bit easier.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[-]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
[x]: Packages must not store files under /srv, /opt or /usr/local
Ruby:
[x]: Platform dependent files must all go under %{gem_extdir_mri}, platform
independent under %{gem_dir}.
[x]: Gem package must not define a non-gem subpackage
[x]: Macro %{gem_extdir} is deprecated.
[x]: Gem package is named rubygem-%{gem_name}
[x]: Package contains BuildRequires: rubygems-devel.
[x]: Gem package must define %{gem_name} macro.
[x]: Pure Ruby package must be built as noarch
[x]: Package does not contain Requires: ruby(abi).
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Avoid bundling fonts in non-fonts packages.
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if
[Bug 1151464] Review Request: ballerburg - Two players, two castles, and a hill in between
https://bugzilla.redhat.com/show_bug.cgi?id=1151464
Raphael Groner projects...@smart.ms changed:
What|Removed |Added
CC||projects...@smart.ms
--- Comment #1 from Raphael Groner projects...@smart.ms ---
Only some hints as a manually informal review:
%install
rm -rf %{buildroot}
Removal of %{buildroot} is no longer necessary, except for EPEL 5.
- Do you plan to provide an EPEL package?
# Install additional docs
install -p -m 644 COPYING.txt LIESMICH.txt README.txt doc/authors.txt \
%{buildroot}%{_pkgdocdir}
This is not needed and should be handled in %files section with the %doc tag:
%files
%doc COPYING.txt LIESMICH.txt README.txt doc/authors.txt
convert -gravity south \
…
I don't understand. Why do you manipulate the icons so much? You should put a
comment in the spec file why that is necessary. Ask upstream why the icons are
not provided in the tarball, may there be any legal reasons? Be careful with
additional or legal questionable content cause Fedora does only allow free
stuff:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Content_Licenses
There are two patches available at upstream, committed after the 1.1.0 release:
fullscreen fix and SDL2 usage. Maybe consider to include them.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132008] Review Request: rubygem-openssl_cms - OpenSSL with CMS functions
https://bugzilla.redhat.com/show_bug.cgi?id=1132008 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- rubygem-openssl_cms-0.0.2-2.20140212gitb789b69.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146917] Review Request: parsero - A Python based Robots.txt audit tool
https://bugzilla.redhat.com/show_bug.cgi?id=1146917 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- parsero-0.81-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1144466] Review Request: rubygem-apipie-bindings - The Ruby bindings for Apipie documented APIs
https://bugzilla.redhat.com/show_bug.cgi?id=1144466 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||rubygem-apipie-bindings-0.0 ||.10-2.fc21 Resolution|--- |ERRATA Last Closed||2014-10-10 12:00:53 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- rubygem-apipie-bindings-0.0.10-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1096809] Review Request: mingw-SDL2_mixer - MinGW Windows port of Simple DirectMedia Layer's Sample Mixer Library
https://bugzilla.redhat.com/show_bug.cgi?id=1096809 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mingw-SDL2_mixer-2.0.0-3.fc ||20 Resolution|--- |ERRATA Last Closed||2014-10-10 12:01:16 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- mingw-SDL2_mixer-2.0.0-3.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146927] Review Request: python-drat - A reading text analysis tool
https://bugzilla.redhat.com/show_bug.cgi?id=1146927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-drat-0.4.1-1.fc21 Resolution|--- |ERRATA Last Closed||2014-10-10 12:01:37 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-drat-0.4.1-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151464] Review Request: ballerburg - Two players, two castles, and a hill in between
https://bugzilla.redhat.com/show_bug.cgi?id=1151464 Christian Dersch chrisder...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||chrisder...@gmail.com Assignee|nob...@fedoraproject.org|chrisder...@gmail.com Flags||fedora-review? --- Comment #2 from Christian Dersch chrisder...@gmail.com --- Assigned, will have to look at it at the weekend :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149423] Review Request: gnurobbo - Port of the once famous ATARI game Robbo
https://bugzilla.redhat.com/show_bug.cgi?id=1149423 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- gnurobbo-0.66-1.20141005svn412.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1135430] Review Request: python-XStatic-jquery-ui - jquery-ui (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1135430 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-XStatic-jquery-ui-1. |python-XStatic-jquery-ui-1. |10.4.1-1.el7|10.4.1-1.fc20 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-XStatic-jquery-ui-1.10.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062757] Review Request: glite-lb-logger-msg - Plugin for sending LB notifications to messaging infrastructure
https://bugzilla.redhat.com/show_bug.cgi?id=1062757 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||glite-lb-logger-msg-1.2.13- ||2.fc21 Resolution|--- |ERRATA Last Closed||2014-10-10 12:03:01 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- glite-lb-logger-msg-1.2.13-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115709] Review Request: nodejs-w3cjs - A node.js module for using the w3c validator
https://bugzilla.redhat.com/show_bug.cgi?id=1115709 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version||nodejs-w3cjs-0.1.25-3.fc20 Resolution|RAWHIDE |ERRATA --- Comment #18 from Fedora Update System upda...@fedoraproject.org --- nodejs-w3cjs-0.1.25-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150090] Review Request: python-quantities - Support for physical quantities with units, based on numpy
https://bugzilla.redhat.com/show_bug.cgi?id=1150090 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc21, python-quantities-0.10.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150067] Review Request: python-lazyarray - A lazily-evaluated numerical array class
https://bugzilla.redhat.com/show_bug.cgi?id=1150067 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- python-lazyarray-0.2.7-3.fc21, python-quantities-0.10.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149641] Review Request: xcat - A command line tool to explore blind XPath injection vulnerabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1149641 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System upda...@fedoraproject.org --- xcat-0.7.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150121] Review Request: perl-Module-Build-XSUtil - A Module::Build class for building XS modules
https://bugzilla.redhat.com/show_bug.cgi?id=1150121 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- perl-Module-Build-XSUtil-0.14-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146930] Review Request: python-cpuinfo - Getting CPU info
https://bugzilla.redhat.com/show_bug.cgi?id=1146930 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-cpuinfo-0.1.2-2.fc21 Resolution|--- |ERRATA Last Closed||2014-10-10 12:06:50 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-cpuinfo-0.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115709] Review Request: nodejs-w3cjs - A node.js module for using the w3c validator
https://bugzilla.redhat.com/show_bug.cgi?id=1115709 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|nodejs-w3cjs-0.1.25-3.fc20 |nodejs-w3cjs-0.1.25-3.fc19 --- Comment #19 from Fedora Update System upda...@fedoraproject.org --- nodejs-w3cjs-0.1.25-3.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146935] Review Request: nodejs-filed - Simplified file library
https://bugzilla.redhat.com/show_bug.cgi?id=1146935 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-filed-0.1.0-2.fc21 Resolution|--- |ERRATA Last Closed||2014-10-10 12:08:30 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- nodejs-filed-0.1.0-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1146927] Review Request: python-drat - A reading text analysis tool
https://bugzilla.redhat.com/show_bug.cgi?id=1146927 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-drat-0.4.1-1.fc21|python-drat-0.4.1-1.fc20 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- python-drat-0.4.1-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119369] Review Request: speedtest-cli - Command line interface for testing internet bandwidth
https://bugzilla.redhat.com/show_bug.cgi?id=1119369 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||speedtest-cli-0.3.0-1.fc20 Resolution|--- |ERRATA Last Closed||2014-10-10 12:09:49 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- speedtest-cli-0.3.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1134343] Review Request: perl-Digest-SHA3 - Perl extension for SHA-3
https://bugzilla.redhat.com/show_bug.cgi?id=1134343 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|perl-Digest-SHA3-0.22-1.fc2 |perl-Digest-SHA3-0.22-1.fc2 |1 |0 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- perl-Digest-SHA3-0.22-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1100477] Review Request: python-natsort - Python library that sorts lists using the natural order sort
https://bugzilla.redhat.com/show_bug.cgi?id=1100477 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Fixed In Version|python-natsort-3.5.1-1.fc21 |python-natsort-3.5.1-1.fc20 --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- python-natsort-3.5.1-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150610] Review Request: kalibrate-rtl - GSM based frequency calibration for rtl-sdr
https://bugzilla.redhat.com/show_bug.cgi?id=1150610 Florian der-flo Lehner d...@der-flo.net changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Florian der-flo Lehner d...@der-flo.net --- hi! It looks fine, so I approve it. Cheers, Flo For the records: http://koji.fedoraproject.org/koji/taskinfo?taskID=7822770 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150762] Review Request: python-xcffib - A drop in replacement for xpyb, an XCB python binding
https://bugzilla.redhat.com/show_bug.cgi?id=1150762 Adam Miller admil...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Adam Miller admil...@redhat.com --- [X]: Package must own all directories that it creates. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114413] Review Request: python-flask-cors - Flask extension to support cross origin resource sharing
https://bugzilla.redhat.com/show_bug.cgi?id=1114413 --- Comment #5 from Lokesh Mandvekar l...@fedoraproject.org --- Tom, sorry about the delay. %changelog * Fri Oct 10 2014 Lokesh Mandvekar l...@fedoraproject.org - 1.9.0-1 - update to 1.9.0 - correct license - trim down BR list Latest koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7823387 Spec URL: https://lsm5.fedorapeople.org/python-flask-cors/python-flask-cors.spec SRPM URL: https://lsm5.fedorapeople.org/python-flask-cors/SRPMS/python-flask-cors-1.9.0-1.fc22.src.rpm I'll check with upstream about _version.py or perhaps we could install in a non-standard location -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117025] Review Request: rubygem-joiner - Builds ActiveRecord joins from association paths
https://bugzilla.redhat.com/show_bug.cgi?id=1117025
--- Comment #2 from Ken Dreyer ktdre...@ktdreyer.com ---
(In reply to František Dvořák from comment #1)
Issues or changes for consideration:
1) new version of joiner is available (0.3.3)
Thanks, I've updated the gem to 0.3.3.
* Fri Oct 10 2014 Ken Dreyer ktdre...@ktdreyer.com - 0.3.3-1
- Update to joiner 0.3.3 (RHBZ #1117025)
- Use %%license macro (RHBZ #1117025)
Spec URL: http://ktdreyer.fedorapeople.org/reviews/rubygem-joiner.spec
SRPM URL:
http://ktdreyer.fedorapeople.org/reviews/rubygem-joiner-0.3.3-1.fc22.src.rpm
Exact changes in Git:
https://fedorapeople.org/cgit/ktdreyer/public_git/rubygem-joiner.git/commit/?id=8f874b22823e7912fd2ed550810be24213c48c69
F22 scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7825913
2) (cosmetic) you can consider using unified way of excluding files
(replacing rm .%{gem_instdir}/%{gem_name}.gemspec by %exclude macro?)
In the case of rm %{gem_name}.gemspec, I consider that to be a bug in the
upstream project. I don't see a point to shipping the gemspec file in the gem
itself. Plenty of gems avoid doing this (eg rugged). See
https://lists.fedoraproject.org/pipermail/ruby-sig/2013-December/001471.html
for a discussion on this (that unfortunately didn't reach resolution.)
3) (cosmetic) you can consider using %license macro for license file
Thanks for pointing this out. When this guideline first came out I didn't see a
backwards-compatible way to introduce this, but after reading
https://fedorahosted.org/fpc/ticket/411#comment:11 I see there is an easy
solution for backwards compatibility. I've changed this in my package.
4) (future work) I think combustion gem requires bundler. Removing bundler
from spec_helper.rb may break things, or there will be needed some way of
disabling bundler in combustion?
But it is not used now anyway, so it is not needed neither for build nor
passing the review. :-)
Yeah, I'm typically able to strip out Bundler where possible. I'll be sure to
check if we need to do that with combustion.
5) (question) there is not used require 'active_record' anywere in joiner
sources, but I guess it's OK (developers using joiner will require rails or
activerecord anyway?)
Interesting, I guess upstream thinks it's fine to just require it in the
gemspec and not in the actual library.
In the RPM case, since we Require: rubygem(activerecord) I think it's ok, but
your point is valid that upstream probably needs to think about the non-Bundler
case.
When you were testing in your chroot, did rubygem-activerecord get installed
there? Or did you install the package with --nodeps? It's weird that it would
break like that for you, since the dependency is in the RPM.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151464] Review Request: ballerburg - Two players, two castles, and a hill in between
https://bugzilla.redhat.com/show_bug.cgi?id=1151464
--- Comment #3 from Andrea Musuruane musur...@gmail.com ---
(In reply to Raphael Groner from comment #1)
%install
rm -rf %{buildroot}
Removal of %{buildroot} is no longer necessary, except for EPEL 5.
- Do you plan to provide an EPEL package?
Good catch. It's a leftover. Removed.
# Install additional docs
install -p -m 644 COPYING.txt LIESMICH.txt README.txt doc/authors.txt \
%{buildroot}%{_pkgdocdir}
This is not needed and should be handled in %files section with the %doc tag:
%files
%doc COPYING.txt LIESMICH.txt README.txt doc/authors.txt
If I did that on older version of rpm, I would have wiped out the doc already
installed by make install.
convert -gravity south \
…
I don't understand. Why do you manipulate the icons so much? You should put
a comment in the spec file why that is necessary.
So much? The original image is not a square, but the desktop icon are.
Therefore I resize the image using the same aspect ratio and putting a white
background at the top.
Ask upstream why the icons
are not provided in the tarball, may there be any legal reasons? Be careful
with additional or legal questionable content cause Fedora does only allow
free stuff:
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Content_Licenses
Why upstream should ship an icon when they do not ship a desktop file?
This package is perfectly legal. Ballerburg was released for Atari ST in Public
Domain:
http://www.eckhardkruse.net/atari_st/baller.html?en
This is a port for Linux based on that source code.
There are two patches available at upstream, committed after the 1.1.0
release: fullscreen fix and SDL2 usage. Maybe consider to include them.
Fullscreen mode already works - just press F to test it.
The RPM is not linked against SDL2 but against SDL 1.2 therefore the patch is
useless.
Spec URL:
https://dl.dropboxusercontent.com/u/12575912/reviews/ballerburg.spec
SRPM URL:
https://dl.dropboxusercontent.com/u/12575912/reviews/ballerburg-1.1.0-2.fc20.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 421241] Review Request: php-ZendFramework - Leading open-source PHP framework
https://bugzilla.redhat.com/show_bug.cgi?id=421241 Felix Kaechele fe...@fetzig.org changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #60 from Felix Kaechele fe...@fetzig.org --- Package Change Request == Package Name: php-ZendFramework New Branches: el7 Owners: heffer -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151635] New: Review Request: torbrowser-launcher - Tor Browser Bundle managing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1151635 Bug ID: 1151635 Summary: Review Request: torbrowser-launcher - Tor Browser Bundle managing tool Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: robyd...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://robyduck.fedorapeople.org/packages/SPECS/torbrowser-launcher.spec SRPM URL: https://robyduck.fedorapeople.org/packages/SRPMS/torbrowser-launcher-0.1.5-1.fc20.src.rpm Description: Tor Browser Launcher is intended to make the Tor Browser Bundle (TBB) easier to maintain and use for GNU/Linux users. You install torbrowser-launcher from your distribution's package manager and it handles everything else, including: * Downloading the most recent version of TBB for you, in your language and for your architecture * Automatically updating (while preserving your bookmarks and preferences) * Verifying the TBB's GnuPG signature * Includes AppArmor profiles to make a Tor Browser compromise not as bad * Adding a Tor Browser application launcher to your desktop environment's menu Fedora Account System Username: robyduck -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1117025] Review Request: rubygem-joiner - Builds ActiveRecord joins from association paths
https://bugzilla.redhat.com/show_bug.cgi?id=1117025 --- Comment #3 from František Dvořák val...@civ.zcu.cz --- (In reply to Ken Dreyer from comment #2) 5) (question) there is not used require 'active_record' anywere in joiner sources, but I guess it's OK (developers using joiner will require rails or activerecord anyway?) Interesting, I guess upstream thinks it's fine to just require it in the gemspec and not in the actual library. In the RPM case, since we Require: rubygem(activerecord) I think it's ok, but your point is valid that upstream probably needs to think about the non-Bundler case. When you were testing in your chroot, did rubygem-activerecord get installed there? Or did you install the package with --nodeps? It's weird that it would break like that for you, since the dependency is in the RPM. Yes, rubygem-activerecord were installed (with the rubygem-rails). The command: ruby -e require 'active_record'; require 'joiner' works fine. It is not problem with packaging, and using ActiveRecord already is probably expected. Anyway, package can be approved. I'll create the final report yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
