[Bug 1147149] Review Request: python-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1147149 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- python-cryptography-vectors-0.5.4-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-cryptography-vectors-0.5.4-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151711] Review Request: liblxqt - Core LXQT library
https://bugzilla.redhat.com/show_bug.cgi?id=1151711 Eugene A. Pivnev ti.eug...@gmail.com changed: What|Removed |Added Summary|Review Request: lxqt-libs - |Review Request: liblxqt - |Core LXQT library |Core LXQT library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147149] Review Request: python-cryptography-vectors - Test vectors for the cryptography package
https://bugzilla.redhat.com/show_bug.cgi?id=1147149 --- Comment #14 from Fedora Update System upda...@fedoraproject.org --- python-cryptography-vectors-0.5.4-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-cryptography-vectors-0.5.4-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151711] Review Request: liblxqt - Core LXQT library
https://bugzilla.redhat.com/show_bug.cgi?id=1151711 Eugene A. Pivnev ti.eug...@gmail.com changed: What|Removed |Added Alias|lxqt-libs |liblxqt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151711] Review Request: liblxqt - Core LXQT library
https://bugzilla.redhat.com/show_bug.cgi?id=1151711 --- Comment #9 from Eugene A. Pivnev ti.eug...@gmail.com --- (In reply to Ralf Corsepius from comment #1) Package does not comply to Fedora's packaging conventions to name a package after it's tarname = This package should be named liblxqt Spec URL: https://tieugene.fedorapeople.org/rpms/liblxqt/liblxqt.spec SRPM URL: https://tieugene.fedorapeople.org/rpms/liblxqt/liblxqt-0.7.0-1.src.rpm Koji build (f21): http://koji.fedoraproject.org/koji/taskinfo?taskID=7879723 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151635] Review Request: torbrowser-launcher - Tor Browser Bundle managing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1151635 --- Comment #5 from pjp pj.pan...@yahoo.co.in --- Hello Robert, I've torbrowser-launcher.noarch 0:0.1.5-3.fc19 installed. Today when I invoked it, it upgraded TBB from 3.6.6 - 4.0 _without_ preserving browser history open tabs from 3.6.6. Second, upon each invocation of torbrowser-launcher it seems to download and install TBB 4.0. It shows === $ torbrowser-launcher ... Starting launcher dialog LATEST VERSION 4.0 Checked for update within 24 hours, skipping TBB is out of date, attempting to upgrade to 4.0 ... === closer look at the .local/share/torbrowser/tbb/x86_64/tor-browser_en-US/Docs/sources/versions still shows TORBROWSER_VERSION=3.6.6 instead of 4.0; Probably that is why it downloads TBB-4.0 each time. If I did not have an old instance of TBB-3.6.5 in a separate directory, I would have lost all browser history and open tabs, with no way to recover them. This is severe. Could you please ping upstream about it? Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151635] Review Request: torbrowser-launcher - Tor Browser Bundle managing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1151635 --- Comment #6 from Robert Mayr robyd...@gmail.com --- Ok, thank you. I will try it too, probably there are some changes when updating to 4.x. It seemd to work fino for updates from 3.6.x to 3.6.y... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153302] Review Request: tilda - A Gtk based drop down terminal for Linux and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1153302 --- Comment #2 from hannes johannes.l...@googlemail.com --- There was a new release yesterday. I will update it tonight and will provide an updated spec and src.rpm. Johannes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 905240] Review Request: rubygem-log4r - Comprehensive and flexible logging library for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=905240 Vít Ondruch vondr...@redhat.com changed: What|Removed |Added CC||vondr...@redhat.com --- Comment #15 from Vít Ondruch vondr...@redhat.com --- I just noticed that 1.11 is introducing breaking changes: https://github.com/colbygk/log4r/issues/26 https://github.com/colbygk/log4r/issues/24 And it was yanked on rubygems.org: http://rubygems.org/gems/log4r/versions https://github.com/colbygk/log4r/issues/26#issuecomment-31622574 Could you please revert back to 1.10 until this gets resolved? Thanks. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666
--- Comment #1 from Jan Synacek jsyna...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package contains BR: python2-devel or python3-devel
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
Note: Using prebuilt packages
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
GPL (v3 or later), Unknown or generated. 7 files have unknown
license. Detailed output of licensecheck in /home/jsynacek/work/reviews
/gr-iqbal/review-gr-iqbal/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gnuradio,
/usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[ ]: Python eggs must not download any dependencies during the build process.
[ ]: A package which is used by another package via an egg interface should
provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[ ]: If the source package does not
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666
--- Comment #2 from Jan Synacek jsyna...@redhat.com ---
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
Swig wrapper libraries, I don't see a problem with that.
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gnuradio,
/usr/share/gnuradio/grc, /usr/share/gnuradio/grc/blocks
These are owned by gnuradio, which is required for this package.
[!]: Reviewer should test that the package builds in mock.
It builds. I've built the package myself, because one of the required
libraries wasn't available in the rawhide build root (it's built
properly though, just not propagated yet).
[ ]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gr-iqbal-
devel , gr-iqbal-doc
ACTION REQUIRED: Please, add %{?_isa} to the devel subpackage.
Rpmlint
---
Checking: gr-iqbal-0.37.2-1.fc22.x86_64.rpm
gr-iqbal-devel-0.37.2-1.fc22.x86_64.rpm
gr-iqbal-doc-0.37.2-1.fc22.noarch.rpm
gr-iqbal-0.37.2-1.fc20.src.rpm
gr-iqbal-devel.x86_64: W: only-non-binary-in-usr-lib
gr-iqbal-devel.x86_64: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 2 warnings.
No problem, the first warning is a known bug.
Unversioned so-files
gr-iqbal:
/usr/lib64/python2.7/site-packages/gnuradio/iqbalance/_iqbalance_swig.so
Swig wrappers, no problem.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151635] Review Request: torbrowser-launcher - Tor Browser Bundle managing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1151635 --- Comment #7 from Robert Mayr robyd...@gmail.com --- I'm not able to reproduce the issue, works fine here on F20: == $ torbrowser-launcher Tor Browser Launcher By Micah Lee, licensed under MIT version 0.1.5 https://github.com/micahflee/torbrowser-launcher Initializing Tor Browser Launcher Successfully loaded mirrors from /usr/share/torbrowser-launcher/mirrors.txt ... Starting launcher dialog LATEST VERSION 4.0 Checked for update within 24 hours, skipping Latest version of TBB is installed, launching Launching Tor Browser for Linux == -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #3 from Jaroslav Škarvada jskar...@redhat.com --- Thanks for the review, updated version: Spec URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-iqbal.spec SRPM URL: https://fedorapeople.org/~jskarvad/gnuradio/gr-iqbal-0.37.2-2.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653
--- Comment #5 from Petr Pisar ppi...@redhat.com ---
(In reply to Scott Talbert from comment #3)
A few initial comments.
Release:0.1.%{miniz_rc}%{?dist}
I'm thinking this should just be 1.%{miniz_rc}%{?dist} since this is a
post-release (ie, 1.15r4 came after 1.15) rather than a pre-release. See
here:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
I thought this is a release-candidate, i.e. a pre-release. There is no 1.15
listed on the download page. And the changelog in the header file lists 1.15
after 1.15r4.
gcc %{?__global_ldflags} -fPIC -shared %{name}.o -o lib%{name}.so
I'm wondering if we should be adding soname versioning? It doesn't seem
like upstream is changing much but it seems like it might be good to have.
I do not think this is good idea because SONAME is part of ABI. Having Fedora
specific ABI is not good. I know this code is a library nowhere now, but that
could change in the future. I want to keep the differences as little as
possible.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jan Synacek jsyna...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Jan Synacek jsyna...@redhat.com --- I don't see any more problems, approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151462] Review Request: belen - GUI of youtube-dl command
https://bugzilla.redhat.com/show_bug.cgi?id=1151462
--- Comment #11 from Carlos Morel-Riquelme morel.rique...@gmail.com ---
Hi Parag, i hope that you are fine , i have new files
new SPEC https://n0oir.fedorapeople.org/belen.spec
new SRPM https://n0oir.fedorapeople.org/belen-0.1-4.fc21.src.rpm
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
LGPL (v3 or later). Detailed output of licensecheck in
/home/n0oir/review/review-belen/licensecheck.txt
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 1 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[ ]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Jaroslav Škarvada jskar...@redhat.com --- New Package SCM Request === Package Name: gr-iqbal Short Description: GNURadio block for suppressing IQ imbalance Upstream URL: http://cgit.osmocom.org/gr-iqbal/ Owners: jskarvad Branches: f20 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226209] Merge Review: nut
https://bugzilla.redhat.com/show_bug.cgi?id=226209 Vitezslav Crhonek vcrho...@redhat.com changed: What|Removed |Added Flags||needinfo?(mhlavink@redhat.c ||om) --- Comment #11 from Vitezslav Crhonek vcrho...@redhat.com --- I agree with your changes and explanations. However, I see commit 4a8e9a8d14e23b1978e8cbca77da3f661924d3d3 (spec cleanup) in master branch, but it just removes nut-2.6.5-ipmifix.patch, no changes to the spec file. The package cannot be built now... You probably didn't commit spec file changes by mistake? -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152047] Review Request: jenkins-matrix-project-plugin - Jenkins Matrix Project Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1152047 --- Comment #5 from Fedora Update System upda...@fedoraproject.org --- jenkins-matrix-project-plugin-1.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/jenkins-matrix-project-plugin-1.3-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152047] Review Request: jenkins-matrix-project-plugin - Jenkins Matrix Project Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1152047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152057] Review Request: csnappy - Snappy compression library ported to C
https://bugzilla.redhat.com/show_bug.cgi?id=1152057 --- Comment #4 from Petr Pisar ppi...@redhat.com --- I see. Thanks. I think that the guidelines forgets that the licenses require to distribute not only license text, but also copyright notice. So I added a script into the spec file which gathers the data and put them into LICENSE file. Updated SPEC and SRPM files are on the same addresses. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832353] Review Request: perl-Net-Dropbox-API - A dropbox API interface
https://bugzilla.redhat.com/show_bug.cgi?id=832353 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Robin Lee robinlee.s...@gmail.com --- Package Change Request == Package Name: perl-Net-Dropbox-API New Branches: el6 epel7 Owners: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847435] Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers
https://bugzilla.redhat.com/show_bug.cgi?id=847435 Robin Lee robinlee.s...@gmail.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #7 from Robin Lee robinlee.s...@gmail.com --- Package Change Request == Package Name: perl-X11-Protocol-Other New Branches: el6 epel7 Owners: cheeselee -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1080203] Review Request: perl-Excel-Template-Plus - An extension to the Excel::Template module
https://bugzilla.redhat.com/show_bug.cgi?id=1080203 --- Comment #7 from Sven Nierlein sven.nierl...@consol.de --- thanks for your detailed remarks. I will take care of them after my vacation, so don't expect any update soon. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832353] Review Request: perl-Net-Dropbox-API - A dropbox API interface
https://bugzilla.redhat.com/show_bug.cgi?id=832353 --- Comment #10 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 832353] Review Request: perl-Net-Dropbox-API - A dropbox API interface
https://bugzilla.redhat.com/show_bug.cgi?id=832353 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847435] Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers
https://bugzilla.redhat.com/show_bug.cgi?id=847435 --- Comment #8 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 847435] Review Request: perl-X11-Protocol-Other - Miscellaneous X11::Protocol helpers
https://bugzilla.redhat.com/show_bug.cgi?id=847435 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996780] Rename Request: python-astroid - Python Abstract Syntax Tree New Generation
https://bugzilla.redhat.com/show_bug.cgi?id=996780 --- Comment #18 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 996780] Rename Request: python-astroid - Python Abstract Syntax Tree New Generation
https://bugzilla.redhat.com/show_bug.cgi?id=996780 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 --- Comment #6 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153636] New: Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format
https://bugzilla.redhat.com/show_bug.cgi?id=1153636 Bug ID: 1153636 Summary: Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Sereal-Decoder/perl-Sereal-Decoder.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Sereal-Decoder/perl-Sereal-Decoder-3.002-1.fc22.src.rpm Description: This library implements a deserializer for an efficient, compact-output, and feature-rich binary protocol called Sereal. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153636] Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format
https://bugzilla.redhat.com/show_bug.cgi?id=1153636 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Depends On||1152057, 1152653 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1152057 [Bug 1152057] Review Request: csnappy - Snappy compression library ported to C https://bugzilla.redhat.com/show_bug.cgi?id=1152653 [Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152057] Review Request: csnappy - Snappy compression library ported to C
https://bugzilla.redhat.com/show_bug.cgi?id=1152057 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153636 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153636 [Bug 1153636] Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153636 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153636 [Bug 1153636] Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150666] Review Request: gr-iqbal - GNURadio block for suppressing IQ imbalance
https://bugzilla.redhat.com/show_bug.cgi?id=1150666 Jaroslav Škarvada jskar...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-10-16 07:58:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1062315] Review Request: xorg-x11-drv-fbturbo - Xorg X11 fbturbo video driver
https://bugzilla.redhat.com/show_bug.cgi?id=1062315 --- Comment #16 from Hans de Goede hdego...@redhat.com --- (In reply to Parag AN(पराग) from comment #15) any updates here? Martin no longer is with Red Hat, so his bugzilla email address no longer works. So unless we can find someone to take this review request over this review request should probably be closed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653
--- Comment #6 from Scott Talbert s...@techie.net ---
(In reply to Petr Pisar from comment #5)
Release:0.1.%{miniz_rc}%{?dist}
I'm thinking this should just be 1.%{miniz_rc}%{?dist} since this is a
post-release (ie, 1.15r4 came after 1.15) rather than a pre-release. See
here:
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
I thought this is a release-candidate, i.e. a pre-release. There is no 1.15
listed on the download page. And the changelog in the header file lists 1.15
after 1.15r4.
I am pretty sure it is a post-release. If you go look at the SVN revision
history, in r61 he originally had 1.15 but then he changes it to r3. So I
think the r's are post-release.
gcc %{?__global_ldflags} -fPIC -shared %{name}.o -o lib%{name}.so
I'm wondering if we should be adding soname versioning? It doesn't seem
like upstream is changing much but it seems like it might be good to have.
I do not think this is good idea because SONAME is part of ABI. Having
Fedora specific ABI is not good. I know this code is a library nowhere now,
but that could change in the future. I want to keep the differences as
little as possible.
I had thought FPC had put something out on this but it looks like it is still
draft:
https://fedorahosted.org/fpc/ticket/405
https://fedoraproject.org/wiki/User:Jstanek/Draft_-_Downstream_.so_name_versioning
So at the very least we should probably try to convince upstream to start
versioning.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1148529] Review Request: python-flask-rstpages - Adds support for reStructuredText to a Flask application
https://bugzilla.redhat.com/show_bug.cgi?id=1148529 Richard Marko rma...@redhat.com changed: What|Removed |Added CC||rma...@redhat.com --- Comment #3 from Richard Marko rma...@redhat.com --- Thank you both. Updated: Spec URL: https://rmarko.fedorapeople.org/packages/python-flask-rstpages.spec SRPM URL: https://rmarko.fedorapeople.org/packages/python-flask-rstpages-0.3-2.fc20.src.rpm Diff of the spec files: https://rmarko.fedorapeople.org/packages/python-flask-rstpages.diff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 226209] Merge Review: nut
https://bugzilla.redhat.com/show_bug.cgi?id=226209 Michal Hlavinka mhlav...@redhat.com changed: What|Removed |Added Flags|needinfo?(mhlavink@redhat.c | |om) | --- Comment #12 from Michal Hlavinka mhlav...@redhat.com --- fixed -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653 --- Comment #7 from Petr Pisar ppi...@redhat.com --- I will change the release value to the post-release schema. I asked upstream to version the library when he decides to support building a shared library. https://code.google.com/p/miniz/issues/detail?id=7#c5. Provided the request for shared library is two years old, Fedora can go on a insert it's own SONAME. I will add one. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653 --- Comment #8 from Petr Pisar ppi...@redhat.com --- Updated package: SPEC: https://ppisar.fedorapeople.org/miniz/miniz.spec SRPM: https://ppisar.fedorapeople.org/miniz/miniz-1.15-1.r4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153698] New: Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity
https://bugzilla.redhat.com/show_bug.cgi?id=1153698 Bug ID: 1153698 Summary: Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Session-Storage-Secure/perl-Session-Storage-Secure.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Session-Storage-Secure/perl-Session-Storage-Secure-0.010-1.fc22.src.rpm Description: This module implements a secure way to encode session data. It is primarily intended for storing session data in browser cookies, but could be used with other back-end storage where security of stored session data is important. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151414] Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1151414 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153698 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153698 [Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153074] Review Request: perl-Sereal-Encoder - Perl serialization into Serial format
https://bugzilla.redhat.com/show_bug.cgi?id=1153074 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153698 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153698 [Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151369] Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl
https://bugzilla.redhat.com/show_bug.cgi?id=1151369 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153698 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153698 [Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity
https://bugzilla.redhat.com/show_bug.cgi?id=1153698 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Depends On||1153074, 1153636, 1151419, ||1151369, 1151414 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1151369 [Bug 1151369] Review Request: perl-Crypt-URandom - Non-blocking randomness for Perl https://bugzilla.redhat.com/show_bug.cgi?id=1151414 [Bug 1151414] Review Request: perl-Number-Tolerant - Tolerance ranges for inexact numbers https://bugzilla.redhat.com/show_bug.cgi?id=1151419 [Bug 1151419] Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare https://bugzilla.redhat.com/show_bug.cgi?id=1153074 [Bug 1153074] Review Request: perl-Sereal-Encoder - Perl serialization into Serial format https://bugzilla.redhat.com/show_bug.cgi?id=1153636 [Bug 1153636] Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153636] Review Request: perl-Sereal-Decoder - Perl deserialization for Sereal format
https://bugzilla.redhat.com/show_bug.cgi?id=1153636 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153698 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153698 [Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151419] Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
https://bugzilla.redhat.com/show_bug.cgi?id=1151419 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1153698 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1153698 [Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153698] Review Request: perl-Session-Storage-Secure - Encrypted, expiring, compressed, serialized session data with integrity
https://bugzilla.redhat.com/show_bug.cgi?id=1153698 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1144342 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1144342 [Bug 1144342] perl-Dancer-Session-Cookie-0.25 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653
--- Comment #9 from Scott Talbert s...@techie.net ---
gcc %{?__global_ldflags} -fPIC -shared -Wl,-soname,%{soname} \
%{name}.o -o lib%{name}.so.0.1
One nit, I think you could use your soname global on the 2nd line here.
The only other issue from the package review is the precompiled binaries in the
source bundle. I'm not sure why it matters, since it is clear they aren't
going into the RPM, but the guidelines state they must be removed in %prep.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653 --- Comment #10 from Petr Pisar ppi...@redhat.com --- Updated package is on the same URL. I kept the soname definition at the place to make it clear it's used not only in %build section. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149566] Review Request: slurm - Simple LinUx Resource Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1149566 --- Comment #6 from David Brown david.br...@pnnl.gov --- Yup further investigation seems like the rpmlint stuff didn't find those lines but they are there in the init scripts... I'll have to look at the guidelines for what a SYSV init script is supposed to look like. The ibmad and ibumad stuff is enabled in the build and the %if 0 thing was removed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152653] Review Request: miniz - Compression library implementing the zlib and Deflate
https://bugzilla.redhat.com/show_bug.cgi?id=1152653
Scott Talbert s...@techie.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #11 from Scott Talbert s...@techie.net ---
My suggestion was to replace:
%{name}.o -o lib%{name}.so.0.1
with
%{name}.o -o %{soname}
But that is a nit.
Package looks good to me, approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1149649] Review Request: tuxfootball - funny soccer game
https://bugzilla.redhat.com/show_bug.cgi?id=1149649
Andrea Musuruane musur...@gmail.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||musur...@gmail.com
Assignee|nob...@fedoraproject.org|musur...@gmail.com
Flags||fedora-review?
--- Comment #1 from Andrea Musuruane musur...@gmail.com ---
Correct SRPM URL seem to be:
https://raphgro.fedorapeople.org/review/tuxfootball/tuxfootball-0.3.1-0.1.fc20.src.rpm
I'm using this one to perform the review.
Release tag is wrong. You are using a pre-release tag but tuxfootball-0.3.1 has
been released.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag
Better, more descriptive, summary: Great 2D soccer (sometimes called football)
game
License is wrong. It is GPLv2+ (note the +) not GPLv2.
Source0 URL is wrong. It should be:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
https://fedoraproject.org/wiki/Packaging:SourceURL#Sourceforge.net
In this way you can get rid of the %{ver} macro.
Guidelines require to Requires: a package when you install a file into a
directory that the package does not own. You install icons into
/usr/share/icons/hicolor and therefore you MUST Requires: hicolor-icon-theme.
https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Ownership
You must use trademarks in a way that is not ambiguous. Avoid phrasing like
similar to or like. Therefore avoid using Amco's Kick Off and Sensible
Software's Sensible Soccer in description.
https://fedoraproject.org/wiki/Packaging:Guidelines#summary
You can improve the description adding:
The gameplay is designed to be quick, responsive and fun. You are always
in control of the player closest to the ball. The ball is controlled via
two different kick buttons - one for pass, and one for shoot. Aftertouch
can be applied to shots by quickly pressing and holding the direction you
want the ball to bend towards. Pushing in the opposite direction to what
you kicked the ball makes it raise into the air, pushing in the same
direction as the ball makes it dip towards the ground.
You MUST use scriptlets to update the icon cache to ensure that the Desktop
files are able to load the included icon files.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
Because the data package is build from the same source as the main package,
there is no real gain in splitting them apart.
You can use %{_pkgdocdir} instead of %{_docdir}/%{name}
Remove ChangeLog from docs. It is irrelevant documentation (it is about source
code commits) and it should not be packaged.
https://fedoraproject.org/wiki/Packaging:Guidelines#Documentation
The package uses gettext for translations so you should add BuildRequires:
gettext.
Moreover, you MUST use the %find_lang macro.
https://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
Compilation is not verbose. Therefore it is not possible to check the compiler
flag used. Invoke make like make %{?_smp_mflags} V=1
Incorrect FSF addess should be reported upstream.
https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address
tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tuxfootball-0.3.1/src/SFont.c
tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tuxfootball-0.3.1/src/SFont.h
tuxfootball-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/tuxfootball-0.3.1/src/Font.hpp
I'll perform a deeper analysis after these issues are fixed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151635] Review Request: torbrowser-launcher - Tor Browser Bundle managing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1151635 --- Comment #8 from pjp pj.pan...@yahoo.co.in --- (In reply to Robert Mayr from comment #7) I'm not able to reproduce the issue, works fine here on F20: Oh, you are using the same SRPM from c#3 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 998219] Review Request: mate-themes-extras - GTK-2/3 themes for GTK based desktops
https://bugzilla.redhat.com/show_bug.cgi?id=998219 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- mate-themes-extras-1.7.6-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/mate-themes-extras-1.7.6-1.el7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153721] New: Review Request: golang-github-skratchdot-open-golang - Open a file, directory, or URI using the OS's default application
https://bugzilla.redhat.com/show_bug.cgi?id=1153721 Bug ID: 1153721 Summary: Review Request: golang-github-skratchdot-open-golang - Open a file, directory, or URI using the OS's default application Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-skratchdot-open-golang/golang-github-skratchdot-open-golang.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-skratchdot-open-golang/golang-github-skratchdot-open-golang-0-0.1.gitba570a1.fc20.src.rpm Description: Open a file, directory, or URI using the OS's default application Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7882297 $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-skratchdot-open-golang-0-0.1.gitba570a1.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-skratchdot-open-golang-devel-0-0.1.gitba570a1.fc20.noarch.rpm golang-github-skratchdot-open-golang.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153724] New: Review Request: golang-github-mitchellh-mapstructure - Go library for decoding generic map values into native Go structures
https://bugzilla.redhat.com/show_bug.cgi?id=1153724
Bug ID: 1153724
Summary: Review Request: golang-github-mitchellh-mapstructure -
Go library for decoding generic map values into native
Go structures
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mitchellh-mapstructure/golang-github-mitchellh-mapstructure.spec
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-mitchellh-mapstructure/golang-github-mitchellh-mapstructure-0-0.1.git740c764.fc20.src.rpm
Description: mapstructure is a Go library for decoding generic map values to
structures
and vice versa, while providing helpful error handling.
This library is most useful when decoding values from some data stream (JSON,
Gob, etc.) where you don't quite know the structure of the underlying data
until you read a part of it. You can therefore read a map[string]interface{}
and use this library to decode it into the proper underlying
native Go structure.
Fedora Account System Username: jchaloup
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7883740
$ rpmlint
/home/jchaloup/rpmbuild/SRPMS/golang-github-mitchellh-mapstructure-0-0.1.git740c764.fc20.src.rpm
/home/jchaloup/rpmbuild/RPMS/noarch/golang-github-mitchellh-mapstructure-devel-0-0.1.git740c764.fc20.noarch.rpm
golang-github-mitchellh-mapstructure.spec
golang-github-mitchellh-mapstructure.src: W: spelling-error %description -l
en_US versa - avers, verse, verso
golang-github-mitchellh-mapstructure-devel.noarch: W: spelling-error
%description -l en_US versa - avers, verse, verso
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153721] Review Request: golang-github-skratchdot-open-golang - Open a file, directory, or URI using the OS's default application
https://bugzilla.redhat.com/show_bug.cgi?id=1153721 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153721] Review Request: golang-github-skratchdot-open-golang - Open a file, directory, or URI using the OS's default application
https://bugzilla.redhat.com/show_bug.cgi?id=1153721 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Lokesh Mandvekar l...@fedoraproject.org --- Package approved. Specfile conforms to current Go packaging draft. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153724] Review Request: golang-github-mitchellh-mapstructure - Go library for decoding generic map values into native Go structures
https://bugzilla.redhat.com/show_bug.cgi?id=1153724 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153726] New: Review Request: golang-github-racker-perigee -
https://bugzilla.redhat.com/show_bug.cgi?id=1153726 Bug ID: 1153726 Summary: Review Request: golang-github-racker-perigee - Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-racker-perigee/golang-github-racker-perigee.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-racker-perigee/golang-github-racker-perigee-0-0.1.git0c00cb0.fc20.src.rpm Description: Perigee provides a REST client that, while it should be generic enough to use with most any RESTful API, is nonetheless optimized to the needs of the OpenStack APIs. Perigee grew out of the need to refactor out common API access code from the gorax project. Several things influenced the name of the project. Numerous elements of the OpenStack ecosystem are named after astronomical artifacts. Additionally, perigee occurs when two orbiting bodies are closest to each other. Perigee seemed appropriate for something aiming to bring OpenStack and other RESTful services closer to the end-user. This library is still in the very early stages of development. Fedora Account System Username: jchaloup koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7883807 $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-racker-perigee-0-0.1.git0c00cb0.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-racker-perigee-devel-0-0.1.git0c00cb0.fc20.noarch.rpm golang-github-racker-perigee.spec golang-github-racker-perigee.src: W: spelling-error %description -l en_US refactor - redactor, reactor, re factor golang-github-racker-perigee.src: W: spelling-error %description -l en_US gorax - borax golang-github-racker-perigee-devel.noarch: W: spelling-error %description -l en_US refactor - redactor, reactor, re factor golang-github-racker-perigee-devel.noarch: W: spelling-error %description -l en_US gorax - borax 2 packages and 1 specfiles checked; 0 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153726] Review Request: golang-github-racker-perigee - REST client optimized for use with APIs for request and response bodies
https://bugzilla.redhat.com/show_bug.cgi?id=1153726 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Summary|Review Request: |Review Request: |golang-github-racker-perige |golang-github-racker-perige |e - |e - REST client optimized ||for use with APIs for ||request and response bodies -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153724] Review Request: golang-github-mitchellh-mapstructure - Go library for decoding generic map values into native Go structures
https://bugzilla.redhat.com/show_bug.cgi?id=1153724 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Lokesh Mandvekar l...@fedoraproject.org --- Package approved. Specfile conforms to current Go packaging draft. Only sources installed but that may change as packaging draft evolves. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153726] Review Request: golang-github-racker-perigee - REST client optimized for use with APIs for request and response bodies
https://bugzilla.redhat.com/show_bug.cgi?id=1153726 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153731] New: Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty
https://bugzilla.redhat.com/show_bug.cgi?id=1153731 Bug ID: 1153731 Summary: Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-tonnerre-golang-pretty/golang-github-tonnerre-golang-pretty.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-tonnerre-golang-pretty/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20.src.rpm Description: Pretty printing for Go values http://godoc.org/github.com/kr/pretty Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7883898 $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-tonnerre-golang-pretty-0-0.1.gite7fccc0.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-tonnerre-golang-pretty-devel-0-0.1.gite7fccc0.fc20.noarch.rpm golang-github-tonnerre-golang-pretty.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153726] Review Request: golang-github-racker-perigee - REST client optimized for use with APIs for request and response bodies
https://bugzilla.redhat.com/show_bug.cgi?id=1153726 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Lokesh Mandvekar l...@fedoraproject.org --- Package approved. Specfile conforms to current Go packaging draft. Only sources installed for now, that may change as the packaging draft evolves. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153731] Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty
https://bugzilla.redhat.com/show_bug.cgi?id=1153731 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153733] New: Review Request: golang-github-rackspace-gophercloud - The Go SDK for Openstack http://gophercloud.io
https://bugzilla.redhat.com/show_bug.cgi?id=1153733 Bug ID: 1153733 Summary: Review Request: golang-github-rackspace-gophercloud - The Go SDK for Openstack http://gophercloud.io Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rackspace-gophercloud/golang-github-rackspace-gophercloud.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rackspace-gophercloud/golang-github-rackspace-gophercloud-0-0.1.gite13cda2.fc20.src.rpm Description: Gophercloud currently lets you authenticate with OpenStack providers to create and manage servers. We are working on extending the API to further include cloud files, block storage, DNS, databases, security groups, and other features. This library is still in the very early stages of development. Fedora Account System Username: jchaloup Koji: build locally as it depends on golang(github.com/mitchellh/mapstructure), golang(github.com/racker/perigee) and golang(github.com/tonnerre/golang-pretty). These are being reviewed right now. $ rpmlint /home/jchaloup/rpmbuild/SRPMS/golang-github-rackspace-gophercloud-0-0.1.gite13cda2.fc20.src.rpm /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-rackspace-gophercloud-devel-0-0.1.gite13cda2.fc20.noarch.rpm golang-github-rackspace-gophercloud.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153733] Review Request: golang-github-rackspace-gophercloud - The Go SDK for Openstack http://gophercloud.io
https://bugzilla.redhat.com/show_bug.cgi?id=1153733 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@fedoraproject.org Assignee|nob...@fedoraproject.org|l...@fedoraproject.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153733] Review Request: golang-github-rackspace-gophercloud - The Go SDK for Openstack http://gophercloud.io
https://bugzilla.redhat.com/show_bug.cgi?id=1153733 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Lokesh Mandvekar l...@fedoraproject.org --- package approved. specfile conforms to current golang packaging draft. Only sources packaged for now, but that may change as packaging draft evolves. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153731] Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty
https://bugzilla.redhat.com/show_bug.cgi?id=1153731 Lokesh Mandvekar l...@fedoraproject.org changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Lokesh Mandvekar l...@fedoraproject.org --- Looks like the MIT license file should have this line on top: The MIT License (MIT) ..perhaps that should be reported upstream, kr/pretty has that corrected btw. But apart from that, specfile conforms to current golang packaging draft. Only source files packaged for now, but that may change as packaging draft evolves. This is a fork of kr/pretty but paths for installed files don't conflict at the time of this writing. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152057] Review Request: csnappy - Snappy compression library ported to C
https://bugzilla.redhat.com/show_bug.cgi?id=1152057
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Florian der-flo Lehner d...@der-flo.net ---
Hi Petr!
Looks good!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
--- http://koji.fedoraproject.org/koji/taskinfo?taskID=7884148
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq,
[Bug 1056291] Review Request: python-kdcproxy - MS-KKDCP (kerberos proxy) WSGI module
https://bugzilla.redhat.com/show_bug.cgi?id=1056291 Nathaniel McCallum nathan...@natemccallum.com changed: What|Removed |Added CC||nathan...@natemccallum.com Flags||fedora-cvs? --- Comment #8 from Nathaniel McCallum nathan...@natemccallum.com --- New Package SCM Request === Package Name: python-kdcproxy Short Description: Python WSGI Kerberos HTTP proxy Upstream URL: https://github.com/npmccallum/kdcproxy Owners: npmccallum nalin Branches: f21 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151456] Review Request: libgltf - a library for rendering glTF models
https://bugzilla.redhat.com/show_bug.cgi?id=1151456
Florian der-flo Lehner d...@der-flo.net changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||d...@der-flo.net
Assignee|nob...@fedoraproject.org|d...@der-flo.net
Flags||fedora-review+
--- Comment #1 from Florian der-flo Lehner d...@der-flo.net ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 102400 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
---
[Bug 1151464] Review Request: ballerburg - Two players, two castles, and a hill in between
https://bugzilla.redhat.com/show_bug.cgi?id=1151464 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #15 from Fedora Update System upda...@fedoraproject.org --- ballerburg-1.1.0-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1151747] Review request: onionshare - share files of any size securely and anonymously
https://bugzilla.redhat.com/show_bug.cgi?id=1151747 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System upda...@fedoraproject.org --- onionshare-0.6-5.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1150762] Review Request: python-xcffib - A drop in replacement for xpyb, an XCB python binding
https://bugzilla.redhat.com/show_bug.cgi?id=1150762 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- python-xcffib-0.1.7-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152047] Review Request: jenkins-matrix-project-plugin - Jenkins Matrix Project Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1152047 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System upda...@fedoraproject.org --- jenkins-matrix-project-plugin-1.3-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153751] New: Review Request: golang-github-spf13-pflag - Drop-in replacement for Go's flag package, implementing POSIX/GNU-style --flags
https://bugzilla.redhat.com/show_bug.cgi?id=1153751 Bug ID: 1153751 Summary: Review Request: golang-github-spf13-pflag - Drop-in replacement for Go's flag package, implementing POSIX/GNU-style --flags Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-spf13-pflag/golang-github-spf13-pflag.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-spf13-pflag/golang-github-spf13-pflag-0-0.1.git463bdc8.fc20.src.rpm Description: pflag is a drop-in replacement for Go's flag package, implementing POSIX/GNU-style --flags. pflag is compatible with the GNU extensions to the POSIX recommendations for command-line options. For a more precise description, see the Command-line flag syntax section below. pflag is available under the same style of BSD license as the Go language, which can be found in the LICENSE file. Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=7884479 $ rpmlint /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-spf13-pflag-devel-0-0.1.git463bdc8.fc20.noarch.rpm /home/jchaloup/rpmbuild/SRPMS/golang-github-spf13-pflag-0-0.1.git463bdc8.fc20.src.rpm golang-github-spf13-pflag.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153756] New: Review Request: golang-github-spf13-cobra - A Commander for modern Go CLI interactions
https://bugzilla.redhat.com/show_bug.cgi?id=1153756 Bug ID: 1153756 Summary: Review Request: golang-github-spf13-cobra - A Commander for modern Go CLI interactions Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-spf13-cobra/golang-github-spf13-cobra.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-spf13-cobra/golang-github-spf13-cobra-0-0.1.gitb1e90a7.fc20.src.rpm Description: Cobra is a commander providing a simple interface to create powerful modern CLI interfaces similar to git go tools. In addition to providing an interface, Cobra simultaneously provides a controller to organize your application code. Inspired by go, go-Commander, gh and subcommand, Cobra improves on these by providing fully posix compliant flags (including short long versions), nesting commands, and the ability to define your own help and usage for any or all commands. Fedora Account System Username: jchaloup Koji: build locally but depends on golang-github-spf13-pflag which is under review right now $ rpmlint /home/jchaloup/rpmbuild/RPMS/noarch/golang-github-spf13-pflag-devel-0-0.1.git463bdc8.fc20.noarch.rpm /home/jchaloup/rpmbuild/SRPMS/golang-github-spf13-pflag-0-0.1.git463bdc8.fc20.src.rpm golang-github-spf13-pflag.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166409] Review Request: gajim - jabber client written in PyGTK
https://bugzilla.redhat.com/show_bug.cgi?id=166409 Michal Schmidt mschm...@redhat.com changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #12 from Michal Schmidt mschm...@redhat.com --- Package Change Request == Package Name: gajim New Branches: epel7 Owners: michich A user requested Gajim in EPEL 7 in bug 1126898. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1152244] Review Request: unsafe-mock - A mock of sun.misc.Unsafe
https://bugzilla.redhat.com/show_bug.cgi?id=1152244 --- Comment #2 from Mo Morsi mmo...@redhat.com --- Sounds reasonable (assuming the dep is satisfied by the Java8 in Fedora). Lets proceed w/ the other deps try to build JRuby w/out this. If all goes well, can just close this issue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153302] Review Request: tilda - A Gtk based drop down terminal for Linux and Unix
https://bugzilla.redhat.com/show_bug.cgi?id=1153302 --- Comment #3 from hannes johannes.l...@googlemail.com --- Spec URL: https://hannes.fedorapeople.org/tilda.spec SRPM URL: https://hannes.fedorapeople.org/tilda-1.2-1.fc20.src.rpm Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=7884796 Could remove the .desktop patch, because it was upstreamed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166409] Review Request: gajim - jabber client written in PyGTK
https://bugzilla.redhat.com/show_bug.cgi?id=166409 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 166409] Review Request: gajim - jabber client written in PyGTK
https://bugzilla.redhat.com/show_bug.cgi?id=166409 --- Comment #13 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1056291] Review Request: python-kdcproxy - MS-KKDCP (kerberos proxy) WSGI module
https://bugzilla.redhat.com/show_bug.cgi?id=1056291 --- Comment #9 from Jon Ciesla limburg...@gmail.com --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1056291] Review Request: python-kdcproxy - MS-KKDCP (kerberos proxy) WSGI module
https://bugzilla.redhat.com/show_bug.cgi?id=1056291 Jon Ciesla limburg...@gmail.com changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132671] Review Request: rubygem-compass-import-once - Ruby Module to speed up Sass compilation
https://bugzilla.redhat.com/show_bug.cgi?id=1132671 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||1152676 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1152676 [Bug 1152676] installed rubygem-compass and rubygem-sass are incompatible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1132670] Review Request: rubygem-compass-core - The Compass core stylesheet library
https://bugzilla.redhat.com/show_bug.cgi?id=1132670 Mo Morsi mmo...@redhat.com changed: What|Removed |Added Blocks||1152676 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1152676 [Bug 1152676] installed rubygem-compass and rubygem-sass are incompatible. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153756] Review Request: golang-github-spf13-cobra - A Commander for modern Go CLI interactions
https://bugzilla.redhat.com/show_bug.cgi?id=1153756 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2014-10-16 14:29:43 --- Comment #1 from Jan Chaloupka jchal...@redhat.com --- *** This bug has been marked as a duplicate of bug 1085881 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085881] Review Request: golang-github-spf13-cobra - A Commander for modern go CLI interactions
https://bugzilla.redhat.com/show_bug.cgi?id=1085881 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added CC||jchal...@redhat.com --- Comment #11 from Jan Chaloupka jchal...@redhat.com --- *** Bug 1153756 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153751] Review Request: golang-github-spf13-pflag - Drop-in replacement for Go's flag package, implementing POSIX/GNU-style --flags
https://bugzilla.redhat.com/show_bug.cgi?id=1153751 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2014-10-16 14:30:43 --- Comment #1 from Jan Chaloupka jchal...@redhat.com --- *** This bug has been marked as a duplicate of bug 1085890 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1085890] Review Request: golang-github-spf13-pflag - Replacement for Go's flag package
https://bugzilla.redhat.com/show_bug.cgi?id=1085890 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added CC||jchal...@redhat.com --- Comment #11 from Jan Chaloupka jchal...@redhat.com --- *** Bug 1153751 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153733] Review Request: golang-github-rackspace-gophercloud - The Go SDK for Openstack http://gophercloud.io
https://bugzilla.redhat.com/show_bug.cgi?id=1153733 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka jchal...@redhat.com --- New Package SCM Request === Package Name: golang-github-rackspace-gophercloud Short Description: The Go SDK for Openstack http://gophercloud.io Upstream URL: https://github.com/rackspace/gophercloud Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153731] Review Request: golang-github-tonnerre-golang-pretty - Pretty printing for Go values http://godoc.org/github.com/kr/pretty
https://bugzilla.redhat.com/show_bug.cgi?id=1153731 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka jchal...@redhat.com --- New Package SCM Request === Package Name: golang-github-tonnerre-golang-pretty Short Description: Pretty printing for Go values http://godoc.org/github.com/kr/pretty Upstream URL: https://github.com/tonnerre/golang-pretty Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153726] Review Request: golang-github-racker-perigee - REST client optimized for use with APIs for request and response bodies
https://bugzilla.redhat.com/show_bug.cgi?id=1153726 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka jchal...@redhat.com --- New Package SCM Request === Package Name: golang-github-racker-perigee Short Description: REST client optimized for use with APIs for request and response bodies Upstream URL: https://github.com/racker/perigee Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1153724] Review Request: golang-github-mitchellh-mapstructure - Go library for decoding generic map values into native Go structures
https://bugzilla.redhat.com/show_bug.cgi?id=1153724 Jan Chaloupka jchal...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka jchal...@redhat.com --- New Package SCM Request === Package Name: golang-github-mitchellh-mapstructure Short Description: Go library for decoding generic map values into native Go structures Upstream URL: https://github.com/mitchellh/mapstructure Owners: jchaloup lsm5 vbatts Branches: f21 f20 f19 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
