[Bug 1169793] Review Request: libstemmer - C stemming algorithm library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169793

Marek Skalický  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2014-12-05 02:18:20



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rocket - CLI for running app containers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #13 from Lokesh Mandvekar  ---
(In reply to Timothy St. Clair from comment #12)
> As I had mentioned: 
> 
> An important point to clarify is that two things were announced:
> 
> 1. a spec (App Container)
> https://github.com/coreos/rocket/blob/master/app-container/SPEC.md
> 2. and an implementation (Rocket).
>  
> Meaning, there may well be several implementations to the spec.

Yup, comment from upstream author:
-
The coreos rootfs is by no means a hard requirement of rocket - we intend for
stage1 and stage0 to be decoupled and modular.

However, there's a fairly close relationship between the stage1 init binary and
the stage1 rootfs, so if you want to change the latter, you have two options:

 - Replace it with something that's still compatible with the existing stage1
init binary. This will probably be fairly plausible with something
Fedora-based, as long as the systemd is relatively recent (this is basically
the main thing we use, as you can see in the mkrootfs.sh)
 - Roll your own init binary as well as rootfs. In this case, you are free to
use whatever you like in both, as long as you can continue to work with the
output that the stage0 generates, and then comply with the ACE spec
-

Origin: https://github.com/coreos/rocket/issues/173#issuecomment-65739099

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1151818] Review Request: nodejs-typeahead.js - Autocomplete library for JavaScript

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1151818

Dan Callaghan  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #4 from Dan Callaghan  ---
Built in rawhide:

http://koji.fedoraproject.org/koji/buildinfo?buildID=597159

Will build for F21 and EPEL7 once dependencies are pushed to stable.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170529] Review Request: reprepro - Tool to handle local repositories of Debian packages

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170529



--- Comment #5 from Michel Alexandre Salim  ---
Only three items need fixing (see [!])

- license should be GPLv2 and GPLv2+ and MIT, with a comment describing what
files are not under GPLv2 (see attachment)

- try and enable at least some of the tests - or maybe create a %check section
with a comment showing how to invoke the tests but document which missing
dependencies are preventing us from running them

- try and adjust Makefile (or call make with the appropriate argument) so that
install is called with -p to preserve timestamps


The latter two are not mandatory though (but the latter might cause 

Also, this rpmlint warning:
- sftp.py in docs should not have executable permission -- it's missing
shebangs and doesn't have an if __name__ == '__main__' section

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170529] Review Request: reprepro - Tool to handle local repositories of Debian packages

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170529



--- Comment #4 from Michel Alexandre Salim  ---
Created attachment 965001
  --> https://bugzilla.redhat.com/attachment.cgi?id=965001&action=edit
License check result

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "MIT/X11 (BSD like)", "GPL (v2 or later)", "GPL (v2)", "Unknown or
 generated", "*No copyright* Public domain". 84 files have unknown
 license. Detailed output of licensecheck in
 /home/michel/sources/fedora/reviews/1170529-reprepro/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 430080 bytes in 28 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[!]: %check is present and all tests pass.
 Upstream sources contain tests/test.sh but between missing dependencies
and 
[!]: Packages should try to preserve timestamps of original installed files.
 install is called without -p
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from 

[Bug 1170529] Review Request: reprepro - Tool to handle local repositories of Debian packages

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170529



--- Comment #3 from Michel Alexandre Salim  ---
Any idea where the testtool referenced in tests/test.sh comes from? I'm going
through my review checklist and am about to suggest enabling at least some of
the available tests, but hits a snag there. Checking the package's list of
Debian dependencies don't really reveal anything informative either.

We can skip that for now I suppose.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170529] Review Request: reprepro - Tool to handle local repositories of Debian packages

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170529

Michel Alexandre Salim  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||mic...@michel-slm.name
   Assignee|nob...@fedoraproject.org|mic...@michel-slm.name
  Flags||fedora-review?



--- Comment #2 from Michel Alexandre Salim  ---
Taking this review -- could you review this in return? Thanks beforehand!

https://bugzilla.redhat.com/show_bug.cgi?id=1170875

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170875] New: Review Request: budgie-desktop - An elegant desktop with GNOME integration

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170875

Bug ID: 1170875
   Summary: Review Request: budgie-desktop - An elegant desktop
with GNOME integration
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mic...@michel-slm.name
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://salimma.fedorapeople.org/specs/desktop/budgie-desktop.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/desktop/budgie-desktop-8-1.fc21.src.rpm
Description:
Budgie is the flagship desktop of the Evolve OS Linux Distribution,
and is an Evolve OS project. Designed with the modern user in mind, it
focuses on simplicity and elegance.

The Budgie Desktop tightly integrates with the GNOME stack, employing
underlying technologies to offer an alternative desktop experience. In
the spirit of open source, the project is compatible with and
available for other Linux distributions.

Fedora Account System Username: salimma

COPR repo: https://copr.fedoraproject.org/coprs/salimma/budgie-desktop/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rocket - CLI for running app containers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #12 from Timothy St. Clair  ---
As I had mentioned: 

An important point to clarify is that two things were announced:

1. a spec (App Container)
https://github.com/coreos/rocket/blob/master/app-container/SPEC.md
2. and an implementation (Rocket).

Meaning, there may well be several implementations to the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1167478] Review Request: python-pysb - Rule-based modeling of biochemical systems as Python programs

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1167478

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Mukundan Ragavan  ---
Just noticed that I had left the review incomplete here (copy/paste snafu).

(In reply to Mukundan Ragavan from comment #3)

> Python:
> [ ]: Python eggs must not download any dependencies during the build process.
> [ ]: A package which is used by another package via an egg interface should
>  provide egg info.
> [x]: Package meets the Packaging Guidelines::Python
> [x]: Package contains BR: python2-devel or python3-devel
> [x]: Binary eggs must be removed in %prep


This should be


Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep


With the updated spec and srpm, I have no further issues.

Package APPROVED!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 459934] Review Request: perl-DateTime-Format-Pg - Parse and format PostgreSQL dates and times

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=459934

Fedora Update System  changed:

   What|Removed |Added

   Fixed In Version||perl-DateTime-Format-Pg-0.1
   ||6010-6.el7
 Resolution|NEXTRELEASE |ERRATA



--- Comment #11 from Fedora Update System  ---
perl-DateTime-Format-Pg-0.16010-6.el7 has been pushed to the Fedora EPEL 7
stable repository.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1165620] Review Request: biber - Command-line bibliographic manager, BibTeX replacement

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1165620



--- Comment #11 from Colin Macdonald  ---
Upstream thinks we can relax the Unicode::Collate requirement so I'll do that
and leave a comment in the spec file on my next revision.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 492708] Review Request: xml2 - XML/Unix Processing Tools

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=492708



--- Comment #16 from Fedora Update System  ---
xml2-0.5-7.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/xml2-0.5-7.el6

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 492708] Review Request: xml2 - XML/Unix Processing Tools

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=492708



--- Comment #15 from Fedora Update System  ---
xml2-0.5-7.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/xml2-0.5-7.el7

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1148704] Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1148704

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21 has been pushed to the
Fedora 21 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1166919] Review Request: python-fastcache - C implementation of python3 lru_cache

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1166919

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
python-fastcache-1.0.2-2.fc21 has been pushed to the Fedora 21 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170149] Review Request: mingw-librsvg2 - SVG library based on cairo for MinGW

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170149

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
mingw-librsvg2-2.40.6-1.fc21 has been pushed to the Fedora 21 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1147351] Review Request: python-modestmaps - Modest Maps python port

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1147351

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
python-modestmaps-1.4.6-2.fc21 has been pushed to the Fedora 21 testing
repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
2048-cli-0.8-2.fc21 has been pushed to the Fedora 21 testing repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rocket - CLI for running app containers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #11 from Matthew Miller  ---
(In reply to Lokesh Mandvekar from comment #7)
> Maybe we could try a fedora rootfs instead, but no idea how well that'd
> work, also gotta check with upstream about that (if we're to pursue that
> option)
> 
> Correct me if I'm wrong, people

If the intention is to require CoreOS as the stage1 rootfs it's kind of a
nonstarter for every other distribution

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169966] Review Request: rocket - CLI for running app containers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169966



--- Comment #10 from Lokesh Mandvekar  ---
(In reply to Tomas Tomecek from comment #9)
> Wanted to give rocket a shot, so I made your spec a source of information;
> couple points:
> 
>  * latest build of go-bindata is 0.0.6, while your spec requires 3.0.7-1 (on
> the other hand, I can see that you have built the new version in koji, looks
> like that repos weren't regenerated yet)

yup only built for rawhide (mostly to get this going), I'll push builds for
others soon, co-maintainers welcome :)

> 
>  * my VM missed gnupg, might be a good idea to add it to buildrequires

hmm, koji didn't seem to complain, but I will double-check

> 
>  * (same point for tar but since it's in minimum build env set, it doesn't
> make sense to make it a BR I guess)

ack

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170824] New: Review Request: nodejs-async-each - Async parallel forEach / map function for JavaScript

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170824

Bug ID: 1170824
   Summary: Review Request: nodejs-async-each - Async parallel
forEach / map function for JavaScript
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-async-each.spec
SRPM URL:
https://piotrp.fedorapeople.org/nodejs-async-each-0.1.6-1.fc21.src.rpm
Description: Async parallel forEach / map function for JavaScript
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170811] Review Request: nodejs-clone - deep cloning of objects and arrays

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170811

Piotr Popieluch  changed:

   What|Removed |Added

 Blocks||1170816




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1170816
[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI
annotation pass for astral
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170815] Review Request: nodejs-astral-pass - Pass helper for Astral that simplifies traversal.

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170815

Piotr Popieluch  changed:

   What|Removed |Added

 Blocks||1170816




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1170816
[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI
annotation pass for astral
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170816

Piotr Popieluch  changed:

   What|Removed |Added

 Depends On||1170815, 1170811




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1170811
[Bug 1170811] Review Request: nodejs-clone - deep cloning of objects and
arrays
https://bugzilla.redhat.com/show_bug.cgi?id=1170815
[Bug 1170815] Review Request: nodejs-astral-pass -  Pass helper for Astral
that simplifies traversal.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170816] New: Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170816

Bug ID: 1170816
   Summary: Review Request: nodejs-astral-angular-annotate -
AngularJS DI annotation pass for astral
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-astral-angular-annotate.spec
SRPM URL:
https://piotrp.fedorapeople.org/nodejs-astral-angular-annotate-0.0.2-1.fc21.src.rpm
Description: AngularJS DI annotation pass for astral
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170815] New: Review Request: nodejs-astral-pass - Pass helper for Astral that simplifies traversal.

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170815

Bug ID: 1170815
   Summary: Review Request: nodejs-astral-pass -  Pass helper for
Astral that simplifies traversal.
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-astral-pass.spec
SRPM URL:
https://piotrp.fedorapeople.org/nodejs-astral-pass-0.1.0-1.fc21.src.rpm
Description: Pass helper for Astral that simplifies traversal.
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170812] Review Request: nodejs-astral - AST tooling framework for JavaScript

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170812

Piotr Popieluch  changed:

   What|Removed |Added

 Depends On||1170811




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1170811
[Bug 1170811] Review Request: nodejs-clone - deep cloning of objects and
arrays
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170811] Review Request: nodejs-clone - deep cloning of objects and arrays

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170811

Piotr Popieluch  changed:

   What|Removed |Added

 Blocks||1170812




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1170812
[Bug 1170812] Review Request: nodejs-astral -  AST tooling framework for
JavaScript
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170812] New: Review Request: nodejs-astral - AST tooling framework for JavaScript

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170812

Bug ID: 1170812
   Summary: Review Request: nodejs-astral -  AST tooling framework
for JavaScript
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-astral.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-astral-0.1.0-1.fc21.src.rpm
Description: AST tooling framework for JavaScript
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170811] New: Review Request: nodejs-clone - deep cloning of objects and arrays

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170811

Bug ID: 1170811
   Summary: Review Request: nodejs-clone - deep cloning of objects
and arrays
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-clone.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-clone-0.1.18-1.fc21.src.rpm
Description: deep cloning of objects and arrays
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170802] New: Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170802

Bug ID: 1170802
   Summary: Review Request: nodejs-relateurl -  Minify URLs by
converting them from absolute to relative
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: piotr1...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://piotrp.fedorapeople.org/nodejs-relateurl.spec
SRPM URL: https://piotrp.fedorapeople.org/nodejs-relateurl-0.2.5-1.fc21.src.rpm
Description: Minify URLs by converting them from absolute to relative
Fedora Account System Username: piotrp

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170072] Review Request: python-rfc6266 - Parse and generate Content-Disposition headers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170072



--- Comment #7 from Kevin Fenzi  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169358] Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169358



--- Comment #3 from Kevin Fenzi  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170072] Review Request: python-rfc6266 - Parse and generate Content-Disposition headers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170072

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169358] Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169358

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 526738] Review Request: py-radix - Radix tree data structure for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=526738



--- Comment #24 from Kevin Fenzi  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 526738] Review Request: py-radix - Radix tree data structure for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=526738

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 179904] Review Request: icecast

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=179904



--- Comment #11 from Kevin Fenzi  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 179904] Review Request: icecast

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=179904

Kevin Fenzi  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 179904] Review Request: icecast

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=179904

Björn "besser82" Esser  changed:

   What|Removed |Added

 CC||bjoern.es...@gmail.com
  Flags||fedora-cvs?



--- Comment #10 from Björn "besser82" Esser  ---
I want to build to epel7.

#

Package Change Request
==
Package Name: icecast
New Branches: epel7
Owners: besser82 ixs
InitialCC: ppisar

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 526738] Review Request: py-radix - Radix tree data structure for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=526738

Matt Domsch  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #23 from Matt Domsch  ---
Package Change Request
==
Package Name: py-radix
New Branches: EL-7
Owners: 
InitialCC:

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154213] Review Request: python-structlog - Painless structural logging

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154213



--- Comment #16 from Fedora Update System  ---
python-structlog-0.4.2-5.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-structlog-0.4.2-5.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170664] Review Request: python-mistune - Markdown parser for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170664



--- Comment #3 from Christian Dersch  ---
Thank you for your fast review! Fixed the issues:

Spec URL: https://lupinix.fedorapeople.org/packages/python-mistune.spec
SRPM URL:
https://lupinix.fedorapeople.org/packages/python-mistune-0.4.1-2.fc20.src.rpm

Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8296802

Greetings,
Christian

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169358] Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169358

Emmanuel Seyman  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #2 from Emmanuel Seyman  ---
(In reply to Jitka Plesnikova from comment #1)
>
> TODO: Remove BRs perl(Test::Builder), perl(Test::Pod::Coverage), they are
> not used

Done.

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-Plack-Middleware-MethodOverride/perl-Plack-Middleware-MethodOverride-0.10-2.fc20.src.rpm

> Package APPROVED.

Thank you, Jikta.
Requesting SCM.

New Package SCM Request
===
Package Name: perl-Plack-Middleware-MethodOverride
Short Description: Override REST methods to Plack apps via POST
Upstream URL: http://search.cpan.org/dist/Plack-Middleware-MethodOverride/
Owners: eseyman
Branches: f21
InitialCC: perl-sig

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170774] New: Review Request: upconvert - A python script that converts between schematic file formats

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170774

Bug ID: 1170774
   Summary: Review Request: upconvert - A python script that
converts between schematic file formats
   Product: Fedora
   Version: 21
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: lkund...@v3.sk
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC: http://v3.sk/~lkundrak/SPECS/upconvert.spec
SRPM:
http://v3.sk/~lkundrak/SRPMS/upconvert-0.8.9-1.20140403gita5975a5.fc21.src.rpm

Description:

A command line python anything-in anything-out file converter to go between the 
multitude of electrical circuit schematic file formats. This project was 
started by Upverter (http://upverter.com).

The converter can import and export in the following formats:

Upverter OpenJSON
KiCad
gEDA
Fritzing
NC Drill
Eagle
Eagle XML (in testing)
ViewDraw/DxDesigner (in testing)
DSN (in testing)
PNG Image
Bill of Materials
CSV Netlist
Altium (in development)
Telesis Netlist (in development)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154213] Review Request: python-structlog - Painless structural logging

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154213



--- Comment #15 from Fedora Update System  ---
python-structlog-0.4.2-5.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/python-structlog-0.4.2-5.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170664] Review Request: python-mistune - Markdown parser for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170664



--- Comment #2 from Thomas Spura  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Issues:
- The egg is not deleted.
- Please be more specific in %files.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[!]: Package does not own files or directories owned by other packages.
 /usr/lib64/python3.4/site-packages/__pycache__ should not be owned, only 
%{upname}.* inside it.

Could you please be a bit more specific in %files, such as:
%{python2_sitearch}/%{upname}.*
%{python2_sitearch}/%{upname}-%{version}-py?.?.egg-info

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.

Python:
[!]: Binary eggs must be removed in %prep
Please do so.
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-mistune
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 archite

[Bug 1168907] Package Review: freerouting - Circuit Board Routing Tool

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168907

Richard Marko  changed:

   What|Removed |Added

 CC||rma...@redhat.com
   Assignee|nob...@fedoraproject.org|rma...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168907] Package Review: freerouting - Circuit Board Routing Tool

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168907

Richard Marko  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895

Juan Orti  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2014-12-04 14:30:34



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170213] Review Request: modoboa - Mail hosting and management platform

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170213
Bug 1170213 depends on bug 1169895, which changed state.

Bug 1169895 Summary: Review Request: python-sievelib - Client-side SIEVE library
https://bugzilla.redhat.com/show_bug.cgi?id=1169895

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170072] Review Request: python-rfc6266 - Parse and generate Content-Disposition headers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170072

Juan Orti  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #6 from Juan Orti  ---
New Package SCM Request
===
Package Name: python-rfc6266
Short Description: Parse and generate Content-Disposition headers
Upstream URL: https://github.com/g2p/rfc6266
Owners: jorti
Branches: f19 f20 f21
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170664] Review Request: python-mistune - Markdown parser for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170664

Thomas Spura  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||toms...@fedoraproject.org
   Assignee|nob...@fedoraproject.org|toms...@fedoraproject.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170072] Review Request: python-rfc6266 - Parse and generate Content-Disposition headers

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170072

Florian "der-flo" Lehner  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Florian "der-flo" Lehner  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses found:
 "Unknown or generated". 6 files have unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.4/site-packages,
 /usr/lib/python3.4/site-packages/__pycache__, /usr/lib/python3.4
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.4/site-packages,
 /usr/lib/python3.4/site-packages/__pycache__, /usr/lib/python3.4
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 102400 bytes in 6 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
 supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
 in its own file, then that file, containing the text of the license(s)
 for the package is included in %doc.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
 are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
 in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate file
 from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-rfc6266
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should c

[Bug 1167830] Review Request: python-ptyprocess - Run a subprocess in a pseudo terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1167830

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1167830] Review Request: python-ptyprocess - Run a subprocess in a pseudo terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1167830



--- Comment #8 from Jon Ciesla  ---
Same error.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1135503] Review Request: khelpcenter - Application to show KDE Application's documentation

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1135503



--- Comment #5 from Kevin Kofler  ---
The -O3 comes from CMake's default flags for the Release build type. I think
KDE 4 overrode those in FindKDE4Internal.cmake, but KF5 keeps CMake's defaults.

IMHO, we should change that default in the cmake package. And yes, ANY package
that uses -O3 without a good justification (and "CMake has broken defaults" is
not) should not pass review.

I think using RelWithDebInfo instead will make it use -O2, it may or may not
have other side effects. (IIRC, we opted against defaulting to RelWithDebInfo
because KDE 4 stuff only had -DNDEBUG in Release, or something like that. Not
sure how KF5 behaves there.) But I insist, the default for Release should be
fixed in CMake packaging.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1167830] Review Request: python-ptyprocess - Run a subprocess in a pseudo terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1167830

Pierre-YvesChibon  changed:

   What|Removed |Added

 CC||pin...@pingoured.fr
  Flags||fedora-cvs?



--- Comment #7 from Pierre-YvesChibon  ---
This is odd, the group is present both in FAS and pkgdb.

@Jon, would you mind trying again? Maybe we hit some caching issue or something
weird.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 449784] Review Request: rpmreaper - A tool for removing packages from system

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=449784

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 449784] Review Request: rpmreaper - A tool for removing packages from system

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=449784



--- Comment #8 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170720] Review Request: mingw-colorhug-client - MinGW Tools for the Hughski ColorHug

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170720

David King  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||amigad...@amigadave.com
   Assignee|nob...@fedoraproject.org|amigad...@amigadave.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170720] New: Review Request: mingw-colorhug-client - MinGW Tools for the Hughski ColorHug

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170720

Bug ID: 1170720
   Summary: Review Request: mingw-colorhug-client - MinGW Tools
for the Hughski ColorHug
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rhug...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://people.freedesktop.org/~hughsient/temp/mingw-colorhug-client.spec
SRPM URL:
http://people.freedesktop.org/~hughsient/temp/mingw-colorhug-client-0.2.4-1.fc22.src.rpm
Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=8295544
Description: MinGW Tools for the Hughski ColorHug
Fedora Account System Username: rhughes

Other notes: The ColorHug is an open-source, open-hardware colorimeter device
designed for Linux users and developers. I'm also the project lead upstream :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1142407] Review Request: drpm - deltarpm manipulation library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1142407

Michael Schwendt  changed:

   What|Removed |Added

 CC||bugs.mich...@gmx.net



--- Comment #12 from Michael Schwendt  ---
For example:

$ pkg-config --cflags --libs drpm
Package rpm-devel was not found in the pkg-config search path.
Perhaps you should add the directory containing `rpm-devel.pc'
to the PKG_CONFIG_PATH environment variable
Package 'rpm-devel', required by 'drpm', not found


> http://koji.fedoraproject.org/koji/taskinfo?taskID=8286489
> https://kojipkgs.fedoraproject.org//work/tasks/6491/8286491/build.log

cc -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-switches  -m64 -mtune=generic -std=c99 -pedantic -Wall -Wextra
-fPIC -g -O0   -c -o drpm.o drpm.c

#warning _FORTIFY_SOURCE requires compiling with optimization (-O) [-Wcpp]
 #  warning _FORTIFY_SOURCE requires compiling with optimization (-O)

https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895



--- Comment #8 from Fedora Update System  ---
python-sievelib-0.8-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/python-sievelib-0.8-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895



--- Comment #7 from Fedora Update System  ---
python-sievelib-0.8-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-sievelib-0.8-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895



--- Comment #6 from Fedora Update System  ---
python-sievelib-0.8-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-sievelib-0.8-2.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169358] Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169358

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires
perl-Plack-Middleware-MethodOverride-0.10-1.fc22.noarch.rpm | sort | uniq -c
  1 perl >= 1:5.8.1
  1 perl(:MODULE_COMPAT_5.20.1)
  1 perl(Plack::Middleware)
  1 perl(URI)
  1 perl(parent)
  1 perl(strict)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides
perl-Plack-Middleware-MethodOverride-0.10-1.fc22.noarch.rpm | sort | uniq -c
  1 perl(Plack::Middleware::MethodOverride) = 0.10
  1 perl-Plack-Middleware-MethodOverride = 0.10-1.fc22
Binary provides are Ok.

$ rpmlint ./perl-Plack-Middleware-MethodOverride.spec
./perl-Plack-Middleware-MethodOverride-0.10-1.fc22.*
perl-Plack-Middleware-MethodOverride.noarch: W: spelling-error %description -l
en_US http -> HTTP
perl-Plack-Middleware-MethodOverride.src: W: spelling-error %description -l
en_US http -> HTTP
2 packages and 1 specfiles checked; 0 errors, 2 warnings.
Rpmlint is ok

TODO: Remove BRs perl(Test::Builder), perl(Test::Pod::Coverage), they are
not used

Otherwise package is good.

Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1148704] Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1148704



--- Comment #13 from Fedora Update System  ---
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6 has been submitted as an
update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1148704] Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1148704



--- Comment #12 from Fedora Update System  ---
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21 has been submitted as an
update for Fedora 21.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1148704] Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1148704



--- Comment #11 from Fedora Update System  ---
golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc20 has been submitted as an
update for Fedora 20.
https://admin.fedoraproject.org/updates/golang-googlecode-go-crypto-0-0.1.hg69e2a90ed92d.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1148704] Review Request: golang-googlecode-go-crypto - Supplementary Go cryptography libraries

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1148704

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114737] Review Request: openms - Open-source software for LC/MS data management and analyses

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114737



--- Comment #15 from Jerry James  ---
(In reply to Antonio Trande from comment #14)
> (In reply to Jerry James from comment #13)
> > - The main package installs over 93 Mbytes of files in %{_datadir}, 
> > including
> >   the examples.  Can any of those files go into a noarch subpackage?
> 
> Too sub-packages in my opinion.
> 
> > - The entire %{_datadir}/OpenMS directory, except for the examples, is
> >   duplicated in the python-openms package, as
> >   %{python2_sitearch}/pyopenms/share/OpenMS.  Is that really necessary?  Can
> >   %{python2_sitearch}/pyopenms/share/OpenMS instead be a symbolic link to
> >   %{_datadir}/OpenMS?
> 
> Python OpenMS may be used as standalone software so it must have own data
> directories. 

This means that we are duplicating that 93 Mbytes of files across all
architectures, and over 2 packages per architecture.  All you need to do is
make a single subpackage, say openmms-data, that is noarch, contains all this
data, and is a dependency of both the main package and python-mms, and all that
duplication will go away.  It really is worth doing.  Please consider it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 449784] Review Request: rpmreaper - A tool for removing packages from system

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=449784

Miroslav Lichvar  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #7 from Miroslav Lichvar  ---
Package Change Request
==
Package Name: rpmreaper
New Branches: epel7
Owners: mlichvar

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170664] Review Request: python-mistune - Markdown parser for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170664



--- Comment #1 from Christian Dersch  ---
Small adjustment, new Koji build for rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8295003

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168009] Review Request: python-gbpclient - Python API and CLI for OpenStack Neutron Group Based Policy

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168009

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168009] Review Request: python-gbpclient - Python API and CLI for OpenStack Neutron Group Based Policy

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168009



--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170664] New: Review Request: python-mistune - Markdown parser for Python

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170664

Bug ID: 1170664
   Summary: Review Request: python-mistune - Markdown parser for
Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/packages/python-mistune.spec
SRPM URL:
https://lupinix.fedorapeople.org/packages/python-mistune-0.4.1-1.fc20.src.rpm

Description: Markdown parser for Python

Fedora Account System Username: lupinix

Koji builds:
  rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=8294829
  f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=8294851
  f21 http://koji.fedoraproject.org/koji/taskinfo?taskID=8294845

Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168006] Review Request: openstack-neutron-gbp - Group Based Policy service plugin for OpenStack Networking Service

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168006



--- Comment #6 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168006] Review Request: openstack-neutron-gbp - Group Based Policy service plugin for OpenStack Networking Service

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168006

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1114737] Review Request: openms - Open-source software for LC/MS data management and analyses

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1114737



--- Comment #14 from Antonio Trande  ---
(In reply to Jerry James from comment #13)
> Issues:
> ===
> - The gtk-update-icon-cache invocations are being run on the main package,
> but
>   instead should be run on the openms-TOPP package; i.e., move them to
>   "%posttrans TOPP" and "%postun TOPP".

Done.

> - The source tarball, OpenMS-Release1.11.1.tar.gz, has 0600 permissions.
>   Please change that to 0644.

Done.

> - All software in Fedora is open source, so I think the summary should just
>   read "LC/MS data management and analyses"

Done.

> - The debuginfo generator gets a little confused while trying to locate some
>   source files.  Look in the build log for errors like this:
> 
> cpio:
> OpenMS-Release1.11.1/include/OpenMS/ANALYSIS/DECHARGING/FeatureDeconvolution.
> h: Cannot stat: Permission denied
> cpio:
> OpenMS-Release1.11.1/include/OpenMS/ANALYSIS/DECHARGING/ILPDCWrapper.h:
> Cannot stat: Permission denied
> 
>   The problem is the initial "OpenMS-Release1.11.1" part of the path.  To fix
>   the problem, add this at the end of %install:
> 
>   ln -s . OpenMS-Release%{version}

Done.

> - The openms-devel package contains the directory /usr/include/OpenMS, but
>   there are no files inside that directory.  Also, the directory has 0644
>   permissions, but should have 0755 permissions.

Done.

> - The openms-devel package installs a symbolic link libOpenMS_GUI.so that
>   points to %{_libdir}/libOpenMS_GUIso.1.11.1, but the target name is
> actually
>   %{_libdir}/libOpenMS_GUI.so.1.11.1; i.e., there is a missing dot.

Done.

> - ldd -u reports that the libraries and most of the binaries are linked with
>   libraries that are not actually used; see the
> unused-direct-shlib-dependency
>   rpmlint warnings below.  It might we worthwhile to add "-Wl,--as-needed" to
>   LDFLAGS.

Okay.

> - The cmake invocation specifies -DCMAKE_MT_ENABLE_TBB=ON and related
>   variables, and the spec file contains BuildRequires: tbb-devel, yet I see
>   this in the build log:
> 
> -- Intel TBB: OFF
> 
>   Perhaps it should be -DMT_ENABLE_TBB=ON (without the "CMAKE_" prefix)?

Done.

> - Use the new %license macro to install license texts, rather than %doc.

Done.

> - The main package installs 80 Mbytes of files in
> %{_datadir}/OpenMS/examples.
>   Are those files used at runtime?  If not, consider moving them to a -doc
>   subpackage.

They could be used as examples by a beginner user.

> - The main package installs over 93 Mbytes of files in %{_datadir}, including
>   the examples.  Can any of those files go into a noarch subpackage?

Too sub-packages in my opinion.

> - The entire %{_datadir}/OpenMS directory, except for the examples, is
>   duplicated in the python-openms package, as
>   %{python2_sitearch}/pyopenms/share/OpenMS.  Is that really necessary?  Can
>   %{python2_sitearch}/pyopenms/share/OpenMS instead be a symbolic link to
>   %{_datadir}/OpenMS?

Python OpenMS may be used as standalone software so it must have own data
directories. 

> - Some installed files have their executable bits set inappropriately.  See
>   the rpmlint messages about scripts without shebangs.
> - /usr/share/OpenMS/CV/psi-mzdata.obo has DOS end-of-line markers.
> - Fix the description-line-too-long error in the rpmlint output.
> 

Okay.

I'm building latest release; soon i will post it. 
Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169358] Review Request: perl-Plack-Middleware-MethodOverride - Override REST methods to Plack apps via POST

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169358

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168009] Review Request: python-gbpclient - Python API and CLI for OpenStack Neutron Group Based Policy

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168009

Robert Kukura  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Robert Kukura  ---
New Package SCM Request
===
Package Name: python-gbpclient
Short Description: Python API and CLI for OpenStack Neutron Group Based Policy
Upstream URL: https://launchpad.net/group-based-policy-client
Owners: rkukura
Branches: f20 f21
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168006] Review Request: openstack-neutron-gbp - Group Based Policy service plugin for OpenStack Networking Service

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168006

Robert Kukura  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #5 from Robert Kukura  ---
New Package SCM Request
===
Package Name: openstack-neutron-gbp
Short Description: Group Based Policy service plugin for OpenStack Networking
Service
Upstream URL: https://launchpad.net/group-based-policy
Owners: rkukura
Branches: f20 f21
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170629] New: Review Request: python-ncclient - Python library for NETCONF clients

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170629

Bug ID: 1170629
   Summary: Review Request: python-ncclient - Python library for
NETCONF clients
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ihrac...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://people.redhat.com/~ihrachys/python-ncclient.spec
SRPM URL:
http://people.redhat.com/~ihrachys/python-ncclient-0.4.2-1.fc20.src.rpm
Description: This project is a Python library that facilitates client-side
scripting and application development around the NETCONF protocol.
Fedora Account System Username: ihrachyshka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #15 from Fedora Update System  ---
2048-cli-0.8-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #14 from Fedora Update System  ---
2048-cli-0.8-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.fc20

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #13 from Fedora Update System  ---
2048-cli-0.8-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.fc19

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #12 from Fedora Update System  ---
2048-cli-0.8-2.el7 has been submitted as an update for Fedora EPEL 7.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #11 from Fedora Update System  ---
2048-cli-0.8-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #10 from Fedora Update System  ---
2048-cli-0.8-2.el5 has been submitted as an update for Fedora EPEL 5.
https://admin.fedoraproject.org/updates/2048-cli-0.8-2.el5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1141528] Review Request: php-horde-mnemo - A web based notes manager

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1141528



--- Comment #2 from Remi Collet  ---
Update to 4.2.3 (security)
https://github.com/remicollet/remirepo/commit/2a1d024c443081812cd205c3b0f8462aa1186272

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/2a1d024c443081812cd205c3b0f8462aa1186272/php/horde/php-horde-mnemo/php-horde-mnemo.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-horde-mnemo-4.2.3-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1170231] Review Request: 2048-cli - The game 2048 for your Linux terminal

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1170231



--- Comment #9 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1169895] Review Request: python-sievelib - Client-side SIEVE library

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1169895



--- Comment #5 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168260] Review Request: perl-Parse-Debian-Packages - Parse the data from a debian Packages.gz

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168260



--- Comment #11 from Jon Ciesla  ---
Git done (by process-git-requests).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1168260] Review Request: perl-Parse-Debian-Packages - Parse the data from a debian Packages.gz

2014-12-04 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1168260

Jon Ciesla  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

  1   2   >