[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1175023 --- Comment #7 from Gerald Cox --- Oops, forgot to modify that... here it is: Spec URL: https://gbcox.fedorapeople.org/specs/oggify.spec SRPM URL: https://repos.fedorapeople.org/repos/gbcox/forefront/fedora-21/SRPMS/oggify-2.0.7-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168017] Review Request: rabbitmq-java-client - Java Advanced Message Queue Protocol client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168017 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #18 from Fedora Update System --- rabbitmq-java-client-3.4.2-4.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral
https://bugzilla.redhat.com/show_bug.cgi?id=1170816 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-astral-angular-annot |nodejs-astral-angular-annot |ate-0.0.2-2.fc20|ate-0.0.2-2.fc19 --- Comment #13 from Fedora Update System --- nodejs-astral-angular-annotate-0.0.2-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171338] Review Request: nodejs-is-lower-case - Check if a string is lower cased
https://bugzilla.redhat.com/show_bug.cgi?id=1171338 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-is-lower-case-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171314] Review Request: nodejs-snake-case - Snake case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171314 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-snake-case-1.0.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170812] Review Request: nodejs-astral - AST tooling framework for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1170812 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-astral-0.1.0-2.fc19 |nodejs-astral-0.1.0-2.fc20 --- Comment #12 from Fedora Update System --- nodejs-astral-0.1.0-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171350] Review Request: nodejs-change-case - Convert a string between camelCase, PascalCase, Title Case, snake_case and more
https://bugzilla.redhat.com/show_bug.cgi?id=1171350 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-change-case-2.1.5-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171335] Review Request: nodejs-param-case - Param case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171335 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-param-case-1.0.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171306] Review Request: nodejs-camel-case - Camel case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171306 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-camel-case-1.0.2-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169115] Review Request: nodejs-console-browserify - Emulate console for all the browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1169115 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-console-browserify-1 |nodejs-console-browserify-1 |.1.0-1.fc19 |.1.0-1.fc21 --- Comment #12 from Fedora Update System --- nodejs-console-browserify-1.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169115] Review Request: nodejs-console-browserify - Emulate console for all the browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1169115 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-console-browserify-1 |nodejs-console-browserify-1 |.1.0-1.fc20 |.1.0-1.fc19 --- Comment #11 from Fedora Update System --- nodejs-console-browserify-1.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171327] Review Request: nodejs-path-case - Path case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171327 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-path-case-1.0.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171345] Review Request: nodejs-constant-case - Constant case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171345 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-constant-case-1.0.0-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171341] Review Request: nodejs-dot-case - Dot case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171341 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- nodejs-dot-case-1.0.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171336] Review Request: nodejs-is-upper-case - Check if a string is upper cased
https://bugzilla.redhat.com/show_bug.cgi?id=1171336 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-is-upper-case-1.0.1-1.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170816] Review Request: nodejs-astral-angular-annotate - AngularJS DI annotation pass for astral
https://bugzilla.redhat.com/show_bug.cgi?id=1170816 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-astral-angular-annot ||ate-0.0.2-2.fc20 Resolution|NEXTRELEASE |ERRATA --- Comment #12 from Fedora Update System --- nodejs-astral-angular-annotate-0.0.2-2.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174893] Review Request: dnf-plugins-extras - Extras Plugins for DNF
https://bugzilla.redhat.com/show_bug.cgi?id=1174893 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- dnf-plugins-extras-0.0.1-2.fc21 has been pushed to the Fedora 21 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169115] Review Request: nodejs-console-browserify - Emulate console for all the browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1169115 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-console-browserify-1 ||.1.0-1.fc20 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-console-browserify-1.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171334] Review Request: nodejs-pascal-case - Pascal case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171334 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-pascal-case-1.0.0-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171320] Review Request: nodejs-title-case - Title case a string
https://bugzilla.redhat.com/show_bug.cgi?id=1171320 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- nodejs-title-case-1.0.1-1.fc20 has been pushed to the Fedora 20 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170812] Review Request: nodejs-astral - AST tooling framework for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1170812 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-astral-0.1.0-2.fc19 Resolution|NEXTRELEASE |ERRATA --- Comment #11 from Fedora Update System --- nodejs-astral-0.1.0-2.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1165620] Review Request: biber - Command-line bibliographic manager, BibTeX replacement
https://bugzilla.redhat.com/show_bug.cgi?id=1165620 Bug 1165620 depends on bug 1165639, which changed state. Bug 1165639 Summary: Review Request: perl-Business-ISMN - perl extension to work with International Standard Music Numbers https://bugzilla.redhat.com/show_bug.cgi?id=1165639 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1165639] Review Request: perl-Business-ISMN - perl extension to work with International Standard Music Numbers
https://bugzilla.redhat.com/show_bug.cgi?id=1165639 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||perl-Business-ISMN-1.11-4.f ||c21 Resolution|--- |ERRATA Last Closed||2014-12-21 01:35:22 --- Comment #9 from Fedora Update System --- perl-Business-ISMN-1.11-4.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1175023 --- Comment #6 from Niranjan MR --- Thanks for the comments, Could you update the spec file and srpm and provide the links here, So that it could be reviewed by others. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 --- Comment #16 from Fedora Update System --- python-tilestache-1.49.11-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-tilestache-1.49.11-3.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 --- Comment #13 from Fedora Update System --- python-tilestache-1.49.11-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/python-tilestache-1.49.11-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 --- Comment #15 from Fedora Update System --- python-tilestache-1.49.11-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-tilestache-1.49.11-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1147356] Review Request: python-tilestache - A stylish alternative for caching your map tiles
https://bugzilla.redhat.com/show_bug.cgi?id=1147356 --- Comment #14 from Fedora Update System --- python-tilestache-1.49.11-3.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-tilestache-1.49.11-3.fc19 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1175023 --- Comment #5 from Gerald Cox --- I saw that, but unfortunately that method won't work. There is an issue with github that submodules are not included in the archives - so if I were to do that, there would be an error mismatch between the local source archive which builds the package and url version. The only way to get around it is to use the version control method: https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Using_Revision_Control I also did a google search and found the emacs-rinari package which is currently in the Fedora Production repository uses a git repo with submodules. I took the same approach. The one change I made was to use the git --branch option which pulls the exact version of code, ensuring a match. Thanks again for taking the time to review my package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1159660] Review Request: WALinuxAgent - The Windows Azure Linux Agent
https://bugzilla.redhat.com/show_bug.cgi?id=1159660 --- Comment #6 from Scott K Logan --- Okay, I'm starting to see that re-factoring the sample spec is not going to work. At this rate, we will have modified the entire thing just to meet packaging specifications. I made a spec from scratch that should conform. Spec URL: https://cottsay.fedorapeople.org/WALinuxAgent2/WALinuxAgent.spec SRPM URL: https://cottsay.fedorapeople.org/WALinuxAgent2/WALinuxAgent-2.0.11-1.fc22.src.rpm Notes: - %config without (noreplace) implies replace. You can't actually specify (replace) with %config. In any case, I'm pretty sure this should be (noreplace), so I changed it. - logrotate.d should not be owned by this package, only the single file inside it. - Do you think it is a good move to switch to systemd for epel7? You're more knowledgeable here, so I'll let you make the call and adjust the logic appropriately. Thanks, --scott -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172800] Review Request: dwgrep - A tool for querying Dwarf (debuginfo) graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1172800 --- Comment #10 from Petr Machata --- Mostly this is modeled after elfutils. I like the idea of keeping the headers of a project together in a directory. libzwerg is also fairly easily extensible, so someone could come up with their own set of words for navigating stuff that they are interested in. They would then naturally use this directory as well. This possibility is somewhat remote, as there is no public API for this, but at some point it likely will be. The whole Dwarf module could then be converted to a separate DSO and provided as an independent module which just uses core libzwerg API. Those are all blue-sky plans though. Near-term there are more pressing issues (see the fairly extensive TODO in the source tarball). A user could pass -I /usr/include/libzwerg if they wish to use the simple inclusion scheme. But the whole API is experimental at this point, and undocumented (unlike the query language itself, which I'd like to keep fairly stable), so this can all change in arbitrary ways. Even though I have symbol versioning in, it will likely not be used seriously until some later release. E.g. note the function named zw_stack_dump_xxx, which is actually exported by the version script. (In reply to Zbigniew Jędrzejewski-Szmek from comment #9) > - maybe move the documentation from /usr/share/doc/dwgrep-doc/ to > /usr/share/doc/dwgrep/html? That makes sense. But wouldn't then dwgrep-doc have to depend on dwgrep? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 969700] Review Request: libccp4 - Library providing specific CCP4 functionality
https://bugzilla.redhat.com/show_bug.cgi?id=969700 Tim Fenn changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Tim Fenn --- Package Change Request == Package Name: libccp4 New Branches: epel7 Owners: timfenn InitialCC: timfenn -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128662] Review Request: ceres-solver - A non-linear least squares minimizer
https://bugzilla.redhat.com/show_bug.cgi?id=1128662 --- Comment #1 from Scott K Logan --- The links appear to be dead. Any chance you could post them somewhere else? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1114413] Review Request: python-flask-cors - Flask extension to support cross origin resource sharing
https://bugzilla.redhat.com/show_bug.cgi?id=1114413 --- Comment #6 from Tom Prince --- I've submitted https://github.com/wcdolphin/flask-cors/pull/93 to address _version. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636
--- Comment #21 from Christian Dersch ---
Thank you for your comments :)
(In reply to Björn "besser82" Esser from comment #18)
> Please open a seperate bug for the ExcludeArch: %{arm}.
https://bugzilla.redhat.com/show_bug.cgi?id=1176345
>
> Spec-file doesn't properly handle translations… "Keep in mind that usage of
> %find_lang in packages containing locales is a MUST." [1]
Fixed in scidavis-1.D8-6
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119056] Review Request: python-idna - Internationalized Domain Names in Applications (IDNA)
https://bugzilla.redhat.com/show_bug.cgi?id=1119056 Tom Prince changed: What|Removed |Added Flags|needinfo?(tom.prince@ualber | |ta.net) | --- Comment #6 from Tom Prince --- Updated spec: https://github.com/ClusterHQ/fedora-packages/raw/2b3f62d57594440aee43fdba46a6775185f0b8e6/python-idna.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119004] Review Request: python-characteristic - Say 'yes' to types but 'no' to typing!
https://bugzilla.redhat.com/show_bug.cgi?id=1119004 --- Comment #6 from Tom Prince --- I've bumped the version to 14.3. I don't see any tabs, and all the spelling things are false-positivies. Spec URL: https://raw.githubusercontent.com/ClusterHQ/fedora-packages/2b3f62d57594440aee43fdba46a6775185f0b8e6/python-characteristic.spec SRPM URL: http://data.hybridcluster.net/fedora-scratch/python-characteristic-14.3.0-1.fc20.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=8451839 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636 --- Comment #20 from Fedora Update System --- scidavis-1.D8-6.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/scidavis-1.D8-6.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636 --- Comment #19 from Fedora Update System --- scidavis-1.D8-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/scidavis-1.D8-6.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175023] Review Request: oggify - audio conversion tool for music library conversion
https://bugzilla.redhat.com/show_bug.cgi?id=1175023 --- Comment #4 from Niranjan MR --- Could you follow the method suggested in below link when giving source urls from github https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1173773] Review Request: php-bantu-ini-get-wrapper - Convenience wrapper around PHP's ini_get() function
https://bugzilla.redhat.com/show_bug.cgi?id=1173773 Adam Williamson (Fedora) changed: What|Removed |Added Flags||fedora-cvs? --- Comment #21 from Adam Williamson (Fedora) --- New Package SCM Request === Package Name: php-bantu-ini-get-wrapper Short Description: Convenience wrapper around PHP's ini_get() function Upstream URL: https://github.com/bantuXorg/php-ini-get-wrapper Owners: adamwill Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=1176273
--- Comment #4 from MartinKG ---
Hi Raphael,
thanks for your reply,
(In reply to Raphael Groner from comment #3)
> Hi Martin,
>
> there are some hints for your spec file. Maybe I can do the official review
> as well.
>
> * SHOULD consider to name the package 'asqp' as upstream does partly for the
> project name? Well, I can see that the source tarball is using that full
> name like in the subject.
> https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming
>
ok, i will name the package/spec file asgp/asgp.spec
> * SHOULD remove the Group tag cause it's obosolete. Note: This tag is
> deprecated since Fedora 17.
> https://fedoraproject.org/wiki/
> How_to_create_an_RPM_package#SPEC_file_overview
>
done
> * MUST use a valid Source URL, or add a comment how to build the tarball.
> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
>
> This?
> http://www.stuff-o-matic.com/asgp/download/download.php?platform=source
>
yes this is a valid link for asgp-1.0.8
but there is a recent version 1.0.12 on https://github.com/j-jorge/asgp/
build instruction:
mkdir asgp-build
cd asgp-build
git clone https://github.com/j-jorge/bear.git
git clone https://github.com/j-jorge/asgp.git
[root@fc21 asgp-build]# du -sk *
1140264asgp
37616bear
approx. 1,17 GByte
should we use this version ?
>
> * MUST build with mock and koji (scratch) to ensure all BR are correct.
> https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
> https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
>
already done, but no additional build requires are detected.
> * SHOULD fix/patch CMakeLists.txt to not enforce docbook2x as it seems to
> create conflicts. And please send your patch to upstream, do they know about
> that issue?
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
> > # Cmake suggests it but "parser error" will be got.
> > BuildConflicts: docbook2x
>
can you send me a patch ?
> * SHOULD what is "Plee the Bear"? How is it related to this package? You
> won't be able to create two individual subpackges for that 'bear' and
> 'bear-factory' stuff. So consider to package that separately and unbundle.
> https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> > of the Bear Engine for Plee the Bear & Andy's Super Great Park.
>
not done, because not clear.
> * MUST 'Require: hicolor-icon-theme' cause of the folder ownership.
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#File_and_Directory_Ownership
> > %files
> > …
> > %{_datadir}/icons/hicolor/*/apps/asgp.png
>
added Require: hicolor-icon-theme
is this ok ?
> * MUST (when possible) use the %cmake macro to avoid relisting of all those
> parameters like RPATH etc.
> https://fedoraproject.org/wiki/Packaging:Cmake
- done, replaced cmake with %cmake
Spec URL: https://martinkg.fedorapeople.org/Review/asgp-1.0.8-3/asgp.spec
%changelog
* Sat Dec 20 2014 Martin Gansser - 1.0.8-3
- changed package name from andy-super-great-park to asgp
- added valid Source URL
- added download instruction
- removed group tag
- added CMAKE_VERBOSE_MAKEFILE=TRUE to %%make build verbose
- added Require hicolor-icon-theme
- used macro %%cmake
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171231] Review Request: nodejs-object-assign - ES6 Object.assign() ponyfill
https://bugzilla.redhat.com/show_bug.cgi?id=1171231 Parag changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170802] Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative
https://bugzilla.redhat.com/show_bug.cgi?id=1170802 Piotr Popieluch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Piotr Popieluch --- Thank you for review. Will add the enable_tests condition before pushing. New Package SCM Request === Package Name: nodejs-relateurl Short Description: - Minify URLs by converting them from absolute to relative Upstream URL: https://github.com/stevenvachon/relateurl Owners: piotrp Branches: f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636
Björn "besser82" Esser changed:
What|Removed |Added
Status|MODIFIED|ASSIGNED
Blocks|485251 (F-ExcludeArch-ARM) |
--- Comment #18 from Björn "besser82" Esser ---
Please open a seperate bug for the ExcludeArch: %{arm}.
Spec-file doesn't properly handle translations… "Keep in mind that usage of
%find_lang in packages containing locales is a MUST." [1]
[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Handling_Locale_Files
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=485251
[Bug 485251] ExcludeArch Tracker for ARM
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170802] Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative
https://bugzilla.redhat.com/show_bug.cgi?id=1170802
Parag AN(पराग) changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Parag AN(पराग) ---
Looks good now. But you can also write BR: specific to tests like
%if 0%{?enable_tests}
BuildRequires: mocha
BuildRequires: npm(chai)
%endif
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1173204] Review Request: nodejs-as-number - Tiny function that returns the given number, or a default value
https://bugzilla.redhat.com/show_bug.cgi?id=1173204 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Parag --- Thank you for this package review. New Package SCM Request === Package Name: nodejs-as-number Short Description: Tiny function that returns the given number, or a default value Upstream URL: https://github.com/mattdesl/as-number Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1173204] Review Request: nodejs-as-number - Tiny function that returns the given number, or a default value
https://bugzilla.redhat.com/show_bug.cgi?id=1173204
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review+
--- Comment #1 from Piotr Popieluch ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1173204-nodejs-as-
number/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build int
[Bug 1172974] Review Request: nodejs-split - Split a text stream into a line stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172974 Parag changed: What|Removed |Added Flags||fedora-cvs? --- Comment #4 from Parag --- Thank you for this package review. New Package SCM Request === Package Name: nodejs-split Short Description: Split a text stream into a line stream Upstream URL: https://github.com/dominictarr/split Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172975] Review Request: nodejs-stream-reduce - Reduce stream data to a single value
https://bugzilla.redhat.com/show_bug.cgi?id=1172975 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Parag --- Updated changelog. Thank you for this package review. New Package SCM Request === Package Name: nodejs-stream-reduce Short Description: Reduce stream data to a single value Upstream URL: https://github.com/parshap/node-stream-reduce/ Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172800] Review Request: dwgrep - A tool for querying Dwarf (debuginfo) graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1172800 --- Comment #9 from Zbigniew Jędrzejewski-Szmek --- Two questions: - how is libzwerg headers supposed to be used? Currently it'd be #include . Shouldn't the headers be installed directly in /usr/include, so it is enough to say #include ? (Really an upstream question, but still worth answering). - maybe move the documentation from /usr/share/doc/dwgrep-doc/ to /usr/share/doc/dwgrep/html? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172975] Review Request: nodejs-stream-reduce - Reduce stream data to a single value
https://bugzilla.redhat.com/show_bug.cgi?id=1172975
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review+
--- Comment #1 from Piotr Popieluch ---
nodejs-stream-reduce.noarch: W: incoherent-version-in-changelog 6.0.2-1
['1.0.3-1.fc22', '1.0.3-1']
Please update version number in changelog entry to match the actual version
before pusing to SCM.
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 3 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1172975-nodejs-stream-
reduce/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[-]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_RO
[Bug 1172974] Review Request: nodejs-split - Split a text stream into a line stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172974
Piotr Popieluch changed:
What|Removed |Added
Flags|fedora-review- |fedora-review+
--- Comment #3 from Piotr Popieluch ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 6 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1172974-nodejs-
split/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic
[Bug 1175878] Review Request: nodejs-html-minifier - HTML minifier with lint-like capabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1175878 Piotr Popieluch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Piotr Popieluch --- Thank you for review. Group tag removed. Could you please check https://bugzilla.redhat.com/show_bug.cgi?id=1170802 as it blocks this package? New Package SCM Request === Package Name: nodejs-html-minifier Short Description: HTML minifier with lint-like capabilities Upstream URL: https://kangax.github.io/html-minifier/ Owners: piotrp Branches: f20 f21 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172525] Review Request: zbackup - A versatile deduplicating backup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1172525 Vladimir Stackov changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172525] Review Request: zbackup - A versatile deduplicating backup tool
https://bugzilla.redhat.com/show_bug.cgi?id=1172525 --- Comment #14 from Vladimir Stackov --- New Package SCM Request === Package Name: zbackup Short Description: A versatile deduplicating backup tool Upstream URL: http://zbackup.org/ Owners: am1g0 Branches: f20 f21 f22 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175878] Review Request: nodejs-html-minifier - HTML minifier with lint-like capabilities
https://bugzilla.redhat.com/show_bug.cgi?id=1175878 Parag AN(पराग) changed: What|Removed |Added Status|NEW |ASSIGNED CC||panem...@gmail.com Assignee|nob...@fedoraproject.org|panem...@gmail.com Flags||fedora-review+ --- Comment #1 from Parag AN(पराग) --- Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-html-minifier.noarch: W: only-non-binary-in-usr-lib nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/change-case /usr/lib/node_modules/change-case nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/clean-css /usr/lib/node_modules/clean-css nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/cli /usr/lib/node_modules/cli nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/uglify-js /usr/lib/node_modules/uglify-js@2 nodejs-html-minifier.noarch: W: dangling-symlink /usr/lib/node_modules/html-minifier/node_modules/relateurl /usr/lib/node_modules/relateurl nodejs-html-minifier.src: W: strange-permission nodejs-html-minifier-dl-tests.sh 0755L nodejs-html-minifier.src: W: invalid-url Source1: nodejs-html-minifier-tests-v0.6.9.tar.bz2 2 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball: 5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b upstream tarball: 5e58d4e5bb59ed6b24da67b822f30af8f016d3d19331981c1aea8f9349a7047b + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) Group tag is optional and can be removed. APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172973] Review Request: nodejs-from - Easy way to make a Readable Stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172973 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #3 from Parag --- Updated the above srpm. Thank you for this package review. New Package SCM Request === Package Name: nodejs-from Short Description: Easy way to make a Readable Stream Upstream URL: http://github.com/dominictarr/from Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171749] Review Request: nodejs-ascii-tree - A node module for generating a text tree in ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1171749 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Parag --- Thank you for this package review. New Package SCM Request === Package Name: nodejs-ascii-tree Short Description: A node module for generating a text tree in ASCII Upstream URL: https://github.com/liushuping/ascii-tree Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171230] Review Request: nodejs-registry-url - Get the set npm registry URL
https://bugzilla.redhat.com/show_bug.cgi?id=1171230 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #5 from Parag --- Thank you for this package review. New Package SCM Request === Package Name: nodejs-registry-url Short Description: Get the set npm registry URL Upstream URL: https://github.com/sindresorhus/registry-url Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172974] Review Request: nodejs-split - Split a text stream into a line stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172974 Parag changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Parag --- Updated please check again above SRPM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176277] Review Request: Shinobi - Meta build system for Ninja
https://bugzilla.redhat.com/show_bug.cgi?id=1176277
--- Comment #2 from Ivan Romanov ---
sed script in %build section is not the sane. I think here SHOULD be used
patch.
What is %{sample} ? How you got this?
What do diff in %check section?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176307] Review Request: torrent-file-editor - Qt based GUI tool designed to create and edit .torrent files
https://bugzilla.redhat.com/show_bug.cgi?id=1176307 --- Comment #3 from Ivan Romanov --- wrong previous srpm url Spec URL: https://raw.githubusercontent.com/drizt/torrent-file-editor-package/717d16ebc342a77e0464cd795c8fba78691cf581/torrent-file-editor.spec SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/8790/8448790/torrent-file-editor-0.1.0-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172974] Review Request: nodejs-split - Split a text stream into a line stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172974 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com Flags||fedora-review- --- Comment #1 from Piotr Popieluch --- - URL incorrect - version number in changelog does not match packaged version Could you fix these, will continue review after. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176307] Review Request: torrent-file-editor - Qt based GUI tool designed to create and edit .torrent files
https://bugzilla.redhat.com/show_bug.cgi?id=1176307
--- Comment #2 from Ivan Romanov ---
(In reply to Raphael Groner from comment #1)
> Hi Ivan,
>
> there are some hints for your spec file. Please fix those, then I can
> continue with the review.
>
> * Use macros whereever possible. Don't use a slash at the end of the URL.
> You can use just 'sf' as abbreviation 'sourceforge'.
>
> - URL:http://sourceforge.net/projects/torrent-file-editor/
> + URL:http://sf.net/projects/%{name}
Fixed.
> - Source0:
> http://sourceforge.net/projects/%{name}/files/%{name}-%{version}.tar.gz
> + Source0:%{url}/files/%{name}-%{version}.tar.gz
It's not correct.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Sourceforge.net
> * MUST 'Require: hicolor-icon-theme' cause of the folder ownership.
> https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/
> Guidelines#File_and_Directory_Ownership
>
> > %files
> > …
> > %{_datadir}/icons/hicolor/*/apps/%{name}.png
Fixed.
> * SHOULD tell us more about your package in %description. Consider to write
> about the features as mentioned so at the sourceforge page.
Fixed.
> * SHOULD directly get the source tarball from github without using
> sourceforge
> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/
> SourceURL#Github
It's not correct.
> If the upstream does create tarballs you should use them as tarballs provide
> an easier trail for people auditing the packages.
In this case upstream creates tarballs. So I use them.
> * Additional question: Why do you not use Qt5 also in Fedora, like you do
> for the tree product? Fedora 21 has Qt5 packages.
Qt4 now is main. Qt5 only for development as I understand. Anyway Qt5 variant
looks ugly. I don't want to use it. When Qt5 become stable I will transtition
to it.
Spec URL:
https://raw.githubusercontent.com/drizt/torrent-file-editor-package/717d16ebc342a77e0464cd795c8fba78691cf581/torrent-file-editor.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/8973/8448973/torrent-file-editor-0.1.0-1.fc22.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=1176273
Raphael Groner changed:
What|Removed |Added
CC||projects...@smart.ms
--- Comment #3 from Raphael Groner ---
Hi Martin,
there are some hints for your spec file. Maybe I can do the official review as
well.
* SHOULD consider to name the package 'asqp' as upstream does partly for the
project name? Well, I can see that the source tarball is using that full name
like in the subject.
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#General_Naming
* SHOULD remove the Group tag cause it's obosolete. Note: This tag is
deprecated since Fedora 17.
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#SPEC_file_overview
* MUST use a valid Source URL, or add a comment how to build the tarball.
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL
This?
http://www.stuff-o-matic.com/asgp/download/download.php?platform=source
* MUST build with mock and koji (scratch) to ensure all BR are correct.
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires
https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds
* SHOULD fix/patch CMakeLists.txt to not enforce docbook2x as it seems to
create conflicts. And please send your patch to upstream, do they know about
that issue?
https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment
> # Cmake suggests it but "parser error" will be got.
> BuildConflicts: docbook2x
* SHOULD what is "Plee the Bear"? How is it related to this package? You won't
be able to create two individual subpackges for that 'bear' and 'bear-factory'
stuff. So consider to package that separately and unbundle.
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries
> of the Bear Engine for Plee the Bear & Andy's Super Great Park.
* MUST 'Require: hicolor-icon-theme' cause of the folder ownership.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership
> %files
> …
> %{_datadir}/icons/hicolor/*/apps/asgp.png
* MUST (when possible) use the %cmake macro to avoid relisting of all those
parameters like RPATH etc.
https://fedoraproject.org/wiki/Packaging:Cmake
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172973] Review Request: nodejs-from - Easy way to make a Readable Stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172973
Piotr Popieluch changed:
What|Removed |Added
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review+
--- Comment #2 from Piotr Popieluch ---
Please fix the version number in the changelog before pushing to SCM
[!]: Changelog in prescribed format.
- Version number in changelog incorrect
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1172973-nodejs-from/licensecheck.txt
[-]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[!]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not s
[Bug 1172973] Review Request: nodejs-from - Easy way to make a Readable Stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172973 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com --- Comment #1 from Piotr Popieluch --- Spec url invalid, should be: Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-from.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-from-0.1.3-1.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=1176273 --- Comment #2 from Volker Fröhlich --- Please make the build verbose and make Source0 a URL. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171749] Review Request: nodejs-ascii-tree - A node module for generating a text tree in ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1171749 Piotr Popieluch changed: What|Removed |Added Assignee|nob...@fedoraproject.org|piotr1...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171749] Review Request: nodejs-ascii-tree - A node module for generating a text tree in ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1171749
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Flags||fedora-review+
--- Comment #1 from Piotr Popieluch ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1171749-nodejs-ascii-
tree/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %glo
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636 --- Comment #17 from Fedora Update System --- scidavis-1.D8-5.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/scidavis-1.D8-5.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176273] Review Request: andy-super-great-park - 2D arcade game
https://bugzilla.redhat.com/show_bug.cgi?id=1176273 Volker Fröhlich changed: What|Removed |Added CC||volke...@gmx.at Summary|Review Request: |Review Request: |andy-super-great-park - |andy-super-great-park - 2D |andy-super-great-park |arcade game -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127636] Review Request: scidavis - Application for Scientific Data Analysis and Visualization
https://bugzilla.redhat.com/show_bug.cgi?id=1127636 --- Comment #16 from Fedora Update System --- scidavis-1.D8-5.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/scidavis-1.D8-5.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171230] Review Request: nodejs-registry-url - Get the set npm registry URL
https://bugzilla.redhat.com/show_bug.cgi?id=1171230
Piotr Popieluch changed:
What|Removed |Added
Flags|fedora-review- |fedora-review+
--- Comment #4 from Piotr Popieluch ---
Looks good now,
APPROVED
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1171230-nodejs-registry-
url/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[?]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[!]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]:
[Bug 1176307] Review Request: torrent-file-editor - Qt based GUI tool designed to create and edit .torrent files
https://bugzilla.redhat.com/show_bug.cgi?id=1176307
Raphael Groner changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Raphael Groner ---
Hi Ivan,
there are some hints for your spec file. Please fix those, then I can continue
with the review.
* Use macros whereever possible. Don't use a slash at the end of the URL. You
can use just 'sf' as abbreviation 'sourceforge'.
- URL:http://sourceforge.net/projects/torrent-file-editor/
+ URL:http://sf.net/projects/%{name}
- Source0:
http://sourceforge.net/projects/%{name}/files/%{name}-%{version}.tar.gz
+ Source0:%{url}/files/%{name}-%{version}.tar.gz
* MUST 'Require: hicolor-icon-theme' cause of the folder ownership.
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#File_and_Directory_Ownership
> %files
> …
> %{_datadir}/icons/hicolor/*/apps/%{name}.png
* SHOULD tell us more about your package in %description. Consider to write
about the features as mentioned so at the sourceforge page.
* SHOULD directly get the source tarball from github without using sourceforge
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github
* Additional question: Why do you not use Qt5 also in Fedora, like you do for
the tree product? Fedora 21 has Qt5 packages.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171230] Review Request: nodejs-registry-url - Get the set npm registry URL
https://bugzilla.redhat.com/show_bug.cgi?id=1171230 --- Comment #3 from Parag --- Got it. For tests I need BR: npm(rc) Added and uploaded in same release. Please check again. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171607] Review Request: nodejs-caller-path - Get the path of the caller module
https://bugzilla.redhat.com/show_bug.cgi?id=1171607 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:15 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171749] Review Request: nodejs-ascii-tree - A node module for generating a text tree in ASCII
https://bugzilla.redhat.com/show_bug.cgi?id=1171749 Bug 1171749 depends on bug 1171748, which changed state. Bug 1171748 Summary: Review Request: nodejs-freetree - A node module for creating tree data structure from text input https://bugzilla.redhat.com/show_bug.cgi?id=1171748 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172972] Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172972 Bug 1172972 depends on bug 1172971, which changed state. Bug 1172971 Summary: Review Request: nodejs-duplexer - Creates a duplex stream https://bugzilla.redhat.com/show_bug.cgi?id=1172971 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171748] Review Request: nodejs-freetree - A node module for creating tree data structure from text input
https://bugzilla.redhat.com/show_bug.cgi?id=1171748 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:07 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171607] Review Request: nodejs-caller-path - Get the path of the caller module
https://bugzilla.redhat.com/show_bug.cgi?id=1171607 Bug 1171607 depends on bug 1171606, which changed state. Bug 1171606 Summary: Review Request: nodejs-callsites - Get callsites from the V8 stack trace API https://bugzilla.redhat.com/show_bug.cgi?id=1171606 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172969] Review Request: nodejs-pause-stream - A ThroughStream that strictly buffers all readable events when paused
https://bugzilla.redhat.com/show_bug.cgi?id=1172969 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:13 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171608] Review Request: nodejs-require-uncached - Require a module bypassing the cache
https://bugzilla.redhat.com/show_bug.cgi?id=1171608 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:08 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171606] Review Request: nodejs-callsites - Get callsites from the V8 stack trace API
https://bugzilla.redhat.com/show_bug.cgi?id=1171606 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:16 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172968] Review Request: nodejs-event-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172968 Bug 1172968 depends on bug 1172971, which changed state. Bug 1172971 Summary: Review Request: nodejs-duplexer - Creates a duplex stream https://bugzilla.redhat.com/show_bug.cgi?id=1172971 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171605] Review Request: nodejs-resolve-from - Resolve the path of a module like require.resolve() but from a given path
https://bugzilla.redhat.com/show_bug.cgi?id=1171605 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:10 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172970] Review Request: nodejs-map-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172970 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:09 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172968] Review Request: nodejs-event-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172968 Bug 1172968 depends on bug 1172970, which changed state. Bug 1172970 Summary: Review Request: nodejs-map-stream - Construct pipes of streams of events https://bugzilla.redhat.com/show_bug.cgi?id=1172970 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171234] Review Request: nodejs-ttembed-js - Set embedding level of TrueType fonts module for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1171234 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171608] Review Request: nodejs-require-uncached - Require a module bypassing the cache
https://bugzilla.redhat.com/show_bug.cgi?id=1171608 Bug 1171608 depends on bug 1171607, which changed state. Bug 1171607 Summary: Review Request: nodejs-caller-path - Get the path of the caller module https://bugzilla.redhat.com/show_bug.cgi?id=1171607 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172968] Review Request: nodejs-event-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172968 Bug 1172968 depends on bug 1172969, which changed state. Bug 1172969 Summary: Review Request: nodejs-pause-stream - A ThroughStream that strictly buffers all readable events when paused https://bugzilla.redhat.com/show_bug.cgi?id=1172969 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172968] Review Request: nodejs-event-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172968 Bug 1172968 depends on bug 1172972, which changed state. Bug 1172972 Summary: Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream https://bugzilla.redhat.com/show_bug.cgi?id=1172972 What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172971] Review Request: nodejs-duplexer - Creates a duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172971 Parag changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171230] Review Request: nodejs-registry-url - Get the set npm registry URL
https://bugzilla.redhat.com/show_bug.cgi?id=1171230 Bug 1171230 depends on bug 1171608, which changed state. Bug 1171608 Summary: Review Request: nodejs-require-uncached - Require a module bypassing the cache https://bugzilla.redhat.com/show_bug.cgi?id=1171608 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171608] Review Request: nodejs-require-uncached - Require a module bypassing the cache
https://bugzilla.redhat.com/show_bug.cgi?id=1171608 Bug 1171608 depends on bug 1171605, which changed state. Bug 1171605 Summary: Review Request: nodejs-resolve-from - Resolve the path of a module like require.resolve() but from a given path https://bugzilla.redhat.com/show_bug.cgi?id=1171605 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172972] Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172972 Parag changed: What|Removed |Added Status|MODIFIED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2014-12-20 06:29:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172972] Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172972 --- Comment #8 from Parag --- Built in rawhide, therefore closing this now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
