[Bug 1177494] New: Review Request: paper-gtk-theme - Paper GTK Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1177494 Bug ID: 1177494 Summary: Review Request: paper-gtk-theme - Paper GTK Theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: echevemas...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://echevemaster.fedorapeople.org/paper-gtk-theme/paper-gtk-theme.spec SRPM URL: https://echevemaster.fedorapeople.org/paper-gtk-theme/paper-gtk-theme-1.0-0.1.20141227gite1d8cb1.fc20.src.rpm Paper themes for GTK+2, GTK+3, Metacity and GNOME Shell Fedora Account System Username: echevemaster -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172976] Review Request: nodejs-follow - Extremely robust, fault-tolerant CouchDB changes follower
https://bugzilla.redhat.com/show_bug.cgi?id=1172976 Parag changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Parag --- Tests are disabled. Will work with upstream to fix errors. Updated package as Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-follow.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-follow-0.11.4-2.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 821917] Review Request: mu - maildir utility with Emacs support
https://bugzilla.redhat.com/show_bug.cgi?id=821917
--- Comment #24 from Christopher Meng ---
I still can see %define macro in the spec. And it really doesn't make too much
sense to replace 4 chars dcjb with 8 chars %{owner}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 Bug 1175952 depends on bug 1164257, which changed state. Bug 1164257 Summary: Review Request: efl - Enlightenment Fundament Library https://bugzilla.redhat.com/show_bug.cgi?id=1164257 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 Christopher Meng changed: What|Removed |Added CC||serein...@online.fr --- Comment #3 from Christopher Meng --- *** Bug 1164257 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1164257] Review Request: efl - Enlightenment Fundament Library
https://bugzilla.redhat.com/show_bug.cgi?id=1164257 Christopher Meng changed: What|Removed |Added Status|NEW |CLOSED CC||i...@cicku.me Resolution|--- |DUPLICATE Last Closed||2014-12-27 21:32:09 --- Comment #3 from Christopher Meng --- As you are not the current maintainer of efl series(those obsoletes) in pkgdb, I hope you can let the current maintainer Tom to finish this. Because this package will touch many others which means you can't push it without consent from other maintainers. *** This bug has been marked as a duplicate of bug 1175952 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177463] Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams
https://bugzilla.redhat.com/show_bug.cgi?id=1177463 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Parag --- Thanks for this review. New Package SCM Request === Package Name: nodejs-stream-spigot Short Description: Testing or converting simple functions into Readable streams Upstream URL: https://github.com/brycebaril/node-stream-spigot Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #5 from Parag --- I have already submitted nodejs-streaam-spigot for package review. See https://bugzilla.redhat.com/show_bug.cgi?id=1177463 BR: npm(tape) added please check again. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171553] Review Request: csvdiff - Generate a diff between two CSV files on the command-line
https://bugzilla.redhat.com/show_bug.cgi?id=1171553
--- Comment #3 from William Moreno ---
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/csvdiff.spec
SRPM URL:
https://williamjmorenor.fedorapeople.org/rpmdev/csvdiff-0.1.0-2.fc20.src.rpm
Thanks for the feedback:
# Patched the shebang for files in %%{_bindir}
# Build with python3
# Request upstream to add a manpage
(https://github.com/larsyencken/csvdiff/issues/5)
Looks like test is faling :( I have noticed upstream about that
(https://github.com/larsyencken/csvdiff/issues/3)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 --- Comment #8 from Jan Chaloupka --- Lokesh, I have assigned those two bugs on you. Peter, don't hesitate to make a review of them if you have some spare time. Happy New Year :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177486 Jan Chaloupka changed: What|Removed |Added Blocks||1175471 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1175471 [Bug 1175471] Review Request: fleet - A distributed init system -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177487] Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file
https://bugzilla.redhat.com/show_bug.cgi?id=1177487 Jan Chaloupka changed: What|Removed |Added Blocks||1175471 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1175471 [Bug 1175471] Review Request: fleet - A distributed init system -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 Jan Chaloupka changed: What|Removed |Added Depends On||1177487, 1177486 --- Comment #7 from Jan Chaloupka --- Done. Must update the test for deps in Godeps folder. Thanks. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177486 [Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser in go https://bugzilla.redhat.com/show_bug.cgi?id=1177487 [Bug 1177487] Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177486 Jan Chaloupka changed: What|Removed |Added Blocks||1177487 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177487 [Bug 1177487] Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177487] Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file
https://bugzilla.redhat.com/show_bug.cgi?id=1177487 Jan Chaloupka changed: What|Removed |Added Status|NEW |ASSIGNED Depends On||1177486 Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review? Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177486 [Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser in go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177487] New: Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file
https://bugzilla.redhat.com/show_bug.cgi?id=1177487 Bug ID: 1177487 Summary: Review Request: golang-github-rakyll-globalconf - Effortlessly persist and read flag values from an ini config file Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rakyll-globalconf/golang-github-rakyll-globalconf.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rakyll-globalconf/golang-github-rakyll-globalconf-0-0.1.git415abc3.fc20.src.rpm Description: Effortlessly persist and read flag values from an ini config file Fedora Account System Username: jchaloup $ rpmlint golang-github-rakyll-globalconf-0-0.1.git415abc3.fc20.src.rpm golang-github-rakyll-globalconf-devel-0-0.1.git415abc3.fc20.noarch.rpm golang-github-rakyll-globalconf.spec golang-github-rakyll-globalconf.src: W: spelling-error Summary(en_US) ini -> uni, in, ii golang-github-rakyll-globalconf.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure golang-github-rakyll-globalconf.src: W: spelling-error %description -l en_US ini -> uni, in, ii golang-github-rakyll-globalconf.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure golang-github-rakyll-globalconf-devel.noarch: W: spelling-error Summary(en_US) ini -> uni, in, ii golang-github-rakyll-globalconf-devel.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure golang-github-rakyll-globalconf-devel.noarch: W: spelling-error %description -l en_US ini -> uni, in, ii golang-github-rakyll-globalconf-devel.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure 2 packages and 1 specfiles checked; 0 errors, 8 warnings. Upstream: https://github.com/rakyll/globalconf Koji: depends on https://github.com/rakyll/globalconf, which has review request #1177486. Locally build succesfully. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177486] Review Request: golang-github-rakyll-goini - INI file parser in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177486 Jan Chaloupka changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177486] New: Review Request: golang-github-rakyll-goini - INI file parser in go
https://bugzilla.redhat.com/show_bug.cgi?id=1177486 Bug ID: 1177486 Summary: Review Request: golang-github-rakyll-goini - INI file parser in go Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rakyll-goini/golang-github-rakyll-goini.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-rakyll-goini/golang-github-rakyll-goini-0-0.1.git907cca0.fc20.src.rpm Description: INI file parser in go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8487016 $ rpmlint golang-github-rakyll-goini-0-0.1.git907cca0.fc20.src.rpm golang-github-rakyll-goini-devel-0-0.1.git907cca0.fc20.noarch.rpm golang-github-rakyll-goini.spec golang-github-rakyll-goini.src: W: invalid-license Not filled so far golang-github-rakyll-goini-devel.noarch: W: invalid-license Not filled so far golang-github-rakyll-goini-devel.noarch: W: no-documentation golang-github-rakyll-goini-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/rakyll/goini/empty.ini 2 packages and 1 specfiles checked; 1 errors, 3 warnings. Upstream: https://github.com/rakyll/goini Notes: There is no README, no LICENSE file, no documentation. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 692131] Review Request: sflphone - SIP/IAX2 compatible enterprise-class softphone for multi-way conferencing
https://bugzilla.redhat.com/show_bug.cgi?id=692131 --- Comment #24 from Sandro Mani --- Things regarding video improved in the latest version 1.4.1, here is now a package which should be ready for Fedora: SPEC: https://smani.fedorapeople.org/review/sflphone.spec SRPM: https://smani.fedorapeople.org/review/sflphone-1.4.1-1.fc22.src.rpm The only blocker which remains is bug 1128464 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176895] Review Request: nodejs-compress-commons - A library that defines a common interface for working with archive formats
https://bugzilla.redhat.com/show_bug.cgi?id=1176895 --- Comment #7 from Fedora Update System --- nodejs-compress-commons-0.2.0-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-compress-commons-0.2.0-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #4 from Piotr Popieluch --- Mock build fails. Tests need BR: npm(tape), could you please add this? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 952632] Review Request: qtermwidget - Qt4 terminal widget
https://bugzilla.redhat.com/show_bug.cgi?id=952632 Rex Dieter changed: What|Removed |Added Status|MODIFIED|CLOSED CC||rdie...@math.unl.edu Resolution|--- |ERRATA Last Closed|2013-05-04 22:27:21 |2014-12-27 14:52:08 --- Comment #28 from Rex Dieter --- re-closing, no need to have re-opened just for fedora-cvs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177463] Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams
https://bugzilla.redhat.com/show_bug.cgi?id=1177463
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
Flags||fedora-review+
--- Comment #1 from Piotr Popieluch ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 2 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1177463-nodejs-stream-
spigot/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build
[Bug 1123537] Review Request: nodejs-handlebars - Mustache extension for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1123537 --- Comment #25 from Piotr Popieluch --- Could you please push the updates to the stable repositories? I have many packages which I would like to push to stable and depend on handlebars. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170802] Review Request: nodejs-relateurl - Minify URLs by converting them from absolute to relative
https://bugzilla.redhat.com/show_bug.cgi?id=1170802 --- Comment #11 from Fedora Update System --- nodejs-relateurl-0.2.5-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-relateurl-0.2.5-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471 --- Comment #6 from Lokesh Mandvekar --- s/do/to -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175471] Review Request: fleet - A distributed init system
https://bugzilla.redhat.com/show_bug.cgi?id=1175471
--- Comment #5 from Lokesh Mandvekar ---
Hi Peter, we don't need do redefine %{gopath} anymore (since golang-1.2.1-3)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176887] Review Request: nodejs-crc32-stream - A streaming CRC32 checksumer
https://bugzilla.redhat.com/show_bug.cgi?id=1176887 --- Comment #8 from Fedora Update System --- nodejs-crc32-stream-0.3.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-crc32-stream-0.3.1-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119056] Review Request: python-idna - Internationalized Domain Names in Applications (IDNA)
https://bugzilla.redhat.com/show_bug.cgi?id=1119056 Tom Prince changed: What|Removed |Added Flags||fedora-cvs? --- Comment #8 from Tom Prince --- New Package SCM Request === Package Name: python-idna Short Description: Internationalised Domain Names in Applications (IDNA) Upstream URL: https://github.com/kjd/idna Owners: tomprince Branches: f21 f22 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 --- Comment #3 from Piotr Popieluch --- Build fails due to missing deps for tests, could you disable the tests? DEBUG util.py:366: Getting requirements for nodejs-through2-0.6.3-1.fc22.src DEBUG util.py:366: --> nodejs-packaging-7-2.fc21.noarch DEBUG util.py:366: --> nodejs-bl-0.9.3-1.fc22.noarch DEBUG util.py:366: --> nodejs-tap-0.4.4-3.fc22.noarch DEBUG util.py:366: --> nodejs-xtend-4.0.0-2.fc22.noarch DEBUG util.py:366: Error: No Package found for npm(stream-spigot) DEBUG util.py:476: Child return code was: 1 DEBUG util.py:161: kill orphans DEBUG util.py:495: child environment: None -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172976] Review Request: nodejs-follow - Extremely robust, fault-tolerant CouchDB changes follower
https://bugzilla.redhat.com/show_bug.cgi?id=1172976
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Assignee|nob...@fedoraproject.org|piotr1...@gmail.com
QA Contact|extras...@fedoraproject.org |piotr1...@gmail.com
Flags||fedora-review-
--- Comment #1 from Piotr Popieluch ---
- spec file in srpm differs
- incorrect symlink for binary:
please change:
ln -s %{nodejs_sitelib}/%{module_name}/bin/cli.js
%{buildroot}%{_bindir}/follow
into:
ln -s %{nodejs_sitelib}/%{module_name}/cli.js %{buildroot}%{_bindir}/follow
- rpmlint error
nodejs-follow.noarch: E: non-executable-script
/usr/lib/node_modules/follow/browser/export.js 0644L /usr/bin/env
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[!]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[!]: Spec file according to URL is the same as in SRPM.
Note: Spec file as given by url is not the same as in SRPM (see attached
diff).
See: (this test has no URL)
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
Rpmlint
---
Checking: nodejs-follow-0.11.4-1.fc22.noarch.rpm
nodejs-follow-0.11.4-1.fc22.src.rpm
nodejs-follow.noarch: W: only-non-binary-in-usr-lib
nodejs-follow.noarch: W: dangling-symlink /usr/bin/follow
/usr/lib/node_modules/follow/bin/cli.js
nodejs-follow.noarch: W: dangling-symlink
/usr/lib/node_modules/follow/node_modules/browser-request
/usr/lib/node_modules/browser-request
n
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 14 files have unknown licens
[Bug 1176881] Review Request: nodejs-bl - A Node.js Buffer list collector, reader and streamer
https://bugzilla.redhat.com/show_bug.cgi?id=1176881 Parag changed: What|Removed |Added Blocks||1176808 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176808 [Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177463] Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams
https://bugzilla.redhat.com/show_bug.cgi?id=1177463 Parag changed: What|Removed |Added Blocks||1176808 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176808 [Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Parag changed: What|Removed |Added Depends On||1176881, 1177463 --- Comment #2 from Parag --- Updated please check again. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176881 [Bug 1176881] Review Request: nodejs-bl - A Node.js Buffer list collector, reader and streamer https://bugzilla.redhat.com/show_bug.cgi?id=1177463 [Bug 1177463] Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177463] New: Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams
https://bugzilla.redhat.com/show_bug.cgi?id=1177463 Bug ID: 1177463 Summary: Review Request: nodejs-stream-spigot - Testing or converting simple functions into Readable streams Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: pnem...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-stream-spigot.spec SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-stream-spigot-3.0.4-1.fc21.src.rpm Description: A readable stream generator, useful for testing or converting simple functions into Readable streams. Fedora Account System Username: pnemade -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176810] Review Request: nodejs-concat-stream - Writable stream that concatenates strings or binary data and calls a callback with the result
https://bugzilla.redhat.com/show_bug.cgi?id=1176810 Piotr Popieluch changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2014-12-27 12:05:29 --- Comment #2 from Piotr Popieluch --- *** This bug has been marked as a duplicate of bug 1078467 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1176811 Bug 1176811 depends on bug 1176810, which changed state. Bug 1176810 Summary: Review Request: nodejs-concat-stream - Writable stream that concatenates strings or binary data and calls a callback with the result https://bugzilla.redhat.com/show_bug.cgi?id=1176810 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078467] Review Request: nodejs-concat-stream - Writable stream that concatenates data and calls a callback with the result
https://bugzilla.redhat.com/show_bug.cgi?id=1078467 Piotr Popieluch changed: What|Removed |Added Blocks||956806 (nodejs-reviews), ||1176811 CC||pnem...@redhat.com --- Comment #8 from Piotr Popieluch --- *** Bug 1176810 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1176811 [Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1176811 Piotr Popieluch changed: What|Removed |Added Depends On||1078467 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078467 [Bug 1078467] Review Request: nodejs-concat-stream - Writable stream that concatenates data and calls a callback with the result -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176810] Review Request: nodejs-concat-stream - Writable stream that concatenates strings or binary data and calls a callback with the result
https://bugzilla.redhat.com/show_bug.cgi?id=1176810 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Flags||fedora-review- --- Comment #1 from Piotr Popieluch --- This is already in Fedora: https://admin.fedoraproject.org/pkgdb/acls/name/nodejs-concat-stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form
https://bugzilla.redhat.com/show_bug.cgi?id=1058765 --- Comment #15 from Fedora Update System --- OpenTK-1.1-1.4c.fc21,mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/OpenTK-1.1-1.4c.fc21,mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176807] Review Request: nodejs-typedarray - TypedArray polyfill for old browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1176807 Parag changed: What|Removed |Added Assignee|nob...@fedoraproject.org|piotr1...@gmail.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176807] Review Request: nodejs-typedarray - TypedArray polyfill for old browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1176807 Parag changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-cvs? --- Comment #2 from Parag --- Fixed in same srpm. Thank you for this review. New Package SCM Request === Package Name: nodejs-typedarray Short Description: TypedArray polyfill for old browsers Upstream URL: https://github.com/substack/typedarray Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176807] Review Request: nodejs-typedarray - TypedArray polyfill for old browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1176807
Piotr Popieluch changed:
What|Removed |Added
CC||piotr1...@gmail.com
Flags||fedora-review+
--- Comment #1 from Piotr Popieluch ---
APPROVED,
suggestion:
add example dir to %doc
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 4 files have unknown license. Detailed output of
licensecheck in /home/piotr/rpmbuild/1176807-nodejs-
typedarray/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: Spec use %global instead of %define unless justified.
= EXTRA items =
Generic:
[x]: Rpmlint is r
[Bug 821917] Review Request: mu - maildir utility with Emacs support
https://bugzilla.redhat.com/show_bug.cgi?id=821917
--- Comment #23 from Maciek Borzecki ---
Addressed most of the comments. I've completely dropped separate guile packages
as that made little sense. The guile bindings are part of mu anyway, so extra
packages were redundant.
fedora-review brings up a couple of issues though:
- unversioned *.so file - this is really needed for guile bindings, and using
'mu' modules triggers a dlopen of libguile-mu.so in %{_libdir}
- a couple of files are listed in licensecheck.txt due to missing license info,
I'll be forwarding this upstream
Updated spec:
https://raw.githubusercontent.com/bboozzoo/mu-fedora/f16824cf37e85bad17f419899da1640de6298b00/mu.spec
Koji buils: http://koji.fedoraproject.org/koji/taskinfo?taskID=8485709
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1016444] ReviewRequest: festige - a GUI frontend to fst and dssi vst (run Windows VST audio plugins under wine)
https://bugzilla.redhat.com/show_bug.cgi?id=1016444 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||festige -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1128977] Review Request: dee-qt - Qt4/5 binding and QML plugin for Dee
https://bugzilla.redhat.com/show_bug.cgi?id=1128977 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Alias||dee-qt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176808] Review Request: nodejs-through2 - A tiny wrapper around Node streams2 Transform to avoid explicit subclassing noise
https://bugzilla.redhat.com/show_bug.cgi?id=1176808 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Assignee|nob...@fedoraproject.org|piotr1...@gmail.com --- Comment #1 from Piotr Popieluch --- - Summary/Description is too long, please make it shorter. - Source0 is different in spec and srpm, please update spec or rebuild srpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177038] Review Request: qt5-qtwebsockets - Qt5 - WebSockets component
https://bugzilla.redhat.com/show_bug.cgi?id=1177038 Rex Dieter changed: What|Removed |Added Alias||qt5-qtwebsockets -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175328] Review Request: powerdevil - Manages the power consumption settings of a Plasma Shell
https://bugzilla.redhat.com/show_bug.cgi?id=1175328 --- Comment #2 from Rex Dieter --- No need for desktop-file-install, there are no .desktop files used for application menus (ie, nothing is installed under /usr/share/applications/...) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 998243] Review Request: nodejs-chai - BDD/TDD assertion library for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=998243 --- Comment #9 from Fedora Update System --- nodejs-chai-1.9.1-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-chai-1.9.1-2.el7 -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1176811 --- Comment #1 from Parag --- Need this package in Fedora as early as this is dependency for nodejs-got which is already I pushed to testing, failing to understand that I have this missing dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060254] Review Request: nodejs-deep-eql - Improved deep equality testing for Node.js and the browser
https://bugzilla.redhat.com/show_bug.cgi?id=1060254 --- Comment #10 from Fedora Update System --- nodejs-deep-eql-0.1.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-deep-eql-0.1.3-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177453] Review Request: jxmpp - An Open Source XMPP Java base-library
https://bugzilla.redhat.com/show_bug.cgi?id=1177453 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1038274] Review Request: rubygem-liquid - A secure, non-evaling end user template engine with aesthetic markup
https://bugzilla.redhat.com/show_bug.cgi?id=1038274
--- Comment #3 from Mamoru TASAKA ---
Two comments
* License
- As lib/liquid/module_ex.rb is under Ruby,
the License tag should be "MIT and Ruby".
* Enabling tests
- Would you actually execute test suite as much
as possible, like below (for example)?
mkdir spy
touch spy/integration.rb
ruby -I"lib:.:test" -e 'Dir.glob("./test/**/*_test.rb").each{|f| require f
unless /context_unit_test/ =~ f }'
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177453] Review Request: jxmpp - An Open Source XMPP Java base-library
https://bugzilla.redhat.com/show_bug.cgi?id=1177453 gil cattaneo changed: What|Removed |Added Blocks||1177443 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177443 [Bug 1177443] smack 4.0.6 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177453] New: Review Request: jxmpp - An Open Source XMPP Java base-library
https://bugzilla.redhat.com/show_bug.cgi?id=1177453 Bug ID: 1177453 Summary: Review Request: jxmpp - An Open Source XMPP Java base-library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/jxmpp.spec SRPM URL: https://gil.fedorapeople.org/jxmpp-0.3.0-1.fc19.src.rpm Description: JXMPP is an Open Source Java base library for XMPP. It provides often used functionality needed to build a XMPP stack. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8485635 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 gil cattaneo changed: What|Removed |Added Blocks||1177443 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177443 [Bug 1177443] smack 4.0.6 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] New: Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 Bug ID: 1177451 Summary: Review Request: minidns - Minimal DNS library for java and android systems Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/minidns.spec SRPM URL: https://gil.fedorapeople.org/minidns-0.1.3-1.fc19.src.rpm Description: MiniDNS is a minimal dns client library for android. It can parse a basic set of resource records (A, , NS, SRV) and is easy to use and extend. This library is not intended to be used as a DNS server. You might want to look into dnsjava for such functionality. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8485637 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1142497] Review Request: rubygem-opennebula - OpenNebula Client API
https://bugzilla.redhat.com/show_bug.cgi?id=1142497 Mamoru TASAKA changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Mamoru TASAKA --- Okay, no problem. * spec file clean * source matches upstream * builds cleanly * built rpms clean * installs cleanly * at least the following works $ ruby -e "require 'opennebula' ; p OpenNebula::VERSION" "4.10.1" -- This package (rubygem-opennebula) is APPROVED by mtasaka -- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175328] Review Request: powerdevil - Manages the power consumption settings of a Plasma Shell
https://bugzilla.redhat.com/show_bug.cgi?id=1175328
Miroslav Suchý changed:
What|Removed |Added
CC||msu...@redhat.com
--- Comment #1 from Miroslav Suchý ---
License should be marked as:
%license COPYING
I believe you can make better on %description :)
I am missing destop-file-install:
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage
Should
%{_datadir}/doc/HTML/en/kcontrol/powerdevil
be marked as %doc ?
During build time:
Error: No Package found for plasma-workspace-devel
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form
https://bugzilla.redhat.com/show_bug.cgi?id=1058765 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form
https://bugzilla.redhat.com/show_bug.cgi?id=1058765 --- Comment #14 from Fedora Update System --- mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1113301] Review Request: nova-image-builder - Utility for building OpenStack Glance images inside OpenStack Nova instances
https://bugzilla.redhat.com/show_bug.cgi?id=1113301
Miroslav Suchý changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||msu...@redhat.com
Assignee|nob...@fedoraproject.org|msu...@redhat.com
--- Comment #4 from Miroslav Suchý ---
Taking.
It would be nice if you can talk to upstream and migrate this tool to use
python3 on Fedora22 (and replace shebang by sed in nova-install during %build
phase if 0%{fedora} >= 22 ).
You should provide man page:
http://fedoraproject.org/wiki/Packaging:Guidelines#Man_pages
You should use:
CFLAGS="$RPM_OPT_FLAGS" %{__python2} setup.py install -O1 --root=%{buildroot}
--skip-build
instead of direct use -O1.
You should mark license as:
%license COPYING
Description must end by dot.
It would be nice, if you can add tests as SOURCE1 and run them in %check phase.
This
Requires(post): chkconfig
Requires(preun): chkconfig
is IMO not needed and I fail to find any reference to chkconfig in code.
You are missing BR of -devel package:
http://fedoraproject.org/wiki/Packaging:Python#BuildRequires
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170374] Review Request: yum-plugin-needs-restarting - YUM plugin for listing processes using old files after upgrade
https://bugzilla.redhat.com/show_bug.cgi?id=1170374
Miroslav Suchý changed:
What|Removed |Added
CC||msu...@redhat.com
--- Comment #1 from Miroslav Suchý ---
1) I'm not sure if it is worth the work to continue adding something for yum. I
would focus work on some plugin for DNF instead.
2) There is much better plugin (for DNF) called tracer. See bug 1158629
And if you want to learn something:
* %defattr(-, root, root)
This is default and not needed since rpm 4.2
* %{__python} -c "import compileall;
compileall.compile_dir('%{buildroot}/%pluginhome', 1)"
rpm do that automatically, no need to do that.
* rm -rf %{buildroot}
not needed: http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
* you should preserve timestamps and use "cp -a"
* license should be marked using %license macro
%license COPYING
* do not enumerate all extension and just use:
%{pluginhome}/needs-restarting.py*
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174933] Review Request: python-rq - Library for creating background jobs, and processing them.
https://bugzilla.redhat.com/show_bug.cgi?id=1174933
Miroslav Suchý changed:
What|Removed |Added
CC||msu...@redhat.com
--- Comment #2 from Miroslav Suchý ---
Just reading the
This:
%clean
rm -rf %{buildroot}
Is not needed unless you target EL5.
http://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
The same apply for
rm -rf %{buildroot}
in
%install
Fedora 22 defaults to Python3. Unless you have strong reason, you should
provide python3-* subpackage.
This:
%defattr(-,root,root,-)
is default and is not needede since rpm4.2
It would be nice if you can provide man pages for:
%{_bindir}/rqinfo
%{_bindir}/rqworker
(and maybe contribute it back to upstream).
License should be:
%license LICENSE
Upstream have tests... you should run them in %check section. (you need to
package them as SOURCEX)
in %prep section you should delete bundled egg-info and create it from source
http://fedoraproject.org/wiki/Packaging:Python_Eggs
You should try to preserve timestamps of files. Therefore you "cp -a".
Summary must not end with dot.
Buildroot tag is not needed (unless you target el5)
http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177442] Review Request: jbosh - XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH)
https://bugzilla.redhat.com/show_bug.cgi?id=1177442 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177442] Review Request: jbosh - XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH)
https://bugzilla.redhat.com/show_bug.cgi?id=1177442 gil cattaneo changed: What|Removed |Added Blocks||1177443 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1177443 [Bug 1177443] smack 4.0.6 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1119056] Review Request: python-idna - Internationalized Domain Names in Applications (IDNA)
https://bugzilla.redhat.com/show_bug.cgi?id=1119056
Miroslav Suchý changed:
What|Removed |Added
Status|NEW |ASSIGNED
Blocks|177841 (FE-NEEDSPONSOR) |
Flags|fedora-review? |fedora-review+
--- Comment #7 from Miroslav Suchý ---
It is good habit to provide both update spec file and src.rpm.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Unknown or generated". 12 files have unknown license. Detailed output of
licensecheck in /tmp/python-idna/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown must
be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-idna
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-Engl
[Bug 1177442] New: Review Request: jbosh - XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH)
https://bugzilla.redhat.com/show_bug.cgi?id=1177442 Bug ID: 1177442 Summary: Review Request: jbosh - XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/jbosh.spec SRPM URL: https://gil.fedorapeople.org/jbosh-0.8.0-1.fc19.src.rpm Description: A maintained fork of com.kenai.jbosh for XEP-0124: Bidirectional-streams Over Synchronous HTTP (BOSH). This library is used by Smack to support XEP-206: XMPP over BOSH. In contrast to org.kenai.jbosh, this jBOSH library uses the Apache Commons HttpClient 4. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=8485533 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177009] Review Request: python-tempest-lib - OpenStack Functional Testing Library
https://bugzilla.redhat.com/show_bug.cgi?id=1177009 Miroslav Suchý changed: What|Removed |Added CC||msu...@redhat.com --- Comment #1 from Miroslav Suchý --- Quick review for obvious problems: * Remove that markup from %description. And do not repeat Summary in %description. * Fedora 22 defaults to Python3. Therefore you should provide python3-subpackage unless there is strong reason. * LICENSE file should be marked as: %license LICENSE * subunit-trace is missing man page * I would recommend moving sphinx documentation to -doc subpackage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1176811 Piotr Popieluch changed: What|Removed |Added CC||piotr1...@gmail.com Blocks||1171238 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1171238 [Bug 1171238] Review Request: nodejs-package-info - Get the information of a npm package -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171238] Review Request: nodejs-package-info - Get the information of a npm package
https://bugzilla.redhat.com/show_bug.cgi?id=1171238 Piotr Popieluch changed: What|Removed |Added Depends On||1176811 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1176811 [Bug 1176811] Review Request: nodejs-duplexify - Turn a writeable and readable stream into a single streams2 duplex stream -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172719] Review Request: isl - Integer point manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1172719
Michael Schwendt changed:
What|Removed |Added
CC||bugs.mich...@gmx.net
--- Comment #2 from Michael Schwendt ---
> expanded our pkgconfig_libdir... /usr/lib64/pkgconfig
That's what the build.log says, but you move it to %{_datadir}/pkgconfig/isl.pc
in %install. Why? Its contents are _not_ arch-independent.
Further, isl.pc relinks with -lgmp, which is not necessary when linking shared.
And isl.pc doesn't specify a pkgconfig dependency on gmp/gmp-devel, because
that one does not include any pkgconfig file.
> CC isl_gmp.lo
> CC isl_ast_int.lo
Build output is non-verbose, which makes it almost useless. One cannot see the
linker and/or compiler options (
https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags )
Try building with V=1 passed to "make", or configure with
--disable-silent-rules. That may be enough. See --help.
> -rwxr-xr-x /usr/lib64/libisl.la
These libtool archives are covered here:
https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries
> $ rpm -qpR isl-devel-0.14-1.fc21.x86_64.rpm |grep isl
> isl = 0.14-1.fc21
> libisl.so.13()(64bit)
https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package
> Requires: gmp
https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires
> Group: System Environment/Base
Group tag for C/C++ library -devel packages has been "Development/Libraries"
for many years.
The Group tag for your base package is missing. It would be "System
Environment/Libraries", but notice:
https://fedoraproject.org/wiki/Packaging:Guidelines#Group_tag
> %setup -q
> %configure
%configure is to be executed in %build (not just for --short-circuit builds).
> %install
> make install ...
Use %makeinstall:
https://fedoraproject.org/wiki/Packaging:Guidelines#Why_the_.25makeinstall_macro_should_not_be_used
> %defattr(-,root,root,-)
%defattr is not needed anymore for a long time:
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions
Unless you want to reuse exactly the same spec for EL5.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 Michael Schwendt changed: What|Removed |Added Depends On||1164257 --- Comment #2 from Michael Schwendt --- Bug 1164257 - Review Request: efl - Enlightenment Fundament Library Team-work time, guys! Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1164257 [Bug 1164257] Review Request: efl - Enlightenment Fundament Library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1164257] Review Request: efl - Enlightenment Fundament Library
https://bugzilla.redhat.com/show_bug.cgi?id=1164257 Michael Schwendt changed: What|Removed |Added Blocks||1175952 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1175952 [Bug 1175952] Review Request: efl - Collection of Enlightenment libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 Michael Schwendt changed: What|Removed |Added CC||bugs.mich...@gmx.net --- Comment #1 from Michael Schwendt --- > To strike the balance, this efl package makes subpackages for each of these > libraries, What balance? What is the rationale? It looks like a strange decision, because of the inter-dependencies between these libs. For example: $ rpm -qpR evas-1.12.2-1.fc22.x86_64.rpm |grep ^libe libeet.so.1()(64bit) libefl.so.1()(64bit) libeina.so.1()(64bit) libeo.so.1()(64bit) libevas.so.1()(64bit) $ rpm -qpR edje-1.12.2-1.fc22.x86_64.rpm |grep ^libe libecore.so.1()(64bit) libecore_audio.so.1()(64bit) libecore_con.so.1()(64bit) libecore_evas.so.1()(64bit) libecore_file.so.1()(64bit) libecore_imf.so.1()(64bit) libecore_imf_evas.so.1()(64bit) libecore_input.so.1()(64bit) libecore_input_evas.so.1()(64bit) libedje.so.1()(64bit) libeet.so.1()(64bit) libeeze.so.1()(64bit) libefl.so.1()(64bit) libeina.so.1()(64bit) libeio.so.1()(64bit) libembryo.so.1()(64bit) libemotion.so.1()(64bit) libeo.so.1()(64bit) libephysics.so.1()(64bit) libevas.so.1()(64bit) With such heavy inter-deps it makes no sense to create subpackages. Especially the dep on libelf.so.1 will always pull in the full show via your "elf" base package and its explicit Requires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1173839] Review Request: fstrm - Frame Streams implementation in C
https://bugzilla.redhat.com/show_bug.cgi?id=1173839 Fedora Update System changed: What|Removed |Added Fixed In Version||fstrm-0.2.0-1.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System --- fstrm-0.2.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115679] Review Request: nodejs-grunt-saucelabs - Grunt task running tests using Sauce Labs
https://bugzilla.redhat.com/show_bug.cgi?id=1115679 --- Comment #13 from Fedora Update System --- nodejs-grunt-saucelabs-8.3.3-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171607] Review Request: nodejs-caller-path - Get the path of the caller module
https://bugzilla.redhat.com/show_bug.cgi?id=1171607 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-caller-path-0.1.0-1. ||fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-caller-path-0.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172970] Review Request: nodejs-map-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172970 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-map-stream-0.0.5-1.f ||c21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-map-stream-0.0.5-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131978] Review Request: nodejs-csscomb-core - Framework for writing postprocessors
https://bugzilla.redhat.com/show_bug.cgi?id=1131978 --- Comment #14 from Fedora Update System --- nodejs-csscomb-core-2.0.4-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115704] Review Request: nodejs-sauce-tunnel - A wrapper around the Sauce Labs tunnel jar
https://bugzilla.redhat.com/show_bug.cgi?id=1115704 --- Comment #13 from Fedora Update System --- nodejs-sauce-tunnel-2.1.0-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171234] Review Request: nodejs-ttembed-js - Set embedding level of TrueType fonts module for Node.js
https://bugzilla.redhat.com/show_bug.cgi?id=1171234 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-ttembed-js-0.1.0-1.f ||c21 Resolution|NEXTRELEASE |ERRATA --- Comment #12 from Fedora Update System --- nodejs-ttembed-js-0.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1169492] Review Request: abc - Sequential logic synthesis and formal verification
https://bugzilla.redhat.com/show_bug.cgi?id=1169492 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||abc-1.01-2.hg20141130.fc21 Resolution|--- |ERRATA Last Closed||2014-12-27 04:25:25 --- Comment #11 from Fedora Update System --- abc-1.01-2.hg20141130.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115704] Review Request: nodejs-sauce-tunnel - A wrapper around the Sauce Labs tunnel jar
https://bugzilla.redhat.com/show_bug.cgi?id=1115704 --- Comment #12 from Fedora Update System --- nodejs-sauce-tunnel-2.1.0-1.fc19 has been pushed to the Fedora 19 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174893] Review Request: dnf-plugins-extras - Extras Plugins for DNF
https://bugzilla.redhat.com/show_bug.cgi?id=1174893 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||dnf-plugins-extras-0.0.1-2. ||fc21 Resolution|--- |ERRATA Last Closed||2014-12-27 04:24:24 --- Comment #14 from Fedora Update System --- dnf-plugins-extras-0.0.1-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171605] Review Request: nodejs-resolve-from - Resolve the path of a module like require.resolve() but from a given path
https://bugzilla.redhat.com/show_bug.cgi?id=1171605 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-resolve-from-1.0.0-1 ||.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-resolve-from-1.0.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171748] Review Request: nodejs-freetree - A node module for creating tree data structure from text input
https://bugzilla.redhat.com/show_bug.cgi?id=1171748 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-freetree-0.2.1-1.fc2 ||1 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-freetree-0.2.1-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115674] Review Request: nodejs-grunt-contrib-less - Compile LESS files to CSS
https://bugzilla.redhat.com/show_bug.cgi?id=1115674 --- Comment #16 from Fedora Update System --- nodejs-grunt-contrib-less-0.12.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1131978] Review Request: nodejs-csscomb-core - Framework for writing postprocessors
https://bugzilla.redhat.com/show_bug.cgi?id=1131978 --- Comment #13 from Fedora Update System --- nodejs-csscomb-core-2.0.4-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171608] Review Request: nodejs-require-uncached - Require a module bypassing the cache
https://bugzilla.redhat.com/show_bug.cgi?id=1171608 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-require-uncached-1.0 ||.2-1.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-require-uncached-1.0.2-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1171606] Review Request: nodejs-callsites - Get callsites from the V8 stack trace API
https://bugzilla.redhat.com/show_bug.cgi?id=1171606 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-callsites-1.0.0-1.fc ||21 Resolution|NEXTRELEASE |ERRATA --- Comment #10 from Fedora Update System --- nodejs-callsites-1.0.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115704] Review Request: nodejs-sauce-tunnel - A wrapper around the Sauce Labs tunnel jar
https://bugzilla.redhat.com/show_bug.cgi?id=1115704 --- Comment #11 from Fedora Update System --- nodejs-sauce-tunnel-2.1.0-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115679] Review Request: nodejs-grunt-saucelabs - Grunt task running tests using Sauce Labs
https://bugzilla.redhat.com/show_bug.cgi?id=1115679 --- Comment #12 from Fedora Update System --- nodejs-grunt-saucelabs-8.3.3-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1115679] Review Request: nodejs-grunt-saucelabs - Grunt task running tests using Sauce Labs
https://bugzilla.redhat.com/show_bug.cgi?id=1115679 --- Comment #11 from Fedora Update System --- nodejs-grunt-saucelabs-8.3.3-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1172972] Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172972 Fedora Update System changed: What|Removed |Added Fixed In Version||nodejs-stream-combiner-0.2. ||1-1.fc21 Resolution|NEXTRELEASE |ERRATA --- Comment #9 from Fedora Update System --- nodejs-stream-combiner-0.2.1-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170664] Review Request: python-mistune - Markdown parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1170664 Fedora Update System changed: What|Removed |Added Fixed In Version|python-mistune-0.5-1.fc21 |python-mistune-0.5-1.fc20 --- Comment #14 from Fedora Update System --- python-mistune-0.5-1.fc20 has been pushed to the Fedora 20 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1170664] Review Request: python-mistune - Markdown parser for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1170664 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||python-mistune-0.5-1.fc21 Resolution|--- |ERRATA Last Closed||2014-12-27 04:20:09 --- Comment #13 from Fedora Update System --- python-mistune-0.5-1.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
