[Bug 1198342] Review Request: dateutils - Command-line date and time calculation, conversion, and comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1198342 --- Comment #7 from Christopher Meng --- (In reply to Rüdiger Meier from comment #5) > "dateutils." prefix looks a bit ugly but at least Debian is using the same. > Other Distros are using it originally without prefix. Maybe they don't have > collisions or they didn't checked. I guess upstream could be also convinced > about adding a nice prefix. Surprisingly, my solution is even 'conflicting' with Debian ;) You could choose another prefix like 'dateutils-', or something shorter even. But it will confuse guys who just wanna use it, and also upstream, too. (In reply to Matthew Miller from comment #6) > It's not just that it looks ugly; it's also unwieldy for a command-line tool > that by its nature is likely to get typed a lot (rather than a > special-purpose util like the mentioned dapl-utils). Christopher, as I > understand it there's no _current_ conflicts here; do you have a strong > opinion on just leaving it? I don't have experience with handling conflicting binary names in Fedora, as anything with such name conflicts would be a vexed problem... But I don't want to see a solution like 'ninja-build' in Fedora as well, it's undue. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155055] Review Request: jenkins-pam-auth-plugin - Jenkins PAM Authentication plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1155055 Michal Srb changed: What|Removed |Added Flags|needinfo?(m...@redhat.com) |fedora-cvs? --- Comment #3 from Michal Srb --- New Package SCM Request === Package Name: jenkins-pam-auth-plugin Short Description: Jenkins PAM Authentication plugin Upstream URL: https://github.com/jenkinsci/pam-auth-plugin Owners: msrb msimacek mizdebsk Branches: f21 f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 --- Comment #7 from Benoît Marcelin --- e_dbus doesn't exist anymore. It has been replaced by eldbus. Your package should obsoletes it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 911781] Review Request: bittwist - Bit-Twist is a simple yet powerful libpcap-based Ethernet packet generator.
https://bugzilla.redhat.com/show_bug.cgi?id=911781 --- Comment #12 from Eduardo Echeverria --- I'm still interested in know what is the fas of Giuseppe and if still he hasn't been sponsored. Like says Fabian, Giuseppe, please append the links of the spec and SRPM, usually reviewers use a tool named fedora-review, that expects those links be available at the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #19 from Antoine Martin --- Upstream here. Sorry for replying late. First, I would like to say that many of us are happy Fedora users and would love to help in getting xpra in Fedora proper. So if you need us to do anything, do let us know. Working with downstream distributions is always worth the effort, we have greatly benefited from the feedback we have received so far. >> * gtk3 : N > I guess this is disabled because it is unstable, but please keep an eye out > for this to change in future releases. Indeed. In 0.15 (which is running late), we have split the packages into: * xpra-common * xpra * python3-xpra - which is the GTK3 version. Still not ready for prime time, but at least getting the packaging in order by splitting things. >> * qt4 : N > Same here. This one has been dropped completely in 0.15 because of a complete lack of maintenance. Note: we're not going to unbundle jquery and websockets, because it would be too costly for us to make builds for all the platforms we support (centos etc). But if we can somehow make it easier, let us know. The HTML5 client is making great progress in trunk. Re CSC: * you don't /really/ need pyopencl, we have the cython csc module as fallback - which is usually fast enough * I have experienced issues with pyopencl and the AMD icd, causing hangs because of interference with the signal handlers... so we're unsure what to do with this one (and in most cases, swscale is just as fast..) > The wiki oddly says that opencl is enabled by default these days, but I guess > the code is what counts so this can be skipped for now. It is when built. We have a "csc-modules" command line switch to be able to enable/disable csc modules at runtime. I believe that what the wiki is meant to say is that it will be used by default when present. > Hmm... I am finding that when forwarding individual app windows (as opposed > to the whole desktop) window resizing doesn't work properly. It is meant to work properly... BUT, there are lots of issues in this area, newer toolkits (especially GTK) seem to use server-side resizing. This is being addressed in 0.15, at least with *nix clients for now. > I am running F20 on the (remote) server, and F21 locally for the client, and > when I resize the frame, the application itself doesn't resize properly. I > tried this both with and without xdummy, and see the same thing. My client > desktop is Gnome 3, and on the server I was simply running either xterm or > gnome-terminal. Well, that's very odd. I test with xterm hundreds of times a day, and I use F21.. though no with Gnome 3. > Package PyOpenGL-accelerate (or work with PyOpenGL packagers to build the > accelerate module at the same time as the main package - even though they're > separate tarballs, they are version lock-stepped as far as I can see). Definitely MUST be in lockstep. We have hit some very obscure bugs when those two packages had version mismatch issues. I ended up adding version checks to prevent us using zero copy upload in such cases (so it should now degrade well - at least as well as we can make it) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197640] Review Request: ghc-equivalence - Equivalence relations implemented with union-find
https://bugzilla.redhat.com/show_bug.cgi?id=1197640
Ben Boeckel changed:
What|Removed |Added
Flags||fedora-review+
--- Comment #2 from Ben Boeckel ---
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 307200 bytes in 20 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[Bug 1182261] Review Request: libabigail - Tool for constructing, manipulating, serializing and de-serializing ABI-relevant artifacts
https://bugzilla.redhat.com/show_bug.cgi?id=1182261 Sinny Kumari changed: What|Removed |Added CC||skum...@redhat.com --- Comment #36 from Sinny Kumari --- Hi Parag, I was looking for another package which can be packaged for Fedora. I looked into http://fedoraproject.org/wiki/Package_maintainers_wishlist for help and also other resources to find out if something is unpackaged and can be relevant to add into Fedora. Package maintainers wishlist wiki page is quite outdated and it took some time to figure out relevant unpackaged project from it. Right now I am working on packaging Grabserial (http://elinux.org/Grabserial) project for adding it into Fedora repository. I will soon send package review for same. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197520] Review Request: xfce4-pulseaudio-plugin - Pulseaudio panel plugin for Xfce Panel
https://bugzilla.redhat.com/show_bug.cgi?id=1197520 Mukundan Ragavan changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-03-04 20:32:26 --- Comment #6 from Mukundan Ragavan --- Checked in and built. Thanks again for the review Sandro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078371] Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 --- Comment #19 from Fedora Update System --- js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078368] Review Request: js-jquery - JavaScript DOM manipulation, event handling, and AJAX library
https://bugzilla.redhat.com/show_bug.cgi?id=1078368 --- Comment #18 from Fedora Update System --- js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el7,js-jquery1-1.11.2-2.el7,js-sizzle-2.1.1-1.jquery.2.1.2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078368] Review Request: js-jquery - JavaScript DOM manipulation, event handling, and AJAX library
https://bugzilla.redhat.com/show_bug.cgi?id=1078368 --- Comment #17 from Fedora Update System --- js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078371] Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 --- Comment #18 from Fedora Update System --- js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.el6,js-jquery1-1.11.2-2.el6,js-sizzle-2.1.1-1.jquery.2.1.2.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078371] Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 --- Comment #17 from Fedora Update System --- js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078368] Review Request: js-jquery - JavaScript DOM manipulation, event handling, and AJAX library
https://bugzilla.redhat.com/show_bug.cgi?id=1078368 --- Comment #16 from Fedora Update System --- js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc21,js-jquery1-1.11.2-2.fc21,js-sizzle-2.1.1-1.jquery.2.1.2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078371] Review Request: js-jquery1 - JavaScript DOM manipulation, event handling, and AJAX library - for legacy browsers
https://bugzilla.redhat.com/show_bug.cgi?id=1078371 --- Comment #16 from Fedora Update System --- js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1078368] Review Request: js-jquery - JavaScript DOM manipulation, event handling, and AJAX library
https://bugzilla.redhat.com/show_bug.cgi?id=1078368 --- Comment #15 from Fedora Update System --- js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/js-jquery-2.1.3-1.fc20,js-jquery1-1.11.2-2.fc20,js-sizzle-2.1.1-1.jquery.2.1.2.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #17 from Fedora Update System --- golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #16 from Fedora Update System --- golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #15 from Fedora Update System --- golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #14 from Fedora Update System --- golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.3.gitfa8ad6f.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312
--- Comment #18 from T.C. Hollingsworth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= ISSUES =
[!]: Package does not contain bundled libraries.
Please package js-web-socket-js to avoid bundling as discussed earlier.
[!]: The summary in bugzilla does not match the summary in the spec.
Please correct these items for approval. Other issues identified can be
corrected in the course of normal development.
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"GPL (v2 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL
(v3 or later)", "BSD (2 clause)", "*No copyright* MIT/X11 (BSD like)".
418 files have unknown license. Detailed output of licensecheck in
/var/tmp/1198312-xpra/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
contains desktop file(s) with a MimeType: entry.
Note: desktop file(s) with MimeType entry in xpra
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in xpra
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 112640 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #17 from T.C. Hollingsworth --- (In reply to Jonathan Underwood from comment #16) > Interesting. Which Fedora versions are you running on the client and server? I only did F20->F20 as well using your package as both the client and server. :-( I did test your package as a client on F20 against several xpra servers in the wild running on various distributions without trouble though. I could potentially install it on an F21 server and test it out in awhile but unless I get the wild idea to update my laptop from F20 while away from home I'm probably not going to be able to test an F21 client anytime soon. :-/ Do the upstream RPMs work fine in the same configuration? Can you reproduce it on F21 with a different window manager? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #11 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #10 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #9 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #8 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.2.git75cd24fc2f2c.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #16 from Jonathan Underwood --- (In reply to T.C. Hollingsworth from comment #15) > (In reply to Jonathan Underwood from comment #14) > > Hmm... I am finding that when forwarding individual app windows (as opposed > > to the whole desktop) window resizing doesn't work properly. From Googling I > > can't work out if this is expected behavior. > > Hmm, I never use xpra for a whole desktop, and resizing windows works just > fine here with your package. Interesting. Which Fedora versions are you running on the client and server? I am running F20 on the (remote) server, and F21 locally for the client, and when I resize the frame, the application itself doesn't resize properly. I tried this both with and without xdummy, and see the same thing. My client desktop is Gnome 3, and on the server I was simply running either xterm or gnome-terminal. Earlier in the day I tested with F20 as both client and server (the same machine in fact), and windows resized just fine there. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #15 from T.C. Hollingsworth --- (In reply to Jonathan Underwood from comment #13) > Just collecting a few things here for later: > 1) Need to package js-jquery-ui and js-web-socket-js from upstream and > unbundle from xpra - this probably needs to happen before package is > approved.. jquery things that are not yet packaged have a blanket exception from the FPC. You're right about js-web-socket-js though, that really should get packaged. It doesn't even require building, it's just a bunch of static files. > Outstanding issues for post-approval: > 1) Package pyopencl > 2) Package PyOpenGL-accelerate (or work with PyOpenGL packagers to build the > accelerate module at the same time as the main package - even though they're > separate tarballs, they are version lock-stepped as far as I can see). Glad you noticed this too, I just noticed it with testing also. > 3) Enable --with-csc_opencl (In reply to Jonathan Underwood from comment #14) > Hmm... I am finding that when forwarding individual app windows (as opposed > to the whole desktop) window resizing doesn't work properly. From Googling I > can't work out if this is expected behavior. Hmm, I never use xpra for a whole desktop, and resizing windows works just fine here with your package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #13 from Fedora Update System --- golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #12 from Fedora Update System --- golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #11 from Fedora Update System --- golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190413] Review Request: golang-github-prometheus-procfs - Functions to retrieve system, kernel and process metrics from the /proc fs
https://bugzilla.redhat.com/show_bug.cgi?id=1190413 --- Comment #13 from Fedora Update System --- golang-github-prometheus-procfs-0-0.2.git6c34ef8.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-github-prometheus-procfs-0-0.2.git6c34ef8.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190413] Review Request: golang-github-prometheus-procfs - Functions to retrieve system, kernel and process metrics from the /proc fs
https://bugzilla.redhat.com/show_bug.cgi?id=1190413 --- Comment #12 from Fedora Update System --- golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190413] Review Request: golang-github-prometheus-procfs - Functions to retrieve system, kernel and process metrics from the /proc fs
https://bugzilla.redhat.com/show_bug.cgi?id=1190413 --- Comment #10 from Fedora Update System --- golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190437] Review Request: golang-github-prometheus-client_model - Data model artifacts for Prometheus
https://bugzilla.redhat.com/show_bug.cgi?id=1190437 --- Comment #10 from Fedora Update System --- golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-github-prometheus-client_model-0-0.2.gitfa8ad6f.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190413] Review Request: golang-github-prometheus-procfs - Functions to retrieve system, kernel and process metrics from the /proc fs
https://bugzilla.redhat.com/show_bug.cgi?id=1190413 --- Comment #11 from Fedora Update System --- golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-github-prometheus-procfs-0-0.2.git6c34ef8.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #14 from Jonathan Underwood --- Hmm... I am finding that when forwarding individual app windows (as opposed to the whole desktop) window resizing doesn't work properly. From Googling I can't work out if this is expected behavior. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #13 from Jonathan Underwood --- OK, thanks for the explanation - I'm all clear now. Just collecting a few things here for later: 1) Need to package js-jquery-ui and js-web-socket-js from upstream and unbundle from xpra - this probably needs to happen before package is approved.. Outstanding issues for post-approval: 1) Package pyopencl 2) Package PyOpenGL-accelerate (or work with PyOpenGL packagers to build the accelerate module at the same time as the main package - even though they're separate tarballs, they are version lock-stepped as far as I can see). 3) Enable --with-csc_opencl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1175952] Review Request: efl - Collection of Enlightenment libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1175952 --- Comment #6 from Tom "spot" Callaway --- Updated spec: https://spot.fedorapeople.org/efl.spec Updated SRPM: https://spot.fedorapeople.org/efl-1.13.1-2.fc21.src.rpm Koji Rawhide scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9139662 This updates to 1.13.1, drops the subpackages, fixes the FSF address issues from rpmlint, fixes compilation of drm support. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #12 from T.C. Hollingsworth --- (In reply to Jonathan Underwood from comment #7) > (In reply to T.C. Hollingsworth from comment #2) > > > * rencode : Y > > > * server : Y > > > * shadow : Y > > > * sound: Y > > > * strict : Y > > > * swscale_static : N > > > * verbose : N > > > * vpx : N > > > > Is it still necessary to disable this? > > > > libswscale isn't strictly required these days: > > https://www.xpra.org/trac/wiki/CSC > > I am a bit confused here as, as I think you're conflating two issues - vpx, > and CSC, but perhaps I misunderstand. They're related issues. All the video codecs require a CSC to perform pre-conversion except in certain limited circumstances. In the earlier version of the code, there weren't any such limited circumstances and libswscale from ffmpeg was the only CSC. That's why vpx was previously disabled. See the comments from Antoine, an upstream developer, in the old bug for more details on all this. Note also that he said improvements were on the way, and they came. Now that there are multiple CSC implementations and at least one that works on Fedora, vpx and other future libre codecs should work fine. > Anyway, regarding CSC, upstream defaults are: > > --with-csc_opencl or --without-csc_opencl (default: False) > --with-csc_cython or --without-csc_cython (default: True) > > so, --without-csc_opencl and --with-csc_cython. Are you saying you'd like to > see the package use --with-csc_opencl and --without-csc_cython instead? No, you can build more than one of these. The wiki oddly says that opencl is enabled by default these days, but I guess the code is what counts so this can be skipped for now. = It sounds like all the issues I've found so far have been addressed. Let me put it through a few more paces and see if we can't get this approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #11 from Jonathan Underwood --- SPEC: https://jgu.fedorapeople.org/xpra.spec SRPM: https://jgu.fedorapeople.org/xpra-0.14.19-4.fc20.src.rpm %changelog * Tue Mar 3 2015 Jonathan G. Underwood - 0.14.19-4 - Add --with-Xdummy and --with-Xdummy_wrapper build options since Xorg not installed at build time so autodetection fails -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #5 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #6 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #7 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.el6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #4 from Fedora Update System --- golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198342] Review Request: dateutils - Command-line date and time calculation, conversion, and comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1198342 --- Comment #6 from Matthew Miller --- It's not just that it looks ugly; it's also unwieldy for a command-line tool that by its nature is likely to get typed a lot (rather than a special-purpose util like the mentioned dapl-utils). Christopher, as I understand it there's no _current_ conflicts here; do you have a strong opinion on just leaving it? Rüdiger, it sounds like you're more in touch with upstream than I am; do you want to contact them and ask if they're open to going to dateadd, dateconv, etc? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198342] Review Request: dateutils - Command-line date and time calculation, conversion, and comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1198342 --- Comment #5 from Rüdiger Meier --- (In reply to Matthew Miller from comment #4) > > 4. CFLAGS are being overriden by march=native(aarch64 doesn't support it) > > and even others, this is not not good, please patch. > > Rüdiger Meier, I'll wait as suggested... presumably fixed? Yes, this will be fixed. > > 5. These program names are too common, please consider passing > > --program-prefix='dateutils.', as it even conflicts with RHEL dapl-utils > > package(It's not in Fedora I checked). > > I think that'd make them significantly less handy, and unless there are > really strong feelings here, I think I'd prefer to leave as-is, or as a > worst case change the initial 'd' to expanded 'date' — dateadd, dateconv, > etc. (But that also seems like a big deviation from upstream!) "dateutils." prefix looks a bit ugly but at least Debian is using the same. Other Distros are using it originally without prefix. Maybe they don't have collisions or they didn't checked. I guess upstream could be also convinced about adding a nice prefix. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180723] Review Request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #34 from Fedora Update System --- clufter-0.10.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/clufter-0.10.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180723] Review Request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #35 from Fedora Update System --- clufter-0.10.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/clufter-0.10.1-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1180723] Review Request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1180723 --- Comment #33 from Fedora Update System --- clufter-0.10.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/clufter-0.10.1-1.fc20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194545] Review Request: python-cached_property - A cached-property for decorating methods in Python classes.
https://bugzilla.redhat.com/show_bug.cgi?id=1194545 Pete Travis changed: What|Removed |Added Summary|Review Request: |Review Request: |python-cached-property - A |python-cached_property - A |cached-property for |cached-property for |decorating methods in |decorating methods in |Python classes. |Python classes. --- Comment #4 from Pete Travis --- After some thought, I'm going to go with matching the name of the module, following the spirit of the Python naming guidelines, which specify matching the module and don't mention the upstream project name. I'll update the SRPM soon, or on the next bump if you see more room for improvement. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197639] Review Request: ghc-STMonadTrans - A monad transformer version of the ST monad
https://bugzilla.redhat.com/show_bug.cgi?id=1197639 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ghc-STMonadTrans-0.3.2-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1195554] Review Request: ghc-wizards - High level, generic library for interrogative user interfaces
https://bugzilla.redhat.com/show_bug.cgi?id=1195554 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #6 from Fedora Update System --- Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1195555] Review Request: ghc-tabular - Two-dimensional data tables with rendering functions
https://bugzilla.redhat.com/show_bug.cgi?id=119 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #10 from Fedora Update System --- Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197337] Review Request: ghc-polyparse - A variety of alternative parser combinator libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1197337 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ghc-polyparse-1.11-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179982] Review Request: docsis-config-encoder - Encode a DOCSIS binary configuration file
https://bugzilla.redhat.com/show_bug.cgi?id=1179982 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #26 from Fedora Update System --- docsis-config-encoder-0.9.8-0.1.20150302git68e622f.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197641] Review Request: ghc-boxes - 2D text pretty-printing library
https://bugzilla.redhat.com/show_bug.cgi?id=1197641 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ghc-boxes-0.1.4-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1195551] Review Request: ghc-prelude-extras - Haskell98 higher order versions of Prelude classes
https://bugzilla.redhat.com/show_bug.cgi?id=1195551 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1195553] Review Request: ghc-control-monad-free - Free monads and monad transformers
https://bugzilla.redhat.com/show_bug.cgi?id=1195553 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- Package ghc-wizards-1.0.1-1.fc22, ghc-tabular-0.2.2.7-2.fc22, ghc-control-monad-free-0.6.1-3.fc22, ghc-prelude-extras-0.4-2.fc22, ghc-shakespeare-text-1.1.0-3.fc22, hledger-0.24-1.fc22, ghc-hledger-lib-0.24-1.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing ghc-wizards-1.0.1-1.fc22 ghc-tabular-0.2.2.7-2.fc22 ghc-control-monad-free-0.6.1-3.fc22 ghc-prelude-extras-0.4-2.fc22 ghc-shakespeare-text-1.1.0-3.fc22 hledger-0.24-1.fc22 ghc-hledger-lib-0.24-1.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-2880/hledger-0.24-1.fc22,ghc-hledger-lib-0.24-1.fc22,ghc-wizards-1.0.1-1.fc22,ghc-control-monad-free-0.6.1-3.fc22,ghc-tabular-0.2.2.7-2.fc22,ghc-prelude-extras-0.4-2.fc22,ghc-shakespeare-text-1.1.0-3.fc22 then log in and leave karma (feedback). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197642] Review Request: ghc-data-hash - Combinators for building fast hashing functions
https://bugzilla.redhat.com/show_bug.cgi?id=1197642 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- ghc-data-hash-0.2.0.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1196373] Review Request: stockfish - Powerful open source chess engine
https://bugzilla.redhat.com/show_bug.cgi?id=1196373 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- stockfish-7-0.1.20150302gitcb2111f.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Jan Chaloupka changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Jan Chaloupka --- New Package SCM Request === Package Name: golang-bitbucket-ww-goautoneg Short Description: HTTP Content-Type Autonegotiation Upstream URL: https://bitbucket.org/ww/goautoneg Owners: jchaloup lsm5 Branches: f22 f21 f20 el6 InitialCC: golang-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Lokesh Mandvekar changed: What|Removed |Added CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #1 from Lokesh Mandvekar --- - specfile conforms to golang packaging draft - license correct and valid - only sources installed package approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198803] New: Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation
https://bugzilla.redhat.com/show_bug.cgi?id=1198803 Bug ID: 1198803 Summary: Review Request: golang-bitbucket-ww-goautoneg - HTTP Content-Type Autonegotiation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-bitbucket-ww-goautoneg/golang-bitbucket-ww-goautoneg.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-bitbucket-ww-goautoneg/golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc20.src.rpm Description: HTTP Content-Type Autonegotiation Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9139242 $ rpmlint golang-bitbucket-ww-goautoneg-0-0.1.git75cd24fc2f2c.fc20.src.rpm golang-bitbucket-ww-goautoneg-devel-0-0.1.git75cd24fc2f2c.fc20.noarch.rpm golang-bitbucket-ww-goautoneg.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Upstream: https://bitbucket.org/ww/goautoneg Notes: license in README.txt moved to LICENSE file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 Piotr Popieluch changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Piotr Popieluch --- Thank you for review! New Package SCM Request === Package Name: nodejs-onetime Short Description: Only call a function once Upstream URL: https://github.com/sindresorhus/onetime Owners: piotrp Branches: f20 f21 f22 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1166421] Review Request: nodejs-sphericalmercator - Transformations between the Web Mercator projection and Latitude Longitude coordinates
https://bugzilla.redhat.com/show_bug.cgi?id=1166421 --- Comment #2 from Piotr Popieluch --- Hi Eduardo, Latest version is now 1.0.3. You can also remove Group: this is only needed if you intend to package for EPEL5. I will do a full review if you upload a new version which solves all issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927
Gerard Ryan changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Gerard Ryan ---
(In reply to Piotr Popieluch from comment #3)
> Hi Gerard,
>
> Thank you for pointing me to the Github source URL guidelines, it never
> occurred to me that those might exist.. I probably have a dozen of packages
> using this incorrectly. I will check all my packages next weekend.
>
Yes, it's hard to remember all of the rules all the time...it's a good thing we
force ourselves to get our packages reviewed! :) I guess this particular one is
because the tags aren't necessarily immutable, but the commit hashes are.
> I've updated the spec and srpm without a version bump.
>
> Thank you for reviewing!
Thank you for packaging! It looks good to me now, so I'll approve it.
For any innocent bystanders, here's the diff of the spec file between the two
versions:
--- srpm/nodejs-onetime.spec2015-03-01 17:56:35.28500 +
+++ nodejs-onetime.spec2015-03-04 19:55:43.0 +
@@ -3,14 +3,15 @@
%global enable_tests 1
%global srcname onetime
+%global commit a4aa1ce5291cc5f32ecb8f4b0a918b12cb47ea5e
Name: nodejs-%{srcname}
Version:1.0.0
Release:1%{?dist}
Summary:Only call a function once
License:MIT
-URL:https://github.com/sindresorhus/onetime
-Source0:
https://github.com/sindresorhus/%{srcname}/archive/v%{version}/%{srcname}-%{version}.tar.gz
+URL:https://github.com/sindresorhus/%{srcname}
+Source0:
https://github.com/sindresorhus/%{srcname}/archive/%{commit}/%{srcname}-%{commit}.tar.gz
BuildArch: noarch
ExclusiveArch: %{nodejs_arches} noarch
@@ -28,7 +29,7 @@
%prep
-%setup -q -n %{srcname}-%{version}
+%setup -q -n %{srcname}-%{commit}
rm -rf node_modules/
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194927] Review Request: nodejs-onetime - Only call a function once
https://bugzilla.redhat.com/show_bug.cgi?id=1194927 --- Comment #3 from Piotr Popieluch --- Hi Gerard, Thank you for pointing me to the Github source URL guidelines, it never occurred to me that those might exist.. I probably have a dozen of packages using this incorrectly. I will check all my packages next weekend. I've updated the spec and srpm without a version bump. Thank you for reviewing! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Blocks||563471 (FE-SECLAB) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=563471 [Bug 563471] Tracker: Review Requests for Fedora Security Lab related packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added Alias||mitmproxy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1070418] Review Request: python-mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1070418 Fabian Affolter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |DUPLICATE Last Closed||2015-03-04 14:04:11 --- Comment #10 from Fabian Affolter --- *** This bug has been marked as a duplicate of bug 1198760 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Fabian Affolter changed: What|Removed |Added CC||dh...@openwall.com --- Comment #1 from Fabian Affolter --- *** Bug 1070418 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] New: Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Bug ID: 1198760 Summary: Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: m...@fabian-affolter.ch QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.11.3-1.fc21.src.rpm Project URL: http://mitmproxy.org/ Description: mitmproxy is an interactive, SSL-capable man-in-the-middle proxy for HTTP with a console interface. mitmdump is the command-line version of mitmproxy. Think tcpdump for HTTP. libmproxy is the library that mitmproxy and mitmdump are built on. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9138575 rpmlint output: [fab@laptop017 SRPMS]$ rpmlint mitmproxy-0.11.3-1.fc21.src.rpm mitmproxy.src: W: spelling-error %description -l en_US mitmdump -> dumdum mitmproxy.src: W: spelling-error %description -l en_US tcpdump -> Dumpster mitmproxy.src: W: spelling-error %description -l en_US libmproxy -> improbably 1 packages and 0 specfiles checked; 0 errors, 3 warnings. [fab@laptop017 noarch]$ rpmlint mitmproxy-0.11.3-1.fc21.noarch.rpm mitmproxy.noarch: W: spelling-error %description -l en_US tcpdump -> Dumpster mitmproxy.noarch: W: no-manual-page-for-binary mitmproxy mitmproxy.noarch: W: no-manual-page-for-binary mitmdump 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Fedora Account System Username: fab -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197947] Review Request: khard - An address book for the Linux console
https://bugzilla.redhat.com/show_bug.cgi?id=1197947
--- Comment #4 from Florian "der-flo" Lehner ---
Hi Ben!
> > [ ] Please append
> > #/%{name}-%{version}.tar.gz
> > to your Source0 to get a propper named source.
>
> I see no reason why this is necessary. %setup -n handles this just fine.
rpm will then use %{name}-%{version}.tar.gz as the tarball name. If you use
spectool -g khard.spec to download the tarball, it will rename the tarball for
you.
At the moment, you get v0.2.1.tar.gz which can be everything. It just makes it
easier to handle multiple packages and is not a blocker.
> > khard.noarch: E: non-executable-script
> > /usr/lib/python2.7/site-packages/davcontroller/davcontroller.py 0644L
> > /usr/bin/python
>
> Patched locally and filed upstream:
> .
Your patch doesn't work well. Please take a look at:
https://fedoraproject.org/wiki/Packaging_tricks#Remove_shebang_from_Python_libraries
Cheers,
Florian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103555] Review Request: fcl - The Flexible Collision Library
https://bugzilla.redhat.com/show_bug.cgi?id=1103555 --- Comment #1 from Rich Mattes --- Update: Spec URL: http://rmattes.fedorapeople.org/RPMS/fcl/fcl.spec SRPM URL: http://rmattes.fedorapeople.org/RPMS/fcl/fcl-0.3.2-1.fc21.src.rpm rpmlint: $ rpmlint ./fcl.spec ../RPMS/x86_64/fcl* fcl.x86_64: W: spelling-error %description -l en_US normals -> normal, normal's, formals fcl.x86_64: E: invalid-soname /usr/lib64/libfcl.so libfcl.so fcl.x86_64: W: shared-lib-calls-exit /usr/lib64/libfcl.so exit@GLIBC_2.2.5 fcl-devel.x86_64: W: only-non-binary-in-usr-lib fcl-devel.x86_64: W: no-documentation 3 packages and 1 specfiles checked; 1 errors, 4 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1194798] Review Request: GeoIP-GeoLite-data - Free GeoLite IP geolocation country database
https://bugzilla.redhat.com/show_bug.cgi?id=1194798 --- Comment #6 from Philip Prindeville --- Spec file looks okay. Have you run rpmlint on both files? Also, what's the script to run over the package to review it and do the automated checks? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #10 from Jonathan Underwood --- For anyone wanting to test packages, I've created a COPR repository here: https://copr.fedoraproject.org/coprs/jgu/xpra/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186497] Review Request: libtifiles2 - Texas Instruments calculator files library
https://bugzilla.redhat.com/show_bug.cgi?id=1186497 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186497] Review Request: libtifiles2 - Texas Instruments calculator files library
https://bugzilla.redhat.com/show_bug.cgi?id=1186497 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186501] Review Request: libticables2 - Texas Instruments link cables library
https://bugzilla.redhat.com/show_bug.cgi?id=1186501 --- Comment #6 from Ben Rosser --- I can fix the other things. For the ownership of /usr/lib/rules/udev.d, does that just mean the package should BuildRequires: systemd? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1186497] Review Request: libtifiles2 - Texas Instruments calculator files library
https://bugzilla.redhat.com/show_bug.cgi?id=1186497 Ben Rosser changed: What|Removed |Added Flags||fedora-cvs? --- Comment #10 from Ben Rosser --- Thanks for the review! New Package SCM Request === Package Name: libtifiles2 Short Description: Texas Instruments calculator files library Upstream URL: https://sourceforge.net/projects/tilp/ Owners: tc01 Branches: f20 f21 f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055712] Review Request: docker - Automates deployment of containerized applications
https://bugzilla.redhat.com/show_bug.cgi?id=1055712 --- Comment #12 from Lokesh Mandvekar --- also, see https://github.com/lsm5/docker-rpm for other files used -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1055712] Review Request: docker - Automates deployment of containerized applications
https://bugzilla.redhat.com/show_bug.cgi?id=1055712 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mat...@redhat.com |jchal...@redhat.com --- Comment #11 from Lokesh Mandvekar --- Spec URL: https://github.com/lsm5/docker-rpm/blob/master/docker.spec Let's use github for this review :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #9 from Jonathan Underwood --- Update again to work on F20. Minimally tested locally on F20 by starting session, running xterm, killing session. SPEC: https://jgu.fedorapeople.org/xpra.spec SRPM: https://jgu.fedorapeople.org/xpra-0.14.19-2.fc20.src.rpm * Tue Mar 3 2015 Jonathan G. Underwood - 0.14.19-3 - Use js-jquery package only on F22 or later - not available on earlier distros -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179982] Review Request: docsis-config-encoder - Encode a DOCSIS binary configuration file
https://bugzilla.redhat.com/show_bug.cgi?id=1179982 --- Comment #25 from Fedora Update System --- docsis-config-encoder-0.9.8-0.1.20150302git68e622f.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/docsis-config-encoder-0.9.8-0.1.20150302git68e622f.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198342] Review Request: dateutils - Command-line date and time calculation, conversion, and comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1198342 --- Comment #4 from Matthew Miller --- (In reply to Christopher Meng from comment #2) > 1. %check section is needed for > make check Sure, will add. > 2. Disable silent build by passing --disable-silent-rules to %configure, > then you will see trouble 4. Hmmm; maybe that should be standard? Good catch. > 3. Consider packaging octave binding(*optional*, as I don't find it useful > so far, might not for others I think). Is this bringing in baggage if you rebuild with octave-devel as a build-requires (or out of mock on a system with it installed)? I guess I could subpackage, but as it's not mentioned in the docs (is it? did I miss something?) I'm inclined to just leave it out. > 4. CFLAGS are being overriden by march=native(aarch64 doesn't support it) > and even others, this is not not good, please patch. Rüdiger Meier, I'll wait as suggested... presumably fixed? > 5. These program names are too common, please consider passing > --program-prefix='dateutils.', as it even conflicts with RHEL dapl-utils > package(It's not in Fedora I checked). I think that'd make them significantly less handy, and unless there are really strong feelings here, I think I'd prefer to leave as-is, or as a worst case change the initial 'd' to expanded 'date' — dateadd, dateconv, etc. (But that also seems like a big deviation from upstream!) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179982] Review Request: docsis-config-encoder - Encode a DOCSIS binary configuration file
https://bugzilla.redhat.com/show_bug.cgi?id=1179982 --- Comment #24 from Fedora Update System --- docsis-config-encoder-0.9.8-0.1.20150302git68e622f.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/docsis-config-encoder-0.9.8-0.1.20150302git68e622f.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1179982] Review Request: docsis-config-encoder - Encode a DOCSIS binary configuration file
https://bugzilla.redhat.com/show_bug.cgi?id=1179982 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358 Eng Ops Maitai User changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|pm-r...@redhat.com |jpoko...@redhat.com QA Contact|nob...@redhat.com |mspqa-l...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1126990] Review Request: kimchi - SImple KVM virtualization management
https://bugzilla.redhat.com/show_bug.cgi?id=1126990 Brent Baude changed: What|Removed |Added CC||aline.man...@gmail.com --- Comment #8 from Brent Baude --- I have created a new spec and rpm at: https://baude.fedorapeople.org/kimchi-1.4.0-2.fc21.noarch.rpm https://baude.fedorapeople.org/kimchi.spec This includes significant work from upstream to remove libraries that were previously shipped. They now use system dependencies instead. Please consider reviewing now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198312] Review Request: xpra - screen for X
https://bugzilla.redhat.com/show_bug.cgi?id=1198312 --- Comment #8 from Jonathan Underwood --- Updated packages which build fine - haven't had chance to test their usage yet though. SPEC: https://jgu.fedorapeople.org/xpra.spec SRPM: https://jgu.fedorapeople.org/xpra-0.14.19-2.fc20.src.rpm * Tue Mar 3 2015 Jonathan G. Underwood - 0.14.19-2 - Update Summary to be more descriptive of package - Use packaged js-jquery - Add provides for bundled(js-jquery-ui) and bundled(js-web-socket-js) - Build with vpx and webp support enabled - Remove any installed SWF files - Remove executable flag for all .js files - Remove Requires for python-webm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1195279] Review Request: preupgrade-assistant - Preupgrade assistant a tool for assess system before an upgrade
https://bugzilla.redhat.com/show_bug.cgi?id=1195279
--- Comment #22 from Zbigniew Jędrzejewski-Szmek ---
(In reply to Petr Hracek from comment #21)
> Spec URL: https://phracek.fedorapeople.org/preupgrade-assistant.spec
> SRPM URL:
> https://phracek.fedorapeople.org/preupgrade-assistant-0.11.7-4.fc21.src.rpm
It seems that the problem from comment #c3 has resurfaced. In F23 mock:
running build_ext
Traceback (most recent call last):
File "setup.py", line 61, in
test_suite = 'tests.suite',
File "/usr/lib64/python3.4/distutils/core.py", line 148, in setup
dist.run_commands()
File "/usr/lib64/python3.4/distutils/dist.py", line 955, in run_commands
self.run_command(cmd)
File "/usr/lib64/python3.4/distutils/dist.py", line 974, in run_command
cmd_obj.run()
File "/usr/lib/python3.4/site-packages/setuptools/command/test.py", line 142,
in run
self.with_project_on_sys_path(self.run_tests)
File "/usr/lib/python3.4/site-packages/setuptools/command/test.py", line 122,
in with_project_on_sys_path
func()
File "/usr/lib/python3.4/site-packages/setuptools/command/test.py", line 163,
in run_tests
testRunner=self._resolve_as_ep(self.test_runner),
File "/usr/lib64/python3.4/unittest/main.py", line 92, in __init__
self.parseArgs(argv)
File "/usr/lib64/python3.4/unittest/main.py", line 139, in parseArgs
self.createTests()
File "/usr/lib64/python3.4/unittest/main.py", line 146, in createTests
self.module)
File "/usr/lib64/python3.4/unittest/loader.py", line 146, in
loadTestsFromNames
suites = [self.loadTestsFromName(name, module) for name in names]
File "/usr/lib64/python3.4/unittest/loader.py", line 146, in
suites = [self.loadTestsFromName(name, module) for name in names]
File "/usr/lib64/python3.4/unittest/loader.py", line 105, in
loadTestsFromName
module = __import__('.'.join(parts_copy))
File "/builddir/build/BUILD/preupgrade-assistant-0.11.7/tests/__init__.py",
line 2, in
from tests import test_preup
File "/builddir/build/BUILD/preupgrade-assistant-0.11.7/tests/test_preup.py",
line 6, in
from preup.application import Application
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.7/preup/application.py", line
18, in
from preuputils.compose import XCCDFCompose
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.7/preuputils/compose.py", line
12, in
from preuputils.oscap_group_xml import OscapGroupXml
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.7/preuputils/oscap_group_xml.py",
line 13, in
from preuputils.xml_utils import print_error_msg, XmlUtils
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.7/preuputils/xml_utils.py",
line 11, in
from preuputils import script_utils
File
"/builddir/build/BUILD/preupgrade-assistant-0.11.7/preuputils/script_utils.py",
line 6, in
import xml_utils
ImportError: No module named 'xml_utils'
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #20)
> > - Why BR:pykickstart R:pykickstart in F23?
> >
> You are right python3-kickstart should require pykickstart in F23
Are you sure? The only reason to do that would be if python3-kickstart called
binaries (ksflatten, ksshell, ksvalidator, ksverdiff) provided by pykickstart.
The reason for my original question was that this dependency seems spurious
since pykickstart is for Python2, and preupgrade-asistant is running under
Python3 in F23. In the spec file I see you moved R/BR:pykicstart underneath %if
0%{?fedora} == 22, so this seems fine now.
> > - preupgrade-assistant.rpm has an empty /usr/share/doc/preupgrade directory
> > and README files are in /usr/share/preupgrade.
> >
> README is in /usr/share/doc/preupgrade directory.
> README file should be in both directories. The file is copied to
> /root/preupgrade/ directory after an assessment.
> User can see after a upgrade/migration what results mean.
> But I will corrected it after package review so that only one README file is
> enough.
I think it is fine as is. You have to be careful here because of the rule that
packages cannot require anything in %doc at runtime. So having two copies of
this very small file is probably the best option.
> > - Looking at the first message:
> > The Preupgrade Assistant is a diagnostics tool
> > and does not perform the actual upgrade.
> > Make sure you back up your system and all of your data now,
> > before using the Upgrade Tool to avoid potential data loss.
> > Do you want to continue? y/n
> >
> > If it is only a diagnostic tool, why is it unsafe to run?
> > Also, why does it require root privileges? Isn't the RPM database public?
> We need to have a access to all files and directories. Root access is really
> needed. Some data are accessible only under root account.
OK, so it needs to run as root. By why the scary warning?
> > - In the man page: "All common log files are stored in
> > /var/cache/preupgrade/common". Isn't /var/log/preupgrade used?
> Those directories are different.
> - /var/log/preup
[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets
https://bugzilla.redhat.com/show_bug.cgi?id=1198498
Rich Mattes changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||richmat...@gmail.com
Assignee|nob...@fedoraproject.org|richmat...@gmail.com
--- Comment #1 from Rich Mattes ---
I'll take this review.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: libs/sha-1.c is BSD
Note: lib/base64-decode.c and lib/ssl-http2.c are MIT
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
Note: libs/sha-1.c should be noted as bundled, as per
https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Requirement_if_you_bundle
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
Note: Is there any reason to delete the CMake modules being installed?
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[-]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in th
[Bug 1198617] Review Request: tomcat-taglibs-parent - Apache Taglibs Parent
https://bugzilla.redhat.com/show_bug.cgi?id=1198617 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
