[Bug 1222709] Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 --- Comment #2 from Rafael Aquini --- (In reply to Douglas Schilling Landgraf from comment #1) > Hi Rafael, > > I saw Marcelo took the bug, here two quick comments, from: > https://fedoraproject.org/wiki/Packaging:ReviewGuidelines > > #1) > MUST: If (and only if) the source package includes the text of the > license(s) in its own file, then that file, containing the text of the > license(s) for the package must be included in %license.[4] > > > #2) > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Exceptions_2 > Exceptions > > There is no need to include the following packages or their dependencies as > BuildRequires because they would occur too often. These packages are > considered the minimum build environment. > > > gcc-c++ > Thanks for taking the time to review this work Douglas! Here's the adjusted spec, following your feedback: Spec URL: https://aquini.fedorapeople.org/memkind/memkind.spec SRPM URL: https://aquini.fedorapeople.org/memkind/memkind-0.2.2-2.20150518git.fc23.src.rpm Koji scratch-Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=9782909 -- Rafael -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222709] Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 --- Comment #1 from Douglas Schilling Landgraf --- Hi Rafael, I saw Marcelo took the bug, here two quick comments, from: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines #1) MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license.[4] #2) https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Exceptions_2 Exceptions There is no need to include the following packages or their dependencies as BuildRequires because they would occur too often. These packages are considered the minimum build environment. gcc-c++ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222709] Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 Marcelo Barbosa "firemanxbr" changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mr.marcelo.barb...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103414] Review Request: js-jquery-migrate - APIs and features removed from jQuery core
https://bugzilla.redhat.com/show_bug.cgi?id=1103414 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103414] Review Request: js-jquery-migrate - APIs and features removed from jQuery core
https://bugzilla.redhat.com/show_bug.cgi?id=1103414 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1154750] Review Request: mozilla-privacy-badger - Protects your privacy by blocking spying ads and invisible trackers
https://bugzilla.redhat.com/show_bug.cgi?id=1154750 Andy Lutomirski changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|l...@mit.edu|nob...@fedoraproject.org Flags|fedora-review? | --- Comment #4 from Andy Lutomirski --- I'm dropping this, since I'm barely qualified to reivew JS. Note to whomever takes over: the license needs careful checking. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222709] Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 Rafael Aquini changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222709] Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 Rafael Aquini changed: What|Removed |Added CC||dougsl...@redhat.com, ||mr.marcelo.barb...@gmail.co ||m Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222709] New: Review Request: memkind - User Extensible Heap Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1222709 Bug ID: 1222709 Summary: Review Request: memkind - User Extensible Heap Manager Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: aqu...@linux.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://aquini.fedorapeople.org/memkind/memkind.spec SRPM URL: https://aquini.fedorapeople.org/memkind/memkind-0.2.2-1.20150518git.fc23.src.rpm Description: The memkind library is an user extensible heap manager built on top of a customized jemalloc fork which enables control of memory characteristics and partitioning of the heap between types of memory. The types (kind) of memory are defined by operating system memory policies that have been applied to virtual address ranges. Memory characteristics supported by memkind without user extension include control of NUMA and page size features. This software is being made available for early evaluation. Fedora Account System Username: aquini rpmlint output for the .spec: $ rpmlint SPECS/memkind.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Koji scratch-Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=9779121 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1103414] Review Request: js-jquery-migrate - APIs and features removed from jQuery core
https://bugzilla.redhat.com/show_bug.cgi?id=1103414 T.C. Hollingsworth changed: What|Removed |Added Flags||fedora-cvs? --- Comment #12 from T.C. Hollingsworth --- New Package SCM Request === Package Name: js-jquery-migrate Short Description: APIs and features removed from jQuery core Upstream URL: https://github.com/jquery/jquery-migrate/ Owners: patches jamielinux Branches: f22 f21 f20 epel7 el6 el5 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Bug 1215414 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #12 from Igor Gnatenko --- *** Bug 879931 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
https://bugzilla.redhat.com/show_bug.cgi?id=879928 Bug 879928 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879931] Review Request: angelscript - AngelCode Scripting Library
https://bugzilla.redhat.com/show_bug.cgi?id=879931 Igor Gnatenko changed: What|Removed |Added Status|NEW |CLOSED CC||i.gnatenko.br...@gmail.com Resolution|--- |DUPLICATE Last Closed|2015-05-18 04:49:21 |2015-05-18 16:48:26 --- Comment #11 from Igor Gnatenko --- (In reply to Pavel Alexeev (aka Pahan-Hubbitus) from comment #10) > Hans why you close my review request?? I ready for review. Do you willing do > it? We already did it %) *** This bug has been marked as a duplicate of bug 1215414 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #11 from Fedora Update System --- angelscript-2.30.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/angelscript-2.30.0-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879931] Review Request: angelscript - AngelCode Scripting Library
https://bugzilla.redhat.com/show_bug.cgi?id=879931 Pavel Alexeev (aka Pahan-Hubbitus) changed: What|Removed |Added Status|CLOSED |NEW Resolution|DUPLICATE |--- Keywords||Reopened --- Comment #10 from Pavel Alexeev (aka Pahan-Hubbitus) --- Hans why you close my review request?? I ready for review. Do you willing do it? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Bug 1215414 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|CLOSED |NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
https://bugzilla.redhat.com/show_bug.cgi?id=879928 Bug 879928 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|CLOSED |NEW Resolution|DUPLICATE |--- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222690] New: Review Request: gap-pkg-fga - Free group algorithms for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1222690 Bug ID: 1222690 Summary: Review Request: gap-pkg-fga - Free group algorithms for GAP Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jjames.fedorapeople.org/gap-pkg-fga/gap-pkg-fga.spec SRPM URL: https://jjames.fedorapeople.org/gap-pkg-fga/gap-pkg-fga-1.2.0-1.fc23.src.rpm Fedora Account System Username: jjames Description: The FGA package provides methods for computations with finitely generated subgroups of free groups. It allows you to (constructively) test membership and conjugacy, and to compute free generators, the rank, the index, normalizers, centralizers, and intersections where the groups involved are finitely generated subgroups of free groups. In addition, it provides generators and a finite presentation for the automorphism group of a finitely generated free group and allows to write any such automorphism as word in these generators. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 Mikolaj Izdebski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-05-18 16:24:31 --- Comment #9 from Mikolaj Izdebski --- Built for rawhide. Closing. http://koji.fedoraproject.org/koji/buildinfo?buildID=637698 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 --- Comment #8 from Mikolaj Izdebski --- Asked upstream to add license file: https://github.com/pmd/build-tools/pull/1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 Mikolaj Izdebski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Mikolaj Izdebski --- New Package SCM Request === Package Name: pmd-build-tools Short Description: PMD Build Plugin Owners: mizdebsk msrb msimacek Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190269] Review Request: openstack-barbican - Secrets as a Service
https://bugzilla.redhat.com/show_bug.cgi?id=1190269 --- Comment #9 from Haïkel Guémar --- By curiosity, I gave a shot to the paste-based scripts provided upstream (master) and they work perfectly fine, I was able to run service without glitches. https://github.com/openstack/barbican/tree/master/bin Could we ship them separately for Juno ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 --- Comment #5 from gil cattaneo --- found NON blocking issues: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Package does not include license text files separate from upstream. Please, fix before import -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487
--- Comment #4 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 27 files have unknown license. Detailed
output of licensecheck in /home/gil/1221487-pmd-build-
tools/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/maven-metadata, /usr/share/licenses
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses,
/usr/share/maven-metadata
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in
[Bug 1213976] Review Request: sqlite-jdbc - SQLite JDBC library
https://bugzilla.redhat.com/show_bug.cgi?id=1213976 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #6 from Fedora Update System --- sqlite-jdbc-3.8.9.1-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206946] Review Request: rubygem-occi-cli - Executable OCCI client
https://bugzilla.redhat.com/show_bug.cgi?id=1206946 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- rubygem-occi-cli-4.3.1-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222662] New: Review Request: notify-sharp3 - C# Desktop Notification with gtk3
https://bugzilla.redhat.com/show_bug.cgi?id=1222662 Bug ID: 1222662 Summary: Review Request: notify-sharp3 - C# Desktop Notification with gtk3 Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: claudiorodr...@pereyradiaz.com.ar QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://elsupergomez.fedorapeople.org/SPECS/notify-sharp3.spec SRPM URL: https://elsupergomez.fedorapeople.org/SRPMS/notify-sharp3-3.0.3-1.fc21.src.rpm Description: A C# implementation for Desktop Notifications Fedora Account System Username: elsupergomez -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215344] Review Request: plowshare-modules-legacy - Legacy modules for plowshare
https://bugzilla.redhat.com/show_bug.cgi?id=1215344
--- Comment #1 from Pavel Alexeev (aka Pahan-Hubbitus) ---
Package Review
==
Legend:
[+] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[+]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[+]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v3 or later)".
[+]: Package requires other packages for directories it uses.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/plowshare,
/usr/share/plowshare/modules
[-]: Package contains no bundled libraries without FPC exception.
[+]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[+]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[+]: Package uses nothing in %doc for runtime.
[+]: Package consistently uses macros (instead of hard-coded directory
names).
[+]: Package is named according to the Package Naming Guidelines.
[+]: Package does not generate any conflict.
[+]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[+]: Requires correct, justified where necessary.
[+]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[+]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[?]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
Note: Found : Packager: Pavel Alexeev (aka Pahan-Hubbitus)
Found : Vendor: fedora
See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[+]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
Latest commit 098d61824beb108d146cfa5b73eb8d9b05400fe3 and I do not see any
tags or releases.
[+]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[-]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[+]: Packages should try to preserve timestamps of original installed
files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: No file require
[Bug 1221487] Review Request: pmd-build-tools - PMD Build Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1221487 Mikolaj Izdebski changed: What|Removed |Added Whiteboard|BuildFails | --- Comment #3 from Mikolaj Izdebski --- I've uploaded wrong SRPM indeed. Now it builds fine: http://koji.fedoraproject.org/koji/taskinfo?taskID=9777514 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222346] Review Request: python-pkgconfig - A Python interface to the pkg-config command line tool
https://bugzilla.redhat.com/show_bug.cgi?id=1222346 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||python-pkgconfig-1.1.0-2.fc ||23 Resolution|--- |RAWHIDE Last Closed||2015-05-18 14:05:43 --- Comment #4 from Orion Poplawski --- Thanks for the note about the python2/3 dirs. I think we need to clean up the python packaging guidelines to make that more explicit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222346] Review Request: python-pkgconfig - A Python interface to the pkg-config command line tool
https://bugzilla.redhat.com/show_bug.cgi?id=1222346 Orion Poplawski changed: What|Removed |Added Fixed In Version|python-pkgconfig-1.1.0-2.fc |python-pkgconfig-1.1.0-1.fc |23 |23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215150] Review Request: python-pathlib - Object-oriented filesystem paths
https://bugzilla.redhat.com/show_bug.cgi?id=1215150
Raphael Groner changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #7 from Raphael Groner ---
APPROVED
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /home/build/fedora-review/1215150-python-
pathlib/licensecheck.txt
==> OK. setup.py mentions MIT
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 378880 bytes in 29 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Rev
[Bug 1190269] Review Request: openstack-barbican - Secrets as a Service
https://bugzilla.redhat.com/show_bug.cgi?id=1190269 --- Comment #8 from Greg Swift --- Ya, unfortunately that is a growth point issue for the project. barbican.sh is very much a development bootstrap. It does side loading via pip, etc. In talking to a few of the developers I originally got 'well, they run it with whatever engine they want'. I have since gotten more buy-in on the concept of making it run in apache with mod_uwsgi. But they haven't gotten to that yet. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Nikos Mavrogiannopoulos changed: What|Removed |Added Blocks||1220391 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1220391 [Bug 1220391] ipcalc doesn't work for IPv6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221204] Review Request: python-docker-scripts - Collection of scripts to help manage Docker
https://bugzilla.redhat.com/show_bug.cgi?id=1221204 Marek Goldmann changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-05-18 09:42:06 --- Comment #6 from Marek Goldmann --- Thanks, built for Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 --- Comment #9 from Lukáš Nykrýn --- And I thank you :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 --- Comment #8 from Lukáš Nykrýn --- https://git.fedorahosted.org/cgit/initscripts.git/commit/?id=e5282b7755a453cc2a938d1514c03b83821c4f61 -> removed ipcalc in upstream and new version -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Nikos Mavrogiannopoulos changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-05-18 09:05:29 --- Comment #7 from Nikos Mavrogiannopoulos --- Built. Thank you. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1190269] Review Request: openstack-barbican - Secrets as a Service
https://bugzilla.redhat.com/show_bug.cgi?id=1190269 Haïkel Guémar changed: What|Removed |Added Flags|needinfo?(karlthered@gmail. | |com)| --- Comment #7 from Haïkel Guémar --- Services cannot run, they require barbican.sh which is not installed. I suggest that we find a better way to start barbican services in the future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222346] Review Request: python-pkgconfig - A Python interface to the pkg-config command line tool
https://bugzilla.redhat.com/show_bug.cgi?id=1222346 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222346] Review Request: python-pkgconfig - A Python interface to the pkg-config command line tool
https://bugzilla.redhat.com/show_bug.cgi?id=1222346 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221204] Review Request: python-docker-scripts - Collection of scripts to help manage Docker
https://bugzilla.redhat.com/show_bug.cgi?id=1221204 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221204] Review Request: python-docker-scripts - Collection of scripts to help manage Docker
https://bugzilla.redhat.com/show_bug.cgi?id=1221204 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222484] Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox
https://bugzilla.redhat.com/show_bug.cgi?id=1222484 --- Comment #1 from Juan Orti --- I've updated the SPEC and created a copr repository: https://copr.fedoraproject.org/coprs/jorti/rhythmbox-ampache/ Spec URL: https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache.spec SRPM URL: https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache-0-0.2.20150518git7415a69.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #10 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221183] Review request: nodejs-dezalgo - Contain async insanity so that the dark pony lord doesn't eat souls
https://bugzilla.redhat.com/show_bug.cgi?id=1221183 Tomas Hrcka changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Nikos Mavrogiannopoulos changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Nikos Mavrogiannopoulos --- New Package SCM Request === Package Name: ipcalc Short Description: IP network address calculator Owners: nmav Branches: master InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Lukáš Nykrýn changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #4 from Lukáš Nykrýn --- (In reply to Nikos Mavrogiannopoulos from comment #2) > Thanks. I've fixed the license upstream [0] but I'm not sure it makes sense > to make a new release for that. If it is required for you I'll do a 0.1.1 > otherwise I'll postpone it for the next update. > > https://github.com/nmav/ipcalc/commit/ > 4f126ce6f95707e02dae7647cc979e930e4a799d I am fine with that. (In reply to Nikos Mavrogiannopoulos from comment #3) > btw. to be added in master (f23) it would require a version bump in > initscripts. I have couple of patches in upstream which are not with fedora yet so I will release 9.63 when you package will be built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 --- Comment #3 from Nikos Mavrogiannopoulos --- btw. to be added in master (f23) it would require a version bump in initscripts. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 --- Comment #2 from Nikos Mavrogiannopoulos --- Thanks. I've fixed the license upstream [0] but I'm not sure it makes sense to make a new release for that. If it is required for you I'll do a 0.1.1 otherwise I'll postpone it for the next update. https://github.com/nmav/ipcalc/commit/4f126ce6f95707e02dae7647cc979e930e4a799d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222484] New: Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox
https://bugzilla.redhat.com/show_bug.cgi?id=1222484 Bug ID: 1222484 Summary: Review Request: rhythmbox-ampache - Ampache plugin for Rhythmbox Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: j.orti.alca...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache.spec SRPM URL: https://jorti.fedorapeople.org/rhythmbox-ampache/rhythmbox-ampache-0-0.1.20150518git7c1d978.fc22.src.rpm Description: The Rhythmbox Ampache Plugin is a plugin for the music player Rhythmbox that enables browsing the metadata and streaming music from an Ampache media server. Fedora Account System Username: jorti -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423
--- Comment #1 from Lukáš Nykrýn ---
In short:
ipcalc-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ipcalc-0.1.0/ipcalc-geoip.c
ipcalc-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/ipcalc-0.1.0/ipcalc.c
Otherwise looks fine.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2) (with incorrect FSF address)", "Unknown or
generated". 1 files have unknown license. Detailed output of
licensecheck in /home/lnykryn/1222423-ipcalc/licensecheck.txt
[X]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses
* /usr/share/licenses is now owned by filesystem in rawhide
[X]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses
* /usr/share/licenses is now owned by filesystem in rawhide
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[-]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
* Have confilcts with old initscripts, which is desired
[-]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is prese
[Bug 1154750] Review Request: mozilla-privacy-badger - Protects your privacy by blocking spying ads and invisible trackers
https://bugzilla.redhat.com/show_bug.cgi?id=1154750 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Blocks|1078359 (js-reviews)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221209] Review Request: addon-sdk - SDK to create Firefox add-ons using standard Web technologies
https://bugzilla.redhat.com/show_bug.cgi?id=1221209 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Blocks|1078359 (js-reviews)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221209] Review Request: addon-sdk - SDK to create Firefox add-ons using standard Web technologies
https://bugzilla.redhat.com/show_bug.cgi?id=1221209 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Blocks||1078359 (js-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1154750] Review Request: mozilla-privacy-badger - Protects your privacy by blocking spying ads and invisible trackers
https://bugzilla.redhat.com/show_bug.cgi?id=1154750 Dominik 'Rathann' Mierzejewski changed: What|Removed |Added Blocks||1078359 (js-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1078359 [Bug 1078359] JavaScript review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - Flexible cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Igor Gnatenko changed: What|Removed |Added Summary|Review Request: angelscript |Review Request: angelscript |- A flexible, |- Flexible cross-platform |cross-platform scripting|scripting library |library | Flags||fedora-cvs? --- Comment #9 from Igor Gnatenko --- > -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc > sdk/docs/manual/*" to avoid including the files under dk/docs/articles in > both the main package and the -devel package I will fix on import stage. Thanks for review! New Package SCM Request === Package Name: angelscript Short Description: Flexible cross-platform scripting library Upstream URL: http://www.angelcode.com/angelscript/ Owners: ignatenkobrain Branches: f21 f22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #8 from Hans de Goede --- Full review done: Good: - rpmlint checks return: angelscript-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 0 specfiles checked; 0 errors, 1 warnings. This warning can be ignored - package meets naming guidelines - package meets packaging guidelines - license (zlib) OK, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r Should fix: -Change the %doc for -devel from "%doc sdk/docs/*" to "%doc sdk/docs/manual/*" to avoid including the files under dk/docs/articles in both the main package and the -devel package No blockers: Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1127967] Review Request: python-releases - A Sphinx extension for changelog manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1127967 --- Comment #4 from Pierre-YvesChibon --- The LICENSE file is already in the sources when I look at the tarball on pypi: https://pypi.python.org/pypi/releases So there is no need to include it once more -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174479] Review Request: beets - Music library manager and MusicBrainz tagger
https://bugzilla.redhat.com/show_bug.cgi?id=1174479 Michele Baldessari changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2015-05-18 05:47:41 --- Comment #19 from Michele Baldessari --- 1.3.11 is now in rawhide. 1.3.12 introduced a new dependency (python-jellyfish). I will chase this in another BZ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 --- Comment #7 from Igor Gnatenko --- (In reply to Hans de Goede from comment #6) > I'm going to review this one, assigning it to myself. I'm happy %) Let's do it! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222266] Review Request: php-mtdowling-jmespath-php - Declaratively specify how to extract elements from a JSON document
https://bugzilla.redhat.com/show_bug.cgi?id=166 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #9 from Fedora Update System --- php-mtdowling-jmespath-php-2.1.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222267] Review Request: php-mtdowling-transducers - Composable algorithmic transformations
https://bugzilla.redhat.com/show_bug.cgi?id=167 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- php-mtdowling-transducers-0.3.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222265] Review Request: php-whitehat101-apr1-md5 - Apache's APR1-MD5 algorithm in pure PHP
https://bugzilla.redhat.com/show_bug.cgi?id=165 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- php-whitehat101-apr1-md5-1.0.0-1.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Status|NEW |ASSIGNED CC||hdego...@redhat.com Assignee|nob...@fedoraproject.org|hdego...@redhat.com --- Comment #6 from Hans de Goede --- I'm going to review this one, assigning it to myself. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879931] Review Request: angelscript - AngelCode Scripting Library
https://bugzilla.redhat.com/show_bug.cgi?id=879931 Hans de Goede changed: What|Removed |Added Status|NEW |CLOSED CC||hdego...@redhat.com Resolution|--- |DUPLICATE Last Closed||2015-05-18 04:49:21 --- Comment #9 from Hans de Goede --- Since this bug report has not seen any activity in more then 2 years now, and there is a new active attempt at packaging angelscript, I'm going to close this one as a dup of the new review-request. *** This bug has been marked as a duplicate of bug 1215414 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
https://bugzilla.redhat.com/show_bug.cgi?id=879928 Bug 879928 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Bug 1215414 depends on bug 879931, which changed state. Bug 879931 Summary: Review Request: angelscript - AngelCode Scripting Library https://bugzilla.redhat.com/show_bug.cgi?id=879931 What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics
https://bugzilla.redhat.com/show_bug.cgi?id=879928 Hans de Goede changed: What|Removed |Added Depends On||1215414 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1215414 [Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215414] Review Request: angelscript - A flexible, cross-platform scripting library
https://bugzilla.redhat.com/show_bug.cgi?id=1215414 Hans de Goede changed: What|Removed |Added Blocks||879928 (rigsofrods) CC||pa...@hubbitus.info --- Comment #5 from Hans de Goede --- *** Bug 879931 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=879928 [Bug 879928] Review Request: rigsofrods - Vehicle simulator based on soft-body physics -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1202805] Review Request: owncloud-client - The ownCloud Client
https://bugzilla.redhat.com/show_bug.cgi?id=1202805 --- Comment #10 from Dams --- FTR, 1.8.1 has been released. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206946] Review Request: rubygem-occi-cli - Executable OCCI client
https://bugzilla.redhat.com/show_bug.cgi?id=1206946 --- Comment #8 from Fedora Update System --- rubygem-occi-cli-4.3.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/rubygem-occi-cli-4.3.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206946] Review Request: rubygem-occi-cli - Executable OCCI client
https://bugzilla.redhat.com/show_bug.cgi?id=1206946 --- Comment #7 from Fedora Update System --- rubygem-occi-cli-4.3.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/rubygem-occi-cli-4.3.1-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1206946] Review Request: rubygem-occi-cli - Executable OCCI client
https://bugzilla.redhat.com/show_bug.cgi?id=1206946 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Lukáš Nykrýn changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Lukáš Nykrýn changed: What|Removed |Added CC||lnyk...@redhat.com Assignee|nob...@fedoraproject.org|lnyk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222423] New: Review Request: ipcalc - IP network address calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1222423 Bug ID: 1222423 Summary: Review Request: ipcalc - IP network address calculator Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: nmavr...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://people.redhat.com/nmavrogi/fedora/ipcalc.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/ipcalc-0.1.0-1.fc21.src.rpm Description: ipcalc provides a simple way to calculate IP information for a host. The various options specify what information ipcalc should display on standard out. Multiple options may be specified. An IP address to operate on must always be specified. Most operations also require a netmask or a CIDR prefix as well. Fedora Account System Username: nmav -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221469] Review Request: jruby-maven-plugins - JRuby Maven plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1221469 Michal Srb changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||jruby-maven-plugins-1.0.10- ||2.fc23 Resolution|--- |RAWHIDE Last Closed||2015-05-18 03:18:10 --- Comment #9 from Michal Srb --- Thanks for the review and the repo. The package is now in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
