[Bug 597315] Review Request: bwa - Burrows-Wheeler Alignment tool
https://bugzilla.redhat.com/show_bug.cgi?id=597315 --- Comment #26 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597315] Review Request: bwa - Burrows-Wheeler Alignment tool
https://bugzilla.redhat.com/show_bug.cgi?id=597315 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 510843] Review Request: samtools - Tools for nucleotide sequence alignments in the SAM format
https://bugzilla.redhat.com/show_bug.cgi?id=510843 --- Comment #17 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 510843] Review Request: samtools - Tools for nucleotide sequence alignments in the SAM format
https://bugzilla.redhat.com/show_bug.cgi?id=510843 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 --- Comment #3 from gil cattaneo --- NON blocking issues: gap-pkg-polycyclic.noarch: W: file-not-utf8 /usr/share/doc/gap-pkg-polycyclic/style.css Please fix it gap-pkg-polycyclic.noarch: E: version-control-internal-file /usr/lib/gap/pkg/polycyclic-2.11/doc/.cvsignore Please remove Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904
gil cattaneo changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
NOTE: manual review
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 4 files have unknown license. Detailed
output of licensecheck in /home/gil/1205904-gap-pkg-polycyclic/srpm
/review-gap-pkg-polycyclic/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[?]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyrig
[Bug 1225249] Review Request: møte - a MeetBot log wrangler
https://bugzilla.redhat.com/show_bug.cgi?id=1225249 --- Comment #5 from Chaoyi Zha --- Okay. I've fixed the issues, pushed them to the repo, and tested the built packages. The spec can be found here: https://raw.githubusercontent.com/fedora-infra/mote/master/files/mote.spec The build can be found here: https://copr.fedoraproject.org/coprs/cydrobolt/mote/build/94810/ However, the package will not build for EPEL 6 with font files removed, as the fontawesome package is unavailable for EPEL 6. If we can upgrade value01 to RHEL 7, everything should work out. Otherwise, everything seems to be correct, and the F22 package installs and runs correctly in my VM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 gil cattaneo changed: What|Removed |Added CC||punto...@libero.it Assignee|nob...@fedoraproject.org|punto...@libero.it Flags||fedora-review? --- Comment #1 from gil cattaneo --- can you take this https://bugzilla.redhat.com/show_bug.cgi?id=1178149 ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226474] New: Review Request: carat - Crystallographic AlgoRithms And Tables
https://bugzilla.redhat.com/show_bug.cgi?id=1226474 Bug ID: 1226474 Summary: Review Request: carat - Crystallographic AlgoRithms And Tables Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: loganje...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jjames.fedorapeople.org/carat/carat.spec SRPM URL: https://jjames.fedorapeople.org/carat/carat-2.1b1.19.07.2008-1.fc23.src.rpm Fedora Account System Username: jjames Description: CARAT is a computer package which handles enumeration, construction, recognition, and comparison problems for crystallographic groups up to dimension 6. The name CARAT itself is an acronym for Crystallographic AlgoRithms And Tables. Due to its specialized nature and some generically named binaries, this package uses environment-modules to access its binaries. This should not present a problem as it will be accessed primarily via GAP, rather than directly from the command line. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223627] Review Request: gap-pkg-edim - Elementary divisors of integer matrices
https://bugzilla.redhat.com/show_bug.cgi?id=1223627 --- Comment #7 from Fedora Update System --- gap-pkg-edim-1.3.2-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gap-pkg-edim-1.3.2-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223627] Review Request: gap-pkg-edim - Elementary divisors of integer matrices
https://bugzilla.redhat.com/show_bug.cgi?id=1223627 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222690] Review Request: gap-pkg-fga - Free group algorithms for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1222690 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222690] Review Request: gap-pkg-fga - Free group algorithms for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1222690 --- Comment #5 from Fedora Update System --- gap-pkg-fga-1.2.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gap-pkg-fga-1.2.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205777] Review Request: gap-pkg-autpgrp - Compute the automorphism group of a p-Group in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205777 --- Comment #7 from Fedora Update System --- gap-pkg-autpgrp-1.6-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gap-pkg-autpgrp-1.6-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205777] Review Request: gap-pkg-autpgrp - Compute the automorphism group of a p-Group in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205777 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 597315] Review Request: bwa - Burrows-Wheeler Alignment tool
https://bugzilla.redhat.com/show_bug.cgi?id=597315 Adam Huffman changed: What|Removed |Added Flags||fedora-cvs? --- Comment #25 from Adam Huffman --- Package Change Request == Package Name: bwa New Branches: EL-7 Owners: verdurin -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218089] Review Request: php-seld-cli-prompt - Allows you to prompt for user input on the command line
https://bugzilla.redhat.com/show_bug.cgi?id=1218089 Fedora Update System changed: What|Removed |Added Fixed In Version|php-seld-cli-prompt-1.0.0-1 |php-seld-cli-prompt-1.0.0-1 |.fc22 |.el7 --- Comment #14 from Fedora Update System --- php-seld-cli-prompt-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218090] Review Request: php-seld-phar-utils - PHAR file format utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1218090 Fedora Update System changed: What|Removed |Added Fixed In Version|php-seld-phar-utils-1.0.0-1 |php-seld-phar-utils-1.0.0-1 |.fc21 |.el7 --- Comment #14 from Fedora Update System --- php-seld-phar-utils-1.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060817] Review Request: fllog - Amateur Radio Log Program
https://bugzilla.redhat.com/show_bug.cgi?id=1060817 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #22 from Fedora Update System --- fllog-1.2.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1060804] Review Request: flamp - Amateur Multicast Protocol - file transfer program
https://bugzilla.redhat.com/show_bug.cgi?id=1060804 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #41 from Fedora Update System --- flamp-2.2.02-2.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1213595] Review Request: mediawiki123-intersection - Create a list of pages that are listed in a set of categories
https://bugzilla.redhat.com/show_bug.cgi?id=1213595 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mediawiki123-intersection-1 ||.7.0-1.el7 Resolution|--- |ERRATA Last Closed||2015-05-29 17:48:16 --- Comment #6 from Fedora Update System --- mediawiki123-intersection-1.7.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1213599] Review Request: mediawiki123-RSS - Displays one or more RSS feeds on a wiki page
https://bugzilla.redhat.com/show_bug.cgi?id=1213599 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mediawiki123-RSS-2.25.0-1.e ||l7 Resolution|--- |ERRATA Last Closed||2015-05-29 17:47:50 --- Comment #6 from Fedora Update System --- mediawiki123-RSS-2.25.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221293] Review Request: nodejs-normalize-git-url - Normalizes Git URLs. For npm, but you can use it too.
https://bugzilla.redhat.com/show_bug.cgi?id=1221293 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #11 from Fedora Update System --- nodejs-normalize-git-url-1.0.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1214357] Review Request: dist-git - Package source version control system
https://bugzilla.redhat.com/show_bug.cgi?id=1214357 Fedora Update System changed: What|Removed |Added Fixed In Version|dist-git-0.11-1.fc21|dist-git-0.11-1.el7 --- Comment #19 from Fedora Update System --- dist-git-0.11-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221218] Review Request: nodejs-fs-write-stream-atomic - Like fs.createWriteStream(...), but atomic
https://bugzilla.redhat.com/show_bug.cgi?id=1221218 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #12 from Fedora Update System --- nodejs-fs-write-stream-atomic-1.0.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 889011] Review Request: rubygem-asciidoctor - AsciiDoc implementation in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=889011 --- Comment #34 from Fedora Update System --- rubygem-asciidoctor-1.5.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 510843] Review Request: samtools - Tools for nucleotide sequence alignments in the SAM format
https://bugzilla.redhat.com/show_bug.cgi?id=510843 Adam Huffman changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #16 from Adam Huffman --- Package Change Request == Package Name: samtools New Branches: EL-7 Owners: verdurin -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212699] Review Request: mediawiki123-HTTP302Found - Forces an external HTTP 302 redirect instead of internal redirects
https://bugzilla.redhat.com/show_bug.cgi?id=1212699 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||mediawiki123-HTTP302Found-2 ||.0.1-3.el7 Resolution|--- |ERRATA Last Closed||2015-05-29 17:45:26 --- Comment #6 from Fedora Update System --- mediawiki123-HTTP302Found-2.0.1-3.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215071] Review Request: querydsl - Type-safe queries for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1215071 --- Comment #3 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9884796 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 --- Comment #9 from Fedora Update System --- morphia-0.105-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/morphia-0.105-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 751925] Review Request: python-tables - Hierarchical datasets in Python
https://bugzilla.redhat.com/show_bug.cgi?id=751925 --- Comment #24 from Zbigniew Jędrzejewski-Szmek --- https://admin.fedoraproject.org/updates/python-tables-3.2.0-1.el7,blosc-1.6.1-1.el7,python-blosc-1.2.7-3.el7,python-numexpr-2.3-4.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675588] Review Request: pycmd - Tools for managing/searching Python related files
https://bugzilla.redhat.com/show_bug.cgi?id=675588 --- Comment #20 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675588] Review Request: pycmd - Tools for managing/searching Python related files
https://bugzilla.redhat.com/show_bug.cgi?id=675588 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177958] Review Request: libsbw - C++ Broker library
https://bugzilla.redhat.com/show_bug.cgi?id=1177958 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added CC||zbys...@in.waw.pl --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Update? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174290] Review Request: scalasca - Toolset for scalable performance analysis of large-scale parallel applications
https://bugzilla.redhat.com/show_bug.cgi?id=1174290
Zbigniew Jędrzejewski-Szmek changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||zbys...@in.waw.pl
Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
Flags||fedora-review?
--- Comment #6 from Zbigniew Jędrzejewski-Szmek ---
(In reply to Dave Love from comment #4)
> (In reply to Vladimir Stackov from comment #3)
>
> > https://fedoraproject.org/wiki/Packaging:Guidelines#.25clean
>
> Yes, but I'm doing what the packaging guidelines say by using a template and
> rpmlint. This seems harmless and trivial in comparison to feedback I was
> hoping for before doing similar tools.
Less is better. It is easier to read (or review) the spec file if it doesn't
contain unnecessary elements. The guidelines are normative, and rpmlint and
templates are often out of date.
Similarly for BuildRoot tag: please remove it.
> > https://fedorahosted.org/fpc/ticket/411
> > https://fedoraproject.org/wiki/Changes/
> > Use_license_macro_in_RPMs_for_packages_in_Cloud_Image
>
> I can't tell what the status of that is, even. It's not in the guidelines,
> I haven't seen anything use it, and I don't understand what you gain by
> substituting the contents of the license tag somewhere. I want to include
> actual documents, which aren't necessarily just the GPL, or whatever.
Please see
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text.
Using %license is now mandatory. It does not substitute the file, just changes
the location and makes rpm install it even if docs are excluded.
If you want to retain compatibility with older releases, you can use:
%files
%{!?_licensedir:%global license %%doc}
%license COPYING
It's a question of preference, but I'd change stuff like:
for d in openmpi \
%if %{with mpich}
mpich
%endif
do
pushd $d
make install DESTDIR=$RPM_BUILD_ROOT
popd
done
to
%makeinstall -C openmpi
%if %{with mpich}
%makeinstall -C mpich
%endif
... just to be easier on the eyes :)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761
--- Comment #3 from Julien Enselme ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Permissions on files are set properly.
Note: See rpmlint output
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE.txt is marked as %doc instead of %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
= MUST items =
C/C++:
[X]: Package does not contain kernel modules.
[X]: Package contains no static executables.
[X]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 92 files have unknown license. Detailed
output of licensecheck in /tmp/1203761-python-Fiona/licensecheck.txt
[X]: License file installed when any subpackage combination is installed.
[X]: %build honors applicable compiler flags or justifies otherwise.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[X]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 184320 bytes in 18 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[X]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[X]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358 errata-xmlrpc changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675588] Review Request: pycmd - Tools for managing/searching Python related files
https://bugzilla.redhat.com/show_bug.cgi?id=675588 Thomas Moschny changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #19 from Thomas Moschny --- Package Change Request == Package Name: pycmd New Branches: epel7 Owners: thm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223623] Review Request: python-num2words - Modules to convert numbers to words
https://bugzilla.redhat.com/show_bug.cgi?id=1223623 --- Comment #4 from Zbigniew Jędrzejewski-Szmek --- See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Valid_License_Short_Names: LGPL should be changed to LGPLv2 or LGPLv2+. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725733] Review Request: rubygem-closure-compiler - Ruby Wrapper for the Google Closure Compiler
https://bugzilla.redhat.com/show_bug.cgi?id=725733 --- Comment #1 from Zbigniew Jędrzejewski-Szmek --- Oh, this is rather old. If you still want this reviewed, it should be updated to depend on closure-compiler. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177857] Review Request: libsedml - Library that fully supports SED-ML for SBML
https://bugzilla.redhat.com/show_bug.cgi?id=1177857 --- Comment #8 from Antonio Trande --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #7) > Will you be preparing an update, or should I review this version? I'm preparing an update. > > Looking at the spec file, at least the %descriptions are wrong: they are all > the same. Indeed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 725733] Review Request: rubygem-closure-compiler - Ruby Wrapper for the Google Closure Compiler
https://bugzilla.redhat.com/show_bug.cgi?id=725733 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223623] Review Request: python-num2words - Modules to convert numbers to words
https://bugzilla.redhat.com/show_bug.cgi?id=1223623 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|NEW |ASSIGNED CC||zbys...@in.waw.pl Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl Flags||fedora-review? --- Comment #3 from Zbigniew Jędrzejewski-Szmek --- Is there a particular reason to remove the tests? It's good to have tests in the installed package too. Raphael is right: you should not download the license file from gnu.org. But you can use the file from the upstream repository: https://github.com/savoirfairelinux/num2words/blob/master/COPYING . Looks OK otherwise. I'll take the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358 Jan Pokorný changed: What|Removed |Added Status|VERIFIED|POST -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358 Jan Pokorný changed: What|Removed |Added Status|POST|MODIFIED Fixed In Version|clufter-0.11.1-1.el6|clufter-0.11.2-1.el6 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177857] Review Request: libsedml - Library that fully supports SED-ML for SBML
https://bugzilla.redhat.com/show_bug.cgi?id=1177857 --- Comment #7 from Zbigniew Jędrzejewski-Szmek --- Will you be preparing an update, or should I review this version? Looking at the spec file, at least the %descriptions are wrong: they are all the same. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 --- Comment #6 from Tom Hughes --- OK so it looks like packaging from github was a really bad idea of mine... The github version (quite reasonably) doesn't have columnify.js, so you would need to be able to generate it by running babel in the spec, only we don't have babel. So I think you're going to have to do it from the NPM repository for now at least, and if you want the tests you'll have to grab them from github as a separate source. Apologies for leading you on that wild goose chase. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1217857] Review Request: bandit - A framework for performing security analysis of Python source code
https://bugzilla.redhat.com/show_bug.cgi?id=1217857 --- Comment #11 from Zbigniew Jędrzejewski-Szmek --- ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 --- Comment #2 from Miro Hrončok --- Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/python-Fiona.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-Fiona-1.5.0-1.fc21.src.rpm Done, also added pytest and ogrinfo binary. I've tried a rawhide mock build after the change and it works. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226406] New: Review Request: R-S4Vectors - S4 implementation of vectors and lists
https://bugzilla.redhat.com/show_bug.cgi?id=1226406 Bug ID: 1226406 Summary: Review Request: R-S4Vectors - S4 implementation of vectors and lists Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: tcall...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://spot.fedorapeople.org/R-S4Vectors.spec SRPM URL: https://spot.fedorapeople.org/R-S4Vectors-0.6.0-1.fc22.src.rpm Description: The S4Vectors package defines the Vector and List virtual classes and a set of generic functions that extend the semantic of ordinary vectors and lists in R. Package developers can easily implement vector-like or list-like objects as concrete subclasses of Vector or List. In addition, a few low-level concrete subclasses of general interest (e.g. DataFrame, Rle, and Hits) are implemented in the S4Vectors package itself (many more are implemented in the IRanges package and in other Bioconductor infrastructure packages). Fedora Account System Username: spot Koji Rawhide Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=9880383 Note: This is a core dep for the majority of the current Bioconductor stack. It currently will only build against Rawhide due to the version requirement of BiocGenerics -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo --- Thanks for the review! New Package SCM Request === Package Name: morphia Short Description: A type-safe Java library for MongoDB Upstream URL: https://github.com/mongodb/morphia Owners: gil Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 Jerry James changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Jerry James --- Sorry, I don't know what happened there. I could have sworn that the Requires weren't versioned when I looked at them last night, but looking at them now, they clearly are versioned. Anyway, I see no further issues, so this package is APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 Julien Enselme changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|juj...@jujens.eu Flags||fedora-review? --- Comment #1 from Julien Enselme --- Build in mock fails during tests because of "ImportError: No module named six". The six module is required according to https://github.com/Toblerity/Fiona/blob/master/setup.py#L129. Can you please add it as BuildRequire and Require. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=1215046 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=1215046 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177857] Review Request: libsedml - Library that fully supports SED-ML for SBML
https://bugzilla.redhat.com/show_bug.cgi?id=1177857 --- Comment #6 from Antonio Trande --- I'm going to update this package to the latest commit. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223623] Review Request: python-num2words - Modules to convert numbers to words
https://bugzilla.redhat.com/show_bug.cgi?id=1223623 William Moreno changed: What|Removed |Added Flags|needinfo?(williamjmorenor@g | |mail.com) | --- Comment #2 from William Moreno --- Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-num2words.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-num2words-0.5.2-2.fc21.src.rpm - - 0.5.2-2 - Remove /test after %%check I do not agree about remove the test of the gpl, I am packaging the tarball from pypi and this tarball do not include the text of the GPL. The GPL requires than a copy of the license must be provived with the source, there is a mistake to not include the license file when you use GPL. I have opened a issue on github to include the license file in the pypi tarball https://github.com/savoirfairelinux/num2words/issues/21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=1215046 Fabien Boucher changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Fabien Boucher --- New Package SCM Request === Package Name: python-gear Short Description: Pure Python Async Gear Protocol Library Upstream URL: https://github.com/openstack-infra/gear Owners: fbo Branches: f20 f21 f22 epel7 InitialCC: misc -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1217563] Review Request: bonecp - JDBC Connection Pool
https://bugzilla.redhat.com/show_bug.cgi?id=1217563 gil cattaneo changed: What|Removed |Added Blocks||1089552 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1089552 [Bug 1089552] Review Request: mybatis-guice - Google Guice integration for MyBatis 3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1089552] Review Request: mybatis-guice - Google Guice integration for MyBatis 3
https://bugzilla.redhat.com/show_bug.cgi?id=1089552 gil cattaneo changed: What|Removed |Added Depends On||1217563 --- Comment #2 from gil cattaneo --- Spec URL: http://gil.fedorapeople.org/mybatis-guice.spec SRPM URL: http://gil.fedorapeople.org/mybatis-guice-3.6-1.fc20.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9878072 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1217563 [Bug 1217563] Review Request: bonecp - JDBC Connection Pool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215046] Review Request: python-gear - Pure Python Async Gear Protocol Library
https://bugzilla.redhat.com/show_bug.cgi?id=1215046 --- Comment #6 from Fabien Boucher --- Hi Michael, Thank for the review ! I guess I can fix the items you mentioned after I got the access to the SCM ? I'll do the SCM request. For python 3, it seems the library is compatible so I'll add the required elements in the spec file. Cheers, Fabien -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1167444] Review Request: wificurse - WiFi DoS attack tool for auditing wireless networks.
https://bugzilla.redhat.com/show_bug.cgi?id=1167444 --- Comment #10 from Fedora End Of Life --- This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 --- Comment #6 from Fedora Update System --- mysema-commons-lang-0.2.4-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/mysema-commons-lang-0.2.4-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080 --- Comment #5 from gil cattaneo --- (In reply to gil cattaneo from comment #4) > (In reply to Jerry James from comment #3) > This/ese is a noarch package/s is not necessary add "explicit versioned > Requires" > there is no way to "mix and match versions", our Java tools resolve this > operation see inthe build.log [INFO maven.req] -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||0.1.7-1.fc23 Resolution|--- |RAWHIDE Last Closed||2015-05-29 08:22:34 --- Comment #9 from gil cattaneo --- Thanks for all! Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9877052 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 --- Comment #5 from Zuzana Svetlikova --- Is that okay? Spec URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-columnify/nodejs-columnify.spec SRPM URL: https://fedorapeople.org/~zvetlik/nodejs/nodejs-columnify/nodejs-columnify-1.5.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226013] Review Request: fwupdate - firmware update utility and library
https://bugzilla.redhat.com/show_bug.cgi?id=1226013 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226013] Review Request: fwupdate - firmware update utility and library
https://bugzilla.redhat.com/show_bug.cgi?id=1226013 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223843] Review Request: python-anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223627] Review Request: gap-pkg-edim - Elementary divisors of integer matrices
https://bugzilla.redhat.com/show_bug.cgi?id=1223627 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223627] Review Request: gap-pkg-edim - Elementary divisors of integer matrices
https://bugzilla.redhat.com/show_bug.cgi?id=1223627 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222690] Review Request: gap-pkg-fga - Free group algorithms for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1222690 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222690] Review Request: gap-pkg-fga - Free group algorithms for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1222690 --- Comment #4 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205777] Review Request: gap-pkg-autpgrp - Compute the automorphism group of a p-Group in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205777 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205777] Review Request: gap-pkg-autpgrp - Compute the automorphism group of a p-Group in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205777 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1107880] Review Request: ffos-cli - Simple program to help programmers create Firefox OS applications easier
https://bugzilla.redhat.com/show_bug.cgi?id=1107880 --- Comment #4 from Fedora End Of Life --- This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1068988] Fedora lacks a package for pyload
https://bugzilla.redhat.com/show_bug.cgi?id=1068988 --- Comment #5 from Fedora End Of Life --- This message is a reminder that Fedora 20 is nearing its end of life. Approximately 4 (four) weeks from now Fedora will stop maintaining and issuing updates for Fedora 20. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '20'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 20 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 675588] Review Request: pycmd - Tools for managing/searching Python related files
https://bugzilla.redhat.com/show_bug.cgi?id=675588 --- Comment #18 from Thomas Moschny --- (In reply to Orion Poplawski from comment #17) > Thomas - would you be willing to maintain pycmd in EPEL7? Sure, will have a look. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223843] Review Request: python-anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843 Jan Chaloupka changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223843] Review Request: python-anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843 Jan Chaloupka changed: What|Removed |Added Summary|Review Request: anymarkup |Review Request: |- Parse or serialize any|python-anymarkup - Parse or |markup in Python|serialize any markup in ||Python Flags||fedora-cvs? --- Comment #15 from Jan Chaloupka --- New Package SCM Request === Package Name: python-anymarkup Short Description: Parse or serialize any markup in Python Upstream URL: https://github.com/bkabrda/anymarkup Owners: jchaloup pviktori Branches: f22 f21 f20 el6 el7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223843] Review Request: anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843
Petr Viktorin changed:
What|Removed |Added
Whiteboard|NotReady|
Flags|fedora-review? |fedora-review+
--- Comment #14 from Petr Viktorin ---
Good to go!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= MUST items =
Generic:
[X]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[X]: License field in the package spec file matches the actual license.
[X]: License file installed when any subpackage combination is installed.
[X]: Package contains no bundled libraries without FPC exception.
[X]: Changelog in prescribed format.
[X]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[X]: Package uses nothing in %doc for runtime.
[X]: Package consistently uses macros (instead of hard-coded directory
names).
[X]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[X]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[X]: Requires correct, justified where necessary.
[X]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[X]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[X]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[-]: Python eggs must not download any dependencies during the build
process.
[X]: A package which is used by another package via an egg interface should
provide egg info.
[X]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[X]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: python3-anymarkup is an independent subpackage
[X]: Package functions as described.
[X]: Latest version is packaged.
[X]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[X]: Package should compile and build into binary rpms on all supported
architectures.
[X]: %check is present and all tests pass.
[X]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_RO
[Bug 1223843] Review Request: anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843 --- Comment #13 from Jan Chaloupka --- Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=9875343 SRPM: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup-0.4.2-1.fc23.src.rpm Spec: https://jchaloup.fedorapeople.org/reviews/anymarkup/python-anymarkup.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223843] Review Request: anymarkup - Parse or serialize any markup in Python
https://bugzilla.redhat.com/show_bug.cgi?id=1223843
--- Comment #12 from Petr Viktorin ---
Three problems -- sorry for missing some of these earlier:
- The Source0 URL is wrong, should be
https://pypi.python.org/packages/source/a/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
- The LICENSE file is installed as %doc. (This is a bug in my template,
apologies!)
- Requires: python3-pytest is unnecessary - tests aren't required at run-time.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219411] Review Request: python34 - Version 3 of the Python programming language aka Python 3000
https://bugzilla.redhat.com/show_bug.cgi?id=1219411 --- Comment #5 from Matej Stuchlik --- > > The point of that flag is to make debugging the debug build easier, but now > > that you mention it, it should be set to -O0 or -Og. Will fix! > > But why do you need something different from the Fedora python3 package? The same option is used in Rawhide, actually. :) But it should be in f22/f21 as well, let me look into that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 826038] Review Request: proxytoys - An implementation neutral API for creation of dynamic proxies
https://bugzilla.redhat.com/show_bug.cgi?id=826038 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 --- Comment #4 from gil cattaneo --- New Package SCM Request === Package Name: mysema-commons-lang Short Description: Mysema Commons Lang Upstream URL: http://www.mysema.com/ Owners: gil Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1219411] Review Request: python34 - Version 3 of the Python programming language aka Python 3000
https://bugzilla.redhat.com/show_bug.cgi?id=1219411 --- Comment #4 from Aurelien Bompard --- > Correct, in the final package it should be and will be, first however one > needs to resolve the dependency cycle between Python, pip, setuptools and > wheel. There's more about this at the top of the .spec file in the comment. OK, we're on the same page. > The purpose of the main_python3 flag is somewhat explained in [0], in > "Lifecycle of python3X stacks, rebuilding". Let me know if it's not clear. :) > I'll add a comment to the .spec explaining the purpose of the flag. > > Note that Python 3 is actually *not* in RHEL 7, hence why there's a need for > it in EPEL. Oh, right, I was certain that it was there. It all makes sense then :-) > The point of that flag is to make debugging the debug build easier, but now > that you mention it, it should be set to -O0 or -Og. Will fix! But why do you need something different from the Fedora python3 package? The other changes in the SRPM are OK, the macros look correct. I'm now waiting for your fixes to test the binary and make another (possibly final :) ) review. Thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1177451] Review Request: minidns - Minimal DNS library for java and android systems
https://bugzilla.redhat.com/show_bug.cgi?id=1177451 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo --- Thanks! New Package SCM Request === Package Name: minidns Short Description: Minimal DNS library for Java and Android systems Upstream URL: https://github.com/rtreffer/minidns Owners: gil InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215080] Review Request: morphia - A type-safe java library for MongoDB
https://bugzilla.redhat.com/show_bug.cgi?id=1215080
--- Comment #4 from gil cattaneo ---
(In reply to Jerry James from comment #3)
> Issues:
> ===
> - Package does not contain duplicates in %files.
> Note: warning: File listed twice: /usr/share/java/morphia
> See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles
>
> This is probably due to the presence of %dir %{_javadir}/%{name} in %files.
Fixed
> - While the subpackages have dependencies generated for them by maven that
> result in them requiring the main package, those dependencies are
> unversioned. I think you should also have explicit versioned Requires in
> the subpackages so that it is not possible for someone to mix and match
> versions.
This/ese is a noarch package/s is not necessary add "explicit versioned
Requires"
there is no way to "mix and match versions", our Java tools resolve this
operation
Spec URL: https://gil.fedorapeople.org/morphia.spec
SRPM URL: https://gil.fedorapeople.org/morphia-0.105-2.fc20.src.rpm
- remove duplicate files
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215074] Review Request: mysema-commons-lang - Mysema Commons Lang
https://bugzilla.redhat.com/show_bug.cgi?id=1215074 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #3 from gil cattaneo --- Thanks! New Package SCM Request === Package Name: mysema-commons-lang Short Description: Mysema Commons Lang Upstream URL: http://www.mysema.com/ Owners: gil InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
