[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #8 from Julien Enselme --- > I see LICENSE file in the tarball, but no %license in the package. The LICENSE was not present in the fist tarball I used but it is in the tarball from pypi. Added. > Feels useless, as this package should automatically require /usr/bin/python Indeed, require removed. > Any chance for longer description? Use a longer description. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1224028] Review Request: rubygem-rmail-sup - A lightweight mail library written in ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1224028 Parag AN(पराग) changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) --- Issues: 1) We don't need to specify explicitly provides: now. See https://fedoraproject.org/wiki/Packaging:Ruby?rd=Packaging/Ruby#Filtering_Requires_and_Provides Rest looks fine to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779
--- Comment #7 from Ding-Yi Chen ---
(In reply to Raphael Groner from comment #6)
> Two more informal things to mention:
>
> > Patch0: %{name}-formatSecurity.patch
> Where do you have this patch from? Did you try to send it to upstream? If it
> can be found there, please provide a link, either directly the URL as value
> or another link in the comment.
This patch is to fix the compile error when -Werror=format-security is on.
The bug report and the patch is at:
https://sourceforge.net/p/skfans/bugs/4/
> Please remove the rm line from %install, you can move it to %clean. Note
> that this section is now redundant in Fedora and is only necessary for EPEL6.
Done.
> I could do the official review. But as I am on vacation currently, this is
> going to happen not before in the next weeks.
It is OK for me.
Spec URL: https://dchen.fedorapeople.org/files/rpms/7kaa.spec
SRPM URL: https://dchen.fedorapeople.org/files/rpms/7kaa-2.14.5-2.fc22.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223673] Review Request: llvm35 - The Low Level Virtual Machine
https://bugzilla.redhat.com/show_bug.cgi?id=1223673 --- Comment #4 from Jens Petersen --- Thanks! Appreciated :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1079064] Review Request: btbuilder - Role-playing game construction set in the style of the Bard's Tale Construction Set
https://bugzilla.redhat.com/show_bug.cgi?id=1079064 --- Comment #21 from Dennis Payne --- SDL_mng does create a shared library in the latest version. I don't believe that was the case initially. Do I need to open a new request for SDL_mng? I've forked the SDL_mng library. It adds my additions for animation state objects. Some memory leaks are fixed. One function is renamed to conform with naming convention in SDL. That function is also fixed to actually work. Bt Builder: Spec URL: https://raw.githubusercontent.com/dulsi/btbuilder/master/btbuilder.spec SRPM URL: http://identicalsoftware.com/btbuilder/btbuilder-0.5.3-1.fc22.src.rpm SDL_mng Spec URL: https://raw.githubusercontent.com/dulsi/SDL_mng/master/SDL_mng.spec SRPM URL: http://identicalsoftware.com/btbuilder/SDL_mng-0.2.2-2.fc22.src.rpm The new btbuilder won't open a massive window anymore. I don't think SDL give me the size of a single screen but I'll look into that later. Is there a forum or mailing list for mingw cross-compiling? I've copied the SDL_image mingw spec and modified it but it doesn't work. I don't know how to fix the error. (For the time being I'll just build the windows versions with SDL_mng files copied into it but ideally I want it built the same as the linux version.) The error is: configure: error: source directory already configured; run "make distclean" there first -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1158080] Review Request: php-guzzlehttp-ringphp - Simple handler system used to power clients and servers in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1158080 Shawn Iwinski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2015-05-31 22:57:06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 Jerry James changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Jerry James --- New Package SCM Request === Package Name: gap-pkg-alnuth Short Description: Algebraic number theory for GAP Upstream URL: http://www.icm.tu-bs.de/ag_algebra/software/Alnuth/ Owners: jjames Branches: f22 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 --- Comment #6 from Jerry James --- (In reply to gil cattaneo from comment #5) > NON blocking issues found > > gap-pkg-alnuth.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-alnuth/GPL > > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address > > Please, fix before import. informing upstream about this. > > Approved Okay, I will inform upstream. Thank you again for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178162] Review Request: springframework-data-commons - Interfaces and code shared between the various datastore specific implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1178162 --- Comment #4 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/springframework-data-commons.spec SRPM URL: https://gil.fedorapeople.org/springframework-data-commons-1.8.4-1.fc20.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9900439 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from gil cattaneo --- NON blocking issues found gap-pkg-alnuth.noarch: E: incorrect-fsf-address /usr/share/licenses/gap-pkg-alnuth/GPL https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address Please, fix before import. informing upstream about this. Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905
--- Comment #4 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
NOTE: manual review
= MUST items =
Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
Note: Using prebuilt packages
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "*No copyright* GPL". 4 files have
unknown license. Detailed output of licensecheck in /home/gil/1205905
-gap-pkg-alnuth/srpm/review-gap-pkg-alnuth/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/licenses
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/licenses
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
Note: Using prebuilt rpms.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Reviewer should test that the package builds in mock.
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[?]: Packages should try to preserve timestamps of original installed
files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin,
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 --- Comment #7 from Fedora Update System --- gap-pkg-polycyclic-2.11-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/gap-pkg-polycyclic-2.11-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205905] Review Request: gap-pkg-alnuth - Algebraic number theory for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205905 Jerry James changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Jerry James --- (In reply to gil cattaneo from comment #1) > Please, let me know how and when gap-pkg-polycyclic available in rawhide Okay, gap-pkg-polycyclic is now available in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 --- Comment #10 from Fedora Update System --- python-Fiona-1.5.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-Fiona-1.5.1-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 --- Comment #9 from Fedora Update System --- python-Fiona-1.5.1-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-Fiona-1.5.1-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226719] Review Request: menulibre - FreeDesktop.org compliant menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1226719 Marcus Karlsson changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226719] New: Review Request: menulibre - FreeDesktop.org compliant menu editor
https://bugzilla.redhat.com/show_bug.cgi?id=1226719 Bug ID: 1226719 Summary: Review Request: menulibre - FreeDesktop.org compliant menu editor Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: m...@acc.umu.se QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://www.acc.umu.se/~mk/fedora/menulibre/20150531T2115/menulibre.spec SRPM URL: https://www.acc.umu.se/~mk/fedora/menulibre/20150531T2115/menulibre-2.0.6-1.fc22.src.rpm Description: MenuLibre is a graphical FreeDesktop.org compliant menu editor that lets you edit menu entries. Fedora Account System Username: marcusk Koji build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=9899336 I have not submitted a package before and is seeking a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075806] Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1075806 --- Comment #17 from Sebastian Dyroff --- First of all, I really appreciate any help to get this done. Sorry, I am very busy with non fedora related things. I tested your version, and it did not work for me. The fcgiwrap.service file requires a user http that does not exist on a system without apache installed and fails to start. Also I did not see any selinux rules. By default, the selinux policy forbids the webserver to connect to the fcgiwrap socket(I could not test this step with your version, because it didn't start on the cloud image). Steps I did for installing: - Used a fedora 21 cloud base image (Sorry do not have a 22 for now) - installed your copr repo with dnf - installed your fcgiwrap package with dnf - started the fcgiwrap socket with systemctl - started the fcgiwrap service with systemctl log output was: $ sudo systemctl status fcgiwrap ● fcgiwrap.service - Simple CGI Server Loaded: loaded (/usr/lib/systemd/system/fcgiwrap.service; static) Active: failed (Result: exit-code) since Sun 2015-05-31 19:49:22 UTC; 8min ago Process: 1003 ExecStart=/usr/sbin/fcgiwrap (code=exited, status=217/USER) Main PID: 1003 (code=exited, status=217/USER) May 31 19:49:22 fcgiwrap-test.localdomain systemd[1]: Starting Simple CGI Server... May 31 19:49:22 fcgiwrap-test.localdomain systemd[1]: Started Simple CGI Server. May 31 19:49:22 fcgiwrap-test.localdomain systemd[1]: fcgiwrap.service: main process exited, code=exited, status=217/USER May 31 19:49:22 fcgiwrap-test.localdomain systemd[1]: Unit fcgiwrap.service entered failed state. May 31 19:49:22 fcgiwrap-test.localdomain systemd[1]: fcgiwrap.service failed. I uploaded my intermediate version of the spec file here: http://www.dyroff.net/fedora/fcgiwrap.tar.bz2 If you want to continue working on my spec file, we should setup a git repo to cordinate and bring it in shape. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178162] Review Request: springframework-data-commons - Interfaces and code shared between the various datastore specific implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1178162 --- Comment #3 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9898514 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1209166] Review Request: palo - cell-oriented, multi-dimensional in-memory OLAP server
https://bugzilla.redhat.com/show_bug.cgi?id=1209166 Michael Schwendt (Fedora Packager Sponsors Group) changed: What|Removed |Added Summary|(FE-NEEDSPONSOR) Review |Review Request: palo - |Request: palo - |cell-oriented, |cell-oriented, |multi-dimensional in-memory |multi-dimensional in-memory |OLAP server |OLAP server | --- Comment #5 from Michael Schwendt (Fedora Packager Sponsors Group) --- There is a separate list of FE-NEEDSPONSOR tickets in the Cached Package Review Tracker at: http://fedoraproject.org/PackageReviewStatus/ It is not necessary to put 'FE-NEEDSPONSOR' into the summary line. Entering your full name in the bugzilla account details can be helpful. Try pointing the fedora-review tool at this ticket: fedora-review -b 1209166 It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest packages, performs local test-builds and many checks related to the packaging guidelines. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #7 from Miro Hrončok --- > Requires: python Feels useless, as this package should automatically require /usr/bin/python and python(abi) = 2.7 Any chance for longer description? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #6 from Miro Hrončok --- I see LICENSE file in the tarball, but no %license in the package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #5 from Miro Hrončok --- I forgot to link this: https://code.google.com/p/closure-linter/issues/detail?id=81 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 Miro Hrončok changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|mhron...@redhat.com Flags||fedora-review? --- Comment #4 from Miro Hrončok --- Apparently, it is indeed not Python 3 compatible. OK, I'll take the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 984560] Review Request: Enki - Extensible text editor for programmers
https://bugzilla.redhat.com/show_bug.cgi?id=984560 --- Comment #12 from Raphael Groner --- Is it possible to get it done with PyQt5 (package name for dependency: python-qt5) ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1015868] Review Request: python-qutepart - Source code text editor component based on Qt
https://bugzilla.redhat.com/show_bug.cgi?id=1015868 --- Comment #23 from Raphael Groner --- Is it possible to get it done with PyQt5 (package name for dependency: python-qt5) ? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #3 from Julien Enselme --- (In reply to Miro Hrončok from comment #2) > No Python 3 support? Not that I am aware of. There nothing in pypi or the setup.py that indicates that this program is compatible with python 3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure-linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 Julien Enselme changed: What|Removed |Added Summary|Review Request: |Review Request: |python-closure_linter - |python-closure-linter - |Style checker for |Style checker for |JavaScript |JavaScript -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178149] Review Request: springframework-hateoas - Representations for hyper-text driven REST web services
https://bugzilla.redhat.com/show_bug.cgi?id=1178149 --- Comment #8 from Fedora Update System --- springframework-hateoas-0.16.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/springframework-hateoas-0.16.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178149] Review Request: springframework-hateoas - Representations for hyper-text driven REST web services
https://bugzilla.redhat.com/show_bug.cgi?id=1178149 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure_linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #2 from Miro Hrončok --- No Python 3 support? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1075806] Review Request: fcgiwrap - Simple FastCGI wrapper for CGI scripts
https://bugzilla.redhat.com/show_bug.cgi?id=1075806 --- Comment #16 from Juan Orti --- (In reply to Sebastian Dyroff from comment #14) > Hey just a short info. I am still working on it, when I have time. The > systemd unit files are now included, but it is neccessary to write an > selinux module to use the systemd socket by any webserver. While creating > the module, I stumbled over the following behaviour > https://bugzilla.redhat.com/show_bug.cgi?id=1197886. I will continue, if > this issue is resolved. I've build fcgiwrap on my own, and it's working fine using systemd socket activation. Maybe the problem you comment is already solved. Are you still interested in pushing this forward? I can help comaintaining if you wish. This is my version of the spec file and a copr with it: https://jorti.fedorapeople.org/fcgiwrap/ https://copr.fedoraproject.org/coprs/jorti/fcgiwrap/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1218159] Review Request: python-closure_linter - Style checker for JavaScript
https://bugzilla.redhat.com/show_bug.cgi?id=1218159 --- Comment #1 from Julien Enselme --- Update SPEC: - SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-closure-linter.spec - SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-closure-linter-2.3.13-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #1 from Julien Enselme --- Update to 0.6.6: - SPECS: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec - SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 --- Comment #7 from Miro Hrončok --- Thanks Julien, feel free to assign any review directly to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 Miro Hrončok changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Miro Hrončok --- New Package SCM Request === Package Name: python-Fiona Short Description: Fiona reads and writes spatial data files Upstream URL: http://github.com/Toblerity/Fiona Owners: churchyard Branches: f21 f22 InitialCC: python-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215071] Review Request: querydsl - Type-safe queries for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1215071 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215071] Review Request: querydsl - Type-safe queries for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1215071 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1205904] Review Request: gap-pkg-polycyclic - Algorithms on polycylic groups for GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1205904 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178149] Review Request: springframework-hateoas - Representations for hyper-text driven REST web services
https://bugzilla.redhat.com/show_bug.cgi?id=1178149 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178149] Review Request: springframework-hateoas - Representations for hyper-text driven REST web services
https://bugzilla.redhat.com/show_bug.cgi?id=1178149 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1226664] New: Review Request: fido-pi - Protein identification in MS/MS proteomics
https://bugzilla.redhat.com/show_bug.cgi?id=1226664 Bug ID: 1226664 Summary: Review Request: fido-pi - Protein identification in MS/MS proteomics Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: anto.tra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://sagitter.fedorapeople.org/Fido/fido-pi.spec SRPM URL: https://sagitter.fedorapeople.org/Fido/fido-pi-0-0.1.20150209git281e4d.fc22.src.rpm Description: Fido is a tool used in the area of computational proteomics. It calculates posterior probabilities for protein identifications based on database searches of tandem mass spectra. Fedora Account System Username: sagitter Another package named Fido is already in Fedora, i chose 'fido-pi' as name of this package. There are not conflicts between binary executable names. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779
Raphael Groner changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|nob...@fedoraproject.org|projects...@smart.ms
Flags||fedora-review?
--- Comment #6 from Raphael Groner ---
Two more informal things to mention:
> Patch0: %{name}-formatSecurity.patch
Where do you have this patch from? Did you try to send it to upstream? If it
can be found there, please provide a link, either directly the URL as value or
another link in the comment.
Please remove the rm line from %install, you can move it to %clean. Note that
this section is now redundant in Fedora and is only necessary for EPEL6.
I could do the official review. But as I am on vacation currently, this is
going to happen not before in the next weeks.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779 --- Comment #5 from Ding-Yi Chen --- Add command to execute downloader, and update to 7kaa-2.14.5 Spec URL: https://dchen.fedorapeople.org/files/rpms/7kaa.spec SRPM URL: https://dchen.fedorapeople.org/files/rpms/7kaa-2.14.5-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1224516] Review Request: httpcomponents-asyncclient - Apache components to build asynchronous client side HTTP services
https://bugzilla.redhat.com/show_bug.cgi?id=1224516 gil cattaneo changed: What|Removed |Added Summary|Review Request: |Review Request: |httpcomponents-asyncclient |httpcomponents-asyncclient |- Apache HttpComponents |- Apache components to |AsyncClient |build asynchronous client ||side HTTP services --- Comment #1 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/httpcomponents-asyncclient.spec SRPM URL: https://gil.fedorapeople.org/httpcomponents-asyncclient-4.1-1.fc20.src.rpm Description: Asynch HttpClient is a HTTP/1.1 compliant HTTP agent implementation based on HttpCore NIO and HttpClient components. It is a complementary module to Apache HttpClient intended for special cases where ability to handle a great number of concurrent connections is more important than performance in terms of a raw data throughput. Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=9897826 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1178162] Review Request: springframework-data-commons - Interfaces and code shared between the various datastore specific implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1178162 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1215071] Review Request: querydsl - Type-safe queries for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1215071 gil cattaneo changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from gil cattaneo --- (In reply to Jerry James from comment #6) > There are just two minor issues, an extraneous line in %files and the choice > of subpackage to install the license file into. Fixed Thanks for review Spec URL: https://gil.fedorapeople.org/querydsl.spec SRPM URL: https://gil.fedorapeople.org/querydsl-4.0.0-2.fc20.src.rpm New Package SCM Request === Package Name: querydsl Short Description: Type-safe queries for Java Upstream URL: http://www.querydsl.com Owners: gil Branches: f22 InitialCC: java-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1157273] Review Request: conky-manager-deluxepack - Deluxe Conky Manager Pack
https://bugzilla.redhat.com/show_bug.cgi?id=1157273 --- Comment #6 from Mosaab Alzoubi --- OK, Sorry for late.. Spec URL: http://downloads.sourceforge.net/project/cmdp/20141026/conky-manager-deluxepack.spec SRPM URL: http://downloads.sourceforge.net/project/cmdp/20141026/conky-manager-deluxepack-20141026-3.fc21.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 709328] Review Request: psi-plus - Jabber client based on Qt
https://bugzilla.redhat.com/show_bug.cgi?id=709328 --- Comment #111 from Raphael Groner --- (In reply to Raphael Groner from comment #110) > psi-plus snapshot of revision 457 currently is FTBFS cause of too old qmake. s/qmake/qconf/ We are waiting for qconf 1.5 from upstream. -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203761] Review Request: python-Fiona - Fiona reads and writes spatial data files
https://bugzilla.redhat.com/show_bug.cgi?id=1203761 Julien Enselme changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Julien Enselme --- Looks good. Approved! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
