[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 --- Comment #7 from Fedora Update System --- php-doctrine-doctrine-bundle-1.5.0-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-bundle-1.5.0-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 --- Comment #8 from Fedora Update System --- php-doctrine-doctrine-bundle-1.5.0-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-bundle-1.5.0-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 --- Comment #9 from Fedora Update System --- php-doctrine-doctrine-bundle-1.5.0-3.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-doctrine-doctrine-bundle-1.5.0-3.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 Michal Ambroz changed: What|Removed |Added Depends On||1236249 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236249 [Bug 1236249] Bluefish contains bundled python library jsbeautifier and others -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760
--- Comment #5 from Michal Ambroz ---
Hello,
generaly most of the checks are OK.
I have identified these issues:
1) Licenses/budled libraries
Package contains bundled libraries. I believe that html2text is problem even
from the licensing point of view.
My recommendation is to:
- unbundle html2text and pyparsig - which already have separate package
- agree with bluefish maintainer on unbundling js-beautify/jsbeautifier
- tneststring and wbxml - it would be probably best to ask mitmproxy author on
what would be the effort needed to unbundle those
2) Source checksums
- when checking the MD5 I have noticed that source on github and upstream
website are different. Packages seems to be same, but probably repacked on
different platform.
- Please can you inform the upstream about this issue?
3) Man pages
- this falls to the "should" not must category so it would not be blocking the
package approval.
- Please any chance getting the man-pages from the Debian package and try to
push it upstream?
Best regards
Michal Ambroz
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
- MIT
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 114 files have
unknown license.
- BSD - for example libmproxy/web/static/vendor.js
- GPLv3 - libmproxy/contrib/html2text.py
[!]: Package contains no bundled libraries without FPC exception.
- pyparsing /usr/lib/python2.7/site-packages/libmproxy/contrib/pyparsing.py -
there is already package pyparsing
- GPLv3 - libmproxy/contrib/html2text.py - https://github.com/aaronsw/html2text
- there is already package python-html2text
- MITM - jsbeautifier - https://github.com/beautify-web/js-beautify - part of
bluefish-shared-data package (probably issue there as well)
- libmproxy/tnetstring.py - https://github.com/rfk/tnetstring
- wbxml - libmproxy/contrib/wbxml -
https://github.com/davidpshaw/PyWBXMLDecoder
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 25 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name
[Bug 1236225] New: Review Request: jenkins-openid-plugin - Jenkins OpenID Plugin
https://bugzilla.redhat.com/show_bug.cgi?id=1236225 Bug ID: 1236225 Summary: Review Request: jenkins-openid-plugin - Jenkins OpenID Plugin Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mizde...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Depends On: 1236224 Spec URL: https://raw.githubusercontent.com/mizdebsk/newpkg/2a5ec417eff6acd0f24e2901710ee798869e98ea/jenkins-openid-plugin.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mizdebsk/newpkg/fedora-rawhide-x86_64/jenkins-openid-plugin-2.1.1-1.fc23/jenkins-openid-plugin-2.1.1-1.fc23.src.rpm Description: This package provides OpenID plugin for Jenkins. Fedora Account System Username: mizdebsk Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236224 [Bug 1236224] Review Request: openid4java-team - Team extension for openid4java -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236224] Review Request: openid4java-team - Team extension for openid4java
https://bugzilla.redhat.com/show_bug.cgi?id=1236224 Mikolaj Izdebski changed: What|Removed |Added Blocks||1236225 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236225 [Bug 1236225] Review Request: jenkins-openid-plugin - Jenkins OpenID Plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236224] New: Review Request: openid4java-team - Team extension for openid4java
https://bugzilla.redhat.com/show_bug.cgi?id=1236224 Bug ID: 1236224 Summary: Review Request: openid4java-team - Team extension for openid4java Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: mizde...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/mizdebsk/newpkg/bd7110a02adfb810cb44f51342f1e2e306341c96/openid4java-team.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/mizdebsk/newpkg/fedora-rawhide-x86_64/openid4java-team-1.0-1.fc23/openid4java-team-1.0-1.fc23.src.rpm Description: This package provides team extension for openid4java. Fedora Account System Username: mizdebsk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779 --- Comment #28 from Fedora Update System --- 7kaa-2.14.5-8.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/7kaa-2.14.5-8.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779 --- Comment #29 from Fedora Update System --- 7kaa-2.14.5-8.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/7kaa-2.14.5-8.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1220779] Review Request: 7kaa - Seven Kingdoms: Ancient Adversaries
https://bugzilla.redhat.com/show_bug.cgi?id=1220779 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1173625] Review Request: fcitx-qt5 - Fcitx IM module for Qt5
https://bugzilla.redhat.com/show_bug.cgi?id=1173625 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||fcitx-qt5-1.0.2-2.fc21 Resolution|--- |ERRATA Last Closed||2015-06-26 16:33:01 --- Comment #16 from Fedora Update System --- fcitx-qt5-1.0.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1158080] Review Request: php-guzzlehttp-ringphp - Simple handler system used to power clients and servers in PHP
https://bugzilla.redhat.com/show_bug.cgi?id=1158080 Bug 1158080 depends on bug 1131103, which changed state. Bug 1131103 Summary: php-guzzlehttp-streams-3.0.0 is available https://bugzilla.redhat.com/show_bug.cgi?id=1131103 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1232273] Review Request: pdfpc - A GTK based presentation viewer application for GNU/Linux
https://bugzilla.redhat.com/show_bug.cgi?id=1232273 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||pdfpc-4.0.0-2.fc22 Resolution|--- |ERRATA Last Closed||2015-06-26 16:30:45 --- Comment #9 from Fedora Update System --- pdfpc-4.0.0-2.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235831] Review Request: vim-vcscommand - version control system commands from within vim
https://bugzilla.redhat.com/show_bug.cgi?id=1235831
--- Comment #2 from Raphael Groner ---
Some informal things to mention:
* Please remove Group: line, it's obsolete and not needed.
* Where do you have the sources zip from? Please provide an URL or at least
comment in the spec file how you create it.
* Your description line is too long. Insert some line feeds to break it into
several lines.
* Use 'cp -p' to preserve timestamps.
* Remove %doc, it is not necessary: %doc %{vimfiles_root}/doc/*
* Reference the complete individual folders: remove the star ('*') at the end
of the %files lines but keep the trailing slashes ('/') at the pathes.
* The name of your linked SRPM file is wrong. Why is there no .srpm suffix?
* Please provide a koji scratch build for rawhide. You could test also for
other targets you plan a separate package for.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235305] Review Request: hitch - Network proxy that terminates TLS/SSL connections
https://bugzilla.redhat.com/show_bug.cgi?id=1235305 --- Comment #6 from Sören Möller --- Thank you, now I was able to run the tests (successful) by rpmbuild --define "runcheck 1" -bs hitch.spec rpmbuild --define "runcheck 1" --rebuild hitch-1.0.0-0.3.1.beta3.fc23.src.rpm (note the -bs instead of -bb) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1224265] Review Request: udiskie - Automounter for removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1224265
--- Comment #11 from Raphael Groner ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues generally:
* You can use -print and -delete as the options for find
to log and remove the disallowed files:
- find %{buildroot}%{python3_sitelib} -name '*.exe' | xargs rm -f
+ find %{buildroot} -name '*.exe' -print -delete
With that, you need also only one line to find in both py2 and py3 folders.
You should do that removal early in %prep, but I do not know if install fails.
https://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: There is no build directory. Running licensecheck on vanilla
upstream sources. No licenses found. Please check the source files for
licenses manually.
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
Note: Directories without known owners: /etc/polkit-1/rules.d,
/etc/polkit-1
=> This is handled in PolicyKit. So you must add Requires: polkit
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/icons/hicolor
(hicolor-icon-theme, fedora-logos),
/usr/share/icons/hicolor/scalable/actions(hicolor-icon-theme),
/usr/share/icons/hicolor/scalable(hicolor-icon-theme, fedora-logos)
=> Please remove them from %files, hicolor-icon-theme takes care of that.
=> Add Requires: hicolor-icon-theme
https://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_also_owned_by_a_package_implementing_required_functionality_of_your_package
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
=> see above.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[!]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in udiskie
=> Please fix.
https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 61440 bytes in 6 files.
=> List manpage without %doc, it is a separate file and has nothing to do with
documentation folder.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources u
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #9 from Fedora Update System --- light-locker-1.6.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #8 from Fedora Update System --- light-locker-1.6.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #7 from Fedora Update System --- light-locker-1.6.0-2.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/light-locker-1.6.0-2.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1230867
--- Comment #11 from Jie Kang ---
(In reply to Severin Gehwolf from comment #10)
> Here is an informal review of felix-scr 1.6.2. It built fine for me. Thanks!
>
> Package Review
> ==
>
> [!] URL in spec should be:
>
> http://felix.apache.org/documentation/subprojects/apache-felix-service-
> component-runtime.html
Done
> [!] There are references in spec to version 1.8.x. Please fix to use
> 1.6.2 instead.
Fixed
> [!] Summary in spec should be:
> "Summary: Apache Felix Declarative Services Runtime"
Fixed
> [!] Please remove commented out "#BuildRequires: mvn(org.eclipse:osgi)"
>
Removed
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
>
>
>
> = MUST items =
>
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
> other legal requirements as defined in the legal section of Packaging
> Guidelines.
> [x]: If (and only if) the source package includes the text of the
> license(s) in its own file, then that file, containing the text of the
> license(s) for the package is included in %license.
> [x]: License field in the package spec file matches the actual license.
> Note: Checking patched sources after %prep for licenses.
> [-]: License file installed when any subpackage combination is installed.
> [x]: Package requires other packages for directories it uses.
> Note: No known owner of /usr/share/maven-poms/felix
> This should be OK. I don't think this is specific to felix-scr. This is
> probably a bug in felix-osgi-core or some base package all other felix
> packages should require.
> [x]: Package must own all directories that it creates.
> Note: Directories without known owners: /usr/share/java/felix,
> /usr/share/maven-poms/felix
> This is OK. Same as above.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [?]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
> names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
> Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [?]: Package is not known to require an ExcludeArch tag.
> [x]: Large documentation must go in a -doc subpackage. Large could be size
> (~1MB) or number of files.
> Note: Documentation size is 30720 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
> one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
> Note: There are rpmlint messages (see attachment).
> [x]: Package does not own files or directories owned by other packages.
> [x]: All build dependencies are listed in BuildRequires, except for any
> that are listed in the exceptions section of Packaging Guidelines.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
> beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
> work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
> provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
> %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
>
> Java:
> [x]: Bundled jar/class files should be removed before build
> [x]: Packages have proper BuildRequires/Requires on jpackage-utils
> Note: Maven packages do not need to (Build)Require jpackage-utils. It
> is pulled in by maven-local
> [x]: Javadoc documentation files are generated and included in -javadoc
> subpackage
> [x]: Javadoc subpackages should not have Requires: jpackage-utils
> [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
>
> Maven:
> [x]: If package contains pom.xml files in
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230967] Review Request: php-doctrine-doctrine-bundle - Symfony Bundle for Doctrine
https://bugzilla.redhat.com/show_bug.cgi?id=1230967 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229610] Review Request: doxy2man - Create man pages from doxygen XML output
https://bugzilla.redhat.com/show_bug.cgi?id=1229610 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229610] Review Request: doxy2man - Create man pages from doxygen XML output
https://bugzilla.redhat.com/show_bug.cgi?id=1229610 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 --- Comment #13 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236151] New: Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation
https://bugzilla.redhat.com/show_bug.cgi?id=1236151 Bug ID: 1236151 Summary: Review Request: python-dockerfile-parse - Python library for Dockerfile manipulation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jpope...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jpopelka.fedorapeople.org/python-dockerfile-parse.spec SRPM URL: https://jpopelka.fedorapeople.org/python-dockerfile-parse-0.0.3-1.fc22.src.rpm Description: Python library for Dockerfile manipulation Fedora Account System Username: jpopelka -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets
https://bugzilla.redhat.com/show_bug.cgi?id=1198498 --- Comment #7 from Jason Tibbitts --- That's oversimplifying a bit. The actual ticket says: ACTION: Bundling of base64/random SSL setup bits. (+1:5, 0:1, -1:0) (geppetto, 17:19:48) ACTION: Bundling of "custom" sha1 implementation. (+1:3, 0:1, -1:2) … just link to the openssl functions, as you have build options for it. (geppetto, 17:20:04) https://fedorahosted.org/fpc/ticket/546#comment:2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #27 from Fedora Update System --- trojita-0.5-6.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 --- Comment #5 from Raphael Groner --- New Package SCM Request === Package Name: light-locker Short Description: A simple session-locker for lightdm Upstream URL: https://github.com/the-cavalry/light-locker Owners: raphgro Branches: f22 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 Raphael Groner changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #4 from Raphael Groner --- New Package SCM Request === Package Name: light-locker Short Description: Upstream URL: https://github.com/the-cavalry/light-locker Owners: raphgro Branches: f22 f21 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1224265] Review Request: udiskie - Automounter for removable media
https://bugzilla.redhat.com/show_bug.cgi?id=1224265 --- Comment #10 from Raphael Groner --- Sorry for the delay here. I am going to take a closer look inside, hopefully in the next days. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Rex Dieter --- Thanks, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Petr Pisar changed: What|Removed |Added Flags||fedora-cvs? --- Comment #2 from Petr Pisar --- New Package SCM Request === Package Name: perl-Encode-ISO2022 Short Description: ISO/IEC 2022 character encoding scheme Upstream URL: http://search.cpan.org/dist/Encode-ISO2022/ Owners: ppisar jplesnik psabata Branches: InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Petr Šabata changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata --- No issues discovered during the review. Approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236053] Review Request: perl-Dist-Metadata - Information about a Perl module distribution
https://bugzilla.redhat.com/show_bug.cgi?id=1236053 Petr Šabata changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Šabata --- Ack, approving. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236053] Review Request: perl-Dist-Metadata - Information about a Perl module distribution
https://bugzilla.redhat.com/show_bug.cgi?id=1236053 --- Comment #2 from Jitka Plesnikova --- Updated files are on the same links -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236053] Review Request: perl-Dist-Metadata - Information about a Perl module distribution
https://bugzilla.redhat.com/show_bug.cgi?id=1236053 --- Comment #1 from Petr Šabata --- Missing build time dependency: - coreutils -- called in SPEC (rm), line 60 Missing runtime dependency: - File::Basename -- lib/Dist/Metadata/Dist.pm:81 The rest looks good. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230209] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1230209
--- Comment #3 from Petr Pisar ---
Spec file changes:
--- perl-Test-Time.spec.old 2015-06-10 14:36:39.0 +0200
+++ perl-Test-Time.spec 2015-06-26 12:06:10.0 +0200
@@ -1,11 +1,18 @@
Name: perl-Test-Time
Version:0.04
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Overrides the time() and sleep() core functions for testing
License:GPL+ or Artistic
URL:http://search.cpan.org/dist/Test-Time/
Source0:
http://www.cpan.org/authors/id/S/SA/SATOH/Test-Time-%{version}.tar.gz
BuildArch: noarch
+
+BuildRequires: perl(inc::Module::Install)
+BuildRequires: perl(Module::Install::AuthorTests)
+BuildRequires: perl(Module::Install::Repository)
+BuildRequires: perl(Module::Install::ReadmeFromPod)
+BuildRequires: perl(Module::Install::TestBase)
+
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(Filter::Util::Call)
BuildRequires: perl(Test::More)
@@ -21,7 +28,8 @@
%setup -q -n Test-Time-%{version}
# Remove bundled modules
-for f in inc/Spiffy.pm \
+for f in $(find inc/Module -name *.pm) \
+inc/Spiffy.pm \
inc/Test/Base/Filter.pm \
inc/Test/Name/FromLine.pm \
inc/Test/More.pm \
@@ -54,5 +62,8 @@
%{_mandir}/man3/*
%changelog
+* Fri Jun 26 2015 Ralf Corsépius - 0.04-2
+- Remove bundled inc/Module.
+
* Mon Jun 08 2015 Ralf Corsépius - 0.04-1
- Initial package.
> TODO: Use plain `perl' command instead of %{__perl} macro and build-require
> `perl'.
Not addressed. Ok.
> FIX: Remove all the bundled Module::Install files from ./inc, build-require
> `perl(inc::Module::Install)' and other needed modules from Module::Install
> namespace (locate functions called from Makefile.PL). Or declare all
> build-time dependencies for the bundled Module::Install modules.
+BuildRequires: perl(inc::Module::Install)
+BuildRequires: perl(Module::Install::AuthorTests)
+BuildRequires: perl(Module::Install::Repository)
+BuildRequires: perl(Module::Install::ReadmeFromPod)
+BuildRequires: perl(Module::Install::TestBase)
That's fine, but not enough. Even upstream don't know what dependencies needs.
Please also:
FIX: Build-require `perl(Module::Install::Metadata)' (Makefile.PL:24).
FIX: BUild-require `perl(Module::Install::Include)' (Makefile.PL:43).
> FIX: Build-require `coreutils' (perl-Test-Time.spec:32).
> FIX: Build-require `sed' (perl-Test-Time.spec:33).
> FIX: Build-require `make' (perl-Test-Time.spec:38).
> FIX: Build-require `findutils' (perl-Test-Time.spec:43).
> FIX: Build-require `perl(strict)' (lib/Test/Time.pm:2).
> FIX: Build-require `perl(warnings)' (lib/Test/Time.pm:3).
FIX: Please add these dependencies.
> TODO: Replace PERL_INSTALL_ROOT with DESTDIR argument in %install section.
Not addressed. Ok.
> TODO: Remove the unnecessary find command deleting empty directories from
> %install section.
Not addresses. Ok.
Please correct all `FIX' items and provide new spec file.
Resolution: Package NOT approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm
https://bugzilla.redhat.com/show_bug.cgi?id=1225229
--- Comment #2 from Raphael Groner ---
Spec URL: https://raphgro.fedorapeople.org/review/locker/light-locker.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/locker/light-locker-1.6.0-2.fc22.src.rpm
rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10218012
epel7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10218073
* Fri Jun 26 2015 Raphael Groner <> - 1.6.0-2
- fix license, enhance build options, add gsettings schema scriplets
(In reply to Rex Dieter from comment #1)
…
> 3. SHOULD drop
> desktop-file-validate %{buildroot}%{_sysconfdir}/xdg/autostart/*.desktop
> no need to validate autostart, only stuff under /usr/share/applications/
Well, I do that intentionally. There's an issue with NotShowIn and a patch
provided, see also the upstream issue.
…
> As a practical matter, it worries my a little that it seems to conditionally
> autostart based on DE used (regardless if lightdm is active or not?). this
> feels wrong to me, but I don't have any suggestions on how to improve that
> offhand.
Not sure what you mean. The DE should provide an on/off switch. What DE could
be problematic in that matter?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236064] Review Request: perl-Encode-JISX0213 - JIS X 0213 encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1236064 Petr Pisar changed: What|Removed |Added Depends On||1236051 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236051 [Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236064] New: Review Request: perl-Encode-JISX0213 - JIS X 0213 encoding
https://bugzilla.redhat.com/show_bug.cgi?id=1236064 Bug ID: 1236064 Summary: Review Request: perl-Encode-JISX0213 - JIS X 0213 encoding Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Encode-JISX0213/perl-Encode-JISX0213.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Encode-JISX0213/perl-Encode-JISX0213-0.03-1.fc23.src.rpm Description: This package provides Perl encoding data for JIS X 0213. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Petr Pisar changed: What|Removed |Added Blocks||1236064 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1236064 [Bug 1236064] Review Request: perl-Encode-JISX0213 - JIS X 0213 encoding -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236053] Review Request: perl-Dist-Metadata - Information about a Perl module distribution
https://bugzilla.redhat.com/show_bug.cgi?id=1236053 Petr Šabata changed: What|Removed |Added Status|NEW |ASSIGNED CC||psab...@redhat.com Assignee|nob...@fedoraproject.org|psab...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236053] New: Review Request: perl-Dist-Metadata - Information about a Perl module distribution
https://bugzilla.redhat.com/show_bug.cgi?id=1236053 Bug ID: 1236053 Summary: Review Request: perl-Dist-Metadata - Information about a Perl module distribution Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: jples...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jplesnik.fedorapeople.org/perl-Dist-Metadata/perl-Dist-Metadata.spec SRPM URL: https://jplesnik.fedorapeople.org/perl-Dist-Metadata/perl-Dist-Metadata-0.926-1.fc23.src.rpm Description: This module provides an easy interface for getting various metadata about a Perl module distribution. Fedora Account System Username: jples...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236051] New: Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme
https://bugzilla.redhat.com/show_bug.cgi?id=1236051 Bug ID: 1236051 Summary: Review Request: perl-Encode-ISO2022 - ISO/IEC 2022 character encoding scheme Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-Encode-ISO2022/perl-Encode-ISO2022.spec SRPM URL: https://ppisar.fedorapeople.org/perl-Encode-ISO2022/perl-Encode-ISO2022-0.04-1.fc23.src.rpm Description: This module provides a character encoding scheme (CES) switching a set of multiple coded character sets (CCS). Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 --- Comment #26 from Fedora Update System --- trojita-0.5-6.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/trojita-0.5-6.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Raphael Groner changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 --- Comment #25 from Fedora Update System --- trojita-0.5-6.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/trojita-0.5-6.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198760] Review Request: mitmproxy - An interactive SSL-capable intercepting HTTP proxy
https://bugzilla.redhat.com/show_bug.cgi?id=1198760 --- Comment #4 from Fabian Affolter --- (In reply to Michal Ambroz from comment #3) > any reason why the source is taken from 3rd party (pypi.python.org) No reason. I will go with the tarball from the upstream website. At the moment from my point of view there is no meed to run with the git source. Anyway, thanks for the input. Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/mitmproxy-0.12.1-2.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 --- Comment #24 from Fedora Update System --- trojita-0.5-6.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/trojita-0.5-6.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235305] Review Request: hitch - Network proxy that terminates TLS/SSL connections
https://bugzilla.redhat.com/show_bug.cgi?id=1235305
--- Comment #5 from Ingvar Hagelund ---
I updated the package again:
* Wed Jun 10 2015 Ingvar Hagelund 1.0.0-0.3.beta3
- Added _hardened_build macro and PIE on el6
http://users.linpro.no/ingvar/varnish/hitch/hitch.spec
http://users.linpro.no/ingvar/varnish/hitch/hitch-1.0.0-0.3.2.beta3.fc22.src.rpm
(In reply to Sören Möller from comment #4)
> - I am unsure about the best name for the manpage. I interprete
> https://fedoraproject.org/wiki/Packaging:Guidelines#Manpages as if it should
> be called "hitch-openssl", but I am far from sure.
I'l let this rest for now.
> - I am unsure how to chekck if "%build honors applicable compiler flags or
> justifies otherwise.", although I think it does as it does what I expected
> in build.log and no obvious changes in the spec-file
This means that the build will honor changes in the build environment, like
changing the CFLAGS and LDFLAGS variables before calling configure/make. It
does.
> - I did not evaluate the proper function of the package (but this is a
> SHOULD not a MUST, so I don't think this is a problem)
To test hitch, for example in front of varnish, in front of apache, do
- Install varnish, httpd and hitch
- Start apache (systemctl start httpd.service)
- Edit the varnish config to point to the local httpd
That is, change the default backend definition in
/etc/varnish/default.vcl , like this:
backend default {
.host = "127.0.0.1";
.port = "80";
}
- Start varnish (systemctl start varnish.service)
- Add an ssl certificate to the hitch config. For a dummy certificate,
the one in the hitch source may be used:
sudo cp ~/rpmbuild/BUILD/hitch-*/tests/certs/default.example.com \
/etc/pki/tls/private/default.example.com.pem
Edit /etc/hitch/hitch.conf. Change the pem-file option to use that cert
pem-file = "/etc/pki/tls/private/default.example.com.pem"
- Start hitch (systemctl start hitch.service)
Point your net browser to https://localhost:8443/ . You should be greeted with
a warning about a non-official certificate. Past that, you will get the apache
frontpage through varnish and hitch.
> - I was not able to run the tests as I get a lot of errors of this form:
> "warning: user ingvar does not exist - using root"
> "warning: group ingvar does not exist - using root"
These messages are not related to the tests. It is just that the user that
generated the source package ("ingvar") does not exist on your machine. This is
perfectly normal, and may safely be ignored.
> But I tried to run it with buildroot, as I didn't want to install it on the
> system, so it might work in that case.
As stated in a previous comment, %check is not enabled by default, as it won't
work on the koji builders, nor on machines that can't reach the Internet. You
can run the test suite without installing the package while building:
rpmbuild --define "runcheck 1" -bb hitch.spec
rpmbuild --define "runcheck 1" --rebuild hitch-1.0.0-0.3.2.beta3.fc22.src.rpm
Ingvar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Raphael Groner changed: What|Removed |Added See Also|https://bugzilla.redhat.com | |/show_bug.cgi?id=1234656| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Raphael Groner changed: What|Removed |Added See Also||https://bugzilla.redhat.com ||/show_bug.cgi?id=1234656 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230209] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1230209 --- Comment #2 from Ralf Corsepius --- Updated package: Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Test-Time.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Test-Time-0.04-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 Raphael Groner changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #23 from Raphael Groner --- New Package SCM Request === Package Name: trojita Short Description: IMAP e-mail client Upstream URL: http://trojita.flaska.net Owners: raphgro group::kde-sig Branches: f21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1208582] Review Request: trojita - IMAP e-mail client
https://bugzilla.redhat.com/show_bug.cgi?id=1208582 --- Comment #22 from Raphael Groner --- SPEC https://raphgro.fedorapeople.org/review/qt/trojita/trojita.spec SRPM https://raphgro.fedorapeople.org/review/qt/trojita/trojita-0.5-6.fc22.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10217181 epel7 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10217135 * Fri Jun 26 2015 Raphael Groner <> - 0.5-6 - optional BR: at EPEL -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 --- Comment #12 from Zuzana Svetlikova --- New Package SCM Request === Package Name: nodejs-columnify Short Description: Render data in text columns, supports in-column text-wrap Upstream URL: https://github.com/timoxley/columnify Owners: zvetlik Branches: f21 f22 el6 epel7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1203659] Review Request: nodejs-columnify - Render data in text columns, supports in-column text-wrap.
https://bugzilla.redhat.com/show_bug.cgi?id=1203659 Zuzana Svetlikova changed: What|Removed |Added Flags||fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1198498] Review Request: libwebsockets - A lightweight C library for Websockets
https://bugzilla.redhat.com/show_bug.cgi?id=1198498 --- Comment #6 from Daniel O'Connor --- From the trac ticket: Status changed from meeting to closed Resolution set to accepted We discussed this at this weeks meeting (http://meetbot.fedoraproject.org/fedora-meeting-1/2015-06-25/fpc.2015-06-25-16.01.txt): -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235950] Review Request: openrdf-sesame - Java framework for processing and handling RDF data
https://bugzilla.redhat.com/show_bug.cgi?id=1235950 gil cattaneo changed: What|Removed |Added Depends On||1106256 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1106256 [Bug 1106256] mysql-connector-java: FTBFS in rawhide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235950] Review Request: openrdf-sesame - Java framework for processing and handling RDF data
https://bugzilla.redhat.com/show_bug.cgi?id=1235950 gil cattaneo changed: What|Removed |Added Blocks||652183 (FE-JAVASIG) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235950] New: Review Request: openrdf-sesame - Java framework for processing and handling RDF data
https://bugzilla.redhat.com/show_bug.cgi?id=1235950 Bug ID: 1235950 Summary: Review Request: openrdf-sesame - Java framework for processing and handling RDF data Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/openrdf-sesame.spec SRPM URL: https://gil.fedorapeople.org/openrdf-sesame-2.7.16-1.fc20.src.rpm Description: Sesame is an extensible Java framework for storing, querying and inferencing for RDF. It can be deployed as a web server or used as a Java library. Features include several query languages (SeRQL and SPARQL), inferencing support, and RAM or disk storage. Additionally, the central APIs of Sesame are storage-independent and are supported by many third-party RDF database vendors. Fedora Account System Username: gil -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235950] Review Request: openrdf-sesame - Java framework for processing and handling RDF data
https://bugzilla.redhat.com/show_bug.cgi?id=1235950 gil cattaneo changed: What|Removed |Added Depends On||1235949 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1235949 [Bug 1235949] Review Request: urlrewritefilter - A Java Web Filter with functionality like Apache's mod_rewrite -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235949] Review Request: urlrewritefilter - A Java Web Filter with functionality like Apache's mod_rewrite
https://bugzilla.redhat.com/show_bug.cgi?id=1235949 gil cattaneo changed: What|Removed |Added Blocks||1235950 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1235950 [Bug 1235950] Review Request: openrdf-sesame - Java framework for processing and handling RDF data -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235949] New: Review Request: urlrewritefilter - A Java Web Filter with functionality like Apache's mod_rewrite
https://bugzilla.redhat.com/show_bug.cgi?id=1235949 Bug ID: 1235949 Summary: Review Request: urlrewritefilter - A Java Web Filter with functionality like Apache's mod_rewrite Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: punto...@libero.it QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://gil.fedorapeople.org/urlrewritefilter.spec SRPM URL: https://gil.fedorapeople.org/urlrewritefilter-4.0.4-1.fc20.src.rpm Description: A Java Web Filter for any compliant web application servers (such as Tomcat, JBoss, Jetty or Resin), which allows you to rewrite URLs before they get to your code. It is a very powerful tool just like Apache's mod_rewrite. Fedora Account System Username: gil Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=10216510 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
