[Bug 1241922] Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
https://bugzilla.redhat.com/show_bug.cgi?id=1241922 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #6 from Jitka Plesnikova --- Package Change Request == Package Name: perl-Test-LWP-UserAgent New Branches: f23 Owners: jplesnik ppisar psabata InitialCC: perl-sig -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228091] Review Request: php-zetacomponents-console-tools - Zeta ConsoleTools Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228091 Remi Collet changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #9 from Remi Collet --- Can you please check, https://admin.fedoraproject.org/pkgdb/package/php-zetacomponents-console-tools/ => OK. http://pkgs.fedoraproject.org/cgit/php-zetacomponents-console-tools.git => MISSING $ fedpkg clone php-zetacomponents-console-tools Clonage dans 'php-zetacomponents-console-tools'... FATAL: R any php-zetacomponents-console-tools remi DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://r...@pkgs.fedoraproject.org/php-zetacomponents-console-tools', '--origin', 'origin']' returned non-zero exit status 128 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 Remi Collet changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #10 from Remi Collet --- Can you please check, https://admin.fedoraproject.org/pkgdb/package/php-zetacomponents-graph/ => OK http://pkgs.fedoraproject.org/cgit/php-zetacomponents-graph.git => MISSING $ fedpkg clone php-zetacomponents-graph Clonage dans 'php-zetacomponents-graph'... FATAL: R any php-zetacomponents-graph remi DENIED by fallthru (or you mis-spelled the reponame) fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exists. Could not execute clone: Command '['git', 'clone', 'ssh://r...@pkgs.fedoraproject.org/php-zetacomponents-graph', '--origin', 'origin']' returned non-zero exit status 128 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1241292 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1241292 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228091] Review Request: php-zetacomponents-console-tools - Zeta ConsoleTools Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228091 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228091] Review Request: php-zetacomponents-console-tools - Zeta ConsoleTools Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228091 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
https://bugzilla.redhat.com/show_bug.cgi?id=516364 --- Comment #27 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
https://bugzilla.redhat.com/show_bug.cgi?id=516364 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241493] Review Request: libgrss - Library for easy management of RSS/Atom/Pie feeds
https://bugzilla.redhat.com/show_bug.cgi?id=1241493 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- libgrss-0.6-2.fc22 has been pushed to the Fedora 22 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221540] Review Request: nodejs-write-file-atomic - Write files in an atomic fashion w/configurable ownership
https://bugzilla.redhat.com/show_bug.cgi?id=1221540 Fedora Update System changed: What|Removed |Added Fixed In Version|nodejs-write-file-atomic-1. |nodejs-write-file-atomic-1. |1.2-2.fc22 |1.2-2.fc21 --- Comment #17 from Fedora Update System --- nodejs-write-file-atomic-1.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1221540] Review Request: nodejs-write-file-atomic - Write files in an atomic fashion w/configurable ownership
https://bugzilla.redhat.com/show_bug.cgi?id=1221540 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Fixed In Version||nodejs-write-file-atomic-1. ||1.2-2.fc22 Resolution|--- |ERRATA Last Closed||2015-07-15 22:33:31 --- Comment #16 from Fedora Update System --- nodejs-write-file-atomic-1.1.2-2.fc22 has been pushed to the Fedora 22 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1156492] Review Request: golang-github-cpuguy83-go-md2man - Process markdown into manpages
https://bugzilla.redhat.com/show_bug.cgi?id=1156492 Fedora Update System changed: What|Removed |Added Fixed In Version|golang-github-cpuguy83-go-m |golang-github-cpuguy83-go-m |d2man-1-4.el6 |d2man-1-4.fc21 --- Comment #22 from Fedora Update System --- golang-github-cpuguy83-go-md2man-1-4.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef
https://bugzilla.redhat.com/show_bug.cgi?id=1242056 --- Comment #7 from Athos Ribeiro --- Just attaching a link for the new koji build, sorry for all the spamming. http://koji.fedoraproject.org/koji/taskinfo?taskID=10373324 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228089] Review Request: php-zetacomponents-base - Zeta Base Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228089 Fedora Update System changed: What|Removed |Added Fixed In Version|php-zetacomponents-base-1.9 |php-zetacomponents-base-1.9 |-2.el6 |-2.el7 --- Comment #15 from Fedora Update System --- php-zetacomponents-base-1.9-2.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #8 from Fedora Update System --- nghttp2-1.0.5-1.el7 has been pushed to the Fedora EPEL 7 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 858062] Review Request: mingw-qt5-qtactiveqt - Qt5 for Windows - QtActiveQt component
https://bugzilla.redhat.com/show_bug.cgi?id=858062 Fedora Update System changed: What|Removed |Added Fixed In Version|mingw-qt5-qtactiveqt-5.4.2- |mingw-qt5-qtactiveqt-5.4.2- |1.fc22 |1.el7 --- Comment #22 from Fedora Update System --- mingw-qt5-qtactiveqt-5.4.2-1.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228089] Review Request: php-zetacomponents-base - Zeta Base Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228089 Fedora Update System changed: What|Removed |Added Fixed In Version|php-zetacomponents-base-1.9 |php-zetacomponents-base-1.9 |-2.fc22 |-2.el6 --- Comment #14 from Fedora Update System --- php-zetacomponents-base-1.9-2.el6 has been pushed to the Fedora EPEL 6 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef
https://bugzilla.redhat.com/show_bug.cgi?id=1242056 --- Comment #6 from Athos Ribeiro --- > I noticed another issue, this time in fedora-review ruby plugin, > that has a regex for '^.*gem\s+install', that matches the > "gem install" text inside a comment, so, this, along with comments > about behaviour of %gem_install could be a long time TODO, as you > become more involved with Fedora ruby packages :) I will take a look into this one, Thank you! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241412] Review Request: python-ldap3 - Strictly RFC 4511 conforming LDAP V3 pure Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1241412 --- Comment #7 from Jason Tibbitts --- My apologies; the %check section I included is completely wrong. The tests can be run using nosetest-2.7 and nosetest-3.4, but most of them will fail because they must connect to an ldap server. There are probably some tests in there which we could run but it would be a bit of work to patch out the ones which we can't. Also, I did update pyasn1 but got yelled at for it. Oh, well; it will be in rawhide and F23 soon unless the maintainer decides to revert my trivial update and untag the package. No idea if he'll update the release branches, either. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef
https://bugzilla.redhat.com/show_bug.cgi?id=1242056 --- Comment #5 from Athos Ribeiro --- Hi Paulo, Thank you for your Review! > But before sponsoring you, I would like to see at > least one informal package review from you. Here is my first review attempt: https://bugzilla.redhat.com/show_bug.cgi?id=1243507 I also replied in this request where sources were not available, I was not sure what to do with the ticket status though: https://bugzilla.redhat.com/show_bug.cgi?id=1229913 > Please fix: > [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the > beginning of %install. > Note: rm -rf %{buildroot} present but not required > The line > find %{buildroot}%{gem_instdir}/bin -type f | xargs chmod a+x > does not appear to be required as well, for this specific package. Done and bumped the release. (shoud I bump it even if it wasn't uploaded to fedora cgit? i.e. during the review process?) New files are at: Spec URL: https://ribeiro.fedorapeople.org/rubygem-chake.spec SRPM URL: https://ribeiro.fedorapeople.org/rubygem-chake-0.7-2.fc22.src.rpm > Please comment: > [?]: Development files must be in a -devel package >Can you guarantee all files installed are required for runtime? Or > some are only need for development? Yes. We could question the chake.spec.erb file (which is a template to generate a spec file) presence in there, but it is called by the Rakefile which is installed by the -doc package, which means that if we move that to a devel package the -doc package would require the -devel one. It is in the gem in order to generate rpm packages from it. For the next version I will submit a patch to change this rpm generation (I am already having this conversation with upstream). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231427] Review Request: COPASI - Biochemical network simulator
https://bugzilla.redhat.com/show_bug.cgi?id=1231427 --- Comment #13 from Dave Johansen --- Issues: === [!]: Development (unversioned) .so files in -devel subpackage, if present. Several .so files in %_libdir. Are these ok? [!]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. license.txt does not appear to be Artistic 2.0 and states "You cannot redistribute this test version." [!]: License field in the package spec file matches the actual license. Several licenses found by licensecheck. Here's the list: BSD (2 clause) -- COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/randomGenerator/Cmt19937.cpp COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/randomGenerator/Cmt19937.h GPL (v2 or later) - COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/model/CChemEqParser_yacc.cpp COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/model/CChemEqParser_yacc.hpp GPL (v2 or later) GPL (v2 or later) (with incorrect FSF address) COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/MIRIAM/WebServicesIssues/stdsoap2.cpp COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/MIRIAM/WebServicesIssues/stdsoap2.h GPL (v3 or later) - COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/function/CEvaluationParser_yacc.cpp COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/function/CEvaluationParser_yacc.hpp LGPL COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/sbml/IdList.h MIT/X11 (BSD like) -- COPASI-192df43f09810b4416c7c59bec08ed63a2c22186/copasi/GL/glext.h [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/perl5/vendor_perl/auto, /usr/lib/perl5, /usr/lib/perl5/vendor_perl, /usr/lib/mono, /usr/share/copasi, /usr/share/java [!]: Useful -debuginfo package or justification otherwise. Missing -debuginfo. [!]: Fully versioned dependency in subpackages if applicable. I'm not sure which of these are appropriate, but: Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in COPASI- gui , COPASI-data , python-COPASI , python3-COPASI , java-COPASI , perl-COPASI , R-COPASI , COPASI-sharp , COPASI-doc [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. Needs to be fixed Other Issues: === [!]: examples are in -data but would it make sense for them to be somewhere else? [!]: I would recommend making the .desktop and .appdata.xml sources to simplify the .spec file. = MUST items = C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at t
[Bug 1231459] Review Request: libosimum - Fast and flexible C++ library for working with OpenStreetMap data
https://bugzilla.redhat.com/show_bug.cgi?id=1231459 Christopher Meng changed: What|Removed |Added Status|NEW |ASSIGNED CC||i...@cicku.me --- Comment #6 from Christopher Meng --- You should use %cmake. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 Athos Ribeiro changed: What|Removed |Added CC||athoscribe...@gmail.com --- Comment #1 from Athos Ribeiro --- This is an informal review since, I have no rights of performing official reviews and it is also my first package review attempt, I hope it helps: Package Review == Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated = MUST items = Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/packager/package_reviews/1243507-perl- Algorithm-LUHN/licensecheck.txt [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/perl5/vendor_perl/Algorithm(perl-Algorithm-Diff) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [-]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Perl: [x]: Package contains the mandatory BuildRequires and Requires:. [x]: CPAN urls should be non-versioned. = SHOULD items = Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags shou
[Bug 1242011] Review Request: python-UcsSdk - Python SDK for Cisco UCS Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1242011 --- Comment #7 from Brian Demers --- Informal reviews for other projects: 1243550, 1234664 Spec URL: https://raw.githubusercontent.com/CiscoSystems/UcsSdk-spec/d20dd9157aa9d26ecd48dc550c6388ad005125d9/python-UcsSdk.spec SRPM URL: https://github.com/CiscoSystems/UcsSdk-spec/releases/download/new-spec-2/python-UcsSdk-0.8.2.2-0.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1234664] Review Request: jchart2d - Real-time charting library for Java
https://bugzilla.redhat.com/show_bug.cgi?id=1234664 Brian Demers changed: What|Removed |Added CC||brdem...@cisco.com --- Comment #1 from Brian Demers --- Informal review: https://fedorahosted.org/released/javapackages/doc/ This section, isn't guaranteed to work: ``` # overwrite bundled libs with symlinks to system libraries ln -sfn /usr/share/java/xmlgraphics-commons.jar jchart2d/ext/xmlgraphics-commons-1.3.1.jar ln -sfn /usr/share/java/jide-oss.jar jchart2d/ext/jide-oss-2.9.7.jar ln -sfn /usr/share/java/proguard/proguard.jar jchart2d/ext/build/proguard-4.5.1.jar ln -sfn /usr/share/java/junit.jar jchart2d/ext/build/junit-4.8.1.jar ``` Something should probably be done in %build and these libs removed in %prep http://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires I understand the need to override the jars, as that is a fedora requirement, but your BuildDepends could be any version, which could cause problems depending on which version is installed. Run fedora-review locally to see other errors: `dnf install -y fedora-review fedora-review-plugin-java` `fedora-review -b 1234664` You will see errors and warnings such as: Rpmlint --- Checking: jchart2d-3.2.2-1.fc23.noarch.rpm jchart2d-javadoc-3.2.2-1.fc23.noarch.rpm jchart2d-3.2.2-1.fc23.src.rpm jchart2d.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) sh: /usr/bin/python: No such file or directory # i'm not sure why this python call is here ? jchart2d.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243550] Review Request: openstack-aodh - OpenStack Telemetry Alarming
https://bugzilla.redhat.com/show_bug.cgi?id=1243550 Brian Demers changed: What|Removed |Added CC||brdem...@cisco.com --- Comment #1 from Brian Demers --- Informal Review: Guessing this should be added to RDO: https://openstack.redhat.com/packaging/rdo-packaging.html#_how_to_add_a_new_package_to_rdo_master_packaging Take a look at: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag for versioning and dist tag See https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL to set Source0 to a URL (or a comment) Requires and BuildRequires are fragmented, which makes the spec harder to read. Not sure where the 'ceilometer' group is created, but you might want to make a note about, I'm assuming it gets created by another openstack rpm, but i'm not sure. https://fedoraproject.org/wiki/Packaging:UsersAndGroups %license is missing Download and run 'fedora-review -b 1243550' you will see other errors and messages that will need to be cleaned up. https://fedoraproject.org/wiki/Package_Review_Process -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236488] Review Request: indistarter - GUI for Indi Server
https://bugzilla.redhat.com/show_bug.cgi?id=1236488 --- Comment #4 from Sören Möller --- After running fedora-review one of the first problems encountered was the following warning: [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr, /usr/bin, /usr/share/pixmaps, /usr/share/applications, /usr/share, /usr/share/appdata, /usr/share/doc, /usr/share/icons I removed this warning by changing %files %doc %{_docdir}/indistarter %{_bindir}/* %{_datadir}/applications/*.desktop %{_datadir}/appdata/*.appdata.xml %{_datadir}/icons/* %{_datadir}/pixmaps/* from your .spec file to %files %doc %{_docdir}/indistarter %{_bindir}/%{name} %{_datarootdir}/applications/%{name}.desktop %{_datarootdir}/appdata/%{name}.appdata.xml %{_datarootdir}/icons/hicolor/48x48/apps/%{name}.png %{_datarootdir}/pixmaps/%{name}.png which resolves this warning. I think this change or something similar is necessary, as your .spec file seems to indicate that the package wants to own all of (for instance) %{_bindir} and not only the file it provides into the pre-existing directory. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 --- Comment #7 from Fedora Update System --- nghttp2-1.0.5-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nghttp2-1.0.5-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 --- Comment #6 from Fedora Update System --- nghttp2-1.0.5-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/nghttp2-1.0.5-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1229913] Review Request: rubygem-ruby-notes - Console based system that let you make notes about important things
https://bugzilla.redhat.com/show_bug.cgi?id=1229913 Athos Ribeiro changed: What|Removed |Added CC||athoscribe...@gmail.com --- Comment #1 from Athos Ribeiro --- Hello, your spec and srpm files are not available, which blocks this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236488] Review Request: indistarter - GUI for Indi Server
https://bugzilla.redhat.com/show_bug.cgi?id=1236488 --- Comment #3 from Sören Möller --- Thanks for the explanation, I now have downloaded it. My first build with fedora-review failed, as appstream-util was not found, but adding BuildRequires:libappstream-glib to the .spec-file solved that problem, and I was able to build, so you might want to add that to the .spec too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1239273] Review Request: golang-github-BurntSushi-toml-test - Language agnostic test suite for TOML
https://bugzilla.redhat.com/show_bug.cgi?id=1239273 --- Comment #12 from Julien Enselme --- > %{gopath} macro is provided since golang-1.2.1-3 so BuildRequires must have: > BuildRequires: golang >= 1.2.1-3 > for both main package and devel subpackage. Noted. > Are tests in tests directory used by toml-test binary only? They are. Devel package disabled. SRPM: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/golang-github-BurntSushi-toml-test-0.2.0-0.5.git85f50d0.fc22.src.rpm SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/golang-github-BurntSushi-toml-test.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235422] Review Request: java-hll - Java library for the HyperLogLog algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1235422 --- Comment #6 from Fedora Update System --- java-hll-1.6.0-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/java-hll-1.6.0-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1235422] Review Request: java-hll - Java library for the HyperLogLog algorithm
https://bugzilla.redhat.com/show_bug.cgi?id=1235422 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1230867 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230867] Review Request: felix-scr - Apache Felix Declarative Services Runtime
https://bugzilla.redhat.com/show_bug.cgi?id=1230867 --- Comment #21 from Fedora Update System --- felix-scr-1.6.2-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/felix-scr-1.6.2-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236328] Review Request: python-pandocfilters - Python module for writing pandoc filters
https://bugzilla.redhat.com/show_bug.cgi?id=1236328 --- Comment #8 from Fedora Update System --- python-pandocfilters-1.2.4-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-pandocfilters-1.2.4-1.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231458] Review Request: osmpbf - C library to read and write OpenStreetMap PBF files
https://bugzilla.redhat.com/show_bug.cgi?id=1231458 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231458] Review Request: osmpbf - C library to read and write OpenStreetMap PBF files
https://bugzilla.redhat.com/show_bug.cgi?id=1231458 --- Comment #13 from Fedora Update System --- osmpbf-1.3.3-5.20150712git17fd0cc.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/osmpbf-1.3.3-5.20150712git17fd0cc.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236328] Review Request: python-pandocfilters - Python module for writing pandoc filters
https://bugzilla.redhat.com/show_bug.cgi?id=1236328 --- Comment #7 from Fedora Update System --- python-pandocfilters-1.2.4-1.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-pandocfilters-1.2.4-1.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236328] Review Request: python-pandocfilters - Python module for writing pandoc filters
https://bugzilla.redhat.com/show_bug.cgi?id=1236328 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1231459] Review Request: libosimum - Fast and flexible C++ library for working with OpenStreetMap data
https://bugzilla.redhat.com/show_bug.cgi?id=1231459 --- Comment #5 from Tom Hughes --- New version: Spec URL: http://download.compton.nu/tmp/libosmium.spec SRPM URL: http://download.compton.nu/tmp/libosmium-2.2.0-2.fc22.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10370460 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #17 from Fedora Update System --- python-importmagic-0.1.3-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/python-importmagic-0.1.3-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223464] Review Request: nuget - Package manager for NuGet repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1223464 Claudio Rodrigo Pereyra DIaz changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-07-15 16:05:14 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #16 from Fedora Update System --- python-importmagic-0.1.3-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/python-importmagic-0.1.3-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
https://bugzilla.redhat.com/show_bug.cgi?id=516364 Itamar Reis Peixoto changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #26 from Itamar Reis Peixoto --- Package Change Request == Package Name: xrdp New Branches: EL-7 Owners: itamarjp -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230949] Review Request: hid4java - A cross-platform Java Native Access (JNA) wrapper for the signal11/hidapi library
https://bugzilla.redhat.com/show_bug.cgi?id=1230949 --- Comment #10 from Jonny Heggheim --- Created a ticket upstream for the license header: https://github.com/gary-rowe/hid4java/issues/25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 516364] Review Request: xrdp - Open source remote desktop protocol (RDP) server
https://bugzilla.redhat.com/show_bug.cgi?id=516364 Itamar Reis Peixoto changed: What|Removed |Added CC||stref...@gmail.com --- Comment #25 from Itamar Reis Peixoto --- *** Bug 1242164 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236328] Review Request: python-pandocfilters - Python module for writing pandoc filters
https://bugzilla.redhat.com/show_bug.cgi?id=1236328 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ --- Comment #6 from Zbigniew Jędrzejewski-Szmek --- OK, it works now. Dunno, in the past I don't recall such a long delay. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242095] Review Request: python-ipython_genutils - IPython vestigial utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1242095 Orion Poplawski changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE Last Closed||2015-07-15 15:24:31 --- Comment #6 from Orion Poplawski --- Checked in and built. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242098] Review Request: python-traitlets - A lightweight derivative of Enthought Traits for configuring Python objects
https://bugzilla.redhat.com/show_bug.cgi?id=1242098 Bug 1242098 depends on bug 1242095, which changed state. Bug 1242095 Summary: Review Request: python-ipython_genutils - IPython vestigial utilities https://bugzilla.redhat.com/show_bug.cgi?id=1242095 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NEXTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1098965] Review Request: capstone - Multi-platform, multi-architecture disassembly framework.
https://bugzilla.redhat.com/show_bug.cgi?id=1098965 Stefan Cornelius changed: What|Removed |Added Attachment|0 |1 #1024818 is|| obsolete|| --- Comment #14 from Stefan Cornelius --- Created attachment 1052423 --> https://bugzilla.redhat.com/attachment.cgi?id=1052423&action=edit Updated spec file for 3.0.4 Version 3.0.4 includes security fixes. I ran some tests and scratch builds and found no issues so far. http://koji.fedoraproject.org/koji/taskinfo?taskID=10369873 http://koji.fedoraproject.org/koji/taskinfo?taskID=10369903 http://koji.fedoraproject.org/koji/taskinfo?taskID=10369908 http://koji.fedoraproject.org/koji/taskinfo?taskID=10369912 My plan is to get this on COPR as soon as possible, but there is one little problem with the fedorapeople.org sign-in (which I need to be able to host the src.rpm). Once that's resolved, I'll hopefully be able to provide a COPR repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1241292 Shawn Iwinski changed: What|Removed |Added Flags||fedora-cvs? --- Comment #6 from Shawn Iwinski --- THANKS for the review! New Package SCM Request === Package Name: php-zendframework-zend-diactoros Short Description: PSR HTTP Message implementations Upstream URL: https://github.com/zendframework/zend-diactoros Owners: siwinski Branches: f21 f22 f23 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1236328] Review Request: python-pandocfilters - Python module for writing pandoc filters
https://bugzilla.redhat.com/show_bug.cgi?id=1236328 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Flags|fedora-cvs+ |fedora-cvs? --- Comment #5 from Zbigniew Jędrzejewski-Szmek --- Hm, this doesn't seem to have worked. Can't clone the repo, and it is not visible on http://pkgs.fedoraproject.org/cgit/python-pandocfilters.git/ . -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243550] New: Review Request: openstack-aodh - OpenStack Telemetry Alarming
https://bugzilla.redhat.com/show_bug.cgi?id=1243550 Bug ID: 1243550 Summary: Review Request: openstack-aodh - OpenStack Telemetry Alarming Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: pkila...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh.spec SRPM URL: https://pkilambi.fedorapeople.org/openstack-aodh/openstack-aodh-0.0.1.dev3940-1.fc22.src.rpm Description: OpenStack Telemetry Alarming -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193878] Review Request: qmasterpassword - Stateless Master Password Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1193878 Michael Schwendt (Fedora Packager Sponsors Group) changed: What|Removed |Added Blocks|177841 (FE-NEEDSPONSOR) | Flags|fedora-review? |fedora-review+ --- Comment #14 from Michael Schwendt (Fedora Packager Sponsors Group) --- Okay. Just one minor nitpick: $ rpmlint qmasterpassword-1.1-2.fc21.src.rpm qmasterpassword.src:73: W: macro-in-%changelog %check 1 packages and 0 specfiles checked; 0 errors, 1 warnings. In the %changelog or in other comments anywhere in the spec file, some macros expand and cause side-effects, which may even influence the build in bad ways. Imagine you added a changelog comment mentioning the "%configure" macro. In the built packages you would get to see the exanded macro, i.e. a big blog as can be seen in "rpm -E %configure". Hence in comments it is better to escape macros with a double '%%'. > -BuildRequires: qt5-qtbase-devel >= 5.2.0 > +BuildRequires: qt5-qtbase-devel Note that my earlier comment referred to the "Requires" tag only, not the BuildRequires. It's okay to drop the version here, too, but minimum versions on BuildRequires can be helpful actually when trying to build a src.rpm for a completely unexpected build target. For example, if Fedora EPEL 6 did not contain Qt 5.4.x already, the src.rpm would fail to build. Though, in many packages, minimum version requirements are out-of-date, and configure scripts or other version checks are applied by the used build framework. > %changelog There is nothing about this in the guidelines, https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs and it is no blocker criterion, but "rpm --query --changelog …" output adds an empty line between individual changelog entries for increase readability. So, it's widely accepted practice to do that also in the spec file and increase readability. Decide yourself whether you like that, too. * Package builds fine on Rawhide and F21. * Basic installation and runtime testing: F21 with GNOME Shell Package APPROVED. Please fix the unescaped macro in %changelog when/after importing into dist git. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174974] Review Request: python-mox3 - Mock object framework for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1174974 Alan Pevec changed: What|Removed |Added Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241412] Review Request: python-ldap3 - Strictly RFC 4511 conforming LDAP V3 pure Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1241412 --- Comment #6 from Jason Tibbitts --- Created attachment 1052408 --> https://bugzilla.redhat.com/attachment.cgi?id=1052408&action=edit Patch to try and fix build issues My editor may have stripped some whitespace, too. Sorry about that. I didn't bump the release or add a changelog, so you'll need to do that before posting another package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1174974] Review Request: python-mox3 - Mock object framework for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1174974 Alan Pevec changed: What|Removed |Added Status|NEW |ASSIGNED CC||ape...@gmail.com --- Comment #9 from Alan Pevec --- Getting back to this, mox3 now has a proper upstream, it was adopted by Oslo project: https://review.openstack.org/190330 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241412] Review Request: python-ldap3 - Strictly RFC 4511 conforming LDAP V3 pure Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1241412 --- Comment #5 from Jason Tibbitts --- I'll attach a patch which I used to get this to sort of build and run checks. Or it would actually do all of that, except that the module requires pyasn1 >= 0.1.8 and Fedora has only 0.1.7. I'll see about pushing an update for that today, but I'm still not sure how you were able to build and test this package at all. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1241292 Remi Collet changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from Remi Collet --- [x]: License field in the package spec file matches the actual license. [x]: Rpmlint is run on all installed packages. Blocker fixed. === APPROVED === -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 --- Comment #8 from Remi Collet --- New Package SCM Request === Package Name: php-zetacomponents-graph Short Description: Zeta Graph Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 f23 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228091] Review Request: php-zetacomponents-console-tools - Zeta ConsoleTools Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228091 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Remi Collet --- Thanks for the review! New Package SCM Request === Package Name: php-zetacomponents-console-tools Short Description: Zeta ConsoleTools Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 f23 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1228090] Review Request: php-zetacomponents-graph - Zeta Graph Component
https://bugzilla.redhat.com/show_bug.cgi?id=1228090 Remi Collet changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Remi Collet --- Thanks for the review! New Package SCM Request === Package Name: php-zetacomponents-graph Short Description: Zeta Graph Component Upstream URL: http://zetacomponents.org/ Owners: remi Branches: f21 f22 el6 epel7 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241412] Review Request: python-ldap3 - Strictly RFC 4511 conforming LDAP V3 pure Python client
https://bugzilla.redhat.com/show_bug.cgi?id=1241412 --- Comment #4 from Jason Tibbitts --- I really need a python3 ldap library and so pulled this, but unfortunately it doesn't build due to a bad patch. Actually it doesn't even prep. How did you get your package to compile? + /usr/bin/patch -p1 --fuzz=0 can't find file to patch at input line 5 Perhaps you used the wrong -p or --strip option? The text leading up to this was: -- |diff --git a/docs/manual/source/ldap3.utils.rst b/docs/manual/source/ldap3.utils.rst |index c29271f..29ef33a 100644 |--- a/docs/manual/source/ldap3.utils.rst |+++ b/docs/manual/source/ldap3.utils.rst -- File to patch: Skip this patch? [y] Skipping patch. 1 out of 1 hunk ignored The next patch would delete the file docs/manual/source/ldap3.utils.tls_backport.rst, which does not exist! Assume -R? [n] Apply anyway? [n] Skipping patch. 1 out of 1 hunk ignored patching file ldap3/core/tls.py patching file ldap3/utils/tls_backport.py RPM build errors: error: Bad exit status from /var/tmp/rpm-tmp.0IUyQh (%prep) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222926] Review Request: nunit - unit-testing framework for .Net/mono
https://bugzilla.redhat.com/show_bug.cgi?id=1222926 --- Comment #21 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223464] Review Request: nuget - Package manager for NuGet repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1223464 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1223464] Review Request: nuget - Package manager for NuGet repositories
https://bugzilla.redhat.com/show_bug.cgi?id=1223464 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1222926] Review Request: nunit - unit-testing framework for .Net/mono
https://bugzilla.redhat.com/show_bug.cgi?id=1222926 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241292] Review Request: php-zendframework-zend-diactoros - PSR HTTP Message implementations
https://bugzilla.redhat.com/show_bug.cgi?id=1241292 --- Comment #4 from Shawn Iwinski --- Updated to 1.1.2 and addressed review comments. Changes: https://github.com/siwinski/rpms/commit/e8209809d0f42f8ef426271aefb4759180ec2008 Spec URL: https://raw.githubusercontent.com/siwinski/rpms/e8209809d0f42f8ef426271aefb4759180ec2008/php-zendframework-zend-diactoros/php-zendframework-zend-diactoros.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-zendframework-zend-diactoros-1.1.2-1.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242663] Review Request: perl-Hash-Layout - Hashes with predefined levels, composite keys and default values
https://bugzilla.redhat.com/show_bug.cgi?id=1242663 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242663] Review Request: perl-Hash-Layout - Hashes with predefined levels, composite keys and default values
https://bugzilla.redhat.com/show_bug.cgi?id=1242663 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242328] Review Request: takari-tycho-support - Takari Tycho Base
https://bugzilla.redhat.com/show_bug.cgi?id=1242328 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242328] Review Request: takari-tycho-support - Takari Tycho Base
https://bugzilla.redhat.com/show_bug.cgi?id=1242328 --- Comment #7 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242095] Review Request: python-ipython_genutils - IPython vestigial utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1242095 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242095] Review Request: python-ipython_genutils - IPython vestigial utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1242095 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241922] Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
https://bugzilla.redhat.com/show_bug.cgi?id=1241922 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241944] Review Request: python-importmagic - Python library to auto-magically add, remove and manage imports
https://bugzilla.redhat.com/show_bug.cgi?id=1241944 --- Comment #15 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241922] Review Request: perl-Test-LWP-UserAgent - LWP::UserAgent suitable for simulating and testing network calls
https://bugzilla.redhat.com/show_bug.cgi?id=1241922 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241419] Review Request: nodejs-native-or-bluebird - Use either the native Promise or Bluebird
https://bugzilla.redhat.com/show_bug.cgi?id=1241419 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241419] Review Request: nodejs-native-or-bluebird - Use either the native Promise or Bluebird
https://bugzilla.redhat.com/show_bug.cgi?id=1241419 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1212318] Review Request: golang-github-hashicorp-serf- Service orchestration and management tool http://www.serfdom.io
https://bugzilla.redhat.com/show_bug.cgi?id=1212318 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241156] Review Request: go-srpm-macros - RPM macros for building Golang packages for various architectures
https://bugzilla.redhat.com/show_bug.cgi?id=1241156 --- Comment #6 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1241156] Review Request: go-srpm-macros - RPM macros for building Golang packages for various architectures
https://bugzilla.redhat.com/show_bug.cgi?id=1241156 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1240376] Review Request: php-guzzlehttp-psr7 - PSR-7 message implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1240376 --- Comment #9 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1240376] Review Request: php-guzzlehttp-psr7 - PSR-7 message implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1240376 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1240375] Review Request: php-guzzlehttp-promises - Guzzle promises library
https://bugzilla.redhat.com/show_bug.cgi?id=1240375 --- Comment #8 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1240375] Review Request: php-guzzlehttp-promises - Guzzle promises library
https://bugzilla.redhat.com/show_bug.cgi?id=1240375 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1239148] Review Request: thefuck - App that corrects your previous console command
https://bugzilla.redhat.com/show_bug.cgi?id=1239148 --- Comment #11 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1239148] Review Request: thefuck - App that corrects your previous console command
https://bugzilla.redhat.com/show_bug.cgi?id=1239148 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237247] Review Request: nghttp2 - library implementing the HTTP/2 protocol
https://bugzilla.redhat.com/show_bug.cgi?id=1237247 --- Comment #5 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237042] Review Request: nodejs-validate-npm-package-name - Give me a string and I'll tell you if it's a valid npm package name
https://bugzilla.redhat.com/show_bug.cgi?id=1237042 --- Comment #3 from Jon Ciesla --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1237042] Review Request: nodejs-validate-npm-package-name - Give me a string and I'll tell you if it's a valid npm package name
https://bugzilla.redhat.com/show_bug.cgi?id=1237042 Jon Ciesla changed: What|Removed |Added Flags|fedora-cvs? |fedora-cvs+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review