[Bug 1244817] Review Request: python-xvfbwrapper - run headless display inside X virtual framebuffer (Xvfb)

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244817

Matthias Runge  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Matthias Runge  ---
Thank you for the review!

New Package SCM Request
===
Package Name: python-xvfbwrapper
Short Description: run headless display inside X virtual framebuffer (Xvfb)
Upstream URL: https://github.com/cgoldberg/xvfbwrapper
Owners: mrunge
Branches: f22 f23 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #24 from Michel Alexandre Salim  ---
I think you should rename kernprof to kernprof-%{python2_version} (or
kernprof-%{python3_version} for the Python 3 build) instead of symlinking.

You might then symlink back the versioned binary to kernprof, but this would
cause problem if both packages are installed.

Probably either pick a default (either Python 2 or Python 3 gets the symlink,
probably depending on which version of Fedora -- F23 aims to have Python 3 as
default), or better, use the alternatives system.

https://fedoraproject.org/wiki/Packaging:Alternatives

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270

Daniel Kopeček  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||dkope...@redhat.com
   Assignee|nob...@fedoraproject.org|dkope...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1182358] New package request: clufter - Tool for transforming/analyzing cluster configuration formats

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1182358

errata-xmlrpc  changed:

   What|Removed |Added

 Status|RELEASE_PENDING |CLOSED
 Resolution|--- |ERRATA
Last Closed||2015-07-22 03:43:30



--- Comment #27 from errata-xmlrpc  ---
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2015-1420.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1212909] New package request: clufter - Tool for transforming/analyzing cluster configuration formats

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1212909
Bug 1212909 depends on bug 1182358, which changed state.

Bug 1182358 Summary: New package request: clufter - Tool for 
transforming/analyzing cluster configuration formats
https://bugzilla.redhat.com/show_bug.cgi?id=1182358

   What|Removed |Added

 Status|RELEASE_PENDING |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #4 from Daniel Kopeček  ---
(In reply to Petr Lautrbach from comment #2)
> Spec URL: http://plautrba.fedorapeople.org/secilc/secilc.spec
> SRPM URL: http://plautrba.fedorapeople.org/secilc/secilc-2.4-2.fc24.src.rpm
> 
> * Tue Jul 21 2015 Petr Lautrbach  2.4-2
> - make secilc-doc package noarch

DownloadError: 'Error 404 downloading
http://plautrba.fedorapeople.org/secilc/secilc-2.4-2.fc24.src.rpm'
07-22 09:47 root ERRORERROR: 'Error 404 downloading
http://plautrba.fedorapeople.org/secilc/secilc-2.4-2.fc24.src.rpm' (logs in
/home/dkopecek/.cache/fedora-review.log)

Please upload the package so that I can review it. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #5 from Petr Lautrbach  ---
Fixed, I accidentally uploaded secilc-2.4-2.fc23.src.rpm instead of
secilc-2.4-2.fc24.src.rpm. Sorry.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244509] Review Request: perl-DBIx-Class-Schema-Diff - Identify differences between two DBIx::Class schemas

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244509

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2015-07-22 03:58:40



--- Comment #4 from Emmanuel Seyman  ---
Released in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245356] Review Request: python-ansi - ANSI cursor movement and graphics

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245356



--- Comment #2 from Sebastian Dyroff  ---
Thanks, fixed. See

Spec URL: http://www.dyroff.net/fedora/python-ansi.spec
SRPM URL: http://www.dyroff.net/fedora/python-ansi-0.1.3-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063054] Review Request: rubygem-rb-fsevent - FSEvents API with Signals catching (without RubyCocoa)

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063054

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |
 Resolution|--- |DEFERRED
Last Closed||2015-07-22 04:03:01



--- Comment #2 from Parag AN(पराग)  ---
Based on https://bugzilla.redhat.com/show_bug.cgi?id=1063039#c3 , I am going to
close this review. If you still want to continue please reopen.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063055] Review Request: rubygem-rb-kqueue - A Ruby wrapper for BSD's kqueue, using FFI

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063055

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |
 Resolution|--- |DEFERRED
Last Closed||2015-07-22 04:04:20



--- Comment #2 from Parag AN(पराग)  ---
Based on https://bugzilla.redhat.com/show_bug.cgi?id=1063039#c3 , I am going to
close this review. If you still want to continue please reopen.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1063053] Review Request: rubygem-middleman-sprockets - Sprockets support for Middleman

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1063053

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |
 Resolution|--- |DEFERRED
Last Closed||2015-07-22 04:04:41



--- Comment #1 from Parag AN(पराग)  ---
Based on https://bugzilla.redhat.com/show_bug.cgi?id=1063039#c3 , I am going to
close this review. If you still want to continue please reopen.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1045963



--- Comment #11 from Jens Petersen  ---
Ping Pranav :)

Are you able to continue the review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244764



--- Comment #5 from Vít Ondruch  ---
Thanks for the update.

* Better description
  - I forgot to mention that the description is not really descriptive :/ Could
you please update the description? Probably the first paragraph from
README.md will do the job.

* Dependency on diff
  - Since I read the description now ( ;) ), I noticed that that the package
depends on external diff. It might be good idea to include
"Recommends: %{_bindir}/diff". On the other hand, I am not 100% sure if
that
is really needed because:

1) diff is very likely available even in some minimal installation
2) The case when diff is not available looks to be handled gracefully
   (although the message is probably not very clear).
3) There could be used also rubygem-diff-lcs alternatively (but this is not
   very likely due to (1))

So I leave it up to you, I just wanted to mention it here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1009754] Review Request: perl-Term-RawInput - Replacement for in perl scripts

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1009754

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||panem...@gmail.com
  Flags||needinfo?(chjoh...@gmail.co
   ||m)



--- Comment #2 from Parag AN(पराग)  ---
I have not see any activity by the submitter using his FAS in datagrepper
output.

Chris,
 you still want to continue packaging of this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1005518] Review Request: junicode-fonts - Unicode font for medievalists

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1005518

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||panem...@gmail.com
  Flags||needinfo?(leftmostcat@gmail
   ||.com)



--- Comment #10 from Parag AN(पराग)  ---
I have not see any activity by the submitter using his FAS in datagrepper
output in Fedora project.

Sean,
 you still want to continue packaging of this?

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1151462] Review Request: belen - GUI of youtube-dl command

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1151462

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||panem...@gmail.com
 Blocks|177841 (FE-NEEDSPONSOR) |
 Resolution|--- |NOTABUG
Last Closed||2015-07-22 04:21:38



--- Comment #22 from Parag AN(पराग)  ---
Let's close this now.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1157201] Review Request: python-flask-imgur - Upload images straight to Imgur in your Flask app.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1157201

Parag AN(पराग)  changed:

   What|Removed |Added

 CC||pyn...@gmail.com
  Flags||needinfo?(pyn...@gmail.com)



--- Comment #9 from Parag AN(पराग)  ---
Any progress here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244514] Review Request: python-snappy - Python library for the snappy compression library from Google

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244514



--- Comment #6 from Michael Schwendt (Fedora Packager Sponsors Group) 
 ---
%py3dir usage has been removed from the packaging guidelines anyway:

https://fedorahosted.org/fpc/ticket/435
https://fedoraproject.org/w/index.php?title=Packaging%3APython&diff=405394&oldid=404468
https://fedoraproject.org/wiki/Packaging:Python

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208616



--- Comment #21 from Fedora Update System  ---
consul-0-0.1.git5079177.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.fc22

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208616



--- Comment #23 from Fedora Update System  ---
consul-0-0.1.git5079177.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208616

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1208616] Review Request: consul - Tool for service discovery, monitoring and configuration http://www.consul.io

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1208616



--- Comment #22 from Fedora Update System  ---
consul-0-0.1.git5079177.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/consul-0-0.1.git5079177.fc21

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1231460] Review Request: osmium-tool - Command line tool for working with OpenStreetMap data based on the Osmium library

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1231460



--- Comment #3 from Tom Hughes  ---
New build to fix a test failure in mock:

Spec URL: http://download.compton.nu/tmp/osmium-tool.spec
SRPM URL: http://download.compton.nu/tmp/osmium-tool-1.1.1-3.src.rpm

Scratch build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=10434883

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270

Daniel Kopeček  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245604] New: Review Request: vim-go - Go development plugin for Vim

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245604

Bug ID: 1245604
   Summary: Review Request: vim-go - Go development plugin for Vim
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: nfo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://nforro.fedorapeople.org/vim-go.spec
SRPM URL: https://nforro.fedorapeople.org/vim-go-1.0.5-1.fc22.src.rpm

Koji scratchbuild URL:
http://koji.fedoraproject.org/koji/taskinfo?taskID=10435031

Description:
Go (golang) support for Vim. It comes with predefined sensible settings (like
auto gofmt on save), has auto-complete, snippet support, improved syntax
highlighting, go tool-chain commands, etc... If needed vim-go installs all
necessary binaries for providing seamless Vim integration with current
commands. It's highly customizable and each individual feature can be
disabled/enabled easily.

Fedora Account System Username: nforro

rpmlint output:
$ rpmlint vim-go.spec SRPMS/vim-go-1.0.5-1.fc22.src.rpm 
vim-go.src: W: spelling-error %description -l en_US golang -> Angolan, Golan,
Angola
vim-go.src: W: spelling-error %description -l en_US gofmt -> Goff
vim-go.src: W: spelling-error %description -l en_US customizable ->
customization
1 packages and 1 specfiles checked; 0 errors, 3 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241919



--- Comment #25 from Jackson Isaac  ---
Revbump to release v4.

Copied the versioned binary of kernprof. I tried to use alternatives system but
it was quite confusing with the post and postun stuff.

Spec URL:
https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v4/python-line_profiler.spec

SRPM URL:
https://jacksonisaac.fedorapeople.org/packaging/python-line_profiler/release-v4/python-line_profiler-1.0-4.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 808350] Review Request: racket - Racket development system

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=808350



--- Comment #64 from Miroslav Suchý  ---
So does it have sense to persuede this review? You may get more attention if
you start Copr project at:
 https://copr.fedoraproject.org
and reopen this review when the SElinux issue settle down (if ever).

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Aviso  changed:

   What|Removed |Added

 CC||red...@avram.us



--- Comment #14 from Aviso  ---
Looks like python-defusedxml was never added to EPEL 7. Can we get that added?


Also, I'm attaching a couple patches:


python-defusedxml-0.4.1-entity_loop.patch

It looks like in the mass rebuilds, --nocheck is used, so the tests don't
actually run, but when I rebuild manually, I noticed a few of the tests fail
with:

lxml.etree.XMLSyntaxError: Detected an entity reference loop, line 1, column 4

This is due to a security patch in libxml2. It's legitimate, but the tests are
expecting the wrong exception. I emailed the maintainer about it, but haven't
heard anything yet. This patch modifies the tests so they check for what is
expected.


python-defusedxml-0.4.1-format_strings.patch

This is from a pull request in the defusedxml repo. It fixes some string
formatting syntax so it work in Python 2.6 as well as 2.7+
https://bitbucket.org/tiran/defusedxml/pull-request/1/make-format-strings-python26-compatible/diff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #6 from Daniel Kopeček  ---
secilc.x86_64: E: explicit-lib-dependency libsepol
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

Why does the tool require static linkage to libsepol and the explicit Requires
on libsepol?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=927883



--- Comment #15 from Aviso  ---
Created attachment 1054818
  --> https://bugzilla.redhat.com/attachment.cgi?id=1054818&action=edit
Patch for tests.py

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245618] New: Review Request: golang-github-bgentry-speakeasy - Golang helpers for reading password input without cgo

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245618

Bug ID: 1245618
   Summary: Review Request: golang-github-bgentry-speakeasy -
Golang helpers for reading password input without cgo
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-bgentry-speakeasy/golang-github-bgentry-speakeasy.spec

SRPM URL:
https://jchaloup.fedorapeople.org/reviews/golang-github-bgentry-speakeasy/golang-github-bgentry-speakeasy-0-0.1.gitbc4d2c2.fc20.src.rpm

Description: Golang helpers for reading password input without cgo

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10435878

$ rpmlint golang-github-bgentry-speakeasy-0-0.1.gitbc4d2c2.fc20.src.rpm
golang-github-bgentry-speakeasy-devel-0-0.1.gitbc4d2c2.fc20.noarch.rpm
golang-github-bgentry-speakeasy.src: W: spelling-error Summary(en_US) cgo ->
cog, cg, co
golang-github-bgentry-speakeasy.src: W: spelling-error %description -l en_US
cgo -> cog, cg, co
golang-github-bgentry-speakeasy-devel.noarch: W: spelling-error Summary(en_US)
cgo -> cog, cg, co
golang-github-bgentry-speakeasy-devel.noarch: W: spelling-error %description -l
en_US cgo -> cog, cg, co
2 packages and 0 specfiles checked; 0 errors, 4 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=927883



--- Comment #16 from Aviso  ---
Created attachment 1054819
  --> https://bugzilla.redhat.com/attachment.cgi?id=1054819&action=edit
python-defusedxml-0.4.1-format_strings.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Aviso  changed:

   What|Removed |Added

 Attachment|Patch for tests.py  |python-defusedxml-0.4.1-ent
   #1054818||ity_loop.patch
description||



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #7 from Daniel Kopeček  ---
Also, during the package build phase, a lot of useless stuff gets compiled
including libsepo.a,.so and some binaries that are removed afterwards. This
only slows down the build of the package and should be avoided.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #8 from Daniel Kopeček  ---
secilc.x86_64: W: spurious-executable-perm /usr/share/man/man8/secilc.8.gz
The file is installed with executable permissions, but was identified as one
that probably should not be executable.  Verify if the executable bits are
desired, and remove if not.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270



--- Comment #9 from Daniel Kopeček  ---
secilc-debuginfo.x86_64: E: debuginfo-without-sources
This debuginfo package appears to contain debug symbols but no source files.
This is often a sign of binaries being unexpectedly stripped too early during
the build, or being compiled without compiler debug flags (which again often
is a sign of distro's default compiler flags ignored which might have security
consequences), or other compiler flags which result in rpmbuild's debuginfo
extraction not working as expected.  Verify that the binaries are not
unexpectedly stripped and that the intended compiler flags are used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270

Daniel Kopeček  changed:

   What|Removed |Added

 CC||plaut...@redhat.com
  Flags||needinfo?(plautrba@redhat.c
   ||om)



--- Comment #10 from Daniel Kopeček  ---
Please resolve the issues described in comments #6, #7, #8 and #9 so that I can
continue with the review process.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1224516] Review Request: httpcomponents-asyncclient - Apache components to build asynchronous client side HTTP services

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1224516

gil cattaneo  changed:

   What|Removed |Added

 Blocks||1245633




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1245633
[Bug 1245633] metrics-3.1.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245640] New: Review Request: msed - Tools to manage the activation and use of self encrypting drives

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245640

Bug ID: 1245640
   Summary: Review Request: msed -  Tools to manage the activation
and use of self encrypting drives
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: c...@wpi.edu
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://cra.fedorapeople.org/msed/msed.spec
SRPM URL:
https://cra.fedorapeople.org/msed/msed-0.23-0.4.beta.gite38a16d.fc21.src.rpm
Description: MSED is a Self-Encrypting Drive (SED) management program and
Pre-Boot Authorization (PBA) image that will allow the activation and use of
self encrypting drives that comply with the Trusted Computing Group
Opal 2.0 SSC.

This package provides the msed and linuxpba binaries, but not the PBA
image itself.

Fedora Account System Username: cra

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241808] Review Request: python-oslo-cache - Cache storage for Openstack projects.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241808

hgue...@redhat.com changed:

   What|Removed |Added

 CC||hgue...@redhat.com



--- Comment #4 from hgue...@redhat.com ---
Please drop this line:
%{python2_sitelib}/

Basically, your package would be owning python site-packages directory, which
is not ok.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242724] Review Request: perl-File-Find-Rule-Age - Rule to match on file age

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1242724



--- Comment #1 from Petr Šabata  ---
Nothing really new here so I'll be brief.  I explained all these in the other
review :)   I'll assume this one is going into EL6+ as well.


* The BuildRoot tag can be dropped.

* The perl version constraint can be dropped.

* Missing buildtime dependencies: coreutils, findutils, make
  All of these are called in the specfile.

* Missing perl buildtime dependencies:
  - base, lib/File/Find/Rule/Age.pm:8
  - Carp, lib/File/Find/Rule/Age.pm:10
  - File::stat, lib/File/Find/Rule/Age.pm:12
  - FindBin, t/01-legacy.t:6 t/02-accessed.t:6 t/02-created.t:6
t/02-modified.t:6
  - strict, Makefile.PL:1
  - warnings, Makefile.PL:2

 The lib/* and t/* deps are needed because you run the test suite (good!).

* You should filter out the autogenerated unversioned runtime dependencies on
DateTime, File::Find::Rule and Params::Util.  For example like so:

%global __requires_exclude ^perl\\(DateTime|File::Find::Rule|Params::Util\\)$

* There's no need to clean the buildroot (line 40), remove the emtpy
directories (line 45), for the %clean section (lines 52-53) or for %defattr
(line 56).

* You may substitute PERL_INSTALL_ROOT with DESTDIR.

* Don't package upstream distribution metadata, META.json, in %doc.

* Correct the changelog header (missing e-mail address).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219612] Review Request: nodejs-mongodb-core - Core MongoDB driver functionality

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219612

Troy Dawson  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #4 from Troy Dawson  ---
New Package SCM Request
===
Package Name: nodejs-mongodb-core
Short Description: Core MongoDB driver functionality
Upstream URL: https://github.com/christkv/mongodb-core
Owners: tdawson
Branches: f23 epel7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 958131] Review Request: mysql-community - rename community-mysql to mysql-community

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=958131



--- Comment #15 from Honza Horak  ---
With dnf and soft dependencies we might be able to do more, theoretically. But
I'm still not sure if renaming is worth the trouble..

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 927883] Review Request: python-defusedxml - XML bomb protection for Python stdlib modules

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=927883

Miro Hrončok  changed:

   What|Removed |Added

  Flags|fedora-cvs+ |fedora-cvs?



--- Comment #17 from Miro Hrončok  ---
Package Change Request
==
Package Name: python-defusedxml
New Branches: epel7
Owners: churchyard bkabrda

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1242727] Review Request: perl-MooX-Roles-Pluggable - Moo eXtension for pluggable roles

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1242727



--- Comment #1 from Petr Šabata  ---
Based on my feedback from the other two reviews, try to fix this package first.
 I would just repeat myself and it will be a good exercise for you :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1235831] Review Request: vim-vcscommand - version control system commands from within vim

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1235831

Nikola Forró  changed:

   What|Removed |Added

 CC||nfo...@redhat.com



--- Comment #5 from Nikola Forró  ---
(In reply to Raphael Groner from comment #2)
> * Reference the complete individual folders: remove the star ('*') at the
> end of the %files lines but keep the trailing slashes ('/') at the pathes.

I think by doing this, you are causing the package to own the directories,
which is in contradiction with FPG, because the directories are already owned
by vim-filesystem package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233989] Review Request: gap-pkg-aclib - Almost Crystallographic groups library for GAP

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233989



--- Comment #4 from Jerry James  ---
Do you happen to have an earlier build of gap-pkg-aclib installed on the
machine where this check is being run (i.e., so that the checker sees the
installed package and thinks that the directory ownership clashes as a result)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244764



--- Comment #6 from Ilya Gradina  ---
Spec URL: http://repo.clanwars.org/gitlab/rubygem-diffy.spec
SRPM URL: http://repo.clanwars.org/gitlab/rubygem-diffy-3.0.7-4.fc24.src.rpm

rubygem-diffy uses system's "diff" or "ldiff" (from %{_bindir}, tbh). "diff" is
coming from package called "diffutils" and it present in minimal system
(because if I'm trying to remove diffutils I'm getting errors about removing
systemd and dnf). This means that Requires: /usr/bin/diff is not needed. About
"ldiff".. It comes from "rubygem-diff-lcs". According to sources[0], it tries
to find "diff" first and if it's not found - tries to use "ldiff", so if we
will add Requires: /usr/bin/ldiff it will be not used at all, so it's
unnecessary.


[0]https://github.com/samg/diffy/blob/master/lib/diffy/diff.rb#L151-L153

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1244764] Review Request: rubygem-diffy - Convenient diffing in ruby

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1244764



--- Comment #7 from Vít Ondruch  ---
Ok, thx. The package looks good and is ready for approval from my POV. Could
you please apply your newly gained experience to your other package as well?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241808] Review Request: python-oslo-cache - Cache storage for Openstack projects.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241808

hgue...@redhat.com changed:

   What|Removed |Added

 Blocks||1243533
   ||(RDO-LIBERTY-REVIEWS)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1243533
[Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245270] Review Request: secilc - The SELinux CIL Compiler

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245270

Petr Lautrbach  changed:

   What|Removed |Added

  Flags|needinfo?(plautrba@redhat.c |
   |om) |



--- Comment #11 from Petr Lautrbach  ---
(In reply to Daniel Kopeček from comment #6)
> secilc.x86_64: E: explicit-lib-dependency libsepol
> You must let rpm find the library dependencies by itself. Do not put unneeded
> explicit Requires: tags.

fixed

> 
> Why does the tool require static linkage to libsepol and the explicit
> Requires on libsepol?

Requires on sepol was removed as wrong.

But it still links against static libsepol.a library. It's already changed in
upstream devel tree and it will be addressed in the update to the next upstream
release in future. Right now, it would need backport several commits including
a code move and a re-factorization.

(In reply to Daniel Kopeček from comment #9)
> secilc-debuginfo.x86_64: E: debuginfo-without-sources


fixed

SRPM URL: http://plautrba.fedorapeople.org/secilc/secilc-2.4-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1190269] Review Request: openstack-barbican - Secrets as a Service

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1190269

Greg Swift  changed:

   What|Removed |Added

  Flags|needinfo?(gregswift@gmail.c |needinfo?(karlthered@gmail.
   |om) |com)



--- Comment #21 from Greg Swift  ---
Updated the method a little bit, using the suggested loop with minor tweak

https://github.com/gregswift/barbican-spec/commit/46acd1998c7bb890acecd8a5f1913bc2816b8f2d

Spec URL: http://nytefyre.net/rpms/openstack-barbican.spec
SRPM URL: http://nytefyre.net/rpms/openstack-barbican-2014.2-6.fc21.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1219612] Review Request: nodejs-mongodb-core - Core MongoDB driver functionality

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1219612



--- Comment #5 from Troy Dawson  ---

(In reply to Parag AN(पराग) from comment #3)
> Review:
> 
> + Package build successfully in mock F24 x86_64
> 
> + rpmlint on all generated rpms gave output
> nodejs-mongodb-core.noarch: W: only-non-binary-in-usr-lib
> 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
> 
> + Packaged source verified with upstream as (sha256sum)
> source in
> tarball:6efaf61e6ceaa1fc322a01c480fcf347a1c8e57d911dc6546d4e87b5922d41b5
> source from upstream:
> 6efaf61e6ceaa1fc322a01c480fcf347a1c8e57d911dc6546d4e87b5922d41b5
> 
> + License "ASL 2.0" is valid and is included in LICENSE file.
> 
> + follow nodejs packaging guidelines
> 
> Suggestions:
> 1) Group tag is not necessary except you have plans to build this for EPEL5.
> 
> 2) you should follow
> https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/
> Packagers#ExclusiveArch and use
> 
> ExclusiveArch: %{nodejs_arches} noarch
> 
> 3) also we have a license tag to mark license files so you should use
> %license LICENSE
> 
> See https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text
> 
> APPROVED.

Thank you for the review.
I like all of your suggestions, and will implement them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1241919] Review Request: python-line_profiler - Line-by-line profiler for Python.

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1241919

Michel Alexandre Salim  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|mic...@michel-slm.name
  Flags||fedora-review?



--- Comment #26 from Michel Alexandre Salim  ---
yeah, I think you don't need the alternatives just yet.

If you look at the default Python template (rpmdev-newspec -t python bla), it
basically does the installation twice, Python 3 first, to make sure that the
Python 2 binary that is installed later wins.

So in your case you can just make the symlink point to the Python2 version if
you want, but not having it is probably not a big deal. I'll check the
guidelines again just to make sure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245754] New: Review Request: python-linecache2 - Backport of the linecache module

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245754

Bug ID: 1245754
   Summary: Review Request: python-linecache2 - Backport of the
linecache module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mic...@michel-slm.name
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://salimma.fedorapeople.org/specs/python/python-linecache2.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/python/python-linecache2-1.0.0-1.fc22.src.rpm
Description:
A backport of linecache to older supported Pythons.

Fedora Account System Username: salimma

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245754] Review Request: python-linecache2 - Backport of the linecache module

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245754

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||1201575




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1201575
[Bug 1201575] python-testtools-1.8.0 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245765] New: Review Request: python-traceback2 - Backport of the traceback module

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245765

Bug ID: 1245765
   Summary: Review Request: python-traceback2 - Backport of the
traceback module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mic...@michel-slm.name
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://salimma.fedorapeople.org/specs/python/python-traceback2.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/python/python-traceback2-1.4.0-1.fc22.src.rpm
Description: A backport of traceback to older supported Pythons.
Fedora Account System Username: salimma

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245754] Review Request: python-linecache2 - Backport of the linecache module

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245754

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||1245765




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1245765
[Bug 1245765] Review Request: python-traceback2 - Backport of the traceback
module
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245765] Review Request: python-traceback2 - Backport of the traceback module

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245765

Michel Alexandre Salim  changed:

   What|Removed |Added

 Blocks||1201575
 Depends On||1245754




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1201575
[Bug 1201575] python-testtools-1.8.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1245754
[Bug 1245754] Review Request: python-linecache2 - Backport of the linecache
module
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1243507

Bill Pemberton  changed:

   What|Removed |Added

  Flags|fedora-cvs? |fedora-cvs+



--- Comment #9 from Bill Pemberton  ---
I didn't see these branches initially, I see them now.  I was impatient. 
Apologizes for the noise.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #5 from Marcin Haba  ---
Hello,

@Dave:

I noticed that the SWIG bindings bug is already fixed, so I have started review
feature request hgsubversion package.

The result RPM package builds successfully without errors or tracebacks. That
is nice.

Also all unit tests cases finished well:

Ran 362 tests in 782.711s
OK

Installation went perfect either by:

dnf install ./hgsubversion-1.8.1-1.fc21.noarch.rpm

For know the hgsubversion usage I read begining of the documentation from here:

/home/gani/1221459-hgsubversion/rpms-unpacked/hgsubversion-1.8.1-1.fc21.noarch.rpm/usr/share/doc/hgsubversion/hgsubversion.html

that says:

"
 To create a new Mercurial clone, you can use a command such as the following:

 $ hg clone  [destination]

   Or with a real example:

 $ hg clone http://python-nose.googlecode.com/svn nose-hg
"

For test I used a random selected SVN repository from fedorahosted:

$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
abort: 'http://svn.fedorahosted.org/svn/xmlto/' does not appear to be an hg
repository:
---%<--- (text/html; charset=UTF-8)
xmlto - Revision 82: /

 xmlto - Revision 82: /
 
  AUTHORS
  COPYING
  ChangeLog
  FAQ
  INSTALL
  Makefile.am
  NEWS
  README
  THANKS
  config.h.in
  configure.in
  doc/
  format/
  xmlif/
  xmlto.in
  xmlto.mak
  xmlto.spec.in
 
 Powered by http://subversion.tigris.org/";>Subversion version 1.6.11
(r934486).

---%<---
!

I also tried to use --layout single switcher, but without success:

$ hg clone --layout single http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
hg clone: option --layout not recognized
hg clone [OPTION]... SOURCE [DEST]

make a copy of an existing repository

options ([+] can be repeated):

 -U --noupdate  the clone will include an empty working copy (only a
repository)
 -u --updaterev REV revision, tag or branch to check out
 -r --rev REV [+]   include the specified changeset
 -b --branch BRANCH [+] clone only the specified branch
--pull  use pull protocol to copy metadata
--uncompressed  use uncompressed transfer (fast over LAN)
 -e --ssh CMD   specify ssh command to use
--remotecmd CMD specify hg command to run on the remote side
--insecure  do not verify server certificate (ignoring web.cacerts
config)

(use "hg clone -h" to show more help)


At the end I tried to checkout the same repository by subversion:

$ svn checkout http://svn.fedorahosted.org/svn/xmlto/
Axmlto/xmlif
Axmlto/xmlif/test
Axmlto/xmlif/test/result-foo
Axmlto/xmlif/test/result-bar
Axmlto/xmlif/test/result-html
Axmlto/xmlif/test/run-test
Axmlto/xmlif/test/result-unrelated-condition
Axmlto/xmlif/test/result-pdf
Axmlto/xmlif/test/result-baz
Axmlto/xmlif/test/result-no-condition
Axmlto/xmlif/test/result-ps
Axmlto/xmlif/test/test.xml
Axmlto/xmlif/xmlif.c
Axmlto/xmlif/xmlif.l
Axmlto/AUTHORS
Axmlto/configure.in
Axmlto/ChangeLog
Axmlto/THANKS
Axmlto/format
Axmlto/format/docbook
Axmlto/format/docbook/txt
Axmlto/format/docbook/xhtml-nochunks
Axmlto/format/docbook/dvi
Axmlto/format/docbook/ps
Axmlto/format/docbook/html-nochunks
Axmlto/format/docbook/javahelp
Axmlto/format/docbook/awt
Axmlto/format/docbook/epub
Axmlto/format/docbook/xhtml
Axmlto/format/docbook/svg
Axmlto/format/docbook/fo
Axmlto/format/docbook/html
Axmlto/format/docbook/pdf
Axmlto/format/docbook/man
Axmlto/format/docbook/mif
Axmlto/format/docbook/htmlhelp
Axmlto/format/docbook/pcl
Axmlto/format/fo
Axmlto/format/fo/svg
Axmlto/format/fo/txt
Axmlto/format/fo/dvi
Axmlto/format/fo/ps
Axmlto/format/fo/pdf
Axmlto/format/fo/awt
Axmlto/format/fo/mif
Axmlto/format/fo/pcl
Axmlto/format/xhtml1
Axmlto/format/xhtml1/svg
Axmlto/format/xhtml1/txt
Axmlto/format/xhtml1/dvi
Axmlto/format/xhtml1/ps
Axmlto/format/xhtml1/fo
Axmlto/format/xhtml1/pdf
Axmlto/format/xhtml1/awt
Axmlto/format/xhtml1/mif
Axmlto/format/xhtml1/pcl
Axmlto/README
Axmlto/config.h.in
Axmlto/xmlto.spec.in
Axmlto/doc
Axmlto/doc/xmlto.xml
Axmlto/doc/xmlif.xml
Axmlto/INSTALL
Axmlto/FAQ
Axmlto/COPYING
Axmlto/xmlto.in
Axmlto/Makefile.am
Axmlto/xmlto.mak
Axmlto/NEWS

This test confirms that it is valid SVN repository.

THe hgsubversion is on place:

# ls -l /usr/lib/python2.7/site-packages/hgsubversion/ 
razem 736
-rw-r--r--. 1 root root  1993 05-07 10:46 compathacks.py
-rw-r--r--. 2 root root  2811 07-22 18:12 compathacks.pyc
-rw-r--r--. 2 root root  2811 07-22 18:12 compathacks.pyo
-rw-r--r--. 1 root root 25484 05-07 10:46 editor.py
-rw-r--r--. 2 root root 21925 07-22 18:12 editor.pyc
-rw-r--r--. 2 root root 21925 07-22 18:12 editor.pyo
...
...


Could you tell me if documentation is wrong or I missed so

[Bug 921797] Review Request: pypolicyd-spf - SPF Policy Server for Postfix (Python implementation)

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=921797



--- Comment #60 from Trever Adams  ---
Until bug 1230373 and bug 1232595 get fixed, I will not be looking at this.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 921797] Review Request: pypolicyd-spf - SPF Policy Server for Postfix (Python implementation)

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=921797



--- Comment #59 from Trever Adams  ---
George, I haven't looked into it. I am afraid it got lost in the noise of my
work.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #6 from Marcin Haba  ---
One more info.

On system where I built hgsubversion result RPM I have the subversion libs that
causes SWIG problem:

# dnf list installed subversion*
Last metadata expiration check performed 2:34:25 ago on Wed Jul 22 17:40:34
2015.
Zainstalowane pakiety
subversion.x86_64 1.8.13-2.fc22  @System
subversion-libs.x86_641.8.13-2.fc22  @System
subversion-python.x86_64  1.8.13-2.fc22  @System


On system where I installed the result RPM I have the same subversion libs that
causes SWIG problem:

# dnf list installed subversion*
Last metadata expiration check performed 1:06:36 ago on Wed Jul 22 19:02:04
2015.
Zainstalowane pakiety
subversion-libs.x86_64  1.8.13-2.fc22@System
subversion-python.x86_641.8.13-2.fc22@System

On system where I installed the result RPM also I experienced the same SWIG
traceback:

>>> import hgsubversion
Traceback (most recent call last):
  File "", line 1, in 
  File "/usr/lib/python2.7/site-packages/hgsubversion/__init__.py", line 49, in

import svncommands
  File "/usr/lib/python2.7/site-packages/hgsubversion/svncommands.py", line 16,
in 
import svnwrap
  File "/usr/lib/python2.7/site-packages/hgsubversion/svnwrap/__init__.py",
line 28, in 
from svn_swig_wrapper import *
  File
"/usr/lib/python2.7/site-packages/hgsubversion/svnwrap/svn_swig_wrapper.py",
line 20, in 
from svn import client
  File "/usr/lib64/python2.7/site-packages/svn/client.py", line 26, in 
from libsvn.client import *
  File "/usr/lib64/python2.7/site-packages/libsvn/client.py", line 105, in

import libsvn.core
  File "/usr/lib64/python2.7/site-packages/libsvn/core.py", line 7285, in

svn_pool_create()
TypeError: svn_pool_create() takes exactly 2 arguments (0 given)

So, my question is - why previously during first test the same version Spec and
SRPM threw traceback during building, but now it does not throw this traceback
during build process ?

At the end, I would mention that the subversion 1.8.13-7 is not available yet
in repository:

# LANG=en dnf update subversion-libs subversion-python
Failed to set locale, defaulting to C
Last metadata expiration check performed 1:25:18 ago on Wed Jul 22 19:02:04
2015.
Dependencies resolved.
Nothing to do.
Complete!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233989] Review Request: gap-pkg-aclib - Almost Crystallographic groups library for GAP

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233989

Gerald Cox  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Gerald Cox  ---
Apparently, this issue was being caused by a changes that have been made to
dnf.  I found:  https://bugzilla.redhat.com/show_bug.cgi?id=1244531
and applied the update which appears to have fixed this particular issue;
however, I commented in the ticket that while I was testing I found other
packages which previously passed review fine are now showing errors.  

In any event, it's working now, so I'm approving this before something else
breaks... ;-)

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

FALSE POSITIVES:

- W: spelling-error Summary(en_US) [...listed below...]

SHOULD:

- %check is present and all tests pass.

- W: only-non-binary-in-usr-lib
  Same situation that occurred in rhbz#1233984

- If the source package does not include license text(s) as a separate
  file from upstream, the packager SHOULD query upstream to include it.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 2 files have unknown license. Detailed
 output of licensecheck in /home/gbcox/bugzilla_fedora_review/1233989
 -gap-pkg-aclib/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[-]: Description and summary sections in

[Bug 1245791] New: Review Request: python-influxdb - Python client for interacting with InfluxDB

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245791

Bug ID: 1245791
   Summary: Review Request: python-influxdb - Python client for
interacting with InfluxDB
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: karlthe...@gmail.com
  Reporter: pkila...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
 Flags: fedora-review?



Spec URL:
https://pkilambi.fedorapeople.org/python-influxdb/python-influxdb.spec
SRPM URL:
https://pkilambi.fedorapeople.org/python-influxdb/python-influxdb-2.6.0-1.fc22.src.rpm

Description:
Python client for interacting with InfluxDB

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #7 from Dave Johansen  ---
(In reply to Marcin Haba from comment #5)
> For test I used a random selected SVN repository from fedorahosted:
> 
> $ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
> abort: 'http://svn.fedorahosted.org/svn/xmlto/' does not appear to be an hg
> repository:
> 
> Could you tell me if documentation is wrong or I missed something.

Did you enable hgsubversion (
https://mercurial.selenic.com/wiki/HgSubversion#Installation_and_Configuration
)?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205376] Review Request: spooky-c - C port of Bob Jenkins' spooky hash algorithm

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1205376

Björn Persson  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2015-07-22 15:40:48



--- Comment #21 from Björn Persson  ---
All done as far as I can see.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #8 from Marcin Haba  ---
Hello,

Thanks for quick reply.

No, I did not enable hgsubversion. Thanks for the link. I have never used
Mercurial before ;-)

It might be good to mention about this step (adding rc file) in documentation,
or provide this rc file in hgsubversion RPM package. What do you think about
it?

So, I added rc file to /etc/mercurial/hgrc.d/ as below:

# cat /etc/mercurial/hgrc.d/hgsubversion.rc 
[extensions]
hgsubversion = /usr/lib/python2.7/site-packages/hgsubversion


And then I tried to use the same hg call as previously:
$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg

As result I noticed segfault in dmesg:

[47575.983918] hg[25781]: segfault at 0 ip 7f5b12b58abd sp 7ffc310c4540
error 6 in libpython2.7.so.1.0[7f5b12ad8000+17c000]

I tried to use gdb as below:

gdb /usr/bin/python2.7
run /usr/bin/hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg


Starting program: /usr/bin/python2.7 /usr/bin/hg clone
http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
0x77a93abd in dict_set_item_by_hash_or_entry () from
/lib64/libpython2.7.so.1.0
...
...
(gdb) thread apply all bt
#0  0x77a93abd in dict_set_item_by_hash_or_entry () from
/lib64/libpython2.7.so.1.0
#1  0x77a95ef4 in PyDict_SetItemString () from
/lib64/libpython2.7.so.1.0
#2  0x7fffeb6c2219 in SWIG_Python_SetConstant () from
/usr/lib64/python2.7/site-packages/libsvn/_client.so
#3  0x7fffeb6c2415 in svn_swig_py_get_commit_log_func_swigconstant () from
/usr/lib64/python2.7/site-packages/libsvn/_client.so
#4  0x77af58be in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#5  0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#6  0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#7  0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#8  0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#9  0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#10 0x77b0767f in load_next () from /lib64/libpython2.7.so.1.0
#11 0x77b08098 in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0
#12 0x77aede48 in builtin___import__ () from /lib64/libpython2.7.so.1.0
#13 0x77af4f43 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#14 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#15 0x77af55c6 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#16 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#17 0x77a825ac in function_call () from /lib64/libpython2.7.so.1.0
#18 0x77a5db03 in PyObject_Call () from /lib64/libpython2.7.so.1.0
#19 0x77aefac7 in PyEval_CallObjectWithKeywords () from
/lib64/libpython2.7.so.1.0
#20 0x77af261b in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#21 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#22 0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#23 0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#24 0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#25 0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#26 0x77b07918 in ensure_fromlist () from /lib64/libpython2.7.so.1.0
#27 0x77b0815a in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0
#28 0x77aede48 in builtin___import__ () from /lib64/libpython2.7.so.1.0
#29 0x77af4f43 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#30 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#31 0x77af55c6 in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#32 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#33 0x77a825ac in function_call () from /lib64/libpython2.7.so.1.0
#34 0x77a5db03 in PyObject_Call () from /lib64/libpython2.7.so.1.0
#35 0x77aefac7 in PyEval_CallObjectWithKeywords () from
/lib64/libpython2.7.so.1.0
#36 0x77af261b in PyEval_EvalFrameEx () from /lib64/libpython2.7.so.1.0
#37 0x77af66b4 in PyEval_EvalCodeEx () from /lib64/libpython2.7.so.1.0
#38 0x77af67d9 in PyEval_EvalCode () from /lib64/libpython2.7.so.1.0
#39 0x77b064dc in PyImport_ExecCodeModuleEx () from
/lib64/libpython2.7.so.1.0
#40 0x77b06762 in load_source_module () from /lib64/libpython2.7.so.1.0
#41 0x77b073f0 in import_submodule () from /lib64/libpython2.7.so.1.0
#42 0x77b0767f in load_next () from /lib64/libpython2.7.so.1.0
#43 0x77b0805d in PyImport_ImportModuleLevel () from
/lib64/libpython2.7.so.1.0
#44 0x77aed

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #9 from Marcin Haba  ---
Same plugin is loaded as shows below command:

# hg help hgsubversion
hgsubversion extension - integration with Subversion repositories

hgsubversion is an extension for Mercurial that allows it to act as a
Subversion client, offering fast, incremental and bidirectional
synchronisation.

At this point, hgsubversion is usable by users reasonably familiar with
Mercurial as a VCS. It's not recommended to dive into hgsubversion as an
introduction to Mercurial, since hgsubversion "bends the rules" a little and
violates some of the typical assumptions of early Mercurial users.

Before using hgsubversion, we *strongly* encourage running the automated
tests. See 'README' in the hgsubversion directory for details.

For more information and instructions, see "hg help subversion".

list of commands:

 svn   subcommands for Subversion integration

(use "hg help -v hgsubversion" to show built-in aliases and global options)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233989] Review Request: gap-pkg-aclib - Almost Crystallographic groups library for GAP

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233989



--- Comment #6 from Jerry James  ---
(In reply to Gerald Cox from comment #5)
> In any event, it's working now, so I'm approving this before something else
> breaks... ;-)

Ha!  Thank you so much once again for the reviews.  I owe you a few.  Ping me
when you have something I can review for you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1233989] Review Request: gap-pkg-aclib - Almost Crystallographic groups library for GAP

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1233989

Jerry James  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #7 from Jerry James  ---
New Package SCM Request
===
Package Name: gap-pkg-aclib
Short Description: Almost Crystallographic groups library for GAP
Upstream URL: http://www.icm.tu-bs.de/~beick/so.html
Owners: jjames
Branches: f22 f23
InitialCC:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1154218] Review Request: graphite-api - Graphite-web, without the interface. Just the rendering HTTP API

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1154218



--- Comment #16 from Piotr Popieluch  ---
Spec URL: https://piotrp.fedorapeople.org/graphite-api.spec
SRPM URL:
https://piotrp.fedorapeople.org/graphite-api-1.0.1-4.20150702gitbe7907c.fc22.src.rpm


Updated spec and srpm:
- removed epel support, python-six in el7 is too old and not supported
- removed Python2 support, not targeting el7 anymore, fedora has python3
- fixed lint warnings

Tested on F22

scratch-build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10441716

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1221459] Review Request: hgsubversion - Mercurial extension for Subversion

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1221459



--- Comment #10 from Marcin Haba  ---
Hello,

After download latest subversion 1.8.13-7 packages from here:

http://koji.fedoraproject.org/koji/buildinfo?buildID=669141

and update:

# dnf update subversion-libs-1.8.13-7.fc22.x86_64.rpm
subversion-1.8.13-7.fc22.x86_64.rpm subversion-python-1.8.13-7.fc22.x86_64.rpm

the hgsubversion started working:

$ hg clone http://svn.fedorahosted.org/svn/xmlto/ xmlto-hg
[r1] ovasik: xmlto release 0.0.21
[r2] ovasik: Initial commit to Fedorahosted XMLTO svn (version 0.0.21)
[r3] ovasik: fix broken stringparam option
[r4] ovasik: add --nonet and --noent option to xmllint validation check(fixes
debian #516253)
...
...
...
[r81] ovasik: xmlif: fix segfault with malformed end attribute
[r82] ovasik: xmlif/xmlif.{c,l}: fix double free with invalid end attribute
pulled 82 revisions
updating to branch default
62 files updated, 0 files merged, 0 files removed, 0 files unresolved

It looks that the SWIG problem in subversion was the reason.

So, I have following suggestions:

1) add to Spec Requires and BuildRequires tags appropriate subversion
dependecies (>= 1.8.13-7)
2) add a sample rc file /etc/mercurial/hgrc.d/ to enable hgsubversion extension

I a have question about tests cases from hgsubversion:

1) Why all tests executed by run.py finished successfully with installed
subversion(-libs|-python) 1.8.13-2 that version caused segfault on clone action
call?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1189269] Review Request: qparted - Visual partition editor based on Qt framework [a fork of qtparted]

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1189269



--- Comment #13 from Raphael Groner  ---
Mario, please try to reproduce comment #11 in Fedora 22. I could access my
stick with QtParted but it's retired cause of dead upstream (log of
2015-06-10).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245845] New: Review Request: python-scandir - faster version of os.walk included in PY3.5

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245845

Bug ID: 1245845
   Summary: Review Request: python-scandir - faster version of
os.walk included in PY3.5
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: red...@avram.us
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://drive.google.com/open?id=0B0D-SO5kT7MTbFNIbUR4UEpzTzA
SRPM URL: https://drive.google.com/open?id=0B0D-SO5kT7MTVXhTTllIYzRKWnc

Description: 
scandir() is a directory iteration function like os.listdir(), except that
instead of returning a list of bare filenames, it yields DirEntry objects that
include file type and stat information along with the name. Using scandir()
increases the speed of os.walk() by 2-20 times (depending on the platform and
file system) by avoiding unnecessary calls to os.stat() in most cases.
scandir is included in the Python 3.5+ standard library.

https://github.com/benhoyt/scandir
This package makes scandir available for Python 2 and Python <3.5

Fedora Account System Username: aviso

Scratch builds:
F24: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443289
EL6: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443284
EL7: https://koji.fedoraproject.org/koji/taskinfo?taskID=10443277

This is my first package, so I need a sponsor. The wiki says this is where I
should post links to show I'm involved.
Backported python-pgpdump to el6: bug 1030710
Help with python-pgpdump build failures: bug 1239850
Patches for python-defusedxml: bug 927883
Backported dhcp fix to el6: bug 1067142

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1243507



--- Comment #10 from Fedora Update System  ---
perl-Algorithm-LUHN-1.01-3.el6 has been submitted as an update for Fedora EPEL
6.
https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1243507



--- Comment #11 from Fedora Update System  ---
perl-Algorithm-LUHN-1.01-3.el7 has been submitted as an update for Fedora EPEL
7.
https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245852] New: Review Request: mingw-lua51 - MinGW Windows Library providing Lua 5.1 programming language

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245852

Bug ID: 1245852
   Summary: Review Request: mingw-lua51 - MinGW Windows Library
providing Lua 5.1 programming language
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: redhat-bugzi...@linuxnetz.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://labs.linuxnetz.de/bugzilla/mingw-lua51.spec
SRPM URL: http://labs.linuxnetz.de/bugzilla/mingw-lua51-5.1.5-1.src.rpm
Description:
Lua is a powerful light-weight programming language designed for extending
applications. Lua is also frequently used as a general-purpose, stand-alone
language. Lua is free software. Lua combines simple procedural syntax with
powerful data description constructs based on associative arrays and
extensible semantics. Lua is dynamically typed, interpreted from bytecodes,
and has automatic memory management with garbage collection, making it ideal
for configuration, scripting, and rapid prototyping.

This package contains a compatibility version of the Lua 5.1 binaries.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1227334] Review Request: libgudev - GObject-based wrapper library for libudev

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1227334

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||libgudev-230-2.fc23.x86_64
 Resolution|--- |RAWHIDE
Last Closed||2015-07-22 21:56:00



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245889] New: Review Request: python-pymssql - Microsoft SQL Server adapter for Python

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245889

Bug ID: 1245889
   Summary: Review Request: python-pymssql - Microsoft SQL Server
adapter for Python
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ste...@nuxoll.eu.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://snuxoll.fedorapeople.org/packages/python-pymssql.spec
SRPM URL:
https://snuxoll.fedorapeople.org/packages/python-pymssql-2.1.1-1.fc22.src.rpm
Description: A simple database interface for Python that builds on top of
FreeTDS to provide a Python DB-API (PEP-249) interface to Microsoft SQL Server.
Fedora Account System Username: snuxoll

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245889] Review Request: python-pymssql - Microsoft SQL Server adapter for Python

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245889



--- Comment #1 from Stefan Nuxoll  ---
I suppose I should note that this is my first package and that I will need a
sponsor.

This package has completed a successful Koji scratch build on:

Fedora 22: http://koji.fedoraproject.org/koji/taskinfo?taskID=10445560
Fedora 23: http://koji.fedoraproject.org/koji/taskinfo?taskID=10445585

Currently it's failing on EPEL 7, which is a branch I'm looking to target,
hopefully I'll have this working later today.

EPEL 7:http://koji.fedoraproject.org/koji/taskinfo?taskID=10445576

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245889] Review Request: python-pymssql - Microsoft SQL Server adapter for Python

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245889



--- Comment #2 from Stefan Nuxoll  ---
Got the EPEL scratch build working with a patch to setup.py, the src rpm and
spec file linked have been updated with the changes:

EPEL7:  http://koji.fedoraproject.org/koji/taskinfo?taskID=10445673

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1245889] Review Request: python-pymssql - Microsoft SQL Server adapter for Python

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1245889

Stefan Nuxoll  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1225229] Review Request: light-locker - A simple session-locker for lightdm

2015-07-22 Thread bugzilla
https://bugzilla.redhat.com/show_bug.cgi?id=1225229

Raphael Groner  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED
External Bug ID||Debian BTS 779749



--- Comment #19 from Raphael Groner  ---
Transition to systemd.

Is that Debian Bug (#779749) somehow relevant, also for Fedora?

Upstream issue: https://github.com/the-cavalry/light-locker/issues/64

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review