[Bug 1250344] Review Request: python-networking-cisco - Cisco OpenStack Neutron driver
https://bugzilla.redhat.com/show_bug.cgi?id=1250344 --- Comment #6 from Haïkel Guémar karlthe...@gmail.com --- Thanks, I'll apply the requested before first build! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230949] Review Request: hid4java - A cross-platform Java Native Access (JNA) wrapper for the signal11/hidapi library
https://bugzilla.redhat.com/show_bug.cgi?id=1230949 --- Comment #15 from Jonny Heggheim heg...@gmail.com --- Thanks, I tried to learn more about the naming guidelines at https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Should I also include the date? Like 0.1.20150726git1e9ef80 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238
Adam Miller admil...@redhat.com changed:
What|Removed |Added
Status|NEW |ASSIGNED
--- Comment #2 from Adam Miller admil...@redhat.com ---
The %{__python} should be %{__python2} as per python packaging guidelines:
https://fedoraproject.org/wiki/Packaging:Python
Otherwise things look good.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: BSD (2 clause), GPL (v3 or later). Detailed output of
licensecheck in /home/admiller/reviews/1251238-yubioath-
desktop/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in yubioath-desktop
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 --- Comment #3 from Seth Jennings spartacu...@gmail.com --- Adam, thanks for the review! New spec and SRPM using the __python2 macro. Spec URL: https://www.variantweb.net/pub/fedora/specs/yubioath-desktop.spec SRPM URL: https://www.variantweb.net/pub/fedora/22/source/SRPMS/yubioath-desktop-2.1.1-3.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251278] New: Review Request: python-XStatic-Angular-Gettext - Angular-gettext (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1251278 Bug ID: 1251278 Summary: Review Request: python-XStatic-Angular-Gettext - Angular-gettext (XStatic packaging standard) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: karlthe...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://hguemar.fedorapeople.org/reviews/python-XStatic-Angular-Gettext.spec SRPM URL: https://hguemar.fedorapeople.org/reviews/python-XStatic-Angular-Gettext-2.1.0.2-1.fc24.src.rpm Description: Angular-gettext (XStatic packaging standard) Fedora Account System Username: hguemar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251278] Review Request: python-XStatic-Angular-Gettext - Angular-gettext (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1251278 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 Fedora Blocker Bugs Application blockerb...@fedoraproject.org changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||1170817 ||(AlphaBlocker,F23AlphaBlock ||er) --- Comment #1 from Fedora Blocker Bugs Application blockerb...@fedoraproject.org --- Proposed as a Blocker for 23-alpha by Fedora user rdieter using the blocker tracking app because: F23 kde/plasma theming, adamw poked us yesterday that this was a blocker, so here we are. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1170817 [Bug 1170817] Fedora 23 Alpha blocker bug tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244196] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components
https://bugzilla.redhat.com/show_bug.cgi?id=1244196 --- Comment #11 from Kevin Kofler ke...@tigcc.ticalc.org --- Until that happens, I think we should treat the V8 portability issue as a non-blocker. Especially, because technically, one could get around the SSE2 issue by excluding i686 entirely, but it is of course better to ship a package that works on many-but-not-all i686 machines than none at all. We should just have a tracker bug for the SSE2 issue, as would be required for ExcludeArch. Maybe even put it on the x86 ExcludeArch tracker, even though we won't actually exclude the arch (because that'd be silly). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 Sandro Mani manisan...@gmail.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||manisan...@gmail.com Assignee|nob...@fedoraproject.org|manisan...@gmail.com Flags||fedora-review? --- Comment #2 from Sandro Mani manisan...@gmail.com --- Two things I notice: - Directories without known owners: /usr/share/kde4/apps/kdm, /usr/share/kde4/apps/kdm/themes, /usr/share/plasma/look-and-feel, /usr/share/plasma, /usr/share/plasma/desktoptheme - Licenses marked as %doc instead of %license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world
https://bugzilla.redhat.com/show_bug.cgi?id=1155793 --- Comment #17 from nobra...@gmail.com --- Spec URL: https://nobrakal.fedorapeople.org/hyperrogue.spec SRPM URL: https://nobrakal.fedorapeople.org/hyperrogue-6.6-1.fc22.src.rpm I've updated my spec to fix some typo, and force the use of the -fPIC flag during building. Here is a successful koji scratch build against rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=10627187 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 Adam Miller admil...@redhat.com changed: What|Removed |Added CC||admil...@redhat.com Assignee|nob...@fedoraproject.org|admil...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238
--- Comment #4 from Adam Miller admil...@redhat.com ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: BSD (2 clause), GPL (v3 or later). Detailed output of
licensecheck in /home/admiller/reviews/1251238-yubioath-
desktop/licensecheck.txt
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/icons/hicolor,
/usr/share/icons/hicolor/128x128/apps,
/usr/share/icons/hicolor/128x128
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
contains icons.
Note: icons in yubioath-desktop
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[-]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 Adam Miller admil...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246763] Review Request: cutegram - A Qt Qml based Telegram client
https://bugzilla.redhat.com/show_bug.cgi?id=1246763 --- Comment #2 from Helio Chissini de Castro he...@kde.org --- 1, 2 and 3 fixed on: https://heliocastro.fedorapeople.org/cutegram/cutegram-2.5.0-3.fc22.src.rpm https://heliocastro.fedorapeople.org/cutegram/cutegram.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246763] Review Request: cutegram - A Qt Qml based Telegram client
https://bugzilla.redhat.com/show_bug.cgi?id=1246763 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|nob...@fedoraproject.org|jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246762] Review Request: telegramqml - Qt Qml qtelegram wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1246762 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||jgrul...@redhat.com Assignee|williamjmore...@gmail.com |jgrul...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246762] Review Request: telegramqml - Qt Qml qtelegram wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1246762 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- 1) ldconfig should be called in %post and %postun 2) The spec file from the URL above is not the same as the one in SRPM 3) Group tag is optional and used only for compatibility with EPEL 4) You are mixing tabs and spaces according to rpmlint -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193990] Review Request: opencity - Full 3D city simulator game project
https://bugzilla.redhat.com/show_bug.cgi?id=1193990 --- Comment #13 from Fedora Update System upda...@fedoraproject.org --- opencity-0.0.6.5-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/opencity-0.0.6.5-3.fc21 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246763] Review Request: cutegram - A Qt Qml based Telegram client
https://bugzilla.redhat.com/show_bug.cgi?id=1246763 --- Comment #1 from Jan Grulich jgrul...@redhat.com --- 1) Missing runtime dependencies - at least qt5-qtquickcontrols and qt5-qtgraphicaleffects were required and not installed automatically 2) License should be marked with %license macro 3) Mixing tabs and spaces according to rpmlint -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250929] New: Review Request: python-XStatic-Angular-Gettext - Angular-Gettext (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1250929 Bug ID: 1250929 Summary: Review Request: python-XStatic-Angular-Gettext - Angular-Gettext (XStatic packaging standard) Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mru...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Gettext.spec SRPM URL: http://www.matthias-runge.de/fedora/python-XStatic-Angular-Gettext-2.1.0.2-1.fc22.src.rpm Description: Angular-Gettext javascript library packaged for setuptools (easy_install) / pip. This package is intended to be used by any project that needs these files. Fedora Account System Username: mrunge -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246762] Review Request: telegramqml - Qt Qml qtelegram wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1246762 --- Comment #2 from Helio Chissini de Castro he...@kde.org --- Hi 1, 2 and 4 fixed in https://heliocastro.fedorapeople.org/cutegram/telegramqml-0.8.0-5.fc22.src.rpm https://heliocastro.fedorapeople.org/cutegram/telegramqml.spec As group tag is optional, so i kept there -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230949] Review Request: hid4java - A cross-platform Java Native Access (JNA) wrapper for the signal11/hidapi library
https://bugzilla.redhat.com/show_bug.cgi?id=1230949 Alexander Kurtakov akurt...@redhat.com changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230949] Review Request: hid4java - A cross-platform Java Native Access (JNA) wrapper for the signal11/hidapi library
https://bugzilla.redhat.com/show_bug.cgi?id=1230949
--- Comment #14 from Alexander Kurtakov akurt...@redhat.com ---
Pre release Release tag should be 0.1.git%{short_sha}.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] Review Request:Helm - Software synth and lv2 plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 j...@therobinsonfamily.net changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||1251241 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1251241 [Bug 1251241] Fedora 23 KDE still uses Fedora 22 desktop background (no f23-kde-theme) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1197947] Review Request: khard - An address book for the Linux console
https://bugzilla.redhat.com/show_bug.cgi?id=1197947 --- Comment #8 from Ben Boeckel maths...@gmail.com --- (In reply to Florian der-flo Lehner from comment #7) If you package the latest commit (8a206ce3ad129d1588f8f57bd65d860369e92036), you don't need to patch the sources. Eh, a patch is easier to manage than all the git commit release stuff, IMO. And I still like the use of git tags instead of guessing what kind of software is in v0.4.1.tar.gz - *shrug* It is in its own directory here; I'm not too worried about it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 --- Comment #4 from Rex Dieter rdie...@math.unl.edu --- Spec URL: https://rdieter.fedorapeople.org/rpms/f23-kde-theme/f23-kde-theme.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/f23-kde-theme/f23-kde-theme-23.0-2.fc22.src.rpm %changelog * Thu Aug 06 2015 Rex Dieter rdie...@fedoraproject.org 23.0-2 - f23-kdm-theme: Requires: kdm (dir ownership mostly) , +README - fix parent dir ownership, use %%license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 --- Comment #3 from Rex Dieter rdie...@math.unl.edu --- Those dirs should probably be owned by kde-filesystem/kf5-filesytem, but I'll add them here until properly fixed elsehwere. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] New: Review Request:Helm - Software synth and lv2 plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 Bug ID: 1250833 Summary: Review Request:Helm - Software synth and lv2 plugins Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: j...@therobinsonfamily.net QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://therobinsonfamily.net/SPECS/helm.spec SRPM URL: http://therobinsonfamily.net/SRPMS/helm-0.4.1-3.fc22.src.rpm Description: Helm is a Software Synth and lv2 plugin which is designed to have a simple UI Fedora Account System Username: baggypants -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Parag Nemade pnem...@redhat.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #5 from Parag Nemade pnem...@redhat.com --- Thank you. New Package SCM Request === Package Name: nodejs-create-error-class Short Description: Create Error classes Upstream URL: https://github.com/floatdrop/create-error-class Owners: pnemade Branches: f22 f23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249148] Review Request: nodejs-create-error-class - Create Error classes
https://bugzilla.redhat.com/show_bug.cgi?id=1249148 Piotr Popieluch piotr1...@gmail.com changed: What|Removed |Added Flags|fedora-review- |fedora-review+ --- Comment #4 from Piotr Popieluch piotr1...@gmail.com --- APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246762] Review Request: telegramqml - Qt Qml qtelegram wrapper library
https://bugzilla.redhat.com/show_bug.cgi?id=1246762 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Grulich jgrul...@redhat.com --- Ok, looks good now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246763] Review Request: cutegram - A Qt Qml based Telegram client
https://bugzilla.redhat.com/show_bug.cgi?id=1246763 Jan Grulich jgrul...@redhat.com changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Jan Grulich jgrul...@redhat.com --- Ok, looks good now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244760] Review Request: rubygem-six - Very simple authorization gem
https://bugzilla.redhat.com/show_bug.cgi?id=1244760 --- Comment #8 from Vít Ondruch vondr...@redhat.com --- (In reply to Ilya Gradina from comment #7) I have added link to pull request which adds license in files distribution. Thx What is my next steps? I'm still waiting for some informal reviews. So far, I saw only bug 1246974, where you posted just output from fedora-review without any other comment. For example, there appears to be some issues identified by rpmlint, so you should probably pinpoint them and check if they are false positives and probably propose fix for the others. I hope you understand this is not to discourage you, but to encourage proper packaging ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250929] Review Request: python-XStatic-Angular-Gettext - Angular-Gettext (XStatic packaging standard)
https://bugzilla.redhat.com/show_bug.cgi?id=1250929 Matthias Runge mru...@redhat.com changed: What|Removed |Added Blocks||1243533 ||(RDO-LIBERTY-REVIEWS) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1243533 [Bug 1243533] (RDO) Tracker: Review requests for new RDO Liberty packages -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] Review Request:Helm - Software synth and lv2 plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1250833
Igor Gnatenko i.gnatenko.br...@gmail.com changed:
What|Removed |Added
CC||i.gnatenko.br...@gmail.com
--- Comment #3 from Igor Gnatenko i.gnatenko.br...@gmail.com ---
I'm not a sponsor, but I will give you some notes.
- Source0: https://github.com/mtytel/helm/archive/v0.4.1.zip
Source0:
https://github.com/mtytel/helm/archive/v%{version}.tar.gz#/%{name}-%{version}.tar.gz
Look at: https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags
You also can use %{url} instead of first part in Source0 tag
- Requires:mesa-libGL, alsa-lib, jack-audio-connection-kit, freetype,
libXrandr, libXinerama, libXcursor, helm-common
Please make it separate (I mean in some lines, not it one.
I don't think that most of them is needed (I'm sure that RPM will pick up
90% of them automatically)
- Requires: helm-common
you should specify version at least. Example:
Requires: helm-common = %{version}
- For common subpkg please build noarch version.
- $RPM_BUILD_ROOT
replace with %{buildroot}
- make %{?_smp_mflags}
you could use %make_build
- %_libdir/lv2/helm.lv2/helm.so
don't need to use quotes there
- Also i think you just want to have there just: %{_libdir}/lv2/helm.lv2/
don't need to specify files manually
The same for common subpackage
- %doc COPYING
should be %license COPYING
- %{_bindir}/helm
again, no quotes and try to use %{name} where it's possible
- %setup -q
You could use %autosetup
- License: GPL3
GPL3 is not valid license. You'd want GPLv3 or GPLv3+ (haven't checked
sources)
- I've not checked desktop file, but looks like no icons in hicolor theme,
only in /usr/share/helm. So if you want to use icons there -- use
%{_datadir}/icons/hicolor/* as place for icons
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 Igor Gnatenko i.gnatenko.br...@gmail.com changed: What|Removed |Added Summary|Review Request:Helm - |Review Request: helm - |Software synth and lv2 |Polyphonic software synth |plugins |with lots of modulation and ||easy to use UI -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] Review Request:Helm - Software synth and lv2 plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 --- Comment #2 from j...@therobinsonfamily.net --- This is my first request and I need a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251016] New: Review Request: perl-CPAN-Releases-Latest - Find latest release of all distributions on CPAN
https://bugzilla.redhat.com/show_bug.cgi?id=1251016 Bug ID: 1251016 Summary: Review Request: perl-CPAN-Releases-Latest - Find latest release of all distributions on CPAN Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ppi...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ppisar.fedorapeople.org/perl-CPAN-Releases-Latest/perl-CPAN-Releases-Latest.spec SRPM URL: https://ppisar.fedorapeople.org/perl-CPAN-Releases-Latest/perl-CPAN-Releases-Latest-0.06-1.fc24.src.rpm Description: This Perl module constructs a list of all distributions on CPAN, by default using the MetaCPAN API. The generated index is cached locally. It will let you iterate over the index, either release by release, or distribution by distribution. Fedora Account System Username: ppisar -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251034] New: Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component
https://bugzilla.redhat.com/show_bug.cgi?id=1251034 Bug ID: 1251034 Summary: Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@famillecollet.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/95ca200ef1921153612e49a5edfaf9484320c8e3/php/zend/php-zendframework-zendpdf/php-zendframework-zendpdf.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-zendframework-zendpdf-2.0.2-1.remi.src.rpm Description: Zend Framework ZendPdf component. Fedora Account System Username: remi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251034] Review Request: php-zendframework-zendpdf - Zend Framework ZendPdf component
https://bugzilla.redhat.com/show_bug.cgi?id=1251034 Remi Collet fed...@famillecollet.com changed: What|Removed |Added Alias||zendframework/zendpdf -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246720] Review Request: nodejs-prismjs - Lightweight, robust, elegant syntax highlighting
https://bugzilla.redhat.com/show_bug.cgi?id=1246720 William Moreno williamjmore...@gmail.com changed: What|Removed |Added CC||williamjmore...@gmail.com Flags||needinfo?(i...@cicku.me) --- Comment #5 from William Moreno williamjmore...@gmail.com --- As part of the review of python-frappe the nodejs-prismjs was removed as a bundled js library, python-frappe it is usable without this package so nodeja-primsjs it is just about add some syntax highlighting, but will be nice is python-frappe it is avaible in the Alpha release of Fedora 23 with all the depencies ready to user than can try this app in fedora for the first time (Fedora will be the firts distro to ship frappe in repos). So, Christopher are you available to continue with this review or I can take it? I ran a informal review of the last spec posted by Eduardo and I did no fine bloquers issues. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 Seth Jennings spartacu...@gmail.com changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247747] Review Request: f23-backgrounds - Fedora 23 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1247747 Adam Williamson awill...@redhat.com changed: What|Removed |Added Blocks|1170817 | |(AlphaBlocker,F23AlphaBlock | |er) | Whiteboard|AcceptedBlocker | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1170817 [Bug 1170817] Fedora 23 Alpha blocker bug tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247747] Review Request: f23-backgrounds - Fedora 23 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1247747 Adam Williamson awill...@redhat.com changed: What|Removed |Added Blocks||1251242 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1251242 [Bug 1251242] Tracker: Fedora 23 desktops using Fedora 22 desktop backgrounds -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250344] Review Request: python-networking-cisco - Cisco OpenStack Neutron driver
https://bugzilla.redhat.com/show_bug.cgi?id=1250344 Haïkel Guémar karlthe...@gmail.com changed: What|Removed |Added Flags||fedora-cvs? --- Comment #7 from Haïkel Guémar karlthe...@gmail.com --- New Package SCM Request === Package Name: python-networking-cisco Short Description: Cisco OpenStack Neutron driver Upstream URL: https://pypi.python.org/pypi/networking-cisco Owners: hguemar bdemers Branches: f23 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] New: Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 Bug ID: 1251238 Summary: Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: spartacu...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://www.variantweb.net/pub/fedora/specs/yubioath-desktop.spec SRPM URL: https://www.variantweb.net/pub/fedora/22/source/SRPMS/yubioath-desktop-2.1.1-2.fc22.src.rpm Description: The Yubico Authenticator is a graphical desktop tool and CLI for generating Open AuTHentication (OATH) event-based HOTP and time-based TOTP one-time password codes, with the help of a YubiKey that protects the shared secrets. Fedora Account System Username spartacus06 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added Blocks||656997 (kde-reviews), ||1250206 (F23Blocker-kde) Alias||f23-kde-theme Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1250206 [Bug 1250206] Fedora 23 Blocker KDE Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251238] Review Request: yubioath-desktop - Yubikey tool for generating OATH tokens
https://bugzilla.redhat.com/show_bug.cgi?id=1251238 --- Comment #1 from Seth Jennings spartacu...@gmail.com --- Created attachment 1060060 -- https://bugzilla.redhat.com/attachment.cgi?id=1060060action=edit self-reporting fedora-review This is my first package submission so, afaict, I need a sponsor. Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10625020 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251247] New: Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1251247 Bug ID: 1251247 Summary: Review Request: f23-kde-theme - Fedora Twenty Three KDE Theme Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/f23-kde-theme/f23-kde-theme.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/f23-kde-theme/f23-kde-theme-23.0-1.fc22.src.rpm Description: Fedora Twenty Three KDE Theme Fedora Account System Username: rdieter scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=10625810 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1247747] Review Request: f23-backgrounds - Fedora 23 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1247747 Adam Williamson awill...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2015-08-06 14:56:44 --- Comment #16 from Adam Williamson awill...@redhat.com --- I split out the desktop-backgrounds part of this as https://bugzilla.redhat.com/show_bug.cgi?id=1251243 , for clarity. Closing this, as f23-backgrounds did land already. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Flags||fedora-review? ||fedora_requires_release_not ||e? fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] New: Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 Bug ID: 1251136 Summary: Review Request: qpid-tests - Conformance tests for Apache Qpid Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ibove...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: qpid-tests.spec (attached) SRPM URL: qpid-tests-0.32-1.el7.src.rpm (attached) Fedora Account System Username: irina -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1244196] Review Request: qt5-qtwebengine - Qt5 - QtWebEngine components
https://bugzilla.redhat.com/show_bug.cgi?id=1244196 --- Comment #10 from Kevin Kofler ke...@tigcc.ticalc.org --- Wow, another miracle, this time going on at Chromium upstream: https://chromium.googlesource.com/v8/v8/+log/master/src/interpreter (started 2 weeks ago, probably not usable yet). When done, and when it reaches (or is backported by us into) QtWebEngine, this will cover the secondary architectures, and through a similar setup as for QtDeclarative, non-SSE2 x86. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1168432] Review Request: python-PyMySQL - Pure-Python MySQL client library
https://bugzilla.redhat.com/show_bug.cgi?id=1168432 --- Comment #5 from Julien Enselme juj...@jujens.eu --- The spec looks great but you must use the %%license macro in %%files: Forgot to update that, sorry: SPEC: http://jenselme.perso.centrale-marseille.fr/visible/SPECS/python-PyMySQL.spec SRPMS: http://jenselme.perso.centrale-marseille.fr/visible/SRPMS/python-PyMySQL-0.6.6-4.fc22.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] New: Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 Bug ID: 1251134 Summary: Review Request: qpid-tools - Management and diagostic tools for Apache Qpid Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ibove...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: qpid-tools.spec (attached) SRPM URL: qpid-tools-0.32-1.el7.src.rpm (attached) Split from qpid-cpp package. Fedora Account System Username: irina -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 --- Comment #2 from Irina Boverman ibove...@redhat.com --- Created attachment 1059975 -- https://bugzilla.redhat.com/attachment.cgi?id=1059975action=edit source rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Flags||fedora-review? ||fedora_requires_release_not ||e? fedora-cvs? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Attachment||review? #1059973 Flags|| --- Comment #1 from Irina Boverman ibove...@redhat.com --- Created attachment 1059973 -- https://bugzilla.redhat.com/attachment.cgi?id=1059973action=edit Package spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Attachment||review? #1059976 Flags|| --- Comment #1 from Irina Boverman ibove...@redhat.com --- Created attachment 1059976 -- https://bugzilla.redhat.com/attachment.cgi?id=1059976action=edit Package spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 --- Comment #2 from Irina Boverman ibove...@redhat.com --- Created attachment 1059977 -- https://bugzilla.redhat.com/attachment.cgi?id=1059977action=edit source rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Flags|fedora-review? | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1045963] Review Request: ghc-gtk3 - Binding to the Gtk+ graphical user interface library
https://bugzilla.redhat.com/show_bug.cgi?id=1045963 --- Comment #15 from Jens Petersen peter...@redhat.com --- Dunno if you have seen the Haskell Packaging Guidelines: https://fedoraproject.org/wiki/Packaging:Haskell They explicitly mention that debuginfo is currently disabled. It might be good to add a similar explicit exception for the .so file naming to avoid such confusion, but given that there are no conventional symlinks, and ghc always names and links shared libraries by full name including version and ghc-version, there isn't really any problem here. And the package library subdirs are not in the ld path anyway. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193990] Review Request: opencity - Full 3D city simulator game project
https://bugzilla.redhat.com/show_bug.cgi?id=1193990 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- opencity-0.0.6.5-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/opencity-0.0.6.5-3.fc23 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250884] New: Review Request: future - Easy, clean, reliable Python 2/3 compatibility
https://bugzilla.redhat.com/show_bug.cgi?id=1250884 Bug ID: 1250884 Summary: Review Request: future - Easy, clean, reliable Python 2/3 compatibility Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: anto.tra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://sagitter.fedorapeople.org/future/future.spec SRPM URL: https://sagitter.fedorapeople.org/future/future-0.15.0-2.fc22.src.rpm Description: future is the missing compatibility layer between Python 2 and Python 3. It allows you to use a single, clean Python 3.x-compatible codebase to support both Python 2 and Python 3 with minimal overhead. It provides ``future`` and ``past`` packages with backports and forward ports of features from Python 3 and 2. It also comes with ``futurize`` and ``pasteurize``, customized 2to3-based scripts that helps you to convert either Py2 or Py3 code easily to support both Python 2 and 3 in a single clean Py3-style codebase, module by module. Fedora Account System Username: sagitter Note. 1- Package for Fedora, EPEL6, EPEL7 2- This packages provides PEM certificates in future/backports/test directory It's for testing purpose, i guess they can be ignored according to 'rpmlint' info. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250887] New: Review Request: preprocess - A portable multi-language file Python2 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1250887 Bug ID: 1250887 Summary: Review Request: preprocess - A portable multi-language file Python2 preprocessor Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: anto.tra...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://sagitter.fedorapeople.org/preprocess/preprocess.spec SRPM URL: https://sagitter.fedorapeople.org/preprocess/preprocess-1.2-1.20150629git30078c.fc22.src.rpm Description: There are millions of templating systems out there (most of them developed for the web). This isn't one of those, though it does share some basics: a markup syntax for templates that are processed to give resultant text output. The main difference with preprocess.py is that its syntax is hidden in comments (whatever the syntax for comments maybe in the target filetype) so that the file can still have valid syntax. A comparison with the C preprocessor is more apt. preprocess.py is targetted at build systems that deal with many types of files. Languages for which it works include: C++, Python, Perl, Tcl, XML, JavaScript, CSS, IDL, TeX, Fortran, PHP, Java, Shell scripts (Bash, CSH, etc.) and C#. Preprocess is usable both as a command line app and as a Python module. Fedora Account System Username: sagitter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250884] Review Request: future - Easy, clean, reliable Python 2/3 compatibility
https://bugzilla.redhat.com/show_bug.cgi?id=1250884 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Blocks||1250887 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1250887 [Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1250887 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Depends On||1250884 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1250884 [Bug 1250884] Review Request: future - Easy, clean, reliable Python 2/3 compatibility -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250833] Review Request:Helm - Software synth and lv2 plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 --- Comment #1 from j...@therobinsonfamily.net --- Scratch builds available on cop https://copr.fedoraproject.org/coprs/baggypants/helm-stable/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1243507] Review Request: perl-Algorithm-LUHN - Calculate the Modulus 10 Double Add Double checksum
https://bugzilla.redhat.com/show_bug.cgi?id=1243507 --- Comment #12 from Fedora Update System upda...@fedoraproject.org --- perl-Algorithm-LUHN-1.01-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/perl-Algorithm-LUHN-1.01-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Attachment||review? #1059990 Flags|| --- Comment #2 from Irina Boverman ibove...@redhat.com --- Created attachment 1059990 -- https://bugzilla.redhat.com/attachment.cgi?id=1059990action=edit Package spec file -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251136] Review Request: qpid-tests - Conformance tests for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251136 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Blocks||1251146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1251146 [Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package, add qpid-tools and qpid-tests packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1248103] Review Request: perl-qpid - Perl bindings for the Qpid messaging framework
https://bugzilla.redhat.com/show_bug.cgi?id=1248103 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2015-08-06 10:45:47 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246766] Review Request: golang-github-docker-libkv - Key/Value store abstraction library
https://bugzilla.redhat.com/show_bug.cgi?id=1246766 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 10:59:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246205] Review Request: golang-github-grpc-grpc-go - The Go language implementation of gRPC. HTTP/2 based RPC
https://bugzilla.redhat.com/show_bug.cgi?id=1246205 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 11:00:03 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245967] Review Request: golang-github-google-btree - BTree implementation for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1245967 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 11:01:37 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230227] Review Request: perl-HTTP-Headers-Fast - Faster implementation of HTTP::Headers
https://bugzilla.redhat.com/show_bug.cgi?id=1230227 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Status|NEW |ASSIGNED CC||ppi...@redhat.com Assignee|nob...@fedoraproject.org|ppi...@redhat.com Flags||fedora-review? --- Comment #1 from Petr Pisar ppi...@redhat.com --- URL and Source0 address are usable. Ok. Source archive is original (SHA-256: d7b397e2fc07cfb00c1d9a76ee790f07462a3b2cbeb5fc951dfeb134b0ada867). Ok. Summary verified from lib/HTTP/Headers/Fast.pm. Ok. Description verified from lib/HTTP/Headers/Fast.pm. OK. License verified from lib/HTTP/Headers/Fast.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok. TODO: You can remove the command for deleting empty directories in the %install section. FIX: Build-require `perl(CPAN::Meta)' (Build.PL:15). FIX: Build-require `perl(CPAN::Meta::Prereqs)' (Build.PL:16). FIX: Build-require `perl(File::Basename)' (Build.PL:13). FIX: Build-require `perl(strict)' (Build.PL:8). FIX: Build-require `perl(utf8)' (Build.PL:10). FIX: Build-require `perl(warnings)' (Build.PL:9). FIX: Build-require `perl(MIME::Base64)' (lib/HTTP/Headers/Fast.pm:466). FIX: Build-require `perl(Storable)' (lib/HTTP/Headers/Fast.pm:357). FIX: Build-require `perl(Test)' (t/headers.t:4). All tests pass. Ok. $ rpmlint perl-HTTP-Headers-Fast.spec ../SRPMS/perl-HTTP-Headers-Fast-0.17-1.fc24.src.rpm ../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm drwxr-xr-x2 rootroot0 Aug 6 17:04 /usr/share/doc/perl-HTTP-Headers-Fast -rw-r--r--1 rootroot 1565 Nov 14 2013 /usr/share/doc/perl-HTTP-Headers-Fast/Changes -rw-r--r--1 rootroot 2106 Nov 14 2013 /usr/share/doc/perl-HTTP-Headers-Fast/README.md drwxr-xr-x2 rootroot0 Aug 6 17:04 /usr/share/licenses/perl-HTTP-Headers-Fast -rw-r--r--1 rootroot18449 Nov 14 2013 /usr/share/licenses/perl-HTTP-Headers-Fast/LICENSE -rw-r--r--1 rootroot 2704 Aug 6 17:04 /usr/share/man/man3/HTTP::Headers::Fast.3pm.gz drwxr-xr-x2 rootroot0 Aug 6 17:04 /usr/share/perl5/vendor_perl/HTTP drwxr-xr-x2 rootroot0 Aug 6 17:04 /usr/share/perl5/vendor_perl/HTTP/Headers -rw-r--r--1 rootroot15132 Aug 6 17:04 /usr/share/perl5/vendor_perl/HTTP/Headers/Fast.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl = 0:5.00800 1 perl(:MODULE_COMPAT_5.22.0) 1 perl(Carp) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) = 3.0.4-1 1 rpmlib(FileDigests) = 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) = 4.0-1 1 rpmlib(PayloadIsXz) = 5.2-1 FIX: Run-require `perl(HTTP::Date)' (lib/HTTP/Headers/Fast.pm:365). FIX: Run-require `perl(MIME::Base64)' (lib/HTTP/Headers/Fast.pm:466). FIX: Run-require `perl(Storable)' (lib/HTTP/Headers/Fast.pm:357). $ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-Headers-Fast-0.17-1.fc24.noarch.rpm | sort -f | uniq -c 1 perl(HTTP::Headers::Fast) = 0.17 1 perl-HTTP-Headers-Fast = 0.17-1.fc24 Binary provides are Ok. Package builds in F24 (http://koji.fedoraproject.org/koji/taskinfo?taskID=10623584). Ok. Otherwise the package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' items, and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100 --- Comment #3 from Irina Boverman ibove...@redhat.com --- Created attachment 1059992 -- https://bugzilla.redhat.com/attachment.cgi?id=1059992action=edit source rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1230227] Review Request: perl-HTTP-Headers-Fast - Faster implementation of HTTP::Headers
https://bugzilla.redhat.com/show_bug.cgi?id=1230227 Petr Pisar ppi...@redhat.com changed: What|Removed |Added Blocks||1221832 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1221832 [Bug 1221832] perl-Dancer2-0.161000 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245618] Review Request: golang-github-bgentry-speakeasy - Golang helpers for reading password input without cgo
https://bugzilla.redhat.com/show_bug.cgi?id=1245618 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 10:58:52 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1245958] Review Request: golang-github-coreos-pkg - A collection of go utility packages
https://bugzilla.redhat.com/show_bug.cgi?id=1245958 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 11:02:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100 --- Comment #4 from Irina Boverman ibove...@redhat.com --- Attached revised spec file and source RPM. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1251134] Review Request: qpid-tools - Management and diagostic tools for Apache Qpid
https://bugzilla.redhat.com/show_bug.cgi?id=1251134 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Blocks||1251146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1251146 [Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package, add qpid-tools and qpid-tests packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1248100] Review Request: python-qpid - The Apache Qpid Python client library for AMQP.
https://bugzilla.redhat.com/show_bug.cgi?id=1248100 Irina Boverman ibove...@redhat.com changed: What|Removed |Added Blocks||1251146 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1251146 [Bug 1251146] Re-organise qpid-cpp package, un-retire python-qpid package, add qpid-tools and qpid-tests packages. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246740] Review Request: golang-github-mesos-mesos-go - Go language bindings for Apache Mesos
https://bugzilla.redhat.com/show_bug.cgi?id=1246740 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 10:59:41 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246033] Review Request: golang-github-bradfitz-http2 - HTTP/2 support for Go (in active development)
https://bugzilla.redhat.com/show_bug.cgi?id=1246033 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |RAWHIDE Last Closed||2015-08-06 11:00:29 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033797] Review Request: golang-labix-mgo - The mgo rich MongoDB driver for Go
https://bugzilla.redhat.com/show_bug.cgi?id=1033797 Lokesh Mandvekar l...@redhat.com changed: What|Removed |Added CC||fpoko...@redhat.com, ||jchal...@redhat.com --- Comment #13 from Lokesh Mandvekar l...@redhat.com --- Jan, Fridolin, could you please take care of this package too? :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1033798] Review Request: golang-launchpad-goyaml - YAML support for the Go language
https://bugzilla.redhat.com/show_bug.cgi?id=1033798 --- Comment #2 from Lokesh Mandvekar l...@redhat.com --- Jan, Fridolin, any idea if this package or one of its possible forks exist in fedora? Or else, we'll need to review, approve and close this :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246974] Review Request: rubygem-shortURL - very simple library to use URL shortening services.
https://bugzilla.redhat.com/show_bug.cgi?id=1246974 --- Comment #2 from Ilya Gradina ilya.grad...@gmail.com --- In section %check no tests, see here - [1]. ( in this case will - add BuildRequires: rubygem(rspec) and in %check add rspec -Ilib spec ). Also see output rpmlint: 1) summary-too-long 2) in URL: beter use https: ... . ( https://github.com/robbyrussell/shorturl , without the latter / .) 3) %description and Summary in en_US format. See examples rubygem-* spec file in [2]. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Testing_frameworks_usage [2] http://pkgs.fedoraproject.org/cgit/?q=rubygem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1246974] Review Request: rubygem-shortURL - very simple library to use URL shortening services.
https://bugzilla.redhat.com/show_bug.cgi?id=1246974 Igor Gnatenko i.gnatenko.br...@gmail.com changed: What|Removed |Added CC||i.gnatenko.br...@gmail.com --- Comment #3 from Igor Gnatenko i.gnatenko.br...@gmail.com --- (In reply to Ilya Gradina from comment #2) In section %check no tests, see here - [1]. ( in this case will - add BuildRequires: rubygem(rspec) and in %check add rspec -Ilib spec ). Also see output rpmlint: 1) summary-too-long What does it means? Where to read about? 2) in URL: beter use https: ... . ( https://github.com/robbyrussell/shorturl , without the latter / .) 3) %description and Summary in en_US format. What does it means? Where to read about? See examples rubygem-* spec file in [2]. [1] https://fedoraproject.org/wiki/Packaging:Ruby#Testing_frameworks_usage [2] http://pkgs.fedoraproject.org/cgit/?q=rubygem -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250344] Review Request: python-networking-cisco - Cisco OpenStack Neutron driver
https://bugzilla.redhat.com/show_bug.cgi?id=1250344
Alan Pevec ape...@gmail.com changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
|needinfo?(ape...@gmail.com) |
--- Comment #5 from Alan Pevec ape...@gmail.com ---
So Vendor thing is a bug in fedora-review, actually!
Either way, %{driver} as macro name is better, it might not always be a
particular vendor behind the driver.
rpmlint also complains about gid neutron and perms 640 on config files but
those are correct.
But please, before import replace TAB in line 28 and make version in changelog
match Version: field, to indulge nitpickers like me.
More nitpicks:
* %{python2_sitelib}/%{srcname}-%{version}-py%{python2_version}.egg-info hurts
to read, why not simply:
%{python2_sitelib}/*.egg-info
?
* use pypi URL instead of tarballs.o.o ?
* SKIP_PIP_INSTALL=1 won't prevent including requirements.txt into egginfo, we
still need rm -rf {test-,}requirements.txt in %prep but that can be a followup.
APPROVED
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package must own all directories that it creates.
Note: /etc/neutron is owned by openstack-neutron-common in Requires
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
Note: please fix W: incoherent-version-in-changelog 2015.1.2-1 before
import
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
Note: Documentation size is 266240 bytes in 38 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: rpmlint commented at the top.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package
[Bug 1247747] Review Request: f23-backgrounds - Fedora 23 default desktop background
https://bugzilla.redhat.com/show_bug.cgi?id=1247747 Lukas Brabec lbra...@redhat.com changed: What|Removed |Added CC||lbra...@redhat.com --- Comment #14 from Lukas Brabec lbra...@redhat.com --- Just tested this on KDE. On login screen, there is F23 background, but after logging in, the desktop shows the old one. I checked /usr/share/backgrounds and the wallpaper is there. Workspace theme settings contains F22 theme but there is no F23 theme. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250884] Review Request: future - Easy, clean, reliable Python 2/3 compatibility
https://bugzilla.redhat.com/show_bug.cgi?id=1250884 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Hardware|All |noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1250887] Review Request: preprocess - A portable multi-language file Python2 preprocessor
https://bugzilla.redhat.com/show_bug.cgi?id=1250887 Antonio Trande anto.tra...@gmail.com changed: What|Removed |Added Hardware|All |noarch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193990] Review Request: opencity - Full 3D city simulator game project
https://bugzilla.redhat.com/show_bug.cgi?id=1193990 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1193990] Review Request: opencity - Full 3D city simulator game project
https://bugzilla.redhat.com/show_bug.cgi?id=1193990 --- Comment #11 from Fedora Update System upda...@fedoraproject.org --- opencity-0.0.6.5-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/opencity-0.0.6.5-3.fc22 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1102942] Review Request: php-phpoffice-phpexcel - A pure PHP library for reading and writing spreadsheet files
https://bugzilla.redhat.com/show_bug.cgi?id=1102942 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #7 from Tom spot Callaway tcall...@redhat.com --- The use of the trademark excel is nominative here, since we are using it in a minimal way to describe this applications support and manipulation of the excel file format. Thus, the use is considered fair use and appropriate. Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1249271] Review Request: nodejs-unzip-response - Unzip a HTTP response if needed
https://bugzilla.redhat.com/show_bug.cgi?id=1249271 Fedora Update System upda...@fedoraproject.org changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System upda...@fedoraproject.org --- nodejs-unzip-response-1.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
[Bug 1242723] Review Request: perl-Alien-Packages - Find information of installed packages
https://bugzilla.redhat.com/show_bug.cgi?id=1242723 --- Comment #3 from Tim Orling ticot...@gmail.com --- Spec URL: https://ttorling.fedorapeople.org/perl-Alien-Packages/perl-Alien-Packages.spec SRPM URL: https://ttorling.fedorapeople.org/perl-Alien-Packages/perl-Alien-Packages-0.003-2.fc23.src.rpm Git URL: https://fedorapeople.org/cgit/ttorling/public_git/perl-Alien-Packages.git/ koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=10623630 copr: https://copr.fedoraproject.org/coprs/ttorling/perl-meta-cpan-support/build/107329/ It appears Module::Pluggable is not not in EPEL6 Filed issue on CPAN for LICENSE file: https://rt.cpan.org/Ticket/Display.html?id=106272 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/package-review
