[Bug 1276114] Review Request: nodejs-generate-object-property - Generate safe JS code that can used to reference a object property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276114



--- Comment #2 from Piotr Popieluch  ---
Thanks, updated

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269964] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

Summary|Rebase clufter package  |Rebase clufter component



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #25 from Fedora Update System  ---
dssp-2.2.1-6.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-a0e26542e3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #23 from Fedora Update System  ---
dssp-2.2.1-6.el5 has been submitted as an update to Fedora EPEL 5.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1a8dc2d36d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203749

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276161] Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276161



--- Comment #1 from Upstream Release Monitoring 
 ---
jplesnik's scratch build of perl-SQL-SplitStatement-1.00020-2.fc22.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11624840

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #26 from Fedora Update System  ---
dssp-2.2.1-6.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-1148a3ae68

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276108] Review Request: nodejs-generate-function - Module that helps you write generated functions in Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276108



--- Comment #3 from Piotr Popieluch  ---
Yes, I took release+one commit to have the license included.

I've updated for option 2.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276161] Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276161

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort |
uniq -c
  1 /usr/bin/env
  1 perl(:MODULE_COMPAT_5.22.0)
  1 perl(Carp)
  1 perl(Class::Accessor::Fast)
  1 perl(Getopt::Long)
  1 perl(List::MoreUtils)
  1 perl(Pod::Usage)
  1 perl(Regexp::Common)
  1 perl(SQL::SplitStatement)
  1 perl(SQL::Tokenizer) >= 0.22
  1 perl(base)
  1 perl(constant)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-SQL-SplitStatement-1.00020-2.fc24.noarch.rpm | sort |
uniq -c
  1 perl(SQL::SplitStatement) = 1.00020
  1 perl-SQL-SplitStatement = 1.00020-2.fc24
Binary provides are Ok.

$ rpmlint perl-SQL-SplitStatement*
perl-SQL-SplitStatement.noarch: E: incorrect-fsf-address
/usr/share/licenses/perl-SQL-SplitStatement/LICENSE
2 packages and 1 specfiles checked; 1 errors, 0 warnings.

Invalid address was reported to upstream.
Otherwise rpmlint is ok.

BuildRequires need to be updated
FIX: Please add BRs
* perl(base) - lib/SQL/SplitStatement.pm:10
* perl(File::Find) - SQL-SplitStatement-2.00020/t/00-compile.t:10
* perl(strict) - Makefile.PL and tests
* perl(warnings) - Makefile.PL and tests
* Add version constrain to perl(SQL::Tokenizer) >= 0.22

Description
TODO: this part of Description should be changed "(for the details see the 
  "SUPPORTED DBMSs" section below)", because the section is part of man
  page not Description

Please correct all 'FIX' issues and consider fixing 'TODO' item

Otherwise, the package looks good
Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Oded Gabbay  changed:

   What|Removed |Added

  Flags|needinfo?(ogab...@redhat.co |
   |m)  |



--- Comment #9 from Oded Gabbay  ---
I can fix everything, however the last item involves fixing the tar file
itself, which I don't want to do at this point.

Can we continue with fixing all of your remarks except the last one
(configure.ac), and I'll fix it upstream so next release it will be fixed in
Fedora as well ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265329] Review Request: nodejs-parse-json - Parse JSON with more helpful errors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265329

Parag Nemade  changed:

   What|Removed |Added

  Flags|needinfo?(pnem...@redhat.co |
   |m)  |



--- Comment #3 from Parag Nemade  ---
Thanks for the above review. I have fixed this license tag in below update

Spec URL: http://pnemade.fedorapeople.org/fedora-work/nodejs-parse-json.spec
SRPM URL:
http://pnemade.fedorapeople.org/fedora-work/nodejs-parse-json-2.2.0-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276111] Review Request: nodejs-is-property - Tests if a json property can be safely accessed using the .syntax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276111



--- Comment #3 from Piotr Popieluch  ---
I've created a github issue:
https://github.com/mikolalysenko/is-property/issues/3

Not sure what to do with this, the whole module seems to be a generated regex
oneliner.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1203749] Review Request: dssp - Protein secondary structure assignment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1203749



--- Comment #24 from Fedora Update System  ---
dssp-2.2.1-6.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-add531b6f0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276161] Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276161

Emmanuel Seyman  changed:

   What|Removed |Added

  Flags||fedora-cvs?



--- Comment #3 from Emmanuel Seyman  ---
(In reply to Jitka Plesnikova from comment #2):
> 
> BuildRequires need to be updated
> FIX: Please add BRs

Done.

> TODO: this part of Description should be changed "(for the details see the 
>   "SUPPORTED DBMSs" section below)", because the section is part of man
>   page not Description

Indeed. Done.

> Please correct all 'FIX' issues and consider fixing 'TODO' item

Spec URL:
http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-SplitStatement.spec
SRPM URL:
http://people.parinux.org/~seyman/fedora/perl-SQL-SplitStatement/perl-SQL-SplitStatement-1.00020-3.fc22.src.rpm

> Package APPROVED.

Thank you, Jikta. SCM request made.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268372] Review Request: openstack-app-catalog-ui - openstack horizon plugin for the openstack app-catalog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268372

Matthias Runge  changed:

   What|Removed |Added

  Flags||needinfo?(ape...@gmail.com)



--- Comment #18 from Matthias Runge  ---
I'd approve this package, it looks sane to me.

Thank you for your patience, Kevin.

Alan, how to proceed from here now? There is no flag to set, if it was a fedora
review, I'd approve the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690



--- Comment #4 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-37a556f5a6

--- Comment #5 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.fc22 has been submitted as an update to Fedora
22. https://bodhi.fedoraproject.org/updates/FEDORA-2015-17b4a7f2e6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690



--- Comment #4 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.fc23 has been submitted as an update to Fedora
23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-37a556f5a6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1260575] Review Request: python-ordered-set - A Custom MutableSet that remembers its order

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1260575



--- Comment #21 from Fedora Update System  ---
python-ordered-set-1.3.1-4.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1079090] Review Request: layla-fonts - A collection of traditional Arabic fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1079090



--- Comment #66 from Fedora Update System  ---
layla-fonts-1.5-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690



--- Comment #6 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.el5 has been submitted as an update to Fedora
EPEL 5. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-b7f714a161

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690



--- Comment #3 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.el6 has been submitted as an update to Fedora
EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1d8f08342b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274690] Review Request: nordugrid-arc-gangliarc - Ganglia monitoring for ARC services

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274690

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



--- Comment #3 from Fedora Update System  ---
nordugrid-arc-gangliarc-1.0.0-2.el6 has been submitted as an update to Fedora
EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2015-1d8f08342b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264546] Review Request: soletta - A framework for making IoT devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264546



--- Comment #49 from Gustavo Lima Chaves  ---
> I think we are almost done with the review. I would like to have
> an extra comment about my question about if you have an ETA for
> a stable release. For safety, in case you choose to call the
> first official release 0.0.1 it would be better to change back
> to Release: 0.1.%{soletta_tag}%{?dist} - but really, pre releases
> are avoided as official packages :) Not only for this reason, but
> due to not having a somewhat long lived, common release, so that
> people talk about the same thing :)

Hi, Paulo. For me it's also more reasonable to push the RPM release button
starting from our actual 1st (not pre) release, so let's work with that.
For the next iteration here, that might happen before our upstream release,
disregard the beta tags, which will vanish in sequence. I'll work on
the remaining issues and help with dev here and soon I'll come back
with updates. Thanks a lot, Paulo and Michael!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978



--- Comment #11 from Oded Gabbay  ---
Uploaded new spec and srpm files.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1123511] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123511



--- Comment #12 from Upstream Release Monitoring 
 ---
cleaver's scratch build of nanomsg-0.7-0.1.beta.fc20.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11629931

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #10 from Luya Tshimbalanga  ---
(In reply to Oded Gabbay from comment #9)
> Can we continue with fixing all of your remarks except the last one
> (configure.ac), and I'll fix it upstream so next release it will be fixed in
> Fedora as well ?

Sur you can. Please post the updated spec and srpm so I can continue reviewing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|l...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276161] Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276161



--- Comment #4 from Jon Ciesla  ---
This SCM request method has been deprecated. Please see
https://fedoraproject.org/wiki/PackageDB_admin_requests.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||needinfo?(ogab...@redhat.co
   ||m)



--- Comment #12 from Luya Tshimbalanga  ---
(In reply to Oded Gabbay from comment #11)
> Uploaded new spec and srpm files.

URL?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Oded Gabbay  changed:

   What|Removed |Added

  Flags|needinfo?(ogab...@redhat.co |
   |m)  |



--- Comment #13 from Oded Gabbay  ---
oh, the same one.
Spec URL: http://people.freedesktop.org/~gabbayo/hsakmt/hsakmt.spec
SRPM URL:
http://people.freedesktop.org/~gabbayo/hsakmt/hsakmt-1.0.0-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978



--- Comment #14 from Luya Tshimbalanga  ---
Hmm, I don't see the fix within the spec file. Perhaps you mistakenly sent the
old version.

Could you bump also the srpm to 1.0.0-2 reflecting the change? Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269609] Review Request: ari-backup - A wrapper around rdiff-backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269609

Richard Shaw  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Docs Contact||hobbes1...@gmail.com
  Flags||fedora-review?



--- Comment #17 from Richard Shaw  ---
Alright, I'm formally taking the review now.

Have you already done a self introduction on the devel list? It's pretty much
required to be subscribed as a packager. 

I think we've gotten the package in pretty good shape, however I think it would
be a good idea to ask on the fedora devel mailing list about the permissions
just to make sure there's no unwanted side effects that we can't think of.

Perhaps kill two birds with one stone.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate authority

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215478

Till Maas  changed:

   What|Removed |Added

 CC||opensou...@till.name
 Depends On||998103, 1198473




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=998103
[Bug 998103] python-dialog-3.3.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1198473
[Bug 1198473] Review Request: python-configargparse - A Python module with
support for argparse, config files, and env variables
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275391] Review Request: wbar - A quick launch bar

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275391



--- Comment #4 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of wbar-2.3.4-1.fc21.src.rpm for rawhide
completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11630491

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274645] Review Request: python-faker - Faker is a Python package that generates fake data for you

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274645



--- Comment #4 from William Moreno  ---
Looks good

Consider to build the documentation files your selft and include it as Source1
and then just copy it in the BuildRoot, also this documentation must be in a
-docs subpackage.

Upstream provides some test in the tarball, after %%install run this check in
the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269609] Review Request: ari-backup - A wrapper around rdiff-backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269609

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275057] Review Request: python-appstream - Parse AppStream files when you don't have libappstream-glib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275057



--- Comment #5 from Ralph Bean  ---
Latest upstream, with some bugfixes:

Spec URL: http://threebean.org/rpm/SPECS/python-appstream.spec
SRPM URL: http://threebean.org/rpm/SRPMS/python-appstream-0.5-1.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978



--- Comment #16 from Upstream Release Monitoring 
 ---
luya's scratch build of hsakmt-1.0.0-2.fc22.src.rpm for f23 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11630452

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275057] Review Request: python-appstream - Parse AppStream files when you don't have libappstream-glib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275057



--- Comment #6 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-appstream-0.5-1.fc22.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11630504

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1198473] Review Request: python-configargparse - A Python module with support for argparse, config files, and env variables

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1198473

Till Maas  changed:

   What|Removed |Added

 Blocks||1215478




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1215478
[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate
authority
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272669] Review Request: nodejs-pify - Promisify a callback-style function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272669

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #17 from Luya Tshimbalanga  ---
Here is the  review, I will ignore the obsolete macro case as you, upstream,
will fix on the next release.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in hsakmt-
 devel (it is safe to remove that line on the spec file)
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
[-]: Description and summary sections in the package spec 

[Bug 1123511] Review Request: nanomsg - A fast, scalable, and easy to use socket library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1123511

Japheth Cleaver  changed:

   What|Removed |Added

  Flags|needinfo?(cleaver-redhat@te |
   |rabithia.org)   |



--- Comment #13 from Japheth Cleaver  ---
(In reply to Upstream Release Monitoring from comment #12)
> cleaver's scratch build of nanomsg-0.7-0.1.beta.fc20.src.rpm for rawhide
> completed http://koji.fedoraproject.org/koji/taskinfo?taskID=11629931

The "Currently fails checks: https://github.com/nanomsg/nanomsg/issues/281;
line should be removed from the .spec file (since it now passes fine, so long
as LD_LIBRARY_PATH is specified), and the dist tag indicates this was a rebuild
of an f20 SRPM, however the functionality and file list should be correct.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269609] Review Request: ari-backup - A wrapper around rdiff-backup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269609

William Moreno  changed:

   What|Removed |Added

 CC|williamjmore...@gmail.com   |
   Assignee|williamjmore...@gmail.com   |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978



--- Comment #15 from Oded Gabbay  ---
done.
Here are the new links:
Spec URL: http://people.freedesktop.org/~gabbayo/hsakmt/hsakmt.spec
SRPM URL:
http://people.freedesktop.org/~gabbayo/hsakmt/hsakmt-1.0.0-2.fc22.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268380] Review Request: python-sphinx-theme-bootstrap - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #5 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of
python-sphinx-theme-bootstrap-0.4.5-3.fc22.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=11630477

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272669] Review Request: nodejs-pify - Promisify a callback-style function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272669



--- Comment #4 from Fedora Update System  ---
nodejs-pify-2.2.0-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-59c4908f31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276108] Review Request: nodejs-generate-function - Module that helps you write generated functions in Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276108



--- Comment #5 from Piotr Popieluch  ---
Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1218758] Review Request: flmsg - Fast Light Message Amateur Radio Forms Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1218758



--- Comment #13 from Richard Shaw  ---
Chris, do you see the security issue as a blocker? I suppose I could post the
question to the devel list and get some feedback.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276108] Review Request: nodejs-generate-function - Module that helps you write generated functions in Node

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276108

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tom Hughes  ---
Looks good now. Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1272669] Review Request: nodejs-pify - Promisify a callback-style function

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1272669



--- Comment #3 from Fedora Update System  ---
nodejs-pify-2.2.0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2015-93efc5a2c3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274996] Review Request: nodejs-isstream - Determine if an object is a Stream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274996

Jared Smith  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275391] Review Request: wbar - A quick launch bar

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275391



--- Comment #5 from William Moreno  ---
Are you going to epel5? If not, there is no need of rm -rf $RPM_BUILD_ROOT in
%%install.

Note than the current spec build fine in epel6, epel7 and current Fedora:
http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131391/

Where is the license file? You must use the %license macro to handle the
COPYING file in the tarball. Note than for epel6 you need to define the
%license macro in %%files with 

%files 
%{!?_licensedir:%global license %%doc}
%license COPYING

Where are the docs files? You must use the %doc macro to handle the AUTHORS
ChangeLog INSTALL README NEWS THANKS and TODO files in the tarball.

Consider to create a -docs subpackage.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1107127] Review Request: procenv - Utility to show process environment

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1107127



--- Comment #25 from James Hunt  ---
How does this look?

https://jamesodhunt.fedorapeople.org/packages/procenv/procenv.spec
https://jamesodhunt.fedorapeople.org/packages/procenv/procenv-0.41-1.fc23.src.rpm
https://jamesodhunt.fedorapeople.org/packages/procenv/procenv-0.41.tar.gz
https://jamesodhunt.fedorapeople.org/packages/procenv/SHA512SUM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1246761] Review Request: libqtelegram-ae - Qt Telegram API wrapper library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246761



--- Comment #9 from William Moreno  ---
The changelog must be - 6.0-1 and not just - 6.0

I am fine with this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1246761] Review Request: libqtelegram-ae - Qt Telegram API wrapper library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1246761

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from William Moreno  ---
Package Aproved


-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275057] Review Request: python-appstream - Parse AppStream files when you don't have libappstream-glib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275057



--- Comment #9 from William Moreno  ---
Sorry for the last to comments, I was looking at the 0.2 version.

I am working with the 0.5 versión but now the epel6 fails in check:
http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131408/

The problem is with %%check again:
+ python test.py
Traceback (most recent call last):
  File "test.py", line 147, in 

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275057] Review Request: python-appstream - Parse AppStream files when you don't have libappstream-glib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275057



--- Comment #7 from William Moreno  ---
This package it is only for epel6? Or you are goint to build for Fedora and
Epel7?

It may be usefull in Fedora, but Python Packaging Guidelines for Fedora have
changed a lot from epel6.

If you are to build for Fedora at less consider:

1- Use the $%license macro and define it in %%files for epel6 with:
%{!?_licensedir:%global license %%doc}
%license LICENSE

2- Use a %if 0%{?fedora} conditional to build a python2-appstream and use the
python-provides macro.

3- In %%files use a %if 0%{?rhel} && 0%{?rhel} <= 6 to create the
python-appstream rpm and use a %if 0%{?fedora} to create the python2-appstream
rpm.

In the other hand this spec build fine in epel6 but fails in the others build.

http://copr.fedoraproject.org/coprs/williamjmorenor/fedora-review-test/build/131404/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275057] Review Request: python-appstream - Parse AppStream files when you don't have libappstream-glib

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275057



--- Comment #8 from William Moreno  ---
Epel7 and Fedora Builds all then fails in %%chech with python2.7 the check pass
fine with python2.6 in epel6, will yoo go only for epel6?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268380] Review Request: python-sphinx-theme-bootstrap - A sphinx theme that integrates the Bootstrap framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268380



--- Comment #6 from William Moreno  ---
Please post the last versión of the spec and the src.rpm tin this formats:

Spec URL:
SRPM URL:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags|fedora-review+  |fedora-review?



--- Comment #18 from Luya Tshimbalanga  ---
One more thing, considering that hsakmt is a library, would you rename the
package as libhsakmt to be consistent on Fedora repository? The source tarball
does not need renaming, only the spec and srpm. Once it is done, I will set as
APPROVED. Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 807432] Review Request: python-tate-bilinear-pairing - A Python 2/3 library for calculating Tate bilinear pairing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=807432

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||needinfo?(philip.worrall@go
   ||oglemail.com)



--- Comment #13 from William Moreno  ---
Do you want to continue with this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1187082] Review Request: python-slowaes - An Implementation of AES in python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187082

William Moreno  changed:

   What|Removed |Added

 CC||gy...@fsfe.org,
   ||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||needinfo?(gy...@fsfe.org)



--- Comment #6 from William Moreno  ---
Do you want to continue this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1201338] Review Request: python-uniseg - A pure Python module to determine Unicode text segmentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1201338

William Moreno  changed:

   What|Removed |Added

 CC||muri...@br.ibm.com,
   ||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||needinfo?(muri...@br.ibm.co
   ||m)



--- Comment #3 from William Moreno  ---
Do you want to continue this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1205479] Review Request: python-morris - An announcement (signal/event) system for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1205479

William Moreno  changed:

   What|Removed |Added

 CC||williamjmore...@gmail.com
   Assignee|nob...@fedoraproject.org|williamjmore...@gmail.com
  Flags||needinfo?(m...@zygoon.pl)



--- Comment #6 from William Moreno  ---
Do you want to continue with this review?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268697] Review Request: color - colorize text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268697



--- Comment #3 from Austin Dunn  ---
(In reply to Christopher Meng from comment #1)
> What's the homepage of this software?
> 
> And can you avoid short name like this? This only indicates that upstream is
> too lazy.

There is currently no homepage for the package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268372] Review Request: openstack-app-catalog-ui - openstack horizon plugin for the openstack app-catalog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268372



--- Comment #16 from Matthias Runge  ---
flake8 is not used during build, pleae remove it as well

I would use truncate -s 0 {test-,}requirements.txt 
instead of removing that files

Otherwise looks good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate authority

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215478



--- Comment #14 from Nikos Mavrogiannopoulos  ---
To add this in Fedora we certainly need a packager who is able to follow up
with the package. I'm willing to review this, or any other review request if we
have that.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978



--- Comment #7 from Oded Gabbay  ---
Because you are using a wrong link.
It's not
https://wiki.freedesktop.org/xorg/archive/individual/lib/hsakmt-1.0.0.tar.bz2

It's http://xorg.freedesktop.org/archive/individual/lib/hsakmt-1.0.0.tar.bz2

The 404 error you get is because that link is wrong and it can't find the file
to download.

I downloaded the file from the correct link and compared sha256sum to the tar
inside the srpm and they are identical

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1215478] Review Request: lets-encrypt - A free, automated certificate authority

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1215478



--- Comment #13 from Jakub Warmuz  ---
I would like to point out that Let's Encrypt team strongly suggests using
tarballs from PyPI and not git master.
https://github.com/letsencrypt/letsencrypt/wiki/Packaging

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084

Carl van Tonder  changed:

   What|Removed |Added

 CC||c...@supervacuo.com



--- Comment #7 from Carl van Tonder  ---
Uploaded electrum-2.5.1-1.fc23.src.rpm to COPR if that's of help to anyone:

https://copr.fedoraproject.org/coprs/seeitcoming/electrum/

i.e. Samuel's .spec file seems to work fine for later versions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274645] Review Request: python-faker - Faker is a Python package that generates fake data for you

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274645



--- Comment #3 from Juan Orti  ---
Hi, thanks for taking this review.

I've updated the spec according your suggestions, I have also opened a bug to
ask upstream about the documentation problem:
https://github.com/joke2k/faker/issues/291

Spec URL: https://jorti.fedorapeople.org/python-faker/python-faker.spec
SRPM URL:
https://jorti.fedorapeople.org/python-faker/python-faker-0.5.3-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276114] Review Request: nodejs-generate-object-property - Generate safe JS code that can used to reference a object property

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276114

Jared Smith  changed:

   What|Removed |Added

 CC||jsmith.fed...@gmail.com
   Assignee|nob...@fedoraproject.org|jsmith.fed...@gmail.com
  Flags||fedora-review?



--- Comment #1 from Jared Smith  ---
You're missing a BuildRequires on npm(tape).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270322] Review Request: chromium - A WebKit (Blink) powered web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270322



--- Comment #12 from Christopher Meng  ---
(In reply to Tom "spot" Callaway from comment #11)
> (In reply to Christopher Meng from comment #10)
> > (In reply to Neal Gompa from comment #6)
> > > From what I've observed, the usage of Chrome is pretty much because we 
> > > don't
> > > provide Chromium.
> > 
> > That's just your notion. Google provides RPMs for i386 while this chromium
> > only has ExclusiveArch x86_64.
> 
> Enabling support for i386 is incredibly painful, though, now that there is
> support for shared library components again, possibly less so. The biggest
> issue will be getting the nacl/pnacl toolchains working on i386. I wonder
> whether the 6 people still using ia32-only hardware even care.

You won't need to care about i686 after CentOS 6/7 reaching their EOL. Now the
fact is, vendor doesn't want to support ix86 while increasing the burden to
downstream. I have to say I agree with Red Hat's decision but also big thanks
to Google to let me still have ability to enjoy the Internet without Mozilla
crapfox.

NaCl is a serious issue indeed, I'm not sure if Fedora has loosened the
guideline, but it's a blocker of this package, and solving this is not easy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1274978] Review Request: hsakmt - Thunk library for amdkfd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1274978

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||needinfo?(ogab...@redhat.co
   ||m)



--- Comment #8 from Luya Tshimbalanga  ---
(In reply to Oded Gabbay from comment #7)
> Because you are using a wrong link.
> It's not
> https://wiki.freedesktop.org/xorg/archive/individual/lib/hsakmt-1.0.0.tar.bz2
> 
> It's http://xorg.freedesktop.org/archive/individual/lib/hsakmt-1.0.0.tar.bz2

It turned out HTTPS Everywhere extenision for Firefox caused the 404 error by
replacing http with https. Disable it led me to get the tarball. 

---
Looking at the spec files, could you fix the following:

- Package uses either %{buildroot} or $RPM_BUILD_ROOT on that following line

> make install DESTDIR=$RPM_BUILD_ROOT
>
> find %{buildroot} -type f -name "*.la" -delete


I will personally suggest using %{buildroot} for consistency



- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file COPYING is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text



- According to license check from fedora-review script, hsakmt source tarball
has two licenses which should be reflected on the spec file:

GPL (v2 or later)
-
hsakmt-1.0.0/ltmain.sh

MIT/X11 (BSD like)
--
hsakmt-1.0.0/COPYING
hsakmt-1.0.0/hsakmt/debug.c
hsakmt-1.0.0/hsakmt/events.c
hsakmt-1.0.0/hsakmt/fmm.c
hsakmt-1.0.0/hsakmt/fmm.h
hsakmt-1.0.0/hsakmt/globals.c
hsakmt-1.0.0/hsakmt/hsakmt-version.h.in
hsakmt-1.0.0/hsakmt/include/hsakmt.h
hsakmt-1.0.0/hsakmt/include/hsakmttypes.h
hsakmt-1.0.0/hsakmt/include/linux/kfd_ioctl.h
hsakmt-1.0.0/hsakmt/libhsakmt.h
hsakmt-1.0.0/hsakmt/memory.c
hsakmt-1.0.0/hsakmt/openclose.c

--
- AutoTools result from fedora-review script: Obsoleted m4s found
--
  AC_PROG_LIBTOOL found in: hsakmt-1.0.0/configure.ac:70 is replaced by 
LT_INIT. See https://fedorahosted.org/FedoraReview/wiki/AutoTools for details

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1268372] Review Request: openstack-app-catalog-ui - openstack horizon plugin for the openstack app-catalog

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1268372



--- Comment #17 from Kevin Fox  ---
Hi Matthias,

Thanks for the review. I've included the changes. Please find the revisions
below:

Spec URL: http://efox.cc/temp/openstack-app-catalog-ui.spec
SRPM URL:
https://kojipkgs.fedoraproject.org//work/tasks/3823/11623823/openstack-app-catalog-ui-1.0.0-1.fc24.src.rpm
Description: This package provides an OpenStack Horizon plugin to allow easy
access to assets stored in the OpenStack App Catalog.
Fedora Account System Username: kfox

Thanks,
Kevin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1276161] Review Request: perl-SQL-SplitStatement - Split any SQL code into atomic statements

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276161

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1275411] Review Request: Sublime Text 3 - Text editor Sublime Text 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1275411

Robin Lee  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 CC||robinlee.s...@gmail.com
 Resolution|--- |CANTFIX
Last Closed||2015-10-29 21:37:39



--- Comment #1 from Robin Lee  ---
Only software with a 'good license' can be included in official Fedora.
https://fedoraproject.org/wiki/Licensing:Main

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review