[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #16 from Jan Chaloupka  ---
> I can't import "github.com/projectatomic/oci-register-machine" with the devel
> package installed -- I get a 'import 
> "github.com/projectatomic/oci-register-machine"
> is a program, not an importable package' error.  Were the reusable bits
> supposed to be broken out into an oci-register-machine package and called
> from main()?  If so, then the compiler won't accept "oci-register-machine"
> as a package name, and this will affect the Provides: in the devel package.

Sally, if the devel subpackage will contain only files with 'package main'
directive, nothing from the subpackage can not be imported. Either set
with_devel to 0 or break oci-register-machine.go into to files so there is at
least one file with 'package oci-register-machine' directive.

> If %{with_bundled} is set to 1, it'll lose the BuildRequires: on
> golang(github.com/godbus/dbus), and it isn't carrying a vendored copy,
> so the build would fail.

This is useful for future use when vendor or Godeps directory are present. At
the current state it does not make sense to set with_bundled to 1.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301268] Review Request: python-netdiff - Python library for parsing network topology data (eg: dynamic routing protocols, NetJSON, CNML) and detect changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301268

Germano Massullo  changed:

   What|Removed |Added

 Depends On||1302770




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302770
[Bug 1302770] Review Request: python-coveralls - Coveralls.io is service to
publish your coverage stats online with a lot of nice features
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302770] New: Review Request: python-coveralls - Coveralls.io is service to publish your coverage stats online with a lot of nice features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302770

Bug ID: 1302770
   Summary: Review Request: python-coveralls - Coveralls.io is
service to publish your coverage stats online with a
lot of nice features
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: germano.massu...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: fa...@locati.cc, ke...@tigcc.ticalc.org,
package-review@lists.fedoraproject.org
Blocks: 1301268



Spec URL:
https://fedorapeople.org/~germano/package_reviews/python-coveralls/python-coveralls.spec

Fedora Account System Username: germano
GPG key id: 50EDA884
EsteID (DIGI-ID E-RESIDENT) serial number 38601270070

I cannot post a src.rpm file because I obtain error message:
<>
and I cannot find where the problem is.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1301268
[Bug 1301268] Review Request: python-netdiff - Python library for parsing
network topology data (eg: dynamic routing protocols, NetJSON, CNML) and
detect changes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302809] New: Review Request: ne - ne, the nice editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302809

Bug ID: 1302809
   Summary: Review Request: ne - ne, the nice editor
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: bthoma...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/bthomas/ne/ne.git/tree/ne.spec?id=2b507b12e4a1a6d1b0cbd1012858d115462a285b
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/bthomas/ne/fedora-rawhide-x86_64/00156282-ne/ne-3.0.1-1.fc24.src.rpm
Description:  ne is a free (GPL'd) text editor based on the POSIX standard that
runs (we hope) on almost any UN*X machine. ne is easy to use for the beginner,
but powerful and fully configurable for the wizard, and most sparing in its
resource usage. If you have the resources and the patience to use emacs or the
right mental twist to use vi then probably ne is not for you. However, being
fast, small, powerful and simple to use, ne is ideal for email, editing through
phone line (or slow GSM/GPRS) connections and so on. Moreover, the internal
text representation is very compact--you can easily load and modify very large
files.

Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=12712599

Fedora Account System Username: bthomas

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302288] Review Request: perl-Debug-ShowStuff - A collection of handy debugging routines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302288

Petr Šabata  changed:

   What|Removed |Added

   Fixed In Version||perl-Debug-ShowStuff-1.16-1
   ||.fc24



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302249] Review Request: perl-MemHandle - Supply memory-based FILEHANDLE methods

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302249



--- Comment #11 from Fedora Update System  ---
perl-MemHandle-0.07-1.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2f52b2286e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302283] Review Request: perl-Number-Misc - Handy utilities for numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302283



--- Comment #8 from Fedora Update System  ---
perl-Number-Misc-1.2-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7b9cc5f700

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1266429] Review Request: cmark - CommonMark parsing and rendering

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1266429



--- Comment #26 from Fedora Update System  ---
cmark-0.23.0-3.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b9f659fc81

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302285] Review Request: perl-String-Util - String processing utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302285



--- Comment #8 from Fedora Update System  ---
perl-String-Util-1.24-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d285401910

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299637] Review Request: pam_wrapper - A tool to test PAM applications and PAM modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299637



--- Comment #11 from Fedora Update System  ---
pam_wrapper-1.0.1-2.fc22 has been pushed to the Fedora 22 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-10fbf612b6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264653

Remi Collet  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Remi Collet  ---
[x]: Package must own all directories that it creates.


=== APPROVED ===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292794] Review Request: openstack-magnum - Container Management project for OpenStack

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292794

Stephen Gordon  changed:

   What|Removed |Added

 Blocks||1302766




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302766
[Bug 1302766] Add Magnum support using puppet-magnum
-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1286772] Review Request: python-magnumclient - Client library for Magnum API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1286772

Stephen Gordon  changed:

   What|Removed |Added

 Blocks||1302766




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302766
[Bug 1302766] Add Magnum support using puppet-magnum
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302809] Review Request: ne - ne, the nice editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302809

Brandon Thomas  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #11 from Antonio Murdaca  ---
Jan, Lokesh, I should have fixed everything now.

The only thing which doesn't work is removing the `cd $(pwd)/_build/...)` stuff
in %install (as Jan suggested me to do) because I believe it is tied to
$GO15VENDOREXPERIMENT and "go build" only works with "vendor/" if the current
source being built lives under $GOPATH. (you can try this and see it can't
resolves package dependencies)

I've also tagged a new release (v0.1.3)

Spec URL: https://github.com/runcom/skopeo/blob/master/skopeo.spec
SRPM URL: http://runcom.ninja/skopeo-0.1.3-0.1.gitfdb5cac.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12713377
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12713364

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270357] Review Request: nacl-gcc - Various compilers (C, C++) for nacl

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270357
Bug 1270357 depends on bug 1270355, which changed state.

Bug 1270355 Summary: Review Request: nacl-binutils - A GNU collection of binary 
utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1270355

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270355] Review Request: nacl-binutils - A GNU collection of binary utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270355

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 13:23:33



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270355] Review Request: nacl-binutils - A GNU collection of binary utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270355



--- Comment #27 from Fedora Update System  ---
nacl-binutils-2.24-7.git1d8592c.fc22 has been pushed to the Fedora 22 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270405] Review Request: native_client - Google Native Client Toolchain

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270405
Bug 1270405 depends on bug 1270355, which changed state.

Bug 1270355 Summary: Review Request: nacl-binutils - A GNU collection of binary 
utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1270355

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270358] Review Request: nacl-newlib - C library intended for use on embedded systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270358
Bug 1270358 depends on bug 1270355, which changed state.

Bug 1270355 Summary: Review Request: nacl-binutils - A GNU collection of binary 
utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1270355

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270322] Review Request: chromium - A WebKit (Blink) powered web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270322
Bug 1270322 depends on bug 1270355, which changed state.

Bug 1270355 Summary: Review Request: nacl-binutils - A GNU collection of binary 
utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1270355

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270051] Review Request: golang-github-lib-pq - Pure Go Postgres driver for database/sql

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270051



--- Comment #10 from Fedora Update System  ---
golang-github-lib-pq-0-0.1.git0dad96c.fc22 has been pushed to the Fedora 22
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270054] Review Request: golang-github-magiconair-properties - Java properties scanner for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270054

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269799] Review Request: golang-github-lsegal-gucumber - An implementation of Cucumber BDD-style testing for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269799

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1217857] Review Request: bandit - A framework for performing security analysis of Python source code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1217857

Fedora Update System  changed:

   What|Removed |Added

 Resolution|RAWHIDE |ERRATA



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293214] Review Request: python-betamax - A VCR imitation for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293214



--- Comment #8 from Fedora Update System  ---
python-betamax-0.5.1-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293214] Review Request: python-betamax - A VCR imitation for python-requests

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293214

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 13:28:49



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299313] Review Request: nodejs-is-retry-allowed - Is retry allowed for Error?

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299313



--- Comment #10 from Fedora Update System  ---
nodejs-is-retry-allowed-1.0.0-1.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270056] Review Request: golang-github-mattn-go-sqlite3 - Sqlite3 driver for go that using database/sql

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270056



--- Comment #10 from Fedora Update System  ---
golang-github-mattn-go-sqlite3-1.0.0-1.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302844] New: Review Request: golang-github-docker-go-units - go-units is a library to transform human friendly measurements into machine friendly values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302844

Bug ID: 1302844
   Summary: Review Request: golang-github-docker-go-units -
go-units is a library to transform human friendly
measurements into machine friendly values
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: amurd...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://runcom.ninja/golang-github-docker-go-units.spec
SRPM URL:
http://runcom.ninja/golang-github-docker-go-units-0.2.0-1.fc23.src.rpm

Koji buils:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12713807
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12713817

Description: go-units is a library to transform human friendly measurements
into machine friendly values

Fedora Account System Username: runcom

Additional information: this is the latest tag currently available - v0.2.0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302844] Review Request: golang-github-docker-go-units - Transform human friendly measurements into machine friendly values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302844

Lokesh Mandvekar  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-docker-go-uni |golang-github-docker-go-uni
   |ts - go-units is a library  |ts - Transform human
   |to transform human friendly |friendly measurements into
   |measurements into machine   |machine friendly values
   |friendly values |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301748] Review Request: pulp-ostree - Support for pulp-ostree content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301748

Patrick Creech  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-01-28 14:27:21



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302844] Review Request: golang-github-docker-go-units - go-units is a library to transform human friendly measurements into machine friendly values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302844

Lokesh Mandvekar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||l...@redhat.com
   Assignee|nob...@fedoraproject.org|l...@redhat.com
  Flags||fedora-review+



--- Comment #1 from Lokesh Mandvekar  ---
- specfile conforms to current golang packaging draft
- license correct and valid
- only sources installed

package approved.

We gotta wait until you're sponsored into packagers before you can ask for
dist-git (I think).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293204] Review Request: nodejs-is-arrayish - Check if an object can be used like an Array

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293204



--- Comment #14 from Fedora Update System  ---
nodejs-is-arrayish-0.2.1-3.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1194781] Review Request: pcre2 - Perl-compatible regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1194781



--- Comment #18 from Fedora Update System  ---
pcre2-10.21-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297530] Review Request: perl-WWW-Twilio-TwiML - Light and fast TwiML generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297530



--- Comment #13 from Fedora Update System  ---
perl-WWW-Twilio-TwiML-1.05-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291539] Review Request: nodejs-has-unicode - Try to guess if your terminal supports unicode

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291539



--- Comment #11 from Fedora Update System  ---
nodejs-has-unicode-2.0.0-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1290524] Review Request: libdkimpp - Lightweight and portable DKIM (RFC4871) library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290524



--- Comment #16 from Fedora Update System  ---
libdkimpp-1.0.8-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1194781] Review Request: pcre2 - Perl-compatible regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1194781

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2015-03-16 10:07:59 |2016-01-28 14:25:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302283] Review Request: perl-Number-Misc - Handy utilities for numbers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302283

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
perl-Number-Misc-1.2-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9dd9a31f43

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299637] Review Request: pam_wrapper - A tool to test PAM applications and PAM modules

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299637

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
pam_wrapper-1.0.1-2.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-982eba6aca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301565] Review Request: golang-github-jacobsa-oglematchers - Set of matchers for Go (inspired by Google Test for C++ and Google JS Test)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301565

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #5 from Fedora Update System  ---
golang-github-jacobsa-oglematchers-0-0.2.git3ecefc4.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cac893512f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302285] Review Request: perl-String-Util - String processing utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302285

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #7 from Fedora Update System  ---
perl-String-Util-1.24-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8dec07bdc7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302902] New: Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302902

Bug ID: 1302902
   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mstev...@imt-systems.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: 
SRPM URL: 
Description: 
Fedora Account System Username:

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #12 from Upstream Release Monitoring 
 ---
runcom's scratch build of skopeo-0.1.3-1.fc23.src.rpm for f23 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12716264

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264653



--- Comment #8 from Shawn Iwinski  ---
(In reply to Remi Collet from comment #7)
> [!]: Package must own all directories that it creates.
>  Note: Directories without known owners: /usr/share/php/GuzzleHttp6

Updated

Diff:
https://github.com/siwinski/rpms/commit/d61ec0e212076f3029c41fe85e68d34fadfbeb05



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/d61ec0e212076f3029c41fe85e68d34fadfbeb05/php-guzzlehttp-guzzle6/php-guzzlehttp-guzzle6.spec
 

SRPM URL:
https://siwinski.fedorapeople.org/SRPMS/php-guzzlehttp-guzzle6-6.1.1-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #13 from Antonio Murdaca  ---
Pulled in the latest Jan's fixes to the spec (thanks a lot)

Spec URL:
https://raw.githubusercontent.com/runcom/fedora-pkgs/master/skopeo/fedora/skopeo/skopeo.spec
SRPM URL:
https://github.com/runcom/fedora-pkgs/raw/master/skopeo/skopeo-0.1.3-1.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12716275
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12716276

Thanks for the help guys!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1232226] Review Request: golang-github-go-mgo-mgo - The MongoDB driver for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1232226

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #12 from Fedora Update System  ---
golang-github-go-mgo-mgo-0-0.3.gite30de8a.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9658cdb34c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302249] Review Request: perl-MemHandle - Supply memory-based FILEHANDLE methods

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302249

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #10 from Fedora Update System  ---
perl-MemHandle-0.07-1.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb2d420f0e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301568] Review Request: golang-github-3rf-mongo-lint - MongoDB fork of Golint

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301568

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #4 from Fedora Update System  ---
golang-github-3rf-mongo-lint-0-0.2.gitf6cf4f8.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-557091a15b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299038] Review Request: prunerepo - remove old packages from rpm-md repository

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299038

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #11 from Fedora Update System  ---
prunerepo-1.1-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a787b58577

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871



--- Comment #1 from Antonio Murdaca  ---
This is missing cmd/ command directory which needs to be packaged as well - so
tar-split provides a cmd/ and devel.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #14 from Upstream Release Monitoring 
 ---
runcom's scratch build of skopeo-0.1.3-1.fc23.src.rpm for f23 completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12716275

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302904] New: Review Request: cacti - re-review

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302904

Bug ID: 1302904
   Summary: Review Request: cacti - re-review
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mstev...@imt-systems.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mstevens.fedorapeople.org/cacti/cacti.spec
SRPM URL: https://mstevens.fedorapeople.org/cacti/cacti-0.8.8f-1.el7.noarch.rpm
Description: This is a re-review request for cacti. The package is based on the
orphaned Fedora/EPEL package.
Fedora Account System Username: mstevens

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302876] Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302876



--- Comment #1 from Ingvar Hagelund  ---
Upstream source and inforamtion: https://github.com/toreanderson/clatd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302872] Review Request: python-sqlacodegen - Automatic model code generator for SQLAlchemy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302872

Ilya Gradina  changed:

   What|Removed |Added

 CC||ilya.grad...@gmail.com
  Flags||fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302872] Review Request: python-sqlacodegen - Automatic model code generator for SQLAlchemy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302872

Igor Gnatenko  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ilya.grad...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302170] Review Request: pulp-puppet - Support for Puppet content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302170

Adam Miller  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Adam Miller  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 157 files have unknown license.
 Detailed output of licensecheck in /home/admiller/reviews/1302170
 -pulp-puppet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /etc/pulp/admin, /var/lib/pulp,
 /etc/pulp/admin/conf.d, /var/lib/pulp/published, /etc/pulp,
 /etc/pulp/vhosts80, /usr/share/pulp, /etc/pulp/agent/conf.d,
 /etc/pulp/agent, /usr/share/pulp/wsgi
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /var/lib/pulp/published,
 /etc/pulp/agent/conf.d, /etc/pulp/admin, /etc/pulp/admin/conf.d,
 /usr/share/pulp, /etc/httpd, /etc/pulp/agent, /usr/lib/python2.7/site-
 packages/pulp_puppet, /etc/httpd/conf.d, /usr/share/pulp/wsgi,
 /var/lib/pulp, /etc/pulp, /etc/pulp/vhosts80
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: %config files are marked noreplace or the reason is justified.
 Note: No (noreplace) in %config /etc/pulp/admin/conf.d/puppet.conf
 %config /etc/pulp/agent/conf.d/puppet_bind.conf %config
 /etc/pulp/agent/conf.d/puppet_module.conf %config
 /etc/pulp/vhosts80/puppet.conf
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 71680 bytes in 14 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains 

[Bug 1299608] Review Request: Simple-Fuzzer - A simple fuzz test-case builder

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299608

Neil Horman  changed:

   What|Removed |Added

 CC||acon...@redhat.com
  Flags||needinfo?(acon...@redhat.co
   ||m)



--- Comment #1 from Neil Horman  ---
Ok, lots of problems to fix, none of them particularly difficult, but they
should all be addressed (either by fixing them, or explaining them, which may
be the case with some of the scripts that failed rpmlint).  You can ignore the
Installation errors, as I believe thats a known bug with the fedora-review
utility.  What I would suggest is that you start addressing these, then use the
fedora-review tool to check yourself and make sure they're correct.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Dist tag is present.


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[!]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Unknown or generated". 18 files have unknown
 license. Detailed output of licensecheck in
 /home/nhorman/Downloads/1299608-simple-fuzzer/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
 Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go 

[Bug 1301809] Review Request: pulp-rpm - Support for RPM content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301809

Adam Miller  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|admil...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295154] Review Request: python-prompt_toolkit - Library for building powerful interactive command lines in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295154



--- Comment #26 from Fedora Update System  ---
python-prompt_toolkit-0.57-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269576] Review Request: golang-github-MakeNowJust-heredoc - Package heredoc provides the here-document with keeping inden

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269576



--- Comment #12 from Fedora Update System  ---
golang-github-MakeNowJust-heredoc-0-0.1.git1d91351.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1194781] Review Request: pcre2 - Perl-compatible regular expression library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1194781



--- Comment #19 from Fedora Update System  ---
pcre2-10.21-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269806] Review Request: golang-github-aws-aws-sdk-go - AWS SDK for the Go programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269806



--- Comment #21 from Fedora Update System  ---
golang-github-aws-aws-sdk-go-0.9.5-1.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270054] Review Request: golang-github-magiconair-properties - Java properties scanner for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270054



--- Comment #13 from Fedora Update System  ---
golang-github-magiconair-properties-1.5.3-1.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295152] Review Request: python-wcwidth - Measures number of Terminal column cells of wide-character codes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295152



--- Comment #21 from Fedora Update System  ---
python-wcwidth-0.1.6-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269799] Review Request: golang-github-lsegal-gucumber - An implementation of Cucumber BDD-style testing for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269799



--- Comment #13 from Fedora Update System  ---
golang-github-lsegal-gucumber-0-0.1.gite8116c9.el6 has been pushed to the
Fedora EPEL 6 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297530] Review Request: perl-WWW-Twilio-TwiML - Light and fast TwiML generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297530



--- Comment #14 from Fedora Update System  ---
perl-WWW-Twilio-TwiML-1.05-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270051] Review Request: golang-github-lib-pq - Pure Go Postgres driver for database/sql

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270051



--- Comment #12 from Fedora Update System  ---
golang-github-lib-pq-0-0.1.git0dad96c.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270056] Review Request: golang-github-mattn-go-sqlite3 - Sqlite3 driver for go that using database/sql

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270056



--- Comment #11 from Fedora Update System  ---
golang-github-mattn-go-sqlite3-1.0.0-1.el6 has been pushed to the Fedora EPEL 6
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270064] Review Request: golang-github-spf13-viper - Go configuration with fangs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270064



--- Comment #12 from Fedora Update System  ---
golang-github-spf13-viper-0-0.1.gitbe5ff3e.el6 has been pushed to the Fedora
EPEL 6 stable repository. If problems still persist, please make note of it in
this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302871] New: Review Request: tar-split - tar archive assembly/disassembly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302871

Bug ID: 1302871
   Summary: Review Request: tar-split - tar archive
assembly/disassembly
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: amurd...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/runcom/fedora-pkgs/blob/master/golang-github-vbatts-tar-split/fedora/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split.spec
SRPM URL:
https://github.com/runcom/fedora-pkgs/raw/master/golang-github-vbatts-tar-split/golang-github-vbatts-tar-split-0.9.11-1.fc23.src.rpm

Koji builds:

- f23: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715095
- rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=12715092

Description: Pristinely disassembling a tar archive, and stashing needed raw
bytes and offsets to reassemble a validating original archive.
Fedora Account System Username: runcom
Additional information: this is just providing the devel package for v0.9.11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302872] New: Review Request: python-sqlacodegen - Automatic model code generator for SQLAlchemy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302872

Bug ID: 1302872
   Summary: Review Request: python-sqlacodegen - Automatic model
code generator for SQLAlchemy
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: i.gnatenko.br...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-sqlacodegen.spec
SRPM URL:
https://ignatenkobrain.fedorapeople.org/for-review/python-sqlacodegen-1.1.6-1.fc24.src.rpm
Description:
This is a tool that reads the structure of an existing database and generates
the appropriate SQLAlchemy model code, using the declarative style if possible.

This tool was written as a replacement for sqlautocode, which was suffering
from several issues (including, but not limited to, incompatibility with
Python 3 and the latest SQLAlchemy version).

Features
* Supports SQLAlchemy 0.6.x - 1.0.x
* Produces declarative code that almost looks like it was hand written
* Produces PEP 8 compliant code
* Accurately determines relationships, including many-to-many, one-to-one
* Automatically detects joined table inheritance
* Excellent test coverage
Fedora Account System Username: ignatenkobrain

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302170] Review Request: pulp-puppet - Support for Puppet content in the Pulp platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302170

Adam Miller  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|admil...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293045] Review Request: fontopia - the console font editor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293045

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|ERRATA  |---
   Keywords||Reopened



--- Comment #15 from Fedora Update System  ---
fontopia-1.1-4.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-32cedeb2f6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #14 from Sally  ---
The Makefile and spec in the new upstream url were not current :)
I updated the files and uploaded a new srpm for review.

new upstream url: https://github.com/projectatomic/oci-register-machine
review repo with updated files: https://github.com/sallyom/oci-register-stuff

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302876] New: Review Request: clatd - CLAT / SIIT-DC Edge Relay implementation for Linux

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302876

Bug ID: 1302876
   Summary: Review Request: clatd - CLAT / SIIT-DC Edge Relay
implementation for Linux
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ing...@linpro.no
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ingvar.fedorapeople.org/tayga/clatd.spec
SRPM URL:
https://ingvar.fedorapeople.org/tayga/clatd-1.4-1.2.20160128git1abcec1.fc22.src.rpm

Description:
clatd implements the CLAT component of the 464XLAT network architecture
specified in RFC 6877. It allows an IPv6-only host to have IPv4 connectivity
that is translated to IPv6 before being routed to an upstream PLAT (which is
typically a Stateful NAT64 operated by the ISP) and there translated back to
IPv4 before being routed to the IPv4 internet.

Fedora Account System Username: ingvar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302872] Review Request: python-sqlacodegen - Automatic model code generator for SQLAlchemy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302872



--- Comment #1 from Ilya Gradina  ---

This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[ x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[-]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 6 files have unknown license. Detailed
 output of licensecheck in /home/ilgrad/1302872-python-
 sqlacodegen/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[?]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[-]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[?]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: 

[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264653

Shawn Iwinski  changed:

   What|Removed |Added

 Blocks||1302909 (drupal8)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1302909
[Bug 1302909] Review Request: drupal8 - An open source content management
platform
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #15 from Nalin Dahyabhai  ---
runcom is not currently in the packagers group; I can sponsor.

I've got questions about the license tag when we're bundling, and could
probably use some clarification about whether or not, and if so, how many, of
the vendored modules need to be debundled for Fedora.  Otherwise it looks
pretty straightforward from here.

fedora-review output:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
===
- Sources used to build the package match the upstream source, as provided
  in the spec URL.
  See: http://fedoraproject.org/wiki/Packaging/SourceURL

  Since you're keeping a .spec file in the repository, I expect you'll be
keeping it more or less in sync with the one being used for Fedora, so no
worries there.

  The source tarball in the SRPM contained the .git directory and copies of
generated files, including the binary, which is rather odd.  How was it
generated?  Will future versions of the package do this as well?

- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

  Stylistically, it's better to choose either %{buildroot} or $RPM_BUILD_ROOT
and be consistent about it.  You're not doing anything that makes either of
them not an option, so use whichever you prefer.

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is marked as %doc instead of %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

  The main package tags the LICENSE file as %doc rather than %license, which is
trivially fixable.

= MUST items =

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.

 I suspect that linking your MIT-licensed main logic with vendored sources
from other repositories is going to produce

https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Mixed_Source_Licensing_Scenario

[ ]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "BSD (3 clause)", "*No copyright* Apache
 (v2.0)", "Unknown or generated", "BSD (2 clause)". 371 files have
 unknown license. Detailed output of licensecheck in /misc/skopeo
 /review-skopeo/licensecheck.txt

 If it's not mixed source, then "License: MIT" is correct.

[x]: %build honors applicable compiler flags or justifies otherwise.
 Uses %gobuild to invoke the go compiler.
[ ]: Package contains no bundled libraries without FPC exception.

 Package bundles several libraries.  Does it need to remove them at the end
of the %setup section when %{with_bundled} is 0 in order to ensure that the
compiler picks up the debundled copies?  Doesn't Fedora require debundling?

[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[!]: Package consistently uses macros (instead of hard-coded directory
 names).

 The package's makefile hardcodes the install locations, and we don't force
them to match %{_bindir} and %{_mandir}.

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[-]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.

 The package could use a longer %description; I think something along the
lines of the paragraph that starts around line 6 of README.md would work.

[-]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.

 Why is %{with_debug} disabled?  Rebuilding it with debuginfo enabled
produces files with names that seem to be of some use to my debugger.

[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines

 Aside from questions I have about licensing and bundling, this looks fine.

[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs 

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143

Nalin Dahyabhai  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 19:23:05



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293425] Review Request: python-ImcSdk - python lib for CRUD operations on Cisco IMC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293425



--- Comment #12 from Fedora Update System  ---
python-ImcSdk-0.7.2-3.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903

Nalin Dahyabhai  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #15 from Nalin Dahyabhai  ---
fedora-review hit its own bug #1264803, but a manual check shows that the
package installation succeeds.  We've got some issues around being able to use
the -devel package's contents when building other packages; the rest of the
notes cover things which I think will be pretty straightforward to tweak. 
Please let me know if I need to elaborate on anything or provide assistance.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

  Manual check succeeds, so ignore this issue.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.

 License is ASL 2.0, links only with BSD golang-github-godbus-dbus-devel

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 5 files have unknown license. Detailed
 output of licensecheck in /misc/register/review-oci-register-
 machine/licensecheck.txt

 ASL 2.0

[x]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/gocode/src,
 /usr/libexec/docker, /usr/share/gocode,
 /usr/share/gocode/src/github.com

 Might need to add Requires: on docker for /usr/libexec/docker.
 /usr/share/gocode/src and /usr/share/gocode/src/github.com are owned by
golang, which should be fine.
 /usr/libexec/docker/hooks.d probably needs to be provided by multiple
packages if docker isn't going to.
 /usr/share/gocode/src/github.com/projectatomic probably needs to be
provided by multiple packages, so it's fine.

[!]: %build honors applicable compiler flags or justifies otherwise.

 The Makefile doesn't pick up $LDFLAGS from the environment.  Per
/usr/lib/rpm/macros.d/macros.golang-compiler, Fedora 24 defines gobuild() as:
 go build -compiler gc -ldflags "${LDFLAGS:-} -B 0x$(head -c20
/dev/urandom|od -An -tx1|tr -d ' \\n')" -a -v -x
 If the makefile's going to run the compiler, it may want to pick up some
of this.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.

 Version tag on the changelog entry doesn't match the version of the
package, but that's easily fixed.

[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package

 The source for the man page isn't really devel documentation; I think it
can be dropped from the -devel package.

 I can't import "github.com/projectatomic/oci-register-machine" with the
devel package installed -- I get a 'import
"github.com/projectatomic/oci-register-machine" is a program, not an importable
package' error.  Were the reusable bits supposed to be broken out into an
oci-register-machine package and called from main()?  If so, then the compiler
won't accept "oci-register-machine" as a package name, and this will affect the
Provides: in the devel package.

[x]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
 names).

 The makefile hard-codes the location where the man page is installed.  If
the Makefile defines a MANDIR variable, we can override it to follow %{_mandir}
during the %install phase.

[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.

 It could stand to have a longer %description, but otherwise it's fine.

[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[ ]: Package successfully compiles and builds into binary rpms on at least
 one supported primary 

[Bug 1302909] New: Review Request: drupal8 - An open source content management platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302909

Bug ID: 1302909
   Summary: Review Request: drupal8 - An open source content
management platform
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sh...@iwin.ski
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/siwinski/rpms/8095aa4ae37b25540a8e9797002080bb07ef4d63/drupal8/drupal8.spec

SRPM URL: https://siwinski.fedorapeople.org/SRPMS/drupal8-8.0.2-1.fc23.src.rpm

Description:
Drupal is an open source content management platform powering millions of
websites and applications. It’s built, used, and supported by an active and
diverse community of people around the world.


Fedora Account System Username: siwinski

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1273471] Review Request: python-anymarkup-core - The core library for anymarkup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273471

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 19:23:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-01-01 08:37:29 |2016-01-28 19:23:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293425] Review Request: python-ImcSdk - python lib for CRUD operations on Cisco IMC

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293425

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-01-28 19:23:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1291169] Review Request: ccdciel - CCD capture software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1291169



--- Comment #15 from Fedora Update System  ---
ccdciel-0.2.0-10.20160105svn.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302909] Review Request: drupal8 - An open source content management platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302909

Shawn Iwinski  changed:

   What|Removed |Added

 Depends On||1264653
   ||(php-guzzlehttp-guzzle6)
  Alias||drupal8




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1264653
[Bug 1264653] Review Request: php-guzzlehttp-guzzle6 - PHP HTTP client
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1064657] Review Request: exciting - FP-LAPW Code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1064657



--- Comment #12 from Mukundan Ragavan  ---
marcin - I am very sorry about this delay. I will post a review in the next two
days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903



--- Comment #12 from Jan Chaloupka  ---
Makefile contains 'go get' command:
go get github.com/cpuguy83/go-md2man

It is against packaging policies. It must by patched in the package. The
project is already built in the distribution as
golang-github-cpuguy83-go-md2man package. It provides go-md2man binary, so
"Requires: go-md2man" will install the package.

At the same time if you use Makefile
- the package can not be built with debug info support
- the package can be built only for architectures with golang compiler, no with
gcc-go
unless you patch the Makefile. Would recommend to move content of Makefile into
the spec instead of running make. However, not blocker for the review.

If possible, create Godeps.json file for the project with commit of
github.com/godbus/dbus used. I.e.

{
"ImportPath": "github.com/coreos/etcd",
"GoVersion": "go1.5.1",
"Packages": [
"./..."
],
"Deps": [
{
"ImportPath": "github.com/godbus/dbus",
"Rev": "COMMIT"
}
]
}

so we can validate the dependency is provided by the distribution and
up-to-date.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302552] Review Request: php-zendframework-zend-hydrator - Zend Framework Hydrator component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302552

Remi Collet  changed:

   What|Removed |Added

  Alias||endframework/zend-hydrator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: golang-github-projectatomic-oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903

Jan Chaloupka  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-sallyom-Regis |golang-github-projectatomic
   |ter - Golang binary for |-oci-register-machine -
   |registering OCI containers  |Golang binary for
   |with systemd-machined   |registering OCI containers
   ||with systemd-machined



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1282903] Review Request: oci-register-machine - Golang binary for registering OCI containers with systemd-machined

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1282903

Jan Chaloupka  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |golang-github-projectatomic |oci-register-machine -
   |-oci-register-machine - |Golang binary for
   |Golang binary for   |registering OCI containers
   |registering OCI containers  |with systemd-machined
   |with systemd-machined   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302552] Review Request: php-zendframework-zend-hydrator - Zend Framework Hydrator component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302552

Remi Collet  changed:

   What|Removed |Added

  Alias|endframework/zend-hydrator  |zendframework/zend-hydrator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1293735] Review Request: boomaga - A virtual printer for viewing a document before printing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1293735



--- Comment #18 from MartinKG  ---
Dmitry thanks for your helpfulness and Explanation.

here is the new rpm package:
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/boomaga.spec
SRPM URL:
https://martinkg.fedorapeople.org/Review/SRPMS/boomaga-0.7.1-5.git2928eef.fc23.src.rpm

%changelog
* Thu Jan 28 2016 Martin Gansser  -
0.7.1-5.git2928eef
- Dropped link for %%{_bindir}/boomagamerger
- Added %%{name}-0.7.1-NONGUI_DIR.patch

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302003] Review Request: mongo-java-driver2 - MongoDB Java driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302003



--- Comment #9 from Christos Triantafyllidis 
 ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "Apache (v2.0)", "Unknown or generated". 119
 files have unknown license. Detailed output of licensecheck in
 ~/1302003-mongo-java-driver2/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[?]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[!]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[?]: Final provides and requires are sane (see attachments).
[!]: Fully versioned dependency in 

[Bug 1302003] Review Request: mongo-java-driver2 - MongoDB Java driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302003



--- Comment #10 from gil cattaneo  ---
(In reply to Christos Triantafyllidis from comment #9)

> The following are not blocking the review:
> [!]: Latest version is packaged.
> This is intended to be a compat package thus the latest 2.x version is
> packaged.
> [!]: %check is present and all tests pass.
> Clarified in the comment in the spec and confirmed that the original package
> doesn't include %check too
> 
> The following need to be addressed:
> [?]: Package contains no bundled libraries without FPC exception.
> While I don't see anything bundled, I see the following explicit provides:
> - bundle(apache-commons-codec)
> - bundle(jcip-annotations)
> - bundle(postgresql-jdbc)

Those files are modifications of code included in:
apache-commons-codec src/main/com/mongodb/util/Base64Codec.java
jcip-annotations src/main/org/bson/util/annotations/*
postgresql-jdbc src/main/org/bson/io/UTF8Encoding.java
Now, is no more required ask an FPC exception if in the
spec file are explained the bundles libraries

> [?]: Final provides and requires are sane (see attachments).
> Again the same provides as above, why are those explicitly defined? I don't
> see the original package to provide those.
what packages?
> [?]: Package functions as described.
> I'm not sure how to test this. Would it be possible to provide a test case?
> I'd like to run a simple test run especially given the fact that %check is
> not included.
maven build style not use and do not need the %check section
> [!]: If package contains pom.xml files install it (including metadata) even
>  when building with ant
already installed using %mvn_install instruction
> [!]: Fully versioned dependency in subpackages if applicable.
>  Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mongo-
>  java-driver2-javadoc

No needed is a noarch package
> 
> I also see that compared to the original package the following subpackages
> are missing:
> mongo-java-driver2-bson
> mongo-java-driver2-bson-javadoc
not needed
> Also another thing that is not clear to me is why the SPEC file of
> mongo-java-driver is not used as a base for this given that the aim of a
> compat package should be to have the exactly the same functionality as the
> initial one that got updated.

It is not necessary

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1273471] Review Request: python-anymarkup-core - The core library for anymarkup

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273471



--- Comment #15 from Petr Viktorin  ---
Jan, are you planning to push the update to f23/f22?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review