[Bug 1303430] Review Request: python-click-log - Logging integration for python-click

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303430

Charalampos Stratakis  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|cstra...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303432] Review Request: python-click-threading - Multithreaded support for python click apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303432

Charalampos Stratakis  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|cstra...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #6 from Denis Fateyev  ---
The wording "you may assume that enough of an environment exists for RPM to
function and execute basic shell scripts" is vague. Coreutils may be needed to
execute some abstract shell scripts, or maybe not. The list of the packages
which are always present in build environment would work better.
We're at 'perl-sig' just always include coreutils into BRs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265628



--- Comment #32 from Pavel Šimerda (pavlix)  ---

Spec URL: http://pavlix.fedorapeople.org//dhcpcd.spec
SRPM URL: http://pavlix.fedorapeople.org//dhcpcd-6.10.1-1.fc24.src.rpm

Description:
The dhcpcd package provides a minimalistic network configuration daemon
that supports IPv4 and IPv6 configuration including configuration discovery
through NDP, DHCPv4 and DHCPv6 protocols.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265628



--- Comment #34 from Pavel Šimerda (pavlix)  ---

Spec URL: http://pavlix.fedorapeople.org//dhcpcd.spec
SRPM URL: http://pavlix.fedorapeople.org//dhcpcd-6.10.1-2.fc24.src.rpm

Description:
The dhcpcd package provides a minimalistic network configuration daemon
that supports IPv4 and IPv6 configuration including configuration discovery
through NDP, DHCPv4 and DHCPv6 protocols.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #31 from Fedora Update System  ---
msgpuck-1.0.2-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-01e318faa8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #31 from Fedora Update System  ---
msgpuck-1.0.2-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-01e318faa8

--- Comment #32 from Fedora Update System  ---
msgpuck-1.0.2-1.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a17cb3306

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #33 from Fedora Update System  ---
msgpuck-1.0.2-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-6066d67c0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251



--- Comment #4 from Petr Pisar  ---
(In reply to Raphael Groner from comment #3)
> thanks for your hints. I do not see any blockers. Please approve the package.
> 
Good package is also mark of the reviewer and I will no pass package with these
simple to fix mistakes. Please correct the issues I marked as `FIX' and then I
will approve this package.

> Spelling errors
> They do not harm with packaging in general, therefore marked as warnings.
>
Though if spotted they should be fixed. Especially the "filesize" is not an
English word.

> coreutils
> That package can be assumed to be installed in every working system.
> Otherwise, we would have to add iit as dependency to every other packages as
> well. It's always present in a fresh mock build environment and so also on
> koji.

We have to add it to every package that needs it.
.
There is no exceptions list anymore.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265628



--- Comment #33 from Upstream Release Monitoring 
 ---
pavlix's scratch build of dhcpcd-6.10.1-2.fc24.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12799555

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #8 from Sinny Kumari  ---
(In reply to Michel Normand from comment #7)
> Spec URL: https://michelmno.fedorapeople.org/libcxl.spec
> SRPM URL: https://michelmno.fedorapeople.org/libcxl-1.3-1.fc23.src.rpm
> 
> related scratch build on ppc koji:
> http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3115696

Looks good to me.

Small note - After modifying SPEC file, it's good to add a new Changelog entry
as well. Refer
https://fedoraproject.org/wiki/Packaging:Guidelines#Multiple_Changelog_Entries_per_Release
for more information.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251



--- Comment #6 from Upstream Release Monitoring 
 ---
raphgro's scratch build of shrinkpdf-0-1.fc23.src.rpm for rawhide completed
http://koji.fedoraproject.org/koji/taskinfo?taskID=12800827

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301143] Review Request: skopeo - Get information about Docker images without pulling them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301143



--- Comment #26 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/skopeo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python3-nose

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304110] Review Request: nodejs-stream-consume - Consume a stream to ensure it keeps flowing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304110

Tom Hughes  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 2 files have
 unknown license. Detailed output of licensecheck in /home/tom/1304110
 -nodejs-stream-consume/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: Spec use %global instead of %define unless justified.

= EXTRA 

[Bug 1304110] Review Request: nodejs-stream-consume - Consume a stream to ensure it keeps flowing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304110



--- Comment #3 from Jared Smith  ---
Strange... I had both of those BuildRequires in my local copies, but not in the
copies on my fedorapeople site -- I must not have uploaded the latest version
before submitting.

Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-stream-consume/nodejs-stream-consume.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-stream-consume/nodejs-stream-consume-0.1.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299580



--- Comment #6 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/python-grafyaml

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299580] Review Request: python-grafyaml - Tools to make Grafana dashboards from templates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299580



--- Comment #7 from Paul Belanger  ---
Great, thanks everybody for the help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270317] Review Request: lz4-java - LZ4 compression for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270317

Tomas Repik  changed:

   What|Removed |Added

 CC||tre...@redhat.com
   Assignee|nob...@fedoraproject.org|tre...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251

Petr Pisar  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Petr Pisar  ---
Spec file changes:

$ diff -u shrinkpdf.spec{.old,}
--- shrinkpdf.spec.old  2016-01-13 16:29:09.0 +0100
+++ shrinkpdf.spec  2016-02-03 11:58:37.0 +0100
@@ -12,13 +12,13 @@
 BuildArch:  noarch

 Requires:   ghostscript-core
+Requires:   coreutils

 %description
 A simple wrapper around Ghostscript to shrink PDFs (as in reduce
-filesize) under Linux. Inspired by some code found in an OpenOffice
-Python script (I think). The script feeds a PDF through Ghostscript,
-which performs lossy recompression by such methods as downsampling
-the images to 72dpi. The result should be (but not always is) a much
+file size) under Linux. The script feeds a PDF through Ghostscript,
+which performs lossy recompression by such methods own as downsampling
+the images to 72 DPI. The result should be (but not always is) a much
 smaller file.


> TODO: I would improve the description a little bit. I would spell "filesize"
> as two words "file size". I think the second sentence "Inspired by some code
> found in an OpenOffice Python script (I think)" is irrelevant and I would
> remove it. Also I think "72dpi" is spelled wrongly. I'd write it as "72 DPI".

TODO: I think an "own" word slipped into your text this time.

> FIX: Build-require "coreutils" (shrinkpdf.spec:30).
Not addressed. Please add the build-require.

> FIX: Run-require "coreutils" because the script executes "cp", "wc", and
> "cut" programs.
$ rpm -q --requires -p ../RPMS/noarch/shrinkpdf-0-1.fc24.noarch.rpm | sort -f |
uniq -c
  1 /bin/sh
  1 coreutils
  1 ghostscript-core
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

Package builds in F24
(http://koji.fedoraproject.org/koji/taskinfo?taskID=12802729). Ok.

Please add build-dependency on coreutils before building the package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1265628] Review Request: dhcpcd - A minimalistic network configuration daemon with DHCP and rdisc support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1265628

Pavel Šimerda (pavlix)  changed:

   What|Removed |Added

  Flags|needinfo?(psimerda@redhat.c |
   |om) |



--- Comment #35 from Pavel Šimerda (pavlix)  ---

(In reply to Tomas Hozza from comment #29)
> Issues
> --
> [!]: Requires correct, justified where necessary.
>  - According to
> https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd you
> should also BuildRequire "systemd".

We depend on systemd-devel.

> [!]: Package contains systemd file(s) if in need.
>  - Please add also the template unit dhcpcd@.service

I'm not sure this is useful at all, NetworkManager also doesn't have @.service
unit, but it's there now.

> [!]: Latest version is packaged.
>  - latest version is 6.10.1

Latest version is used now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251



--- Comment #5 from Raphael Groner  ---
Fixed. Links are the same for SPEC and SRPM.

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=12800827

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #9 from Michel Normand  ---
(In reply to Sinny Kumari from comment #8)
> [CUT] ...
> Small note - After modifying SPEC file, it's good to add a new Changelog
> entry as well. Refer
> https://fedoraproject.org/wiki/Packaging:
> Guidelines#Multiple_Changelog_Entries_per_Release for more information.

Thanks for the review.
I voluntarily did not modified the Changelog because not yet in fedora db.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/xlogin

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
xlogin-0-0.1.20160114git97667d7.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-39ef6d00d1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304425] Review Request: nodejs-clean-yaml-object - Clean up an object prior to serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304425



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/nodejs-clean-yaml-object

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522



--- Comment #1 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-pg8000-1.10.3-1.fc24.src.rpm for f23
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12820147

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300005] Review Request: fleet-commander-client - Profile data retriever for Fleet Commander client hosts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=135



--- Comment #3 from Alberto Ruiz  ---
I've fixed the %description tag as recommended by #133:

Spec URL:
https://raw.githubusercontent.com/fleet-commander/fc-client/d25de8edf18b0c550b0d0b42272517f9d13bac63/fleet-commander-client.spec
SRPM URL:
https://github.com/fleet-commander/fc-client/releases/download/0.7.0/fleet-commander-client-0.7.0-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251



--- Comment #10 from Fedora Update System  ---
shrinkpdf-0-1.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-98f34222a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] New: Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522

Bug ID: 1304522
   Summary: Review Request: python-pg8000 - Pure Python PostgreSQL
Driver
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: williamjmore...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-pg8000.spec
SRPM URL:
https://williamjmorenor.fedorapeople.org/rpmdev/python-pg8000-1.10.3-0.fc24.src.rpm
Description: Pure Python PostgreSQL Driver
Fedora Account System Username: williamjmorenor

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522

William Moreno  changed:

   What|Removed |Added

 Whiteboard||trivial



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #34 from Fedora Update System  ---
msgpuck-1.0.2-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-6066d67c0c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303764] Review Request: xchange - Java library providing API for Bitcoin and Altcoin exchanges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303764



--- Comment #5 from Jonny Heggheim  ---
Thanks, my plan was to use submit them for review and update this package when
they are accepted

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294862] Review Request: python3-nose - Discovery-based unittest extension for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294862



--- Comment #8 from Fedora Update System  ---
python3-nose-1.3.7-2.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-05d0cc6652

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522



--- Comment #2 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-pg8000-1.10.3-1.fc24.src.rpm for
rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12820245

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1297150] Review Request: erlang-p1_xml - Fast Expat based Erlang XML parsing and manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297150

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #2 from Randy Barlow  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 5 files have unknown
 license. Detailed output of licensecheck in /home/rbarlow/1297150
 -erlang-p1_xml/licensecheck.txt
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to 

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #30 from Fedora Update System  ---
python-recommonmark-0.4.0-4.git7ca5247.fc22 has been pushed to the Fedora 22
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-03 15:51:07



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298019] Review Request: nvme-cli - NVMe management command line interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298019



--- Comment #8 from Fedora Update System  ---
nvme-cli-0.2-2.20160112gitbdbb4da.fc23 has been pushed to the Fedora 23 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1288456] Review Request: python-recommonmark - docutils-compatibility bridge to CommonMark

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1288456



--- Comment #29 from Fedora Update System  ---
python-recommonmark-0.4.0-4.git7ca5247.fc23 has been pushed to the Fedora 23
stable repository. If problems still persist, please make note of it in this
bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298019] Review Request: nvme-cli - NVMe management command line interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298019

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-02-03 15:51:36



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267037] Review Request: perl-Mojolicious-Plugin-Bootstrap3 - Mojolicious + http://getbootstrap.com/

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267037

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-02-03 09:37:01



--- Comment #10 from Emmanuel Seyman  ---
Folks, this is in Rawhide and an update has been issued for F23.

Petr, thank you for the review. You went above and beyond the call of duty on
this one.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298251] Review Request: shrinkpdf - Simple wrapper around Ghostscript to shrink PDFs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298251

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST



--- Comment #8 from Raphael Groner  ---
(In reply to Petr Pisar from comment #7)
> > FIX: Build-require "coreutils" (shrinkpdf.spec:30).
> Not addressed. Please add the build-require.

No. As bash (and mock installing bash, see below) depends on coreutils'
functionality and rpm package depends on it, we can guess a functional build
environment when rpm is installed by rpmbuild.
https://lists.fedoraproject.org/pipermail/devel/2015-June/211423.html


Thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #11 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for
f23 completed http://koji.fedoraproject.org/koji/taskinfo?taskID=12804154

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304425] Review Request: nodejs-clean-yaml-object - Clean up an object prior to serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304425

Tom Hughes  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||t...@compton.nu
   Assignee|nob...@fedoraproject.org|t...@compton.nu
  Flags||fedora-review+



--- Comment #1 from Tom Hughes  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 3 files have
 unknown license. Detailed output of licensecheck in /home/tom/1304425
 -nodejs-clean-yaml-object/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: 

[Bug 1303430] Review Request: python-click-log - Logging integration for python-click

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303430



--- Comment #3 from Michele Baldessari  ---
Spec URL: http://acksyn.org/files/rpms/python-click-log/python-click-log.spec
SRPM URL:
http://acksyn.org/files/rpms/python-click-log/python-click-log-0.1.3-2.fc23.src.rpm

Some assorted spec fixes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304425] Review Request: nodejs-clean-yaml-object - Clean up an object prior to serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304425

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews),
   ||1031982




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1031982
[Bug 1031982] nodejs-tap-5.4.2 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303432] Review Request: python-click-threading - Multithreaded support for python click apps

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303432



--- Comment #3 from Michele Baldessari  ---
Spec URL:
http://acksyn.org/files/rpms/python-click-threading/python-click-threading.spec
SRPM URL:
http://acksyn.org/files/rpms/python-click-threading/python-click-threading-0.1.2-2.fc23.src.rpm

Assorted spec fixes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304425] New: Review Request: nodejs-clean-yaml-object - Clean up an object prior to serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304425

Bug ID: 1304425
   Summary: Review Request: nodejs-clean-yaml-object - Clean up an
object prior to serialization
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-clean-yaml-object/nodejs-clean-yaml-object.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-clean-yaml-object/nodejs-clean-yaml-object-0.1.0-1.fc24.src.rpm
Description: Clean up an object prior to serialization
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #10 from Upstream Release Monitoring 
 ---
williamjmorenor's scratch build of python-astroquery-0.3.1-2.fc23.src.rpm for
rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12803970

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304425] Review Request: nodejs-clean-yaml-object - Clean up an object prior to serialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304425



--- Comment #2 from Tom Hughes  ---
You can leave test.js out of the built package but other than that it's fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522



--- Comment #4 from William Moreno  ---
Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/python-pg8000.spec
SRPM URL:
https://williamjmorenor.fedorapeople.org/rpmdev/python-pg8000-1.10.3-1.fc24.src.rpm

Sorry those are the updated links

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522



--- Comment #5 from Upstream Release Monitoring 
 ---
lupinix's scratch build of python-pg8000-1.10.3-0.fc24.src.rpm for rawhide
failed http://koji.fedoraproject.org/koji/taskinfo?taskID=12821621

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #36 from Fedora Update System  ---
msgpuck-1.0.2-1.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6a17cb3306

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715



--- Comment #18 from Fedora Update System  ---
xlogin-0-0.1.20160114git97667d7.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ff96a1e0b9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303245] Review Request: lrbd - Configure iSCSI access to Ceph rbd images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303245

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303245] Review Request: lrbd - Configure iSCSI access to Ceph rbd images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303245



--- Comment #5 from Fedora Update System  ---
lrbd-1.0.2-0.1.20160129gitcc757bc.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-1fc3fb5682

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #20 from Christian Dersch  ---
Thank you very much :) I'll have a look at your review request.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715



--- Comment #19 from Fedora Update System  ---
xlogin-0-0.1.20160114git97667d7.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-48ec072ee2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522



--- Comment #6 from William Moreno  ---
Test Builds:

https://copr.fedorainfracloud.org/coprs/williamjmorenor/fedora-review-test/build/157851/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304567] New: Review Request: nodejs-array-unique - Return an array free of duplicate values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304567

Bug ID: 1304567
   Summary: Review Request: nodejs-array-unique - Return an array
free of duplicate values
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-array-unique/nodejs-array-unique.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-array-unique/nodejs-array-unique-0.2.1-1.fc24.src.rpm
Description: Return an array free of duplicate values
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304567] Review Request: nodejs-array-unique - Return an array free of duplicate values

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304567

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #19 from William Moreno  ---
Maybe you can help with the review of #1304522

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270776] Review Request: restsharp - Simple REST and HTTP API Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270776

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org



--- Comment #5 from Christian Dersch  ---
Taken

TODO I already recognized: Please move restsharp.pc to a -devel subpackage as
required by Guidelines
https://fedoraproject.org/wiki/Packaging:Mono?rd=Packaging/Mono#-devel_packages

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295249] Review Request: python-gatspy - General tools for Astronomical Time Series in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295249



--- Comment #18 from Fedora Update System  ---
python-gatspy-0.2.1-3.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6ebe790da3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295249] Review Request: python-gatspy - General tools for Astronomical Time Series in Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295249

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304522] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304522

Christian Dersch  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||lupi...@mailbox.org
   Assignee|nob...@fedoraproject.org|lupi...@mailbox.org



--- Comment #3 from Christian Dersch  ---
Taken. Please ensure that the SRPM matches the spec you posted, not the case
here: At least Release tag differs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304571] Review Request: nodejs-arr-diff - Returns an array with only the unique values from the first array

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304571

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)
 Depends On||1304570




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1304570
[Bug 1304570] Review Request: nodejs-arr-flatten - Recursively flatten an
array or arrays
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304570] Review Request: nodejs-arr-flatten - Recursively flatten an array or arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304570

Jared Smith  changed:

   What|Removed |Added

 Blocks||1304571




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1304571
[Bug 1304571] Review Request: nodejs-arr-diff - Returns an array with only
the unique values from the first array
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304581] New: Review Request: nodejs-repeat-string - Repeat the given string n times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304581

Bug ID: 1304581
   Summary: Review Request: nodejs-repeat-string - Repeat the
given string n times
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-repeat-string/nodejs-repeat-string.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-repeat-string/nodejs-repeat-string-1.5.2-1.fc24.src.rpm
Description: Repeat the given string n times
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304581] Review Request: nodejs-repeat-string - Repeat the given string n times

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304581

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349

Link Dupont  changed:

   What|Removed |Added

 CC||l...@fastmail.com



--- Comment #1 from Link Dupont  ---
- Has the patch been submitted upstream?
- Maybe %description should be localized into German (if possible) and English.
At any rate, I'd suggest fixing the spelling suggestions from rpmlint
- Have you tried a koji scratch build to make sure it builds in both x86_64 and
i386?

Rpmlint
---
Checking: flyingsaucersattack-1.20h-1.fc23.x86_64.rpm
  flyingsaucersattack-debuginfo-1.20h-1.fc23.x86_64.rpm
  flyingsaucersattack-1.20h-1.fc23.src.rpm
flyingsaucersattack.x86_64: W: spelling-error %description -l en_US greifen ->
green
flyingsaucersattack.x86_64: W: spelling-error %description -l en_US german ->
German, germane, merman
flyingsaucersattack.x86_64: W: spelling-error %description -l en_US english ->
English
flyingsaucersattack.x86_64: W: spelling-error %description -l en_US attackwaves
-> attack waves, attack-waves, attaches
flyingsaucersattack.x86_64: W: spelling-error %description -l en_US gameover ->
game over, game-over, overcame
flyingsaucersattack.x86_64: W: no-manual-page-for-binary flyingsaucersattack
flyingsaucersattack.src: W: spelling-error %description -l en_US greifen ->
green
flyingsaucersattack.src: W: spelling-error %description -l en_US german ->
German, germane, merman
flyingsaucersattack.src: W: spelling-error %description -l en_US english ->
English
flyingsaucersattack.src: W: spelling-error %description -l en_US attackwaves ->
attack waves, attack-waves, attaches
flyingsaucersattack.src: W: spelling-error %description -l en_US gameover ->
game over, game-over, overcame
3 packages and 0 specfiles checked; 0 errors, 11 warnings.




Rpmlint (debuginfo)
---
Checking: flyingsaucersattack-debuginfo-1.20h-1.fc23.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.





Rpmlint (installed packages)

flyingsaucersattack.x86_64: W: no-manual-page-for-binary flyingsaucersattack
2 packages and 0 specfiles checked; 0 errors, 1 warnings.



Requires

flyingsaucersattack-debuginfo (rpmlib, GLIBC filtered):

flyingsaucersattack (rpmlib, GLIBC filtered):
/bin/sh
hicolor-icon-theme
libaldmb-0.9.3.so()(64bit)
liballeg.so.4.4()(64bit)
libc.so.6()(64bit)
libdumb-0.9.3.so()(64bit)
libgcc_s.so.1()(64bit)
libm.so.6()(64bit)
libstdc++.so.6()(64bit)
rtld(GNU_HASH)



Provides

flyingsaucersattack-debuginfo:
flyingsaucersattack-debuginfo
flyingsaucersattack-debuginfo(x86-64)

flyingsaucersattack:
appdata()
appdata(flyingsaucersattack.appdata.xml)
application()
application(flyingsaucersattack.desktop)
flyingsaucersattack
flyingsaucersattack(x86-64)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304571] New: Review Request: nodejs-arr-diff - Returns an array with only the unique values from the first array

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304571

Bug ID: 1304571
   Summary: Review Request: nodejs-arr-diff - Returns an array
with only the unique values from the first array
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-arr-diff/nodejs-arr-diff.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-arr-diff/nodejs-arr-diff-2.0.0-1.fc24.src.rpm
Description: Returns an array with only the unique values from the first array
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304574] Review Request: nodejs-filename-regex - Regular expression for matching file names

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304574

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304574] New: Review Request: nodejs-filename-regex - Regular expression for matching file names

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304574

Bug ID: 1304574
   Summary: Review Request: nodejs-filename-regex - Regular
expression for matching file names
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-filename-regex/nodejs-filename-regex.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-filename-regex/nodejs-filename-regex-2.0.0-1.fc24.src.rpm
Description: Regular expression for matching file names
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304576] Review Request: nodejs-is-buffer - Determine if an object is Buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304576

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304576] New: Review Request: nodejs-is-buffer - Determine if an object is Buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304576

Bug ID: 1304576
   Summary: Review Request: nodejs-is-buffer - Determine if an
object is Buffer
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-is-buffer/nodejs-is-buffer.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-is-buffer/nodejs-is-buffer-1.1.2-1.fc24.src.rpm
Description: Determine if an object is Buffer
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303245] Review Request: lrbd - Configure iSCSI access to Ceph rbd images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303245



--- Comment #6 from Fedora Update System  ---
lrbd-1.0.2-0.1.20160129gitcc757bc.fc22 has been submitted as an update to
Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-919af89213

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303245] Review Request: lrbd - Configure iSCSI access to Ceph rbd images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303245



--- Comment #7 from Fedora Update System  ---
lrbd-1.0.2-0.1.20160129gitcc757bc.el7 has been submitted as an update to Fedora
EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-f8c8f2628e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304570] New: Review Request: nodejs-arr-flatten - Recursively flatten an array or arrays

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304570

Bug ID: 1304570
   Summary: Review Request: nodejs-arr-flatten - Recursively
flatten an array or arrays
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-arr-flatten/nodejs-arr-flatten.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-arr-flatten/nodejs-arr-flatten-1.0.1-1.fc24.src.rpm
Description: Recursively flatten an array or arrays
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304575] New: Review Request: nodejs-isobject - Returns true if the value is an object and not an array or null

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304575

Bug ID: 1304575
   Summary: Review Request: nodejs-isobject - Returns true if the
value is an object and not an array or null
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-isobject/nodejs-isobject.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-isobject/nodejs-isobject-2.0.0-1.fc24.src.rpm
Description: Returns true if the value is an object and not an array or null
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304575] Review Request: nodejs-isobject - Returns true if the value is an object and not an array or null

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304575

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #23 from Fedora Update System  ---
jcuber-4.3.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304576] Review Request: nodejs-is-buffer - Determine if an object is Buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304576

Jared Smith  changed:

   What|Removed |Added

 Blocks||1304580




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1304580
[Bug 1304580] Review Request: nodejs-kind-of - Get the native type of a
value
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304580] New: Review Request: nodejs-kind-of - Get the native type of a value

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304580

Bug ID: 1304580
   Summary: Review Request: nodejs-kind-of - Get the native type
of a value
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jsmith.fed...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-kind-of/nodejs-kind-of.spec
SRPM URL:
https://jsmith.fedorapeople.org/Packaging/nodejs-kind-of/nodejs-kind-of-3.0.2-2.fc24.src.rpm
Description: Get the native type of a value
Fedora Account System Username: jsmith

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1304580] Review Request: nodejs-kind-of - Get the native type of a value

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1304580

Jared Smith  changed:

   What|Removed |Added

 Blocks||956806 (nodejs-reviews)
 Depends On||1304576




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=956806
[Bug 956806] Node.js Review Tracker
https://bugzilla.redhat.com/show_bug.cgi?id=1304576
[Bug 1304576] Review Request: nodejs-is-buffer - Determine if an object is
Buffer
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269844] Review Request: jcuber - CUBE reader for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269844



--- Comment #24 from Fedora Update System  ---
jcuber-4.3.3-2.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #12 from William Moreno  ---
License is OK
License include with %license macro
Not bundled libraries
Not orphans directories
Macros are fine
Package build fine, you should disable docs generations in rawhide temporally.

There is a rpmlit issue with zero length files than you must exclude in files
or sed a comment in prep.
python2-astroquery.noarch: E: zero-length
/usr/lib/python2.7/site-packages/astroquery/cosmosim/tests/test_cosmosim.py
python2-astroquery.noarch: E: zero-length
/usr/lib/python2.7/site-packages/astroquery/alma/tests/data/empty.html
python3-astroquery.noarch: E: zero-length
/usr/lib/python3.4/site-packages/astroquery/alma/tests/data/empty.html
python3-astroquery.noarch: E: zero-length
/usr/lib/python3.4/site-packages/astroquery/cosmosim/tests/test_cosmosim.py

The python3 package requires the python(abi) remove all shebangs in prep to
avoid the python3 subpackage requires both python3 and python3

python3-astroquery (rpmlib, GLIBC filtered):
/bin/bash
python(abi)
python3-astropy
python3-beautifulsoup4
python3-html5lib
python3-keyring
python3-requests

Source checksums

http://pypi.python.org/packages/source/a/astroquery/astroquery-0.3.1.tar.gz :
  CHECKSUM(SHA256) this package :
ad67bf4f31bc9e0c45621a19f7200d701ff7b5df2d78e9ba7095e65a2f69c50d
  CHECKSUM(SHA256) upstream package :
ad67bf4f31bc9e0c45621a19f7200d701ff7b5df2d78e9ba7095e65a2f69c50d

Fix those issues and the package will be ready.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1267037] Review Request: perl-Mojolicious-Plugin-Bootstrap3 - Mojolicious + http://getbootstrap.com/

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1267037



--- Comment #11 from awill...@redhat.com  ---
That's awesome! Now openqa is unblocked :) Thank you very much for all your
help with getting the deps packaged, Emmanuel!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298715] Review Request: xlogin - Automatic X login service for systemd

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298715

Raphael Groner  changed:

   What|Removed |Added

  Alias|xlogin  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300003] Review Request: fleet-commander - Admin interface for Fleet Commander

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=133



--- Comment #7 from Alberto Ruiz  ---
(In reply to David King from comment #6)
> * the %defattr line in the files section is useless (also, why have an
> executable desktop file?):
> https://lists.fedoraproject.org/archives/list/de...@lists.fedoraproject.org/
> thread/KEO7AX3JXR2TY6OVL4M7HDISZ6YIJNKU/

spice-html5 works as a submodule and most of those files come as 755, that's
why we need the %defattr otherwise we get even more problems with the
linter/reviewer complaining about scripts without a #! header

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1303866] Review Request: lz4-java - LZ4 compression for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303866



--- Comment #2 from gil cattaneo  ---
Please, close this bug if you want import/use my work

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478



--- Comment #13 from Christian Dersch  ---
What is the problem with python(abi)? From build.log:

Provides: python3-astroquery = 0.3.1-2.fc24
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /bin/bash python(abi) = 3.5

So for python3 package wehabe a dep on python 3.5 abi as expected.

https://kojipkgs.fedoraproject.org//work/tasks/872/12640872/build.log close to
end of file

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300092] Review Request: python-socketIO-client - A socket.io client library for Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300092

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #13 from Fedora Update System  ---
python-socketIO-client-0.6.5-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-442278716c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295217] Review Request: msgpuck - a MsgPack serialization library in a self-contained header file

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295217



--- Comment #35 from Fedora Update System  ---
msgpuck-1.0.2-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-01e318faa8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300219] Review Request: python-ripe-atlas-cousteau - Python wrapper for RIPE Atlas API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300219
Bug 1300219 depends on bug 1300092, which changed state.

Bug 1300092 Summary: Review Request: python-socketIO-client - A socket.io 
client library for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1300092

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295478] Review Request: python-astroquery - Access astronomical online data resources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295478

William Moreno  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #18 from William Moreno  ---
Package Aproved
===

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review