[Bug 1306575] Review Request: disruptor-thrift-server - Thrift Server implementation backed by LMAX Disruptor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306575



--- Comment #2 from gil cattaneo  ---
I has escaped those who sponsored you, you can tell me who was sponsoring you?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1189015] Review Request: python-MDAnalysis - Analyze and manipulate molecular dynamics trajectories

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1189015



--- Comment #35 from Fedora Update System  ---
python-MDAnalysis-0.14.0-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-208b886ecc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318251] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318251

Emmanuel Seyman  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-03-19 11:46:26



--- Comment #4 from Emmanuel Seyman  ---
Built for rawhide, updates have been issued for f23 and f24.
Jikta, thank you for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1230213] Review Request: perl-Cookie-Baker - Cookie string generator / parser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1230213
Bug 1230213 depends on bug 1318251, which changed state.

Bug 1318251 Summary: Review Request: perl-Test-Time - Overrides the time() and 
sleep() core functions for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1318251

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318988] Review Request: java-1.8.0-openjdk-aarch32 - OpenJDK AArch32 porting project preview release

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318988

Yanko Kaneti  changed:

   What|Removed |Added

 CC||yan...@declera.com
Summary|Review Request:  -|- OpenJDK AArch32 porting
   ||project preview release



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269964] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964
Bug 1269964 depends on bug 1300014, which changed state.

Bug 1300014 Summary: validation failure in pcs2pcscmd due to newer schema of 
the CIB
https://bugzilla.redhat.com/show_bug.cgi?id=1300014

   What|Removed |Added

 Status|POST|CLOSED
 Resolution|--- |CURRENTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1305496] Review Request: HdrHistogram - A High Dynamic Range Histogram

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305496

Tomas Repik  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318328] New: Review Request: python-detox - Distributing activities of the tox tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318328

Bug ID: 1318328
   Summary: Review Request: python-detox - Distributing activities
of the tox tool
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: rb...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org




Spec URL: http://ralph.fedorapeople.org//python-detox.spec
SRPM URL: http://ralph.fedorapeople.org//python-detox-0.10.0-1.fc23.src.rpm

Description:
detox is the distributed version of the "tox" python testing tool.  It makes
efficient use of multiple CPUs by running all possible activities in parallel.
It has the same options and configuration that tox has so after installation
can just run::

$ detox

in the same way and with the same options with which you would run ``tox``.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318969] New: Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318969

Bug ID: 1318969
   Summary: Review Request: perl-B-Hooks-OP-Check-EntersubForCV -
Invoke callbacks on construction of entersub OPs for
certain CVs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-B-Hooks-OP-Check-EntersubForCV/perl-B-Hooks-OP-Check-EntersubForCV.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-B-Hooks-OP-Check-EntersubForCV/perl-B-Hooks-OP-Check-EntersubForCV-0.09-13.fc24.src.rpm
Description:
Invoke callbacks on construction of entersub OPs for certain CVs.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Miro Hrončok  changed:

   What|Removed |Added

   Assignee|tors...@redhat.com  |mhron...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1308779] Review Request: git-tools - Assorted git-related scripts and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308779

Anoop C S  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
  Flags|fedora-review?  |



--- Comment #15 from Anoop C S  ---
Sorry Greg,

Guidelines from the following link says that an unofficial reviewer must not
change the review request status other than adding himself to the CC list.

https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group#Show_Your_Expertise_by_Commenting_on_other_Review_Requests

So changing status back to NEW and removing the fedora-review flag...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318691] Review Request: perl-XML-CommonNS - List of commonly used XML name spaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318691

Petr Pisar  changed:

   What|Removed |Added

 Depends On||1318687




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1318687
[Bug 1318687] Review Request: perl-XML-NamespaceFactory - Simple factory
objects for SAX name-spaced names
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359



--- Comment #4 from Ralph Bean  ---
Filed this ticket on pkgdb to track that behavior: 
https://github.com/fedora-infra/pkgdb2/issues/330

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #22 from Mattia Verga  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #21)
> Build fails in mock for me. Log:
> https://in.waw.pl/~zbyszek/fedora/astrometry-build-log

Strange, I've succesfully built it in Copr:
https://copr-be.cloud.fedoraproject.org/results/mattia/Astronomy/fedora-rawhide-x86_64/00168982-astrometry/build.log.gz

Seems that ARCH_FLAGS are not the same. In Copr:
make SYSTEM_GSL=yes -j2 'ARCH_FLAGS=-O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic'

In your mock:
make SYSTEM_GSL=yes -j12 'ARCH_FLAGS=-O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong
--param=ssp-buffer-size=4 -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m32 -march=i686 -mtune=atom
-fasynchronous-unwind-tables'

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318251] Review Request: perl-Test-Time - Overrides the time() and sleep() core functions for testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318251



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.22.1)
  1 perl(Test::More)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Test-Time-0.04-1.fc25.noarch.rpm | sort | uniq -c
  1 perl(Test::Time) = 0.04
  1 perl-Test-Time = 0.04-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-Test-Time*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires 
FIX:
* Please add missing BRs
- perl(Module::Install::Include) - provides auto_include - Makefile.PL:43
- perl(Module::Install::Metadata) - provides all_from - Makefile.PL:24
- perl(Module::Install::WriteAll) - provides WriteAll - Makefile.PL:44 
* Removed BRs
- perl(Filter::Util::Call) - it is not used


TODO: Because you remove all files from repository inc, it could be done
  easily, e.g.
rm -r inc
sed -i -e '/^inc\// d' MANIFEST

In that case, the 'findutils' could be removed from BRs

TODO: You can replace %__perl macros with plain perl command.

Description is ok
TODO: Please replace ':' at the end of description with '.'

Please correct 'FIX' issue and consider fixing 'TODO' items and
provide new spec file.

The package is not approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359



--- Comment #8 from mulhern  ---
Whoops. Look's like I'll have to do a new upstream release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318676] Review Request: perl-MooseX-ArrayRef - Blessed array references with Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318676

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-MooseX-ArrayRef-0.005-1.fc25.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.22.1)
  1 perl(:VERSION) >= 5.8.0
  1 perl(Moose) >= 2.00
  1 perl(Moose::Exporter)
  1 perl(Moose::Role)
  1 perl(Moose::Util::MetaRole)
  1 perl(MooseX::ArrayRef::Meta::Class)
  1 perl(MooseX::ArrayRef::Meta::Instance)
  1 perl(Scalar::Util)
  1 perl(constant)
  1 perl(strict)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-MooseX-ArrayRef-0.005-1.fc25.noarch.rpm | sort | uniq
-c
  1 perl(MooseX::ArrayRef) = 0.005
  1 perl(MooseX::ArrayRef::Meta::Class) = 0.005
  1 perl(MooseX::ArrayRef::Meta::Instance) = 0.005
  1 perl-MooseX-ArrayRef = 0.005-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-MooseX-ArrayRef*
perl-MooseX-ArrayRef.noarch: W: invalid-license Artistic
perl-MooseX-ArrayRef.src: W: invalid-license Artistic
2 packages and 1 specfiles checked; 0 errors, 2 warnings.

Rpmlint is ok

The package looks good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306407] Review Request: ansible1.9 - SSH-based configuration management, deployment, and task execution system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306407



--- Comment #12 from Fedora Update System  ---
ansible1.9-1.9.4-2.el6 has been pushed to the Fedora EPEL 6 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262426] Review Request: golang-github-go-fsnotify-fsnotify - File system notifications for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262426



--- Comment #14 from Fedora Update System  ---
golang-github-go-fsnotify-fsnotify-1.2.0-0.4.git96c060f.fc22 has been submitted
as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-2b8e447a89

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318691] New: Review Request: perl-XML-CommonNS - List of commonly used XML name spaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318691

Bug ID: 1318691
   Summary: Review Request: perl-XML-CommonNS - List of commonly
used XML name spaces
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-XML-CommonNS/perl-XML-CommonNS.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-XML-CommonNS/perl-XML-CommonNS-0.06-1.fc25.src.rpm
Description:
This provides definitions of some XML name spaces as strings and
XML::NamespaceFactory objects.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #13 from Antonio Trande  ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #12)
> (In reply to Antonio Trande from comment #11)
> > Package Review
> > ==
> > 
> > Legend:
> > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > [ ] = Manual review needed
> > 
> >  Issues 
> > 
> > - Please, use %{_pkgdocdir} or %doc macro for documentation files.
> 
> I don't understand what you mean here. The spec already does this:
> %files doc
> %{_pkgdocdir}
> 
> 

-doc sub-package should provide its own license file; inside it, I guess you
can tag all documentation with %doc without making a
%{buildroot}%{_defaultdocdir}/tng directory.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316767] Review Request: erlang-fast_tls - TLS / SSL native driver for Erlang / Elixir

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316767



--- Comment #3 from Randy Barlow  ---
Hello Peter! I have added a debuginfo package in release 2:

Spec URL: https://rbarlow.fedorapeople.org/erlang-fast_tls.spec
SRPM URL: https://rbarlow.fedorapeople.org/erlang-fast_tls-1.0.1-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1281313] Review Request: podget - Podcast aggregator/downloader optimized for cron

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1281313



--- Comment #3 from Filip Szymański  ---
Spec URL: https://fszymanski.fedorapeople.org/podget/podget.spec
SRPM URL:
https://fszymanski.fedorapeople.org/podget/podget-0.7.11-1.fc23.src.rpm

Update to 0.7.11

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131



--- Comment #8 from Miro Hrončok  ---
OK, thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: python-librosa - a python package for music and audio analysis

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

Dominika Krejčí  changed:

   What|Removed |Added

  Flags|needinfo?(dkre...@redhat.co |
   |m)  |



--- Comment #8 from Dominika Krejčí  ---
Thanks for feedback!

Here is a new SPEC:
https://raw.githubusercontent.com/Krejdom/librosa-specfile/master/python-librosa.spec

and link to Copr:
https://copr.fedorainfracloud.org/coprs/dkrejci/librosa/build/169159/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318328] Review Request: python-detox - Distributing activities of the tox tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318328



--- Comment #2 from mulhern  ---
This looks good to me. On my F22 system, there was an error, because it
expected python2-setuptools to be python-setuptools (without the 2). But if for
F23 and above only, this shouldn't matter, AFAIU.

rpmlint clean! checksums good! license correct!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294054] Review Request: libiwpm - iWarp Port Mapper userspace daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294054

Neil Horman  changed:

   What|Removed |Added

  Flags||needinfo?(ho...@redhat.com)



--- Comment #7 from Neil Horman  ---
ok, if its in RHEL with this name, I agree we should keep it for fedora.  As
such, please docuement the licence for each binary, and provide a new spec and
rpm, and we'll be good.  Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306629] Review Request: metrics-reporter-config - Manages config for Coda Hale’s Metrics-reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306629



--- Comment #2 from gil cattaneo  ---
... sorry for the noise,
missing BuildRequires: mvn(org.apache.commons:commons-lang3)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #16 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/tng

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317306] Review Request: legofy - Make images look as LEGO blocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317306



--- Comment #5 from Omar Berroteran  ---
(In reply to William Moreno from comment #2)
> Package Review
> ==
> 
> legofy.noarch: W: no-manual-page-for-binary legofy
> 
> Replace:
> install -pDm644 %{SOURCE1} %{buildroot}%{_mandir}/man1/leggofy.1
> 
> with
> install -pDm644 %{SOURCE1} %{buildroot}%{_mandir}/man1/legofy.1
> 
> This package looks god for me, Eduardo comments are no bloquers issues, but
> I want to see some informals reviews before sponsor you as a Fedora Packager.
> 
> = MUST items =
> 
> Generic:
> [x]: Package is licensed with an open-source compatible license and meets
>  other legal requirements as defined in the legal section of Packaging
>  Guidelines.
> [x]: License field in the package spec file matches the actual license.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [x]: Package contains desktop file if it is a GUI application.
> [-]: Development files must be in a -devel package
> [x]: Package uses nothing in %doc for runtime.
> [x]: Package consistently uses macros (instead of hard-coded directory
>  names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [x]: If the package is a rename of another package, proper Obsoletes and
>  Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Package is not known to require an ExcludeArch tag.
> [x]: Large documentation must go in a -doc subpackage.
>  Note: Documentation size is 10240 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Package successfully compiles and builds into binary rpms on at least
>  one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>  Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>  license(s) in its own file, then that file, containing the text of the
>  license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package must own all directories that it creates.
> [x]: Package does not own files or directories owned by other packages.
> [x]: All build dependencies are listed in BuildRequires, except for any
>  that are listed in the exceptions section of Packaging Guidelines.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>  beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>  work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>  provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>  %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> Python:
> [ ]: Python eggs must not download any dependencies during the build
>  process.
> [ ]: A package which is used by another package via an egg interface should
>  provide egg info.
> [ ]: Package meets the Packaging Guidelines::Python
> [x]: Package contains BR: python2-devel or python3-devel
> [x]: Binary eggs must be removed in %prep
> 
> = SHOULD items =
> Generic:
> [x]: If the source package does not include license text(s) as a separate
>  file from upstream, the packager SHOULD query upstream to include it.
> [x]: Final provides and requires are sane (see attachments).
> [x]: Package functions as described.
> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [x]: Patches link to upstream bugs/comments/lists or are otherwise
>  justified.
> [x]: Description and summary sections in the package spec file contains
>  translations for supported Non-English languages, if available.
> [x]: Package should compile and build into binary rpms on all supported
>  architectures.
> [-]: %check is present and all tests pass.
> [x]: Packages should try to preserve timestamps of original installed
>  files.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be 

[Bug 1318873] New: Review Request: neurord - Stochastic reaction-diffusion simulator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318873

Bug ID: 1318873
   Summary: Review Request: neurord - Stochastic
reaction-diffusion simulator
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zbys...@in.waw.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://in.waw.pl/~zbyszek/fedora/neurord.spec
SRPM URL:
http://in.waw.pl/~zbyszek/fedora/neurord-3.0.0-1.20160317gitb17d063.src.rpm
Fedora Account System Username: zbyszek
Description:
A simulator for biological reaction-diffusion systems.
Supports exact stochastic simulation, asynchronous leaping, fixed-τ leaping,
and stepped deterministic solutions. Output can be written as CSV text or HDF5
binary files.

Notes for the reviewer:
There's a very basic python wrapper for reading HDF5 output, but it's not ready
for public consumption yet, and it's not packaged.

Tests are run by %mvn_build. They are not very exhaustive though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318059] Review Request: morituri - Accurate CD ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318059

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



--- Comment #4 from Antonio Trande  ---
Good!
I'm going to review your package but I cannot sponsor you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269056] Review Request: php-pecl-mongodb - MongoDB driver for PHP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269056



--- Comment #10 from Remi Collet  ---
Update to 1.1.5

Spec:
https://raw.githubusercontent.com/remicollet/remirepo/8e86cd8d2a6a1ade09aa86ad7f85cfa32f4be574/php/pecl/php-pecl-mongodb/php-pecl-mongodb.spec
Srpm: http://rpms.famillecollet.com/SRPMS/php-pecl-mongodb-1.1.5-1.remi.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1316186] Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1316186

T. Orsava  changed:

   What|Removed |Added

 CC||dkre...@redhat.com
  Flags||needinfo?(dkre...@redhat.co
   ||m)



--- Comment #1 from T. Orsava  ---
Hi! So here's the review:

- rpmlint says:
python3-librosa.src: E: description-line-too-long C LibROSA is a python package
for music and audio analysis. It provides the building blocks necessary to
create music information retrieval systems.  Your description lines must not
exceed 80 characters. If a line is exceeding this number, cut it to fit in two
lines.

- start with Release number 1, not 2.

- Please include all relevant files as %doc: AUTHORS, CHANGELOG, CONTRIBUTING

- Try to add %check section to run tests provided by the package if possible.

- rpmlint:
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/effects.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/time_frequency.py 644
/usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/files.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/onset.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/decorators.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/__init__.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/output.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/deprecation.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/feature/__init__.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/exceptions.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/decompose.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/display.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/audio.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/feature/utils.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/beat.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/segment.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/utils.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/version.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/__init__.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/constantq.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/feature/rhythm.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/pitch.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/core/spectrum.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/__init__.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/filters.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/util/feature_extractor.py 644
/usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/cache.py 644 /usr/bin/env
python3-librosa.noarch: E: non-executable-script
/usr/lib/python3.5/site-packages/librosa/feature/spectral.py 644 /usr/bin/env
* Suggestion: remove shebang lines (which is the first line of a file when it
starts with #!) from these files as they are unnecessary since these scripts
aren't executable.
* For an inspiration how to do this, you can look at
http://pkgs.fedoraproject.org/cgit/rpms/qutebrowser.git/tree/qutebrowser.spec
lines 42-45, I'll gladly show you how it works in person.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component

[Bug 1317622] Review Request: erlang-cowlib - Support library for manipulating Web protocols

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317622

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Randy Barlow  ---
Hello Peter! I've added a few !'s below. They are all optional at your
discretion, except for the license. The license was MIT instead of ASL, so make
sure you switch that.

I would recommend adding some short comments on each patch in the spec file.
It'd be nice to keep track of what they do and where they came from.

Nice work!


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "ISC", "Unknown or generated". 5 files have unknown license.
 Detailed output of licensecheck in /home/rbarlow/1317622-erlang-
 cowlib/licensecheck.txt
 rbarlow note: The license is MIT, but the spec lists ASL. The
 license check also found ISC. I recommend "MIT and ISC".
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: Patches link to upstream bugs/comments/lists or are otherwise
 justified.
 rbarlow: Can you add comments with links to upstream bugs or
 explanations why that's not beneficial?
[-]: Description and summary sections in the package spec file 

[Bug 1318368] Review Request: perl-IRI - Internationalized Resource Identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318368

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

$ rpm -qp --requires perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c
  1 perl(:MODULE_COMPAT_5.22.1)
  1 perl(:VERSION) >= 5.14.0
  1 perl(Data::Dumper)
  1 perl(Moo)
  1 perl(MooX::HandlesVia)
  1 perl(Scalar::Util)
  1 perl(Types::Standard)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-IRI-0.004-1.fc25.noarch.rpm | sort | uniq -c
  1 perl(IRI) = 0.004
  1 perl-IRI = 0.004-1.fc25
Binary provides are Ok.

$ rpmlint ./perl-IRI*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

BuildRequires are ok
FIX: Please add 'coreutils' - specfile line 45
TODO: perl(strict) and perl(warnings) could be part of first group of BR,
  because they are used in Makefile.PL

FIX: Remove '%clean' from spec file line 60


Please correct all 'FIX' issues and consider fixing 'TODO' items.

Otherwise package is good.
Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131

Charalampos Stratakis  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Charalampos Stratakis  ---
Everything seems good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1255370] Review Request: golang-github-opencontainers-specs - Open Container Specifications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1255370



--- Comment #30 from Fedora Update System  ---
golang-github-opencontainers-specs-0.4.0-0.1.git3ce138b.el6 has been submitted
as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-1001021a29

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318969] Review Request: perl-B-Hooks-OP-Check-EntersubForCV - Invoke callbacks on construction of entersub OPs for certain CVs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318969

Petr Pisar  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=823166
 Blocks||1231104



--- Comment #1 from Petr Pisar  ---
This unretires a package removed from Fedora because of incompatibility with
Perl 5.22.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1231104
[Bug 1231104] perl-B-Hooks-OP-Check-EntersubForCV-0.09-11.fc23: FTBFS with
Perl 5.22
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317306] Review Request: legofy - Make images look as LEGO blocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317306



--- Comment #7 from William Moreno  ---
Please also remember to bump the release tag and make a entry in the changelog
any time to you make a change to the spec.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318363] Review Request: eclipse-epp-logging - Eclipse Error Reporting tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318363

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #1 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
  Note: No javadoc subpackage present
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: Cannot find license.html in rpm(s)
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
 Please, ask to upstream to include license/s file/s
- Javadoc documentation files are generated and included in -javadoc
  subpackage
  Note: No javadoc subpackage present. Note: Javadocs are optional for
  Fedora versions >= 21
  See: https://fedoraproject.org/wiki/Packaging:Java#Javadoc_installation
 IGNORE

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "EPL-1.0", "Unknown or generated". 29 files have unknown
 license. Detailed output of licensecheck in /home/gil/1318363-eclipse-
 epp-logging/licensecheck.txt
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/eclipse/droplets
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/eclipse/droplets,
 /usr/share/eclipse
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Old add_to_maven_depmap macro is not being 

[Bug 1310128] Review Request: zpaq - Incremental journaling back-up archiver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310128



--- Comment #11 from Petr Pisar  ---
I added the bundled(libdivsufsort) Provide, the libdivsufsort copying text and
I changes the License tag so only zpaq-libs is MIT and Public Domain. I hope
that's everything.

Updated package is on these addresses:

Spec URL: https://ppisar.fedorapeople.org/zpaq/zpaq.spec
SRPM URL: https://ppisar.fedorapeople.org/zpaq/zpaq-7.05-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317306] Review Request: legofy - Make images look as LEGO blocks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317306



--- Comment #4 from Omar Berroteran  ---
(In reply to Omar Berroteran from comment #0)
> Spec URL: https://lkf.fedorapeople.org/legofy.spec
> SRPM URL: https://lkf.fedorapeople.org/legofy-1.0.0-1.fc22.src.rpm
> Description: Make images look as if they are made out of 1x1 LEGO blocks
> Fedora Account System Username: lkf

https://lkf.fedorapeople.org/legofy-1.0.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359



--- Comment #9 from mulhern  ---
Ok. It should be ready now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116



--- Comment #24 from Michel Normand  ---
package source available now in master and scratchbuild OK
http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3226265

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1292040

Antonio Trande  changed:

   What|Removed |Added

 CC|anto.tra...@gmail.com   |
  Flags|fedora-review?  |fedora-review+



--- Comment #15 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300981] Review Request: python-django-rest-framework-braces - Utilities for working with Django-Rest-Framework.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300981

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
python-django-rest-framework-braces-0.1.6-2.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-5739f5b60e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318814] New: Review Request: burp2 - Network backup / restore program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318814

Bug ID: 1318814
   Summary: Review Request: burp2 - Network backup / restore
program
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pierre.bour...@free.fr
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/yopito/fedora-epel-pkg/blob/master/burp2/burp2.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/yopito/burp2/epel-7-x86_64/00166819-burp2/burp2-2.0.34-1.git.0.984123c.el7.centos.src.rpm

Description: Burp is a network backup and restore program, using client and
server. It uses librsync in order to save network traffic and to save on the 
amount of space that is used by each backup. It also uses VSS (Volume Shadow
Copy Service) to make snapshots when backing up Windows computers.

v1.x is stated "stable" by the developper,
v2.x become more and more usable and receive all the development.
This is the burp 2.x version, to be provided along of the "burp" 1.x
package(s).

Fedora Account System Username: yopito

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318328] Review Request: python-detox - Distributing activities of the tox tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318328

mulhern  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299179] Review Request: editorconfig - tools for text editors

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299179



--- Comment #7 from Andy Lutomirski  ---
Still multiple issues.

editorconfig-libs and editorconfig-doc both unnecessarily depend on
editorconfig.  These are both serious problems -- the former will break
multilib and the latter will fail to install on anything except whatever
architecture happened to build it in koji.  Once these are fixed, they'll need
%license directives.

editorconfig-libs curiously does *not* depend on libeditorconfig.  That's
because it was built wrong:

/usr/bin/cc  -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 
-fexceptions -fstack-protector-strong --param=ssp-buffer-size=4
-grecord-gcc-swi
tches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic   
-Wl,
-z,relro -specs=/usr/lib/rpm/redhat/redhat-hardened-ld
CMakeFiles/editorconfig_b
in.dir/main.c.o  -o ../../bin/editorconfig-0.12.0 -rdynamic
../../lib/libeditorc
onfig_static.a -lpcre

To fix that, you'll either need to patch the cmake rules or fix the build
options to get it to link against the shared library.

Once you fix *that*, the %license directive in the main package can optionally
go away.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359



--- Comment #10 from Ralph Bean  ---
Nah, _isa isn't an issue here.  And the %check issue is fine.  I'm in the same
situation with a number of packages (and fwiw, I like running them yet again in
koji to catch flubs on my part, but.. your choice!)

Thanks!  I'll re-review in a moment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359



--- Comment #3 from Ralph Bean  ---
We must have a bug somewhere.  This was never actually reviewed.  Therefore the
pkgdb admin action request for a new pcakage should have failed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1306629] Review Request: metrics-reporter-config - Manages config for Coda Hale’s Metrics-reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306629

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED



--- Comment #3 from gil cattaneo  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 6 files
 have unknown license. Detailed output of licensecheck in
 /home/gil/1306629-metrics-reporter-config/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: metrics-reporter-config (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file 

[Bug 1306629] Review Request: metrics-reporter-config - Manages config for Coda Hale’s Metrics-reporter

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1306629

Tomas Repik  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301268] Review Request: python-netdiff - Python library for parsing network topology data (eg: dynamic routing protocols, NetJSON, CNML) and detect changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301268



--- Comment #10 from Fedora Update System  ---
python-netdiff-0.4.7-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-03-17 12:02:24



--- Comment #25 from Dan Horák  ---
I see it's even a regular build so we can close the bug. Please do also a
rawhide (f25) build from the master branch.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1295126] Review Request: python-guzzle_sphinx_theme - Sphinx theme used by Guzzle

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1295126

Antonio Trande  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 Whiteboard||AwaitingSubmitter
  Flags|fedora-review?  |
   |needinfo?(fa...@locati.cc)  |



--- Comment #2 from Antonio Trande  ---
Review stalled.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1308779] Review Request: git-tools - Assorted git-related scripts and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1308779



--- Comment #12 from Greg Bailey  ---
Hi Anoop,

Thanks for the analysis and pointers to further information re: licensecheck.

I checked out licensecheck against the git-tools README.md file on an Ubuntu
machine, and the version there flags README.md as "README.md: *No copyright*
UNKNOWN", even with the suggested addition you provided.  I think it's
sufficient to say that the existing README.md references the correct license,
and that that license matches GPLv3+ as specified in the .spec file.  I'm
hesitant to submit a pull request for it upstream because it's essentially a
change only to satisfy the fedora-review tool, and we can manually verify the
license referenced in README.md anyway.

Regarding the version numbers, upsteam only has one lightweight tag, "v2015.2",
and it's obviously a bit old.  There's a request to tag a new version:

  https://github.com/MestreLion/git-tools/issues/15

Since I don't know what that new tag will be ("v2016.3" or higher, presumably),
I opted to use the version and release numbering suggestions given by:

 
https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages

(See the provided example for the "kismet" RPM there).

My thinking was that once upstream releases "v2016.3" (or "v2016.4", etc.),
then I would change the RPM Version tag to "2016.3" and use a RPM Release tag
of "1", etc. from that point forward. 

Thanks again for your help!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #29 from Mattia Verga  ---
Spec URL: http://www.coolbits.it/fedora/astrometry.spec
SRPM URL: http://www.coolbits.it/fedora/astrometry-0.67-4.fc23.src.rpm

%changelog
* Sat Mar 19 2016 Mattia Verga  - 0.67-4
- Limit parallel make at 4 processes to fix build on F25
- Remove odd symlink in sources
- Fix wrong FSF address

I removed an odd link in sources main directory because it breaks the license
check part of fedora-review.
About licenses (and the wrong FSF address fix) I've asked upstream to fix
source headers, because the project was relicensed under BSD, but licenses in
source headers are a mess:
https://groups.google.com/forum/#!topic/astrometry/mCuyze3TOeM

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144



--- Comment #14 from Fedora Update System  ---
openshift-restclient-java-3.0.1-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-729f5f7830

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1302144] Review Request: openshift-restclient-java - OpenShift Java REST Client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1302144

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1284527] Review Request: opal-prd - OPAL Processor Recovery Diagnostics daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1284527

Dan Horák  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-03-17 05:56:09



--- Comment #40 from Dan Horák  ---
Package built, closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318933] Add (extend) yajl package to EPEL-5

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318933

yopito  changed:

   What|Removed |Added

   See Also||https://bugzilla.redhat.com
   ||/show_bug.cgi?id=1318967



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318368] New: Review Request: perl-IRI - Internationalized Resource Identifiers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318368

Bug ID: 1318368
   Summary: Review Request: perl-IRI - Internationalized Resource
Identifiers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://ppisar.fedorapeople.org/perl-IRI/perl-IRI.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-IRI/perl-IRI-0.004-1.fc25.src.rpm
Description:
The IRI module provides an object representation for Internationalized
Resource Identifiers (IRIs) as defined by RFC 3987 and supports their
parsing, serializing, and base resolution.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #26 from Mattia Verga  ---
The problem is that F25 seems to have set parallel building to 16 concurrent
threads (make -j16) while F24 had 4 (make -j4) and this doesn't like to
astrometry package.
In fact, in F24 astrometry builds fine:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13383841

By forcing the -j4 flag it also builds in rawhide:
http://koji.fedoraproject.org/koji/taskinfo?taskID=13384253

Now, since the Guidelines say "Whenever possible, invocations of make should be
done as make %{?_smp_mflags}", I think I can use that custom value instead of
default macro to overcome the problem, right?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318059] Review Request: morituri - Accurate CD ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318059



--- Comment #7 from Stefan Nuxoll  ---
One quick edit, I removed the plugins directory from the files list since I
switched to including %{_libdir}/morituri, updated spec is again at
https://snuxoll.fedorapeople.org/packages/morituri.spec and here's the scratch
build http://koji.fedoraproject.org/koji/taskinfo?taskID=13377698

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 794793] Fedora - Review Request: openssl-ibmpkcs11 - An openssl PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=794793

IBM Bug Proxy  changed:

   What|Removed |Added

  Flags|needinfo?(bugpr...@us.ibm.c |
   |om) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318363] New: Review Request: eclipse-epp-logging - Eclipse Error Reporting tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318363

Bug ID: 1318363
   Summary: Review Request: eclipse-epp-logging - Eclipse Error
Reporting tool
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: sc...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec
URL:https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging.spec
SRPM URL:
https://sopotc.fedorapeople.org/eclipse-epp-logging/eclipse-epp-logging-1.100.0-0.1.gitc6ce9f2.fc23.src.rpm

Description: EPP Logging provides a set of logging plugins for the Eclipse IDE.
Fedora Account System Username:sopotc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318699] New: Review Request: perl-XML-Namespace - Simple support for XML name spaces

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318699

Bug ID: 1318699
   Summary: Review Request: perl-XML-Namespace - Simple support
for XML name spaces
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ppi...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://ppisar.fedorapeople.org/perl-XML-Namespace/perl-XML-Namespace.spec
SRPM URL:
https://ppisar.fedorapeople.org/perl-XML-Namespace/perl-XML-Namespace-0.02-1.fc25.src.rpm
Description:
This Perl module implements a simple object for representing XML name spaces
in Perl. It provides little more than some syntactic sugar for your Perl
programs, saving you the bother of typing lots of long-winded URIs.

Fedora Account System Username: ppisar

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298238] Review Request: python-babelfish - Python library to work with countries and languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298238



--- Comment #9 from Fedora Update System  ---
python-babelfish-0.5.5-2.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-9943a37645

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318359] New: Review Request: python-justbases - precise conversion between arbitrary bases

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318359

Bug ID: 1318359
   Summary: Review Request: python-justbases - precise conversion
between arbitrary bases
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: amulh...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mulhern.fedorapeople.org/python-justbases.spec
SRPM URL: https://mulhern.fedorapeople.org/python-justbases-0.5-1.fc22.src.rpm
Description: precise conversion between arbitrary bases
Fedora Account System Username: mulhern

Copr: https://copr.fedorainfracloud.org/coprs/mulhern/justbases/build/168721/
Pipy: https://pypi.python.org/pypi/justbases

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1299139] Review Request: astrometry - Tools from Astrometry.net

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1299139



--- Comment #21 from Zbigniew Jędrzejewski-Szmek  ---
Build fails in mock for me. Log:
https://in.waw.pl/~zbyszek/fedora/astrometry-build-log

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1294054] Review Request: libiwpm - iWarp Port Mapper userspace daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1294054

Neil Horman  changed:

   What|Removed |Added

  Flags||fedora-review+
   ||needinfo?(ho...@redhat.com)



--- Comment #9 from Neil Horman  ---
looks good, ack

I've sponsored your for fedora packager, so you should be able to complete this
review and get the dist-git area created for it

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1313942] Review Request: golang-github-docker-go - Go packages with small patches autogenerated

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1313942



--- Comment #10 from Fedora Update System  ---
golang-github-docker-go-1.5.1-0.2.gitd30aec9.fc24 has been pushed to the Fedora
24 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7994971b71

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318988] New: Review Request: -

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318988

Bug ID: 1318988
   Summary: Review Request:  - 
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jva...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/3/java-1.8.0-openjdk.spec
SRPM URL:
https://jvanek.fedorapeople.org/java-1.8.0-openjdk-aarch32-jit/bins/java-1.8.0-openjdk-aarch32-1.8.0.tip-3.tip.fc24/java-1.8.0-openjdk-aarch32-1.8.0.tip-3.tip.fc24.src.rpm
Description: A preview release of the upstream OpenJDK AArch32 porting project.
In time it will be merged with the main java-1.8.0-openjdk package.
Fedora Account System Username: jvanek

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1122577] Review Request: git-xcleaner - TUI interface for git branch removal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1122577



--- Comment #21 from Fedora Update System  ---
git-xcleaner-1.5-1.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-a66b7c5bcf

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1298238] Review Request: python-babelfish - Python library to work with countries and languages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1298238



--- Comment #10 from Fedora Update System  ---
python-babelfish-0.5.5-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1b19ab357f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1262426] Review Request: golang-github-go-fsnotify-fsnotify - File system notifications for Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1262426



--- Comment #13 from Fedora Update System  ---
golang-github-go-fsnotify-fsnotify-1.2.0-0.4.git96c060f.el6 has been submitted
as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-49821494c3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1300981] Review Request: python-django-rest-framework-braces - Utilities for working with Django-Rest-Framework.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1300981

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1269964] Rebase clufter component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1269964

Jan Pokorný  changed:

   What|Removed |Added

 Depends On||1319260



-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1270358] Review Request: nacl-newlib - C library intended for use on embedded systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270358

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Blocks||1270357
 Depends On|1270357 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1270357
[Bug 1270357] Review Request: nacl-gcc - Various compilers (C, C++) for
nacl
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318676] Review Request: perl-MooseX-ArrayRef - Blessed array references with Moose

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318676

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318328] Review Request: python-detox - Distributing activities of the tox tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318328



--- Comment #5 from Fedora Update System  ---
python-detox-0.10.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c499b8ee96

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1312963

Jonathan Underwood  changed:

   What|Removed |Added

 CC||jonathan.underw...@gmail.co
   ||m



--- Comment #1 from Jonathan Underwood  ---
Unfortunately, while starting a review, I found this doesn't build on rawhide:

+ /usr/lib/rpm/find-lang.sh
/builddir/build/BUILDROOT/glibc-arm-linux-gnu-2.23-1.fc25.x86_64 libc
No translations found for libc in
/builddir/build/BUILDROOT/glibc-arm-linux-gnu-2.23-1.fc25.x86_64
error: Bad exit status from /var/tmp/rpm-tmp.orb7iQ (%install)
RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.orb7iQ (%install)
Child return code was: 1


Probably fallout from the glibc langpack re-jigging.

If you can fix that, I'll pick up the review next week - am about to hit the
road for a few days. I'll leave the bug untaken for now, in case you fixi it
and someone else is just aching to review it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317592] Review Request: rubygem-websocket-extensions - Generic extension manager for WebSocket connections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317592



--- Comment #6 from Jun Aruga  ---
Hi, Vit

I updated the spec and srpm file following your review again. [1]
Also finished to run Mock and Koji for test again.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13366172

[1]
$ git diff 3e6b5d0cfe833e89748d87df2934732cfe32d92b
rubygem-websocket-extensions.spec 
diff --git a/rubygem-websocket-extensions.spec
b/rubygem-websocket-extensions.spec
index f9c419c..0a628f9 100644
--- a/rubygem-websocket-extensions.spec
+++ b/rubygem-websocket-extensions.spec
@@ -58,9 +58,8 @@ cp -a .%{gem_dir}/* \

 # Run the test suite
 %check
-tar -xzf %{SOURCE1}
-cp -pr spec/ ./%{gem_instdir}
 pushd .%{gem_instdir}
+tar -xzf %{SOURCE1}
 rspec spec
 popd

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131



--- Comment #1 from Miro Hrončok  ---
License file is missing in the tarball, here is an attempt to fix that:
https://github.com/dougn/coverage_pth/pull/4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #12 from Fedora Update System  ---
python-coverage_pth-0.0.1-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-1ea4c96a56

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1317131] Review Request: python-coverage_pth - Coverage PTH file to enable coverage at the virtualenv level

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1317131



--- Comment #10 from Fedora Update System  ---
python-coverage_pth-0.0.1-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7fbd5e8fd0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1278140] Review Request: planarity - Implementations of several planarity-related graph algorithms

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1278140

Paulo Andrade  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-03-18 12:23:46



--- Comment #6 from Paulo Andrade  ---
Package is available. Closing bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318059] Review Request: morituri - Accurate CD ripper

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318059



--- Comment #8 from Antonio Trande  ---
(In reply to Stefan Nuxoll from comment #6)
> > However, to what is %{_libdir}/morituri/plugins needed ?
> 
> Morituri supports arbitrary plugins, some of which are installed via the
> entry_points mechanism provided by python eggs and others are simply dropped
> into the plugins folder. Providing this folder in the package gives a place
> for users to manually install plugins, and for other plugins to be installed
> into via packages.
> 
> I have updated the spec file with fixes to all the listed issues, still
> available at: https://snuxoll.fedorapeople.org/packages/morituri.spec
> 
> A new koji scratch build is available here:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=13377643

I doubt that we can package an arched directory in a noarch package. I seen
some monituri plugins installed in $HOME/.morituri/plugins, that makes useless
an (empty) arched directory.

@MichaelSchwendt
please, can you help us in this situation ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 794793] Fedora - Review Request: openssl-ibmpkcs11 - An openssl PKCS#11 engine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=794793

Hanns-Joachim Uhl  changed:

   What|Removed |Added

Summary|Review Request: |Fedora - Review Request:
   |openssl-ibmpkcs11 - An  |openssl-ibmpkcs11 - An
   |openssl PKCS#11 engine  |openssl PKCS#11 engine



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301268] Review Request: python-netdiff - Python library for parsing network topology data (eg: dynamic routing protocols, NetJSON, CNML) and detect changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301268

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-03-17 16:54:13



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1314213] Review Request: golang-github-docker-go-connections - Utility package to work with network connections

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1314213



--- Comment #6 from Fedora Update System  ---
golang-github-docker-go-connections-0.1.2-0.1.git6e4c13d.fc23 has been pushed
to the Fedora 23 testing repository. If problems still persist, please make
note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-13ceab1094

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1301116] Review Request: libcxl - Coherent accelerator interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301116

Dan Horák  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1310092] Review Request: cryptobone - Secure Communication Under Your Control

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310092



--- Comment #19 from Richard Shaw  ---
Before you post a new spec and SRPM go ahead and remove the chkconfig stuff. No
need to add it just to silence rpmlint. We have to review all rpmlint errors
but it is sometimes wrong and we can choose to ignore it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1310092] Review Request: cryptobone - Secure Communication Under Your Control

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1310092



--- Comment #17 from Richard Shaw  ---
(In reply to Ralf Senderek from comment #16)
>> (In reply to Richard Shaw from comment #14)
> > I'm assuming the sudogetuser in %post creates an interactive prompt?
> > 
> > Unfortunately the guidelines strictly forbid interactive installs, it's one
> > of the biggest differences between Fedora/Redhat and Debian philosophies. 
> > 
> 
> OK, I've made the whole installation process non-interactive now!

Ok, good. While I understand why you wanted it, I was worried about gui based
installs, I'm not even sure what would happen.


> > 
> > Also, this is probably not compliant:
> > 
> > 
> >  if ! systemctl is-active sshd > /dev/null ; then
> >   systemctl enable sshd 
> >  fi
> 
> I have added a line "Requires=sshd.service" to the cryptoboned.service file
> and removed the code above from the spec file.

OK.


> > Some other script feedback:
> > 
> > Daemons are not allowed to be enabled on install unless they have been
> > approved to do so. You should be using the systemd macros which take care of
> > this for you:
> 
> OK, I have resolved these issues by transferring the activation of my daemons
> to the source code (/usr/lib/cryptobone/sudogetuser). The spec file now has
> a %prosttrans section, which informs the user to run this script.
> This can be done any time, as long as the user has knowledge of the 
> root password, to set the sudoers.d/cbcontrol file and to activate the
> deamon.

Ok, I may have to dig into this one a bit. There is actually a process to get
permission to be enabled by default, I believe it requires an FPC ticket but
really I don't for this kind of process that it's unreasonable to have them
read a little documentation so they know why they're getting into and enable
the daemon explicitly.

This is a pretty invasive package so I appreciate your patience with getting me
up to speed and making all the requisite changes.

I'll start on the full review as soon as I have a few moments.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318358] Review Request: copr-dist-git - Copr services for Dist Git server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318358

Adam Samalik  changed:

   What|Removed |Added

 CC||asama...@redhat.com



--- Comment #1 from Adam Samalik  ---
I have found 1 issue. I didn't have time to check the Python items.

Everything else except the following 5 items passed.

[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/copr,
 /etc/logrotate.d

Python:
[ ]: Python eggs must not download any dependencies during the build
 process.
[ ]: A package which is used by another package via an egg interface should
 provide egg info.
[ ]: Package meets the Packaging Guidelines::Python
[ ]: Binary eggs must be removed in %prep

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Bug 1318310] New: Review Request: python-magnum-ui - OpenStack Magnum UI Horizon plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1318310

Bug ID: 1318310
   Summary: Review Request: python-magnum-ui - OpenStack Magnum UI
Horizon plugin
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: marcos.fermin.l...@cern.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://mferminl.web.cern.ch/mferminl/fedorapkg/python-magnum-ui/0.0.1/python-magnum-ui.spec
SRPM URL:
http://mferminl.web.cern.ch/mferminl/fedorapkg/python-magnum-ui/0.0.1/python-magnum-ui-0.0.1.dev13-1.fc23.src.rpm
Description: This is the UI component for the OpenStack Containers Service
(Magnum).
Fedora Account System Username: mflobo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/package-review