[Bug 1239267] Review Request: innoextract - Inno Setup installers extractor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1239267



--- Comment #15 from Alexandre Detiste  ---
See as an example, for Wolfenstein3D, all the tweaks needed for Fedora are
already there:

https://github.com/a-detiste/game-data-packager/blob/master/data/wolf3d.yaml

All ScummVM games are also supported, but doesn't need any tweak,
as G-D-P also create the .desktop files that launches the games.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1239267] Review Request: innoextract - Inno Setup installers extractor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1239267



--- Comment #14 from Alexandre Detiste  ---
Yup, it build noarch rpm's for local consumption.
(or you build it on your desktop &
move it to some ARM play-thing)

Only 'binary' RPMS, not source ones.
It dynamically writes a .specfile based on
contents from cross-distro .yaml files
the run rpmbuild.

It can also use lgogdownloader (not yet packaged)
& steamcmd (non-free, a pain to make it work).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297491] Review Request: python2-multilib - A module for determining if a package is multilib or not

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297491

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Zbigniew Jędrzejewski-Szmek  ---
+ latest version
+ package name is OK
+ provides/requires are OK
+ %python_require is used
+ "common python template" is used
+ license file is present, %license is used
+ license is acceptable (GPLv2)

rpmlint:
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
-devel must require specific version: raqm%{?_isa} = %{version}-%{release}

Wouldn't it be better to call this package libraqm? Upstream uses both
"libraqm" and "raqm" in various places. That's the package name in arch linux,
and consistency with other distributions is useful for users. Also it's a
library, so "lib" prefix is helpful.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1239267] Review Request: innoextract - Inno Setup installers extractor

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1239267



--- Comment #13 from Mosaab Alzoubi  ---
Is game-data-packager building rpms?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #15 from Fedora Update System  ---
qtpass-1.1.1-2.fc22 has been pushed to the Fedora 22 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-52d9d7d25f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328390] Review Request: infinipath-psm - Intel Performance Scaled Messaging (PSM) Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328390



--- Comment #16 from Fedora Update System  ---
infinipath-psm-3.3-22_g4abbc60_open.2.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4837354e9a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #20 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc22 has been pushed to the
Fedora 22 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-03bbbdeb12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327078] Review Request: python-pyrtlsdr - Python binding for librtlsdr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327078



--- Comment #11 from Fedora Update System  ---
python-pyrtlsdr-0.2.2-3.fc23.1 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #19 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc23 has been pushed to the
Fedora 23 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-38f800bb15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #14 from Fedora Update System  ---
qtpass-1.1.1-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-98dadcd224

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327



--- Comment #17 from Fedora Update System  ---
python-sphinxcontrib-pecanwsme-0.8.0-2.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8e0134b677

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1297491] Review Request: python2-multilib - A module for determining if a package is multilib or not

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1297491



--- Comment #11 from Jay Greguske  ---
Thanks for the suggestions. How about now?

https://people.redhat.com/jgregusk/not-piracy/srpms/python-multilib.spec
https://people.redhat.com/jgregusk/not-piracy/srpms/python-multilib-1.1-4.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #18 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.el6 has been pushed to the Fedora
EPEL 6 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4d3bf84d8e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330343] New: Review Request: iprange - Manage IP ranges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330343

Bug ID: 1330343
   Summary: Review Request: iprange - Manage IP ranges
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: er...@ioerror.us
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://error.fedorapeople.org/iprange.spec
SRPM URL: https://error.fedorapeople.org/iprange-1.0.2-1.fc24.src.rpm
Description: Manage IP ranges
Fedora Account System Username: error

iprange aggregates IP address ranges. It is a (new) dependency of firehol 3.0
and its absence currently blocks that package from Fedora.

$ rpmlint iprange.spec *.rpm
iprange.x86_64: W: no-manual-page-for-binary iprange
3 packages and 1 specfiles checked; 0 errors, 1 warnings.

(Upstream does not ship a man page.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330343] Review Request: iprange - Manage IP ranges

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330343

Michael Hampton  changed:

   What|Removed |Added

 Blocks||1199465




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1199465
[Bug 1199465] firehol-3.0.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1322846] Review Request: SuperLUMT - Single precision real SuperLU routines for shared memory parallel machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1322846



--- Comment #21 from Fedora Update System  ---
SuperLUMT-3.1.0-5.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309792] Review Request: fedora-motd - Generate dynamic MOTD for Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309792

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed|2016-03-13 19:53:36 |2016-04-25 19:54:23



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1322846] Review Request: SuperLUMT - Single precision real SuperLU routines for shared memory parallel machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1322846

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-25 19:54:18



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1309792] Review Request: fedora-motd - Generate dynamic MOTD for Fedora

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309792



--- Comment #23 from Fedora Update System  ---
fedora-motd-0.1.2-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327071] Review Request: libusnic_verbs - No-op libibverbs driver for the Cisco usNIC device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327071



--- Comment #16 from Fedora Update System  ---
libusnic_verbs-2.0.2-1.fc23 has been pushed to the Fedora 23 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327071] Review Request: libusnic_verbs - No-op libibverbs driver for the Cisco usNIC device

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327071

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-04-25 19:53:02



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327929] Review Request: gimpfx-foundry - Additional plugins for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327929

Mukundan Ragavan  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Mukundan Ragavan  ---
I do not think I have anything to complain about. APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327929] Review Request: gimpfx-foundry - Additional plugins for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327929



--- Comment #3 from Mukundan Ragavan  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://admin.fedoraproject.org/pkgdb/acls/name/gimpfx-foundry
  See:
 
https://fedoraproject.org/wiki/Packaging/NamingGuidelines#Conflicting_Package_Names

---> Unretiring the package. This is fine.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.

---> License not included in the source package.


[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. No licenses
 found. Please check the source files for licenses manually.


---> Pretty much every file has license headers. Headers mention what the
license is which is clearly indicated in the spec file.

[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[x]: Buildroot is not present
 Note: Buildroot: present but not needed
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.

---> Please check with upstream about including license file. Not a blocker
though.

[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in 

[Bug 1330330] New: Review Request: golang-tools-godep - Helps build packages reproducibly by fixing their dependencies

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330330

Bug ID: 1330330
   Summary: Review Request: golang-tools-godep - Helps build
packages reproducibly by fixing their dependencies
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jdula...@fedoraproject.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://rpms.jdulaney.com/review/golang-tools-godep.spec
SRPM URL: http://rpms.jdulaney.com/review/golang-tools-godep-62-1.fc24.src.rpm
Description: Helps build packages reproducibly by fixing their dependencies
Fedora Account System Username:  jdulaney

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326875] Review Request: keepassx2 - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326875



--- Comment #2 from Mukundan Ragavan  ---
Sorry for the delay. Mostly minor issues. Can be fixed easily.



Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines

---> This can be ignored. Local issue.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice:
  /usr/share/keepassx2/translations/keepassx_cs.qm
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DuplicateFiles


---> I think this is because of %{_datadir}/keepassx2 and correct usage of
%find_lang macro.

The %files section could be more descriptive to avoid these clashes.

- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.


---> Yes, this does seem to be missing (not present in post or posttrans).
Please fix this.

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or v3)", "LGPL (v2.1 or v3)", "LGPL (v2.1)", "Unknown
 or generated". 13 files have unknown license. Detailed output of
 licensecheck in

/home/mukundan/ownCloud/misc_pkgs/pkg_reviews/1326875-keepassx2/licensecheck.txt

---> Nothing seems bad.

[x]: License file installed when any subpackage combination is installed.

[?]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/keepassx2

---> This is perhaps easily fixed.

This - %{_libdir}/keepassx2/libkeepassx*.so - could be changed to 

%{_libdir}/keepassx2/*


[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/keepassx2,
 /usr/share/mime, /usr/share/mimelnk/application, /usr/share/mimelnk,
 /usr/share/mime/packages
[!]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/icons/hicolor/16x16/mimetypes(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/16x16/actions(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/32x32/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/24x24/apps(hicolor-
 icon-theme, fedora-logos, keepassx), /usr/share/icons/hicolor/24x24
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/128x128/apps(hicolor-icon-theme, keepassx),
 /usr/share/icons/hicolor/128x128/mimetypes(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/64x64(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/256x256/apps(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/64x64/mimetypes
 (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/16x16
 (hicolor-icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/48x48/apps(hicolor-icon-theme, fedora-logos,
 keepassx, nedit), /usr/share/icons/hicolor/scalable/apps(hicolor-icon-
 theme, fedora-logos, keepassx), /usr/share/icons/hicolor/22x22/actions
 (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/128x128
 (hicolor-icon-theme, keepassx),
 /usr/share/icons/hicolor/22x22/mimetypes(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/32x32(hicolor-icon-theme, fedora-
 logos, keepassx), /usr/share/icons/hicolor/256x256(hicolor-icon-theme,
 fedora-logos, keepassx), /usr/share/icons/hicolor/16x16/apps(hicolor-
 icon-theme, fedora-logos, keepassx),
 /usr/share/icons/hicolor/64x64/apps(hicolor-icon-theme, keepassx),
 /usr/share/icons/hicolor/22x22(hicolor-icon-theme, fedora-logos,
 keepassx), /usr/share/icons/hicolor/22x22/status(hicolor-icon-theme,
 keepassx), /usr/share/icons/hicolor/48x48(hicolor-icon-theme, fedora-
 logos, keepassx, nedit), /usr/share/icons/hicolor/32x32/mimetypes
 (hicolor-icon-theme, keepassx), /usr/share/icons/hicolor/scalable
 (hicolor-icon-theme, fedora-logos, keepassx)


---> This can also be easily fixed, probably.

Change %{_datadir}/icons/hicolor/*  ---> %{_datadir}/icons/hicolor/*/*/*

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: 

[Bug 1330316] Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316



--- Comment #4 from Jonny Heggheim  ---
Nice, thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330316] Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316

gil cattaneo  changed:

   What|Removed |Added

 CC||punto...@libero.it



--- Comment #3 from gil cattaneo  ---
Hi Jonny
suggestion:
use

%pom_add_dep org.iq80.leveldb:leveldb::compile core "true"
%pom_add_dep org.fusesource.hawtjni:hawtjni-runtime::compile core
"true"

OR

%pom_add_dep org.iq80.leveldb:leveldb:: core "true"
%pom_add_dep org.fusesource.hawtjni:hawtjni-runtime:: core
"true"

and remove
%global __requires_exclude
^mvn\\(org.iq80.leveldb:leveldb\\)$|^mvn\\(org.fusesource.hawtjni:hawtjni-runtime\\)$

Regards

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329807] Review Request: raqm - Complex Textlayout Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329807



--- Comment #2 from Mosaab Alzoubi  ---
Spec URL: http://pastebin.com/raw/q8Ycfukd
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/moceap/Raqm/fedora-23-x86_64/00180558-raqm/raqm-0.1.0-2.fc23.src.rpm

Everything's OK

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #48 from paul.j.re...@intel.com ---
I have removed the spec file from the tarball and pushed the changes to the
10.1 branch of github.

NEW PROCEDURE TO TEST:

On a Fedora system:
Pull the 10.1 branch from github to a sandbox.
cd sandbox
./makesrpm.sh

The final line of the script will show a line indicating the final resting
place of the src rpm.  It is suitable for submission to koji:

The source rpm is in temp.3182/SRPMS/libpsm2-10.1.3-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329125] Review Request: python-oslo-privsep - OpenStack library for privilege separation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329125



--- Comment #4 from Alan Pevec  ---
Imported to https://github.com/rdo-packages/oslo-privsep-distgit
rdoinfo review https://review.rdoproject.org/r/988

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330316] Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316



--- Comment #1 from Jonny Heggheim  ---
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=13800596

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330316] Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316



--- Comment #2 from Jonny Heggheim  ---
License headers in source files is discussed here
https://github.com/bitcoinj/bitcoinj/issues/1248

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330316] Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328889] Review Request: libiomp - Intel OpenMP runtime library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328889

Orion Poplawski  changed:

   What|Removed |Added

 CC||or...@cora.nwra.com



--- Comment #2 from Orion Poplawski  ---
See
https://fedoraproject.org/wiki/Packaging:Guidelines#Downstream_.so_name_versioning

Have you contacted upstream about providing a soname?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330316] New: Review Request: bitcoinj - A Java library implementation of the Bitcoin protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330316

Bug ID: 1330316
   Summary: Review Request: bitcoinj - A Java library
implementation of the Bitcoin protocol
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: heg...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://jonny.fedorapeople.org/bitcoinj/bitcoinj.spec
SRPM URL:
https://jonny.fedorapeople.org/bitcoinj/bitcoinj-0.14-0.1.fc24.src.rpm
Fedora Account System Username: jonny
Description: The bitcoinj library is a Java implementation of the Bitcoin
protocol,
which allows it to maintain a wallet and send/receive transactions without
needing a local copy of Bitcoin Core.

The built-in Tor support via Orchid have been disabled, Tor is still
supported via SOCKS proxy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324235] Review Request: python-cytoolz - Cython implementation of the toolz package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324235

Orion Poplawski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-04-25 17:01:08



--- Comment #4 from Orion Poplawski  ---
Checked in and built

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1305547] Review Request: lyra - High availability RabbitMQ client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1305547

Raphael Groner  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|l...@fedoraproject.org



--- Comment #3 from Raphael Groner  ---
Hi Luya,

please take this review in swap for bug #1329424.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|projects...@smart.ms
  Flags|fedora-review?  |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424

Raphael Groner  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1273579] Review Request: nest - The neural simulation tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1273579



--- Comment #16 from Ankur Sinha (FranciscoD)  ---
So, I've started working on the cmake spec. I have a question though - I need
to build it without mpi, with mpich, with openmpi, and for each of these 3,
with python2 and python3 - so, can I just build the thing SIX times in the
spec?? I've been trying to hack around and try to limit it to the minimum three
times - without mpi, with mpich and with openmpi, but it's extremely hacky and
quite frankly ugly. Thoughts?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328390] Review Request: infinipath-psm - Intel Performance Scaled Messaging (PSM) Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328390

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #15 from Fedora Update System  ---
infinipath-psm-3.3-22_g4abbc60_open.2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-cb590a5bfa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326217] Review Request: google-noto-emoji-fonts - Google Noto Emoji Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326217

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #6 from Fedora Update System  ---
google-noto-emoji-fonts-20160406-3.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8c7da67fb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #16 from Fedora Update System  ---
python-sphinxcontrib-pecanwsme-0.8.0-2.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8639584a59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327078] Review Request: python-pyrtlsdr - Python binding for librtlsdr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327078

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|NEXTRELEASE |---
   Keywords||Reopened



--- Comment #10 from Fedora Update System  ---
python-pyrtlsdr-0.2.2-3.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #17 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc24 has been pushed to the
Fedora 24 testing repository. If problems still persist, please make note of it
in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f36d18e61

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
qtpass-1.1.1-2.fc24 has been pushed to the Fedora 24 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b108c43f47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027



--- Comment #4 from Fedora Update System  ---
testng-remote-1.0.0-0.2.gitfc5cfab.fc24 eclipse-testng-6.9.11.1-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ff3c3212a4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #3 from Luya Tshimbalanga  ---
(In reply to Raphael Groner from comment #2)
> Review swap with bug #1305547? Well, it's heavily based on java and not
> related to graphics, though.

I will take it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301144] Review Request: horai-ume-fonts - Free Japanese Gothic/Mincho Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301144



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
Looks all good.

I also see the warning about , but I have no idea about it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327828] Review Request: numix - Numix Project gtk and icon themes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327828

Simone Caronni  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|negativ...@gmail.com



--- Comment #8 from Simone Caronni  ---
Hi Sascha, please add me as assignee when creating the separate package
reviews, I will review them separately.

You can use this one for one of the three packages, just rename it accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329188] Review Request: nvml - Non-Volatile Memory Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329188



--- Comment #6 from Dan Williams  ---
(In reply to Krzysztof Czurylo from comment #5)
> 1) The scripts are part of library installation/de-installation process and
> they update the magic(5) files used by file(1) command, allowing to identify
> the type of pmem* pool files based on the signature stored in the pool
> header.
> I don't know any better way to update /etc/magic file.

Send patches to update the upstream file(1).  Unless / until there is an
/etc/magic.d directory where nvml could drop it's own configuration file, it is
discouraged to live edit a system's local configuration file.

> 2) Currently, only x86_64 architecture is supported.  This is because in
> libpmem we use some Intel-specific CPU instructions (inline assembly +
> xmmintrin.h).

Can those optimized routines be swapped out for slower POSIX calls or omitted
entirely on non-x86_64 builds?  That would save you from having to go file bugs
to track unsupported archs per the guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329188] Review Request: nvml - Non-Volatile Memory Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329188

Krzysztof Czurylo  changed:

   What|Removed |Added

  Flags|needinfo?(krzysztof.czurylo |
   |@intel.com) |



--- Comment #5 from Krzysztof Czurylo  ---
1) The scripts are part of library installation/de-installation process and
they update the magic(5) files used by file(1) command, allowing to identify
the type of pmem* pool files based on the signature stored in the pool header.
I don't know any better way to update /etc/magic file.

2) Currently, only x86_64 architecture is supported.  This is because in
libpmem we use some Intel-specific CPU instructions (inline assembly +
xmmintrin.h).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324270] Review Request: python-spur - Run commands locally or over SSH using the same interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324270

Orion Poplawski  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-04-25 12:04:55



--- Comment #4 from Orion Poplawski  ---
Checked in and built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324667] Review Request: python-locket - File-based locks for Python for Linux and Windows

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324667
Bug 1324667 depends on bug 1324270, which changed state.

Bug 1324270 Summary: Review Request: python-spur - Run commands locally or over 
SSH using the same interface
https://bugzilla.redhat.com/show_bug.cgi?id=1324270

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NEXTRELEASE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301144] Review Request: horai-ume-fonts - Free Japanese Gothic/Mincho Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301144



--- Comment #7 from Karel Volný  ---
ah, what a nasty trick :-) - thanks

so here's the second try:
https://kvolny.fedorapeople.org/horai-ume-fonts.spec
https://kvolny.fedorapeople.org/horai-ume-fonts-610-1.fc23.src.rpm

there's already review+ but it'd be nice if you could take a look if I haven't
made some stupid mistake while getting rid of -common (see below for changes)

also, now I'm getting fontconfig warning about multiple families on
installation, which puzzles me ...


$ diff horai-ume-fonts.spec~ horai-ume-fonts.spec  
3a4
> %global _docdir_fmt %{name}
20c21
< Version:580
---
> Version:610
22c23
< Summary:Free Japanese Gothic/Mincho Fonts
---
> Summary:Gothic and Mincho fonts designed for easy on-screen legibility
37,38d37
< Requires:   %{name}-common = %{version}-%{release}
< 
44,53d42
< %package common
< Summary:Common files of %{name}
< Requires:   fontpackages-filesystem
< 
< %description common
< %common_desc
< 
< This package consists of files used by other %{name} packages.
< 
< 
62c51
< Requires:   %{name}-common = %{version}-%{release}
---
> Requires:   fontpackages-filesystem
74c63
< Requires:   %{name}-common = %{version}-%{release}
---
> Requires:   fontpackages-filesystem
90c79
< Requires:   %{name}-common = %{version}-%{release}
---
> Requires:   fontpackages-filesystem
102c91
< Requires:   %{name}-common = %{version}-%{release}
---
> Requires:   fontpackages-filesystem
114c103
< Requires:   %{name}-common = %{version}-%{release}
---
> Requires:   fontpackages-filesystem
157a147
> 
158a149,150
> %license license.html
> 
159a152,153
> %license license.html
> 
161,162c155
< %_font_pkg -n mincho   -f %{fontconf}-mincho.conf   ume-tm??.ttf
< %_font_pkg -n pmincho  -f %{fontconf}-pmincho.conf  ume-pm??.ttf
---
> %license license.html
163a157,158
> %_font_pkg -n mincho   -f %{fontconf}-mincho.conf   ume-tm??.ttf
> %license license.html
165c160
< %files common
---
> %_font_pkg -n pmincho  -f %{fontconf}-pmincho.conf  ume-pm??.ttf
169a165,170
> * Mon Apr 25 2016 Karel Volný  610-1
> - New version 610
> - Fixes as per the review request (rhbz#1301144)
>  - dropped -common subpackage, license included everywhere
>  - changed summary
>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #47 from Michal Schmidt  ---
(In reply to paul.j.reger from comment #46)
> (In reply to Michal Schmidt from comment #45)
> > We don't need "rpmbuild -ta " to work.
> 
> Can you please elaborate?

Our build system needs "rpmbuild -bs " and "rpmbuild -bb " to work.

> Do you would prefer that the spec file is not present in the tar ball?

Yes, I would prefer that.

> Is it an error for the spec file to be present in the tar ball, or just a
> nuisance/inconvenience?

It's not an error. Any spec files inside the tarball will just be ignored.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #46 from paul.j.re...@intel.com ---
(In reply to Michal Schmidt from comment #45)
> We don't need "rpmbuild -ta " to work.

Can you please elaborate?

Do you would prefer that the spec file is not present in the tar ball?

Is it an error for the spec file to be present in the tar ball, or just a
nuisance/inconvenience?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #45 from Michal Schmidt  ---
We don't need "rpmbuild -ta " to work.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #12 from Fedora Update System  ---
qtpass-1.1.1-2.fc22 has been submitted as an update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-52d9d7d25f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #10 from Fedora Update System  ---
qtpass-1.1.1-2.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-98dadcd224

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #11 from Fedora Update System  ---
qtpass-1.1.1-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b108c43f47

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324590] Review Request: hfi1-psm - Intel PSM Libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324590



--- Comment #44 from paul.j.re...@intel.com ---
(In reply to Don Dutile from comment #43)
> (In reply to russell.w.mcguire from comment #42)
> > Question: Does the tarball we generate need to contain any spec file. After
> > all these comments above, and viewing a lot of the SRPMs from Fedora21-23
> > download sites, I see that most all tar.balls inside the SRPMs do not
> > contain specs.
> > 
> > It seems to simplify life if we don't need to include the Fedora specific
> > SPEC file in our tarball. Is this the correct direction.
> 
> Yes. The spec file is separate from the tarball.

It seems that if a specfile is not present in the tarfile, then, rpmbuild -ta
will issue an error and fail.  For example, I have created a tarfile WITHOUT
the spec file in it, and rpmbuild issues an error:

[pjreger@Fedora23-dev wfr-psm-new-10]$ rpmbuild -ta libpsm2-10.1.2.tar.gz
error: Failed to read spec file from libpsm2-10.1.2.tar.gz

Comments please?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301144] Review Request: horai-ume-fonts - Free Japanese Gothic/Mincho Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301144



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
%_font_pkg expands to %post, %postun, and %files at the end. So you can just
add the %files entry immediately after:

%global _docdir_fmt %{name}
%_font_pkg -n gothic   -f %{fontconf}-gothic.conf   ume-tg??.ttf
%license license.html
%_font_pkg -n pgothic  -f %{fontconf}-pgothic.conf  ume-pg??.ttf
%license license.html
%_font_pkg -n uigothic -f %{fontconf}-uigothic.conf ume-ug??.ttf
%license license.html
%_font_pkg -n mincho   -f %{fontconf}-mincho.conf   ume-tm??.ttf
%license license.html
%_font_pkg -n pmincho  -f %{fontconf}-pmincho.conf  ume-pm??.ttf
%license license.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #6 from gil cattaneo  ---
(In reply to Tomas Repik from comment #5)
> Is there anything else besides the license?
> 
> --- SPECS/old/primitive.spec  2016-04-21 15:10:15.0 +0200

Correct license
> -License:   GPLv2 with exceptions

Wrong license
> +License:   GPLv2+

> 
> BTW here is koji: 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1311045] Review Request: Avago ECD RoCE User space library (libocrdma)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1311045



--- Comment #27 from Neil Horman  ---
done.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/testng-remote

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1319289] Review Request: rubygem-review - Flexible document format/conversion system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1319289



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-review

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #9 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/qtpass

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327994] Re-Review Request: python-jupyter-core - Jupyter core package. A base package on which Jupyter projects rely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327994



--- Comment #21 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-jupyter-core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027

Sopot Cela  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #2 from Sopot Cela  ---
I don't think the no-documentation warning from rpmlint is a blocker so + from
me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326277] Review Request: ocitools - Collection of tools for working with the OCI runtime specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326277

Jan Chaloupka  changed:

   What|Removed |Added

 Blocks||1330110
   ||(golang-packaging-tracker)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1330110
[Bug 1330110] Tracker for golang packaging issues
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027



--- Comment #1 from Sopot Cela  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 42 files have unknown license. Detailed output of
 licensecheck in /home/scela/reviews/1330027-testng-
 remote/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in 

[Bug 1329201] Review Request: primitive - Utility methods for Java's primitive types

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329201



--- Comment #5 from Tomas Repik  ---
Is there anything else besides the license?

--- SPECS/old/primitive.spec2016-04-21 15:10:15.0 +0200
+++ SPECS/primitive.spec2016-04-25 10:53:13.436371607 +0200
@@ -2,13 +2,14 @@
 Version:   1.2.2
 Release:   2%{?dist}
 Summary:   Utility methods for Java's primitive types
-License:   GPLv2 with exceptions
-URL:   https://github.com/mintern-java/primitive/
-Source0:  
https://github.com/mintern-java/primitive/archive/%{version}.tar.gz
+# GNU General Public License v2.0 or later, with Classpath exception
+License:   GPLv2+
+URL:   https://github.com/mintern-java/%{name}/
+Source0:  
https://github.com/mintern-java/%{name}/archive/%{version}.tar.gz
 # https://bugzilla.redhat.com/show_bug.cgi?id=1212672
 Source1:   fmpp.sh
 # https://github.com/mintern-java/primitive/issues/5
-Patch0:   
https://github.com/mintern-java/primitive/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch
+Patch0:   
https://github.com/mintern-java/%{name}/commit/cbe3d5d5a1792d0e325e948f7a765cae7ff8e2e7.patch

 BuildRequires: maven-local

BTW here is koji: 
http://koji.fedoraproject.org/koji/taskinfo?taskID=13793714

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301144] Review Request: horai-ume-fonts - Free Japanese Gothic/Mincho Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301144



--- Comment #5 from Karel Volný  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> There's no need to create horai-ume-fonts-common package just to contain the
> license.
> You can instead add the license file to every package and add
> %global _docdir_fmt %{name}
> and the license file will be co-owned by all subpackages.

I'm not sure how to do that?

- %files for each subpackage are defined using %_font_pkg

but this doesn't accept additional argument to add the license

defining

%files -n %{fontname}-gothic-fonts
%license license.html

etc. then leads to error "second %files"

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328062] Review Request: jetbrains-annotations - IntelliJ IDEA Annotations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328062

Tomas Repik  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tre...@redhat.com
   Assignee|nob...@fedoraproject.org|tre...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1084190] Review Request: hamekoz-tiempos - Simple app to calculate diff between two dates

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1084190

Claudio Rodrigo Pereyra DIaz  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |EOL
Last Closed||2016-04-25 07:38:42



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1277161] Review Request: mod_mono - ASP.NET module for Apache

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1277161

Claudio Rodrigo Pereyra DIaz  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |CURRENTRELEASE
  Flags|needinfo?(claudiorodrigo@pe |
   |reyradiaz.com.ar)   |
Last Closed||2016-04-25 07:01:35



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027

Sopot Cela  changed:

   What|Removed |Added

 CC||sc...@redhat.com
   Assignee|nob...@fedoraproject.org|sc...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1326277] Review Request: ocitools - Collection of tools for working with the OCI runtime specification

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1326277

Jan Chaloupka  changed:

   What|Removed |Added

  Flags||needinfo?(l...@redhat.com)



--- Comment #3 from Jan Chaloupka  ---
Ping, any progress on this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327078] Review Request: python-pyrtlsdr - Python binding for librtlsdr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327078



--- Comment #9 from Fedora Update System  ---
python-pyrtlsdr-0.2.2-3.fc23.1 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6563b469ce

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #16 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc24 has been submitted as an
update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8f36d18e61

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #14 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc22 has been submitted as an
update to Fedora 22.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-03bbbdeb12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #15 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.el6 has been submitted as an
update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4d3bf84d8e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327497] Review Request: golang-github-go-ini-ini - Package ini provides INI file read and write functionality in Go

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327497



--- Comment #13 from Fedora Update System  ---
golang-github-go-ini-ini-1.9.0-0.1.git193d1ec.fc23 has been submitted as an
update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-38f800bb15

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1319289] Review Request: rubygem-review - Flexible document format/conversion system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1319289



--- Comment #10 from Antonio Trande  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027

Mat Booth  changed:

   What|Removed |Added

 Blocks||1330014




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1330014
[Bug 1330014] eclipse-testng: FTBFS in rawhide due to testng no longer
shipping "remote" classes
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330027] New: Review Request: testng-remote - Modules for running TestNG remotely

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330027

Bug ID: 1330027
   Summary: Review Request: testng-remote - Modules for running
TestNG remotely
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mat.bo...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~mbooth/reviews/testng-remote.spec
SRPM URL:
https://fedorapeople.org/~mbooth/reviews/testng-remote-1.0.0-0.1.gitfc5cfab.fc25.src.rpm
Description:
TestNG Remote contains the modules for running TestNG remotely. This is
normally used by IDE to communicate with TestNG runtime, e.g. receive the
Test Result from runtime so that can display them on IDE views.
Fedora Account System Username: mbooth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1311045] Review Request: Avago ECD RoCE User space library (libocrdma)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1311045

ocrdma-dev@broadcom.com changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #26 from ocrdma-dev@broadcom.com ---
Need sponsor for this ocrdma dev account for building the package.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327078] Review Request: python-pyrtlsdr - Python binding for librtlsdr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327078



--- Comment #8 from Fedora Update System  ---
python-pyrtlsdr-0.2.2-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-909c31ca01

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327078] Review Request: python-pyrtlsdr - Python binding for librtlsdr

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327078

Jaroslav Škarvada  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-04-25 05:26:09



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327

Javier Peña  changed:

   What|Removed |Added

  Flags|needinfo?(jp...@redhat.com) |



--- Comment #15 from Javier Peña  ---
Package built and submitted to Rawhide, f24 and f23.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327



--- Comment #14 from Fedora Update System  ---
python-sphinxcontrib-pecanwsme-0.8.0-2.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8639584a59

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327



--- Comment #13 from Fedora Update System  ---
python-sphinxcontrib-pecanwsme-0.8.0-2.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-8e0134b677

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1283327

Marcos  changed:

   What|Removed |Added

 CC||jp...@redhat.com
  Flags||needinfo?(jp...@redhat.com)



--- Comment #12 from Marcos  ---
Javier,

could you please submit package as Update in Bodhi?.

Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #2 from Raphael Groner  ---
Review swap with bug #1305547? Well, it's heavily based on java and not related
to graphics, though.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org