[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #8 from Fedora Update System  ---
python-ripozo-1.3.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d8da8b529

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #17 from gil cattaneo  ---
references and differences with the original class EmptyVisitor
http://grepcode.com/file/repo1.maven.org/maven2/asm/asm-all/3.3.1/org/objectweb/asm/commons/EmptyVisitor.java/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #16 from gil cattaneo  ---
(In reply to Ville Skyttä from comment #15)
> Looks like previous revisions of the package have been removed, the latest
> has been somehow updated today without a trace in %changelog and without the
> release bumped and the previous 1.2-1 has been overwritten at
> gil.fedorapeople.org. Also the upstream bug report (link in comment 9) gives
> a hint that maybe this package has changed to use a bundled library or
> something, but there's no bundled(...) Provides in the specfile.

The package contains no library - bundle (...) -. The only significant change
is in dependencies used to be able to operate: org.apache.xbean:xbean-asm-util.
which contains only the class EmptyVisitor and "extends" only
org.objectweb.asm.ClassVisitor and is NOT
org.objectweb.asm.commons.EmptyVisitor

> I would have wanted to check the recent changes to the package to see the
> reasoning and effect behind them -- especially because the %changelog or
> comments here don't shed light on them. But that's not possible without the
> old revisions, so continuing the review would practically mean starting from
> scratch for me.

Is NOT necessary, this package use xbean-finder-shaded which contains:
xbean-asm-util
org.ow2.asm:asm
org.ow2.asm:asm-commons
but in our xbean package, have not been "masked"

> This combined with the fact that I don't actually have use for this package
> makes the whole shebang more than what I want to spend time on, so I'll bow
> out and let someone else -- hopefully one who'll be using the package --
> finish the review.

I don't care, and thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988



--- Comment #4 from Antonio Trande  ---
Spec URL: https://sagitter.fedorapeople.org/giac/giac.spec
SRPM URL: https://sagitter.fedorapeople.org/giac/giac-1.2.2-2.fc23.src.rpm


- Fix required package of pgiac

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-ripozo

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336008] Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336008

Alan Pevec  changed:

   What|Removed |Added

 CC||ape...@redhat.com
   Assignee|nob...@fedoraproject.org|ape...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270322] Review Request: chromium - A WebKit (Blink) powered web browser

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270322



--- Comment #44 from Tom "spot" Callaway  ---
I'm pushing new packages to the "old" stable repo now that will work with the
new re2 package update. The copr already has those builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988



--- Comment #3 from Antonio Trande  ---
Rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14048946

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Jerry James  changed:

   What|Removed |Added

 CC||loganje...@gmail.com



--- Comment #2 from Jerry James  ---
I just did a test build in mock, fedora-rawhide-x86_64, and 2 tests failed,
both apparently due to a longjmp problem in pari.  This may indicate either a
bug in pari, or that giac is not initializing libpari properly.

  ***   bug in PARI/GP (Segmentation Fault), please report.
*** longjmp causes uninitialized stack frame ***:
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas terminated
=== Backtrace: =
/lib64/libc.so.6(+0x780eb)[0x7f55e648e0eb]
/lib64/libc.so.6(__fortify_fail+0x37)[0x7f55e652fc77]
/lib64/libc.so.6(+0x119b9d)[0x7f55e652fb9d]
/lib64/libc.so.6(__longjmp_chk+0x2b)[0x7f55e652fafb]
../src/.libs/libgiac.so.0(+0x84d8c2)[0x7f55ec6418c2]
/lib64/libpari-gmp.so.4(pari_err+0x348)[0x7f55eb637f78]
/lib64/libpthread.so.0(+0x11490)[0x7f55e896b490]
/lib64/libpthread.so.0(__pthread_mutex_trylock+0x14)[0x7f55e8964004]
../src/.libs/libgiac.so.0(_ZN4giac15is_context_busyEPKNS_7contextE+0x16)[0x7f55ec46abb6]
../src/.libs/libgiac.so.0(_ZN4giac12check_threadEPNS_7contextE+0x2c)[0x7f55ec472adc]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x5175e)[0x561d4f1a575e]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x203df)[0x561d4f1743df]
/lib64/libc.so.6(__libc_start_main+0xf1)[0x7f55e6436231]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x27c7a)[0x561d4f17bc7a]
...
./chk_cas: line 5: 14149 Aborted (core dumped) ../src/icas
testcas > cas.tst
...
FAIL: chk_cas

... and ...

  ***   bug in PARI/GP (Segmentation Fault), please report.
*** longjmp causes uninitialized stack frame ***:
/builddir/build/BUILD/giac-1.2
.2/src/.libs/lt-icas terminated
=== Backtrace: =
/lib64/libc.so.6(+0x780eb)[0x7fd0de46f0eb]
/lib64/libc.so.6(__fortify_fail+0x37)[0x7fd0de510c77]
/lib64/libc.so.6(+0x119b9d)[0x7fd0de510b9d]
/lib64/libc.so.6(__longjmp_chk+0x2b)[0x7fd0de510afb]
../src/.libs/libgiac.so.0(+0x84d8c2)[0x7fd0e46228c2]
/lib64/libpari-gmp.so.4(pari_err+0x348)[0x7fd0e3618f78]
/lib64/libpthread.so.0(+0x11490)[0x7fd0e094c490]
../src/.libs/libgiac.so.0(_ZN4giac11kill_threadEPKNS_7contextE+0x1a)[0x7fd0e444bb0a]
../src/.libs/libgiac.so.0(_ZN4giac12check_threadEPNS_7contextE+0x338)[0x7fd0e4453de8]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x5175e)[0x563b110f275e]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x203df)[0x563b110c13df]
/lib64/libc.so.6(__libc_start_main+0xf1)[0x7fd0de417231]
/builddir/build/BUILD/giac-1.2.2/src/.libs/lt-icas(+0x27c7a)[0x563b110c8c7a]
...
./chk_fhan0: line 3: 16795 Aborted (core dumped) ../src/icas
TP00-sol.cas > TP00.tst
...
FAIL: chk_fhan0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336008] New: Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336008

Bug ID: 1336008
   Summary: Review Request: keycloak-httpd-client-install - Tools
to configure Apache HTTPD as Keycloak client
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jden...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jdennis.fedorapeople.org/package_review/keycloak-httpd-client-install.spec

SRPM URL:
https://jdennis.fedorapeople.org/package_review/keycloak-httpd-client-install-0.1-1.fc23.src.rpm

Description: Keycloak is a federated Identity Provider (IdP). Apache HTTPD
supports a variety of authentication modules which can be configured to utilize
a Keycloak IdP to perform authentication. This package contains libraries and
tools which can automate and simplify configuring an Apache HTTPD
authentication module and registering as a client of a Keycloak IdP.

Fedora Account System Username: jdennis

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336005] New: Review Request: gap-pkg-resclasses - Set-theoretic computations with Residue Classes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336005

Bug ID: 1336005
   Summary: Review Request: gap-pkg-resclasses - Set-theoretic
computations with Residue Classes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: loganje...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jjames.fedorapeople.org/gap-pkg-resclasses/gap-pkg-resclasses.spec
SRPM URL:
https://jjames.fedorapeople.org/gap-pkg-resclasses/gap-pkg-resclasses-4.4.2-1.fc25.src.rpm
Fedora Account System Username: jjames
Description: ResClasses is a GAP package for set-theoretic computations with
residue classes of the integers and a couple of other rings. The class of sets
which ResClasses can deal with includes the open and the closed sets in the
topology on the respective ring which is induced by taking the set of all
residue classes as a basis, as far as the usual restrictions imposed by the
finiteness of computing resources permit this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154

Antonio Trande  changed:

   What|Removed |Added

 Depends On|1083941 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1083941
[Bug 1083941] Review Request:  giac - Computer Algebra System
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Antonio Trande  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR),|
   |505154 (FE-SCITECH) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154
Bug 505154 depends on bug 1083941, which changed state.

Bug 1083941 Summary: Review Request:  giac - Computer Algebra System
https://bugzilla.redhat.com/show_bug.cgi?id=1083941

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE



-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1083941] Review Request: giac - Computer Algebra System

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1083941

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-05-13 14:20:00



--- Comment #39 from Antonio Trande  ---


*** This bug has been marked as a duplicate of bug 1335988 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Antonio Trande  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR),
   ||505154 (FE-SCITECH)
 CC||h...@math.jussieu.fr



--- Comment #1 from Antonio Trande  ---
*** Bug 1083941 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
https://bugzilla.redhat.com/show_bug.cgi?id=505154
[Bug 505154] Tracker: Review Requests for Science and Technology related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 505154] Tracker: Review Requests for Science and Technology related packages

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=505154

Antonio Trande  changed:

   What|Removed |Added

 Depends On||1335988




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1335988
[Bug 1335988] Review Request: giac - Computer Algebra System, Symbolic
calculus, Geometry
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335988] New: Review Request: giac - Computer Algebra System, Symbolic calculus, Geometry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335988

Bug ID: 1335988
   Summary: Review Request: giac - Computer Algebra System,
Symbolic calculus, Geometry
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: anto.tra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://sagitter.fedorapeople.org/giac/giac.spec
SRPM URL: https://sagitter.fedorapeople.org/giac/giac-1.2.2-1.fc23.src.rpm

Description:
Giac is a Computer Algebra System made by Bernard Parisse. It  provides 
features from the C/C++ libraries PARI, NTL (arithmetic), GSL (numerics), 
GMP (big integers), MPFR (bigfloats) and also
  - Efficient algorithms for multivariate polynomial operations 
(product, GCD, factorization, groebner bases),
  - Symbolic computations: solver, simplifications, limits/series, integration,
  - Linear algebra with numerical or symbolic coefficients.
  - Partial Maple and TI compatibility.
  - It has interfaces in texmacs and sagemath.

it consists of:
   - a C++ library (libgiac)
   - a command line interpreter (icas/giac)
   - an FLTK-based GUI (xcas) with interactive geometry and formal
spreadsheets.

Fedora Account System Username: sagitter

This package is for Fedora only.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1333204] Review Request: gap-pkg-utils - Utility functions for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333204

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1333204] Review Request: gap-pkg-utils - Utility functions for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333204



--- Comment #3 from Fedora Update System  ---
gap-pkg-utils-0.40-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-66642d080d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332764] Review Request: gap-pkg-factint - Advanced methods for factoring integers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332764



--- Comment #5 from Fedora Update System  ---
gap-pkg-factint-1.5.3-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b2c351067e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332764] Review Request: gap-pkg-factint - Advanced methods for factoring integers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332764

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289726

Ville Skyttä  changed:

   What|Removed |Added

 Status|ASSIGNED|NEW
 CC|ville.sky...@iki.fi |
   Assignee|ville.sky...@iki.fi |nob...@fedoraproject.org
  Flags|fedora-review?  |



--- Comment #15 from Ville Skyttä  ---
Looks like previous revisions of the package have been removed, the latest has
been somehow updated today without a trace in %changelog and without the
release bumped and the previous 1.2-1 has been overwritten at
gil.fedorapeople.org. Also the upstream bug report (link in comment 9) gives a
hint that maybe this package has changed to use a bundled library or something,
but there's no bundled(...) Provides in the specfile.

I would have wanted to check the recent changes to the package to see the
reasoning and effect behind them -- especially because the %changelog or
comments here don't shed light on them. But that's not possible without the old
revisions, so continuing the review would practically mean starting from
scratch for me.

This combined with the fact that I don't actually have use for this package
makes the whole shebang more than what I want to spend time on, so I'll bow out
and let someone else -- hopefully one who'll be using the package -- finish the
review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331952] Review Request: openstack-mistral-ui - OpenStack Mistral Dashboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331952

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #10 from Marcos  ---
Hi Mathias,

I removed python-django-horizon requirement but I don't know how to see the
tests issue that you metion.

SPEC:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral-ui/2.0.0/openstack-mistral-ui.spec
SRPM:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral-ui/2.0.0/openstack-mistral-ui-2.0.0-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846



--- Comment #3 from Fedora Update System  ---
erlang-exometer_core-1.4-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c0f58c332d

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335965] New: Review Request: py3c - Guide and compatibility macros for porting extensions to Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335965

Bug ID: 1335965
   Summary: Review Request: py3c - Guide and compatibility macros
for porting extensions to Python 3
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: pvikt...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gist.githubusercontent.com/encukou/c42efc9ec2acabe113fd55d8eba8fbe7/raw/936101f2c1806422e5b066857e056c5be88103b0/py3c.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/pviktori/py3c/fedora-rawhide-x86_64/00227932-py3c/py3c-0.5-1.fc25.src.rpm
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14046160

Description:

py3c helps you port C extensions to Python 3.

It provides a detailed guide, and a set of macros to make porting easy
and reduce boilerplate.

This is a header-only library (-devel), plus extensive documentation (-doc)

Fedora Account System Username: pviktori

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #6 from Miro Hrončok  ---
Thanks.

Parallel make has no reason here, there is nothing to be run in parallel.
Will correct the whitespace.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Tomas Orsava  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Tomas Orsava  ---
So here comes the formal review:

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 84 files have unknown license. Detailed
 output of licensecheck in /home/torsava/rpmbuild/SPECS/python-
 ripozo/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python3.5/site-packages,
 /usr/lib/python3.5
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages, /usr/lib/python3.5
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: Uses parallel make %{?_smp_mflags} macro.

Probably not rally needed here.

[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python3-ripozo , python2-ripozo , python-ripozo-doc
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from 

[Bug 1333204] Review Request: gap-pkg-utils - Utility functions for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1333204



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-utils

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1332764] Review Request: gap-pkg-factint - Advanced methods for factoring integers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1332764



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-factint

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329846] Review Request: erlang-exometer_core - Easy and efficient instrumentation of Erlang code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329846



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/erlang-exometer_core

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #4 from Miro Hrončok  ---
I've split the documentation to a common subpackage.

URLs are the same:

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-ripozo.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-ripozo-1.3.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1289726] Review Request: apache-commons-weaver - Apache Commons Weaver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1289726



--- Comment #14 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/apache-commons-weaver.spec
SRPM URL: https://gil.fedorapeople.org/apache-commons-weaver-1.2-1.fc23.src.rpm

- resolve tests failures

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14043942

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331952] Review Request: openstack-mistral-ui - OpenStack Mistral Dashboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331952

Matthias Runge  changed:

   What|Removed |Added

  Flags|needinfo?(mru...@redhat.com |
   |)   |



--- Comment #9 from Matthias Runge  ---
Marcos,

the test issue is still open.

You don't need to require on python-django-horizon, since that is pulled in via
openstack-dashboard already.

If you could fix that, I'm even inclined to approve with the stricter fedora
guidelines.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #3 from Miro Hrončok  ---
(In reply to Tomas Orsava from comment #2)
> I suggest unifying the order of Python 2 vs. Python 3 scripts in sections
> %build, %install and %check sections.

Done.

> I'd also suggest using the %{pythonX_version} macro instead of ?.? in:
> %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
> %{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info

Done.

> Otherwise the spec looks great, I'll continue with the review.

Thanks.

URLs are the same:

Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-ripozo.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-ripozo-1.3.0-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335901] Review Request: python-flask-ripozo - An extension for ripozo that brings HATEOAS/REST/Hypermedia APIs to Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335901

Miro Hrončok  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-flask-ripozo - An|python-flask-ripozo - An
   |extension for ripozo and|extension for ripozo that
   |that brings |brings
   |HATEOAS/REST/Hypermedia |HATEOAS/REST/Hypermedia
   |APIs to Flask   |APIs to Flask



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335901] Review Request: python-flask-ripozo - An extension for ripozo and that brings HATEOAS/REST/Hypermedia APIs to Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335901

Miro Hrončok  changed:

   What|Removed |Added

 Depends On||1335878




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1335878
[Bug 1335878] Review Request: python-ripozo - RESTful API framework with
HATEOAS support
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1335901




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1335901
[Bug 1335901] Review Request: python-flask-ripozo - An extension for ripozo
and that brings HATEOAS/REST/Hypermedia APIs to Flask
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335901] New: Review Request: python-flask-ripozo - An extension for ripozo and that brings HATEOAS/REST/Hypermedia APIs to Flask

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335901

Bug ID: 1335901
   Summary: Review Request: python-flask-ripozo - An extension for
ripozo and that brings HATEOAS/REST/Hypermedia APIs to
Flask
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-flask-ripozo.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-flask-ripozo-1.0.4-1.fc23.src.rpm

Description:

This package provides a dispatcher for ripozo so that you can integrate ripozo
with Flask. As with all dispatchers it is simply for getting the request
arguments and appropriately routing them to the various resources for handling.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #2 from Tomas Orsava  ---
I suggest unifying the order of Python 2 vs. Python 3 scripts in sections
%build, %install and %check sections.

I'd also suggest using the %{pythonX_version} macro instead of ?.? in:
%{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info
%{python2_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info

Otherwise the spec looks great, I'll continue with the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878



--- Comment #1 from Miro Hrončok  ---
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14043728

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Tomas Orsava  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Tomas Orsava  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||tors...@redhat.com
   Assignee|nob...@fedoraproject.org|tors...@redhat.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 708402] Review Request: tophat - A spliced read mapper for RNA-Seq

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=708402



--- Comment #14 from Dave Love  ---
For what it's worth, http://www.ccb.jhu.edu/software/tophat/index.shtml now
says tophat is "largely superseded".  There's a quick go at hisat2, the
replacement, in the above copr; it hasn't been tested, though.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335878] New: Review Request: python-ripozo - RESTful API framework with HATEOAS support

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335878

Bug ID: 1335878
   Summary: Review Request: python-ripozo - RESTful API framework
with HATEOAS support
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-ripozo.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-ripozo-1.3.0-1.fc23.src.rpm

Description:
Ripozo is a tool for building RESTful/HATEOAS/Hypermedia APIs. It provides
strong, simple, and fully qualified linking between resources, the ability
to expose available actions and necessary parameters on a resource, and
exposing multiple REST protocols (i.e. SIREN and HAL). Finally, ripozo is
highly extensible. It is able to integrate with any web framework or database
and you can easily roll out your own REST protocols.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335076] Review Request: perl-String-Dirify - String::Dirify Perl module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335076



--- Comment #1 from Petr Pisar  ---
Standalone and packages spec files differ. I will use the standalone one as it
seems more correct because it does not build-require Test::Pod module.

URL and Source0 addresses are usable. Ok.
Source archive (SHA-256:
8e66374ade8b447ba94d276616973ef8a249e5b6258b81662142daa712329d53) is original.
Ok.

FIX: The summary is a dummy text. Please use a tesx from lib/String/Dirify.pm
POD (Convert a string into a directory name).

Summary verified from lib/String/Dirify.pm. Ok.
License verified from Makefile.PL and LICENSE. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require `perl' (perl-String-Dirify.spec:16).
FIX: Build-require `perl-generators'.
FIX: Build-require `make' (perl-String-Dirify.spec:30).

All tests pass. Ok.

$ rpmlint perl-String-Dirify.spec
../SRPMS/perl-String-Dirify-1.03-1.fc25.src.rpm
../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
drwxr-xr-x2 rootroot0 May 13 14:20
/usr/share/doc/perl-String-Dirify
-rw-r--r--1 rootroot  996 May 11 01:36
/usr/share/doc/perl-String-Dirify/Changes
-rw-r--r--1 rootroot 2406 Nov 16  2010
/usr/share/doc/perl-String-Dirify/README
drwxr-xr-x2 rootroot0 May 13 14:20
/usr/share/licenses/perl-String-Dirify
-rw-r--r--1 rootroot20231 May 11 01:28
/usr/share/licenses/perl-String-Dirify/LICENSE
-rw-r--r--1 rootroot 2308 May 13 14:20
/usr/share/man/man3/String::Dirify.3pm.gz
drwxr-xr-x2 rootroot0 May 13 14:20
/usr/share/perl5/vendor_perl/String
-rw-r--r--1 rootroot 6901 May 11 01:39
/usr/share/perl5/vendor_perl/String/Dirify.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm
| sort -f | uniq -c
  1 perl(:MODULE_COMPAT_5.22.2)
  1 perl(Exporter)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm
| sort -f | uniq -c
  1 perl(String::Dirify) = 1.03
  1 perl-String-Dirify = 1.03-1.fc25
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-String-Dirify-1.03-1.fc25.noarch.rpm 
Binary dependencies resolvable. Ok.

Package builds in F25
(http://koji.fedoraproject.org/koji/taskinfo?taskID=14042709). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct all `FIX' items and provide a new spec file.
Resolution: Package NOT approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1335076] Review Request: perl-String-Dirify - String::Dirify Perl module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1335076

Petr Pisar  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||ppi...@redhat.com
   Assignee|nob...@fedoraproject.org|ppi...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329448] Review Request: Tbootxm - trusted host with boot time integrity checks

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329448

Neil Horman  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG
Last Closed||2016-05-13 07:33:54



--- Comment #4 from Neil Horman  ---
ok, but the point of a fedora review is having your code packaged as an rpm so
that we can review the code and its packaging.  I'm closing this.  Please
re-open it when you're ready to try including it in fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 771318] Review Request: showoff - Ruby web app that reads simple configuration files for a presentation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=771318
Bug 771318 depends on bug 771297, which changed state.

Bug 771297 Summary: Review Request: rubygem-bluecloth - A Ruby implementation 
of John Gruber's Markdown
https://bugzilla.redhat.com/show_bug.cgi?id=771297

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 771297] Review Request: rubygem-bluecloth - A Ruby implementation of John Gruber's Markdown

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=771297

Vít Ondruch  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
  Flags|fedora-review?  |
Last Closed||2016-05-13 05:29:24




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1321902] Review Request: qt5ct - Qt5 Configuration Tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321902



--- Comment #17 from Fedora Update System  ---
qt5ct-0.23-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-64b17587f7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331952] Review Request: openstack-mistral-ui - OpenStack Mistral Dashboard

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331952

Marcos  changed:

   What|Removed |Added

  Flags||needinfo?(mru...@redhat.com
   ||)



--- Comment #8 from Marcos  ---
Hi,

I think I address all you comments. Please check again:

SPEC:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral-ui/2.0.0/openstack-mistral-ui.spec
SRPM:
http://mferminl.web.cern.ch/mferminl/fedorapkg/openstack-mistral-ui/2.0.0/openstack-mistral-ui-2.0.0-1.fc25.src.rpm

Successful scratch: http://koji.fedoraproject.org/koji/taskinfo?taskID=14025061

Thanks

-- 
You are receiving this mail because:
You are on the CC list for the bug.
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424



--- Comment #19 from Fedora Update System  ---
gimp-save-for-web-0.29.3-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-5dba261371

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424



--- Comment #18 from Fedora Update System  ---
gimp-save-for-web-0.29.3-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-c6796ac81b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1301144] Review Request: horai-ume-fonts - Free Japanese Gothic/Mincho Fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1301144



--- Comment #16 from Fedora Update System  ---
horai-ume-fonts-610-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323334] Review Request: qtpass - Multi-platform GUI for pass

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323334



--- Comment #18 from Fedora Update System  ---
qtpass-1.1.1-2.fc22 has been pushed to the Fedora 22 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org