[Bug 1338999] Review Request: perl-MooseX-Role-Strict - Use strict 'roles' in Moose
https://bugzilla.redhat.com/show_bug.cgi?id=1338999 Jitka Plesnikova changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #1 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-MooseX-Role-Strict-0.05-1.fc25.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Moose) 1 perl(Moose::Exporter) 1 perl(Moose::Meta::Role) 1 perl(Moose::Meta::Role::Application::ToClass) 1 perl(Moose::Role) 1 perl(MooseX::Meta::Role::Strict) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -qp --provides perl-MooseX-Role-Strict-0.05-1.fc25.noarch.rpm | sort | uniq -c 1 perl(MooseX::Meta::Role::Strict) = 0.05 1 perl(MooseX::Role::Strict) = 0.05 1 perl-MooseX-Role-Strict = 0.05-1.fc25 Binary provides are Ok. $ rpmlint ./perl-MooseX-Role-Strict* perl-MooseX-Role-Strict.noarch: E: wrong-script-interpreter /usr/share/doc/perl-MooseX-Role-Strict/xt/pod.t perl 2 packages and 1 specfiles checked; 1 errors, 0 warnings. TODO: Please remove 'xt' from %doc. Please consider fixing 'TODO' items. Otherwise package looks good. Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004 Emmanuel Seyman changed: What|Removed |Added Assignee|nob...@fedoraproject.org|ppi...@redhat.com QA Contact|ppi...@redhat.com |extras...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339004] Review Request: perl-libintl-perl - Internationalization library for Perl, compatible with gettext
https://bugzilla.redhat.com/show_bug.cgi?id=1339004
--- Comment #1 from Petr Pisar ---
URL and Source0 addresses are usable. Ok.
Source archive (SHA-256:
a597e128742e1c1c973a5e968626ef55eb270e8ecde79c7a7247895f2431) is original.
Ok.
Summary and description verified from the old perl-libintl.spec. Ok.
FIX: The gettext_xs/Makefile.PL license comment is wrong. It should declare
`LGPLv2+'. I cannot find any `GPLv2+' declaration in the sources.
The license tag is Ok.
FIX: Build-require `perl-generators'.
FIX: Build-require `perl-devel' (gettext_xs/gettext_xs.xs:20).
version module is nowhere used. Ok.
MyInstall.pm is executed during the build. Ok.
TODO: Do not build-require `perl(Carp)'. It's not used when running tests.
TODO: You can replace the `-exec rm' command with `-delete' to avoid executing
`rm' in the %install section.
FIX: Tests fails for me:
./tests/03bind_textdomain_codeset_pp.t .. 1/14 # Test 8 got: "March"
(./tests/03bind_textdomain_codeset_pp.t at line 74)
# Expected: "M\xE4rz"
# ./tests/03bind_textdomain_codeset_pp.t line 74 is: ok gettext ('March'),
'M�rz';
./tests/03bind_textdomain_codeset_pp.t .. Failed 1/14 subtests
(less 3 skipped subtests: 10 okay)
[...]
Test Summary Report
---
./tests/03bind_textdomain_codeset_pp.t (Wstat: 0 Tests: 14 Failed: 1)
Failed test: 8
./tests/03dcgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2)
Failed tests: 5, 9
./tests/03dgettext_pp.t (Wstat: 0 Tests: 11 Failed: 2)
Failed tests: 5, 9
./tests/03gettext_pp.t(Wstat: 0 Tests: 8 Failed: 1)
Failed test: 5
./tests/03ngettext_pp.t (Wstat: 0 Tests: 88 Failed: 10)
Failed tests: 24-33
./tests/03pgettext_pp.t (Wstat: 0 Tests: 8 Failed: 3)
Failed tests: 5-7
This is because the ./tests/03bind_textdomain_codeset_pp.t test expects support
de_AT locale. You have to build-require glibc-langpack-de.
$ rpmlint perl-libintl-perl.spec ../SRPMS/perl-libintl-perl-1.25-1.fc25.src.rpm
../RPMS/x86_64/perl-libintl-perl-*
perl-libintl-perl.src: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
perl-libintl-perl.src: W: spelling-error %description -l en_US gettext -> get
text, get-text, Georgette
perl-libintl-perl.x86_64: W: spelling-error Summary(en_US) gettext -> get text,
get-text, Georgette
perl-libintl-perl.x86_64: W: spelling-error %description -l en_US gettext ->
get text, get-text, Georgette
perl-libintl-perl.x86_64: W: manifest-in-perl-module
/usr/share/doc/perl-libintl-perl/sample/simplecal/MANIFEST
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/ru.po
perl-libintl-perl.x86_64: E: wrong-script-interpreter
/usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL
/usr/local/bin/perl
perl-libintl-perl.x86_64: E: incorrect-fsf-address
/usr/share/doc/perl-libintl-perl/sample/simplecal/Makefile.PL
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/fr.po
perl-libintl-perl.x86_64: E: incorrect-fsf-address
/usr/share/perl5/vendor_perl/Locale/libintlFAQ.pod
perl-libintl-perl.x86_64: E: wrong-script-interpreter
/usr/share/doc/perl-libintl-perl/sample/simplecal/bin/simplecal.pl
/usr/local/bin/perl
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/pt_BR.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar_SA.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/it.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/de_AT.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/ga.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/ar.po
perl-libintl-perl.x86_64: W: file-not-utf8
/usr/share/doc/perl-libintl-perl/sample/simplecal/po/de.po
perl-libintl-perl.x86_64: E: incorrect-fsf-address
/usr/share/perl5/vendor_perl/Locale/gettext_xs.pod
3 packages and 1 specfiles checked; 5 errors, 15 warnings.
rpmlint is Ok.
TODO: Report the old FSF address.
TODO: You could correct the shell bang in the examples not to use
/usr/local/bin/perl.
File layout and permissions are Ok.
$ rpm -q --requires -p ../RPMS/x86_64/perl-libintl-perl-1.25-1.fc25.x86_64.rpm
| sort -f | uniq -c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libperl.so.5.24()(64bit)
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(:VERSION) >= 5.4.0
1 perl(base)
1 perl(bytes)
1 perl(Carp)
1 perl(constant)
1 perl(Cwd)
1 perl(DynaLoader)
1 perl(Encode)
1 perl(Encode::Alias)
1 perl(Exporter)
1 perl(File::Spec)
1 perl(integer)
1 perl(IO::Handle)
1 perl(locale)
1 perl(Local
[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema
https://bugzilla.redhat.com/show_bug.cgi?id=1327511 Remi Collet changed: What|Removed |Added CC||rcol...@redhat.com --- Comment #5 from Remi Collet --- Update to 2.0.4: https://github.com/remicollet/remirepo/commit/16231c490c01b1f4e3a19c9ca3055244bf0888b0 Spec: https://raw.githubusercontent.com/remicollet/remirepo/16231c490c01b1f4e3a19c9ca3055244bf0888b0/php/php-justinrainbow-json-schema/php-justinrainbow-json-schema.spec Srpm: http://rpms.remirepo.net/SRPMS/php-justinrainbow-json-schema-2.0.4-1.remi.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338999] Review Request: perl-MooseX-Role-Strict - Use strict 'roles' in Moose
https://bugzilla.redhat.com/show_bug.cgi?id=1338999 --- Comment #2 from Emmanuel Seyman --- Thank you, Jikta. I've amended the spec file. Spec URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX-Role-Strict.spec SRPM URL: http://people.parinux.org/~seyman/fedora/perl-MooseX-Role-Strict/perl-MooseX-Role-Strict-0.05-2.fc23.src.rpm I've also requested the repo in pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1135470] Review Request: libkscreen-qt5 - KDE display configuration library
https://bugzilla.redhat.com/show_bug.cgi?id=1135470 Ngo Than changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed|2015-01-29 09:58:40 |2016-05-25 04:26:05 --- Comment #13 from Ngo Than --- thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #2 from Martin Krizek --- Thanks for the review! Here's updated version: Spec URL: https://mkrizek.fedorapeople.org/specs/python-resultsdb_api.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/python-resultsdb_api-1.2.2-2.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338140] Review Request: guayadeque - Music player
https://bugzilla.redhat.com/show_bug.cgi?id=1338140 --- Comment #9 from MartinKG --- (In reply to Raphael Groner from comment #7) > Package Review > == > = MUST items = > Generic: > [?]: Package is licensed with an open-source compatible license and meets > other legal requirements as defined in the legal section of Packaging > Guidelines. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "BSD (3 clause)", "LGPL (v2.1 or later)", "GPL (v3 or later)", > "Unknown or generated", "*No copyright* Public domain". 169 files have > unknown license. Detailed output of licensecheck in /home/builder > /fedora-review/1338140-guayadeque/licensecheck.txt > => Please explain why those files with no license header. don't know, will ask upstream. > [x]: License file installed when any subpackage combination is installed. > [!]: If the package is under multiple licenses, the licensing breakdown > must be documented in the spec. > [x]: %build honors applicable compiler flags or justifies otherwise. > [?]: Package contains no bundled libraries without FPC exception. > => Source files without license header, see above. don't know, will ask upstream. > > [x]: Large documentation must go in a -doc subpackage. Large could be size > (~1MB) or number of files. > Note: Documentation size is 10240 bytes in 1 files. > [?]: Package complies to the Packaging Guidelines > => see above, licensing/bundling? > > = SHOULD items = > > [?]: Package functions as described. > [?]: Latest version is packaged. > => Latest commit is 13013ff, 2016-05-22. Maybe take this tarball. next package will contains the recent version > = EXTRA items = > > Generic: > [!]: Large data in /usr/share should live in a noarch subpackage if package > is arched. > Note: Arch-ed rpms have a total of 1781760 bytes in /usr/share > => Please split locales into a l10n subpackage. don't know how to split in a l10n package, need assistance here. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336728] Review Request: mozjs45 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1336728 --- Comment #6 from Marek Skalický --- Thank you very much. Spec URL: https://mskalick.fedorapeople.org/mozjs45/mozjs45.spec SRPM URL: https://mskalick.fedorapeople.org/mozjs45/mozjs45-45.1.1-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338339] Review Request: openrave - Open Robotics Automation Virtual Environment
https://bugzilla.redhat.com/show_bug.cgi?id=1338339 --- Comment #2 from Till Hofmann --- There is a COPR for openRAVE: https://copr.fedorainfracloud.org/coprs/thofmann/openrave/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1219983] Review Request: supervisor3 - updated version of supervisor
https://bugzilla.redhat.com/show_bug.cgi?id=1219983 Michel Samia changed: What|Removed |Added Status|CLOSED |NEW CC||msa...@netsuite.com Resolution|NEXTRELEASE |--- Keywords||Reopened --- Comment #5 from Michel Samia --- I'd like to re-open it. I need supervisor 3.x on EL6 so I can easily add applications to some config directory. This feature is there from 3.0. -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833
--- Comment #3 from James Hogarth ---
I'm pretty busy during the day but a couple of quick observations for you to
fix for the review:
You shouldn't have this at the start:
%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%{!?python_sitearch: %global python_sitearch %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib(1))")}
%endif
There is no fedora before 12 to build for, and I'd be surprised if EPEL5 was a
target.
Obsoletes: resultsdb_api < %{version}-%{release}
Since resultsdb_api isn't in fedora it shouldn't be in the review spec
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735
Mat Booth changed:
What|Removed |Added
Docs Contact||mat.bo...@redhat.com
Flags||fedora-review?
--- Comment #5 from Mat Booth ---
There are some minor issues:
* "Group:" tag is no longer used in Fedora, please remove
* Please fix these rpmlint warnings:
- permissions of the README.md file (chmod -x)
- mixed use of tabs and spaces in the spec file
* Drop unnecessary patch - the patch adds a dep on "wagon-webdav-jackrabbit"
and then we remove it with "%pom_xpath_remove" -- please drop the patch and fix
the invokation of pom_xpath_remove.
I can approve this package after they are fixed (don't forget to bump the
release number when you change the spec file! (e.g. with rpmdev-bumpspec
command))
The full review output follows:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[x]: If the source package does not include license text(
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735 --- Comment #6 from Sopot Cela --- Fixed the issues that were pointed out: Spec URL: https://sopotc.fedorapeople.org/mycila-pom/mycila-pom.spec SRPM URL: https://sopotc.fedorapeople.org/mycila-pom/mycila-pom-6-2.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735 Mat Booth changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #7 from Mat Booth --- Perfect, APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735 Sopot Cela changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mat.bo...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 --- Comment #4 from Martin Krizek --- Spec URL: https://mkrizek.fedorapeople.org/specs/python-resultsdb_api.spec SRPM URL: https://mkrizek.fedorapeople.org/srpms/python-resultsdb_api-1.2.2-3.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1219983] Review Request: supervisor3 - updated version of supervisor
https://bugzilla.redhat.com/show_bug.cgi?id=1219983 Michel Samia changed: What|Removed |Added Status|NEW |MODIFIED --- Comment #6 from Michel Samia --- I don't need it anymore, I found that EL6 contains upstart, which can do the job for me -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336833] Review Request: resultsdb_api - API to resultsdb
https://bugzilla.redhat.com/show_bug.cgi?id=1336833 James Hogarth changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #5 from James Hogarth --- Thanks for cleaning up those issue points. Happy with the fixes the review highlighted. Package APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1160671] Review Request: seafile - Cloud storage system
https://bugzilla.redhat.com/show_bug.cgi?id=1160671 --- Comment #13 from Nikos Roussos --- I'm not entirely sure to be honest about the warning. I can't find much relevant documentation around. seafile.x86_64: W: only-non-binary-in-usr-lib and this weird error: seafile-devel.x86_64: E: non-devel-file-in-devel-package /usr/lib64/libseafile.so.0.0.0 I'm also getting two warnings from fedora-review, that I'm not getting when building the package on my own seafile-devel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libseafile.so.0.0.0 /lib64/libgio-2.0.so.0 seafile-devel.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libseafile.so.0.0.0 /lib64/libjansson.so.4 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman changed: What|Removed |Added Flags||needinfo?(robert.amato@inte ||l.com) --- Comment #21 from Neil Horman --- Rick, I'm not an expert on java packaging, but I think your mistaken. Ant and maven pretty clearly, according to this, support setting a runtime classpath: https://maven.apache.org/plugins/maven-antrun-plugin/examples/classpaths.html -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338339] Review Request: openrave - Open Robotics Automation Virtual Environment
https://bugzilla.redhat.com/show_bug.cgi?id=1338339 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED CC||ignate...@redhat.com Assignee|nob...@fedoraproject.org|ignate...@redhat.com --- Comment #3 from Igor Gnatenko --- Thanks for very good preparation. There are some small issues from first glance, I will do full review in few hours. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1323186 --- Comment #22 from Rick Tierney --- I started researching the issue this morning, and in addition to the link you sent, I believe there is some evidence that it can be done; but I will have to run some tests to see if I can get this working. Thanks for the link! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 Rex Dieter changed: What|Removed |Added Depends On||1339405 (kf5-pimcommon) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339405 [Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1325351] Review Request: perl-RDF-NS - Popular RDF name space prefixes from prefix.cc
https://bugzilla.redhat.com/show_bug.cgi?id=1325351 Bug 1325351 depends on bug 1339244, which changed state. Bug 1339244 Summary: perl-RDF-Trine: FTBFS with perl-5.24: unsatisfied dependency https://bugzilla.redhat.com/show_bug.cgi?id=1339244 What|Removed |Added Status|NEW |CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Rex Dieter changed: What|Removed |Added Blocks||1332254 ||(kf5-calendarsupport) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1332254 [Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #2 from Rex Dieter --- OK, after building the deps kf5-pimcommon kdepim-apps-lib pkgs, builds fine. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 Rex Dieter changed: What|Removed |Added Blocks||1332255 (kf5-eventviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1332255 [Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332715] Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1332715 Rex Dieter changed: What|Removed |Added Blocks||1332255 (kf5-eventviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1332255 [Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 Rex Dieter changed: What|Removed |Added Depends On||1339406 (kf5-libkdepim), ||1332715 (kf5-kdgantt2) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1332715 [Bug 1332715] Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs https://bugzilla.redhat.com/show_bug.cgi?id=1339406 [Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 Rex Dieter changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #3 from Rex Dieter --- OK, got deps to do test build, and succeeds now. APPROVED (can fixup SHOULD/non-blocker items after import) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332715] Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1332715
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter ---
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=14249107
naming: ok
sources: ok
c9056f677a6e061811c6f1f6b7b029d3 kdgantt2-16.04.0.tar.xz
license: ok
URL: Not valid
1. Should fix URL to (something like):
URL: https://quickgit.kde.org/?p=%{framework}.git
macros: ok
scriptlets: ok
2. SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes: kdepim-libs%{?_isa} < 16.04.0
Conflicts: kdepim-libs%{?_isa} < 16.04.0
Otherwise, pretty simple and clean, follows conventions of other kf5/pim
related packages.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 --- Comment #4 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 --- Comment #3 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332715] Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1332715 --- Comment #2 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332717] Review Request: kf5-incidenceeditor - KDE PIM library for creating and editing calendar incidences
https://bugzilla.redhat.com/show_bug.cgi?id=1332717
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter ---
gathered depdendencies, and local build succeeds/installs ok.
naming: ok
sources: ok
f0a3c650704e906d191e67364274ac0b incidenceeditor-16.04.0.tar.xz
license: ok
URL: Not valid
1. SHOULD fix URL to (something like):
URL: https://quickgit.kde.org/?p=%{framework}.git
macros: ok
scriptlets: ok
2. SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes: kdepim-libs%{?_isa} < 16.04.0
Conflicts: kdepim-libs%{?_isa} < 16.04.0
Otherwise, pretty simple and clean, follows conventions of other kf5/pim
related packages.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332717] Review Request: kf5-incidenceeditor - KDE PIM library for creating and editing calendar incidences
https://bugzilla.redhat.com/show_bug.cgi?id=1332717 --- Comment #2 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 --- Comment #1 from Rex Dieter --- Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14249166 (though I'm not 100% certain all the deps are in rawhide yet) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 --- Comment #1 from Rex Dieter --- hrm, tracking down these build deps: error: Failed build dependencies: cmake(KF5Gravatar) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 cmake(KF5MailCommon) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 cmake(KF5MessageComposer) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 cmake(KF5MessageCore) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 cmake(KF5MessageList) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 cmake(KF5MessageViewer) is needed by kdepim-addons-16.04.0-1.fc24.x86_64 looks like we need (at least?) 2 more pkgs: libgravatar, messagelib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-lib - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter ---
after gathering deps by hand, builds/isntalls locally ok
naming: ok
sources: ok
677cb160d12d5731a296b3f6a24bc270 kdepim-apps-libs-16.04.0.tar.xz
license: ok
URL: Not valid
1. Should fix URL to (something like):
URL: https://quickgit.kde.org/?p=%{framework}.git
macros: ok
scriptlets: ok
2. SHOULD fix Obsoletes/Conflicts to use real pkg names (without %{?_isa}),
Obsoletes: kdepim-libs%{?_isa} < 16.04.0
Conflicts: kdepim-libs%{?_isa} < 16.04.0
Otherwise, pretty simple and clean, follows conventions of other kf5/pim
related packages.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #2 from Christian Dersch ---
Looks fine :) => Approved
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2)", "LGPL (v2 or later)", "GPL (v2 or later)",
"Unknown or generated", "GPL (v2 or later) (with Qt exception)", "GPL
(v2)". 3 files have unknown license. Detailed output of licensecheck
in /home/review/1339406-kf5-libkdepim/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/dbus-1,
/usr/lib64/cmake, /usr/lib64/qt5/mkspecs,
/usr/lib64/qt5/mkspecs/modules, /usr/include/KF5, /usr/lib64/qt5,
/usr/share/dbus-1/interfaces
[x]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/kdepimwidgets
(kdepim-common), /usr/share/kdepimwidgets/pics(kdepim-common)
===> We have a proper "Conflicts" here => Fine
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under
[Bug 1332719] Review Request: kdepim-apps-lib - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 --- Comment #2 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1335078] Review Request: perl-Template-Plugin-HTML-Strip - HTML:: Strip filter for Template Toolkit
https://bugzilla.redhat.com/show_bug.cgi?id=1335078 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Template-Plugin-HTML-Strip -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338999] Review Request: perl-MooseX-Role-Strict - Use strict 'roles' in Moose
https://bugzilla.redhat.com/show_bug.cgi?id=1338999 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-MooseX-Role-Strict -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1190735] Review Request: mycila-pom - Mycila parent POM
https://bugzilla.redhat.com/show_bug.cgi?id=1190735 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mycila-pom -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336728] Review Request: mozjs45 - JavaScript interpreter and libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1336728 --- Comment #7 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mozjs45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-eventviews -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-calendarsupport -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332715] Review Request: kf5-kdgantt2 - KDE PIM library for rendering Gantt graphs
https://bugzilla.redhat.com/show_bug.cgi?id=1332715 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-kdgantt2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332717] Review Request: kf5-incidenceeditor - KDE PIM library for creating and editing calendar incidences
https://bugzilla.redhat.com/show_bug.cgi?id=1332717 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-incidenceeditor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405
Christian Dersch changed:
What|Removed |Added
Status|ASSIGNED|POST
Flags|fedora-review? |fedora-review+
--- Comment #1 from Christian Dersch ---
Looks fine => Approved!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or
generated", "GPL (v2) LGPL (v2)", "GPL (v2 or v3)", "LGPL", "GPL
(v2)". 3 files have unknown license. Detailed output of licensecheck
in /home/review/1339405-kf5-pimcommon/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib64/qt5,
/usr/include/KF5, /usr/lib64/qt5/mkspecs, /usr/lib64/cmake,
/usr/lib64/qt5/mkspecs/modules
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[?]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
===> Did you ask upstream?
[x]: Fin
[Bug 1339302] Review Request: libintelnvm-cli - Framework library supporting common Intel NVM storage CLI applications.
https://bugzilla.redhat.com/show_bug.cgi?id=1339302 Janet Morgan changed: What|Removed |Added Blocks||1270998 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332722] Review Request: kleopatra - KDE certificate manager and unified crypto GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1332722
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Rex Dieter ---
after gathering deps by hand, builds/installs locally ok
naming: ok
sources: ok
7aeed41d95d0fc4abbeabf783c76377c kleopatra-16.04.0.tar.xz
license: ok
URL: Not valid
1. SHOULD fix URL to (something like):
URL: https://quickgit.kde.org/?p=%{name}.git
macros: ok
scriptlets: ok
Otherwise, pretty simple and clean, follows conventions of other kf5/pim
related packages.
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332722] Review Request: kleopatra - KDE certificate manager and unified crypto GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1332722 --- Comment #2 from Rex Dieter --- pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332722] Review Request: kleopatra - KDE certificate manager and unified crypto GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1332722 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kleopatra -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 --- Comment #3 from Rex Dieter --- Thanks! pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-lib - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kdepim-apps-lib -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-pimcommon -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/kf5-libkdepim -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 --- Comment #2 from Rex Dieter --- Thanks! pkgdb request submitted -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 Matthias Clasen changed: What|Removed |Added Assignee|nob...@fedoraproject.org|mcla...@redhat.com --- Comment #8 from Matthias Clasen --- Taking this then -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #9 from Matthias Clasen --- rpmlint output: $ rpmlint flatpak-0.6.0-1.fc25.src.rpm flatpak.src: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed 1 packages and 0 specfiles checked; 0 errors, 1 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] New: Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Bug ID: 1339703 Summary: Review Request: kf5-libgravatar - Gravatar support library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libgravatar.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libgravatar-16.04.1-1.fc24.src.rpm Description: Gravatar support library Fedora Account System Username: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Depends On||1339405 (kf5-pimcommon) Alias||kf5-libgravatar Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1339405 [Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Rex Dieter changed: What|Removed |Added Blocks||1339703 (kf5-libgravatar) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339703 [Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Christian Dersch changed: What|Removed |Added Status|NEW |ASSIGNED CC||lupi...@mailbox.org Assignee|nob...@fedoraproject.org|lupi...@mailbox.org Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #10 from Matthias Clasen --- And here is the rpmlint output for the binary rpms: $ rpmlint flatpak-*x86_64.rpm flatpak.x86_64: W: spelling-error %description -l en_US sandboxed -> sandboxes, sand boxed, sand-boxed flatpak.x86_64: W: non-conffile-in-etc /etc/dbus-1/system.d/org.freedesktop.Flatpak.SystemHelper.conf flatpak.x86_64: W: non-conffile-in-etc /etc/profile.d/flatpak.sh flatpak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/flatpak-0.6.0/libglnx/glnx-libcontainer.c flatpak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/flatpak-0.6.0/libglnx/glnx-console.h flatpak-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/flatpak-0.6.0/libglnx/glnx-console.c flatpak-devel.x86_64: W: spelling-error %description -l en_US config -> con fig, con-fig, configure flatpak-devel.x86_64: W: obsolete-not-provided xdg-app-devel flatpak-devel.x86_64: W: only-non-binary-in-usr-lib flatpak-libs.x86_64: W: spelling-error %description -l en_US libflatpak -> inflatable flatpak-libs.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/flatpak/bwrap flatpak-libs.x86_64: E: missing-call-to-chdir-with-chroot /usr/lib64/libflatpak.so.0.600.0 flatpak-libs.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 5 errors, 8 warnings. The incorrect fsf addresses should probably be reported back to libglnx upstream, but I don't think that blocks the review. The missing-call-to-chdir-with-chroot warning is just wrong. The code calls chdir right before and after chroot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 --- Comment #1 from Rex Dieter --- Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libgravatar.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-libgravatar-16.04.1-2.fc24.src.rpm %changelog * Wed May 25 2016 Rex Dieter - 16.04.1-2 - BR: kf5-ktextwidgets-devel -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Rex Dieter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-25 13:01:05 --- Comment #4 from Rex Dieter --- imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Bug 1339703 depends on bug 1339405, which changed state. Bug 1339405 Summary: Review Request: kf5-pimcommon - PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339405 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 Bug 1332254 depends on bug 1339405, which changed state. Bug 1339405 Summary: Review Request: kf5-pimcommon - PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339405 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332254] Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling
https://bugzilla.redhat.com/show_bug.cgi?id=1332254 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-25 13:04:23 --- Comment #5 from Rex Dieter --- imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332720] Review Request: kdepim-addons - Additional plugins for KDE PIM applications
https://bugzilla.redhat.com/show_bug.cgi?id=1332720 Bug 1332720 depends on bug 1332254, which changed state. Bug 1332254 Summary: Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling https://bugzilla.redhat.com/show_bug.cgi?id=1332254 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 Bug 1332255 depends on bug 1332254, which changed state. Bug 1332254 Summary: Review Request: kf5-calendarsupport - KDE PIM library for calendar and even handling https://bugzilla.redhat.com/show_bug.cgi?id=1332254 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #11 from Matthias Clasen --- checklist: package naming: ok spec file name: ok packaging guidelines: ok license: ok license field: ok license file: ok spec language: ok spec legibility: excellent upstream sources: the latest tarball found at the source url is 0.6.0. need to clarify with Alex if tarball will continue to be on freedesktop.org or just on github buildable: ok excludearch: not needed buildrequires: ok locale handling: not needed ldconfig: ok system libraries: ok relocatable: no directory ownership: should own /usr/share/gdm/env.d or require gdm. Owning the directory is probably preferable in this case duplicate files: ok permissions: ok macro use: ok permissible content: ok large docs: not applicable %doc content: ok static libraries: none development files: ok devel package deps: ok libtool archives: ok desktop file: not applicable file ownership: ok utf8 filenames: ok In summary: fix up directory ownership -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org http://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339730] New: Review Request: c-sundry - Collection of sundry convenience headers
https://bugzilla.redhat.com/show_bug.cgi?id=1339730 Bug ID: 1339730 Summary: Review Request: c-sundry - Collection of sundry convenience headers Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: k...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/c-util/c-sundry/blob/master/c-sundry.spec SRPM URL: http://copr-dist-git.fedorainfracloud.org/cgit/@bus1/base/c-sundry.git Description: Collection of sundry convenience headers Fedora Account System Username: kay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1293694] Review Request: byte-buddy - Runtime code generation for the Java virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1293694 --- Comment #1 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/byte-buddy.spec SRPM URL: https://gil.fedorapeople.org/byte-buddy-1.3.19-1.fc23.src.rpm Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14250595 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339735] New: Review Request: c-rbtree - Red-Black Tree Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1339735 Bug ID: 1339735 Summary: Review Request: c-rbtree - Red-Black Tree Implementation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: k...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/c-util/c-rbtree/blob/master/c-rbtree.spec SRPM URL: https://copr.fedorainfracloud.org/coprs/g/bus1/base/package/c-rbtree/ Description: Standalone Red-Black Tree Implementation in Standard ISO-C11 Fedora Account System Username: kay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 --- Comment #12 from David King --- Spec URL: https://amigadave.fedorapeople.org/flatpak.spec SRPM URL: https://amigadave.fedorapeople.org/flatpak-0.6.2-1.fc25.src.rpm Updated SRPM URL for the new 0.6.2 release, and incorporating the env.d directory ownership fix. I took the tarball from github, but as you say, it would be good to know the canonical location for tarball releases. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1337434] Review Request: flatpak - Application deployment framework for desktop apps
https://bugzilla.redhat.com/show_bug.cgi?id=1337434 Matthias Clasen changed: What|Removed |Added Flags||fedora-review+ --- Comment #13 from Matthias Clasen --- thanks, looks good now -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1293694] Review Request: byte-buddy - Runtime code generation for the Java virtual machine
https://bugzilla.redhat.com/show_bug.cgi?id=1293694 --- Comment #2 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=14250625 - removed org.codehaus.mojo:clirr-maven-plugin -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339738] New: Review Request: libbus1 - Bus1 IPC Library
https://bugzilla.redhat.com/show_bug.cgi?id=1339738 Bug ID: 1339738 Summary: Review Request: libbus1 - Bus1 IPC Library Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: k...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/bus1/libbus1/blob/master/libbus1.spec SRPM URL: https://copr.fedorainfracloud.org/coprs/g/bus1/base/package/libbus1/ Description: Bus1 IPC Library Fedora Account System Username: kay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339736] New: Review Request: c-variant - GVariant Implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1339736 Bug ID: 1339736 Summary: Review Request: c-variant - GVariant Implementation Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: k...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/c-util/c-variant/blob/master/c-variant.spec SRPM URL: https://copr.fedorainfracloud.org/coprs/g/bus1/base/package/c-variant/ Description: Standalone GVariant Implementation in Standard ISO-C11 Fedora Account System Username: kay -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332256] Review Request: kf5-grantleetheme - KDE PIM library for Grantlee template system
https://bugzilla.redhat.com/show_bug.cgi?id=1332256 Rex Dieter changed: What|Removed |Added Blocks||1339737 (kf5-messagelib) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339737 [Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1336008] Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client
https://bugzilla.redhat.com/show_bug.cgi?id=1336008
Rob Crittenden changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|ape...@redhat.com |rcrit...@redhat.com
--- Comment #3 from Rob Crittenden ---
I'm confused about the naming. Why not put the _bindir files into
keycloak-httpd-client-install and keep the python parts in subpackages or is it
because it would be confusing to install a subpackage to get the top-level
package? It would seem better to me to put the common things into
keycloak-httpd-client-install and leave the python parts broken out.
License does match source, MIT vs GPLv3
rm %{buildroot}/usr/bin/keycloak-httpd-client-install
should be
rm %{buildroot}%{_bindir}/keycloak-httpd-client-install
man pages should not be %doc
man page is not installed in python3 subpackage
Missing %dir for %{_datadir}/python-%{srcname}
Issues with man page (man --warnings keycloak-httpd-client-install.8
>/dev/null)
:8: warning: macro `Bkeycloak-httpd-client-install' not defined
:174: warning: macro `BDetermining' not defined
Not sure I like the glob for _bindir given there is a single file. Why not just
list the one file?
Did upstream release 0.2 include only the man page? Wondering if the upgrade to
upstream should also be mentioned in changelog.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library
https://bugzilla.redhat.com/show_bug.cgi?id=1339703 Rex Dieter changed: What|Removed |Added Blocks||1339737 (kf5-messagelib) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339737 [Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Rex Dieter changed: What|Removed |Added Blocks||656997 (kde-reviews) Depends On||1332256 ||(kf5-grantleetheme), ||1339703 (kf5-libgravatar), ||1339406 (kf5-libkdepim), ||1339405 (kf5-pimcommon), ||1332719 (kdepim-apps-lib) Alias||kf5-messagelib Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=656997 [Bug 656997] kde-related package review tracker https://bugzilla.redhat.com/show_bug.cgi?id=1332256 [Bug 1332256] Review Request: kf5-grantleetheme - KDE PIM library for Grantlee template system https://bugzilla.redhat.com/show_bug.cgi?id=1332719 [Bug 1332719] Review Request: kdepim-apps-lib - KDE PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339405 [Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries https://bugzilla.redhat.com/show_bug.cgi?id=1339406 [Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps https://bugzilla.redhat.com/show_bug.cgi?id=1339703 [Bug 1339703] Review Request: kf5-libgravatar - Gravatar support library -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] New: Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Bug ID: 1339737 Summary: Review Request: kf5-messagelib - KDE Message libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rdie...@math.unl.edu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-messagelib.spec SRPM URL: https://rdieter.fedorapeople.org/rpms/kde-apps/kf5-messagelib-16.04.1-1.fc24.src.rpm Description: KDE Message libraries Fedora Account System Username: rdieter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 Rex Dieter changed: What|Removed |Added Blocks||1339737 (kf5-messagelib) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339737 [Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-lib - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 Rex Dieter changed: What|Removed |Added Blocks||1339737 (kf5-messagelib) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339737 [Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Rex Dieter changed: What|Removed |Added Blocks||1339737 (kf5-messagelib) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1339737 [Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338339] Review Request: openrave - Open Robotics Automation Virtual Environment
https://bugzilla.redhat.com/show_bug.cgi?id=1338339 --- Comment #4 from Till Hofmann --- Spec URL: https://thofmann.fedorapeople.org/openrave.spec SRPM URL: https://thofmann.fedorapeople.org/openrave-0.9.0-14.20160519git2baf4e3.fc23.src.rpm koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14250308 The package currently doesn't build on rawhide because of a bug in a recent change in assimp (pkg-config flags are wrong - I'll file a bug). Changes: * Fix several undefined reference errors that occurred while loading plugins (pull request sent upstream [1]) * Fix a bug in the cmake config that caused a dead symlink /usr/bin/openrave -> /usr/bin/openrave (pull request sent upstream [2]) * Add a patch for openrave issue #323 [3]. This patch is not sent upstream because it is only a workaround * Do not filter out requires from the plugins, but only filter out requires of plugins (i.e. don't filter out SoQt, but filter out libconfigurationcache because this is an openrave lib not in LDPATH) [1] https://github.com/rdiankov/openrave/pull/403 [2] https://github.com/rdiankov/openrave/pull/404 [3] https://github.com/rdiankov/openrave/issues/323 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332722] Review Request: kleopatra - KDE certificate manager and unified crypto GUI
https://bugzilla.redhat.com/show_bug.cgi?id=1332722 Rex Dieter changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-25 14:21:26 --- Comment #4 from Rex Dieter --- imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339406] Review Request: kf5-libkdepim - lib for common kdepim apps
https://bugzilla.redhat.com/show_bug.cgi?id=1339406 Rex Dieter changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-05-25 14:25:01 --- Comment #5 from Rex Dieter --- imported -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332255] Review Request: kf5-eventviews - KDE PIM library for displaying events and calendars
https://bugzilla.redhat.com/show_bug.cgi?id=1332255 Bug 1332255 depends on bug 1339406, which changed state. Bug 1339406 Summary: Review Request: kf5-libkdepim - lib for common kdepim apps https://bugzilla.redhat.com/show_bug.cgi?id=1339406 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339737] Review Request: kf5-messagelib - KDE Message libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339737 Bug 1339737 depends on bug 1339406, which changed state. Bug 1339406 Summary: Review Request: kf5-libkdepim - lib for common kdepim apps https://bugzilla.redhat.com/show_bug.cgi?id=1339406 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1339405] Review Request: kf5-pimcommon - PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1339405 Bug 1339405 depends on bug 1339406, which changed state. Bug 1339406 Summary: Review Request: kf5-libkdepim - lib for common kdepim apps https://bugzilla.redhat.com/show_bug.cgi?id=1339406 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332719] Review Request: kdepim-apps-libs - KDE PIM common libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1332719 Rex Dieter changed: What|Removed |Added Summary|Review Request: |Review Request: |kdepim-apps-lib - KDE PIM |kdepim-apps-libs - KDE PIM |common libraries|common libraries Alias||kdepim-apps-libs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
