[Bug 1331704] Review Request: glusterfs-coreutils - Mimics standard Linux coreutils for GlusterFS clusters

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331704

Anoop C S  changed:

   What|Removed |Added

 Blocks||1317278 (glusterfs-3.8.0)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1317278
[Bug 1317278] GlusterFS 3.8.0 tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 827167] Review Request: bumblebee - Bumblebee daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=827167



--- Comment #32 from Gary Gatling  ---
I will try to upload the current version + spec file to the website tomorrow
and test Nouveau support to see if it still works in fedora 24. If it doesn't
work I feel I can get it working again pretty easily.

But also, see this thread:

https://github.com/Bumblebee-Project/Bumblebee/issues/773

So it may no longer be appropriate for the fedora distribution?

I can try to get clarification from the developers in that issue on github.com.

Thanks for your kind offer to review this package. I'll update this ticket when
everything is in place tomorrow and I'll try to get clarification about the
future of Nouveau support.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 827167] Review Request: bumblebee - Bumblebee daemon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=827167

Ben Rosser  changed:

   What|Removed |Added

 CC||rosser@gmail.com



--- Comment #31 from Ben Rosser  ---
Hey, are you still interested in getting bumblebee into Fedora?

I would be happy to review bumblebee packages as needed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242056



--- Comment #13 from Athos Ribeiro  ---
(In reply to Paulo Andrade from comment #12)
>   Hi Athos,

Hi Paulo, thank you for the feedback.

> 
>   Please comment on this:
> W: simplecov not installed, we won't have a coverage report
> maybe it needs this build requires?
> rubygem-simplecov.noarch : Code coverage analysis tool for Ruby 1.9

simplecov is a gem to measure test coverage. I don't see any advantage on
measuring test coverage during the build step since the output would be
ignored. It would also generate a "coverege" directory which would have to be
removed. see https://github.com/colszowka/simplecov for reference.

> 
>   There is also this issue:
> https://rubygems.org/gems/chake-0.13.gem :
>   CHECKSUM(SHA256) this package :
> 6a3ae97b0efbc40eed8de527c5345ecfea2786c8ef327a46cd5f8bbe9102897e
>   CHECKSUM(SHA256) upstream package :
> d3726ddb2293edc6ad056272cb9ef2f159fdc6a3fd48f17a5bed49d708fbfd4f
> Apparently the file was uploaded again, with same name, but
> different contents, and version in srpm does not match download
> link.

Sorry for that, the new build (link below) has the right source and the
checksums match

> 
>   I see the -doc package is installing files under:
> /usr/share/gems/gems/chake-0.13/
> I believe this is incorrect. Are you sure the main package runs
> without the files installed there?

Yes,

the -doc files under /usr/share/gems/gems/chake-0.13/ are

/usr/share/gems/gems/chake-0.13/examples
which is a directory with examples on how to use chake

/usr/share/gems/gems/chake-0.13/spec
which is a directory with integration tests

/usr/share/gems/gems/chake-0.13/ChangeLog.md
/usr/share/gems/gems/chake-0.13/README.md
upstream changelog and readme files

/usr/share/gems/gems/chake-0.13/Rakefile
Which is a file for rake (make for ruby, so this would be something like a
Makefile)
/usr/share/gems/gems/chake-0.13/Gemfile
File defining all dependencies of the project
/usr/share/gems/gems/chake-0.13/chake.gemspec
File that defines the gem

These files usually go in the -doc in other packaged gems.

> 
>   Please also comment on the directory:
> /usr/share/gems/doc/chake-0.13/ri
> is it really required by the -doc package? Either way, what is
> installing in /usr/share/gems/doc/chake-0.13/ should be installed
> in /usr/share/doc/chake

The ri directory contains the ri documentation for the gem. ri documentation
can be browsed through ri calls on the command line.

About being installed in /usr/share/doc/chake:

As you can see here (f23):
$ dnf repoquery --repoid=fedora -l rubygem-*-doc | grep -i
"^/usr/share/gems/doc/" | cut -d/ -f6 | uniq | wc -l
531
$ dnf repoquery --repoid=fedora rubygem-*-doc | grep rubygem | wc -l
533

only 2 out of 533 gems do not install documentation in /usr/share/gems/doc,
shouldn't I also follow this pattern?

note that %{gem_docdir} expands to /usr/share/gems/gems/NAME-VERSION, as
defined in https://fedoraproject.org/wiki/Packaging:Ruby#Macros.

> 
>   About the fonts, I believe the bug report is
> https://bugzilla.redhat.com/show_bug.cgi?id=1224715 and it will
> not get any attention, as the linked, related upstream report
> is closed https://github.com/rdoc/rdoc/issues/186 as they
> apparently had a different idea about it.

I see...

> Please check that just adding a 'Requires: lato-fonts' is not
> enough to display the documentation, and if not enough, please
> check what kind of patch could be done, apparently only in the
> *.css files.
> I understand it is replicated in more than 500 packages, but
> that is not correct :(

I removed the generated fonts, required the two packages wich contain them and
added links to these files, how about that? I am also checking with Ruby SIG if
that approach would be feasible for all the other 500+ -doc packages.

> 
>   Please check https://fedoraproject.org/wiki/Packaging:Ruby
> the template there installs documentation under:
> $ rpm -E %_defaultdocdir
> /usr/share/doc
> what should be done by the sample command in the sample spec:
> rdoc --op %{buildroot}%{_defaultdocdir}/%{name}

The example shown is for ruby applications, there are other instructions for
packaging gems there. As mentioned above, there is a macro defined with the
path for gems documentations in
https://fedoraproject.org/wiki/Packaging:Ruby#Macros

> 
>   You should likely also join the ruby SIG, and check the tools
> there, as well as other documentation:
> https://fedoraproject.org/wiki/Ruby_SIG

Done!

> 
>   I believe you are doing good, but I will prefer to have you
> knowing well about all packaging details before approving the
> package.
> 
>   About the reviews with no longer srpm or spec, what you did
> is fine, just comment about it in the bug report :)

I was thinking about parsing all the open review requests tickets and upload a
page with information on those, but I believe this should be discussed in a new
ticket, right?

> 
> 

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323186

Neil Horman  changed:

   What|Removed |Added

 CC||robert.am...@intel.com
  Flags||needinfo?(robert.amato@inte
   ||l.com)



--- Comment #39 from Neil Horman  ---
I'm sorry rick, its been a day.

If thats what you're doing, I presume then my understanding is accurate.  If
thats the case, great, if not, please let me know, I want to be sure we do the
right thing here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1020292] Review Request: bitcoin - Peer-to-peer digital currency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1020292



--- Comment #38 from Warren Togami  ---
A few upstream developers were alarmed to hear how quickly Fedora releases are
EOL'ed.  This is of concern because it is hazardous for unmaintained versions
of Bitcoin to continue running after EOL.

There is a separate even bigger concern that it is very dangerous to have
automatic updates of Bitcoin software.  Does Fedora infrastructure have options
to further lock down the ability of insiders or hackers to push a trojan
through the update process?  The scenario of a compromised auto-update leading
to millions of dollars of losses is not a trivial risk when the incentive is
very high.

For reasons like this Ubuntu and Debian do not distribute Bitcoin at all.

Upstream goes through extreme effort to build deterministic, bit-for-bit
reproducible binaries that are verifiable as being identical to what others can
build as added protection against the possibility of trojan distribution.  They
are now in favor of upstream adding both rpm and deb outputs to distribute
their existing deterministic binary.

So yes, upstream would strongly caution against Fedora distributing Bitcoin for
the above reasons.  If Fedora insists on shipping Bitcoin then let us discuss
how to mitigate the risks in ways like:

* Ship the upstream deterministic binary in an RPM.  This is very much against
Fedora policy but this is the safest and easiest to maintain option.
* Make the build of Bitcoin within the Fedora build system deterministic and
verifiable when compared to building it on an identical buildroot.
* Add additional safeguards to the update process to require a much higher
threshold of review including build determinism testing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336726] Review Request: erlang-lucene_parser - A library for Lucene-like query syntax parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336726

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336726] Review Request: erlang-lucene_parser - A library for Lucene-like query syntax parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336726



--- Comment #5 from Fedora Update System  ---
erlang-lucene_parser-1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b6ddd3cde

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323186



--- Comment #38 from Rick Tierney  ---
Sorry Neil I didn't mean to imply you didn't know what jar files were. I was
just trying to get to the bottom of the misunderstanding.

In any case, I understand your point of view and I will attempt to install the
3rd party libraries and remove the lib/ folder containing the jar files and
licenses.

Sorry for the confusion!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1256502] Review Request: python-getdns - python bindings for getdns

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1256502

Ralph Bean  changed:

   What|Removed |Added

 CC||rb...@redhat.com



--- Comment #2 from Ralph Bean  ---
Ping - any update on this Paul?  It would be nice to use this in Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - A sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884

Rex Dieter  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed||2016-05-31 16:59:31



--- Comment #9 from Rex Dieter  ---
importing into rawhide, and fixing up items

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336008] Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336008

John Dennis  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-05-31 16:59:39



--- Comment #9 from John Dennis  ---
Successfully imported and built for rawhide, f24 and f23. Closing.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511



--- Comment #15 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329923] Review Request: gimp-layer-via-copy-cut - Layer via copy/ cut plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329923



--- Comment #16 from Fedora Update System  ---
gimp-layer-via-copy-cut-1.6-2.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-6da43ddbc1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330429] Review Request: php-iamcal-lib-autolink - Adds anchors to urls in a text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330429



--- Comment #17 from Fedora Update System  ---
php-iamcal-lib-autolink-1.7-1.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c39fcd530b

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1089962] Review Request: radeontop - View GPU utilization of AMD/ ATI Radeon devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089962



--- Comment #34 from Fedora Update System  ---
radeontop-0.9-2.20160527git2047d13.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-561d3eb6ea

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329923] Review Request: gimp-layer-via-copy-cut - Layer via copy/ cut plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329923



--- Comment #17 from Fedora Update System  ---
gimp-layer-via-copy-cut-1.6-2.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c23ca81a75

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511



--- Comment #16 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.fc23 has been pushed to the Fedora 23
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1089962] Review Request: radeontop - View GPU utilization of AMD/ ATI Radeon devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089962



--- Comment #33 from Fedora Update System  ---
radeontop-0.9-2.20160527git2047d13.fc22 has been pushed to the Fedora 22
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-7e58867133

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330429] Review Request: php-iamcal-lib-autolink - Adds anchors to urls in a text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330429



--- Comment #16 from Fedora Update System  ---
php-iamcal-lib-autolink-1.7-1.fc22 has been pushed to the Fedora 22 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-3e65280539

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1089962] Review Request: radeontop - View GPU utilization of AMD/ ATI Radeon devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089962



--- Comment #32 from Fedora Update System  ---
radeontop-0.9-2.20160527git2047d13.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4e75511f37

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330429] Review Request: php-iamcal-lib-autolink - Adds anchors to urls in a text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330429



--- Comment #15 from Fedora Update System  ---
php-iamcal-lib-autolink-1.7-1.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-017e6c57e8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671



--- Comment #20 from Fedora Update System  ---
seafile-5.1.2-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-6aa664154f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323186

Neil Horman  changed:

   What|Removed |Added

  Flags|needinfo?(robert.amato@inte |
   |l.com)  |
   |needinfo?(nhor...@redhat.co |
   |m)  |
   |needinfo?(nhor...@redhat.co |
   |m)  |



--- Comment #37 from Neil Horman  ---
yes, Rick, I know what jar files are.  Let me try to be very clear in what I'm
saying:

opa-fmgui, when built contains three categories of jar files:

1) Jar files built from the sources that are unique to opa-fmgui

2) Jar files that are built from sources that you include in the upstream
opa-fmgui source repository, but are available independently as their own
fedora packages (hibernate and jfreechart fall into this category)

3) Jar files that are built from sources that you include in the upstream
opa-fmgui source repository, and are _not_ independently available as their own
fedora packages (gritty falls into this category)



Category 1 Jar files are a no-brainer.  They should be licenced with a fedora
approved license, and that license should be included in the package.  I don't
think we have any disagreement here

Category 2 Jar files, are what I'm driving at. You shouldn't need those jar
files at all, because the jar files can be made available via the Requires tag
in the spec file.  That is to say, you can require that the hibernate and
jfreechart be installed when the opa-fmgui package is installed, so that the
jar files from the hibernate and jfreechart packages are used at run time when
opa-fmgui is run. As such, you don't need to build those jars.  You can remove
them from your build, and in so doing, you don't need to include the license
with them, because you're not (or shouldn't be) packaging them.

Category 3 jar files, I'm willing to give you a waiver on.  gritty I would
normally say needs to be separately packaged, but because the upstream package
is not being actively developed, I don't expect there will be a great need for
it, and its just as likely you will do your own internal fixes to it going
forward.  You will need to include the license file for gritty of course, and
it will need to be an approved open source license (like GPL), but as long as
it is, that should be fine.


If there is a 4th category of jar file I'm unaware of in the project, we will
definitely have to address that as well, but I don't see any at the moment

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330429] Review Request: php-iamcal-lib-autolink - Adds anchors to urls in a text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330429



--- Comment #14 from Fedora Update System  ---
php-iamcal-lib-autolink-1.7-1.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0216866eb2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329923] Review Request: gimp-layer-via-copy-cut - Layer via copy/ cut plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329923



--- Comment #15 from Fedora Update System  ---
gimp-layer-via-copy-cut-1.6-2.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7e668f5432

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323186

Rick Tierney  changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



--- Comment #36 from Rick Tierney  ---
(In reply to Rick Tierney from comment #35)
> Neil:
> 
> My bad, the last message I posted was misleading.  Library jars MUST remain
> present in order for the application to run!  We cannot remove the jars from
> the binary RPM otherwise opa-fmgui won't work at all.  
> 
> So given that critical information, the questions become:
> 
> 1. Does Fedora have any rules against this type of 3rd Party jar file usage?
> 
> 2. Are the 3rd Party licenses for the jar files required when using them
> this way?
> 
> 3. Where should the 3rd Party licenses be stored? RPM, SRPM, both?

Perhaps I'm not being completely clear... these jar files contain binary .class
files which contribute to the proper execution of the opa-fmgui application.
NONE of these jar files (including gritty.jar) contain source code, and I'm
wondering if they need to be accompanied by license files.

The Gritty source code is a separate issue, and since it is not packaged
separately we are building that ourselves and it is accompanied by a license
file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1331972] Review Request: qblade - Wind Turbine Rotor Design and Simulation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1331972



--- Comment #11 from Fedora Update System  ---
qblade-0.91-1.fc23 has been pushed to the Fedora 23 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336726] Review Request: erlang-lucene_parser - A library for Lucene-like query syntax parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336726



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/erlang-lucene_parser

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671



--- Comment #19 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/seafile

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336008] Review Request: keycloak-httpd-client-install - Tools to configure Apache HTTPD as Keycloak client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336008



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/keycloak-httpd-client-install

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340946] Review Request: photoqt - A fast Qt image viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340946



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/photoqt

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - A sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884



--- Comment #8 from Rex Dieter  ---
you're right, sorry.  I'd only checked that the -libs pkg was created, not that
it's contents were removed from the main pkg too.

We can fix that up prior to doing any official builds.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341310] New: Review Request: kubernetes-ansible - Playbook and set of roles for seting up a Kubernetes cluster onto machines

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341310

Bug ID: 1341310
   Summary: Review Request: kubernetes-ansible - Playbook and set
of roles for seting up a Kubernetes cluster onto
machines
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: jchal...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://jchaloup.fedorapeople.org/reviews/kubernetes-ansible/kubernetes-ansible.spec
SRPM URL:
https://jchaloup.fedorapeople.org/reviews/kubernetes-ansible/kubernetes-ansible-0.6.0-0.1.gitd65ebd5.fc20.src.rpm
Description: Playbook and set of roles for seting up a Kubernetes cluster onto
machines
Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14333072

rpmlint kubernetes-ansible-0.6.0-0.1.gitd65ebd5.fc20.src.rpm
kubernetes-ansible-0.6.0-0.1.gitd65ebd5.fc20.noarch.rpm
kubernetes-ansible.src: W: spelling-error Summary(en_US) seting -> sting,
seating, setting
kubernetes-ansible.src: W: spelling-error %description -l en_US seting ->
sting, seating, setting
kubernetes-ansible.noarch: W: spelling-error Summary(en_US) seting -> sting,
seating, setting
kubernetes-ansible.noarch: W: spelling-error %description -l en_US seting ->
sting, seating, setting
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/opencontrail/files/ifdown-vhost 0644L
/bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/kubernetes-addons/files/get_files.sh 0644L
/bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/opencontrail/files/ifup-vhost 0644L
/bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/kubernetes/files/kube-gen-token.sh 0644L
/bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/kubernetes-addons/files/common/kube-addons.sh
0644L /bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/contiv/templates/aci_gw.j2 0644L /bin/bash
kubernetes-ansible.noarch: E: non-executable-script
/usr/share/kubernetes-ansible/roles/kubernetes-addons/files/common/kube-addon-update.sh
0644L /bin/bash
2 packages and 0 specfiles checked; 7 errors, 4 warnings.

non-executable-script errors can be ignored as all those files are installed on
a node by the ansible book. It does not make sense to make them executable in
the rpm. There is a different logic that executes the scripts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1338140] Review Request: guayadeque - Music player

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #12 from Raphael Groner  ---
> [!]: If the package is under multiple licenses, the licensing breakdown
>  must be documented in the spec.

Please do so. That's MUST.
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

wxCurl has wxWidgets Library License (two files in src/curl and two files in
src/wx/curl), so append wxWidgets as short name to License tag.
https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Good_Licenses


> [?]: Package contains no bundled libraries without FPC exception.
> => Source files without license header, see above.

Licensecheck script fails to detect the header, we overlooked that in first
run. SHOULD ask upstream why wxCurl is bundled and try to unbundle.
https://github.com/anonbeat/guayadeque/issues/8#issuecomment-222497195
https://sourceforge.net/projects/wxcurl/


Subpackages for locales look nearly good (ignore the rpmlint warnings), except:
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/share/guayadeque,
 /usr/share/locale/sr_latin, /usr/share/locale/sr_latin/LC_MESSAGES
[!]: Package must own all directories that it creates.
 Note: Directories without known owners:
 /usr/share/locale/sr_latin/LC_MESSAGES, /usr/share/locale/sr_latin,
 /usr/share/guayadeque
=> Fix with:
%files
%dir %{_datadir}/%{name}

guayadeque-langpack-sr_latin.noarch: E: incorrect-locale-subdir
/usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
guayadeque-langpack-sr_latin.noarch: E: invalid-lc-messages-dir
/usr/share/locale/sr_latin/LC_MESSAGES/guayadeque.mo
=> sr_latin is not a valid locale identifier, change to sr@latin.
https://github.com/anonbeat/guayadeque/issues/6


(Sorry for the delay of my response, I'm quite busy currently.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - A sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com



--- Comment #7 from Neal Gompa  ---
Hold on... Why are the krita libraries included in both krita-libs and krita
itself? They should only be in krita-libs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336726] Review Request: erlang-lucene_parser - A library for Lucene-like query syntax parsing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336726

Randy Barlow  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Randy Barlow  ---
Cool, thanks for the explanations. I'm marking this as approved, but please
remember to use the license macro.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1242056] Review Request: rubygem-chake - serverless configuration management tool for chef

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1242056



--- Comment #12 from Paulo Andrade  
---
  Hi Athos,

  Please comment on this:
W: simplecov not installed, we won't have a coverage report
maybe it needs this build requires?
rubygem-simplecov.noarch : Code coverage analysis tool for Ruby 1.9

  There is also this issue:
https://rubygems.org/gems/chake-0.13.gem :
  CHECKSUM(SHA256) this package :
6a3ae97b0efbc40eed8de527c5345ecfea2786c8ef327a46cd5f8bbe9102897e
  CHECKSUM(SHA256) upstream package :
d3726ddb2293edc6ad056272cb9ef2f159fdc6a3fd48f17a5bed49d708fbfd4f
Apparently the file was uploaded again, with same name, but
different contents, and version in srpm does not match download
link.

  I see the -doc package is installing files under:
/usr/share/gems/gems/chake-0.13/
I believe this is incorrect. Are you sure the main package runs
without the files installed there?

  Please also comment on the directory:
/usr/share/gems/doc/chake-0.13/ri
is it really required by the -doc package? Either way, what is
installing in /usr/share/gems/doc/chake-0.13/ should be installed
in /usr/share/doc/chake

  About the fonts, I believe the bug report is
https://bugzilla.redhat.com/show_bug.cgi?id=1224715 and it will
not get any attention, as the linked, related upstream report
is closed https://github.com/rdoc/rdoc/issues/186 as they
apparently had a different idea about it.
Please check that just adding a 'Requires: lato-fonts' is not
enough to display the documentation, and if not enough, please
check what kind of patch could be done, apparently only in the
*.css files.
I understand it is replicated in more than 500 packages, but
that is not correct :(

  Please check https://fedoraproject.org/wiki/Packaging:Ruby
the template there installs documentation under:
$ rpm -E %_defaultdocdir
/usr/share/doc
what should be done by the sample command in the sample spec:
rdoc --op %{buildroot}%{_defaultdocdir}/%{name}

  You should likely also join the ruby SIG, and check the tools
there, as well as other documentation:
https://fedoraproject.org/wiki/Ruby_SIG

  I believe you are doing good, but I will prefer to have you
knowing well about all packaging details before approving the
package.

  About the reviews with no longer srpm or spec, what you did
is fine, just comment about it in the bug report :)

  Your informal review of a sample rubygem package is also good.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341283] New: Review Request: php-lukasreschke-id3parser - ID3 parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341283

Bug ID: 1341283
   Summary: Review Request: php-lukasreschke-id3parser - ID3
parser library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@famillecollet.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://raw.githubusercontent.com/remicollet/remirepo/f4bf181f60fadcf6023c3e412810c7ad7a184c7d/php/php-lukasreschke-id3parser/php-lukasreschke-id3parser.spec
SRPM URL:
http://rpms.remirepo.net/SRPMS/php-lukasreschke-id3parser-0.0.1-1.remi.src.rpm
Description: 
This is a pure ID3 parser based upon getID3.
It supports the following ID3 versions inside MP3 files:

* ID3v1 (v1.0 & v1.1)
* ID3v2 (v2.2, v2.3 & v2.4)

Autoloader: %{_datadir}/php/%{gh_project}/autoload.php




Fedora Account System Username: remi

---

For owncloud 9.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341283] Review Request: php-lukasreschke-id3parser - ID3 parser library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341283

Remi Collet  changed:

   What|Removed |Added

 CC||james.hoga...@gmail.com
  Alias||lukasreschke/id3parser



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339327] Review Request: libintelnvm-i18n - Internationalization library supporting a subset of internationalization functionality.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339327



--- Comment #4 from Namratha Kothapalli  ---
Revert tag to v. Update spec and tags to have GitHub's auto archiving
produce a properly formatted tarball per feedback.

Spec URL:
https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n.spec

SRPM URL:
https://github.com/01org/intelnvmi18nlibrary/releases/download/v1.0.0.1014/libintelnvm-i18n-1.0.0.1014-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339302] Review Request: libintelnvm-cli - Framework library supporting common Intel NVM storage CLI applications.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339302



--- Comment #4 from Namratha Kothapalli  ---
Updated spec and tags to have GitHub's auto archiving produce a properly
formatted tarball per Dan's suggestion. 

Spec URL:
https://github.com/01org/intelnvmclilibrary/releases/download/v1.0.0.1094/libintelnvm-cli.spec

SRPM URL:
https://github.com/01org/intelnvmclilibrary/releases/download/v1.0.0.1094/libintelnvm-cli-1.0.0.1094-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339029] Review Request: libintelnvm-cim - Framework library for Intel NVM storage common information model (CIM) providers.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339029



--- Comment #3 from Namratha Kothapalli  ---
Updated spec and tags to have GitHub's auto archiving produce a properly
formatted tarball. 

Spec URL:
https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1036/libintelnvm-cim.spec

https://github.com/01org/intelnvmcimlibrary/releases/download/v1.0.0.1036/libintelnvm-cim-1.0.0.1036-1.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1287899] Review Request: python-funcsigs - Python function signatures from PEP362 for Python 2.6, 2.7 and 3.2+

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1287899

James Hogarth  changed:

   What|Removed |Added

 Blocks|1244145 |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1244145
[Bug 1244145] Update python2-mock AND python3-mock to 2.0
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - A sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884



--- Comment #6 from Rex Dieter  ---
pkgdb request submitted

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340269] Review Request: keepassx0 - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340269

Stephen Gallagher  changed:

   What|Removed |Added

 CC||limburg...@gmail.com
  Flags||needinfo?(limburgher@gmail.
   ||com)



--- Comment #3 from Stephen Gallagher  ---
tl;dr: A few minor issues.



Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.html is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- The source tarball location is incorrect. It should be:
  https://www.keepassx.org/releases/0.4.4/keepassx-0.4.4.tar.gz

- The package includes sources licensed with BSD (3 clause).


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2)
 (with incorrect FSF address)", "Unknown or generated", "GPL (v2 or
 later) (with incorrect FSF address)", "BSD (3 clause)", "GPL (v2 or
 later)", "GPL (v2)". 18 files have unknown license. Detailed output of
 licensecheck in /dev/shm/1340269-keepassx0/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/mime,
 /usr/share/mimelnk/application, /usr/share/mimelnk,
 /usr/share/mime/packages
[x]: Package does not own files or directories owned by other packages.
 Note: Dirs in package are owned also by:
 /usr/share/keepassx/i18n(keepassx), /usr/share/keepassx(keepassx),
 /usr/share/keepassx/icons(keepassx)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: update-desktop-database is invoked in %post and %postun if package
 contains desktop file(s) with a MimeType: entry.
 Note: desktop file(s) with MimeType entry in keepassx0
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in keepassx0
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
 desktop-file-validate if there is such a file.
[x]: Dist tag is 

[Bug 1340884] Review Request: krita - A sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884

Rex Dieter  changed:

   What|Removed |Added

Summary|Review Request: krita - |Review Request: krita - A
   |Krita is a FREE sketching   |sketching and painting
   |and painting program|program



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - Krita is a FREE sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884

Rex Dieter  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Rex Dieter  ---
sources: ok
$ md5sum *.tgz
beb7140471d1b6b0ae92d664743c067f  krita-3.0.tgz

naming: ok

license: ok

Looks good, APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - Krita is a FREE sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884



--- Comment #4 from Helio Chissini de Castro  ---
Updated with all changes:

Spec URL: https://heliocastro.fedorapeople.org/krita/krita.spec
SRPM URL: https://heliocastro.fedorapeople.org/krita/krita-3.0-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340269] Review Request: keepassx0 - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340269

Stephen Gallagher  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||sgall...@redhat.com
   Assignee|nob...@fedoraproject.org|sgall...@redhat.com
  Flags||fedora-review?



--- Comment #2 from Stephen Gallagher  ---
Benjamin, the short answer is that a mistake was made and people were
accidentally forced to upgrade to the 2.x version which upgraded their
database, but then downgraded again leading to their database being unusable.
So we worked up a way to avoid this going forward which necessitated carrying
both versions in the Fedora collection.

See https://fedorahosted.org/fesco/ticket/1569 for more detail than you could
possibly want.

Jon, I'll get started on this review right now. Sorry for the delay: holidays.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340152] Review Request: python-certbot-apache - Apache plugin to automatically configure certificate via certbot

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340152



--- Comment #3 from James Hogarth  ---
Upstream just released 0.7.0

Spec URL:
https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache.spec
SRPM URL:
https://jhogarth.fedorapeople.org/certbot-apache/python-certbot-apache-0.7.0-1.fc25.src.rpm

Rawhide koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=14330255

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1323186] Review Request: opa-fmgui - Intel OPA Fabric GUI

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1323186

Rick Tierney  changed:

   What|Removed |Added

  Flags||needinfo?(nhor...@redhat.co
   ||m)



--- Comment #35 from Rick Tierney  ---
Neil:

My bad, the last message I posted was misleading.  Library jars MUST remain
present in order for the application to run!  We cannot remove the jars from
the binary RPM otherwise opa-fmgui won't work at all.  

So given that critical information, the questions become:

1. Does Fedora have any rules against this type of 3rd Party jar file usage?

2. Are the 3rd Party licenses for the jar files required when using them this
way?

3. Where should the 3rd Party licenses be stored? RPM, SRPM, both?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424



--- Comment #24 from Fedora Update System  ---
gimp-save-for-web-0.29.3-1.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329424] Review Request: gimp-save-for-web - Save for web plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329424



--- Comment #23 from Fedora Update System  ---
gimp-save-for-web-0.29.3-1.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671

Julien Enselme  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review+



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671

Julien Enselme  changed:

   What|Removed |Added

  Flags||fedora-review-



--- Comment #18 from Julien Enselme  ---
Looks good. Approved.

One review to go and we can have seafile-client in fedora :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340884] Review Request: krita - Krita is a FREE sketching and painting program

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340884

Rex Dieter  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||rdie...@math.unl.edu
 Blocks||656997 (kde-reviews)
   Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu
  Alias||krita
  Flags||fedora-review?



--- Comment #3 from Rex Dieter  ---
I can review, some initial comments:


1.  MUST: drop -devel subpkg, there's no public API (headers), better to omit
%{_libdir}/libkrita*.so
from packaging

2.  SHOULD consider a -libs subpkg, for multilib friendliness, to include
shared libraries and plugins, basically:
%{_libdir}/libkrita*.so.*

3.  SHOULD support better upgrade path from calligra-krita, add

Obsoletes: calligra-krita < 3.0
Provides:  calligra-krita = %{version}-%{release}

# add to -libs pkg, if you choose to create one per item 2
Obsoletes: calligra-krita-libs < 3.0
Provides:  calligra-krita-libs = %{version}-%{release}

4.  Source URL invalid, MUST use (something like)
Source0: http://download.kde.org/stable/krita/%{version}/krita-%{version}.tgz
(without this, I cannot verify sources either, since the Source used currently
has a different extension .tar.xz)

5.  MUST add missing icon/mimetype/shlib scriptlets:
%post
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :

%posttrans
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:

%postun
if [ $1 -eq 0 ] ; then
touch --no-create %{_datadir}/icons/hicolor &> /dev/null || :
gtk-update-icon-cache %{_datadir}/icons/hicolor &> /dev/null || :
update-desktop-database -q &> /dev/null ||:
fi

and to -libs:
%post libs -p /sbin/ldconfig
%postun libs -p /sbin/ldconfig

6.  SHOULD simplify Summary/Description, mentioning "FREE" is extraneous
(everything in fedora is free already), I'd suggest just
Summary: A sketching and painting program


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=656997
[Bug 656997] kde-related package review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340946] Review Request: photoqt - A fast Qt image viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340946

Jaroslav Reznik  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Jaroslav Reznik  ---
Thank you, package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340946] Review Request: photoqt - A fast Qt image viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340946



--- Comment #2 from Jiri Eischmann  ---
(In reply to Jaroslav Reznik from comment #1)
> Name: ok
> Version & release: ok
> Summary: ok
> License: ok (GPLv2+)
> URL: ok
> Sources: ok (SHA256
> 9df3392f0bd746778f119a4da98a32e8ae9ae215564df97d7bcf52efa4d08604)
> 
> BuildRequires: not ok
> 
> BuildRequires:  qt5-qtbase-tds
> BuildRequires:  qt5-qtbase-odbc
> BuildRequires:  qt5-qtbase-ibase
> BuildRequires:  qt5-qtbase-mysql
> BuildRequires:  qt5-qtbase-postgresql
> 
> are not BuildRequires and are not needed to build the package

Ok, removed.

> Description: ok
> 
> Files: ok
> Scratch build: builds ok,
> http://koji.fedoraproject.org/koji/taskinfo?taskID=14326164
> 
> rpmlint output:
> rpmlint photoqt-1.4-1.fc24.x86_64.rpm 
> photoqt.x86_64: W: no-version-in-last-changelog
> photoqt.x86_64: W: no-manual-page-for-binary photoqt
> 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> 
> Please add version to changelog, it's easier to understand what changes
> happend in which version

Added.

> photoqt.spec 
> photoqt.spec:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2)
> 0 packages and 1 specfiles checked; 0 errors, 1 warnings.
> 
> I'm not sure I like appdata included in SPEC file, not a big deal but it
> makes SPEC file less clear.

I wanna stay consistent with my other packages. Once upstream ships the file,
I'll remove it.

> Personally I prefer to use desktop-file-install but guidelines are ok with
> one of install/validate called, so ok.
> 
> {buildroot} and $RPM_BUILD_ROOT are mixed in SPEC file, please choose one
> for consistency or just remove rm -rf $RPM_BUILD_ROOT from %install section
> (not needed).

Fixed.

> For %build and %install sections I'd prefer to use this snippet (out of
> source tree build):
> %build
> mkdir %{_target_platform}
> pushd %{_target_platform}
> %{cmake} ..
> popd
> 
> make %{?_smp_mflags} -C %{_target_platform}
> 
> %install
> make install/fast DESTDIR=%{buildroot} -C %{_target_platform}

Fixed.

I've updated the spec file and a new srpm is here:
https://dl.dropboxusercontent.com/u/1309518/photoqt-1.4-2.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1020292] Review Request: bitcoin - Peer-to-peer digital currency

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1020292



--- Comment #37 from Sascha Spreitzer  ---
Please consider that in 0.12 the vital cryptograpic parts are shipped with the
source:

[..]
-rw-r--r-- root/root  1057 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/COPYING
drwxr-xr-x root/root 0 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/include/
-rw-r--r-- root/root  1014 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/include/secp256k1_ecdh.h
-rw-r--r-- root/root 25771 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/include/secp256k1.h
-rw-r--r-- root/root  4700 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/include/secp256k1_recovery.h
-rw-r--r-- root/root  8302 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/include/secp256k1_schnorr.h
-rw-r--r-- root/root   322 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/libsecp256k1.pc.in
-rw-r--r-- root/root  3521 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/Makefile.am
-rw-r--r-- root/root 61657 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/Makefile.in
drwxr-xr-x root/root 0 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/
-rw-r--r-- root/root   944 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/basic-config.h
-rw-r--r-- root/root  1576 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_ecdh.c
-rw-r--r-- root/root  1726 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench.h
-rw-r--r-- root/root 12623 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_internal.c
-rw-r--r-- root/root  2022 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_recover.c
-rw-r--r-- root/root  2462 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_schnorr_verify.c
-rw-r--r-- root/root  1594 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_sign.c
-rw-r--r-- root/root  2437 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/bench_verify.c
-rw-r--r-- root/root  1172 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/ecdsa.h
-rw-r--r-- root/root 10247 2016-01-01 01:00
bitcoin-0.12.1/src/secp256k1/src/ecdsa_impl.h
[..]

Thus bitcoin is now safe for packaging for distributions? Please raise this to
the FESCo.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1160671] Review Request: seafile - Cloud storage system

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1160671



--- Comment #17 from Nikos Roussos  ---
I fixed the license.

SPEC: https://comzeradd.fedorapeople.org/specs/seafile.spec
SRPM: https://comzeradd.fedorapeople.org/srpms/seafile-5.1.2-3.fc24.src.rpm

For the unused-direct-shlib-dependency warning I opened an upstream bug
https://github.com/haiwen/seafile/issues/1675

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330861] Review Request: numix-icon-theme-circle - Numix Project circle icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330861

Simone Caronni  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #5 from Simone Caronni  ---
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330858] Review Request: numix-icon-theme - Numix Project icon theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330858

Simone Caronni  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #7 from Simone Caronni  ---
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330856] Review Request: numix-gtk-theme - Numix Gtk Theme

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330856

Simone Caronni  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #9 from Simone Caronni  ---
Sponsoring user, no longer requiring a sponsor:

https://fedorahosted.org/packager-sponsors/ticket/275

Thanks to everyone involved.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340269] Review Request: keepassx0 - Cross-platform password manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340269

Benjamin Lefoul  changed:

   What|Removed |Added

 CC||benjamin.lef...@nwise.se



--- Comment #1 from Benjamin Lefoul  ---
Why are there so many forks of keypass?

- We already have the keypass and keypassx packages.

- I sometimes hear of keepass2...

- Keepassx2 was just approved:
https://bugzilla.redhat.com/show_bug.cgi?id=1326875

- Now keepassx0? And no Keepassx1?

This is all very confusing and some explanation could be refreshing...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327254] Review Request: golang-github-eapache-queue - Fast golang queue using ring-buffer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327254



--- Comment #15 from Fedora Update System  ---
golang-github-eapache-queue-1.0.2-0.1.gitded5959.fc22 has been pushed to the
Fedora 22 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327753] Review Request: golang-github-Shopify-toxiproxy - A proxy to simulate network and system conditions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327753



--- Comment #13 from Fedora Update System  ---
golang-github-Shopify-toxiproxy-2.0.0-0.1.rc2.gitfc5a9c0.fc22 has been pushed
to the Fedora 22 stable repository. If problems still persist, please make note
of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336218] Review Request: golang-github-cockroachdb-cmux - Connection mux for serving different services on the same port

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336218



--- Comment #15 from Fedora Update System  ---
golang-github-cockroachdb-cmux-0-0.1.git112f050.fc22 has been pushed to the
Fedora 22 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327291] Review Request: golang-github-mistifyio-go-zfs - Go wrappers for ZFS commands

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327291



--- Comment #13 from Fedora Update System  ---
golang-github-mistifyio-go-zfs-0-0.1.git1b4ae6f.fc22 has been pushed to the
Fedora 22 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327762] Review Request: golang-github-Shopify-sarama - Sarama is a Go library for Apache Kafka 0.8 and 0.9

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327762



--- Comment #15 from Fedora Update System  ---
golang-github-Shopify-sarama-1.7.0-0.1.git87ec8d7.fc22 has been pushed to the
Fedora 22 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1336217] Review Request: golang-github-dustin-go-humanize - Formatters for units to human friendly sizes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1336217



--- Comment #15 from Fedora Update System  ---
golang-github-dustin-go-humanize-0-0.1.git8929fe9.fc22 has been pushed to the
Fedora 22 stable repository. If problems still persist, please make note of it
in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341099] New: Review Request: taskotron-trigger - Triggering Taskotron jobs on fedmsgs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341099

Bug ID: 1341099
   Summary: Review Request: taskotron-trigger - Triggering
Taskotron jobs on fedmsgs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: mkri...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://mkrizek.fedorapeople.org/specs/taskotron-trigger.spec
SRPM URL:
https://mkrizek.fedorapeople.org/srpms/taskotron-trigger-0.3.16-2.fc23.src.rpm
Description: Triggering Taskotron jobs on fedmsgs
FAS: mkrizek

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328064] Review Request: wildfly-elytron - Security, Authentication, and Authorization SPIs for the WildFly project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328064

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
wildfly-elytron-1.0.2-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-dc4f42f41c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1330429] Review Request: php-iamcal-lib-autolink - Adds anchors to urls in a text

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1330429

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
php-iamcal-lib-autolink-1.7-1.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-be8b9d2565

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1328346] Review Request: php-zendframework-zend-router - Zend Framework Router component

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328346

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #8 from Fedora Update System  ---
php-zendframework-zend-router-3.0.1-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4b3e129dff

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1089962] Review Request: radeontop - View GPU utilization of AMD/ ATI Radeon devices

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1089962

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #31 from Fedora Update System  ---
radeontop-0.9-2.20160527git2047d13.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-202dd11a55

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.fc24 has been pushed to the Fedora 24
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1329923] Review Request: gimp-layer-via-copy-cut - Layer via copy/ cut plug-in for GIMP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1329923

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #14 from Fedora Update System  ---
gimp-layer-via-copy-cut-1.6-2.fc24 has been pushed to the Fedora 24 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-396be8064a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339158] Review Request: pioneer - A game of lonely space adventure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339158

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339158] Review Request: pioneer - A game of lonely space adventure

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339158



--- Comment #9 from Fedora Update System  ---
pioneer-20160512-3.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-85301993ca

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1340946] Review Request: photoqt - A fast Qt image viewer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1340946



--- Comment #1 from Jaroslav Reznik  ---
Name: ok
Version & release: ok
Summary: ok
License: ok (GPLv2+)
URL: ok
Sources: ok (SHA256
9df3392f0bd746778f119a4da98a32e8ae9ae215564df97d7bcf52efa4d08604)

BuildRequires: not ok

BuildRequires:  qt5-qtbase-tds
BuildRequires:  qt5-qtbase-odbc
BuildRequires:  qt5-qtbase-ibase
BuildRequires:  qt5-qtbase-mysql
BuildRequires:  qt5-qtbase-postgresql

are not BuildRequires and are not needed to build the package

Description: ok

Files: ok
Scratch build: builds ok,
http://koji.fedoraproject.org/koji/taskinfo?taskID=14326164

rpmlint output:
rpmlint photoqt-1.4-1.fc24.x86_64.rpm 
photoqt.x86_64: W: no-version-in-last-changelog
photoqt.x86_64: W: no-manual-page-for-binary photoqt
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Please add version to changelog, it's easier to understand what changes happend
in which version

photoqt.spec 
photoqt.spec:2: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 2)
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

I'm not sure I like appdata included in SPEC file, not a big deal but it makes
SPEC file less clear.

Personally I prefer to use desktop-file-install but guidelines are ok with one
of install/validate called, so ok.

{buildroot} and $RPM_BUILD_ROOT are mixed in SPEC file, please choose one for
consistency or just remove rm -rf $RPM_BUILD_ROOT from %install section (not
needed).

For %build and %install sections I'd prefer to use this snippet (out of source
tree build):
%build
mkdir %{_target_platform}
pushd %{_target_platform}
%{cmake} ..
popd

make %{?_smp_mflags} -C %{_target_platform}

%install
make install/fast DESTDIR=%{buildroot} -C %{_target_platform}

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020
Bug 1324020 depends on bug 1340876, which changed state.

Bug 1340876 Summary: cant find symbol error
https://bugzilla.redhat.com/show_bug.cgi?id=1340876

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |NOTABUG



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1339470] Review Request: perl-Tie-Hash-ReadonlyStack - Treat multiple hashes as a single hash with copy-on-write modifications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1339470

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
   Fixed In Version||perl-Tie-Hash-ReadonlyStack
   ||-0.2-1.fc25
 Resolution|--- |RAWHIDE
Last Closed||2016-05-31 02:17:01



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511



--- Comment #11 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.fc23 has been submitted as an update to
Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-398e3384d4

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1324020] Review Request: cassandra - OpenSource database Apache Cassandra

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1324020

Tomas Repik  changed:

   What|Removed |Added

 Depends On||1341013




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1341013
[Bug 1341013] Review Request: compile-command-annotations
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341013] Review Request: compile-command-annotations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341013

Tomas Repik  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG),
   ||1324020




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
https://bugzilla.redhat.com/show_bug.cgi?id=1324020
[Bug 1324020] Review Request: cassandra - OpenSource database Apache
Cassandra
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511



--- Comment #13 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.el7 has been submitted as an update to
Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-b7a27e5732

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1327511] Review Request: php-justinrainbow-json-schema - A library to validate a json schema

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1327511



--- Comment #12 from Fedora Update System  ---
php-justinrainbow-json-schema-2.0.4-1.fc24 has been submitted as an update to
Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ba31f25ade

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1341013] New: Review Request: compile-command-annotations

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1341013

Bug ID: 1341013
   Summary: Review Request: compile-command-annotations
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tre...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gil.fedorapeople.org/cassandra/compile-command-annotations.spec
SRPM URL:
https://gil.fedorapeople.org/cassandra/compile-command-annotations-1.2.0-1.fc23.src.rpm
Description: Annotation based configuration file generator for the 24 Hotspot
JVM JIT compiler. Packaging as a dependency for cassandra.
Fedora Account System Username: trepik

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org