[Bug 1230213] Review Request: perl-Cookie-Baker - Cookie string generator / parser
https://bugzilla.redhat.com/show_bug.cgi?id=1230213 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-06-13 00:56:46 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1230213] Review Request: perl-Cookie-Baker - Cookie string generator / parser
https://bugzilla.redhat.com/show_bug.cgi?id=1230213 --- Comment #14 from Fedora Update System --- perl-Cookie-Baker-0.06-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu
https://bugzilla.redhat.com/show_bug.cgi?id=1312963 --- Comment #18 from Fedora Update System --- glibc-arm-linux-gnu-2.23-4.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-19fabfc432 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu
https://bugzilla.redhat.com/show_bug.cgi?id=1312963 --- Comment #17 from Fedora Update System --- glibc-arm-linux-gnu-2.23-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-91e8c1cf59 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #24 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-62f9ce37df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #23 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-c812458f3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1344936 --- Comment #1 from Olivier Lemasle --- Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=14458515 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344294] Review Request: warsow-data - Game data for Warsow
https://bugzilla.redhat.com/show_bug.cgi?id=1344294 --- Comment #3 from Raphael Groner --- > BuildRequires: /usr/bin/dos2unix You can simplify: BuildRequires: dos2unix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344294] Review Request: warsow-data - Game data for Warsow
https://bugzilla.redhat.com/show_bug.cgi?id=1344294 Raphael Groner changed: What|Removed |Added Blocks||1344261 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1344261 [Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1344261
Raphael Groner changed:
What|Removed |Added
CC||projects...@smart.ms
Depends On||1344294
--- Comment #3 from Raphael Groner ---
Can you put both packages warsow (this bug) and warsaw-data (bug #1344294) in
one spec file? warsaw-data could be a subpackage and is not much useful for its
own alone. We could handle all in one single review.
Are you interested in a review swap? Maybe with bug #1344115.
> %global warsow_libdir %{_prefix}/lib/warsow
…
> # Filter private libraries from provides
> %global __provides_exclude_from ^%{warsow_libdir}/.*\\.so$
…
> # Install private libraries to a private directory
> install -d $RPM_BUILD_ROOT%{warsow_libdir}/libs
> install -m 755 libs/*.so $RPM_BUILD_ROOT%{warsow_libdir}/libs/
…
%files
%{warsow_libdir}/
This does not look right to me. Please explain why this private(?) folder must
be used. You should use %{_libdir}/%{name} instead to also honor 64 bits with
/usr/lib64/warsaw.
> BuildRequires: /usr/bin/convert
> BuildRequires: /usr/bin/desktop-file-install
> BuildRequires: /usr/bin/dos2unix
Better is to use concrete package names:
BuildRequires: ImageMagick
BuildRequires: desktop-file-utils
BuildRequires: dos2unix
You can verify with dnf whatprovides.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1344294
[Bug 1344294] Review Request: warsow-data - Game data for Warsow
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344936] Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1344936 Olivier Lemasle changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344936] New: Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang
https://bugzilla.redhat.com/show_bug.cgi?id=1344936 Bug ID: 1344936 Summary: Review Request: golang-github-kyokomi-emoji - Emoji terminal output for golang Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: o.lema...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://olem.fedorapeople.org/golang-github-kyokomi-emoji.spec SRPM URL: https://olem.fedorapeople.org/golang-github-kyokomi-emoji-1.4-1.fc23.src.rpm Description: Emoji terminal output for golang Fedora Account System Username: olem This is my first package, and I need a sponsor. This library is used by tools like Hugo (http://gohugo.io/). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #22 from Raphael Groner --- Well, that's now nearly v0.3.2 as promised on upstream homepage. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302504] Review Request: elog - Logbook system to manage notes through a Web interface
https://bugzilla.redhat.com/show_bug.cgi?id=1302504 Ben Rosser changed: What|Removed |Added Summary|Review Request: elog - |Review Request: elog - |Weblog server and client|Logbook system to manage ||notes through a Web ||interface --- Comment #7 from Ben Rosser --- Thanks for the review! I will fix those on import. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #21 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-5479660d5a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1312963] Review Request: glibc-arm-linux-gnu - Cross Compiled GNU C Library targeted at arm-linux-gnu
https://bugzilla.redhat.com/show_bug.cgi?id=1312963 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #16 from Fedora Update System --- glibc-arm-linux-gnu-2.23-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-0e39325534 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1294523] Review Request: purple-skypeweb - Adds support for Skype to libpurple-based clients
https://bugzilla.redhat.com/show_bug.cgi?id=1294523 --- Comment #2 from Vitaly Zaitsev --- > Please remove this lines, they are not needed: Removed. > A personal request; can you please add these two lines to the > "purple-skypeweb" pacakge? Added. > Please provide again the "Spec URL" and "SRPM URL" lines with the latest > changes, fedora-review needs to have them when parsing packages/spec files. SPEC: https://github.com/xvitaly/purple-skypeweb/raw/master/purple-skypeweb.spec SRPM: https://copr-be.cloud.fedoraproject.org/results/xvitaly/purple-skypeweb/fedora-23-x86_64/00340324-purple-skypeweb/purple-skypeweb-1.1-6.20160510giteb0b500.fc23.src.rpm rpmlint check result: http://paste.fedoraproject.org/378023/74464314/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 Fedora Update System changed: What|Removed |Added Status|POST|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #20 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-5479660d5a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #18 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-62f9ce37df -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1338553] Review Request: nitroshare - Transfer files from one device to another made extremely simple
https://bugzilla.redhat.com/show_bug.cgi?id=1338553 --- Comment #19 from Fedora Update System --- nitroshare-0.3.1-3.20160612git930c9b7.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-c812458f3c -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1294523] Review Request: purple-skypeweb - Adds support for Skype to libpurple-based clients
https://bugzilla.redhat.com/show_bug.cgi?id=1294523
Simone Caronni changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC||negativ...@gmail.com
Blocks|177841 (FE-NEEDSPONSOR) |
Assignee|nob...@fedoraproject.org|negativ...@gmail.com
--- Comment #1 from Simone Caronni ---
No longer blocking FE-NEEDSPONSOR. I will sponsor Vitaly.
Please remove this lines, they are not needed:
> # generating empty configure script
> echo '#!/bin/bash' > configure
> chmod +x configure
> %configure
It is not mandatory to have a configure script. You can use the following to
pass correct CFLAGS when building:
> export CFLAGS="%{optflags}"
> %make_build
A personal request; can you please add these two lines to the "purple-skypeweb"
pacakge?
> Provides: skype4pidgin = %{version}-%{release}
> Obsoletes: skype4pidgin < %{version}-%{release}
I've been packaging all skype4pidgin plugins for years (including libskypeweb)
until now, where skypeweb is mature enough. I would like to make the transition
transparent to the official Fedora packages for my users:
http://negativo17.org/skype-and-skype-pidgin-plugin/
This can be removed in a few months.
Please provide again the "Spec URL" and "SRPM URL" lines with the latest
changes, fedora-review needs to have them when parsing packages/spec files.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302504] Review Request: elog - Weblog server and client
https://bugzilla.redhat.com/show_bug.cgi?id=1302504 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #6 from Antonio Trande --- (In reply to Antonio Trande from comment #5) > Binary files are still "No PIE" I checked again, binary files are good. I can definitively do pass this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302504] Review Request: elog - Weblog server and client
https://bugzilla.redhat.com/show_bug.cgi?id=1302504 Antonio Trande changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #5 from Antonio Trande --- Binary files are still "No PIE" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302504] Review Request: elog - Weblog server and client
https://bugzilla.redhat.com/show_bug.cgi?id=1302504 Antonio Trande changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Antonio Trande --- Please, fix 'file-not-utf8' and 'spurious-executable-perm' warnings. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1342743] Review Request: crawl - Roguelike dungeon exploration game
https://bugzilla.redhat.com/show_bug.cgi?id=1342743 --- Comment #4 from Raphael Groner --- Besides running the unit tests after a package build, defing one of DEBUG, DEBUG_DIAGNOSTICS or DEBUG_TEST may help with further abrt reports, too. Please consider to do so, though I can't tell what's best for abrt, propably DEBUG is sufficient. > [!]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v3 > or later)", "Unknown or generated", "MIT/X11 (BSD like)", "BSD (2 > clause)", "BSD (3 clause) GPL (v2 or later)", "*No copyright* MIT/X11 > (BSD like)". 1507 files have unknown license. The combined license and the amount of unlicensed files let suspect bundled libraries. You MUST add a license breakdown as comment, what individual file is licensed how. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios https://fedoraproject.org/wiki/Bundled_Libraries?rd=Packaging:Bundled_Libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
