[Bug 1356907] Review Request: rust - The Rust Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1356907 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #9 from Igor Gnatenko --- * Fix license tag as we discussed on IRC (add license files if they are there) * Make docs noarch as discussed on IRC * Build tests in parallel Probably we should also consider adding Provides: rustc (with version, %_isa and etc.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files
https://bugzilla.redhat.com/show_bug.cgi?id=1310294 --- Comment #19 from Siddharth Sharma --- (In reply to Rex Dieter from comment #17) > re-reading, looks like my item 12 was missing the actual spec suggestion: > ... this helps: > # fix/workaround hard-coded rpaths > sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' > libtool > sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool Updated for Review SPECS: https://siddharths.fedorapeople.org/SPECS/sqlcipher.spec SRPMS: https://siddharths.fedorapeople.org/SRPMS/sqlcipher-3.3.1-4.fc24.src.rpm I removed tcl from packaging and openssl-devel was missing from build requires. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360587] Review Request: rsyntaxtextarea - A syntax highlighting, code folding text editor for Java Swing applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360587 Dennis Chen changed: What|Removed |Added Blocks||1316315 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1316315 [Bug 1316315] arduino-1.6.10 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360587] New: Review Request: rsyntaxtextarea - A syntax highlighting , code folding text editor for Java Swing applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360587 Bug ID: 1360587 Summary: Review Request: rsyntaxtextarea - A syntax highlighting, code folding text editor for Java Swing applications Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: barracks...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://barracks510.fedorapeople.org/packaging/rsyntaxtextarea.spec SRPM URL: https://barracks510.fedorapeople.org/packaging/rsyntaxtextarea-2.5.8-1.fc24.src.rpm Koji Build URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=15030953 Description: RSyntaxTextArea is a customizable, syntax highlighting text component for Java Swing applications. Out of the box, it supports syntax highlighting for 40+ programming languages, code folding, search and replace, and has add-on libraries for code completion and spell checking. Syntax highlighting for additional languages can be added via tools such as JFlex. Fedora Account System Username: barracks510 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356907] Review Request: rust - The Rust Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1356907 --- Comment #8 from Josh Stone --- New files: https://fedorapeople.org/~jistone/review/rust/v2/rust.spec https://fedorapeople.org/~jistone/review/rust/v2/rust-1.10.0-2.fc26.src.rpm I updated the things I agreed to above. I didn't yet do anything about changing the packaging static files, making -doc noarch, or moving libraries to a subdirectory. Please see my questions about those. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310368] review request: rubygem-jekyll - A simple, blog aware, static site generator
https://bugzilla.redhat.com/show_bug.cgi?id=1310368 --- Comment #5 from Dennis Chen --- > leave it as a placeholder and I will close it out when I resubmit properly. This would be great. Looking forward to having Jekyll on Fedora. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1359794] Review Request: python-marrow-util - A collection of many commonly re-implemented utility classes and functions
https://bugzilla.redhat.com/show_bug.cgi?id=1359794 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1359794] Review Request: python-marrow-util - A collection of many commonly re-implemented utility classes and functions
https://bugzilla.redhat.com/show_bug.cgi?id=1359794 --- Comment #3 from Fedora Update System --- python-marrow-util-1.2.3-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-ee99ebdad6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332607] Review Request: gap-pkg-scscp - Symbolic Computation Software Composability Protocol in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1332607 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332607] Review Request: gap-pkg-scscp - Symbolic Computation Software Composability Protocol in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1332607 --- Comment #9 from Fedora Update System --- gap-pkg-scscp-2.1.4-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-39819ec5e6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1177494] Review Request: paper-gtk-theme - Paper GTK Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1177494 Eduardo Mayorga changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1177494] Review Request: paper-gtk-theme - Paper GTK Theme
https://bugzilla.redhat.com/show_bug.cgi?id=1177494 Eduardo Mayorga changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |NOTABUG Last Closed||2016-07-26 23:33:27 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334112] Review Request: pintail - build web sites from plain text markup
https://bugzilla.redhat.com/show_bug.cgi?id=1334112 Eduardo Mayorga changed: What|Removed |Added CC||m...@petetravis.com Flags||needinfo?(m...@petetravis.com ||) --- Comment #6 from Eduardo Mayorga --- Any update? If there is no response you, Pete, within one week, I'll close this bug as per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1340473] Review Request: mvapich2 - MPI implementation for InfiniBand , iWARP and RoCE
https://bugzilla.redhat.com/show_bug.cgi?id=1340473 Honggang LI changed: What|Removed |Added Status|NEW |ASSIGNED CC||ho...@redhat.com Assignee|nob...@fedoraproject.org|ho...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1118740] Remove the hard dependency on systemd for packages, which make use of systemd rpm macros
https://bugzilla.redhat.com/show_bug.cgi?id=1118740 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||systemd-231-2.fc25.x86_64 Resolution|--- |RAWHIDE Last Closed||2016-07-26 22:47:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1256057] Review Request: ghc-time-locale-compat - Compatibility of TimeLocale between old-locale and time-1.5
https://bugzilla.redhat.com/show_bug.cgi?id=1256057 --- Comment #6 from Jens Petersen --- rpmbuild fails (due to %license): please check the "cblrpm diff" output. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346038] Review Request: python-blivet1 - python2/ blivet-1.x compatibility package
https://bugzilla.redhat.com/show_bug.cgi?id=1346038
Douglas Schilling Landgraf changed:
What|Removed |Added
Status|NEW |ASSIGNED
Assignee|dleh...@redhat.com |dougsl...@redhat.com
--- Comment #14 from Douglas Schilling Landgraf ---
Hi David,
(In reply to David Lehman from comment #13)
> New spec and SRPM available:
>
> SRPM:
> https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-2.fc25.
> src.rpm
>
> SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec
>
>
>
> (I didn't change pygobject3-base requires since that does not have anything
> to do with python3.)
Looks like it has to do with python3, from pygobject3-base spec:
%if 0%{?fedora} > 12
%global with_python3 1
%define python3_version3.1
%endif
%if 0%{?with_python3}
BuildRequires: python3-devel >= %{python3_version}
BuildRequires: python3-cairo-devel
%endif # if with_python3
From:
https://admin.fedoraproject.org/pkgdb/package/rpms/pygobject2/
rpms/pygobject2 (upstream)
Python 2 bindings for GObject
The pygobject2 package provides a convenient wrapper for the GObject library
for use in Python programs.
Additional comment, you can remove the lines below because it's
deprecated/obsolete:
* rm -rf %{buildroot}
* %defattr(-,root,root,-)
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1118740] Remove the hard dependency on systemd for packages, which make use of systemd rpm macros
https://bugzilla.redhat.com/show_bug.cgi?id=1118740 Zbigniew Jędrzejewski-Szmek changed: What|Removed |Added Status|ASSIGNED|POST --- Comment #39 from Zbigniew Jędrzejewski-Szmek --- OK, let's see how that works out in real life. Implemented in http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?id=46083abe1a4de3328d84e4a32ee22c78ac414b03, but I didn't rebuild. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333933] Review Request: ixpdimm_sw - API for development of IXPDIMM management utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1333933 --- Comment #9 from Dan Williams --- I am unable to build this package due to missing ctemplate in Rawhide. ctemplate package only exists in Fedora 23, but has been marked as retired/orphaned for all Fedora releases after 23 as well as EPEL. See: https://admin.fedoraproject.org/pkgdb/package/rpms/ctemplate/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 Nick Bebout changed: What|Removed |Added Assignee|nob...@fedoraproject.org|n...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 Nick Bebout changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #3 from Nick Bebout --- I also changed the summary, since I believe the name of the package in the summary is supposed to be the same as what will be requested for the name of the package in scm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] Review Request: nextcloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 Nick Bebout changed: What|Removed |Added Summary|Review Request: NextCloud - |Review Request: nextcloud - |a private, secure way to|a private, secure way to |share and access files |share and access files -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] Review Request: NextCloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 Nick Bebout changed: What|Removed |Added CC||n...@fedoraproject.org --- Comment #2 from Nick Bebout --- s/NextCloud/Nextcloud I think I'll try to do this review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1333933] Review Request: ixpdimm_sw - API for development of IXPDIMM management utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1333933 --- Comment #8 from Namratha Kothapalli --- Latest code and specs - Spec URL: https://github.com/01org/ixpdimm_sw/releases/download/v01.00.00.2104/ixpdimm_sw.spec SRPM URL: https://github.com/01org/ixpdimm_sw/releases/download/v01.00.00.2104/ixpdimm_sw-01.00.00.2104-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] Review Request: NextCloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 James Hogarth changed: What|Removed |Added Whiteboard||NotReady --- Comment #1 from James Hogarth --- This is a semi-placeholder whilst plans are finalized now that the dependency for it that was missing in Fedora has been approved. This is the same SRPM and SPEC used in the COPR: https://copr.fedorainfracloud.org/coprs/jhogarth/NextCloud The spec is based on the existing owncloud one which this has forked from and installs in parallel to rather than replaces. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360482] New: Review Request: NextCloud - a private, secure way to share and access files
https://bugzilla.redhat.com/show_bug.cgi?id=1360482 Bug ID: 1360482 Summary: Review Request: NextCloud - a private, secure way to share and access files Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: james.hoga...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jhogarth.fedorapeople.org/nextcloud/nextcloud.spec SRPM URL: https://jhogarth.fedorapeople.org/nextcloud/nextcloud-9.0.53-2.fc25.src.rpm Description: Nextcloud gives you a private, secure way to share, work with others and access your own data using an easy to use interface. Be it music, calendar appointments, bookmarks, email or your documents, Nextcloud keeps your data safe. Fedora Account System Username: jhogarth -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346038] Review Request: python-blivet1 - python2/ blivet-1.x compatibility package
https://bugzilla.redhat.com/show_bug.cgi?id=1346038 --- Comment #13 from David Lehman --- New spec and SRPM available: SRPM: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-2.fc25.src.rpm SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec (I didn't change pygobject3-base requires since that does not have anything to do with python3.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334112] Review Request: pintail - build web sites from plain text markup
https://bugzilla.redhat.com/show_bug.cgi?id=1334112
--- Comment #5 from William Moreno ---
From build log in corp:
Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.Ay244b
+ umask 022
+ cd /builddir/build/BUILD
+ cd pintail-1e00238e3446b199d043742b56d092e7b65aca72
+ /usr/bin/python3 setup.py test
running test
running egg_info
writing top-level names to pintail.egg-info/top_level.txt
writing pintail.egg-info/PKG-INFO
writing namespace_packages to pintail.egg-info/namespace_packages.txt
writing dependency_links to pintail.egg-info/dependency_links.txt
reading manifest file 'pintail.egg-info/SOURCES.txt'
writing manifest file 'pintail.egg-info/SOURCES.txt'
running build_ext
--
Ran 0 tests in 0.000s
There are not test in sources so you should remove:
%check
%{__python3} setup.py test
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1334112] Review Request: pintail - build web sites from plain text markup
https://bugzilla.redhat.com/show_bug.cgi?id=1334112
William Moreno changed:
What|Removed |Added
CC||williamjmore...@gmail.com
--- Comment #4 from William Moreno ---
%py3_build and %py3_install should work since it is a noarch package.
The shebang of:
https://github.com/projectmallard/pintail/blob/master/bin/pintail
Should be:
#!/usr/bin/python3 and not #!/usr/bin/env python3
%description looks like to be a single long line and no split in <80 characters
lines.
The file:
https://github.com/projectmallard/pintail/blob/master/pintail/sample.cfg
Should be in %docs.
An by the way
%files
%doc
%{python3_sitelib}/*
%{_bindir}/%{name}
%doc is empy I you must use the %license macro for the COPYING file.
Please use a black line before %changelog
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1118740] Remove the hard dependency on systemd for packages, which make use of systemd rpm macros
https://bugzilla.redhat.com/show_bug.cgi?id=1118740 --- Comment #38 from Yaakov Selkowitz --- (In reply to Harald Hoyer from comment #36) > Note: installing systemd afterwards in a separate rpm transaction does not > produce the same result. What about the proposal in comment 23 wrt handling pre-installed presets in %post if [ $1 == 1 ]? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1118740] Remove the hard dependency on systemd for packages, which make use of systemd rpm macros
https://bugzilla.redhat.com/show_bug.cgi?id=1118740 --- Comment #37 from Yaakov Selkowitz --- Policy guideline discussion: https://fedorahosted.org/fpc/ticket/644 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1238385] Review Request: mingw-qtspell - Spell checking for Qt text widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1238385 --- Comment #5 from Sandro Mani --- Mh sorry managed to upload a wrong SRPM, re-uploaded the correct one. http://koji.fedoraproject.org/koji/taskinfo?taskID=15026089 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares
https://bugzilla.redhat.com/show_bug.cgi?id=1356552 --- Comment #19 from Fedora Update System --- php-onelogin-php-saml-2.9.1-3.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-81dff2c066 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares
https://bugzilla.redhat.com/show_bug.cgi?id=1356552 --- Comment #18 from Fedora Update System --- php-onelogin-php-saml-2.9.1-3.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-353d77a339 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares
https://bugzilla.redhat.com/show_bug.cgi?id=1356552 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares
https://bugzilla.redhat.com/show_bug.cgi?id=1356552 --- Comment #17 from Fedora Update System --- php-onelogin-php-saml-2.9.1-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-de1aca249f -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1270405] Review Request: chromium-native_client - Google Native Client Toolchain
https://bugzilla.redhat.com/show_bug.cgi?id=1270405 Tom "spot" Callaway changed: What|Removed |Added Summary|Review Request: |Review Request: |native_client - Google |chromium-native_client - |Native Client Toolchain |Google Native Client ||Toolchain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1270405] Review Request: native_client - Google Native Client Toolchain
https://bugzilla.redhat.com/show_bug.cgi?id=1270405 --- Comment #15 from Tom "spot" Callaway --- Okay. I _think_ things are working again. New SRPM: https://spot.fedorapeople.org/chromium-native_client-52.0.2743.82-1.20160725git7d72623.fc24.src.rpm New SPEC: https://spot.fedorapeople.org/chromium-native_client.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Janet Morgan changed: What|Removed |Added Flags||needinfo?(nhor...@redhat.co ||m) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353000] Review Request: gns3-server - Graphical Network Simulator 3
https://bugzilla.redhat.com/show_bug.cgi?id=1353000 Athmane Madjoudj changed: What|Removed |Added Blocks||1359761 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1359761 [Bug 1359761] GNS3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353001] Review Request: gns3-gui - Graphical Network Simulator 3
https://bugzilla.redhat.com/show_bug.cgi?id=1353001 Athmane Madjoudj changed: What|Removed |Added Blocks||1359761 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1359761 [Bug 1359761] GNS3 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 --- Comment #11 from Jonny Heggheim --- (In reply to gil cattaneo from comment #10) > Seem vailable in this sub folders: > keepkey/src/main/keepkey-common/protob/ > ... or no? are not the same? They are different. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files
https://bugzilla.redhat.com/show_bug.cgi?id=1310294 --- Comment #18 from Siddharth Sharma --- (In reply to Rex Dieter from comment #17) > re-reading, looks like my item 12 was missing the actual spec suggestion: > ... this helps: > # fix/workaround hard-coded rpaths > sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' > libtool > sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool Thanks a lot Rex :) Will fix it asap. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356907] Review Request: rust - The Rust Programming Language
https://bugzilla.redhat.com/show_bug.cgi?id=1356907
--- Comment #7 from Josh Stone ---
(In reply to Igor Gnatenko from comment #6)
> * License file FiraSans-LICENSE.txt is not marked as %license
OK, will change.
> * Package has .a files
Yes, libcompiler-rt.a, and technically all the .rlib files are static archives
too. I could move them all to a rust-static package, and then the base rust
package will need to require that anyway. Is that preferable?
> * %doc %{_docdir}/%{name}/html/
> -> nothing actually owns %{_docdir}/%{name} for -doc subpackage
Ok, it can share ownership of that directory, right?
> * %define bootstrap_base
> https://static.rust-lang.org/dist/%{bootstrap_date}/rustc-
> %{bootstrap_channel}
> use %global
Sure, will change.
> * BuildRequires: python
> -> is it really needed like python? not python2 or python3?
You're right, it needs python2. I'll change it.
> * -doc subpackage must be noarch
How strong is that "must"? The documentation can vary by architecture in small
ways. For instance, `std::os::linux::raw::stat`[1] varies everywhere. That
happens to be deprecated, but it's just one I know off-hand; there may be more.
[1] https://doc.rust-lang.org/stable/std/os/linux/raw/struct.stat.html
> * is it possible to move all lib*.so into for example, %{_libdir}/rust/?
Maybe so, but why? They have unique hashes in the names, so they won't
collide. Then we'd have to either add rpaths to rustc and rustdoc, or add this
path to ld.so.conf.d/ anyway. So why move them?
> Bundled libs, add to License tag and include licenses to %license:
> * libbacktrace is BSD
> * hoedown is ISC
OK to both.
> * I think "or" should be replaced with "and" in License or rust is licensed
> on one or second license?
Rust's COPYRIGHT explicitly says it is "at your option", so I think "or" is
correct. Then I guess the additions for bundled libraries will be "and", so we
need something like this?
License: ASL 2.0 or MIT, and BSD and ISC
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354545] Review Request: rubygem-actioncable - WebSocket framework for Rails
https://bugzilla.redhat.com/show_bug.cgi?id=1354545 Vít Ondruch changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||rubygem-actioncable-5.0.0-1 ||.fc25 Resolution|--- |RAWHIDE Last Closed||2016-07-26 13:13:27 --- Comment #10 from Vít Ondruch --- Thank you for the review and processing the package request. The package is now available in Rawhide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356597] Review Request: opensaml-java - APIs to work with SAML messages as Java bean objects
https://bugzilla.redhat.com/show_bug.cgi?id=1356597 --- Comment #7 from gil cattaneo --- (In reply to Raphael Groner from comment #6) > Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15024957 > → success > > Waiting for dependency to arrive on my rawhide mirror (using fastestmirror). > > ERROR: Command failed: > # /usr/bin/dnf builddep --installroot > /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 25 Please, use rawhide > /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/opensaml-java- > 3.1.1-1.fc25.src.rpm --setopt=tsflags=nocontexts > No matching package to install: 'mvn(net.shibboleth.utilities:java-support)' > Not all dependencies satisfied > Error: Some packages could not be found. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343661] Rebase clufter component
https://bugzilla.redhat.com/show_bug.cgi?id=1343661 --- Comment #9 from Jan Pokorný --- re [comment 1]: 0.56.3 + 0.57.0: http://oss.clusterlabs.org/pipermail/users/2016-July/003423.html (for 0.56.3, there's a caveat: http://oss.clusterlabs.org/pipermail/users/2016-July/003456.html) 0.58.0: http://oss.clusterlabs.org/pipermail/users/2016-July/003513.html 0.59.0: http://oss.clusterlabs.org/pipermail/users/2016-July/003594.html 0.59.1: http://oss.clusterlabs.org/pipermail/users/2016-July/003630.html Or there's changelog-only digest to be found at: https://pagure.io/clufter/releases -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1276834] Review Request: php-mongodb - MongoDB driver library
https://bugzilla.redhat.com/show_bug.cgi?id=1276834 --- Comment #6 from Jon Ciesla --- Package request has been denied with the reason: please resubmit in rpms namespace -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356597] Review Request: opensaml-java - APIs to work with SAML messages as Java bean objects
https://bugzilla.redhat.com/show_bug.cgi?id=1356597 --- Comment #6 from Raphael Groner --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15024957 → success Waiting for dependency to arrive on my rawhide mirror (using fastestmirror). ERROR: Command failed: # /usr/bin/dnf builddep --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 25 /var/lib/mock/fedora-rawhide-x86_64/root//builddir/build/SRPMS/opensaml-java-3.1.1-1.fc25.src.rpm --setopt=tsflags=nocontexts No matching package to install: 'mvn(net.shibboleth.utilities:java-support)' Not all dependencies satisfied Error: Some packages could not be found. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files
https://bugzilla.redhat.com/show_bug.cgi?id=1310294 --- Comment #17 from Rex Dieter --- re-reading, looks like my item 12 was missing the actual spec suggestion: ... this helps: # fix/workaround hard-coded rpaths sed -i 's|^hardcode_libdir_flag_spec=.*|hardcode_libdir_flag_spec=""|g' libtool sed -i 's|^runpath_var=LD_RUN_PATH|runpath_var=DIE_RPATH_DIE|g' libtool -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files
https://bugzilla.redhat.com/show_bug.cgi?id=1310294
--- Comment #16 from Rex Dieter ---
Looks good, all the blocker items mentioned previously were addressed.
Remaining items to consider:
5. SHOULD document why these compiler flags are needed in a .spec comment
CFLAGS="-DSQLITE_HAS_CODEC -DSQLITE_TEMP_STORE=2"
LDFLAGS="-lcrypto"
...
I'd suggest a comment:
# recommended in README.md ## Compiling section
7a. MUST use %%license tag, instead of:
%doc LICENSE README.md
use
%doc README.md
%license LICENSE
7b. SHOULD, since main pkg already includes README.md and LICENSE, no need to
include in -devel and -tcl subpkg's too, please remove them.
8. (since you're already using %{make_install}), SHOULD use convenience macro
%{make_build}
instead of
make %{?_smp_mflags}
use
%{make_build}
naming: ok
sources: ok
26be3c23220192fb42e1d60f8c90ac69 v3.3.1.tar.gz
macros: ok
scriptlets: ok
licensing: NOT ok
9. MUST use
License: BSD
to match recommendation on
https://fedoraproject.org/wiki/Licensing
10a. SHOULD consider using build option:
--disable-tcl
and avoid the hassle of the -tcl subpkg, unless you specifically are willing to
support this.
10b. MUST: If you choose to keep -tcl subpkg, then must add a versioned
dependency to main pkg:
Requires: %{name}%{?_isa} = %{version}-%{release}
11. MUST remove
%define _unpackaged_files_terminate_build 0
there are better ways of fixing unpackaged files than this hack, for example,
adding this after %{make_install}:
rm -fv %{buildroot}%{_libdir}/lib*.la
12. MUST fix rpath issues, doing a local build, I get:
ERROR 0001: file '/usr/share/tcl8.6/sqlite3/libtclsqlite3.so' contains a
standard rpath '/usr/lib64' in [/usr/lib64]
ERROR 0001: file '/usr/bin/sqlcipher' contains a standard rpath '/usr/lib64'
in [/usr/lib64]
per
https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Removing_Rpath
adding after %configure, this helps:
13. SHOULD remove deprecated items/tags from .spec, including:
(from %install section):
rm -rf $RPM_BUILD_ROOT
Please fix all MUST (blocker) items, and I will approve this package review.
Consider addressing SHOULD (optional) items too, and you'll be extra awesome.
If it helps, here's a copy of
https://rdieter.fedorapeople.org/rpms/sqlcipher.spec
that implements all the suggested fixes (I think).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1238385] Review Request: mingw-qtspell - Spell checking for Qt text widgets
https://bugzilla.redhat.com/show_bug.cgi?id=1238385 --- Comment #4 from Raphael Groner --- FTBFS Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15024939 + MINGW32_CMAKE_ARGS=' -DINCLUDE_INSTALL_DIR:PATH=/usr/i686-w64-mingw32/sys-root/mingw/include -DCMAKE_VERBOSE_MAKEFILE=ON' + PATH=/usr/i686-w64-mingw32/bin:/usr/i686-w64-mingw32/sys-root/mingw/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin + /usr/bin/cmake -DCMAKE_TOOLCHAIN_FILE=/usr/share/mingw/toolchain-mingw32.cmake -DBUILD_SHARED_LIBS:BOOL=ON -DSYSCONF_INSTALL_DIR:PATH=/usr/i686-w64-mingw32/sys-root/mingw/etc -DSHARE_INSTALL_PREFIX:PATH=/usr/i686-w64-mingw32/sys-root/mingw/share -DCMAKE_INSTALL_PREFIX:PATH=/usr/i686-w64-mingw32/sys-root/mingw -DCMAKE_INSTALL_LIBDIR:PATH=/usr/i686-w64-mingw32/sys-root/mingw/lib -DINCLUDE_INSTALL_DIR:PATH=/usr/i686-w64-mingw32/sys-root/mingw/include -DCMAKE_VERBOSE_MAKEFILE=ON -DBUILD_STATIC_LIBS=ON .. CMake Error: The source directory "/builddir/build/BUILD/qtspell-0.8.1/build_qt4" does not appear to contain CMakeLists.txt. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360199] Review Request: snap-confine - Confinement system for snap applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360199
--- Comment #12 from Neal Gompa ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Permissions on files are set properly.
Note: See rpmlint output
See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
- Package uses hardened build flags if required to.
Note: suid files: snap-confine and not %global _hardened_build
See:
http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[?]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "GPL (v3)", "Unknown or generated". 30
files have unknown license. Detailed output of licensecheck in
/home/makerpm/1360199-snap-confine/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/libexec/snapd
[?]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/lib/udev,
/usr/libexec/snapd, /usr/lib/udev/rules.d
[-]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by:
/usr/share/man/man5(filesystem), /usr/share/man/man1(filesystem)
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: Package contains systemd file(s) if in need.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa
[Bug 1360199] Review Request: snap-confine - Confinement system for snap applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360199 Neal Gompa changed: What|Removed |Added Flags|fedora-review+ |fedora-review? --- Comment #11 from Neal Gompa --- Actually, there's still something left here... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343661] Rebase clufter component
https://bugzilla.redhat.com/show_bug.cgi?id=1343661 errata-xmlrpc changed: What|Removed |Added Status|MODIFIED|ON_QA -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #11 from Raphael Groner --- https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343661] Rebase clufter component
https://bugzilla.redhat.com/show_bug.cgi?id=1343661 Jan Pokorný changed: What|Removed |Added Status|ON_QA |MODIFIED Fixed In Version|clufter-0.59.0-1.el7|clufter-0.59.1-1.el7 -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #10 from Raphael Groner --- License discussion continued. Why license CC-BY-SA for the doc subpackage? I can not validate because I don't find any file from upstream that says so. Still not fixed as in comment #4: [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2 or later)", "GPL (v2 or later)", "Unknown or generated", "GPL (v2 or later) LGPL (v2 or later)", "MIT/X11 (BSD like)", "*No copyright* GPL (v2 or later)". 43 files have unknown license. Detailed output of licensecheck in /home/builder/fedora- review/1354210-xviewer/licensecheck.txt [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. => Add MIT to license tag and a comment about license breakdown. I'll attach full licensetext.txt content. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1310294] Review Request: sqlcipher - An SQLite extension that provides 256 bit AES encryption of database files
https://bugzilla.redhat.com/show_bug.cgi?id=1310294 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #15 from Rex Dieter --- I can review today -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1050744] Review Request: belle-sip - Linphone SIP stack
https://bugzilla.redhat.com/show_bug.cgi?id=1050744 --- Comment #50 from Orion Poplawski --- Comment on attachment 1184318 --> https://bugzilla.redhat.com/attachment.cgi?id=1184318 Replace readdir_r with readdir and catch errno Seems reasonable to me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1050744] Review Request: belle-sip - Linphone SIP stack
https://bugzilla.redhat.com/show_bug.cgi?id=1050744 Tom "spot" Callaway changed: What|Removed |Added Attachment|0 |1 #1183912 is|| obsolete|| --- Comment #49 from Tom "spot" Callaway --- Created attachment 1184318 --> https://bugzilla.redhat.com/attachment.cgi?id=1184318&action=edit Replace readdir_r with readdir and catch errno How about this one? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #4 from José Matos --- Ping... I am updating the package to the latest version that is available at updates-testing for F24: Spec URL: https://jamatos.fedorapeople.org/python-nikola.spec SRPM URL: https://jamatos.fedorapeople.org/python-nikola-7.7.11-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344415] Review Request: v8-314 - JavaScript Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1344415 Tom "spot" Callaway changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-07-26 11:30:51 --- Comment #7 from Tom "spot" Callaway --- v8-314 is in rawhide/f25. I'm rebuilding v8 for all active branches (el6, el7, f23, f24) to add Provides for v8-314. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1verbs - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #31 from dennis.dalessan...@intel.com --- Hi Neil, What info is being requested from me at this point? So you marked it approved, now am I waiting to get a sponsor? Does the FE_NEEDSPONSOR in the blocks section accomplish that or is there something else I should do to move that along. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354210] Review Request: xviewer - Fast and functional graphics viewer
https://bugzilla.redhat.com/show_bug.cgi?id=1354210 --- Comment #9 from Raphael Groner --- Forgot, sorry: Unknown or generated xviewer-1.0.4/jpegutils/jpegint-8a.h xviewer-1.0.4/jpegutils/transupp-8a.h These two files have IJG license, see README.8a file. https://fedoraproject.org/wiki/Licensing/IJG Although: GPL (v2 or later) - xviewer-1.0.4/jpegutils/jpegint.h xviewer-1.0.4/jpegutils/transupp-6b.c xviewer-1.0.4/jpegutils/transupp-6b.h xviewer-1.0.4/jpegutils/transupp-8a.c xviewer-1.0.4/jpegutils/transupp.h make[2]: Entering directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' CC transupp-6b.lo CCLD libxviewer-jpegutils.la make[2]: Leaving directory '/builddir/build/BUILD/xviewer-1.0.4/jpegutils' I don't understand. Do we see a (forbidden) try to relicense jpegutils files from IJG to GPLv2+ and a case of bundling? How are those files relevant for the project because 'BR: pkgconfig(libjpeg)'? AND: Did you report or ask about the unlicensed files as in comment #6 to upstream? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1276834] Review Request: php-mongodb - MongoDB driver library
https://bugzilla.redhat.com/show_bug.cgi?id=1276834 Remi Collet changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #5 from Remi Collet --- Thanks for the review! New package requested on pkgdb. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360199] Review Request: snap-confine - Confinement system for snap applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360199 Neal Gompa changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #10 from Neal Gompa --- If you want, you can also change over the rest of the BRs, too... glib2-devel -> pkgconfig(glib-2.0) libseccomp-devel -> pkgconfig(libseccomp) Otherwise, this looks good to me. Package approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354398] Review Request: golang-github-golang-time - Go supplementary time packages
https://bugzilla.redhat.com/show_bug.cgi?id=1354398 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-golang-time -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354378] Review Request: golang-github-urfave-cli - A simple, fast, and fun package for building command line apps in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1354378 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-urfave-cli -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354375] Review Request: golang-github-gengo-grpc-gateway - GRPC to JSON proxy generator
https://bugzilla.redhat.com/show_bug.cgi?id=1354375 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-gengo-grpc-gateway -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356552] Review Request: php-onelogin-php-saml - SAML support for PHP softwares
https://bugzilla.redhat.com/show_bug.cgi?id=1356552 --- Comment #16 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-onelogin-php-saml -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360199] Review Request: snap-confine - Confinement system for snap applications
https://bugzilla.redhat.com/show_bug.cgi?id=1360199 --- Comment #9 from Zygmunt Krynicki --- I've updated packaging to reflect this discussion. I hope I didn't miss anything. The spec and SRPM file is at the same location as before. You can have a detailed view of the changes I made here: https://github.com/zyga/snapcore-fedora/commits/master -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360394] New: Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog
https://bugzilla.redhat.com/show_bug.cgi?id=1360394 Bug ID: 1360394 Summary: Review Request: python-pytest-watch - Local continuous test runner with pytest and watchdog Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: juj...@jujens.eu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://dl.jujens.eu/SPECS/python-pytest-watch.spec SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-watch-4.1.0-1.fc24.src.rpm Description: A zero-config CLI tool that runs [pytest][], and re-runs it when a file in your project changes. It beeps on failures and can run arbitrary commands on each passing and failing test run. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1276834] Review Request: php-mongodb - MongoDB driver library
https://bugzilla.redhat.com/show_bug.cgi?id=1276834
James Hogarth changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from James Hogarth ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
= Issues =
* Extraneous boilerplate
- Please remove non-fedora boilerplate when importing
* Newer version avaliable
- Please consider updating to 1.0.2 when importing
* Not actively tested
- Considering library works as check tests passing
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated". 143 files have unknown license.
Detailed output of licensecheck in /home/james/workspace/fedora-
scm/1276834-php-mongodb/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
Note: rm -rf %{buildroot} present but not required
[x]: Sources contain only permissible code or content.
[!]: Each %files section contains %defattr if rpm < 4.4
Note: %defattr present but not needed
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 92160 bytes in 15 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
Note: Multiple Release: tags found
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
Note: %clean present but not required
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x
[Bug 1356597] Review Request: opensaml-java - APIs to work with SAML messages as Java bean objects
https://bugzilla.redhat.com/show_bug.cgi?id=1356597 --- Comment #5 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15024434 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360365] New: Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test
https://bugzilla.redhat.com/show_bug.cgi?id=1360365 Bug ID: 1360365 Summary: Review Request: python-pytest-mock - Thin-wrapper around the mock package for easier use with py.test Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: juj...@jujens.eu QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://dl.jujens.eu/SPECS/python-pytest-mock.spec SRPM URL: http://dl.jujens.eu/SRPMS/python-pytest-mock-1.1-1.fc24.src.rpm Description: his plugin installs a mocker fixture which is a thin-wrapper around the patching API provided by the mock package, but with the benefit of not having to worry about undoing patches at the end of a test. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356594] Review Request: shibboleth-java-support - Java Support for Shibbleth projects
https://bugzilla.redhat.com/show_bug.cgi?id=1356594 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356594] Review Request: shibboleth-java-support - Java Support for Shibbleth projects
https://bugzilla.redhat.com/show_bug.cgi?id=1356594 --- Comment #11 from Fedora Update System --- shibboleth-java-support-7.1.1-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d6eed6bdf7 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 --- Comment #10 from gil cattaneo --- (In reply to Jonny Heggheim from comment #8) > (In reply to gil cattaneo from comment #3) > > Please use: %mvn_build -f -- -Pupdate-protobuf > > for re-generate java code > > The protobuf source files are git submodules and are not included in the > archive. I am not sure if there is an easy way to re-gernerate the Java code. > > $ cat multibit-hardware-0.7.0/.gitmodules > [submodule "trezor-common"] > path = trezor/src/main/trezor-common > url = https://github.com/trezor/trezor-common.git > [submodule "hid4java/src/main/cpp/hidapi"] > path = hid4java/src/main/cpp/hidapi > url = https://github.com/signal11/hidapi Seem vailable in this sub folders: keepkey/src/main/keepkey-common/protob/ ... or no? are not the same? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354398] Review Request: golang-github-golang-time - Go supplementary time packages
https://bugzilla.redhat.com/show_bug.cgi?id=1354398 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #1 from Lokesh Mandvekar --- - package spec conforms to golang packaging draft - only sources installed - license valid package approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354378] Review Request: golang-github-urfave-cli - A simple, fast, and fun package for building command line apps in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1354378 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #1 from Lokesh Mandvekar --- - package spec conforms to golang packaging draft - only sources installed - license valid package approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 --- Comment #9 from Jonny Heggheim --- (In reply to gil cattaneo from comment #2) > hi > if you have time, can you take this > https://bugzilla.redhat.com/show_bug.cgi?id=1359797 ? > thanks in advance I will review it in my next available Fedora time slot. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 --- Comment #8 from Jonny Heggheim --- (In reply to gil cattaneo from comment #3) > Please use: %mvn_build -f -- -Pupdate-protobuf > for re-generate java code The protobuf source files are git submodules and are not included in the archive. I am not sure if there is an easy way to re-gernerate the Java code. $ cat multibit-hardware-0.7.0/.gitmodules [submodule "trezor-common"] path = trezor/src/main/trezor-common url = https://github.com/trezor/trezor-common.git [submodule "hid4java/src/main/cpp/hidapi"] path = hid4java/src/main/cpp/hidapi url = https://github.com/signal11/hidapi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354375] Review Request: golang-github-gengo-grpc-gateway - GRPC to JSON proxy generator
https://bugzilla.redhat.com/show_bug.cgi?id=1354375 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #2 from Lokesh Mandvekar --- - package spec conforms to golang packaging draft - only sources installed - license valid package approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1332607] Review Request: gap-pkg-scscp - Symbolic Computation Software Composability Protocol in GAP
https://bugzilla.redhat.com/show_bug.cgi?id=1332607 --- Comment #8 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gap-pkg-scscp -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360274] Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
https://bugzilla.redhat.com/show_bug.cgi?id=1360274 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/qt5-qtvirtualkeyboard -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system
https://bugzilla.redhat.com/show_bug.cgi?id=1343063 --- Comment #13 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/artemis -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356594] Review Request: shibboleth-java-support - Java Support for Shibbleth projects
https://bugzilla.redhat.com/show_bug.cgi?id=1356594 --- Comment #10 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/shibboleth-java-support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1359804] Review Request: golang-github-mvo5-goconfigparser - Golang implementation of Python ConfigParser
https://bugzilla.redhat.com/show_bug.cgi?id=1359804 --- Comment #3 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-mvo5-goconfigparser -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1354545] Review Request: rubygem-actioncable - WebSocket framework for Rails
https://bugzilla.redhat.com/show_bug.cgi?id=1354545 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-actioncable -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1359794] Review Request: python-marrow-util - A collection of many commonly re-implemented utility classes and functions
https://bugzilla.redhat.com/show_bug.cgi?id=1359794 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-marrow-util -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360274] Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
https://bugzilla.redhat.com/show_bug.cgi?id=1360274
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter ---
naming: ok
macros: ok
scriptlets: ok
sources: ok
fa473ab9175483dd82aa4d27b9682715 qtvirtualkeyboard-opensource-src-5.7.0.tar.xz
licensing: ok
dependencies: mostly ok
1. SHOULD: I see:
%{?_qt5:Requires: %{_qt5}%{?_isa} = %{_qt5_version}}
but no matching
BuildRequires: qt5-qtbase-private-devel
(which is what we currently use to easily track these hard versioned
dependencies). Please add that
Otherwise, relatively simple package, matches conventions and style of other
existing qt5 packages.
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system
https://bugzilla.redhat.com/show_bug.cgi?id=1343063 --- Comment #12 from gil cattaneo --- Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/6636 https://admin.fedoraproject.org/pkgdb/package/requests/6637 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356594] Review Request: shibboleth-java-support - Java Support for Shibbleth projects
https://bugzilla.redhat.com/show_bug.cgi?id=1356594 --- Comment #9 from gil cattaneo --- Thanks for the review! create new SCM requests: https://admin.fedoraproject.org/pkgdb/package/requests/6634 https://admin.fedoraproject.org/pkgdb/package/requests/6635 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1343063] Review Request: artemis - Java high performance, clustered, asynchronous messaging system
https://bugzilla.redhat.com/show_bug.cgi?id=1343063 Michael Simacek changed: What|Removed |Added Status|NEW |ASSIGNED Flags|fedora-review? |fedora-review+ --- Comment #11 from Michael Simacek --- Looks ok now. APPROVED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 --- Comment #7 from gil cattaneo --- Created attachment 1184267 --> https://bugzilla.redhat.com/attachment.cgi?id=1184267&action=edit licensecheck.txt -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292 gil cattaneo changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1360292] Review Request: multibit-hardware - Common API for hardware wallets in MultiBit HD
https://bugzilla.redhat.com/show_bug.cgi?id=1360292
--- Comment #6 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[!]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "Unknown or generated". 129 files have
unknown license. Detailed output of licensecheck in /home/gil/1360292
-multibit-hardware/licensecheck.txt
Without taking into account the generated files with protobuf,
you should point out to upstream which many of java files have no header
license
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
See Comment#3 and Comment#4
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
Note: Maven packages do not need to (Build)Require jpackage-utils. It
is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven:
[x]: If package contains pom.xml files install it (including metadata) even
when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned
[Bug 1360274] Review Request: qt5-qtvirtualkeyboard - The Qt Virtual Keyboard
https://bugzilla.redhat.com/show_bug.cgi?id=1360274 Rex Dieter changed: What|Removed |Added CC||rdie...@math.unl.edu Blocks||928937 (qt-reviews) Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Flags||fedora-review? --- Comment #1 from Rex Dieter --- I can review today Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1356594] Review Request: shibboleth-java-support - Java Support for Shibbleth projects
https://bugzilla.redhat.com/show_bug.cgi?id=1356594 Michael Simacek changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Flags|fedora-review? |fedora-review+ --- Comment #8 from Michael Simacek --- Looks ok now, APPROVED. Dual licensing means that upstream gives you a choice under which terms you want to use the software. If a package is dual-licensed there is always some notice that explicitly states that you can choose between those licenses. In this package there are files under two different licenses. But you don't have a choice. You must comply with both. Thus it's not dual-licensing. Example of a dual-licensed package is c3p0, take a look at its LICENSE file. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
