[Bug 1364603] Review Request: python-XStatic-Angular-Schema-Form - Angular-Schema-Form JavaScript library packaged for setuptools (easy_install) / pip.
https://bugzilla.redhat.com/show_bug.cgi?id=1364603 --- Comment #7 from Matthias Runge --- xstatic is just a wrapper for static libraries. Thus I'd name the package the wrapped library the same as the library name (or js-angular-schema-form in this case). Idea is, if someone will package up js-angular-schema-form from source, you could just drop the subpackage. python-xstatic-fontawesome-fonts provides just the wrapper, where the font package already provides the pieces we needed, thus the font package was added as dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1291008] Review Request: tipl - Template image processing library
https://bugzilla.redhat.com/show_bug.cgi?id=1291008 --- Comment #3 from Igor Gnatenko --- I will update description during import, any other issues? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1293043] Review Request: python-epac - Machine learning workflow builder
https://bugzilla.redhat.com/show_bug.cgi?id=1293043 Igor Gnatenko changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? ||needinfo?(ilya.gradina@gmai ||l.com) --- Comment #3 from Igor Gnatenko --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1280141] Review Request: python-psychopy - Psychophysics toolkit for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1280141 Igor Gnatenko changed: What|Removed |Added CC||aal...@gmail.com Flags||needinfo?(aal...@gmail.com) --- Comment #3 from Igor Gnatenko --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1280155] Review Request: python-cregg - Utilities for running psychology experiments
https://bugzilla.redhat.com/show_bug.cgi?id=1280155 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|NEW CC|ignate...@redhat.com| Assignee|ignate...@redhat.com|nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1250833] Review Request: helm - Polyphonic software synth with lots of modulation and easy to use UI
https://bugzilla.redhat.com/show_bug.cgi?id=1250833 Igor Gnatenko changed: What|Removed |Added CC|ignate...@redhat.com|j...@therobinsonfamily.net Flags||needinfo?(junk@therobinsonf ||amily.net) --- Comment #12 from Igor Gnatenko --- ping? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1279085] Review Request: maxmind-geoip2 - GeoIP2 webservice and database API
https://bugzilla.redhat.com/show_bug.cgi?id=1279085 --- Comment #11 from Matthias Mailänder --- Note: I updated the OpenRA development build to use the 2.6.0 MaxMind GeoIP version. https://github.com/OpenRA/OpenRA/pull/11285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1270525] Review Request: maxmind-db - Reader for the MaxMind DB Database Format
https://bugzilla.redhat.com/show_bug.cgi?id=1270525 --- Comment #5 from Matthias Mailänder --- Note: I updated OpenRA to use the 2.0.0 MaxMind DB version. https://github.com/OpenRA/OpenRA/pull/11285 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources
https://bugzilla.redhat.com/show_bug.cgi?id=1364194 --- Comment #5 from Eduardo Mayorga --- [mayorga@topo results]$ rpmlint -i pintail-0.3-1gitd669691.fc25.noarch.rpm pintail.noarch: E: explicit-lib-dependency python3-urllib3 You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. Please remove this dependency to continue with the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1302909] Review Request: drupal8 - An open source content management platform
https://bugzilla.redhat.com/show_bug.cgi?id=1302909 --- Comment #16 from Shawn Iwinski --- (In reply to Jared Smith from comment #15) > > I will create a README at the same time I create an RPM README. > > Sounds great. Assuming you add the README before you commit, and given the > fact that everything else looks to be in order, I'm going to go ahead and > approve the package. Thanks again for packaging this. Thanks for the review! I'm going to go ahead and request the pkg in pkgdb and commit the current state into SCM, but I will not build in koji or release in Bodhi until I add the RPM README. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064
--- Comment #12 from Sandro Mani ---
Ah thanks for the clarification. The "Requires: %{name} =
%{version}-%{release}" for the langpacks is needed though, right?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #11 from Kevin Kofler --- As for the difference between Recommends and Suggests, it is that Recommends is a "yes by default" optional dependency, Suggests is a "no by default" optional dependency. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #10 from Kevin Kofler --- The Supplements is a boolean reverse dependency to ensure the langpack will be installed by default if the langpacks-* metapackage is. (It is, however, only allowed for Fedora releases where boolean dependencies are allowed.) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1347897] Review Request: nodejs-convert-source-map - Converts a source-map from/ to different formats
https://bugzilla.redhat.com/show_bug.cgi?id=1347897 Jared Smith changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-08-07 16:01:06 --- Comment #2 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364638] Review Request: nodejs-gulp-sourcemaps - Source map support for Gulp.js
https://bugzilla.redhat.com/show_bug.cgi?id=1364638 Bug 1364638 depends on bug 1347897, which changed state. Bug 1347897 Summary: Review Request: nodejs-convert-source-map - Converts a source-map from/to different formats https://bugzilla.redhat.com/show_bug.cgi?id=1347897 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364230] Review Request: nodejs-loud-rejection - Make unhandled promise rejections fail loudly instead of the default silent fail
https://bugzilla.redhat.com/show_bug.cgi?id=1364230 Bug 1364230 depends on bug 1364229, which changed state. Bug 1364229 Summary: Review Request: nodejs-currently-unhandled - Track the list of currently unhandled promise rejections https://bugzilla.redhat.com/show_bug.cgi?id=1364229 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364229] Review Request: nodejs-currently-unhandled - Track the list of currently unhandled promise rejections
https://bugzilla.redhat.com/show_bug.cgi?id=1364229 Jared Smith changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-08-07 16:00:36 --- Comment #2 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064
--- Comment #9 from Sandro Mani ---
I'm not sure these are correct:
Enhances: %{name} = %{version}-%{release}\
Supplements: (%{name} = %{version}-%{release} and langpacks-%{1})\
Reading the bottom section of [1], I think
Enhances: %{name} = %{version}-%{release}
Requires: %{name} = %{version}-%{release}
would be more correct. Enhances may be used by the package manager to notify
the user about the additional packages, and Requires ensures you don't need to
install the license in each langpack (because it is installed by
lumina-desktop-libs required by lumina-desktop), and that directory ownership
is also correct.
Also, -devel does not need to install the LICENSE separately because it is
already installed by -libs which it requires.
Rest looks good.
[1]
http://www.rpm.org/wiki/PackagerDocs/Dependencies&num=1&hl=en&gl=ch&strip=0&vwsrc=0
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364225] Review Request: nodejs-repeating - Repeat a string - fast
https://bugzilla.redhat.com/show_bug.cgi?id=1364225 Jared Smith changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-08-07 15:52:22 --- Comment #2 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364226] Review Request: nodejs-indent-string - Indent each line in a string
https://bugzilla.redhat.com/show_bug.cgi?id=1364226 Bug 1364226 depends on bug 1364225, which changed state. Bug 1364225 Summary: Review Request: nodejs-repeating - Repeat a string - fast https://bugzilla.redhat.com/show_bug.cgi?id=1364225 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364221] Review Request: nodejs-map-obj - Map object keys and values into a new object
https://bugzilla.redhat.com/show_bug.cgi?id=1364221 --- Comment #3 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364224] Review Request: nodejs-camelcase-keys - Convert object keys to camelCase
https://bugzilla.redhat.com/show_bug.cgi?id=1364224 Bug 1364224 depends on bug 1364221, which changed state. Bug 1364221 Summary: Review Request: nodejs-map-obj - Map object keys and values into a new object https://bugzilla.redhat.com/show_bug.cgi?id=1364221 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364221] Review Request: nodejs-map-obj - Map object keys and values into a new object
https://bugzilla.redhat.com/show_bug.cgi?id=1364221 Jared Smith changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-08-07 15:50:49 --- Comment #2 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364219] Review Request: nodejs-has-gulplog - Check if gulplog is available before attempting to use it
https://bugzilla.redhat.com/show_bug.cgi?id=1364219 Jared Smith changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-08-07 15:48:47 --- Comment #2 from Jared Smith --- In rawhide, closing bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices
https://bugzilla.redhat.com/show_bug.cgi?id=1309794 Raphael Groner changed: What|Removed |Added Status|ASSIGNED|POST Alias|qtscrob | Flags|fedora-review? |fedora-review+ --- Comment #8 from Raphael Groner --- Okay. APPROVED Remove alias to allow general search for bugs. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1309794] Review Request: qtscrob - Qt last.fm submitter for portable music devices
https://bugzilla.redhat.com/show_bug.cgi?id=1309794 --- Comment #7 from Igor Gnatenko --- (In reply to Raphael Groner from comment #6) > About the rpmlint errors: > > > qtscrob.x86_64: E: script-without-shebang > > /usr/share/licenses/qtscrob/COPYING > Remove executable permission. Will fix during import. > > > qtscrob.x86_64: E: wrong-script-end-of-line-encoding > > /usr/share/licenses/qtscrob/COPYING > https://fedoraproject.org/wiki/Common_Rpmlint_issues#wrong-file-end-of-line- > encoding will fix during import > > > qtscrob.x86_64: E: incorrect-fsf-address /usr/share/licenses/qtscrob/COPYING > Please report to upstream. Upstream is dead. Also will fix all other executable issues during import. And add that license stuff at the same time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.
https://bugzilla.redhat.com/show_bug.cgi?id=1364805 --- Comment #1 from Raphael Groner --- > rpmls > RPMS/noarch/hamster-cinnamon-applet-0.2-1.20160728git7fbc81c.fc24.noarch.rpm > |grep LC_MESSAGES -rw-r--r-- /usr/share/locale/cs/LC_MESSAGES/hamster-shell-extension.po.mo -rw-r--r-- /usr/share/locale/de/LC_MESSAGES/hamster-shell-extension.po.mo -rw-r--r-- /usr/share/locale/fr/LC_MESSAGES/hamster-shell-extension.po.mo -rw-r--r-- /usr/share/locale/pl/LC_MESSAGES/hamster-shell-extension.po.mo -rw-r--r-- /usr/share/locale/ru/LC_MESSAGES/hamster-shell-extension.po.mo Bug with basename not working correctly with 'find -exec'. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1344261] Review Request: warsow - Fast paced 3D first person shooter
https://bugzilla.redhat.com/show_bug.cgi?id=1344261 --- Comment #5 from Raphael Groner --- Review swap with bug #1364805? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364704] Review Request: nodejs-linkify-it - Links recognition library with FULL unicode support
https://bugzilla.redhat.com/show_bug.cgi?id=1364704 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364702] Review Request: nodejs-tlds - List of TLDs
https://bugzilla.redhat.com/show_bug.cgi?id=1364702 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364702] Review Request: nodejs-tlds - List of TLDs
https://bugzilla.redhat.com/show_bug.cgi?id=1364702 --- Comment #1 from Jeroen van Meeuwen --- We probably don't want to or should not ship /usr/lib/node_modules/tlds/cron.sh, and perhaps not even bin.js. If we do, I suppose the package needs to ship a .git/ and require git. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364701] Review Request: nodejs-uc-dot-micro - Micro subset of unicode data files for markdown-it projects
https://bugzilla.redhat.com/show_bug.cgi?id=1364701 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364700] Review Request: nodejs-markdown-it-testgen - Tests generator for markdown-it markdown parser
https://bugzilla.redhat.com/show_bug.cgi?id=1364700 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? --- Comment #1 from Jeroen van Meeuwen --- The only problem here is that the %changelog seems to be incomplete (no version, no message). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364699] Review Request: nodejs-linefix - Recursively repair line endings
https://bugzilla.redhat.com/show_bug.cgi?id=1364699
Jeroen van Meeuwen changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Jeroen van Meeuwen ---
It's looking like bin/fix.js is supposed to be made available as
%{_bindir}/linefix (see README.md).
Please note that bin/fix.js has the wrong interpreter as well.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364805] Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.
https://bugzilla.redhat.com/show_bug.cgi?id=1364805 Raphael Groner changed: What|Removed |Added Whiteboard||Trivial -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364805] New: Review Request: hamster-cinnamon-applet - Cinnamon applet for hamster time tracker.
https://bugzilla.redhat.com/show_bug.cgi?id=1364805
Bug ID: 1364805
Summary: Review Request: hamster-cinnamon-applet - Cinnamon
applet for hamster time tracker.
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: projects...@smart.ms
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL:
https://raphgro.fedorapeople.org/review/hamster/cinnamon/hamster-cinnamon-applet.spec
SRPM URL:
https://raphgro.fedorapeople.org/review/hamster/cinnamon/hamster-cinnamon-applet-0.2-1.20160728git7fbc81c.fc24.src.rpm
Description: Cinnamon applet for hamster time tracker.
Fedora Account System Username: raphgro
Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15165970
> rpmlint SPECS/hamster-cinnamon-applet.spec
> SRPMS/hamster-cinnamon-applet-0.2-1.20160728git7fbc81c.fc24.src.rpm
> RPMS/noarch/hamster-cinnamon-applet-0.2-1.20160728git7fbc81c.fc24.noarch.rpm
>
>
hamster-cinnamon-applet.noarch: W: dangling-relative-symlink
/usr/share/cinnamon/applets/hamster-cinnamon-applet/locale ../../../locale
2 packages and 1 specfiles checked; 0 errors, 1 warnings.
=> False positive. All gettext locales get installed into '%{_datadir}/locale'.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 977116] Review Request: pgmodeler - PostgreSQL Database Modeler
https://bugzilla.redhat.com/show_bug.cgi?id=977116 --- Comment #42 from Pavel Alexeev --- Sorry guys for late response. I'm very interesting in this review. Igor thank you very much for taking it on review. Changes: https://github.com/Hubbitus/Fedora-packaging/commit/d0716a3d152c8d085988944bce7140b8e56f2e64 Spec: https://raw.githubusercontent.com/Hubbitus/Fedora-packaging/d0716a3d152c8d085988944bce7140b8e56f2e64/SPECS/pgmodeler.spec Srpm: http://rpm.hubbitus.info/Fedora24/pgmodeler/pgmodeler-0.8.2-1.fc24.src.rpm -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #8 from Raphael Groner --- SPEC: https://raphgro.fedorapeople.org/review/qt/lumina/lumina-desktop.spec SRPM: https://raphgro.fedorapeople.org/review/qt/lumina/lumina-desktop-1.0.0-0.3.Beta4.Tfbab63e.fc24.src.rpm Test builds: https://copr.fedorainfracloud.org/coprs/raphgro/review/package/lumina-desktop/ %changelog * Sun Aug 07 2016 Raphael Groner <> - 1.0.0-0.3.Beta4.Tfbab63e - Beta4 * Sun Aug 07 2016 Raphael Groner <> - 1.0.0-0.2.Beta2.Tfbab63e - avoid dangling-symlink /usr/bin/lte - drop implicit BR: gcc - drop Group tags - compile translations and split into individual langpacks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1353169] Review Request: python-nikola - A static website and blog generator
https://bugzilla.redhat.com/show_bug.cgi?id=1353169 --- Comment #6 from Neal Gompa --- You've still not changed the /usr/bin/nikola link to point to /usr/bin/nikola3. Please do so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1361659] Re-Review Request: vdsm - Virtual Desktop Server Manager
https://bugzilla.redhat.com/show_bug.cgi?id=1361659
--- Comment #5 from Yaniv Bronhaim ---
There was an error because of the "rm -rf %{buildroot}" removal
The following works:
Spec URL: bronhaim.fedorapeople.org/vdsm.spec
SRPM URL: vdsm-4.18.999-380.git4ffbc97.fc23.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364777] Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1364777 Mukundan Ragavan changed: What|Removed |Added Status|NEW |ASSIGNED CC||nonamed...@gmail.com Assignee|nob...@fedoraproject.org|nonamed...@gmail.com Flags||fedora-review? --- Comment #2 from Mukundan Ragavan --- taking for review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364777] Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1364777 Igor Gnatenko changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1069023] Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1069023 Igor Gnatenko changed: What|Removed |Added Resolution|WONTFIX |DUPLICATE --- Comment #13 from Igor Gnatenko --- *** This bug has been marked as a duplicate of bug 1364777 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364777] Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1364777 Igor Gnatenko changed: What|Removed |Added Blocks||201449 (FE-DEADREVIEW), ||1016928 CC||i...@cicku.me --- Comment #1 from Igor Gnatenko --- *** Bug 1069023 has been marked as a duplicate of this bug. *** Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. https://bugzilla.redhat.com/show_bug.cgi?id=1016928 [Bug 1016928] Update it to fife 0.3.5 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364777] Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1364777 Igor Gnatenko changed: What|Removed |Added Blocks||1364745 (FE-GAMESIG) Alias||fifechan Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1364745 [Bug 1364745] Games SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364698] Review Request: nodejs-bundle-dependencies - Generates bundledDependencies package.json value
https://bugzilla.redhat.com/show_bug.cgi?id=1364698 --- Comment #1 from Jeroen van Meeuwen --- nodejs-bundle-dependencies.noarch: E: wrong-script-interpreter /usr/lib/node_modules/bundle-dependencies/dist/bin/index.js /usr/bin/env node nodejs-bundle-dependencies.noarch: E: non-executable-script /usr/lib/node_modules/bundle-dependencies/dist/bin/index.js 644 /usr/bin/env node The documentation in README.md seems to suggest dist/bin/ contents reflect a %_bindir type of command (but then again it also refers to 'npm run bundle-dependencies') -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364698] Review Request: nodejs-bundle-dependencies - Generates bundledDependencies package.json value
https://bugzilla.redhat.com/show_bug.cgi?id=1364698 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364777] New: Review Request: fifechan - C++ GUI library designed for games
https://bugzilla.redhat.com/show_bug.cgi?id=1364777 Bug ID: 1364777 Summary: Review Request: fifechan - C++ GUI library designed for games Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: ignate...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/fifechan.spec SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/fifechan-0.1.2-1.git7b77184.fc26.src.rpm Description: Fifechan is a lightweight cross platform GUI library written in C++ specifically designed for games. It has a small yet powerful built in set of extendable GUI Widgets allowing users to create virtually unlimited types of widgets. Fifechan supports rendering in SDL, OpenGL, or Allegro out of the box or it can be adapted to use any rendering engine the user requires. Events are pushed to Fifechan which allows users to use any input library they wish or they could use the built in input handling through either SDL input or Allegro input. The primary goal for Fifechan is to keep it extendable, lightweight and still be powerful enough to use in all types of games out of the box. Fedora Account System Username: ignatenkobrain -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364697] Review Request: nodejs-leche - A JavaScript testing utility designed to work with Mocha and Sinon
https://bugzilla.redhat.com/show_bug.cgi?id=1364697 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364696] Review Request: nodejs-file-entry-cache - Super simple cache for file metadata
https://bugzilla.redhat.com/show_bug.cgi?id=1364696 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364691] Review Request: nodejs-delete - Delete files and folders and any intermediate directories
https://bugzilla.redhat.com/show_bug.cgi?id=1364691 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364695] Review Request: nodejs-flat-cache - A stupidly simple key/ value storage using files to persist some data
https://bugzilla.redhat.com/show_bug.cgi?id=1364695 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364693] Review Request: nodejs-write - Write files to disk, creating intermediate directories if they don't exist
https://bugzilla.redhat.com/show_bug.cgi?id=1364693 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364689] Review Request: nodejs-has-glob - Returns if an array has a glob pattern
https://bugzilla.redhat.com/show_bug.cgi?id=1364689 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364688] Review Request: nodejs-async-array-reduce - Async reduce
https://bugzilla.redhat.com/show_bug.cgi?id=1364688 --- Comment #1 from Jeroen van Meeuwen --- Please update test.js: https://raw.githubusercontent.com/jonschlinkert/async-array-reduce/master/test.js : CHECKSUM(SHA256) this package : 3ea064039992975b7e618368259b0f7f7ddd7411d927c2ddf147508f2d9c6f67 CHECKSUM(SHA256) upstream package : 6ad626179c39b989f5091cea5c71b8a26ba79e81902adf4bbf57ef3987140d90 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364690] Review Request: nodejs-matched - Adds array support to node-glob, sync and async
https://bugzilla.redhat.com/show_bug.cgi?id=1364690 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364688] Review Request: nodejs-async-array-reduce - Async reduce
https://bugzilla.redhat.com/show_bug.cgi?id=1364688 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364687] Review Request: nodejs-arr-union - Combines a list of arrays , returning a single array with unique values
https://bugzilla.redhat.com/show_bug.cgi?id=1364687 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364683] Review Request: nodejs-ansi-magenta - The color magenta, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1364683 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364685] Review Request: nodejs-lazy-cache - Cache requires to be lazy-loaded when needed
https://bugzilla.redhat.com/show_bug.cgi?id=1364685 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364684] Review Request: nodejs-ansi-cyan - The color cyan, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1364684 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364682] Review Request: nodejs-ansi-yellow - The color yellow, in ansi
https://bugzilla.redhat.com/show_bug.cgi?id=1364682 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364680] Review Request: nodejs-set-getter - Create nested getter properties and any intermediary paths
https://bugzilla.redhat.com/show_bug.cgi?id=1364680 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364681] Review Request: nodejs-object-dot-pick - Returns a filtered copy of an object with only the specified keys
https://bugzilla.redhat.com/show_bug.cgi?id=1364681 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364679] Review Request: nodejs-to-object-path - Create an object path from a list or array of strings
https://bugzilla.redhat.com/show_bug.cgi?id=1364679 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364677] Review Request: nodejs-read-file - Thin wrapper around fs.readFile and fs.readFileSync
https://bugzilla.redhat.com/show_bug.cgi?id=1364677 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364678] Review Request: nodejs-read-json-sync - Read and parse a JSON file synchronously
https://bugzilla.redhat.com/show_bug.cgi?id=1364678 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364676] Review Request: nodejs-try-open - Tries to open a file using fs.openSync, fails gracefully
https://bugzilla.redhat.com/show_bug.cgi?id=1364676 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364675] Review Request: nodejs-npm-license - Check license info for a module
https://bugzilla.redhat.com/show_bug.cgi?id=1364675 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364674] Review Request: nodejs-treeify - Converts a JS object into a nice and readable tree
https://bugzilla.redhat.com/show_bug.cgi?id=1364674 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364673] Review Request: nodejs-package-license - Checks the filesystem for potential license files
https://bugzilla.redhat.com/show_bug.cgi?id=1364673 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364672] Review Request: nodejs-nopt-usage - This module generates a usage string for nopt options
https://bugzilla.redhat.com/show_bug.cgi?id=1364672 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364670] Review Request: nodejs-parse-ms - Parse milliseconds into an object
https://bugzilla.redhat.com/show_bug.cgi?id=1364670 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364671] Review Request: nodejs-pretty-ms - Convert milliseconds to a human readable string: 1337000000 → 15d 11h 23m 20s
https://bugzilla.redhat.com/show_bug.cgi?id=1364671 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364667] Review Request: nodejs-ignore - Ignore is a manager and filter for .gitignore rules
https://bugzilla.redhat.com/show_bug.cgi?id=1364667 Jeroen van Meeuwen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364669] Review Request: nodejs-tap-out - A different tap parser
https://bugzilla.redhat.com/show_bug.cgi?id=1364669 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364650] Review Request: nodejs-global-prefix - Get the npm global path prefix.
https://bugzilla.redhat.com/show_bug.cgi?id=1364650 Jeroen van Meeuwen changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364651] Review Request: nodejs-global-modules - The directory used by npm for globally installed npm modules
https://bugzilla.redhat.com/show_bug.cgi?id=1364651 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364660] Review Request: nodejs-gulp-mocha - Run Mocha tests
https://bugzilla.redhat.com/show_bug.cgi?id=1364660 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364656] Review Request: nodejs-resolve-dir - Resolve a directory
https://bugzilla.redhat.com/show_bug.cgi?id=1364656 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364649] Review Request: nodejs-foreground-child - Run a child as if it's the foreground process
https://bugzilla.redhat.com/show_bug.cgi?id=1364649 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364648] Review Request: nodejs-grunt-svgmin - Minify SVG
https://bugzilla.redhat.com/show_bug.cgi?id=1364648 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364647] Review Request: nodejs-svgmin - Minify SVG files
https://bugzilla.redhat.com/show_bug.cgi?id=1364647
Jared Smith changed:
What|Removed |Added
Blocks||1364648
Jeroen van Meeuwen changed:
What|Removed |Added
Flags||fedora-review?
--- Comment #1 from Jeroen van Meeuwen ---
These need resolving:
nodejs-svgmin.noarch: E: zero-length /usr/lib/node_modules/svgmin/index.js
I do not see the RPM ship any other code? The tarball from npmjs.org seems to
ship an empty index.js indeed.
nodejs-svgmin.src:19: W: macro-in-comment %{version}
nodejs-svgmin.src:42: W: macro-in-comment %setup
Note that 'npm search svgmin' does not return 'svgmin 0.1.0' and npmjs.org
currently does not show the package metadata information because of a failure
to find a readme.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364648
[Bug 1364648] Review Request: nodejs-grunt-svgmin - Minify SVG
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364645] Review Request: nodejs-coa - Command-Option-Argument: Another parser for command line options
https://bugzilla.redhat.com/show_bug.cgi?id=1364645 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364646] Review Request: nodejs-svgo - Nodejs-based tool for optimizing SVG vector graphics files
https://bugzilla.redhat.com/show_bug.cgi?id=1364646 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364645] Review Request: nodejs-coa - Command-Option-Argument: Another parser for command line options
https://bugzilla.redhat.com/show_bug.cgi?id=1364645 --- Comment #1 from Jeroen van Meeuwen --- nodejs-coa.noarch: E: wrong-script-interpreter /usr/lib/node_modules/coa/lib/completion.sh /usr/bin/env bash nodejs-coa.noarch: E: non-executable-script /usr/lib/node_modules/coa/lib/completion.sh 644 /usr/bin/env bash nodejs-coa-1.0.1-1.fc26.noarch.rpm/usr/lib/node_modules/coa/lib/completion.sh is a cmd completion script template for command-line utilities using coa, which could be considered a non-executable artifact. There's not a lot of documentation about it's use in the sources or package itself, though. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364644] Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha
https://bugzilla.redhat.com/show_bug.cgi?id=1364644 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364644] Review Request: nodejs-grunt-simple-mocha - A simple wrapper for running tests with Mocha
https://bugzilla.redhat.com/show_bug.cgi?id=1364644 --- Comment #1 from Jeroen van Meeuwen --- This one does have rpmlint complain about the wrong interpreter as well. You mentioned the use of /usr/bin/node over /usr/bin/env node was not a packaging guideline yet ratified. I take it this may involve https://fedoraproject.org/wiki/Script_Interpreters_(draft), but the main reasons listed there are not my concern. The RPM dependency side-note is a bigger concern. My main concern is the ability to manipulate what is executed by the user (say, env node=~/bin/node and worse). In any case, rpmlint reports it as an error; nodejs-grunt-simple-mocha.noarch: E: wrong-script-interpreter /usr/lib/node_modules/grunt-simple-mocha/bin/grunt-simple-mocha /usr/bin/env node -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364643] Review Request: nodejs-grunt-contrib-jshint - Validate files with JSHint
https://bugzilla.redhat.com/show_bug.cgi?id=1364643 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364641] Review Request: nodejs-flagged-respawn - A tool for respawning node binaries when special flags are present
https://bugzilla.redhat.com/show_bug.cgi?id=1364641 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364640] Review Request: nodejs-rechoir - Require any supported file as a node module
https://bugzilla.redhat.com/show_bug.cgi?id=1364640 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364639] Review Request: nodejs-require-yaml - Lets you load YAML/ YML files using require syntax
https://bugzilla.redhat.com/show_bug.cgi?id=1364639 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364638] Review Request: nodejs-gulp-sourcemaps - Source map support for Gulp.js
https://bugzilla.redhat.com/show_bug.cgi?id=1364638 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364637] Review Request: nodejs-default-resolution - Get the default resolution time based on the current node version
https://bugzilla.redhat.com/show_bug.cgi?id=1364637 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364636] Review Request: nodejs-vali-date - Validate a date
https://bugzilla.redhat.com/show_bug.cgi?id=1364636 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364635] Review Request: nodejs-strip-bom-stream - Strip UTF-8 byte order mark (BOM) from a stream
https://bugzilla.redhat.com/show_bug.cgi?id=1364635 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364632] Review Request: nodejs-merge-stream - Create a stream that emits events from multiple other streams
https://bugzilla.redhat.com/show_bug.cgi?id=1364632 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364634] Review Request: nodejs-first-chunk-stream - Transform the first chunk in a stream
https://bugzilla.redhat.com/show_bug.cgi?id=1364634 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364630] Review Request: nodejs-to-absolute-glob - Make a glob pattern absolute
https://bugzilla.redhat.com/show_bug.cgi?id=1364630 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1364631] Review Request: nodejs-glob-stream - A wrapper around node-glob to make it streamy
https://bugzilla.redhat.com/show_bug.cgi?id=1364631 Jeroen van Meeuwen changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
