[Bug 1368911] Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368911

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||needinfo?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368911] New: Review Request: python-mpd2 - It is a Python library which provides a client interface for MPD

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368911

Bug ID: 1368911
   Summary: Review Request: python-mpd2 - It is a Python library
which provides a client interface for MPD
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@kushaldas.in
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://kushal.fedorapeople.org/packages/python-mpd2.spec
SRPM URL:
https://kushal.fedorapeople.org/packages/python-mpd2-0.5.5-1.fc24.src.rpm
Description: It is a Python library which provides a client interface for MPD
Fedora Account System Username: kushal

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364194] Review Request: pintail - Build web sites from Mallard sources

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364194

Eduardo Mayorga  changed:

   What|Removed |Added

  Flags|needinfo?(e...@mayorgalinux.co |
   |m)  |



--- Comment #8 from Eduardo Mayorga  ---
Release tag should look like 1.MMDDgit%{shortcommit0}%{?dist}. See the note
on post-release packages:
https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Snapshot_packages.

Otherwise, this package looks fine.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
  Flags||fedora-review?



--- Comment #4 from Parag AN(पराग)  ---
(In reply to Igor Gnatenko from comment #2)
> shouldn't name be without perl- prefix?

I don't think so, you can find many perl module packaged examples in Fedora
which uses "perl-" prefix but installs files in %{_bindir}. Also, this package
do contains perl library not just perl scripts.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #3 from Parag AN(पराग)  ---
Suggestions:
 As per current packaging guidelines given on
https://fedoraproject.org/wiki/Packaging:Guidelines

1) use %global instead of %define, See
https://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

2) From README.md and COPYING and few files containing headers, shows this perl
module is in GPLv3+ license so use 
License:GPLv3+

3) If you just look on your system for this file
/etc/rpmdevtools/spectemplate-perl.spec , you will find the most updated spec
file template for perl packaging.
According to that you should include following as your package is noarch type

BuildRequires:  perl
BuildRequires:  perl-generators

4) Your %build should be (as this is noarch package)
%build
%{__perl} Makefile.PL INSTALLDIRS=vendor
make %{?_smp_mflags}

5) In %install, following is now optional and should be removed
rm -rf %{buildroot}

as per https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

6) I see rpmlint on binary rpm shows permissions issue, its good to use same
lines from spec template for %install as

%install
make pure_install DESTDIR=%{buildroot}
find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} ';'
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'
%{_fixperms} $RPM_BUILD_ROOT/*

7) usage of mv should be avoided and instead that use "install

8) The %files section should look like
%files
%{!?_licensedir:%global license %%doc}
%license COPYING
%doc README.md
%{perl_vendorlib}/*
%{_mandir}/man1/*.1*
%{_bindir}/pft
%{_libexecdir}/%{name}/pft-clean
%{_libexecdir}/%{name}/pft-edit
%{_libexecdir}/%{name}/pft-grab
%{_libexecdir}/%{name}/pft-init
%{_libexecdir}/%{name}/pft-ls
%{_libexecdir}/%{name}/pft-make
%{_libexecdir}/%{name}/pft-pub
%{_libexecdir}/%{name}/pft-show

9) Another thing, the %prep can also be used here as
%prep
%autosetup -n %{module}-%{version} -p1

I wonder you being the upstream developer, why not applied yet patchbase0 in
upstream code and released any new tarball?


Fix above issues and increase the release tag and add appropriate changelog
information and provide updated SPEC and SRPM links again for further update of
this package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368611] Review Request: typetype-molot-fonts - Display sans-serif fonts

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368611



--- Comment #10 from Luya Tshimbalanga  ---
Here is the latest updated files with change on source packaged fonts and the
license to SIL OFL

Spec URL:
https://luya.fedorapeople.org/packages/SPECS/typetype-molot-fonts.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/typetype-molot-fonts-1.000-4.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366840] Review Request: openhft-java-compiler - OpenHFT Java Runtime Compiler library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366840

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366840] Review Request: openhft-java-compiler - OpenHFT Java Runtime Compiler library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366840



--- Comment #2 from gil cattaneo  ---
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7353
https://admin.fedoraproject.org/pkgdb/package/requests/7354

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366355] Review Request: acme-tiny - Tiny auditable ACME script for Let's Encrypt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366355



--- Comment #12 from Stuart D Gathman  ---
Works!  https://nyc.gathman.org/  (note signed by letsencrypt.org)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249543

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 972352] Review Request: jsendnsca - Java API for sending passive checks to the Nagios NSCA add-on

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972352

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249543



--- Comment #6 from gil cattaneo  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)

> All good. Should add depenedency on eclipse-filesystem.
 Done
> Package is APPROVED.

Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7351
https://admin.fedoraproject.org/pkgdb/package/requests/7352

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 972352] Review Request: jsendnsca - Java API for sending passive checks to the Nagios NSCA add-on

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972352



--- Comment #9 from gil cattaneo  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #8)
> BuildRequires: hostname,
> then you can remove the "-Dmaven.test.failure.ignore=true". It builds fine.

 Done

> Looks all good, except for the two small issues noted at the top. Package is
> APPROVED.

Spec URL: http://gil.fedorapeople.org/jsendnsca.spec
SRPM URL: http://gil.fedorapeople.org/jsendnsca-2.1.1-1.fc24.src.rpm

Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7349
https://admin.fedoraproject.org/pkgdb/package/requests/7350

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249543

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to gil cattaneo from comment #4)
> Thanks for your help!
:)

> if for you is the same, i would have more interest, for now,
> to try to review the dependencies listed here:
> https://bugzilla.redhat.com/show_bug.cgi?id=1363923
Oh, man. I've had enough for today I think, but I'll try to find some time.
Don't know when though, I'll be travelling for the next few weeks.



This is a review *template*. Besides handling the [ ]-marked tests you are
also supposed to fix the template before pasting into bugzilla:
- Add issues you find to the list of issues on top. If there isn't such
  a list, create one.
- Add your own remarks to the template checks.
- Add new lines marked [!] or [?] when you discover new things not
  listed by fedora-review.
- Change or remove any text in the template which is plain wrong. In this
  case you could also file a bug against fedora-review
- Remove the "[ ] Manual check required", you will not have any such lines
  in what you paste.
- Remove attachments which you deem not really useful (the rpmlint
  ones are mandatory, though)
- Remove this text


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
EPL.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "BSD (3 clause)", "EPL-1.0", "Unknown or generated". 12 files
 have unknown license. Detailed output of licensecheck in
 /var/tmp/1249543-eclipse-paho-mqtt-java/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/eclipse/droplets,
 /usr/share/eclipse
→ add Requires: eclipse-filesystem

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
The name is a bit crazy, but it matches upstream ;)

[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or 

[Bug 1366840] Review Request: openhft-java-compiler - OpenHFT Java Runtime Compiler library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366840

Luya Tshimbalanga  changed:

   What|Removed |Added

 Status|NEW |POST



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366840] Review Request: openhft-java-compiler - OpenHFT Java Runtime Compiler library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366840

Luya Tshimbalanga  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Luya Tshimbalanga  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated". 2 files have unknown
 license. Detailed output of licensecheck in /home/luya/Documents
 /fedora-packaging/review/1366840-openhft-java-
 compiler/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
 Note: Noarch tag is used
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[-]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from 

[Bug 1363923] Review Request: springframework4 - Spring Java Application Framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363923

gil cattaneo  changed:

   What|Removed |Added

 Blocks||968136




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=968136
[Bug 968136] Review Request: camel - Apache Camel integration framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 968136] Review Request: camel - Apache Camel integration framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=968136

gil cattaneo  changed:

   What|Removed |Added

 Depends On||1363923




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1363923
[Bug 1363923] Review Request: springframework4 - Spring Java Application
Framework
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366197] Review Request: aries-quiesce-manager - Apache Aries Quiesce Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366197

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366197] Review Request: aries-quiesce-manager - Apache Aries Quiesce Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366197



--- Comment #3 from gil cattaneo  ---

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/7343
https://admin.fedoraproject.org/pkgdb/package/requests/7344

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 972352] Review Request: jsendnsca - Java API for sending passive checks to the Nagios NSCA add-on

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=972352

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
BuildRequires: hostname,
then you can remove the "-Dmaven.test.failure.ignore=true". It builds fine.

%description should be wrapped to 80 columns.


Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
ASL 2.0.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 5 files
 have unknown license. Detailed output of licensecheck in
 /var/tmp/972352-jsendnsca/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
(see note at the top)

[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on 

[Bug 1366197] Review Request: aries-quiesce-manager - Apache Aries Quiesce Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366197



--- Comment #2 from gil cattaneo  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #1)

> Looks good.
> You might want to wrap %description to 80 columns.
> I didn't test the functionality, but it'll get tested in #1166655 anyway.
> 
> One issue: Obsoletes should use a fixed version, e.g. Obsoletes:
> aries-quiesce < 1.0. Only Provides should use %version. See
> https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.
> 2FReplacing_Existing_Packages.
 Done! ... hope ...
> Package is APPROVED.

Thanks for the review!

Spec URL: https://gil.fedorapeople.org/aries-quiesce-manager.spec
SRPM URL:
https://gil.fedorapeople.org/aries-quiesce-manager-1.0.0-1.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249543



--- Comment #4 from gil cattaneo  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> Build in rawhide fails with
> [ERROR] Plugin org.apache.maven.plugins:maven-antrun-plugin:1.7 or one of
> its dependencies could not be resolved: Cannot access central
> (https://repo.maven.apache.org/maven2) in offline mode and the artifact
> org.apache.maven.plugins:maven-antrun-plugin:jar:1.7 has not been downloaded
> from it before. -> [Help 1]
> 
> maven-antrun-plugin is now at version 1.8, pom.xml needs to be patched.
> It builds fine in F24 mock, it seems only F25+ is a problem.
> 
> Looks good, but please fix the build ;)

Spec URL: https://gil.fedorapeople.org/eclipse-paho-mqtt-java.spec
SRPM URL:
https://gil.fedorapeople.org/eclipse-paho-mqtt-java-1.0.2-1.fc24.src.rpm

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15329436

Thanks for your help!
if for you is the same, i would have more interest, for now,
to try to review the dependencies listed here:
https://bugzilla.redhat.com/show_bug.cgi?id=1363923

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #17 from gvalkov  ---
Doh. Fixed the python-setuptools bit.

Spec URL:
https://raw.githubusercontent.com/gvalkov/python-evdev/eff6213cf782ad6552a98716516cc0b9c082bedc/packaging/python-evdev.spec
SRPM URL:
https://gvalkov.fedorapeople.org/python-evdev/python-evdev-0.6.1-1.fc24.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15329370

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 656483] Review Request: mod_remoteip - Apache Module mod_remoteip

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=656483



--- Comment #19 from p...@posteo.de ---
We have switched to RHEL 7 which includes httpd 2.4 and mod_remoteip, so I vote
for closing this issue.

-- 
You are receiving this mail because:
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366355] Review Request: acme-tiny - Tiny auditable ACME script for Let's Encrypt

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366355



--- Comment #11 from Stuart D Gathman  ---
Spec URL: http://gathman.org/linux/SPECS/acme-tiny.spec
SRPM URL:
http://gathman.org/linux/el6/src/acme-tiny-0.1-8.git5a7b4e7.fc23.src.rpm

It is still out for testing on my local repo - going to do an end-to-end (do
the whole process of registering the cert and running the check script from
cron) on an f23 server.  Only tested end-to-end on el6 so far.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1249543] Review Request: eclipse-paho-mqtt-java - MQTT client library written in Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1249543

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
Build in rawhide fails with
[ERROR] Plugin org.apache.maven.plugins:maven-antrun-plugin:1.7 or one of its
dependencies could not be resolved: Cannot access central
(https://repo.maven.apache.org/maven2) in offline mode and the artifact
org.apache.maven.plugins:maven-antrun-plugin:jar:1.7 has not been downloaded
from it before. -> [Help 1]

maven-antrun-plugin is now at version 1.8, pom.xml needs to be patched.
It builds fine in F24 mock, it seems only F25+ is a problem.

Looks good, but please fix the build ;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1366197] Review Request: aries-quiesce-manager - Apache Aries Quiesce Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366197

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
ASL 2.0.

[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 3 files
 have unknown license. Detailed output of licensecheck in
 /var/tmp/1366197-aries-quiesce-manager/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file 

[Bug 1368855] Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Michal Ambroz  changed:

   What|Removed |Added

 Blocks||563471 (FE-SECLAB)
  Alias||radare2




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=563471
[Bug 563471] Tracker: Review Requests for Fedora Security Lab related
packages
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368855] New: Review Request: radare2 - The reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368855

Bug ID: 1368855
   Summary: Review Request: radare2 - The reverse engineering
framework
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: re...@seznam.cz
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



SPEC URL: https://rebus.fedorapeople.org/SPECS/radare2.spec
SRPM URL: https://rebus.fedorapeople.org/SRPMS/radare2-0.10.5-1.fc23.src.rpm

The radare2 is a reverse-engineering framework that is multi-architecture,
multi-platform, and highly scriptable.  It provides a hexadecimal
editor, wrapped I/O, file system support, debugger support, diffing
between two functions or binaries, and code analysis at opcode,
basic block, and function levels.

Fedora Account System Username: rebus

Link to the Koji scratch build -
http://koji.fedoraproject.org/koji/taskinfo?taskID=15328663

Link to COPR build:
https://copr.fedorainfracloud.org/coprs/rebus/infosec-rebus/build/443316/

Available also from my COPR repository:
dnf copr enable rebus/infosec-rebus
dnf install radare2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #21 from Luya Tshimbalanga  ---
Thank you Zbigniew and Igor. I have learned a lot more than a simple review.
Next package is ispc.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367699] Review Request: python-sphinx_py3doc_enhanced_theme - Theme based on the theme of https:/ /docs.python.org/3/

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367699

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
We have a bunch of theme packages using a common naming scheme:
python2-sphinx-theme-alabaster.noarch 0.7.8-1.fc24 
  @System
python3-sphinx-theme-alabaster.noarch 0.7.8-1.fc24 
  @System
python3-sphinx-theme-better.noarch0.1.5-8.fc24 
  fedora 
python3-sphinx-theme-flask.noarch git20130715.1cc4468-7.fc24   
  fedora 

Also, dashes are preferred
[https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuidelines#Separators].
So I think the package should be called python-sphinx-theme-py3doc-enhanced or
so.

The usual suggestion: define %global _description \
blah blah ... \
blah blah

and then use it as %description %_description, %description -n python3-foobar
%_description, %description -n python2-foobar %_description.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368157] Review Request: python-pika-pool - Pools for pikas ( rename of python-pika_pool)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368157

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Please change Summary to something meaningful.

Define %global _description \
blah blah ... \
blah blah

and then use it as %description %_description, %description -n
python3-pika-pool %_description, %description -n python2-pika-pool
%_description.

The version in Obsoletes is supposed to be fixed, e.g. < 0.1.3-5, see
https://fedoraproject.org/wiki/Packaging:Guidelines#Renaming.2FReplacing_Existing_Packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368850] Review Request: rubygem-rouge - Simple, easy-to-extend drop-in replacement for pygments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368850

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-rouge



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368848] Review Request: rubygem-mercenary - An easier way to build your command-line scripts in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368848

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-mercenary



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368847] Review Request: rubygem-jekyll-watch - Rebuild your Jekyll site when a file changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368847

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-jekyll-watch



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368846] Review Request: rubygem-jekyll-sass-converter - Basic Sass converter for Jekyll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368846

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-jekyll-sass-convert
   ||er



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368845] Review Request: rubygem-forwardable-extended - Forwardable with hash, and instance variable extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368845

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-forwardable-extende
   ||d



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368844] Review Request: rubygem-colorator - Colorize your text in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368844

Björn "besser82" Esser  changed:

   What|Removed |Added

  Alias||rubygem-colorator



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby implementation of Pathname with extra bits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368849

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368850] Review Request: rubygem-rouge - Simple, easy-to-extend drop-in replacement for pygments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368850

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368844] Review Request: rubygem-colorator - Colorize your text in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368844

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby implementation of Pathname with extra bits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368849

Björn "besser82" Esser  changed:

   What|Removed |Added

 Depends On||1368845
  Alias||rubygem-pathutil




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368845
[Bug 1368845] Review Request: rubygem-forwardable-extended - Forwardable
with hash, and instance variable extensions
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368848] Review Request: rubygem-mercenary - An easier way to build your command-line scripts in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368848

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368847] Review Request: rubygem-jekyll-watch - Rebuild your Jekyll site when a file changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368847

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368846] Review Request: rubygem-jekyll-sass-converter - Basic Sass converter for Jekyll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368846

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368851 (rubygem-jekyll)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368851
[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text
into static websites and blogs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368845] Review Request: rubygem-forwardable-extended - Forwardable with hash, and instance variable extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368845

Björn "besser82" Esser  changed:

   What|Removed |Added

 Blocks||1368849 (rubygem-pathutil)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368849
[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby
implementation of Pathname with extra bits
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368851] Review Request: rubygem-jekyll - Transform your plain text into static websites and blogs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368851

Björn "besser82" Esser  changed:

   What|Removed |Added

 Depends On||1368844, 1368846, 1368847,
   ||1368848, 1368849
   ||(rubygem-pathutil), 1368850
  Alias||rubygem-jekyll




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1368844
[Bug 1368844] Review Request: rubygem-colorator - Colorize your text in the
terminal
https://bugzilla.redhat.com/show_bug.cgi?id=1368846
[Bug 1368846] Review Request: rubygem-jekyll-sass-converter - Basic Sass
converter for Jekyll
https://bugzilla.redhat.com/show_bug.cgi?id=1368847
[Bug 1368847] Review Request: rubygem-jekyll-watch - Rebuild your Jekyll
site when a file changes
https://bugzilla.redhat.com/show_bug.cgi?id=1368848
[Bug 1368848] Review Request: rubygem-mercenary - An easier way to build
your command-line scripts in Ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1368849
[Bug 1368849] Review Request: rubygem-pathutil - Faster pure Ruby
implementation of Pathname with extra bits
https://bugzilla.redhat.com/show_bug.cgi?id=1368850
[Bug 1368850] Review Request: rubygem-rouge - Simple, easy-to-extend
drop-in replacement for pygments
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368847] New: Review Request: rubygem-jekyll-watch - Rebuild your Jekyll site when a file changes

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368847

Bug ID: 1368847
   Summary: Review Request: rubygem-jekyll-watch - Rebuild your
Jekyll site when a file changes
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Rebuild your Jekyll site when a file changes with the `--watch` switch!


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327874


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll-watch.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll-watch-1.5.0-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368845] New: Review Request: rubygem-forwardable-extended - Forwardable with hash, and instance variable extensions

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368845

Bug ID: 1368845
   Summary: Review Request: rubygem-forwardable-extended -
Forwardable with hash, and instance variable
extensions
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Extends forwardable with delegation to hashes and instance variables.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327865


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-forwardable-extended.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-forwardable-extended-2.6.0-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368848] New: Review Request: rubygem-mercenary - An easier way to build your command-line scripts in Ruby

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368848

Bug ID: 1368848
   Summary: Review Request: rubygem-mercenary - An easier way to
build your command-line scripts in Ruby
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Lightweight and flexible library for writing command-line apps in Ruby.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327877


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-mercenary.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-mercenary-0.3.6-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368849] New: Review Request: rubygem-pathutil - Faster pure Ruby implementation of Pathname with extra bits

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368849

Bug ID: 1368849
   Summary: Review Request: rubygem-pathutil - Faster pure Ruby
implementation of Pathname with extra bits
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Pathutil tries to be a faster pure Ruby implementation of Pathname.
  It arose out of a need to fix basic problems with Pathname, such as
  susceptibility to join overrides, need for automatic encoding, and
  normalization (for stuff like Jekyll) and the ability to do other
  safe-style operations in an encapsulated format, like copying files
  and folders with symbolic links but only if they originate from the
  given root.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327880


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-pathutil.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-pathutil-0.14.0-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368850] New: Review Request: rubygem-rouge - Simple, easy-to-extend drop-in replacement for pygments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368850

Bug ID: 1368850
   Summary: Review Request: rubygem-rouge - Simple, easy-to-extend
drop-in replacement for pygments
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Rouge is a pure-ruby syntax highlighter.  It can highlight 100
  different languages, and output HTML or ANSI 256-color text.
  Its HTML output is compatible with style-sheets designed for pygments.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327884


Issues:

  W: spelling-error … pygments -> pigments, segments
  ---> false positive


FAS-User:

  besser82


Urls:

  Spec URL:  https://besser82.fedorapeople.org/review/jekyll/rubygem-rouge.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-rouge-1.11.1-0.1.fc26.src.rpm


Additional information:

  This is not the latest version of rubygem-rouge, because rubygem-jekyll
  requires rubygem-rouge < 2.  This will be updated with the next release
  of rubygem-jackyll.


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368846] New: Review Request: rubygem-jekyll-sass-converter - Basic Sass converter for Jekyll

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368846

Bug ID: 1368846
   Summary: Review Request: rubygem-jekyll-sass-converter - Basic
Sass converter for Jekyll
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Let Jekyll build your Sass and SCSS!


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327871


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll-sass-converter.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll-sass-converter-1.4.0-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368851] New: Review Request: rubygem-jekyll - Transform your plain text into static websites and blogs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368851

Bug ID: 1368851
   Summary: Review Request: rubygem-jekyll - Transform your plain
text into static websites and blogs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Jekyll is a simple, blog-aware, static site generator perfect
  for personal, project, or organization sites.  Think of it like
  a file-based CMS, without all the complexity.  Jekyll takes your
  content, renders Markdown and Liquid templates, and spits out a
  complete, static website ready to be served by Apache, Nginx or
  another web server.  Jekyll is the engine behind GitHub Pages,
  which you can use to host sites right from your GitHub repositories.
  Jekyll does what you tell it to do — no more, no less.  It doesn't
  try to outsmart users by making bold assumptions, nor does it
  burden them with needless complexity and configuration.  Put simply,
  Jekyll gets out of your way and allows you to concentrate on what
  truly matters: your content.


Koji Build:

  no build, because of unmet BuildRequires, currently under review


Issues:

  E: version-control-internal-file …/jekyll-3.2.1/lib/site_template/.gitignore
  ---> .gitignore file is used when creating new sites from the template


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-jekyll-3.2.1-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368844] New: Review Request: rubygem-colorator - Colorize your text in the terminal

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368844

Bug ID: 1368844
   Summary: Review Request: rubygem-colorator - Colorize your text
in the terminal
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: fed...@besser82.io
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Description:

  Colorize your text in the terminal.  There are a bunch of gems that
  provide functionality like this, but none have as simple an API as
  this.  Just call "string".color and your text will be colorized.


Koji Build:

  http://koji.fedoraproject.org/koji/taskinfo?taskID=15327862


Issues:

  no issues reported from rpmlint


FAS-User:

  besser82


Urls:

  Spec URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-colorator.spec
  SRPM URL: 
https://besser82.fedorapeople.org/review/jekyll/rubygem-colorator-1.1.0-0.1.fc26.src.rpm


Thanks for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270622] Review Request: sdb - The string database from radare reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270622

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
(MIT)
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 197 files have
 unknown license. Detailed output of licensecheck in
 /var/tmp/1270622-sdb/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/share/vala/vapi,
 /usr/share/vala
OK.

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Scriptlets must be sane, if used.
(see below)

[-]: Description and summary sections in the package spec file contains
 translations for 

[Bug 1365782] python-django-model-utils - Django model mixins and utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1365782

Fabio Alessandro Locati  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Fabio Alessandro Locati  ---
APPROVED

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1270622] Review Request: sdb - The string database from radare reverse engineering framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270622



--- Comment #2 from Michal Ambroz  ---
Hello Zbyszek,
Thanks for review - I am sorry I missed that one. Actually the package
(radare2) for which I would like to have sdb library still doesn't support to
use the sdb as system library so I forgot to check the review.

Here is updated package:
Spec URL: https://rebus.fedorapeople.org/SPECS/sdb.spec
SRPM URL:
https://rebus.fedorapeople.org/SRPMS/sdb-0.10.5-1.bf6575a.fc23.src.rpm


Thank you 
Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
Package looks OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #20 from Zbigniew Jędrzejewski-Szmek  ---
In %files, change %{_libexecdir}/%{name}/* to %{_libexecdir}/%{name}/,
otherwise the directory is going to be unowned.

I don't think the tests do anything:
+ ctest -V -j12
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
UpdateCTestConfiguration  from
:/builddir/build/BUILD/embree-2.10.0/DartConfiguration.tcl
Test project /builddir/build/BUILD/embree-2.10.0
Constructing a list of tests
Checking test dependency graph...
Checking test dependency graph end
No tests were found!!!
+ exit 0

You can run benchmark as a test instead.

+ package name is OKt
+ license is acceptable (ASL 2.0)
+ license is specified correctly 
+ latest version
+ builds and install OK
+ provides/requires/BR look OK
+ rpmlint is happy
+ scriptlets look OK

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #15 from Igor Gnatenko  ---
> BuildRequires:  python-setuptools
BuildRequires: python2-setuptools

;)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #19 from Luya Tshimbalanga  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> You don't need to delete an empty dir from the installation root, rpm will
> just ignore it.

Good to know.

> Something is wrong with the way CXXFLAGS are set (right after pushd). Before
> it before %cmake and that was working better.

Do you mean CXXFLAGS before %cmake?

> %files is still busted. See #c14 for the right form :)
> rpmlint goes all crazy:
> embree-devel.x86_64: E: non-devel-file-in-devel-package
> /usr/lib64/libembree.so.2.10.0
> embree-devel.x86_64: E: library-without-ldconfig-postin
> /usr/lib64/libembree.so.2.10.0
> embree-devel.x86_64: E: library-without-ldconfig-postun
> /usr/lib64/libembree.so.2.10.0
Fixed. 

> You cannot install the examples into /usr/bin. The names are too generic:
> e.g. /usr/bin/convert is a well-known imagemagick executable. You can use
> %_libdir/embree/examples instead.
%{_libexecdir}/embree is used instead.


> - rpmlint is not happy (see above and below)
> 
> rpmlint:
> embree.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1)
Weird. rpmlint n my side did not complain about that line. Either way, it is
fixed.


Here is the updated files:
Spec URL: https://luya.fedorapeople.org/packages/SPECS/embree.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/embree-2.10.0-6.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #14 from gvalkov  ---
Thanks you for the review, Zbigniew. Those were all very valid points, which I
hope to have addressed in the latest version of the spec:

Spec URL:
https://raw.githubusercontent.com/gvalkov/python-evdev/436a967967a862481d7e34c5d243a67351d84500/packaging/python-evdev.spec
SRPM URL:
https://gvalkov.fedorapeople.org/python-evdev/python-evdev-0.6.1-1.fc24.src.rpm
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15326372

This is the diff:
https://github.com/gvalkov/python-evdev/commit/436a967967a862481d7e34c5d243a67351d84500

> rpmlint python-evdev.spec 
> 0 packages and 1 specfiles checked; 0 errors, 0 warnings.

> rpmlint python3-evdev-0.6.1-1.fc24.x86_64.rpm
> python3-evdev.x86_64: W: spelling-error %description -l en_US userspace -> 
> user space, user-space, users pace
> python3-evdev.x86_64: W: spelling-error %description -l en_US dev -> deb, 
> derv, div
> python3-evdev.x86_64: W: spelling-error %description -l en_US uinput -> 
> input, u input, Putin
> python3-evdev.x86_64: W: spelling-error %description -l en_US Uinput -> 
> Input, U input, Putin
> python3-evdev.x86_64: E: wrong-script-interpreter 
> /usr/lib64/python3.5/site-packages/evdev/genecodes.py /usr/bin/env python
> python3-evdev.x86_64: E: non-executable-script 
> /usr/lib64/python3.5/site-packages/evdev/genecodes.py 644 /usr/bin/env python
> python3-evdev.x86_64: E: wrong-script-interpreter 
> /usr/lib64/python3.5/site-packages/evdev/evtest.py /usr/bin/env python
> python3-evdev.x86_64: E: non-executable-script 
> /usr/lib64/python3.5/site-packages/evdev/evtest.py 644 /usr/bin/env python
> 1 packages and 0 specfiles checked; 4 errors, 4 warnings.

Imho, these don't matter, as genecodes and evtest aren't execv-ed as scripts
(anymore). I simply forgot to remove the shebang when I made them into
executable modules (i.e. python -m evdev.evtest). I'll fix this upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #2 from Igor Gnatenko  ---
shouldn't name be without perl- prefix?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #18 from Zbigniew Jędrzejewski-Szmek  ---
Either may be used.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #17 from Igor Gnatenko  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #16)
> You cannot install the examples into /usr/bin. The names are too generic:
> e.g. /usr/bin/convert is a well-known imagemagick executable. You can use
> %_libdir/embree/examples instead.
not %{_libexecdir}/%{name}/ ?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457

Christos Triantafyllidis  changed:

   What|Removed |Added

 Whiteboard|NotReady|



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457

Christos Triantafyllidis  changed:

   What|Removed |Added

 CC||projects...@smart.ms
  Flags||needinfo?(projects.rg@smart
   ||.ms)



--- Comment #6 from Christos Triantafyllidis 
 ---
Hello,

Can you please update the spec/build so that it will use the updated iniparser?

Cheers,
Christos

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #16 from Zbigniew Jędrzejewski-Szmek  ---
You don't need to delete an empty dir from the installation root, rpm will just
ignore it.

Something is wrong with the way CXXFLAGS are set (right after pushd). Before it
before %cmake and that was working better.

%files is still busted. See #c14 for the right form :)
rpmlint goes all crazy:
embree-devel.x86_64: E: non-devel-file-in-devel-package
/usr/lib64/libembree.so.2.10.0
embree-devel.x86_64: E: library-without-ldconfig-postin
/usr/lib64/libembree.so.2.10.0
embree-devel.x86_64: E: library-without-ldconfig-postun
/usr/lib64/libembree.so.2.10.0

You cannot install the examples into /usr/bin. The names are too generic: e.g.
/usr/bin/convert is a well-known imagemagick executable. You can use
%_libdir/embree/examples instead.

+ package name is OK
+ license is acceptable (ASL 2.0)
+ license is specified correctly 
+ latest version
+ builds and install OK
+ provides/requires/BR look OK
- rpmlint is not happy (see above and below)

rpmlint:
embree.src:54: W: mixed-use-of-spaces-and-tabs (spaces: line 54, tab: line 1)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1307271] Review Request: vswm - Very Simple Wireless Manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1307271

Giovanni  changed:

   What|Removed |Added

 CC||da...@openmailbox.org



--- Comment #3 from Giovanni  ---
At current date, spec and srpm cannot be retrieved.

Trying to retrieve spec:
> Error 1. Msg: Failed requesting URL 
> https://api.github.com/repos/23/vswm.spec/contents/

Trying to retrieve src.rpm:
> Error 1. Msg: Failed requesting URL 
> https://api.github.com/repos/23/vswm-0.2-0.fc22.src.rpm/contents/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1346457] Review Request: cava - Console-based Audio Visualizer for Alsa

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346457
Bug 1346457 depends on bug 1346451, which changed state.

Bug 1346451 Summary: iniparser-4.0 is available
https://bugzilla.redhat.com/show_bug.cgi?id=1346451

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1264042] Review Request: source-to-image - A tool for building artifacts from source and injecting into docker images

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1264042

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |NEXTRELEASE
Last Closed||2016-08-21 08:54:13



--- Comment #12 from Parag AN(पराग)  ---
I see this is already built.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790

Parag AN(पराग)  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790



--- Comment #1 from Giovanni  ---
Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=15324923

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1367569] Review Request: perl-PFT - Hacker friendly static blog generator, core library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1367569



--- Comment #4 from Giovanni  ---
(In reply to Parag AN(पराग) from comment #3)
> Yes please submit another package and assign to me.

Done. Thank you very much for your help!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790

Giovanni  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|panem...@gmail.com



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1368790] New: Review Request: perl-App-PFT - Hacker friendly static blog generator, command line utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1368790

Bug ID: 1368790
   Summary: Review Request: perl-App-PFT - Hacker friendly static
blog generator, command line utilities
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: da...@openmailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/dacav/pft/perl-App-PFT.git/plain/perl-App-PFT.spec

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/dacav/pft/fedora-rawhide-x86_64/00441358-perl-App-PFT/perl-App-PFT-1.0.5-2.fc26.src.rpm

Description:

PFT stands for *Plain F. Text*, where the meaning of *F.* is up to
personal interpretation. Like *Fancy* or *Fantastic*.

It is yet another static website generator. This means your content is
compiled once and the result can be served by a simple HTTP server,
without need of server-side dynamic content generation.

This package provides the command line utilities. It depends on another
package: perl-PFT, which is also submitted (see
https://bugzilla.redhat.com/show_bug.cgi?id=1367569 )

Fedora Account System Username: dacav at openmailbox org

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1257410] Review Request: abcMIDI - ABC to/ from MIDI conversion utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1257410

Jens Lody  changed:

   What|Removed |Added

 CC|fed...@jenslody.de  |
   Assignee|fed...@jenslody.de  |nob...@fedoraproject.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org

[Bug 1364618] Review Request: embree - Collection of high-performance ray tracing kernels developed at Intel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1364618



--- Comment #15 from Luya Tshimbalanga  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #14)
> This still doesn't build for me. I needed the following "patch":
> 
> sed -r -i.bak 's/#include /#include /' common/math/constants.h
> sed -r -i.bak '/__forceinline float (abs|floor|ceil)/d' common/math/math.h
> 
> I think it's also good to silence all warnings: -Wno-all in CXXFLAGS.
> Otherwise there's just too much noise.

Using those lines greatly reduce the building time. They fixed the failure as
well.

> 
> %files seems totally broken:
> - .so file must be in -devel
> - .so.* must be in the main package
> - %{_bindir}/%{name}/* doesn't match anything
> [...]
Thanks for the correction. Fixed.


> What about the examples that are now built? Shouldn't they be run in %check,
> and packaged into -examples subpackage?
-examples subpackage added now running in %check following the cmake guideline.

Here is the updated files:
Spec URL: https://luya.fedorapeople.org/packages/SPECS/embree.spec
SRPM URL:
https://luya.fedorapeople.org/packages/SRPMS/embree-2.10.0-5.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org