[Bug 1373782] New: Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C
https://bugzilla.redhat.com/show_bug.cgi?id=1373782 Bug ID: 1373782 Summary: Review Request: mingw-cmocka - MinGW Lightweight library to simplify and generalize unit tests for C Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: nmavr...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://people.redhat.com/nmavrogi/fedora/mingw-cmocka.spec SRPM URL: http://people.redhat.com/nmavrogi/fedora/mingw-cmocka-1.0.1-1.fc24.src.rpm Description: Lightweight library to simplify and generalize unit tests for C. This library is cross-compiled for MinGW. Fedora Account System Username: nmav -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes
https://bugzilla.redhat.com/show_bug.cgi?id=1362490 --- Comment #22 from Remi Collet --- Again, if you need 'mysql' extension, as this have been removed from PHP, you cannot package this (in Fedora) So you have to drop AphrontMySQLDatabaseConnection from the package (and perhaps ensure app will not try to use it) As AphrontMySQLiDatabaseConnection use mysqli extension, you have to requires php-mysqli. Again, you must require all used extensions, and never package name. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370913] Review Request: artemis-wildfly-integration - ActiveMQ Artemis WildFly Integration
https://bugzilla.redhat.com/show_bug.cgi?id=1370913 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #5 from Fedora Update System --- artemis-wildfly-integration-1.0.2-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d538f50dfb -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243 Fedora Update System changed: What|Removed |Added Status|MODIFIED|ON_QA --- Comment #7 from Fedora Update System --- perl-Test-Filename-0.03-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c075fd371d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373666] New: Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature
https://bugzilla.redhat.com/show_bug.cgi?id=1373666 Bug ID: 1373666 Summary: Review Request: hddfancontrol - Control system fan speed by monitoring hard drive temperature Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: rosser@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://tc01.fedorapeople.org/python/hddfancontrol/hddfancontrol.spec SRPM URL: https://tc01.fedorapeople.org/python/hddfancontrol/hddfancontrol-1.2.4-1.fc24.src.rpm Description: HDD Fan control is a command line tool to dynamically control fan speed according to hard drive temperature on Linux. Fedora Account System Username: tc01 rpmlint output and notes: $ rpmlint ../SRPMS/hddfancontrol-1.2.4-1.fc24.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. $ rpmlint ../RPMS/noarch/hddfancontrol-1.2.4-1.fc24.noarch.rpm hddfancontrol.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/hddfancontrol/__init__.py /usr/bin/env python3 hddfancontrol.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/hddfancontrol/__init__.py 644 /usr/bin/env python3 hddfancontrol.noarch: E: wrong-script-interpreter /usr/lib/python3.5/site-packages/hddfancontrol/__main__.py /usr/bin/env python3 hddfancontrol.noarch: E: non-executable-script /usr/lib/python3.5/site-packages/hddfancontrol/__main__.py 644 /usr/bin/env python3 hddfancontrol.noarch: W: no-manual-page-for-binary hddfancontrol-3.5 hddfancontrol.noarch: W: no-manual-page-for-binary hddfancontrol-3 hddfancontrol.noarch: W: no-manual-page-for-binary hddfancontrol 1 packages and 0 specfiles checked; 4 errors, 3 warnings. These errors are because hddfancontrol is written in Python 3 and thus uses /usr/bin/env python3 directly. I think they are ignorable. Note that hddfancontrol is *not* a library (though it is available on PyPI), and thus it is *not* named python-hddfancontrol. It is a program that happens to be written in Python 3. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 gil cattaneo changed: What|Removed |Added Blocks|652183 (FE-JAVASIG) | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=652183 [Bug 652183] Java SIG tracker bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic
https://bugzilla.redhat.com/show_bug.cgi?id=1366028 --- Comment #9 from Fedora Update System --- python-flask-migrate-2.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1368626] Review Request: python-whichcraft - Cross-python shutil.which functionality
https://bugzilla.redhat.com/show_bug.cgi?id=1368626 --- Comment #9 from Fedora Update System --- python-whichcraft-0.4.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370469] Review Request: python-dict-sorted - Dictionaries sorted by key or by comparison function
https://bugzilla.redhat.com/show_bug.cgi?id=1370469 --- Comment #10 from Fedora Update System --- python-dict-sorted-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372064] Review Request: lulzbot-marlin-firmware - Marlin firmware files for the Lulzbot family of 3D printers
https://bugzilla.redhat.com/show_bug.cgi?id=1372064 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/lulzbot-marlin-firmware -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373612] Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373612 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-Masterminds-vcs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373551] Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373551 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/golang-github-Masterminds-semver -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373623] Review Request: glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 --- Comment #4 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/glide -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1346249] Review Request: resultsdb - Results store for automated tasks
https://bugzilla.redhat.com/show_bug.cgi?id=1346249 --- Comment #7 from Tim Flink --- (In reply to Jiri Kulda from comment #6) > Ok thanks for explanation. Due to this I'm putting ack for this package. Assuming that I'm interpreting your comment correctly as a pass on this package review, could you set fedora-review to '+' so that the remaining processes can be kicked off? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373641] Review Request: setBfree - A DSP Tonewheel Organ emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1373641 Guido Aulisi changed: What|Removed |Added Blocks||177841 (FE-NEEDSPONSOR) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373641] New: Review Request: setBfree - A DSP Tonewheel Organ emulator
https://bugzilla.redhat.com/show_bug.cgi?id=1373641 Bug ID: 1373641 Summary: Review Request: setBfree - A DSP Tonewheel Organ emulator Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nob...@fedoraproject.org Reporter: guido.aul...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: http://www.sentolavita.com/pkgs/setBfree.spec SRPM URL: http://www.sentolavita.com/pkgs/setBfree-0.8.2-1.fc24.src.rpm Description: setBfree is a MIDI-controlled, software synthesizer designed to imitate the sound and properties of the electromechanical organs and sound modification devices that brought world-wide fame to the names and products of Laurens Hammond and Don Leslie. Fedora Account System Username: tartina Link to successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15520971 This is my first package, I need a sponsor. Thanks. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1169926] Review Request: zram - Enable compressed swap in memory
https://bugzilla.redhat.com/show_bug.cgi?id=1169926 Juan Orti changed: What|Removed |Added CC||j.orti.alca...@gmail.com --- Comment #2 from Juan Orti --- *** Bug 1179835 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1179835] Review Request: fedorazram - zram compresses swap partitions into RAM for performance
https://bugzilla.redhat.com/show_bug.cgi?id=1179835 Juan Orti changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |DUPLICATE Last Closed||2016-09-06 16:36:25 --- Comment #6 from Juan Orti --- *** This bug has been marked as a duplicate of bug 1169926 *** -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372064] Review Request: lulzbot-marlin-firmware - Marlin firmware files for the Lulzbot family of 3D printers
https://bugzilla.redhat.com/show_bug.cgi?id=1372064 Miro Hrončok changed: What|Removed |Added Flags|fedora-review? |fedora-review+ --- Comment #4 from Miro Hrončok --- APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1169926] Review Request: zram - Enable compressed swap in memory
https://bugzilla.redhat.com/show_bug.cgi?id=1169926 --- Comment #1 from Pavel Alexeev --- Update to f66237001b6a413d1e80710526a00fe26214797b Changes: https://github.com/Hubbitus/rpm-zram/commit/dbdc37ca17ca4aca39c55c1a006271123b87022a Spec: https://raw.githubusercontent.com/Hubbitus/rpm-zram/dbdc37ca17ca4aca39c55c1a006271123b87022a/zram.spec Srpm: http://rpm.hubbitus.info/Fedora24/zram/zram-1.0.0-3.git.f662370.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370919] Review Request: python-pycryptodome - Self-contained Python package of low-level cryptographic primitives
https://bugzilla.redhat.com/show_bug.cgi?id=1370919 Tom "spot" Callaway changed: What|Removed |Added CC||tcall...@redhat.com Blocks|182235 (FE-Legal) | --- Comment #2 from Tom "spot" Callaway --- You can have OCB. Lifting FE-Legal. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=182235 [Bug 182235] Fedora Legal Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372064] Review Request: lulzbot-marlin-firmware - Marlin firmware files for the Lulzbot family of 3D printers
https://bugzilla.redhat.com/show_bug.cgi?id=1372064 --- Comment #3 from Tom "spot" Callaway --- All items fixed, patch sent upstream. New SRPM: https://spot.fedorapeople.org/lulzbot-marlin-firmware-20.03-2.fc24.src.rpm New SPEC: https://spot.fedorapeople.org/lulzbot-marlin-firmware.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1179835] Review Request: fedorazram - zram compresses swap partitions into RAM for performance
https://bugzilla.redhat.com/show_bug.cgi?id=1179835 Pavel Alexeev changed: What|Removed |Added CC||pa...@hubbitus.info --- Comment #5 from Pavel Alexeev --- I post on review it long time ago: https://bugzilla.redhat.com/show_bug.cgi?id=1169926 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 517416] Review Request: awl - Andrew' s Web Libraries - PHP Utility Libraries
https://bugzilla.redhat.com/show_bug.cgi?id=517416 Benoît Marcelin changed: What|Removed |Added CC|serein...@online.fr | Flags|needinfo?(sereinity@online. | |fr) | -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1113310] Review Request: python-libnacl - Python ctypes wrapper for libsodium
https://bugzilla.redhat.com/show_bug.cgi?id=1113310 Erik Johnson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2016-09-06 15:29:10 --- Comment #33 from Erik Johnson --- This is no longer a priority to get packaged, I will close it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1113328] Review Request: python-ioflo - Flow Based Programming Automated Reasoning Engine
https://bugzilla.redhat.com/show_bug.cgi?id=1113328 Erik Johnson changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |NOTABUG Last Closed||2016-09-06 15:28:44 --- Comment #19 from Erik Johnson --- This is no longer a priority to get packaged, I will close it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373218] Review Request: zstd - Zstd compression library
https://bugzilla.redhat.com/show_bug.cgi?id=1373218 --- Comment #1 from Pádraig Brady --- koji build http://koji.fedoraproject.org/koji/taskinfo?taskID=15520262 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #7 from Fedora Update System --- picketlink-bindings-2.7.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-89e8cd17d9 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373623] Review Request: glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 Jan Chaloupka changed: What|Removed |Added Summary|Review Request: |Review Request: glide - |golang-github-Masterminds-g |Package Management for |lide - Package Management |Golang |for Golang | --- Comment #3 from Jan Chaloupka --- Just renaming the package to glide so it is aligned with the command. Spec URL: https://jchaloup.fedorapeople.org/reviews/glide/glide.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/glide/glide-0.12.1-0.1.git8032c28.fc20.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373623] Review Request: golang-github-Masterminds-glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #2 from Lokesh Mandvekar --- - specfile conforms to current golang packaging draft - license correct and valid - only sources installed approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373612] Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373612 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #1 from Lokesh Mandvekar --- - specfile conforms to current golang packaging draft - license correct and valid - only sources installed approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373551] Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373551 Lokesh Mandvekar changed: What|Removed |Added Status|NEW |ASSIGNED CC||l...@redhat.com Assignee|nob...@fedoraproject.org|l...@redhat.com Flags||fedora-review+ --- Comment #1 from Lokesh Mandvekar --- - specfile conforms to current golang packaging draft - license correct and valid - only sources installed approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373450] Review Request: esptool - A utility to communicate with the ROM bootloader in Espressif ESP8266
https://bugzilla.redhat.com/show_bug.cgi?id=1373450 --- Comment #2 from Fedora Update System --- esptool-1.1-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-52bf9ef1c1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373450] Review Request: esptool - A utility to communicate with the ROM bootloader in Espressif ESP8266
https://bugzilla.redhat.com/show_bug.cgi?id=1373450 --- Comment #4 from Fedora Update System --- esptool-1.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-89da263f7a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373450] Review Request: esptool - A utility to communicate with the ROM bootloader in Espressif ESP8266
https://bugzilla.redhat.com/show_bug.cgi?id=1373450 --- Comment #3 from Fedora Update System --- esptool-1.1-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c1c555ac38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes
https://bugzilla.redhat.com/show_bug.cgi?id=1362490 --- Comment #21 from Tim Flink --- Remi - if 'php-mysql' and 'php-mysqlnd' are both incorrect dependencies, what is the correct one? From poking around a bit, the pyp-mysqlnd package provides 'php-mysql' and I'm not seeing any other obvious candidates to fulfill the need for a mysql interface -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373450] Review Request: esptool - A utility to communicate with the ROM bootloader in Espressif ESP8266
https://bugzilla.redhat.com/show_bug.cgi?id=1373450 Fedora Update System changed: What|Removed |Added Status|NEW |MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373623] Review Request: golang-github-Masterminds-glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 Jan Chaloupka changed: What|Removed |Added Depends On||1373551, 1373612 --- Comment #1 from Jan Chaloupka --- There is no Koji build as the package depends on other two which are under review (bz#1373551, bz#1373612). Locally, it builds fine. Testing the glide command locally, vendor directory is created and populated based on content of glide.yaml file. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1373551 [Bug 1373551] Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go https://bugzilla.redhat.com/show_bug.cgi?id=1373612 [Bug 1373612] Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373551] Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373551 Jan Chaloupka changed: What|Removed |Added Blocks||1373623 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1373623 [Bug 1373623] Review Request: golang-github-Masterminds-glide - Package Management for Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373612] Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373612 Jan Chaloupka changed: What|Removed |Added Blocks||1373623 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1373623 [Bug 1373623] Review Request: golang-github-Masterminds-glide - Package Management for Golang -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator
https://bugzilla.redhat.com/show_bug.cgi?id=1362487 --- Comment #9 from Tim Flink --- I don't see the requires on /usr/bin/php in the specfile, though -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373623] New: Review Request: golang-github-Masterminds-glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 Bug ID: 1373623 Summary: Review Request: golang-github-Masterminds-glide - Package Management for Golang Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-glide/golang-github-Masterminds-glide.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-glide/golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.src.rpm Description: Package Management for Golang Fedora Account System Username: jchaloup $ rpmlint golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.src.rpm golang-github-Masterminds-glide-0.12.1-0.1.git8032c28.fc20.x86_64.rpm golang-github-Masterminds-glide-devel-0.12.1-0.1.git8032c28.fc20.noarch.rpm golang-github-Masterminds-glide-unit-test-devel-0.12.1-0.1.git8032c28.fc20.x86_64.rpm golang-github-Masterminds-glide-debuginfo-0.12.1-0.1.git8032c28.fc20.x86_64.rpm golang-github-Masterminds-glide.x86_64: W: incoherent-version-in-changelog 0-0.1.git8032c28 ['0.12.1-0.1.git8032c28.fc20', '0.12.1-0.1.git8032c28'] golang-github-Masterminds-glide.x86_64: W: no-manual-page-for-binary glide golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/c/foo.empty golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/a/glide.yaml golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/glide.yaml golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/a/b/c/placeholder.empty golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/b/foo.empty golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/y/z/placeholder.empty golang-github-Masterminds-glide-unit-test-devel.x86_64: W: dangling-relative-symlink /usr/share/gocode/src/github.com/Masterminds/glide/testdata/path/x/vendor symlinked_vendor golang-github-Masterminds-glide-unit-test-devel.x86_64: E: zero-length /usr/share/gocode/src/github.com/Masterminds/glide/testdata/nv/a/foo.empty golang-github-Masterminds-glide-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package golang-github-Masterminds-glide. 5 packages and 0 specfiles checked; 8 errors, 3 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #6 from gil cattaneo --- thanks for the review! I'm waiting to get administrator permissions ... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370128] Review Request: mingw-mediawriter - Fedora Media Writer for Windows
https://bugzilla.redhat.com/show_bug.cgi?id=1370128 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-06 14:23:12 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1368623] Review Request: python-hamcrest - Hamcrest matchers for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1368623 --- Comment #7 from Fedora Update System --- python-hamcrest-1.8.5-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1368623] Review Request: python-hamcrest - Hamcrest matchers for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1368623 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-06 14:23:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1057909] Review Request: mingw-qt5-qtquickcontrols - Qt5 for Windows - QtQuickControls component
https://bugzilla.redhat.com/show_bug.cgi?id=1057909 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-06 14:22:56 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1057909] Review Request: mingw-qt5-qtquickcontrols - Qt5 for Windows - QtQuickControls component
https://bugzilla.redhat.com/show_bug.cgi?id=1057909 --- Comment #11 from Fedora Update System --- mingw-qt5-qtquickcontrols-5.6.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370473] Review Request: python-fauxquests - Mock HTTP requests sent with the requests package
https://bugzilla.redhat.com/show_bug.cgi?id=1370473 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-06 14:23:20 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370239] Review Request: python-ansible-tower-cli - A CLI tool for Ansible Tower
https://bugzilla.redhat.com/show_bug.cgi?id=1370239 Bug 1370239 depends on bug 1370473, which changed state. Bug 1370473 Summary: Review Request: python-fauxquests - Mock HTTP requests sent with the requests package https://bugzilla.redhat.com/show_bug.cgi?id=1370473 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370128] Review Request: mingw-mediawriter - Fedora Media Writer for Windows
https://bugzilla.redhat.com/show_bug.cgi?id=1370128 --- Comment #6 from Fedora Update System --- mingw-mediawriter-0-1.1git19b13a8.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370473] Review Request: python-fauxquests - Mock HTTP requests sent with the requests package
https://bugzilla.redhat.com/show_bug.cgi?id=1370473 --- Comment #9 from Fedora Update System --- python-fauxquests-1.1-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366843] Review Request: openhft-chronicle-queue - Java library for persisted low latency messaging
https://bugzilla.redhat.com/show_bug.cgi?id=1366843 Bug 1366843 depends on bug 1366839, which changed state. Bug 1366839 Summary: Review Request: openhft-affinity - Java Thread Affinity library https://bugzilla.redhat.com/show_bug.cgi?id=1366839 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366839] Review Request: openhft-affinity - Java Thread Affinity library
https://bugzilla.redhat.com/show_bug.cgi?id=1366839 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-06 14:21:54 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1366839] Review Request: openhft-affinity - Java Thread Affinity library
https://bugzilla.redhat.com/show_bug.cgi?id=1366839 --- Comment #11 from Fedora Update System --- openhft-affinity-3.0.6-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/picketlink-bindings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373612] New: Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373612 Bug ID: 1373612 Summary: Review Request: golang-github-Masterminds-vcs - VCS Repo management through a common interface in Go Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-vcs/golang-github-Masterminds-vcs.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-vcs/golang-github-Masterminds-vcs-1.8.0-0.1.gitfbe9fb6.fc20.src.rpm Description: VCS Repo management through a common interface in Go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15519216 $ rpmlint golang-github-Masterminds-vcs-1.8.0-0.1.gitfbe9fb6.fc20.src.rpm golang-github-Masterminds-vcs-devel-1.8.0-0.1.gitfbe9fb6.fc20.noarch.rpm golang-github-Masterminds-vcs-unit-test-devel-1.8.0-0.1.gitfbe9fb6.fc20.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 Michal Karm Babacek changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #4 from gil cattaneo --- see https://kojipkgs.fedoraproject.org//work/tasks/1217/15501217/build.log -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 Michal Karm Babacek changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #2 from Michal Karm Babacek --- @Gil, /usr/share/java/picketlink-bindings/picketlink-wildfly8.jar What is it for in Wildfly 10+ focused build? Are the maven profiles correct? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #3 from gil cattaneo --- (In reply to Michal Karm Babacek from comment #2) > @Gil, > > /usr/share/java/picketlink-bindings/picketlink-wildfly8.jar > > What is it for in Wildfly 10+ focused build? > Are the maven profiles correct? Yes, is only a bundle of system libraries and is used by: "WildFly: PicketLink Subsystem". Now contains only the picketlink-wildfly-common.jar classes -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 --- Comment #1 from gil cattaneo --- - fix license field -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373450] Review Request: esptool - A utility to communicate with the ROM bootloader in Espressif ESP8266
https://bugzilla.redhat.com/show_bug.cgi?id=1373450
Lumír Balhar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #1 from Lumír Balhar ---
Everything looks good to me. Built and tested in mock.
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15518396
Package approved
Rest of review:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later)", "Unknown or generated". 5 files have
unknown license. Detailed output of licensecheck in
/home/lbalhar/Review/1373450-esptool/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 30720 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]:
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 Michal Karm Babacek changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372825] Review Request: picketlink-bindings - PicketLink Container Bindings
https://bugzilla.redhat.com/show_bug.cgi?id=1372825 Michal Karm Babacek changed: What|Removed |Added CC||mbaba...@redhat.com Assignee|nob...@fedoraproject.org|mbaba...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372345] Review Request: python-piexif - Pure Python library to simplify exif manipulations with python
https://bugzilla.redhat.com/show_bug.cgi?id=1372345 --- Comment #4 from José Matos --- Take 2. :-) Now that upstream released a new version with the tests on. Spec URL: https://jamatos.fedorapeople.org/python-piexif.spec SRPM URL: https://jamatos.fedorapeople.org/python-piexif-1.0.7-1.fc25.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1288737] Review Request: openmeeg - Low-frequency bio-electromagnetism solving forward problems in the field of EEG and MEG
https://bugzilla.redhat.com/show_bug.cgi?id=1288737 Igor Gnatenko changed: What|Removed |Added Blocks|201449 (FE-DEADREVIEW) | Whiteboard|AwaitingSubmitter | --- Comment #8 from Igor Gnatenko --- I didn't see notification. I will adress FTBFS ASAP. Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357110] Review Request: foma - Xerox-compatible finite-state compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1357110 Igor Gnatenko changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2016-09-06 12:13:28 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252471] Review Request: wclang - MinGW wrapper for clang and clang++
https://bugzilla.redhat.com/show_bug.cgi?id=1252471 Igor Gnatenko changed: What|Removed |Added Status|NEW |CLOSED Resolution|--- |WONTFIX Last Closed||2016-09-06 12:13:38 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1288737] Review Request: openmeeg - Low-frequency bio-electromagnetism solving forward problems in the field of EEG and MEG
https://bugzilla.redhat.com/show_bug.cgi?id=1288737 Antonio Trande changed: What|Removed |Added Status|ASSIGNED|NEW Blocks||201449 (FE-DEADREVIEW) Assignee|anto.tra...@gmail.com |nob...@fedoraproject.org Whiteboard||AwaitingSubmitter Flags|fedora-review? | |needinfo?(ignatenko@redhat. | |com)| Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1252471] Review Request: wclang - MinGW wrapper for clang and clang++
https://bugzilla.redhat.com/show_bug.cgi?id=1252471 Antonio Trande changed: What|Removed |Added Status|ASSIGNED|NEW Blocks||201449 (FE-DEADREVIEW) Assignee|anto.tra...@gmail.com |nob...@fedoraproject.org Whiteboard||AwaitingSubmitter Flags|fedora-review? | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1357110] Review Request: foma - Xerox-compatible finite-state compiler
https://bugzilla.redhat.com/show_bug.cgi?id=1357110 Antonio Trande changed: What|Removed |Added Status|ASSIGNED|NEW Blocks||201449 (FE-DEADREVIEW) Assignee|anto.tra...@gmail.com |nob...@fedoraproject.org Whiteboard||AwaitingSubmitter Flags|fedora-review? | Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=201449 [Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter response should be blocking this bug. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370611] Review Request: python-serpy - Ridiculously fast object serialization
https://bugzilla.redhat.com/show_bug.cgi?id=1370611 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-serpy -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373551] New: Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go
https://bugzilla.redhat.com/show_bug.cgi?id=1373551 Bug ID: 1373551 Summary: Review Request: golang-github-Masterminds-semver - Work with Semantic Versions in Go Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: jchal...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-semver/golang-github-Masterminds-semver.spec SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-Masterminds-semver/golang-github-Masterminds-semver-1.1.1-0.1.git8d04313.fc20.src.rpm Description: Work with Semantic Versions in Go Fedora Account System Username: jchaloup Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=15517464 $ rpmlint golang-github-Masterminds-semver-1.1.1-0.1.git8d04313.fc20.src.rpm golang-github-Masterminds-semver-devel-1.1.1-0.1.git8d04313.fc20.noarch.rpm golang-github-Masterminds-semver-unit-test-devel-1.1.1-0.1.git8d04313.fc20.x86_64.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1 - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870 Neil Horman changed: What|Removed |Added Flags||needinfo?(dennis.dalessandr ||o...@intel.com) --- Comment #39 from Neil Horman --- good, so you can import the package, build it and close this bug -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1373155
--- Comment #3 from Jan Pazdziora ---
Thank you for the review. New versions of .spec and .src.rpm were put to
Spec URL: https://adelton.fedorapeople.org/perl-Test-Toolbox.spec
SRPM URL: https://adelton.fedorapeople.org/perl-Test-Toolbox-0.4-1.fc24.src.rpm
The .spec diff against the first take is
--- perl-Test-Toolbox.spec.take12016-09-05 13:23:09.668485126 +0200
+++ perl-Test-Toolbox.spec2016-09-06 16:45:46.474393197 +0200
@@ -8,17 +8,20 @@
Source0:
http://www.cpan.org/modules/by-module/Test/Test-Toolbox-%{version}.tar.gz
BuildArch: noarch
+BuildRequires: coreutils
BuildRequires: findutils
BuildRequires: make
BuildRequires: perl
BuildRequires: perl(base)
BuildRequires: perl(Carp)
+BuildRequires: perl(Exporter)
BuildRequires: perl(ExtUtils::MakeMaker)
BuildRequires: perl(strict)
BuildRequires: perl(Test::Builder::Module)
BuildRequires: perl(Cwd)
BuildRequires: perl-generators
+Requires: perl(File::Basename)
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
%description
@@ -36,7 +39,7 @@
make %{?_smp_mflags}
%install
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+make pure_install DESTDIR=%{buildroot}
find $RPM_BUILD_ROOT -type f -name .packlist -delete
@@ -52,5 +55,5 @@
%{_mandir}/man3/*
%changelog
-* Mon Sep 05 2016 Jitka Plesnikova - 0.4-1
+* Mon Sep 05 2016 Jan Pazdziora - 0.4-1
- 1370828 dependency - Initial .spec for 0.4.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library
https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #28 from Jason Taylor --- Thanks Ralf, I will take this back to upstream and see what we can do. I will hold off on importing until the cmake items are sorted out one way or another. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1373155 --- Comment #2 from Jitka Plesnikova --- Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed FIX: Please add following build-requires - coreutils - perl-Test-Toolbox.spec:32 - perl(Exporter) - Test-Toolbox-0.4/lib/Test/Toolbox.pm:108 $ rpm -qp --requires perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c 1 perl(:MODULE_COMPAT_5.24.0) 1 perl(Carp) 1 perl(Cwd) 1 perl(Exporter) 1 perl(Test::Builder::Module) 1 perl(base) 1 perl(strict) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 FIX: Please add missing run-require perl(File::Basename) it is used in Test-Toolbox-0.4/lib/Test/Toolbox.pm:176 $ rpm -qp --provides perl-Test-Toolbox-0.4-1.fc26.noarch.rpm | sort | uniq -c 1 perl(Test::Toolbox) = 0.4 1 perl-Test-Toolbox = 0.4-1.fc26 Binary provides are Ok. $ rpmlint ./perl-Test-Toolbox* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR. FIX: Please replace my name by your name in changelog. Please correct all 'FIX' issues and consider fixing 'TODO' items and provide new spec file. Package is not approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372866] Review Request: hyperscan - Hyperscan is a high-performance multiple regex matching library
https://bugzilla.redhat.com/show_bug.cgi?id=1372866 --- Comment #27 from Ralf Corsepius --- (In reply to Ralf Corsepius from comment #25) > The origin of this mess the toplevel CMakeList.txt, which is entirely broken. Jason asked me off-list to elaborate this In lines 179-244, this CMakeList.txt implements a scheme which manipulates and overrides CFLAGS/CXXFLAGS to values which are incompatible to Fedora (== this package is being miscompiled). This alone qualifies this package as non-eligible for Fedora, unless this issue can be worked around. Besides this, the working principle of this cmake section lacks generality and lacks portability (As you found out when building for the arm). To allow for users to specify their desired *CLAGS, most cmake-packages are equipped the a cmake define which lets users specify "his *FLAGS" (Often "build type"). Unfortunately, this package doesn't seem fall into this category. I.e. it's likely necessary to patch CMakeList.txt to move the harmful parts out. (In reply to Jon Ciesla from comment #26) > Package request has been approved: > https://admin.fedoraproject.org/pkgdb/package/rpms/hyperscan Sigh - I like should have reset the cvs-flags :-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243 --- Comment #6 from Fedora Update System --- perl-Test-Filename-0.03-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c075fd371d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1 - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870 --- Comment #38 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libhfi1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1 - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870
--- Comment #37 from dennis.dalessan...@intel.com ---
(In reply to Neil Horman from comment #28)
> It looks like at some point in your update you removed the _smp_mflags macro:
>
> [!]: Uses parallel make %{?_smp_mflags} macro.
>
> Its not a huge deal, I can let that slide, but please fix it when you check
> it in.
>
In comment 12 it said this was a typo. So I just removed it and things seemed
to work OK.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1149176] Review Request: vdsm-jsonrpc-java - jsonrpc communication lib for ovirt
https://bugzilla.redhat.com/show_bug.cgi?id=1149176 --- Comment #14 from Michael Simacek --- I only see the comment saying that you updated it, but not the updated specfile. I'd like to note that while Fedora and RHEL based products use RPM specfiles, their usage and guidelines can differ a lot. I've examined the old specfile linked in the original description and there are many problems. I'd strongly suggest creating a new specfile from scratch using current guidelines and documentation, as that will actually be less work for both you and the reviewer. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373155] Review Request: perl-Test-Toolbox - Tools for testing
https://bugzilla.redhat.com/show_bug.cgi?id=1373155 Jitka Plesnikova changed: What|Removed |Added Status|NEW |ASSIGNED CC||jples...@redhat.com Assignee|nob...@fedoraproject.org|jples...@redhat.com Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370735] Review Request: python-sampledata - Sample Data generator for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1370735 Martin Bříza changed: What|Removed |Added Flags|fedora-review? |fedora-review- -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370735] Review Request: python-sampledata - Sample Data generator for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1370735 --- Comment #1 from Martin Bříza --- sampledata/helper.py: interpreter is /usr/bin/env python Other than that, nice clean specfile, builds alright, installs too. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1315870] Review Request: libhfi1 - verbs userspace driver for Intel HFIs
https://bugzilla.redhat.com/show_bug.cgi?id=1315870 dennis.dalessan...@intel.com changed: What|Removed |Added Summary|Review Request: |Review Request: libhfi1 - |libhfi1verbs - verbs|verbs userspace driver for |userspace driver for Intel |Intel HFIs |HFIs| Flags|needinfo?(dennis.dalessandr | |o...@intel.com)| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370792] Review Request: python-premailer - Turns CSS blocks into style attributes
https://bugzilla.redhat.com/show_bug.cgi?id=1370792 --- Comment #1 from Martin Bříza --- I'd wait on this if there's no hurry. Hopefully upstream reconsiders tagging their releases properly... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370792] Review Request: python-premailer - Turns CSS blocks into style attributes
https://bugzilla.redhat.com/show_bug.cgi?id=1370792 Martin Bříza changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370735] Review Request: python-sampledata - Sample Data generator for Python
https://bugzilla.redhat.com/show_bug.cgi?id=1370735 Martin Bříza changed: What|Removed |Added Status|NEW |ASSIGNED Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370611] Review Request: python-serpy - Ridiculously fast object serialization
https://bugzilla.redhat.com/show_bug.cgi?id=1370611 Martin Bříza changed: What|Removed |Added Status|NEW |POST Flags|fedora-review? |fedora-review+ --- Comment #1 from Martin Bříza --- Spec looks clean Builds fine Installs fine No objections from my side. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Test-Filename -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1202064] Review Request: knock - A port-knocking server/client
https://bugzilla.redhat.com/show_bug.cgi?id=1202064 --- Comment #21 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/knock -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1372881] Review Request: nodejs-stream-shift - Returns the next buffer/object in a stream' s readable queue
https://bugzilla.redhat.com/show_bug.cgi?id=1372881 Parag Nemade changed: What|Removed |Added Blocks||956806 (nodejs-reviews) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243 --- Comment #4 from Sandro Mani --- Many thanks! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373243] Review Request: perl-Test-Filename - Portable filename comparison
https://bugzilla.redhat.com/show_bug.cgi?id=1373243
Petr Pisar changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar ---
Spec file changes:
--- perl-Test-Filename.spec.old 2016-09-05 16:36:19.0 +0200
+++ perl-Test-Filename.spec 2016-09-06 09:59:51.0 +0200
@@ -1,6 +1,6 @@
Name: perl-Test-Filename
Version:0.03
-Release:1%{?dist}
+Release:2%{?dist}
Summary:Portable filename comparison
License:ASL 2.0
@@ -9,13 +9,16 @@
BuildArch: noarch
BuildRequires: make
+BuildRequires: findutils
BuildRequires: perl
BuildRequires: perl-generators
BuildRequires: perl(English)
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
+BuildRequires: perl(File::Find)
BuildRequires: perl(File::Spec::Functions)
BuildRequires: perl(File::Temp)
BuildRequires: perl(Path::Tiny)
+BuildRequires: perl(strict)
BuildRequires: perl(Test::Builder::Module)
BuildRequires: perl(Test::More)
BuildRequires: perl(Test::Tester)
@@ -48,12 +51,17 @@
%files
-%doc Changes README
+%doc Changes README Todo examples
%license LICENSE
%{perl_vendorlib}/*
%{_mandir}/man3/Test::Filename*.*
%changelog
+* Tue Sep 06 2016 Sandro Mani - 0.03-2
+- BR: findutils, perl(File::Find), perl(strict)
+- BR: perl(ExtUtils::MakeMaker) >= 6.30
+- Add to %%doc: Todo, examples
+
* Mon Sep 05 2016 Sandro Mani - 0.03-1
- Initial package
> TODO: Package `Todo' file and `examples' directory as documentation.
-%doc Changes README
+%doc Changes README Todo examples
Ok.
> TODO: Constrain `perl(ExtUtils::MakeMaker)' dependency with `>= 6.30'
> (Makefile.PL:7).
-BuildRequires: perl(ExtUtils::MakeMaker)
+BuildRequires: perl(ExtUtils::MakeMaker) >= 6.30
Ok.
> FIX: Build-require `findutils' (perl-Test-Filename.spec:43).
+BuildRequires: findutils
Ok.
> FIX: Build-require `perl(strict)' (Makefile.PL:2).
+BuildRequires: perl(strict)
Ok.
> FIX: Build-require `perl(File::Find)' (t/00-compile.t:10).
+BuildRequires: perl(File::Find)
Ok.
$ rpmlint perl-Test-Filename.spec
../SRPMS/perl-Test-Filename-0.03-2.fc26.src.rpm
../RPMS/noarch/perl-Test-Filename-0.03-2.fc26.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
Package builds in F26
(http://koji.fedoraproject.org/koji/taskinfo?taskID=15515888). Ok.
Package is good.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list
package-review@lists.fedoraproject.org
https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1370611] Review Request: python-serpy - Ridiculously fast object serialization
https://bugzilla.redhat.com/show_bug.cgi?id=1370611 Martin Bříza changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
[Bug 1373487] New: Review Request: python33 - Version 3.3 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1373487 Bug ID: 1373487 Summary: Review Request: python33 - Version 3.3 of the Python programming language Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: mhron...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://github.com/fedora-python/python33/raw/master/python33.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python33-3.3.6-1.fc26.src.rpm Description: Python 3.3 package for developers. No security fixes will be applied. Fedora Account System Username: churchyard COPR: https://copr.fedorainfracloud.org/coprs/g/python/python33/ In the review, please note that this is a backport of the python3 package and the spec might be more complicated than necessary for the sake of much easier portability between python34 and python3. On the other hand, please be thorough about things like conflicts with python3 package, upgrade paths, etc. Also please note that: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Process Contributors and reviewers MUST follow the Package Review Process, with the following exceptions: * The package is being created so that multiple versions of the same package can coexist in the distribution. The package MUST be properly named according to the naming guidelines and MUST NOT conflict with all other versions of the same package. I'd like the reviewer to check this condition first. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list package-review@lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/package-review@lists.fedoraproject.org
