[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model
https://bugzilla.redhat.com/show_bug.cgi?id=1375222 Miro Hrončok changed: What|Removed |Added CC||mhron...@redhat.com --- Comment #7 from Miro Hrončok --- Just a note: You are doing Python 3 conditionals, but still use python2- prefix for Python 2 subpackage, that's not being used in (RH|EP)EL. Is there a rationale? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #34 from Fedora Update System --- lumina-desktop-1.0.0-5.p2.Lbc08e90.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-352e664f45 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1373486] Review Request: python34 - Version 3.4 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1373486 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|ON_QA --- Comment #12 from Fedora Update System --- python34-3.4.5-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-b6ce74ea2e -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #31 from yunying@intel.com --- (In reply to lo1 from comment #30) > Changelog needs to be updated every time you make changes: > https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/ > Guidelines#Changelogs > Thanks for the review Vicky. About change logs, on wiki it says "Every time you make changes, that is, whenever you increment the E-V-R of a package, add a changelog entry. ". My understanding is only when version and/or release is updated, changelog needed. In my case, the target version/release is the package's first release, 1.0-beta1, not changed. So I suppose it's better not to log every detailed changes which I made to fix issues found during review, otherwise the changelog would be long and full of minor details. Is it acceptable? > > > The package failed to build on Fedora 24 (x86_64) as below: > Your build failed due to not finding g++. But on koji build server and COPR, this package does compile successfully. I did local rpmbuild on my desktop with RHEL 7.3 Alpha(No Fedora 24 environment so far). Does Fedora 24 local build is mandatory for new package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1375670 --- Comment #4 from Miro Hrončok --- As the other patches are not numbered, I don't think so. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1279093] Review Request: smartirc4net - C# IRC library
https://bugzilla.redhat.com/show_bug.cgi?id=1279093 --- Comment #6 from Matthias Mailänder --- https://pkgs.org/fedora-rawhide/fedora-i386/smuxi-engine-1.0.5-1.fc25.i686.rpm.html already bundles it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API
https://bugzilla.redhat.com/show_bug.cgi?id=1379254
Michael Hampton changed:
What|Removed |Added
CC||ttome...@redhat.com
Flags||needinfo?(ttomecek@redhat.c
||om)
--- Comment #1 from Michael Hampton ---
Just a couple of easy-to-fix issues, which are at the top:
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
Issues:
===
- If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %license.
Note: License file LICENSE is not marked as %license
See:
http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
- python3-docker-pycreds requires python3-six, not listed in Requires:
= MUST items =
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
Note: License file LICENSE is not marked as %license
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[!]: Requires correct, justified where necessary.
python3-docker-pycreds requires python3-six, not listed in Requires:
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[-]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
Note: Tests require a package which is not yet in Fedora.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 l...@us.ibm.com changed: What|Removed |Added CC||l...@us.ibm.com --- Comment #30 from l...@us.ibm.com --- Changelog needs to be updated every time you make changes: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs The package failed to build on Fedora 24 (x86_64) as below: libtool: compile: g++ -DPACKAGE_NAME=\"tpm2.0-tss\" -DPACKAGE_TARNAME=\"tpm2-0-tss\" -DPACKAGE_VERSION=\"0.98\" "-DPACKAGE_STRING=\"tpm2.0-tss 0.98\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DPACKAGE=\"tpm2-0-tss\" -DVERSION=\"0.98\" -I. -I./include -I./common -I./sysapi/include -I./include -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -c common/sockets.cpp -o common/.libs/tcti_libtcti_socket_la-sockets.o ./libtool: line 1763: g++: command not found Makefile:5819: recipe for target 'common/tcti_libtcti_socket_la-sockets.lo' failed make: *** [common/tcti_libtcti_socket_la-sockets.lo] Error 1 make: *** Waiting for unfinished jobs libtool: compile: g++ -DPACKAGE_NAME=\"tpm2.0-tss\" -DPACKAGE_TARNAME=\"tpm2-0-tss\" -DPACKAGE_VERSION=\"0.98\" "-DPACKAGE_STRING=\"tpm2.0-tss 0.98\"" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1 -DLT_OBJDIR=\".libs/\" -DHAVE_PTHREAD_PRIO_INHERIT=1 -DHAVE_PTHREAD=1 -DPACKAGE=\"tpm2-0-tss\" -DVERSION=\"0.98\" -I. -I./include -I./common -I./sysapi/include -I./include -O2 -g -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -c tcti/tcti_socket.cpp -o tcti/.libs/tcti_libtcti_socket_la-tcti_socket.o ./libtool: line 1763: g++: command not found Makefile:5812: recipe for target 'tcti/tcti_libtcti_socket_la-tcti_socket.lo' failed make: *** [tcti/tcti_libtcti_socket_la-tcti_socket.lo] Error 1 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker
https://bugzilla.redhat.com/show_bug.cgi?id=1342839 --- Comment #30 from Fedora Update System --- python-pycodestyle-2.0.0-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API
https://bugzilla.redhat.com/show_bug.cgi?id=1379254 Michael Hampton changed: What|Removed |Added Assignee|nob...@fedoraproject.org|er...@ioerror.us -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379254] Review Request: python-docker-pycreds - Python bindings for the docker credentials store API
https://bugzilla.redhat.com/show_bug.cgi?id=1379254 Michael Hampton changed: What|Removed |Added Status|NEW |ASSIGNED CC||er...@ioerror.us Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1373623] Review Request: glide - Package Management for Golang
https://bugzilla.redhat.com/show_bug.cgi?id=1373623 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed|2016-09-12 09:20:04 |2016-09-26 23:51:09 --- Comment #14 from Fedora Update System --- glide-0.12.1-0.1.git8032c28.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)
https://bugzilla.redhat.com/show_bug.cgi?id=1361340 --- Comment #21 from Fedora Update System --- python-fadvise-5.0.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1361340] Review Request: python-fadvise - Python interface to posix_fadvise(2)
https://bugzilla.redhat.com/show_bug.cgi?id=1361340 --- Comment #20 from Fedora Update System --- python-fadvise-5.0.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #29 from yunying@intel.com --- Fixed a typo in ExcludeArch list. Updated SPEC: https://raw.githubusercontent.com/yunyings/share/master/tpm2-tss.spec Updated SRPMS: https://github.com/yunyings/share/raw/master/tpm2-tss-1.0-0.1.beta1.el7.src.rpm Succeeded Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15817437 Succeeded COPR build: https://copr.fedorainfracloud.org/coprs/yunyings/tpm2-tss/build/458077/ Anyone could kindly help to review, and maybe approve if no more issues found? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1377444 d. johnson changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1377444 d. johnson changed: What|Removed |Added Flags|fedora-review+ | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII
https://bugzilla.redhat.com/show_bug.cgi?id=1378999 d. johnson changed: What|Removed |Added Flags||fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII
https://bugzilla.redhat.com/show_bug.cgi?id=1378999 Nick Bebout changed: What|Removed |Added Flags|fedora-review+ | -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1377444 Nick Bebout changed: What|Removed |Added Flags||fedora-review+ --- Comment #3 from Nick Bebout --- For some reason it isn't letting him set fedora-review+. Setting for him, per comment # 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII
https://bugzilla.redhat.com/show_bug.cgi?id=1378999 Nick Bebout changed: What|Removed |Added Flags||fedora-review+ --- Comment #3 from Nick Bebout --- For some reason it isn't letting him set fedora-review+. Setting for him, per comment # 2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1342839] Review Request: python-pycodestyle - Python style guide checker
https://bugzilla.redhat.com/show_bug.cgi?id=1342839 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:39:39 --- Comment #29 from Fedora Update System --- python-flake8-import-order-0.9.2-1.fc25, python-pycodestyle-2.0.0-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378999] Review Request: perl-Test-Mock-Guard - Simple mock test library using RAII
https://bugzilla.redhat.com/show_bug.cgi?id=1378999
--- Comment #2 from d. johnson ---
Approved after two minor items:
* Note: License file LICENSE is marked as %doc instead of %license
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
The .spec is correct for older builds, but the standards have changed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377444] Review Request: perl-JSON-WebToken - JSON Web Token (JWT) implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1377444
--- Comment #2 from d. johnson ---
Approved after two minor items:
* Note: License file LICENSE is marked as %doc instead of %license
[!]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
The .spec is correct for older builds, but the standards have changed.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever
https://bugzilla.redhat.com/show_bug.cgi?id=1377252 Bug 1377252 depends on bug 1377228, which changed state. Bug 1377228 Summary: Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn https://bugzilla.redhat.com/show_bug.cgi?id=1377228 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377228] Review Request: perl-Test2-Plugin-NoWarnings - Fail if tests warn
https://bugzilla.redhat.com/show_bug.cgi?id=1377228 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:37:45 --- Comment #5 from Fedora Update System --- perl-Test2-Plugin-NoWarnings-0.02-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1310873] Review Request: rubygem-async_sinatra - A Sinatra plugin for running on async webservers
https://bugzilla.redhat.com/show_bug.cgi?id=1310873 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:37:16 --- Comment #15 from Fedora Update System --- rubygem-async_sinatra-1.2.1-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377252] Review Request: perl-Params-ValidationCompiler - Build an optimized subroutine parameter validator once , use it forever
https://bugzilla.redhat.com/show_bug.cgi?id=1377252 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:37:29 --- Comment #5 from Fedora Update System --- perl-Params-ValidationCompiler-0.13-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1354113] Review Request: python-pytest-catchlog - py.test plugin to catch log messages ( fork of pytest-capturelog)
https://bugzilla.redhat.com/show_bug.cgi?id=1354113 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:37:27 --- Comment #15 from Fedora Update System --- python-pytest-catchlog-1.2.2-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1374035] Review Request: pimd - The original PIM-SM multicast routing daemon
https://bugzilla.redhat.com/show_bug.cgi?id=1374035 --- Comment #11 from Fedora Update System --- pimd-2.3.2-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1348005] Review Request: rubygem-bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1348005 Bug 1348005 depends on bug 1348202, which changed state. Bug 1348202 Summary: Review Request: rubygem-pcaprub - libpcap bindings for ruby https://bugzilla.redhat.com/show_bug.cgi?id=1348202 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1348206] Review Request: rubygem-packetfu - PacketFu is a mid-level packet manipulation library
https://bugzilla.redhat.com/show_bug.cgi?id=1348206 Bug 1348206 depends on bug 1348202, which changed state. Bug 1348202 Summary: Review Request: rubygem-pcaprub - libpcap bindings for ruby https://bugzilla.redhat.com/show_bug.cgi?id=1348202 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377812] Review Request: python-sphinxcontrib-blockdiag - Sphinx " blockdiag" extension
https://bugzilla.redhat.com/show_bug.cgi?id=1377812 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:34:08 --- Comment #5 from Fedora Update System --- python-sphinxcontrib-blockdiag-1.5.5-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1348005] Review Request: rubygem-bettercap - A complete, modular, portable and easily extensible MITM framework
https://bugzilla.redhat.com/show_bug.cgi?id=1348005 Bug 1348005 depends on bug 1348162, which changed state. Bug 1348162 Summary: Review Request: rubygem-net-dns - Pure Ruby DNS library https://bugzilla.redhat.com/show_bug.cgi?id=1348162 What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1348202] Review Request: rubygem-pcaprub - libpcap bindings for ruby
https://bugzilla.redhat.com/show_bug.cgi?id=1348202 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:34:18 --- Comment #13 from Fedora Update System --- rubygem-pcaprub-0.12.4-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1372718] Review Request: rubygem-puma - A simple, fast, threaded, and highly concurrent HTTP 1.1 server
https://bugzilla.redhat.com/show_bug.cgi?id=1372718 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:33:58 --- Comment #27 from Fedora Update System --- rubygem-puma-3.6.0-3.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1348162] Review Request: rubygem-net-dns - Pure Ruby DNS library
https://bugzilla.redhat.com/show_bug.cgi?id=1348162 Fedora Update System changed: What|Removed |Added Status|ON_QA |CLOSED Resolution|--- |ERRATA Last Closed||2016-09-26 20:34:13 --- Comment #12 from Fedora Update System --- rubygem-net-dns-0.8.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1279093] Review Request: smartirc4net - C# IRC library
https://bugzilla.redhat.com/show_bug.cgi?id=1279093 gil cattaneo changed: What|Removed |Added CC|punto...@libero.it | Assignee|punto...@libero.it |nob...@fedoraproject.org -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378014] Review Request: perl-IO-FDPass - Pass a file descriptor over a socket
https://bugzilla.redhat.com/show_bug.cgi?id=1378014 --- Comment #10 from Fedora Update System --- perl-IO-FDPass-1.1-3.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-4b7393cfce -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378160] Review Request: jitterentropy-rngd - RNGD based on CPU Jitter RNG
https://bugzilla.redhat.com/show_bug.cgi?id=1378160 --- Comment #5 from Fedora Update System --- jitterentropy-rngd-1.0.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-92b03e8aff -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1357064] Review Request: lumina-desktop - A lightweight, portable desktop environment
https://bugzilla.redhat.com/show_bug.cgi?id=1357064 --- Comment #33 from Fedora Update System --- lumina-desktop-1.0.0-5.p2.Lbc08e90.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-8ef6597c75 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data
https://bugzilla.redhat.com/show_bug.cgi?id=1336552 --- Comment #10 from Christoph Junghans --- I found another overlinking issue with fedora-review. Spec URL: https://raw.githubusercontent.com/junghans/fedora-review/master/exodusii/exodusii.spec SRPM URL: https://github.com/junghans/fedora-review/raw/master/exodusii/exodusii-6.02-4.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 --- Comment #1 from Björn "besser82" Esser --- Correct urls: Spec URL: https://besser82.fedorapeople.org/review/odoo.spec SRPM URL: https://besser82.fedorapeople.org/review/odoo-9.0c.20160923-0.1.fc26.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1378445] Review Request: kf5-kirigami - QtQuick plugins to build user interfaces based on the KDE UX guidelines
https://bugzilla.redhat.com/show_bug.cgi?id=1378445 Markus S. changed: What|Removed |Added CC||kamika...@web.de --- Comment #10 from Markus S. --- Forgo 1.0 and jump directly to 1.1: https://www.kde.org/announcements/kirigami-1.1.php https://techbase.kde.org/Kirigami -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages
https://bugzilla.redhat.com/show_bug.cgi?id=1375744 --- Comment #10 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/gasnet -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1373487] Review Request: python33 - Version 3.3 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1373487 --- Comment #2 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python33 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter
https://bugzilla.redhat.com/show_bug.cgi?id=1327981 --- Comment #7 from Thomas Spura --- (In reply to Mukundan Ragavan from comment #6) > any movement here folks? Thanks for the ping. Any help with other depending packages of the python notebook is welcome. %changelog - update to 4.5.0 - Fix %%description - use new pythonhosted url in source0 I'm open for suggestions for a better description. Unfortunately, this package does nothing fancy except providing the IPython kernel... Spec URL: https://tomspur.fedorapeople.org/review/python-ipykernel/python-ipykernel.spec SRPM URL: https://tomspur.fedorapeople.org/review/python-ipykernel/python-ipykernel-4.5.0-1.fc23.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1327981] Review Request: python-ipykernel - IPython Kernel for Jupyter
https://bugzilla.redhat.com/show_bug.cgi?id=1327981 Bug 1327981 depends on bug 1327989, which changed state. Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol implementation and client libraries https://bugzilla.redhat.com/show_bug.cgi?id=1327989 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1327979] Review Request: python-jupyter-notebook - A web-based notebook environment for interactive computing
https://bugzilla.redhat.com/show_bug.cgi?id=1327979 Bug 1327979 depends on bug 1327989, which changed state. Bug 1327989 Summary: Review Request: python-jupyter-client - Jupyter protocol implementation and client libraries https://bugzilla.redhat.com/show_bug.cgi?id=1327989 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1327989] Review Request: python-jupyter-client - Jupyter protocol implementation and client libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1327989 Thomas Spura changed: What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE Flags|needinfo?(tomspur@fedorapro | |ject.org) | Last Closed||2016-09-26 15:49:33 --- Comment #12 from Thomas Spura --- Thanks for the ping and sorry for the delay. Building in rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=15812954 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379460] Review Request: kompose - Tool to move from `docker-compose` to Kubernetes
https://bugzilla.redhat.com/show_bug.cgi?id=1379460 Dusty Mabe changed: What|Removed |Added Assignee|nob...@fedoraproject.org|jchal...@redhat.com --- Comment #1 from Dusty Mabe --- Hey jchaloup. I ran redora review tool on this rpm myself. One problem I notice is that the devel rpm won't install because the "requires" aren't all met. This makes sense because we don't bundle things in the vendor directory. What do I do about that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1366047 --- Comment #34 from l...@us.ibm.com --- (In reply to Tomas Mraz from comment #30) > I would say that in using Exclude vs. ExclusiveArch we should apply some > reasoning - if it is positively known that the package does not work on > anything else than x86_64 ppc64le armv7hl i686 then ExclusiveArch would be > appropriate. If on the other hand we know that it does not work for example > on aarch64 but it should work on anything else, then ExcludeArch would be > more appropriate. Thanks! The package doesn't support big endian yet. Thus, I liisted ppc64 and s390x as ExcludeArch. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379460] New: Review Request: kompose - Tool to move from `docker-compose` to Kubernetes
https://bugzilla.redhat.com/show_bug.cgi?id=1379460 Bug ID: 1379460 Summary: Review Request: kompose - Tool to move from `docker-compose` to Kubernetes Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: dustym...@redhat.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose.spec SRPM URL: https://dustymabe.fedorapeople.org/kompose-rpm/kompose-0.1.0-0.1.git8227684.fc24.src.rpm Description: This is a tool that is used to convert between compose files to kubernetes/openshift artifacts. Fedora Account System Username: dustymabe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1375670 --- Comment #3 from Charalampos Stratakis --- (In reply to Miro Hrončok from comment #2) > Could you please commit (or PR) it into the GH repo? > https://github.com/fedora-python/python26 > > Thanks Is it required for this package to reserve a new patch number as stated at [0]? [0] https://fedoraproject.org/wiki/SIGs/Python/PythonPatches -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1377733] Review Request: systemd-bootchart - Boot performance graphing tool
https://bugzilla.redhat.com/show_bug.cgi?id=1377733 --- Comment #10 from Zbigniew Jędrzejewski-Szmek --- Hi, I was travelling the last few days, I couldn't participate in the conversation. I'm fine with adding a Recommend. This package is tiny, so this shouldn't be an issue. I'll add it on systemd-udev, since this is useful on "real" systems. http://pkgs.fedoraproject.org/cgit/rpms/systemd.git/commit/?h=master&id=ef73cc0d30dc1cd4c58ffc368ab0671daccf76fe -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1359914] Review Request: lollypop - Music player for GNOME
https://bugzilla.redhat.com/show_bug.cgi?id=1359914 --- Comment #9 from MartinKG --- Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/lollypop.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/lollypop-0.9.205-1.fc24.src.rpm %changelog * Mon Sep 26 2016 Martin Gansser - 0.9.205-1 * Update to 0.9.205 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages
https://bugzilla.redhat.com/show_bug.cgi?id=1375744 gil cattaneo changed: What|Removed |Added Flags|fedora-review? |fedora-review+ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1375670 --- Comment #2 from Miro Hrončok --- Could you please commit (or PR) it into the GH repo? https://github.com/fedora-python/python26 Thanks -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages
https://bugzilla.redhat.com/show_bug.cgi?id=1375744
--- Comment #9 from gil cattaneo ---
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "MIT/X11 (BSD like)", "BSD (3 clause)", "Unknown or generated".
370 files have unknown license. Detailed output of licensecheck in
/home/gil/1375744-gasnet/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[?]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/lib/valgrind(valgrind-
devel, valgrind-openmpi, valgrind)
[?]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 317440 bytes in 7 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Perl:
[x]: Package contains the mandatory BuildRequires and Requires:.
Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
echo $version)) missing?
= SHOULD items =
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gasnet-
common , gasnet-openmpi , gasnet-mpich , gasnet-devel , gasnet-doc ,
gasnet-debuginfo
[x]: Package functions as described.
[x]: Latest v
[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1366047 --- Comment #33 from l...@us.ibm.com --- (In reply to yunying.sun from comment #29) > From Fedora packaging guideline, ExcludeArch is preferred than > ExclusiveArch, see "ExcludeArch & ExclusiveArch" part @ > https://fedoraproject.org/wiki/Architectures#Primary_Architectures . > > There are some explanations about ExcludeArch here: > https://fedoraproject.org/wiki/Packaging: > Guidelines?rd=PackagingGuidelines#Architecture_Support > > You might need to change to ExcludeArch. Actually, I was advised so when > packing a similar TSS2 package: > https://bugzilla.redhat.com/show_bug.cgi?id=1369708 . > > BTW, could we have a review swap? Thanks for your review! I'll take a look at yours. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1366047 --- Comment #32 from l...@us.ibm.com --- Updated Spec URL: https://fedorapeople.org/~honclo/tss2.spec Updated SRPM URL: https://fedorapeople.org/~honclo/tss2-713-6.fc24.src.rpm Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15812569 Here is the Rpmlint outputs: $ rpmlint tss2.spec ../SRPMS ../RPMS tss2-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 1 specfiles checked; 0 errors, 1 warnings. %changelog * Mon Sep 26 2016 Hon Ching(Vicky) Lo - 713-6 - Added s390x arch as another "ExcludeArch" -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375744] Review Request: gasnet - A Portable High-Performance Communication Layer for GAS Languages
https://bugzilla.redhat.com/show_bug.cgi?id=1375744
--- Comment #8 from Christoph Junghans ---
(In reply to gil cattaneo from comment #7)
> Issues:
>
> [?]: Package contains the mandatory BuildRequires and Requires:.
> Note: Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`";
> echo $version)) missing?
> for gasnet_trace.pl
Fixed.
>
> unused-direct-shlib-dependency and undefined-non-weak-symbol should be fixes
> replacing "-shared" with "-Wl,--as-needed"
Added, but there most of the errors are due to the fact MPI_LIB is not in
LD_LIBRARY_PATH, e.g. libgasnet-mpi* is linked against libammpi and libammpi
against libmpi, but all of them live in MPI_LIB and hence cannot be found by
rpmlint.
>
> NON blocking issues:
> [!]: Latest version is packaged.
> Is available: gasnet-1.27.5, gasnet-1.28.0-rc1
They haven't officially released it yet (see https://gasnet.lbl.gov/) so let's
stick to 1.26.4 for now.
Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/gasnet/gasnet.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/gasnet/gasnet-1.26.4-3.fc24.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1366047] Review Request: tss2 - IBM's TSS 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1366047 --- Comment #31 from l...@us.ibm.com --- Spec URL: https://fedorapeople.org/~honclo/tss2.spec SRPM URL: https://fedorapeople.org/~honclo/tss2-713-5.fc24.src.rpm Description: TSS2 is a user space Trusted Computing Group's Software Stack (TSS) for TPM 2.0. It implements the functionality equivalent to the TCG TSS working group's ESAPI, SAPI, and TCTI layers (and perhaps more) but with a hopefully far simpler interface. It comes with about 80 "TPM tools" that can be used for rapid prototyping, education and debugging. Fedora Account System Username: l...@us.ibm.com Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15812194 This is my first package and I need a sponsor. Thanks for all the comments and review! Here is the Rpmlint outputs: $ rpmlint tss2.spec ../RPMS/ ../SRPMS/ tss2-devel.x86_64: W: only-non-binary-in-usr-lib 4 packages and 1 specfiles checked; 0 errors, 1 warnings. %changelog * Mon Sep 26 2016 Hon Ching(Vicky) Lo - 713-5 - replaced ExclusiveArch with ExcludeArch -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421 Björn "besser82" Esser changed: What|Removed |Added Blocks||1379432 (odoo) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1379432 [Bug 1379432] Review Request: odoo - Suite of web based open source business apps -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 Björn "besser82" Esser changed: What|Removed |Added Depends On||1379421 (python-psycogreen) Alias||odoo Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1379421 [Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379432] New: Review Request: odoo - Suite of web based open source business apps
https://bugzilla.redhat.com/show_bug.cgi?id=1379432 Bug ID: 1379432 Summary: Review Request: odoo - Suite of web based open source business apps Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@besser82.io QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description: Odoo is a complete ERP and CRM. The main features are accounting (analytic and financial), stock management, sales and purchases management, tasks automation, marketing campaigns, help desk, POS, etc. Technical features include a distributed server, flexible workflows, an object database, a dynamic GUI, customizable reports, and XML-RPC interfaces. Koji Build: No build, because of unmet BuildRequires, currently under review. Issues: No known packaging issues, but some complaints from rpmlint: odoo.noarch: E: non-readable /etc/odoo/odoo.conf 640 odoo.noarch: E: non-standard-dir-perm /etc/odoo 750 odoo.noarch: E: non-standard-dir-perm /var/log/odoo 750 ---> Those dirs / files are not world-readable, because they may contain sensitive information, like db-password and such. odoo.noarch: W: empty-%postun ---> caused by %systemd_postun, which is an empty macro, but this error is consistent with packaging guidelines. odoo.noarch: W: non-standard-gid /etc/odoo odoo odoo.noarch: W: non-standard-gid /etc/odoo/odoo.conf odoo odoo.noarch: W: non-standard-gid /var/lib/odoo odoo odoo.noarch: W: non-standard-gid /var/log/odoo odoo odoo.noarch: W: non-standard-uid /etc/odoo odoo odoo.noarch: W: non-standard-uid /etc/odoo/odoo.conf odoo odoo.noarch: W: non-standard-uid /var/lib/odoo odoo odoo.noarch: W: non-standard-uid /var/log/odoo odoo ---> Those files and dirs are owned by the system-user for Odoo, which is created during %pre-scriptlet. This makes sure the Odoo-server (but no regular user) has write access to those locations. odoo.noarch: W: spelling-error %description -l en_US customizable -> customization odoo.noarch: W: spelling-error %description -l en_US workflows -> work flows, work-flows, workloads ---> False positive spelling-errors. FAS-User: besser82 Urls: Spec URL: https://besser82.fedorapeople.org/review/jekyll/odoo.spec SRPM URL: https://besser82.fedorapeople.org/review/odoo-9.0c.20160923-0.1.fc26.src.rpm Thanks for review in advance! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1372123] Review Request: pacmanager - Perl Auto Connector, a multi-purpose SSH/terminal connection manager
https://bugzilla.redhat.com/show_bug.cgi?id=1372123
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #5 from Rex Dieter ---
non-blocker nit-picks (please fix before submitting any official builds):
5. .spec update lacked %changelog entry
6. %files includes:
%{_datadir}/%{name}/*
which still leaves the parent dir unowned, better:
%{_datadir}/%{name}/
7. consider not using %{name} macro in %files, it's fragile (ie, if the
package name ever changed for any reason, the build would fail).
APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379393] Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
https://bugzilla.redhat.com/show_bug.cgi?id=1379393
Rex Dieter changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #2 from Rex Dieter ---
naming: ok
license: ok
1. could/should leave out:
BuildRequires: %{?fedora:cmake}%{!?fedora:cmake3} >= 3.0
that dependency should be handled by whatever package that provides the
%{cmake_lxqt}
macro
macros: ok
2. should consider adjusting pavucontrol-qt.desktop Name/GenericNameComment
somehow, it currently appears exactly the same as pavucontrol, so it's
hard/impossible to distinguish which is which, contains:
Name=PulseAudio Volume Control
GenericName=Volume Control
Comment=Adjust the volume level
(not a blocker, mostly a suggestion for pavucontrol-qt upstream)
scriptlets: ok (n/a)
sources: ok
32217c5ae8a846e92548a55b8d3b9267 pavucontrol-qt-0.1.0.tar.xz
otherwise, package is fairly simple and clean,
APPROVED
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421 Björn "besser82" Esser changed: What|Removed |Added Summary|Review Request: Review |Review Request: |Request: python-psycogreen |python-psycogreen - |- Psycopg2 integration with |Psycopg2 integration with |co-routine libraries|co-routine libraries -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379421] Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421 Björn "besser82" Esser changed: What|Removed |Added Alias||python-psycogreen -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379421] New: Review Request: Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries
https://bugzilla.redhat.com/show_bug.cgi?id=1379421 Bug ID: 1379421 Summary: Review Request: Review Request: python-psycogreen - Psycopg2 integration with co-routine libraries Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: fed...@besser82.io QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description: The psycogreen package enables psycopg2 to work with co-routine libraries, using asynchronous calls internally but offering a blocking interface so that regular code can run unmodified. Psycopg offers co-routines support since release 2.2. Because the main module is a C extension it cannot be monkey-patched to become co-routine-friendly. Instead it exposes a hook that co-routine libraries can use to install a function integrating with their event scheduler. Psycopg will call the function whenever it executes a libpq call that may block. Psycogreen is a collection of “wait callbacks” useful to integrate Psycopg with different co-routine libraries. Koji Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15811888 Issues: no known issues, but some false positives about spelling from rpmlint. FAS-User: besser82 Urls: Spec URL: https://besser82.fedorapeople.org/review/python-psycogreen.spec SRPM URL: https://besser82.fedorapeople.org/review/python-psycogreen-1.0-0.1.fc26.src.rpm Thanks for review in advance! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1030751] Review Request: python-bbcode - A pure python bbcode parser and formatter
https://bugzilla.redhat.com/show_bug.cgi?id=1030751 Charalampos Stratakis changed: What|Removed |Added CC||cstra...@redhat.com, ||i...@cicku.me Flags||needinfo?(i...@cicku.me) --- Comment #12 from Charalampos Stratakis --- Project is still active upstream: https://github.com/dcwatson/bbcode Is there still a desire to package it for fedora? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 806117] Review Request: python-oplop - Generate account passwords based on account nicknames
https://bugzilla.redhat.com/show_bug.cgi?id=806117 Charalampos Stratakis changed: What|Removed |Added CC||abdel.g.martine...@gmail.co ||m, cstra...@redhat.com Flags||needinfo?(abdel.g.martinez. ||l...@gmail.com) --- Comment #24 from Charalampos Stratakis --- This project is now (not so) active on github: https://github.com/brettcannon/oplop Is there still a desire to package that? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 769487] Review Request: python-glumpy - Small python library for rapid visualization of numpy arrays
https://bugzilla.redhat.com/show_bug.cgi?id=769487 Charalampos Stratakis changed: What|Removed |Added CC||cstra...@redhat.com, ||thibault.no...@gmail.com Flags||needinfo?(thibault.north@gm ||ail.com) --- Comment #9 from Charalampos Stratakis --- Project seems active on github now. Any movements on the package? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language
https://bugzilla.redhat.com/show_bug.cgi?id=1375670 --- Comment #1 from Charalampos Stratakis --- On koji the build finishes successfully for f23, while this is not the case for copr f23 chroots. The issue here are zombie processes left behind due to a test case in test_thread.py, so there is a possibility, that the build service used cannot kill the processes at the end of the build (after the %check phase has ran). In order to avoid this, I would suggest applying this [patch] from upstream which was applied only on python 2.7. [patch] https://hg.python.org/cpython/rev/613196986c09/ Copr builds for f23 finish successfully with this commit: https://copr.fedorainfracloud.org/coprs/g/python/python26/build/457870/ -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379393] Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
https://bugzilla.redhat.com/show_bug.cgi?id=1379393 Rex Dieter changed: What|Removed |Added Status|NEW |ASSIGNED CC||rdie...@math.unl.edu Blocks||928937 (qt-reviews) Assignee|nob...@fedoraproject.org|rdie...@math.unl.edu Alias||pavucontrol-qt Flags||fedora-review? --- Comment #1 from Rex Dieter --- I can review today (or tomorrow) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=928937 [Bug 928937] Qt-related package review tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1379393] New: Review Request: pavucontrol-qt - Qt port of volume control pavucontrol
https://bugzilla.redhat.com/show_bug.cgi?id=1379393 Bug ID: 1379393 Summary: Review Request: pavucontrol-qt - Qt port of volume control pavucontrol Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nob...@fedoraproject.org Reporter: he...@kde.org QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Spec URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt.spec SRPM URL: https://heliocastro.fedorapeople.org/pavucontrol-qt/pavucontrol-qt-0.1.0-1.fc24.src.rpm Description: Qt port of volume control pavucontrol Fedora Account System Username: heliocastro -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator
https://bugzilla.redhat.com/show_bug.cgi?id=1362487
--- Comment #17 from Mamoru TASAKA ---
(In reply to Jared Smith from comment #16)
> 3) It's not a huge deal, but rpmlint is complaining that the bash completion
> file isn't marked as %config(noreplace) instead of just %config. Have you
> thought about whether or not you'd want this file to get replaced with a new
> version (if someone had altered the file)?
Well, now bash completion directory is %_datadir/bash-completion/completions ,
not %{_sysconfdir}/bash_completion.d (the latter is deprecated).
You can check what
$ pkg-config --variable=completionsdir bash-completion
returns (and as bash completion files is now not under %_sysconfdir, no %config
should be added)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376450] Review Request: libdvbpsi - Library for MPEG TS and DVB PSI tables decoding and generation
https://bugzilla.redhat.com/show_bug.cgi?id=1376450 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/libdvbpsi -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1362487] Review Request: arcanist - A command line interface to Phabricator
https://bugzilla.redhat.com/show_bug.cgi?id=1362487 --- Comment #16 from Jared Smith --- This package is getting closer to being ready for approval. The remaining outstanding items are: 1) This package fails to install, because of the missing dependency on libphutil. 2) The spec file should use "%global" instead of "%define", unless you can justify the reason why you need to use "%define". 3) It's not a huge deal, but rpmlint is complaining that the bash completion file isn't marked as %config(noreplace) instead of just %config. Have you thought about whether or not you'd want this file to get replaced with a new version (if someone had altered the file)? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL
https://bugzilla.redhat.com/show_bug.cgi?id=1324863 --- Comment #12 from Dridi Boukelmoune --- > I've never got a 100% clear answer. (Perhaps there is none :-) I can share the dirty secrets of varnish ABI rules, but let's do that in a dedicated ticket against the varnish package when I have something ready to submit to you. Incidentally, I think many things can be simplified in the current spec, and I'm not fond of pulling pkg-varnish-cache in. Upstream doesn't follow our packaging guidelines and has recently reduced RPM packaging down to varnish and varnish-devel (which I don't disagree with). That incidentally dropped the -docs package that our guidelines recommend. I think Fedora packaging of Varnish should be independent of upstream's own packaging. > This last version of varnish-modules is built against varnish-5.0 That's a good point, I was the one who fixed varnish-modules so that vmod-xkey and vmod-softpurge would build against 5.0. I'm still against the aforementioned requires. Please be patient until I have time to submit something ;-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model
https://bugzilla.redhat.com/show_bug.cgi?id=1375222 Igor Gnatenko changed: What|Removed |Added Status|ASSIGNED|NEW Assignee|ignate...@redhat.com|nob...@fedoraproject.org Flags|needinfo?(ignatenko@redhat. | |com)| -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1362490] Review Request: libphutil - A collection of PHP utility classes
https://bugzilla.redhat.com/show_bug.cgi?id=1362490 --- Comment #26 from Jared Smith --- (In reply to Tim Flink from comment #25) > > MIT/X11 (BSD like) > > -- > > libphutil-8f8e02d47569dce5f035383d8bcbf7a08481e839/externals/jsonlint/LICENSE > > Why couldn't this be distributed as APL2? Ignoring the GPL3 issue with the > bison output, I mean. Because it's not licensed under the APL2 license. It's licensed under an MIT-like license. You're not the copyright holder, so you can't change the license on the software. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518
https://bugzilla.redhat.com/show_bug.cgi?id=1290342 --- Comment #3 from gil cattaneo --- Spec URL: https://gil.fedorapeople.org/ecc-25519-java.spec SRPM URL: https://gil.fedorapeople.org/ecc-25519-java-1.0.3-1.fc24.src.rpm - update to 1.0.3 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15809989 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF
https://bugzilla.redhat.com/show_bug.cgi?id=1376436 --- Comment #9 from gil cattaneo --- maybe you should update license field, if mpeg/psi/psi.h is under MIT (style) license -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF
https://bugzilla.redhat.com/show_bug.cgi?id=1376436 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|POST Flags|fedora-review? |fedora-review+ --- Comment #8 from gil cattaneo --- have time for this https://bugzilla.redhat.com/show_bug.cgi?id=1290342 ? thanks in advance Approved -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL
https://bugzilla.redhat.com/show_bug.cgi?id=1324863
--- Comment #11 from Ingvar Hagelund ---
(In reply to Dridi Boukelmoune from comment #10)
> I'm certainly against the varnish ABI dependency, I will submit a patch as
> you requested. In the mean time please remove:
>
> Requires: varnishabi-5.0
Well, that certainly is interesting. I've been trying to get scn (upstream) to
explain what how I can ensure compatibilty among versions of varnish and vmods,
but I've never got a 100% clear answer. (Perhaps there is none :-)
This last version of varnish-modules is built against varnish-5.0, and probably
won't work with earlier versions. We could add a dependency fo varnish >= 5.0,
but then, that may or may not add problems when/if varnish-5.1 or 6.0 is
released. We could add a hard dependency on the exact varnish version, but that
would require a recompile on minor releases, that may not be necessary.
Using the varnish-abi version string seems a fairly reasonable choice to avoid
these kinds of problems. So if that is wrong, I'm very interested in why.
> For the virtual provides, I would add the %{release}-%{version} but it's not
> a must in the packaging guidelines IIRC.
>
> Provides: vmod-cookie = %{release}-%{version}
Yep, that's a good idea :-)
br
Ingvar
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1376436] Review Request: bitstream - Simpler access to binary structures such as specified by MPEG , DVB, IETF
https://bugzilla.redhat.com/show_bug.cgi?id=1376436 --- Comment #7 from Nicolas Chauvet (kwizart) --- Spec URL: http://dl.kwizart.net/review/bitstream.spec SRPM URL: http://dl.kwizart.net/review/bitstream-1.1-2.fc26.src.rpm Description: Simpler access to binary structures such as specified by MPEG, DVB, IETF. Licence clarification requested to upstream https://code.videolan.org/videolan/bitstream/issues/1 (but mpeg/psi/psi.h seems right to me) Changelog: * Mon Sep 26 2016 Nicolas Chauvet - 1.1-2 - Only create a -devel package - Remove Group from rpm - Correct License MIT koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15809678 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1375222] Review Request: python-django-jsonfield - A reusable Django field that allows you to store validated JSON in your model
https://bugzilla.redhat.com/show_bug.cgi?id=1375222 Germano Massullo changed: What|Removed |Added Flags||needinfo?(ignatenko@redhat. ||com) --- Comment #6 from Germano Massullo --- All problems fixed spec file: https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield.spec srpm file: https://germano.fedorapeople.org/package_reviews/python-django-jsonfield/python-django-jsonfield-1.0.3-1.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL
https://bugzilla.redhat.com/show_bug.cgi?id=1324863
--- Comment #10 from Dridi Boukelmoune ---
I'm certainly against the varnish ABI dependency, I will submit a patch as you
requested. In the mean time please remove:
Requires: varnishabi-5.0
For the virtual provides, I would add the %{release}-%{version} but it's not a
must in the packaging guidelines IIRC.
Provides: vmod-cookie = %{release}-%{version}
Cheers
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1317887] Review Request: libfastjson - C json library
https://bugzilla.redhat.com/show_bug.cgi?id=1317887 Tomas Sykora changed: What|Removed |Added Assignee|nob...@fedoraproject.org|tosyk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1317887] Review Request: libfastjson - C json library
https://bugzilla.redhat.com/show_bug.cgi?id=1317887 Tomas Sykora changed: What|Removed |Added Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290339] Review Request: curve25519-java - Implementation of Curve25519 in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1290339 gil cattaneo changed: What|Removed |Added Status|ASSIGNED|CLOSED Fixed In Version||curve25519-java-0.1.0-1.fc2 ||6 Resolution|--- |RAWHIDE Last Closed||2016-09-26 09:08:14 --- Comment #6 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15809250 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1317887] Review Request: libfastjson - C json library
https://bugzilla.redhat.com/show_bug.cgi?id=1317887 Radovan Sroka changed: What|Removed |Added Assignee|tosyk...@redhat.com |nob...@fedoraproject.org --- Comment #10 from Radovan Sroka --- This is new libfastjson package: http://www.stud.fit.vutbr.cz/~xsroka00/libfastjson-0.99.4-1.fc24.src.rpm http://www.stud.fit.vutbr.cz/~xsroka00/libfastjson.spec -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518
https://bugzilla.redhat.com/show_bug.cgi?id=1290342 Bug 1290342 depends on bug 1290339, which changed state. Bug 1290339 Summary: Review Request: curve25519-java - Implementation of Curve25519 in Java https://bugzilla.redhat.com/show_bug.cgi?id=1290339 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518
https://bugzilla.redhat.com/show_bug.cgi?id=1290342 Bug 1290342 depends on bug 1290337, which changed state. Bug 1290337 Summary: Review Request: ed25519-java - Implementation of EdDSA (Ed25519) in Java https://bugzilla.redhat.com/show_bug.cgi?id=1290337 What|Removed |Added Status|POST|CLOSED Resolution|--- |RAWHIDE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1290337] Review Request: ed25519-java - Implementation of EdDSA ( Ed25519) in Java
https://bugzilla.redhat.com/show_bug.cgi?id=1290337 gil cattaneo changed: What|Removed |Added Status|POST|CLOSED Fixed In Version||ed25519-java-0.1.0-1.fc26 Resolution|--- |RAWHIDE Last Closed||2016-09-26 09:07:19 --- Comment #7 from gil cattaneo --- Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=15809314 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL
https://bugzilla.redhat.com/show_bug.cgi?id=1324863 --- Comment #9 from Ingvar Hagelund --- (In reply to Ingvar Hagelund from comment #8) > Something like this? > > https://ingvar.fedorapeople.org/varnish/varnish-modules.spec > https://ingvar.fedorapeople.org/varnish/varnish-modules-0.9.2-0.1. > 20160924gitdaa4f1d.fc24.src.rpm Changes: - Upstream git checkout with support for varnish-5.0 - Removed patches that are included upstream - Virtual provides per module - el5 build fix -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1324863] Review Request: varnish-modules - A collection of modules extending varnish VCL
https://bugzilla.redhat.com/show_bug.cgi?id=1324863 --- Comment #8 from Ingvar Hagelund --- Something like this? https://ingvar.fedorapeople.org/varnish/varnish-modules.spec https://ingvar.fedorapeople.org/varnish/varnish-modules-0.9.2-0.1.20160924gitdaa4f1d.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1317887] Review Request: libfastjson - C json library
https://bugzilla.redhat.com/show_bug.cgi?id=1317887 Tomas Sykora changed: What|Removed |Added CC||tosyk...@redhat.com Assignee|nob...@fedoraproject.org|tosyk...@redhat.com -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
