[Bug 1389955] Review Request: gnome-shell-extension-no-top-left-hot-corner - Disable the "hot corner" in GNOME Shell

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389955



--- Comment #4 from terrycloth  ---
Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-no-topleft-hot-corner/raw/master/gnome-shell-extension-no-topleft-hot-corner.spec
SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-no-topleft-hot-corner-14.0-1.fc24.src.rpm


I renamed the package and repository again. I'd originally spelled the package
name with "top-left," because that's  how you normally spell these two separate
words when used together. But  the extension "brands" itself as No Topleft Hot
Corner, so it would be  better if I preserved the "Topleft" name.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390477] Review Request: gnome-shell-extension-do-not-disturb-button - Don' t show desktop notifications until you're ready to look at them

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390477



--- Comment #2 from terrycloth  ---
Okay, summary has been fixed, and updated files pushed. Same URLs.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614



--- Comment #2 from terrycloth  ---
Correction: *installing* TopIcons Plus requires the gsettings command. As far
as I know, the extension itself doesn't need it, but as noted in a comment in
the spec file, upstream recommends using gsettings to disable version
validation during installation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614



--- Comment #1 from terrycloth  ---
I already know that `rpmlint --info` throws an error:

> rpmlint --info gnome-shell-extension-topicons-plus-17-1.fc24.noarch.rpm 
gnome-shell-extension-topicons-plus.noarch: E: explicit-lib-dependency glib2
You must let rpm find the library dependencies by itself. Do not put unneeded
explicit Requires: tags.

...but I'm not sure how to deal with this. TopIcons Plus requires the gsettings
command, which according to rpm --query, is provided by glib2. So I do have to
specify glib2 as a dependency, and I'm not sure how I could make it less
"explicit" to make rpmlint happy.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394614] New: Review Request: gnome-shell-extension-topicons-plus - Move all legacy tray icons to the top panel

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394614

Bug ID: 1394614
   Summary: Review Request: gnome-shell-extension-topicons-plus -
Move all legacy tray icons to the top panel
   Product: Fedora
   Version: 24
 Component: Package Review
  Assignee: nob...@fedoraproject.org
  Reporter: and...@tosk.in
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://gitlab.com/terrycloth/packaging-gnome-shell-extension-topicons-plus/raw/master/gnome-shell-extension-topicons-plus.spec
SRPM URL:
https://andrew.tosk.in/tmp/gnome-shell-extension-topicons-plus-17-1.fc24.src.rpm

Description: Many applications, such as chat clients, downloaders, and some
media players, are meant to run long-term in the background even after you
close their window. These applications remain accessible by adding an icon to
the GNOME Shell Legacy Tray. However, the Legacy Tray is hidden until you push
your mouse into the lower-left of the screen and click on the small tab that
appears. TopIcons Plus brings all icons back to the top panel so that it's
easier to notice when a new application opens in the background or if one
continues to idle after you thought you closed it. You also get some options to
control the look: You can leave the icons in full color, or dynamically convert
them to grayscale, etc.

Fedora Account System Username: terrycloth

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394598] New: Review Request: Nethack - Upgrade to version 3.6.0

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394598

Bug ID: 1394598
   Summary: Review Request: Nethack - Upgrade to version 3.6.0
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: tachokni...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://github.com/tachoknight/nethack-rpm/blob/version-360/nethack.spec
SRPM URL:
https://github.com/tachoknight/nethack-rpm/blob/version-360/nethack-3.6.0-36.fc24.src.rpm
Description: NetHack is a single player dungeon exploration game that runs on a
wide variety of computer systems, with a variety of graphical and text
interfaces all using the same game engine.

Unlike many other Dungeons & Dragons-inspired games, the emphasis in
NetHack is on discovering the detail of the dungeon and not simply
killing everything in sight - in fact, killing everything in sight is
a good way to die quickly.

Each game presents a different landscape - the random number generator
provides an essentially unlimited number of variations of the dungeon
and its denizens to be discovered by the player in one of a number of
characters: you can pick your race, your role, and your gender.

Fedora Account System Username: tachoknight

Hi! I'm a new submitter; Nethack 3.6 has been out for awhile now and the repos
still only have 3.4.3, so I decided to take it on to update the spec file to
work with 3.6. 

I am asking for a sponsor to help guide me through the process; Nethack is too
important a game to languish!

I have run two Koji builds, one for Fedora 24 and the other for the upcoming
Fedora 25:

http://koji.fedoraproject.org/koji/taskinfo?taskID=16441648
http://koji.fedoraproject.org/koji/taskinfo?taskID=16441758

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #9 from Jonny Heggheim  ---
(In reply to gil cattaneo from comment #8)
> If necessary, I will remove them before import

According to
http://fedoraproject.org/wiki/Packaging:Guidelines#No_inclusion_of_pre-built_binaries_or_libraries

It is fine removing it in %prep, but you need to ask upstream to remove the
binaries in their next release.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279112] Review Request: kiss-fft - Fast Fourier Transform library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279112

František Dvořák  changed:

   What|Removed |Added

  Flags|needinfo?(val...@civ.zcu.cz |
   |)   |



--- Comment #9 from František Dvořák  ---
Yes, I'm still interested. Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #24 from Jonny Heggheim  ---
Updated SPEC file.

Spec URL: https://jonny.fedorapeople.org/electrum/electrum.spec
SRPM URL:
https://jonny.fedorapeople.org/electrum/electrum-2.7.12-2.fc25.src.rpm
Description: A lightweight bitcoin client that uses external servers to do the
heavy lifting of the bitcoin protocol.
Fedora Account System Username: jonny
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16440972

Changelog
* Sun Nov 13 2016 Jonny Heggheim  - 2.7.12-2
- Added weak dependency on zbar-pygtk

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1321013] Review request: gnome-shell-extension-taskbar - GNOME Shell Extension TaskBar

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1321013

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
  Flags||needinfo?(zpydr@openmailbox
   ||.org)



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Do you still plan to get this package into Fedora?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632

gil cattaneo  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376940] Review Request: python3-urllib3 - Python 3 HTTP library with thread-safe connection pooling and file post

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376940



--- Comment #3 from Orion Poplawski  ---
Probably, but pkgdb's request for new packages sync process doesn't work with
the Fedora EPEL product, so...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632



--- Comment #5 from gil cattaneo  ---
Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/8667

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
"_" was commonly used, but nowadays "-" is preferred. There's no strict rule,
but if you e.g. look at python packages it's pretty clear: F24 has 3597
'python*' packages, and among that only 84 with an underscore. "Package names
should be in lower case and use dashes in preference to underscores." (BTW, the
upstream is confused too, since they use async-timeout for the the url and
directory names...)

OK, looks good apart from the name. There is no "MUST" guidelines, but please
consider changing it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632

Jonny Heggheim  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #4 from Jonny Heggheim  ---
Review approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632



--- Comment #3 from Jonny Heggheim  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "*No copyright* Apache (v2.0)". 2 files
 have unknown license. Detailed output of licensecheck in
 /home/jonny/tmp/1276632-geronimo-jcdi-1.1-api/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
I assume that it does not conflict with geronimo-jcdi-1.0-api that you also
maintain.

[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if 

[Bug 1394046] Review Request: python3-netaddr - A pure Python network address representation and manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394046

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review+



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
All this applies to the "upstream" python-netaddr.spec too, it'd be best to fix
it there too:

%description is too long to be repeated, it should be defined as a macro.

%{__sed} → sed [https://fedoraproject.org/wiki/Packaging:Guidelines#Macros].

" :-" is strange...

rpmlint:
python34-netaddr.noarch: E: wrong-script-interpreter /usr/bin/netaddr-3.4
/usr/bin/env python
python34-netaddr.noarch: W: install-file-in-docs
/usr/share/doc/python34-netaddr-0.7.18/INSTALL

Those are both valid.

Anyway:
+ package name is OK
+ license is acceptable (BSD)
+ license is specified correctly
+ builds and installs OK
+ provides/requires look correct
+ no scriptlets
+ python macros are used
+ %python_provide is not needed for EPEL

Package is APPROVED. Please consider cleaning up stuff listed above.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3 playback plugin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394148

Yaakov Selkowitz  changed:

   What|Removed |Added

 Depends On||1394147




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394147
[Bug 1394147] Review Request: mpg123 - mp3 audio playback library
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1394148




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394148
[Bug 1394148] Review Request: gstreamer1-plugin-mpg123 - GStreamer mp3
playback plugin
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Yaakov Selkowitz  changed:

   What|Removed |Added

 Blocks||1394582




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394582
[Bug 1394582] MP3 support can now be enabled
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #8 from gil cattaneo  ---
(In reply to Jonny Heggheim from comment #7)
> Review approved, please ignore the bug in fedora-review.
> 
> I noticed uou used rm -r when deleting .java files, not sure if it
> intentional or copy/paste.
If necessary, I will remove them before import

Thanks for the review!

create new SCM requests:
https://admin.fedoraproject.org/pkgdb/package/requests/8666

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632

Jonny Heggheim  changed:

   What|Removed |Added

  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1276632] Review Request: geronimo-jcdi-1.1-api - Apache Geronimo JCDI Spec 1.1

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1276632

Jonny Heggheim  changed:

   What|Removed |Added

 CC||jonnyheggh...@sigaint.org
   Assignee|nob...@fedoraproject.org|jonnyheggh...@sigaint.org



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615

Jonny Heggheim  changed:

   What|Removed |Added

 Blocks|652183 (FE-JAVASIG) |
  Flags|fedora-review?  |fedora-review+



--- Comment #7 from Jonny Heggheim  ---
Review approved, please ignore the bug in fedora-review.

I noticed uou used rm -r when deleting .java files, not sure if it intentional
or copy/paste.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #6 from Jonny Heggheim  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Bundled jar/class files should be removed before build
  Note: Jar files in source (see attachment)
  See: http://fedoraproject.org/wiki/Packaging:Java#Pre-
  built_JAR_files_.2F_Other_bundled_software'

I investigated this check, but I could not find any .jar og .class files in
BUILD after running rpmbuild -bp. This is a bug in fedora-review.

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later)", "Unknown or generated". 529 files have
 unknown license. 
Packager have asked upstream for clarifications.

[x]: License file installed when any subpackage combination is installed.
[-]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
 Note: Maven packages do not need to (Build)Require jpackage-utils. It
 is pulled in by maven-local
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: POM files have correct Maven mapping
[x]: Maven packages should use new style packaging
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage-
 utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from 

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #5 from Jonny Heggheim  ---
(In reply to gil cattaneo from comment #3)
> (In reply to Jonny Heggheim from comment #2)
> > I will review this today/tomorrow. Can you look at bug 1187084?
> 
> Can you take this bug instead bug 1276632?

I am half done with this, I will look at bug 1276632 when this have been
reviewed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1190746] Review Request: mycila-license-maven-plugin - Manage license header of your project

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1190746

gil cattaneo  changed:

   What|Removed |Added

 CC|punto...@libero.it  |
  Flags|needinfo?(zzambers@redhat.c |
   |om) |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #23 from Jonny Heggheim  ---
(In reply to gil cattaneo from comment #22)
> (In reply to gil cattaneo from comment #21)
> > I will review when python-pbkdf2 will be available in rawhide
> Seem unavailable also python-slowaes

Great, both have been requested in the package database, I will let you know
when they are in rawhide.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1325672] Review Request: jmxutils - JMX MBean Utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1325672



--- Comment #1 from gil cattaneo  ---
*** Bug 1039302 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1039302] Review Request: jmxutils - Exporting JMX MBean made easy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1039302

gil cattaneo  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-11-13 16:56:32



--- Comment #4 from gil cattaneo  ---


*** This bug has been marked as a duplicate of bug 1325672 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197048] Review Request: felix-ipojo-metadata - Apache Felix iPOJO Metadata

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197048

gil cattaneo  changed:

   What|Removed |Added

 Blocks||652183 (FE-JAVASIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=652183
[Bug 652183] Java SIG tracker bug
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615

gil cattaneo  changed:

   What|Removed |Added

 Attachment|0   |1
#1177358 is||
   obsolete||



--- Comment #4 from gil cattaneo  ---
Created attachment 1220173
  --> https://bugzilla.redhat.com/attachment.cgi?id=1220173=edit
Source files without license headers - e-mail

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #22 from gil cattaneo  ---
(In reply to gil cattaneo from comment #21)
> I will review when python-pbkdf2 will be available in rawhide
Seem unavailable also python-slowaes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084

gil cattaneo  changed:

   What|Removed |Added

  Flags||fedora-review?



--- Comment #21 from gil cattaneo  ---
I will review when python-pbkdf2 will be available in rawhide

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #3 from gil cattaneo  ---
(In reply to Jonny Heggheim from comment #2)
> I will review this today/tomorrow. Can you look at bug 1187084?

Can you take this bug instead bug 1276632?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1351115] Review Request: python-betamax-matchers - Group of experimental matchers for Betamax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351115

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||ishch...@redhat.com



--- Comment #1 from Iryna Shcherbina  ---
Hi Igor,

the spec file looks good apart from the fact that your python3- subpackage has
Python 2 dependencies. Please change them to:

Requires:   python3-betamax
Requires:   python3-requests-toolbelt

It is an informal review, as I'm not sponsored yet, but I can continue with the
review when I am and when the updates are available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084

Jonny Heggheim  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|punto...@libero.it



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615



--- Comment #2 from Jonny Heggheim  ---
I will review this today/tomorrow. Can you look at bug 1187084?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353615] Review Request: apfloat-java - High performance arbitrary precision arithmetic library for Java

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353615

Jonny Heggheim  changed:

   What|Removed |Added

 CC||jonnyheggh...@sigaint.org
   Assignee|nob...@fedoraproject.org|jonnyheggh...@sigaint.org
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Purell is a tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Athos Ribeiro  changed:

   What|Removed |Added

 Depends On||1394575




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394575
[Bug 1394575] unicode/precis is now secure/precis
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206883] Review Request: golang-github-opennota-urlesc - Package urlesc implements query escaping as per RFC 3986.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206883

Athos Ribeiro  changed:

   What|Removed |Added

 Blocks||1394576




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1394576
[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Purell is
a tiny Go library to normalize URLs
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] Review Request: golang-github-PuerkitoBio-purell - Purell is a tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Athos Ribeiro  changed:

   What|Removed |Added

 Depends On||1206883




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1206883
[Bug 1206883] Review Request: golang-github-opennota-urlesc - Package
urlesc implements query escaping as per RFC 3986.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394576] New: Review Request: golang-github-PuerkitoBio-purell - Purell is a tiny Go library to normalize URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394576

Bug ID: 1394576
   Summary: Review Request: golang-github-PuerkitoBio-purell -
Purell is a tiny Go library to normalize URLs
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athoscribe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-PuerkitoBio-purell-1.0.0-1.src.rpm

Description:
Purell is a tiny Go library to normalize URLs. It returns a pure URL.
It is based on the wikipedia paper (URL_normalization) and the RFC 3986
document.

Fedora Account System Username: athoscr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394250] Review Request: python-async_timeout - asyncio-compatible timeout context manager

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394250



--- Comment #4 from Athmane Madjoudj  ---
Thanks alot for reviewing, please find below the update.

Wrt underscore, IMHO it's only forbidden if it's a separator, in our case it's
part of the name, we have python modules and other packages that contain _ (I
myself have couple Apache httpd modules).

It can be checked with: 

dnf repoquery --qf '%{name}' python\*_\*
dnf repoquery --qf '%{name}' \*_\*

I'll submit pytest_aiohttp soon, but for now we need this pkg in order to fix
python3-aiohttp issues, which is breaking GNS3 (see blocked bugs)


SPEC: https://athmane.fedorapeople.org/pkgs/python-async_timeout.spec
SRPM:
https://athmane.fedorapeople.org/pkgs/python-async_timeout-1.1.0-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #1 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package contains BR: python2-devel or python3-devel
  Use python2-devel

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE.DejaVu is not marked as %license
  See:
  http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text

- freeorion is built with GiGi support (GG/src directory) and linked against
  libGiGi.so private library.
  GG (like util/XMLDoc.cpp) is provided under LGPLv2+ license 

- Unbundle font files please.

- /usr/lib64/freeorion is not owned

- CC-BY-SA-3.0 is not correct; use CC-BY-SA

- Main package and sub-package are inter-dependent.
  You can remove

Requires: %{name}%{?_isa} = %{version}-%{release}

  from freeorion-data

- Fix following errors

freeorion-data.noarch: E: wrong-script-interpreter
/usr/share/freeorion/default/python/tests/run_tests.py /usr/bin/env python2.7
freeorion-data.noarch: E: non-executable-script
/usr/share/freeorion/default/python/tests/run_tests.py 644 /usr/bin/env
python2.7

- Diff spec file in url and in SRPM (see rpmlint output)


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "LGPL (v2.1 or later) (with incorrect FSF address)", "GPL (v2
 or later)", "Unknown or generated", "LGPL (v2.1 or later) LGPL (v2.1
 or later) (with incorrect FSF address)", "BSL (v1.0)", "BSL",
 "zlib/libpng LGPL (v2.1 or later) LGPL (v2.1 or later) (with incorrect
 FSF address)". 547 files have unknown license. Detailed output of
 licensecheck in /home/sagitter/1391334-freeorion/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib64/freeorion
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib64/freeorion
[x]: %build honors applicable compiler flags or justifies otherwise.
[!]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: gtk-update-icon-cache is invoked in %postun and %posttrans if package
 contains icons.
 Note: icons in freeorion
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 122880 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package 

[Bug 1206883] Review Request: golang-github-opennota-urlesc - Package urlesc implements query escaping as per RFC 3986.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206883



--- Comment #5 from Athos Ribeiro  ---
Maybe it should Provide both golang-github-opennota-urlesc and
golang-github-PuerkitoBio-urlesc

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #20 from Antonio Trande  ---
(In reply to Antonio Trande from comment #19)
> (In reply to Tim Fenn from comment #18)
> > (In reply to Antonio Trande from comment #17)
> > > Why are you using coot-rdkit.patch ?
> > > 
> > 
> > It doesn't compile on F24 without it.
> 
> > However on rawhide it doesn't compile
> > with or without the patch, as it seems the latest rdkit that includes
> > 
> > GraphMol/MolDraw2D/MolDraw2D.h
> > 
> > From
> > 
> > /usr/include/rdkit/MolDraw2DCairo.h
> > 
> > Isn't working as it should-I'll try to dig more in to this.
> 
> Looks like f24-rdkit version is highter than rawhide-rdkit version:
> 
> >
> repoquery -l rdkit-devel --releasever=rawhide --disablerepo=rpmfusion* |grep
> MolDraw2D.h
> 
> /usr/include/rdkit/MolDraw2D.h
> /usr/include/rdkit/MolDraw2D.h
> >
> 
> >
> rpm -q --list rdkit-devel |grep MolDraw2D.h
> /usr/include/rdkit/GraphMol/MolDraw2D/MolDraw2D.h
> >
> 
> Your patch will work on f24 only; you need to use a conditional macro in
> this case.

Sorry, i chose wrong file.

$ repoquery -l rdkit-devel --releasever=rawhide |grep MolDraw2DCairo.h

/usr/include/rdkit/MolDraw2DCairo.h
/usr/include/rdkit/MolDraw2DCairo.h

$ rpm -q --list rdkit-devel |grep MolDraw2DCairo.h
/usr/include/rdkit/GraphMol/MolDraw2D/MolDraw2DCairo.h

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402

Antonio Trande  changed:

   What|Removed |Added

 CC||gia...@gmail.com



--- Comment #19 from Antonio Trande  ---
(In reply to Tim Fenn from comment #18)
> (In reply to Antonio Trande from comment #17)
> > Why are you using coot-rdkit.patch ?
> > 
> 
> It doesn't compile on F24 without it.

> However on rawhide it doesn't compile
> with or without the patch, as it seems the latest rdkit that includes
> 
> GraphMol/MolDraw2D/MolDraw2D.h
> 
> From
> 
> /usr/include/rdkit/MolDraw2DCairo.h
> 
> Isn't working as it should-I'll try to dig more in to this.

Looks like f24-rdkit version is highter than rawhide-rdkit version:

>
repoquery -l rdkit-devel --releasever=rawhide --disablerepo=rpmfusion* |grep
MolDraw2D.h

/usr/include/rdkit/MolDraw2D.h
/usr/include/rdkit/MolDraw2D.h
>

>
rpm -q --list rdkit-devel |grep MolDraw2D.h
/usr/include/rdkit/GraphMol/MolDraw2D/MolDraw2D.h
>

Your patch will work on f24 only; you need to use a conditional macro in this
case.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359402] Review Request: coot - crystallographic macromolecular building toolkit (unretire request )

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359402



--- Comment #18 from Tim Fenn  ---
(In reply to Antonio Trande from comment #17)
> Why are you using coot-rdkit.patch ?
> 

It doesn't compile on F24 without it. However on rawhide it doesn't compile
with or without the patch, as it seems the latest rdkit that includes

GraphMol/MolDraw2D/MolDraw2D.h

From

/usr/include/rdkit/MolDraw2DCairo.h

Isn't working as it should-I'll try to dig more in to this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Drop %gittag0, just specify the version in Version.

You have python-pysword (the main src package), and python3-pysword (the only
binary package). So there should be just on summary. Put it in Summary, drop
%sum, and use Summary: %summary later on.

%description makes no sense.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Python bindings to read Sword bible files directly

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-pysword - Read Sword |python-pysword - Python
   |files from Python   |bindings to read Sword
   ||bible files directly



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1328248] Review Request: python-pysword - Read Sword files from Python

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1328248

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl
Summary|Review Request: |Review Request:
   |Python-pysword.  As Python  |python-pysword - Read Sword
   |egg which allows python |files from Python
   |programs to read Sword  |
   |files   |



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1185665] Review Request: muttprint - pretty printing of mails for mutt (and other mailers)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1185665

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags||needinfo?(ma...@redhat.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279112] Review Request: kiss-fft - Fast Fourier Transform library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279112

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||val...@civ.zcu.cz
  Flags||needinfo?(val...@civ.zcu.cz
   ||)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1280155] Review Request: python-cregg - Utilities for running psychology experiments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280155

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||aal...@gmail.com
  Flags||needinfo?(aal...@gmail.com)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1185665] Review Request: muttprint - pretty printing of mails for mutt (and other mailers)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1185665



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Michael, are you still interested in packaging this?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1280155] Review Request: python-cregg - Utilities for running psychology experiments

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1280155

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
Adrian, are you still interested in packaging this? If yes, I'll review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279112] Review Request: kiss-fft - Fast Fourier Transform library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279112

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
František, are you still interested in packaging this? If yes, I'll review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1206883] Review Request: golang-github-opennota-urlesc - Package urlesc implements query escaping as per RFC 3986.

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1206883

Athos Ribeiro  changed:

   What|Removed |Added

 CC||athoscribe...@gmail.com



--- Comment #4 from Athos Ribeiro  ---
I Believe upstream changed the namespace [1]. Should the package name change
before a repo is created here?

[1] See https://github.com/PuerkitoBio/urlesc (opennota redirects here)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-Flask-Bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||yohangratero...@gmail.com



--- Comment #3 from Zbigniew Jędrzejewski-Szmek  ---
*** Bug 983843 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 983843] Review Request: python-flask-bootstrap - Twitter' s Bootstrap in your project, without any boilerplate code

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=983843

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 CC||zbys...@in.waw.pl
 Resolution|--- |DUPLICATE
  Flags|needinfo?(yohangraterol92@g |
   |mail.com)   |
Last Closed||2016-11-13 11:48:09



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
Six weeks without reply. There's a duplicate review that is more alive.

*** This bug has been marked as a duplicate of bug 1388908 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
The upstream decision to move to python3 only is quite unfortunate. But what's
done that's done. Adding a compat python2 package is reasonable.

The name is OK, it should be lowercase, in line with current guidelines.

I think you should:
- add a fat warning in the %description that this is a compat package and
should not be used for new stuff

- drop the documentation parts from the package: documentation is useful for
new stuff, and nobody should be using that
- replace the useless macros like %__sed with normal calls [see
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros].
- use %py2_build and %py2_install

The first point is "user visible", the remaining three are just cleanup, so
just a suggestion.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388908] Review Request: python-Flask-Bootstrap - Python flask bootstrap

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388908

Iryna Shcherbina  changed:

   What|Removed |Added

 CC||ishch...@redhat.com



--- Comment #2 from Iryna Shcherbina  ---
Hi David,

Please note that there is an open review request for the same package [0], but
it has not been active for a while. If you intend to continue the porting
effort for this package, please also check out the comments for that review
request as they also apply here, especially regarding fonts.

[0] https://bugzilla.redhat.com/show_bug.cgi?id=983843

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
That's fine. Just post the links to the other tickets here once you're back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349



--- Comment #15 from Zbigniew Jędrzejewski-Szmek  ---
What good is the stinky old xserver without flyingsaucersattack? :P

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
/usr/share/doc/pology/api/ should be moved into python2-pology, or even
possibly into pology-doc (as it describe the python API, iiuc).

Fedora-review says:
- Large documentation must go in a -doc subpackage. Large could be size
  (~1MB) or number of files.
  Note: Documentation size is 2457600 bytes in 111 files.
  See:
  http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation

OTOH, pology-bash-completion should be merged into main pology rpm. There's no
reason to have it separate, and it slows down the distribution and makes it's
harder to use when there's too many packages.

Rpmlint
---
Checking: pology-0.12-2.fc26.noarch.rpm
  python2-pology-0.12-2.fc26.noarch.rpm
  pology-bash-completion-0.12-2.fc26.noarch.rpm
  pology-0.12-2.fc26.src.rpm
pology.noarch: W: no-manual-page-for-binary poascribe
pology.noarch: W: no-manual-page-for-binary poepatch
pology.noarch: W: no-manual-page-for-binary porewrap
pology.noarch: W: no-manual-page-for-binary normalize-aspell-word-list
pology.noarch: W: no-manual-page-for-binary pomtrans
pology.noarch: W: no-manual-page-for-binary poselfmerge
pology.noarch: W: no-manual-page-for-binary pohybdl
pology.noarch: W: no-manual-page-for-binary traplint
pology.noarch: W: no-manual-page-for-binary posieve
pology.noarch: W: no-manual-page-for-binary posummit
pology.noarch: W: no-manual-page-for-binary poediff
python2-pology.noarch: W: no-documentation
pology-bash-completion.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 13 warnings.

That's OK, and the last two warnings should go away if packages are rearranged.

Everything looks good, but I'm not setting the flag yet. Please rearrange the
subpackages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1270525] Review Request: maxmind-db - Reader for the MaxMind DB Database Format

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1270525
Bug 1270525 depends on bug 1366713, which changed state.

Bug 1366713 Summary: Review Request: nunit2 - unit-testing framework for 
.Net/mono
https://bugzilla.redhat.com/show_bug.cgi?id=1366713

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1366713] Review Request: nunit2 - unit-testing framework for .Net/ mono

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1366713

Raphael Groner  changed:

   What|Removed |Added

 Status|MODIFIED|CLOSED
 Resolution|--- |RAWHIDE
Last Closed|2016-10-03 02:56:41 |2016-11-13 10:20:10



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376867] Review Request: python3-pycurl - Python interface to libcurl for Python 3

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376867

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #4 from Raphael Groner  ---
> %changelog
> * Fri Sep 16 2016 Orion Poplawski  - 7.43.0-3
> - EPEL7 version

Shouldn't this request be with Product Fedora EPEL? There's already
python-pycurl in Fedora (with python2 and python3 subpackages).

(In reply to Tim Orling from comment #1)
> I am also willing to consider adding to EPEL6.

https://fedoraproject.org/wiki/EPEL:Packaging?rd=Packaging:EPEL#EPEL_6_and_earlier

(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> SRPM gives 404 ;(

Same here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #10 from Raphael Groner  ---
(In reply to Orion Poplawski from comment #0)
> This in an EPEL7 only package.

Shouldn't this request be with Product Fedora EPEL?

(In reply to Tim Orling from comment #9)
> I am also willing to consider adding to EPEL6.

https://fedoraproject.org/wiki/EPEL:Packaging?rd=Packaging:EPEL#EPEL_6_and_earlier

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376940] Review Request: python3-urllib3 - Python 3 HTTP library with thread-safe connection pooling and file post

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376940

Raphael Groner  changed:

   What|Removed |Added

 CC||projects...@smart.ms



--- Comment #2 from Raphael Groner  ---
(In reply to Orion Poplawski from comment #0)
> This is an EPEL7 only package.

Shouldn't this request be with Product Fedora EPEL?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1385856] Review Request: log4shib - C++ logging library for Shibboleth (OpenSAML)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1385856

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(walter.pete@yande
   ||x.com)



--- Comment #3 from Raphael Groner  ---
Pete, did you have a chance to run fedora-review?

It would be great if we can achieve some progress with the Shibboleth stack in
Fedora.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1227981] Review Request: budget - Your own personal financial assistant

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1227981

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Blocks||201449 (FE-DEADREVIEW)
 Resolution|--- |NOTABUG
Last Closed||2016-11-13 09:54:40



--- Comment #13 from Raphael Groner  ---
Closing.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1197517] Review Request: elmon - Performance monitoring tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1197517

Raphael Groner  changed:

   What|Removed |Added

  Flags||needinfo?(pa...@hubbitus.in
   ||fo)



--- Comment #20 from Raphael Groner  ---
F25: This update has reached 3 days in testing and can be pushed to stable now
if the maintainer wishes

F24: This update has reached 7 days in testing and can be pushed to stable now
if the maintainer wishes.

Pavel, please do so.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #20 from Jonny Heggheim  ---
(In reply to Samuel Gyger from comment #19)
> If this is how it should be, than I think working with upstream is the way
> to go. The author is very responsive, at least in my experience.

I just sent him an email and asked if we could find a solution.

Btw, Debian stores the locales in
/usr/lib/python2.7/dist-packages/electrum/locale for their Electrum package

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838



--- Comment #8 from Dhanesh B. Sabane  ---
Fixed the description.

*SPEC URL: https://pagure.io/rpm-packaging/blob/master/f/SPECS/python-mlpy.spec
*SRPM URL:
https://pagure.io/rpm-packaging/blob/master/f/SRPMS/python-mlpy-3.5.0-4.fc24.src.rpm

I may not be able to review other packages for a while now because I'm leaving
on vacation for the rest of the month
(https://apps.fedoraproject.org/calendar/vacation/#m4937). I'll start reviewing
packages as soon as I get back. You may close the ticket and we'll revive it
again after I return.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349

Hans de Goede  changed:

   What|Removed |Added

  Flags|needinfo?(hdegoede@redhat.c |
   |om) |



--- Comment #14 from Hans de Goede  ---
(In reply to Raphael Groner from comment #13)
> Are you still interested in this package? Can you provide some builds,
> please?

Yes, patience please it has been only 10 days, and I did have other stuff to-do
like fixing a bunch of xserver-1.19 crashes so that F25 can go out the door...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1303349] Review Request: flyingsaucersattack - Shoot down the attacking UFOs and to save the city

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1303349

Raphael Groner  changed:

   What|Removed |Added

 Status|NEW |POST
 CC||hdego...@redhat.com,
   ||projects...@smart.ms
 Whiteboard||AwaitingSubmitter
  Flags||needinfo?(hdegoede@redhat.c
   ||om)



--- Comment #13 from Raphael Groner  ---
Are you still interested in this package? Can you provide some builds, please?

Otherwise, please close this bug.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389985] Review Request: http-builder - HTTP client framework for Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389985



--- Comment #3 from gil cattaneo  ---
Spec URL: https://gil.fedorapeople.org/http-builder.spec
SRPM URL: https://gil.fedorapeople.org/http-builder-0.7.2-1.fc24.src.rpm
- Cleanup spec file

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16433732

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394147] Review Request: mpg123 - mp3 audio playback library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394147

Nicolas Chauvet (kwizart)  changed:

   What|Removed |Added

 CC||kwiz...@gmail.com



--- Comment #22 from Nicolas Chauvet (kwizart)  ---
I don't get why Supplements is relevant here ?
You will get mpg123-plugins-pulseaudio as soon as you get pulseaudio. Even if
you don't have mpg123. Same for portaudio.

thx for moving the package here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655



--- Comment #3 from Parag Nemade  ---
Updated to fix comment#1 issues

Spec URL: http://pnemade.fedorapeople.org/pology.spec
SRPM URL: http://pnemade.fedorapeople.org/pology-0.12-2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org