[Bug 1395522] Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522

Yunying Sun  changed:

   What|Removed |Added

 CC||yunying@intel.com



--- Comment #3 from Yunying Sun  ---
> Source0:  http://sourceforge.net/projects/sng/files/sng-1.1.0.tar.gz
Is it better to use %{name}/%{version} instead of fixed strings in the Source
field?

I'm a new packager with two packages under review: bug 1369708 and 1369720.
Appreciate if a review swap is possible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969



--- Comment #6 from Fedora Update System  ---
python-pluginbase-0.5-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-f3acd7d879

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969



--- Comment #5 from Fedora Update System  ---
python-pluginbase-0.5-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-838efd8052

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376035] Review Request: modulemd - Module metadata manipulation library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376035

Parag AN(पराग)  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #10 from Parag AN(पराग)  ---

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Few things I want to note here

1) python_provide macro is not used which I think is available on all Fedora as
well as EPEL6+

2) with the new upstream release I can't see modlint now

3) I don't know why following macros are need to be explicitly added to spec
file which are already available by python2-rpm-macros package.
%{!?__python2: %global __python2 /usr/bin/python2}
%{!?py2_build: %global py2_build %{expand: CFLAGS="%{optflags}" %{__python2}
setup.py %{?py_setup_args} build --executable="%{__python2} -s"}}
%{!?py2_install: %global py2_install %{expand: CFLAGS="%{optflags}"
%{__python2} setup.py %{?py_setup_args} install -O1 --skip-build --root
%{buildroot}}}

4) there should be some uniformity needed for python2 and python3 macros. I see
above 3 lines are defined in spec file for python2 but the same is not there
for python3.

I think as python2/3 macros are already available, good to drop them from spec
file.


= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated". 14 files have
 unknown license. Detailed output of licensecheck in
 /home/parag/1376035-modulemd/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the 

[Bug 1395522] Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522



--- Comment #2 from Zbigniew Jędrzejewski-Szmek  ---
Thanks for the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395522] Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522

Parag AN(पराग)  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||panem...@gmail.com
   Assignee|nob...@fedoraproject.org|panem...@gmail.com
  Flags||fedora-review+



--- Comment #1 from Parag AN(पराग)  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc grep make
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

==> This can be ignored as we would like to add all the Build dependencies.

- Good to fix following rpmlint warning
sng.src:10: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line 10)

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "Unknown or generated", "zlib/libpng". 26
 files have unknown license. Detailed output of licensecheck in
 /home/parag/1395522-sng/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see 

[Bug 1386938] Review Request: libprelude - Prelude Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386938



--- Comment #10 from Zbigniew Jędrzejewski-Szmek  ---
(In reply to Thomas Andrejak from comment #9)
> - For soname at the end of the subpackage name, this is what other linux
> distribution required, that's why I do it.
Yes, but Fedora doesn't work this way. In Fedora, there normally just one
version of a given library. Everybody upgrades at once. Hence no suffix.

> It make you able to install
> multiple libprelude versions in parallel. Do I really have to make only one
> subpackage with all ".so" files and do not precise the soname in the
> subpackage name ?
Yes.

> - Can you tell which macro you are talking about ?
I think the following macros are unneeded:
%global libname libprelude%{major}
%global libcpp  libpreludecpp%{cppmajor}
%global libnamedevellibprelude-devel


> - %description is required when you use "%package -n"
OK, let's leave that one for later.

Instead, please explain the difference between package %{libname} and 
package %{libcpp} (see how those macros make everything more obfuscated ;)).
Is there a reason why the second is not merged with the first?

> Thanks for sponsoring :) I will do some reviews this week
Great.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655



--- Comment #7 from Parag Nemade  ---
Thank you for this package review. 

Yes the only recent released tarball is from 2014 ;-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395522] New: Review Request: sng - Lossless editing of PNGs via a textual representation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395522

Bug ID: 1395522
   Summary: Review Request: sng - Lossless editing of PNGs via a
textual representation
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: zbys...@in.waw.pl
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://in.waw.pl/~zbyszek/fedora/sng.spec
SRPM URL: http://in.waw.pl/~zbyszek/fedora/sng-1.1.0-1.fc26.src.rpm
Description:
SNG (Scriptable Network Graphics) is a minilanguage designed
specifically to represent the entire contents of a PNG (Portable
Network Graphics) file in an editable form. Thus, SNGs representing
elaborate graphics images and ancillary chunk data can be readily
generated or modified using only text tools.

SNG is implemented by a compiler/decompiler called sng that losslessly
translates between SNG and PNG.

This will be used by diffoscope.

Fedora Account System Username: zbyszek
Koji rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=16469919

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #10 from Nathaniel McCallum  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #9)
> I saw the that one of the files is suid, so I decided to have a look
> at the code...
> 
> Two issues pop out:
> 1. memset(key, 0, strlen(key)); is going to be optimized away. If you
> are doing that to decrease chances of the key leaking out, this will
> not work. See
> https://github.com/systemd/systemd/blob/
> 493fd52f1ada36bfe63301d4bb50f7fd2b38c670/src/basic/string-\
> util.c#L834
> for a way (cribbed from openssl), for a way around that.
> 
> 2. I don't think using the relative path like as in
> snprintf(path, pathl, "%s/../bin/clevis-decrypt", dirname(tmp))
> is safe. If the user is able to call the binary under a different
> path where they control the ../bin prefix, it will allow them to call
> arbitrary binary as root.

The clevis-decrypt binary is not executed as root. We drop privileges much
earlier than that. See:
https://github.com/latchset/clevis/blob/master/clevis-luks-udisks2.c#L384

However, your concern is still valid because we pass information obtained as
root to that process. So it still represents a security concern. I'd love to
chat with you on IRC to discuss some of my concerns with my own code if you
have time.

> I don't think it's directly exploitable in
> the default configuration, but it's not hard to contrive some scenario
> where it would be:
> 
> - fs.protected_hardlinks=0
>   This is the kernel default, which is overridden by systemd-sysctl
>   after boot.  If systemd-sysctl is prevented from running, for
>   example by broken configuration, clevis-luks-udisks2 becomes
>   immediately exploitable a la CVE-2009-1894.
> 
> - some scenario where the fs containing the suid binary is mounted
>   below a user writable directory (for example the administrator
>   temporarily mounts the fs under /var/tmp for backup purposes).
> 
> - some manipulation using mount namespaces.
> 
> I don't see an exploit, but relying on the binary always being visible
> only under the correct path seems very brittle. It'd seem much better
> to substitute the real absolute path during build.

Yeah, I agree. The main reason I haven't done this is because it makes in-tree
unit testing (after build, before install) more difficult. Suggestions welcome.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

  Flags||fedora-review+



--- Comment #6 from Zbigniew Jędrzejewski-Szmek  ---
+ package name is OK
+ license is acceptable (GPLv3+ and BSD)
+ license is specified correctly
+ builds and installs OK
+ python macros are used
+ %python_provide is used
+ fedora-review is happy
+ latest version (even if it's not very fresh ;))

Rpmlint
---
Checking: pology-0.12-3.fc26.noarch.rpm
  python2-pology-0.12-3.fc26.noarch.rpm
  pology-doc-0.12-3.fc26.noarch.rpm
  pology-0.12-3.fc26.src.rpm
pology.noarch: W: no-manual-page-for-binary poediff
pology.noarch: W: no-manual-page-for-binary porewrap
... etc ...
python2-pology.noarch: W: no-documentation
4 packages and 0 specfiles checked; 0 errors, 12 warnings.

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #9 from Zbigniew Jędrzejewski-Szmek  ---
I saw the that one of the files is suid, so I decided to have a look
at the code...

Two issues pop out:
1. memset(key, 0, strlen(key)); is going to be optimized away. If you
are doing that to decrease chances of the key leaking out, this will
not work. See
https://github.com/systemd/systemd/blob/493fd52f1ada36bfe63301d4bb50f7fd2b38c670/src/basic/string-\
util.c#L834
for a way (cribbed from openssl), for a way around that.

2. I don't think using the relative path like as in
snprintf(path, pathl, "%s/../bin/clevis-decrypt", dirname(tmp))
is safe. If the user is able to call the binary under a different
path where they control the ../bin prefix, it will allow them to call
arbitrary binary as root. I don't think it's directly exploitable in
the default configuration, but it's not hard to contrive some scenario
where it would be:

- fs.protected_hardlinks=0
  This is the kernel default, which is overridden by systemd-sysctl
  after boot.  If systemd-sysctl is prevented from running, for
  example by broken configuration, clevis-luks-udisks2 becomes
  immediately exploitable a la CVE-2009-1894.

- some scenario where the fs containing the suid binary is mounted
  below a user writable directory (for example the administrator
  temporarily mounts the fs under /var/tmp for backup purposes).

- some manipulation using mount namespaces.

I don't see an exploit, but relying on the binary always being visible
only under the correct path seems very brittle. It'd seem much better
to substitute the real absolute path during build.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382655] Review Request: pology - CLI tools for PO files processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382655



--- Comment #5 from Parag Nemade  ---
Updated to fix comment#4 issues

Spec URL: http://pnemade.fedorapeople.org/pology.spec
SRPM URL: http://pnemade.fedorapeople.org/pology-0.12-3.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #8 from Zbigniew Jędrzejewski-Szmek  ---
There's nothing in the guidelines that says that desktop file validation should
not be performed in this case. This file is installed into the same directory
as many other .desktop files, so it'll be loaded by various tools, so I think
it should be validated. desktop-file-validate prints no warnings for
clevis-luks-udisks2.desktop, so I don't see any reason to not validate it
according to the guidelines.

> The clevis package provides basic encryption/decryption policy support. Users 
> can use this directly. But most commonly, it will be used as a building block 
> for other packages, [for example to automatically decrypt LUKS volumes using 
> a passphrase received over the network, including the root volume, see 
> clevis-lukus and clevis-dracut packages].

OK, great, I think that if this is appended to current %description, it gives a
reasonable idea what this package does.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #22 from Fedora Update System  ---
python-evdev-0.6.1-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c33638448e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #21 from Fedora Update System  ---
python-evdev-0.6.1-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-76396fd739

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #3 from Stephen Gallagher  ---
Created attachment 1221004
  --> https://bugzilla.redhat.com/attachment.cgi?id=1221004=edit
Mock failure during fedora-review of python-avocado-43.0-3

This is still failing to build intermittently in mock. See attachment.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #12 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el7 has been pushed to the Fedora EPEL 7 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d1b6e9d1ee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #11 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el5 has been pushed to the Fedora EPEL 5 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-114b48bfab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387447] Review Request: php-sentry - PHP client for Sentry

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387447

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-15 18:22:19



--- Comment #21 from Fedora Update System  ---
php-sentry-0.22.0-1.fc24 has been pushed to the Fedora 24 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392227] Review Request: pidgin-groupchat-typing-notifications - Adds typing notifications for group chats in Pidgin

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392227

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-15 18:22:33



--- Comment #12 from Fedora Update System  ---
pidgin-groupchat-typing-notifications-0-2.git33a75f9.fc24 has been pushed to
the Fedora 24 stable repository. If problems still persist, please make note of
it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 879740] Review Request: python-evdev - bindings for the linux input handling subsystem

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=879740



--- Comment #20 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-evdev

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #2 from Merlin Mathesius  ---
Updated with additional patch to skip buggy selftest causing builds to
occasionally fail as discussed in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-3.fc24.src.rpm
COPR build URL:
https://copr.fedoraproject.org/coprs/merlinm/avocado/build/477093/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pluginbase

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #7 from Nathaniel McCallum  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> I should have pasted a link to the guidelines:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
> You must either use desktop-file-install of desktop-file-validate.

As I stated above, this is not a usual .desktop file. It is not an application,
but a user session daemon. I do not believe these requirements apply in this
situation.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #6 from Nathaniel McCallum  ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #5)
> Also, I'm still stumped a bit by the %description... Imagine that you're a
> user who looks and 'dnf info' output:
> Clevis is a framework for automated decryption. It allows you to encrypt
> data using sophisticated unlocking policies which enable decryption to
> occur automatically.
> 
> It doesn't say *what* is being decrypted. It also gives no hint what those
> "sophisticated unlocking policies" might be. A package should not be a black
> box... Please make this a bit easier to understand.

Anything is being encrypted/decrypted. You're asking for more specificity in
the description of a subpackage that is the enabling technology for other
subpackages. The clevis package provides basic encryption/decryption policy
support. Users can use this directly. But most commonly, it will be used as a
building block for other packages.

For example, you can install clevis-dracut (which depends on clevis and
clevis-luks) to perform automated root volume decryption.

Simply put, the clevis package is the core functionality and is intentionally
vague.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #29 from Jonny Heggheim  ---
(In reply to gil cattaneo from comment #28)
> Approved, maybe we could wait the upstream reply @

Thanks, I will wait for reply from upstream

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] New: Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396

Bug ID: 1395396
   Summary: Review Request: python-sphinx_gallery - Sphinx
extension to automatically generate an examples
gallery
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: or...@cora.nwra.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery-0.1.5-1.fc26.src.rpm
Description:
A Sphinx extension that builds an HTML version of any Python script and puts
it into an examples gallery.

Fedora Account System Username: orion

http://koji.fedoraproject.org/koji/taskinfo?taskID=16466702

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #5 from Zbigniew Jędrzejewski-Szmek  ---
Also, I'm still stumped a bit by the %description... Imagine that you're a user
who looks and 'dnf info' output:
Clevis is a framework for automated decryption. It allows you to encrypt
data using sophisticated unlocking policies which enable decryption to
occur automatically.

It doesn't say *what* is being decrypted. It also gives no hint what those
"sophisticated unlocking policies" might be. A package should not be a black
box... Please make this a bit easier to understand.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
I should have pasted a link to the guidelines:
https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
You must either use desktop-file-install of desktop-file-validate.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389695] Review Request: python-wcsaxes - A Python framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389695



--- Comment #4 from Sergio Pascual  ---
I'm considering to package pytest-mpl before this one

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #3 from Nathaniel McCallum  ---
I'm not precisely sure what you want me to do with the .desktop file. This is
not a general purpose application but a user session daemon.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962



--- Comment #2 from Nathaniel McCallum  ---
Spec:
http://copr-dist-git.fedorainfracloud.org/cgit/npmccallum/clevis/clevis.git/plain/clevis.spec
SRPM:
https://copr-be.cloud.fedoraproject.org/results/npmccallum/clevis/fedora-rawhide-x86_64/00477086-clevis/clevis-1-1.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084

gil cattaneo  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #28 from gil cattaneo  ---
(In reply to Jonny Heggheim from comment #27)
> (In reply to gil cattaneo from comment #26)
> > Please, ask to upstream to confirm the licensing of code and/or content/s,
> > and to add license headers

Approved, maybe we could wait the upstream reply @

> https://github.com/spesmilo/electrum/issues/2041

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1187084] Review Request: electrum - a lightweight Bitcoin client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1187084



--- Comment #27 from Jonny Heggheim  ---
(In reply to gil cattaneo from comment #26)
> Please, ask to upstream to confirm the licensing of code and/or content/s,
> and to add license headers

https://github.com/spesmilo/electrum/issues/2041

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395341] Review Request: python-zeroconf - A Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395341

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354



--- Comment #1 from Athos Ribeiro  ---
License: There is no LICENSE file. The license text is a section in the README
file. It would be really nice to ask upstream to include a LICENSE file in the
project (this is not a blocker)

Tests: There is a test suite in colorlog/tests. Is there any reason for not
having a %check section in the package?

The package does not own its own directory: %{python3_sitelib}/%{srcname} and
others:
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages/colorlog/__pycache__, /usr/lib/python2.7/site-
 packages/colorlog, /usr/lib/python3.5/site-packages/colorlog

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[-]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[!]: Package requires other packages for directories it uses.
 Note: No known owner of /usr/lib/python2.7/site-packages/colorlog,
 /usr/lib/python3.5/site-packages/colorlog, /usr/lib/python3.5/site-
 packages/colorlog/__pycache__
[!]: Package must own all directories that it creates.
 Note: Directories without known owners: /usr/lib/python3.5/site-
 packages/colorlog/__pycache__, /usr/lib/python2.7/site-
 packages/colorlog, /usr/lib/python3.5/site-packages/colorlog
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 40960 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[!]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[!]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest 

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354

Athos Ribeiro  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||athoscribe...@gmail.com
   Assignee|nob...@fedoraproject.org|athoscribe...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395368] New: Review Request: golang-github-spf13-nitro - Quick and easy performance analyzer library for golang

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395368

Bug ID: 1395368
   Summary: Review Request: golang-github-spf13-nitro - Quick and
easy performance analyzer library for golang
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: athoscribe...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://athoscr.fedorapeople.org/packaging/golang-github-spf13-nitro.spec
SRPM URL:
https://athoscr.fedorapeople.org/packaging/golang-github-spf13-nitro-0-0.1.git24d7ef3.fc26.src.rpm
Koji build:

Description: Nitro is a quick and easy performance analyzer library for golang.
It is useful for comparing A/B against different drafts of functions or
different functions.

Fedora Account System Username: athoscr

Note that the README file ha a changelog section describing versions, but there
are no tags nor branches in the repository, so I prefered not specifying a
version for the package, basing it on the package releases and upstream
commits, as other golang packages.

upstream ships no test suite, so there's no unit-test package nor a %check
section in the spec file.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394962] Review Request: clevis - Automated decryption framework

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394962

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||zbys...@in.waw.pl
   Assignee|nob...@fedoraproject.org|zbys...@in.waw.pl
  Flags||fedora-review?



--- Comment #1 from Zbigniew Jędrzejewski-Szmek  ---
%description
Clevis is a framework for automated decryption.
→ great, but please provide some detail here. Automated decryption of what? Is
this another jack the ripper clone?

make %{?_smp_mflags} V=1
make %{?_smp_mflags} check
→ %make_build V=1
  %make_build check

rm -rf $RPM_BUILD_ROOT
→ please no
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

Fedora review says:
Issues:
===
- Package installs a %{name}.desktop using desktop-file-install or desktop-
  file-validate if there is such a file.
- Package uses hardened build flags if required to.
  Note: suid files: clevis-luks-udisks2 and not %global _hardened_build
  See:
 
http://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Compiler_flags

rpmlint:
clevis-udisks2.x86_64: W: non-conffile-in-etc
/etc/xdg/autostart/clevis-luks-udisks2.desktop

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #33 from Fedora Update System  ---
php-fedora-autoloader-0.2.1-2.el6 has been pushed to the Fedora EPEL 6 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #6 from Antonio Trande  ---
(In reply to Ryan H. Lewis (rhl) from comment #5)
> Thanks Antonio, I am adjusting the raw spec file, located in the repository
> itself: 
> 
> Spec URL:
> https://github.com/elemental/Elemental/blob/master/redhat/elemental.spec
> 
> The copr builds happen every time we push to master:
> https://copr.fedorainfracloud.org/coprs/rhl/elemental/build/477011/

When the package is ready, post links to the files.
(This is the raw file
https://raw.githubusercontent.com/elemental/Elemental/master/redhat/elemental.spec)
> 
> I have sonamed libEl with the major version (and issued a PR for this, since
> I don't knwo what other affects this may have) and disabled BUILD_METIS
> (even though it wasn't building), and added gmp-devel as a build dependency.
> 
> I've renamed the python subpackges to python2-elemental-openmpi and added a
> corresponding mpich one.
> 
> I believe I have set the compiler flags correctly now, and moved the
> binaries/libraries to the correct locations. We will see what happens once
> the above build completes.

Do you really need to compile examples (bin/examples-*) and tests files
(bin/tests-*)? If yes, those files should be packaged separately.

Also, you can perform 'make test' for testing Elemental.
http://libelemental.org/documentation/dev/build.html#testing-the-c-11-installation

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] New: Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354

Bug ID: 1395354
   Summary: Review Request: python-colorlog - A colored formatter
for the python logging module
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-colorlog.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-colorlog-2.7.0-1.fc24.src.rpm

Project URL: https://github.com/borntyping/python-colorlog

Description:
colorlog.ColoredFormatter is a formatter for use with Python's logging
module that outputs records using terminal colors.

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16465940

rpmlint output:
[fab@laptop016 SRPMS]$ rpmlint python*-colorlog*
python-colorlog.src: W: spelling-error Summary(en_US) formatter -> formatted,
for matter, for-matter
python-colorlog.src: W: spelling-error %description -l en_US ColoredFormatter
-> Formatted
python-colorlog.src: W: spelling-error %description -l en_US formatter ->
formatted, for matter, for-matter
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

[fab@laptop016 noarch]$ rpmlint python*-colorlog-*
python2-colorlog.noarch: W: spelling-error Summary(en_US) formatter ->
formatted, for matter, for-matter
python2-colorlog.noarch: W: spelling-error %description -l en_US
ColoredFormatter -> Formatted
python2-colorlog.noarch: W: spelling-error %description -l en_US formatter ->
formatted, for matter, for-matter
python3-colorlog.noarch: W: spelling-error Summary(en_US) formatter ->
formatted, for matter, for-matter
python3-colorlog.noarch: W: spelling-error %description -l en_US
ColoredFormatter -> Formatted
python3-colorlog.noarch: W: spelling-error %description -l en_US formatter ->
formatted, for matter, for-matter
2 packages and 0 specfiles checked; 0 errors, 6 warnings.

Fedora Account System Username: fab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #10 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.fc23 has been pushed to the Fedora 23 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-49c2e0da1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389016] Review Request: libxsmm - Library for small matrix-matrix multiplications on Intel x86_64 (e.g. for cp2k)

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389016



--- Comment #35 from Fedora Update System  ---
libxsmm-1.5.2-2.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-041c46cdc9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #5 from Ryan H. Lewis (rhl)  ---
Thanks Antonio, I am adjusting the raw spec file, located in the repository
itself: 

Spec URL:
https://github.com/elemental/Elemental/blob/master/redhat/elemental.spec

The copr builds happen every time we push to master:
https://copr.fedorainfracloud.org/coprs/rhl/elemental/build/477011/

I have sonamed libEl with the major version (and issued a PR for this, since I
don't knwo what other affects this may have) and disabled BUILD_METIS (even
though it wasn't building), and added gmp-devel as a build dependency.

I've renamed the python subpackges to python2-elemental-openmpi and added a
corresponding mpich one.

I believe I have set the compiler flags correctly now, and moved the
binaries/libraries to the correct locations. We will see what happens once the
above build completes.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395341] Review Request: python-zeroconf - A Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395341

Fabian Affolter  changed:

   What|Removed |Added

  Alias||python-zeroconf



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395341] New: Review Request: python-zeroconf - A Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395341

Bug ID: 1395341
   Summary: Review Request: python-zeroconf - A Python Multicast
DNS Service Discovery Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: m...@fabian-affolter.ch
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-zeroconf.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-zeroconf-0.17.6-1.fc24.src.rpm

Project URL: https://github.com/jstasiak/python-zeroconf

Description:
A pure Python Multicast DNS Service Discovery Library (Bonjour/Avahi
compatible).

Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16465405

rpmlint output:
[fab@laptop016 SRPMS]$ rpmlint python*-zero*
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

[fab@laptop016 noarch]$ rpmlint python*-zero*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Fedora Account System Username: fab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #9 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el6 has been pushed to the Fedora EPEL 6 testing
repository. If problems still persist, please make note of it in this bug
report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7925ac1d3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1279112] Review Request: kiss-fft - Fast Fourier Transform library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1279112



--- Comment #18 from Fedora Update System  ---
kiss-fft-1.3.0-1.el6, qm-dsp-1.7.1-1.el6, qm-vamp-plugins-1.7.1-1.el6 has been
pushed to the Fedora EPEL 6 testing repository. If problems still persist,
please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-a7e9c92ffb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899



--- Comment #14 from Fedora Update System  ---
libdirq-0.4-1.el6 has been pushed to the Fedora EPEL 6 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7a13703365

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389695] Review Request: python-wcsaxes - A Python framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389695



--- Comment #3 from Iryna Shcherbina  ---
Hi Sergio,

Is there still an interest in adding this package to Fedora?
Let me know if you need any help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #6 from Fedora Update System  ---
python-wcsaxes-0.9-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-884992496e

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183



--- Comment #5 from Fedora Update System  ---
perl-Text-VCardFast-0.09-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-02d23ebb5a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183



--- Comment #4 from Fedora Update System  ---
perl-Text-VCardFast-0.09-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-d21eb3c9e9

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #7 from Fedora Update System  ---
python-wcsaxes-0.9-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-8b93ef0700

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183

Petr Pisar  changed:

   What|Removed |Added

   Fixed In Version|perl-Text-VCardFast-0.09-1. |perl-Text-VCardFast-0.09-2.
   |fc26|fc26



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #4 from Antonio Trande  ---
Take a look to proposed 'Build Modes':
http://libelemental.org/documentation/0.85/build.html#build-modes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971



--- Comment #3 from Antonio Trande  ---
- Please, post direct links to 'raw' spec file and srpm.

- MPI compilers are not correct: you are using always '/usr/bin/c++'. You have
to set CMAKE_CXX_COMPILER:FILEPATH option at least inside MPI build
directories.

'lib*_openmpi' and 'lib*_mpich' libraries must be installed under
'/usr/lib/openmpi/lib' and '/usr/lib/mpich/lib' respectively. Like them, even
binary files must be installed under '/usr/lib/openmpi/bin' and
'/usr/lib/mpich/bin' respectively.
See http://fedoraproject.org/wiki/Packaging:MPI

- If 

// Build METIS
BUILD_METIS:BOOL=ON

means build Metis from source, you can disable it.

- CMake looks searching for GMP, too.

-- Could NOT find GMP (missing:  GMP_INCLUDES GMP_LIBRARIES GMP_VERSION_OK)
(Required is at least version "6.0.0")

- Python package name looks better like python2-elemental

- Libraries are not "sonamed"; could be a good suggestion for upstream.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #8 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-d1b6e9d1ee

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #6 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el5 has been submitted as an update to Fedora EPEL 5.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-114b48bfab

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #5 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.fc23 has been submitted as an update to Fedora 23.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-49c2e0da1c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #7 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.el6 has been submitted as an update to Fedora EPEL 6.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-7925ac1d3c

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #4 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4d6f56c103

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395121] Review Request: perl-Crypt-IDEA - Perl interface to IDEA block cipher

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395121



--- Comment #3 from Fedora Update System  ---
perl-Crypt-IDEA-1.10-5.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e85db2ba89

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394969] Review Request: python-pluginbase - A support library for building plugins systems

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394969

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Athos Ribeiro  ---
Issues were fixed.

Package looks good to me. Approved!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #1 from Merlin Mathesius  ---
Updates made based on comments and discussions in #fedora-modularity.

Spec URL: https://merlinm.fedorapeople.org/python-avocado.spec
SRPM URL: https://merlinm.fedorapeople.org/python-avocado-43.0-2.fc24.src.rpm
COPR build URL:
https://copr.fedorainfracloud.org/coprs/merlinm/avocado/build/476977/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #5 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-wcsaxes

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #4 from Christian Dersch  ---
Again, thank you very much :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Antonio Trande  ---
Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #2 from Christian Dersch  ---
Spec URL: https://lupinix.fedorapeople.org/review/python-wcsaxes.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-wcsaxes-0.9-2.fc25.src.rpm

Thank you very much for your quick review!


- ASL license is not correct. Use 'ASL 2.0'

==> Fixed

- Unexpanded-macro %description

==> Fixed

- Hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo

==> Fixed by removing this file, does not contain any useful information
anyway.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1386735] Review Request: php-fedora-autoloader - Fedora Autoloader

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1386735



--- Comment #32 from Fedora Update System  ---
php-fedora-autoloader-0.2.1-2.el7 has been pushed to the Fedora EPEL 7 stable
repository. If problems still persist, please make note of it in this bug
report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273



--- Comment #1 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

- ASL license is not correct. Use 'ASL 2.0'

- Unexpanded-macro %description

- Hidden-file-or-dir /usr/share/doc/python3-wcsaxes-doc/html/.buildinfo

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 103 files have unknown license.
 Detailed output of licensecheck in /home/sagitter/1395273-python-
 wcsaxes/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
 must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python2-wcsaxes (description), python3-wcsaxes
 (description)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 4 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 python2-wcsaxes , python3-wcsaxes , python3-wcsaxes-doc
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if 

[Bug 1394240] Review Request: perl-XML-Fast - Simple and very fast XML to hash conversion

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394240



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-XML-Fast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Text-VCardFast-0.09-1.
   ||fc26



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository. I upgraded the package to 0.09
version.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389971] Review Request: Elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1363935] Review Request: python-yara - Python binding for the YARA pattern matching tool

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1363935



--- Comment #8 from Michal Ambroz  ---
Thank you Fabian.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Antonio Trande  changed:

   What|Removed |Added

 CC||anto.tra...@gmail.com
 Blocks||177841 (FE-NEEDSPONSOR)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387250] Review Request: python-lazr-smtptest - Test framework for SMTP-based applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387250

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387250] Review Request: python-lazr-smtptest - Test framework for SMTP-based applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387250



--- Comment #5 from Fedora Update System  ---
python-lazr-smtptest-2.0.3-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-54be67dd74

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394267] Review Request: perl-NNTPClient - Perl 5 module to talk to NNTP (RFC977) server

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394267



--- Comment #1 from Athos Ribeiro  ---
fedora-review complains about BuildRequires make and findutils, since those are
already included in the current minimum build environment.

Guidelines are vague on those since "RPM deps may change" and the definition of
"basic shell scripts" is not clear. So I believe those are up to the packager.

Package name: Is there a reason for this package not being named
perl-News-NNTPClient?

License: There is no license text other than a note in the README file and in
the module itself, saying it can be redistributed or modified under the same
terms of Perl itself. It would be nice to ask upstream to distribute a LICENSE
file as well (not a blocker).

Tests: Some tests on %check are failing, apparently, they rely on a running
news server. Would you work on it, so it doesn't run these tests?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394139] Review Request: perl-Mail-IMAPTalk - IMAP client interface with lots of features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394139



--- Comment #5 from Fedora Update System  ---
perl-Encode-IMAPUTF7-1.05-2.fc25 perl-Mail-IMAPTalk-4.04-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fb1ede8818

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394139] Review Request: perl-Mail-IMAPTalk - IMAP client interface with lots of features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394139



--- Comment #6 from Fedora Update System  ---
perl-Encode-IMAPUTF7-1.05-2.fc24 perl-Mail-IMAPTalk-4.04-1.fc24 has been
submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-4d69373086

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394139] Review Request: perl-Mail-IMAPTalk - IMAP client interface with lots of features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394139



--- Comment #4 from Fedora Update System  ---
perl-Encode-IMAPUTF7-1.05-2.fc25 perl-Mail-IMAPTalk-4.04-1.fc25 has been
submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-fb1ede8818

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394139] Review Request: perl-Mail-IMAPTalk - IMAP client interface with lots of features

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394139

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Mail-IMAPTalk-4.04-1.f
   ||c26



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394146] Review Request: perl-Convert-Base64 - Encoding and decoding of Base64 strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394146



--- Comment #5 from Fedora Update System  ---
perl-Convert-Base64-0.001-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-df16f5afba

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394146] Review Request: perl-Convert-Base64 - Encoding and decoding of Base64 strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394146



--- Comment #4 from Fedora Update System  ---
perl-Convert-Base64-0.001-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-ce08d48f91

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394146] Review Request: perl-Convert-Base64 - Encoding and decoding of Base64 strings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394146

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-Convert-Base64-0.001-1
   ||.fc26



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Christian Dersch  changed:

   What|Removed |Added

 Blocks||115 (Astronomy-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=115
[Bug 115] Astronomy SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395273] New: Review Request: python-wcsaxes - A framework for plotting astronomical and geospatial data

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395273

Bug ID: 1395273
   Summary: Review Request: python-wcsaxes - A framework for
plotting astronomical and geospatial data
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: lupi...@mailbox.org
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://lupinix.fedorapeople.org/review/python-wcsaxes.spec
SRPM URL:
https://lupinix.fedorapeople.org/review/python-wcsaxes-0.9-1.fc25.src.rpm

Description: WCSAxes is a Python module which enhances matplotlib to plot
astronomical and
geospatial data.

Fedora Account System Username: lupinix

Koji scratch build (rawhide):
http://koji.fedoraproject.org/koji/taskinfo?taskID=16463801

Thank you very much for review in advance!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1392838] Review Request: python-mlpy - Python module for Machine Learning

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1392838

Dhanesh B. Sabane  changed:

   What|Removed |Added

 Blocks||100 (ML-SIG)




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=100
[Bug 100] Machine Learning SIG - review tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394215] Review Request: perl-Tie-DataUUID - Tie interface to Data:: UUID

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394215



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Tie-DataUUID

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394183] Review Request: perl-Text-VCardFast - Perl extension for very fast parsing of VCards

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394183



--- Comment #2 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Text-VCardFast

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388945

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||zbys...@in.waw.pl



--- Comment #4 from Zbigniew Jędrzejewski-Szmek  ---
Sam, can you run fedora-review on this bug?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1393899] Review Request: libdirq - C implementation of the simple directory queue algorithm

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1393899



--- Comment #13 from Fedora Update System  ---
libdirq-0.4-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-693fad51b5

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org