[Bug 1290342] Review Request: ecc-25519-java - Java library to use Ed25519 and Curve25518

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1290342



--- Comment #17 from Tomas Repik  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

ISSUES
==
[!]: Requires correct, justified where necessary.
- please justify the use of perl (in spec also)

QUESTIONS
=
Are these two the only sources the package compiles?
ECC-25519-Java/src/main/java/net/vrallev/java/ecc/Ecc25519Helper.java
ECC-25519-Java/src/main/java/net/vrallev/java/ecc/KeyHolder.java

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[?]: License field in the package spec file matches the actual license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[?]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Java:
[x]: Bundled jar/class files should be removed before build
[x]: Packages have proper BuildRequires/Requires on jpackage-utils
[x]: Javadoc documentation files are generated and included in -javadoc
 subpackage
[x]: Javadoc subpackages should not have Requires: jpackage-utils
[x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)

Maven:
[x]: If package contains pom.xml files install it (including metadata) even
 when building with ant
[x]: Old add_to_maven_depmap macro is not being used

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: 

[Bug 1394262] Review Request: perl-Net-CardDAVTalk - CardDAV client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394262

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Jitka Plesnikova  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Jitka Plesnikova  ---
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Net-CalDAVTalk-0.09-1.fc26.noarch.rpm | sort | uniq
-c
  1 perl(:MODULE_COMPAT_5.24.0)
  1 perl(:VERSION) >= 5.6.0
  1 perl(Carp)
  1 perl(Data::Dumper)
  1 perl(Data::ICal)
  1 perl(Data::ICal::Entry::Alarm::Display)
  1 perl(Data::ICal::Entry::Alarm::Email)
  1 perl(Data::ICal::Entry::Event)
  1 perl(Data::ICal::Entry::TimeZone)
  1 perl(Data::ICal::Entry::TimeZone::Daylight)
  1 perl(Data::ICal::Entry::TimeZone::Standard)
  1 perl(Data::ICal::TimeZone) >= 1.23
  1 perl(DateTime::Format::ICal) >= 0.09
  1 perl(DateTime::Format::ISO8601) >= 0.08
  1 perl(DateTime::TimeZone)
  1 perl(Digest::SHA)
  1 perl(JSON::XS)
  1 perl(MIME::Base64)
  1 perl(MIME::Types)
  1 perl(Net::CalDAVTalk::TimeZones)
  1 perl(Net::DAVTalk) >= 0.02
  1 perl(Text::LevenshteinXS) >= 0.03
  1 perl(Text::VCardFast) >= 0.06
  1 perl(URI::Escape)
  1 perl(XML::Spice)
  1 perl(base)
  1 perl(strict)
  1 perl(warnings)
  1 rpmlib(CompressedFileNames) <= 3.0.4-1
  1 rpmlib(FileDigests) <= 4.6.0-1
  1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Net-CalDAVTalk-0.09-1.fc26.noarch.rpm | sort | uniq
-c
  1 perl(Net::CalDAVTalk) = 0.09
  1 perl(Net::CalDAVTalk::TimeZones)
  1 perl-Net-CalDAVTalk = 0.09-1.fc26
Binary provides are Ok.

$ rpmlint ./perl-Net-CalDAVTalk*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package looks good.
Approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #11 from Tomas Repik  ---
(In reply to gil cattaneo from comment #9)
> Are still present jar/class files. Please, remove them adding
> find -name "*.jar" -delete
> in %prep section

Sorry, I missed it, I will include it in the next "version".

(In reply to gil cattaneo from comment #10)
> Created attachment 1222731 [details]
> spec file

Thanks for the Spec updated do you think we can do both extensions optional?
Use %bcond_with with the jcache submodule as well? I also have to ask why do
you do: %mvn_package :%{name}-parent __noinstall Is the parent not necessary?
In which cases it would be needed?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394252] Review Request: perl-Net-CalDAVTalk - CalDAV client with JSON data interface

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394252

Jitka Plesnikova  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||jples...@redhat.com
   Assignee|nob...@fedoraproject.org|jples...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873



--- Comment #9 from Michal Ambroz  ---
Opps - fingers faster than brain - the links should have been:
Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-5.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873



--- Comment #8 from Michal Ambroz  ---
Thanks Zbysek for comments.
Updated package:

Spec URL: http://rebus.fedorapeople.org/SPECS/python2-pyx.spec
SRPM URL: http://rebus.fedorapeople.org/SRPMS/python2-pyx-0.12.1-4.fc24.src.rpm

Download of file was removed from sourceforge, switched to pypi repository.


Best regards
Michal Ambroz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #9 from Michal Ambroz  ---
Thank you.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391334] Review Request: freeorion - Turn-based space empire and galactic conquest (4X) computer game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391334



--- Comment #8 from Link Dupont  ---
Good catch. It falls back to DejaVu-Sans if it can't find Roboto, but I
symlinked those two fonts into default/data/fonts anyway.

Spec URL:
https://fedorapeople.org/cgit/linkdupont/public_git/freeorion.git/plain/freeorion.spec
SRPM URL:
https://fedorapeople.org/~linkdupont/srpms/freeorion-0.4.6-4.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx-gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396

Orion Poplawski  changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution|--- |CURRENTRELEASE
Last Closed||2016-11-22 23:13:52



--- Comment #9 from Orion Poplawski  ---
Checked in and built

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1380105] Review Request: mingw-libdb - MinGW build of The Berkeley DB database library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1380105

Yaakov Selkowitz  changed:

   What|Removed |Added

 CC||yselk...@redhat.com



--- Comment #3 from Yaakov Selkowitz  ---
Are the EXEs really useful here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397643] Review Request: dapl - Library providing access to the DAT 2.0 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397643

Honggang LI  changed:

   What|Removed |Added

 CC||mschm...@redhat.com,
   ||rdma-dev-t...@redhat.com
 Blocks||1315609



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397643] New: Review Request: dapl - Library providing access to the DAT 2.0 API

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397643

Bug ID: 1397643
   Summary: Review Request: dapl - Library providing access to the
DAT 2.0 API
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: ho...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl.spec

SRPM URL:
http://people.redhat.com/honli/.419dc6a07891d4da7bc03168d5613fcz/dapl-2.1.9-1.fc26.src.rpm

Description: 
Along with the RDMA kernel drivers, libdat and libdapl provides
a userspace RDMA API that supports DAT 2.0 specification and IB
transport extensions for atomic operations and rdma write with
immediate data.

Fedora Account System Username: honli

Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=16572248

Please note MCM is disabled because:
1) Latest mpss modules have not been merged into upstream kernel.
2) No independent SCIF source code available.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748

Yaakov Selkowitz  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #3 from Yaakov Selkowitz  ---
Looks good to me.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382935] Review Request: python-visitor - A tiny python visitor implementation

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382935

Fedora Update System  changed:

   What|Removed |Added

 Status|ON_QA   |CLOSED
 Resolution|--- |ERRATA
Last Closed||2016-11-22 22:52:54



--- Comment #6 from Fedora Update System  ---
python-visitor-0.1.3-1.fc24 has been pushed to the Fedora 24 stable repository.
If problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748

Yaakov Selkowitz  changed:

   What|Removed |Added

  Flags|fedora-review-  |fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748



--- Comment #2 from Neal Gompa  ---
Spec URL:
http://copr-dist-git.fedorainfracloud.org/cgit/ngompa/mingw-openal-soft/mingw-openal-soft.git/plain/mingw-openal-soft.spec?id=8f833d624cb4c3918cc48e8fc2285b3a3fbc4e46

SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/ngompa/mingw-openal-soft/fedora-rawhide-x86_64/00480465-mingw-openal-soft/mingw-openal-soft-1.17.2-2.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748

Yaakov Selkowitz  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review-



--- Comment #1 from Yaakov Selkowitz  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Header files in -devel subpackage, if present.
  Note: mingw32-openal-soft : /usr/i686-w64-mingw32/sys-
  root/mingw/include/AL/al.h mingw32-openal-soft : /usr/i686-w64-mingw32
  /sys-root/mingw/include/AL/alc.h mingw32-openal-soft :
  /usr/i686-w64-mingw32/sys-root/mingw/include/AL/alext.h mingw32-openal-
  soft : /usr/i686-w64-mingw32/sys-root/mingw/include/AL/efx-creative.h
  mingw32-openal-soft : /usr/i686-w64-mingw32/sys-root/mingw/include/AL
  /efx-presets.h mingw32-openal-soft : /usr/i686-w64-mingw32/sys-
  root/mingw/include/AL/efx.h mingw64-openal-soft : /usr/x86_64-w64-mingw32
  /sys-root/mingw/include/AL/al.h mingw64-openal-soft :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alc.h mingw64-openal-
  soft : /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/alext.h mingw64
  -openal-soft : /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx-
  creative.h mingw64-openal-soft : /usr/x86_64-w64-mingw32/sys-
  root/mingw/include/AL/efx-presets.h mingw64-openal-soft :
  /usr/x86_64-w64-mingw32/sys-root/mingw/include/AL/efx.h
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages
- Static libraries in -static or -devel subpackage, providing -devel if
  present.
  Note: Package has .a files: mingw32-openal-soft, mingw64-openal-soft.
  Illegal package name: mingw32-openal-soft, mingw64-openal-soft. Does not
  provide -static: mingw32-openal-soft, mingw64-openal-soft.
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
[-]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: 

[Bug 1396748] Review Request: mingw-openal-soft - MinGW port of Open Audio Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396748

Yaakov Selkowitz  changed:

   What|Removed |Added

 CC||yselk...@redhat.com
   Assignee|nob...@fedoraproject.org|yselk...@redhat.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397620] Review Request: nodejs-int64-buffer - 64bit Long Integer on Buffer/Array/ ArrayBuffer in Pure JavaScript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397620

Ben Rosser  changed:

   What|Removed |Added

 Blocks||1397621




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397621
[Bug 1397621] Review Request: nodejs-qtdatastream - Nodejs lib which can
read/write Qt formatted Datastreams
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397621] Review Request: nodejs-qtdatastream - Nodejs lib which can read/ write Qt formatted Datastreams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397621

Ben Rosser  changed:

   What|Removed |Added

 Depends On||1397620



--- Comment #1 from Ben Rosser  ---
This package requires nodejs-int64-buffer
(https://bugzilla.redhat.com/show_bug.cgi?id=1397620).


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397620
[Bug 1397620] Review Request: nodejs-int64-buffer - 64bit Long Integer on
Buffer/Array/ArrayBuffer in Pure JavaScript
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397621] New: Review Request: nodejs-qtdatastream - Nodejs lib which can read/ write Qt formatted Datastreams

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397621

Bug ID: 1397621
   Summary: Review Request: nodejs-qtdatastream - Nodejs lib which
can read/write Qt formatted Datastreams
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://tc01.fedorapeople.org/quassel/quassel-webserver/nodejs-qtdatastream.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-webserver/nodejs-qtdatastream-0.6.7-1.fc24.src.rpm

Description: Nodejs lib which can read/write Qt formatted Datastreams.

For the moment the following types are handled for reading and writing:
QBool, QShort, QInt, QInt64, QUInt, QUInt64, QDouble, QMap, QList, QString,
QVariant, QStringList, QByteArray, QUserType, QDateTime, QTime, QChar,
QInvalid.

Fedora Account System Username: tc01

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397620] New: Review Request: nodejs-int64-buffer - 64bit Long Integer on Buffer/Array/ ArrayBuffer in Pure JavaScript

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397620

Bug ID: 1397620
   Summary: Review Request: nodejs-int64-buffer - 64bit Long
Integer on Buffer/Array/ArrayBuffer in Pure JavaScript
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: rosser@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL:
https://tc01.fedorapeople.org/quassel/quassel-webserver/nodejs-int64-buffer.spec
SRPM URL:
https://tc01.fedorapeople.org/quassel/quassel-webserver/nodejs-int64-buffer-0.1.9-1.fc24.src.rpm

Description: JavaScript's number based on IEEE-754 could only handle 53 bits
precision. This module provides a couple of classes: Int64BE and Uint64BE which
could hold 64 bits long integer and loose no bit.

Fedora Account System Username: tc01

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396790] Review Request: gnome-shell-extension-freon - GNOME Shell extension to display system temperature , voltage, and fan speed

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396790

Zbigniew Jędrzejewski-Szmek  changed:

   What|Removed |Added

 CC||and...@tosk.in,
   ||zbys...@in.waw.pl
  Flags||needinfo?(and...@tosk.in)



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #21 from Fedora Update System  ---
python3-tornado-4.4.2-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-27782b5577

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387873] Review Request: python2-pyx - Python graphics package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387873



--- Comment #7 from Zbigniew Jędrzejewski-Szmek  ---
%{!?python2_sitearch: %define python_sitearch %(%{__python2} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib(1)")}
→ harmless, but unnecessary

Group:  Applications/Publishing
→ not needed

BuildRoot:  %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
→ SHOULD NOT be used
[https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections]

Provides:python2-pyx
→ should be removed

python2-pyx.src: E: description-line-too-long C WARNING: This is compat python2
package and should be used only for legacy stuff.
python2-pyx.src:22: W: unversioned-explicit-provides python2-pyx
python2-pyx.src:13: W: mixed-use-of-spaces-and-tabs (spaces: line 3, tab: line
13)
python2-pyx.src: W: file-size-mismatch pyxfaq.pdf = 159033,
http://pyx.sourceforge.net/pyxfaq.pdf = 158776
python2-pyx.src: W: file-size-mismatch manual.pdf = 696879,
http://pyx.sourceforge.net/manual.pdf = 707854
python2-pyx.src: W: invalid-url Source0:
http://downloads.sourceforge.net/sourceforge/pyx/PyX-0.12.1.tar.gz HTTP Error
404: Not Found

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396139



--- Comment #10 from Yaakov Selkowitz  ---
The sources are missing in the debug package because configure is messing
around with CFLAGS.  However, given Fedora's default %{optflags}, you are
correct that this isn't quite sufficient; --disable-debugging needs to be
dropped from the arguments to %configure.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909

Fedora Update System  changed:

   What|Removed |Added

 Status|POST|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1375670] Review Request: python26 - Version 2.6 of the Python programming language

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1375670

Fedora Update System  changed:

   What|Removed |Added

 Status|CLOSED  |ON_QA
 Resolution|CURRENTRELEASE  |---
   Keywords||Reopened



--- Comment #11 from Fedora Update System  ---
python26-2.6.9-3.fc23 has been pushed to the Fedora 23 testing repository. If
problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-54c504f247

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346407] Review Request: stress-ng - Stress test a computer system in various ways

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346407

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #21 from Fedora Update System  ---
stress-ng-0.07.05-3.fc23 has been pushed to the Fedora 23 testing repository.
If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2016-b925ae12fa

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #20 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python3-tornado

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx-gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #8 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinx-gallery

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388396



--- Comment #12 from Fedora Update System  ---
python-pynlpl-1.0.9-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-c75647fa6a

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388396

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396139] Review Request: libmad - MPEG audio decoder library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396139



--- Comment #9 from Neal Gompa  ---
@Yaakov, I do not see how that fixes the fact that the source code is missing
in the debuginfo subpackage...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261

Neal Gompa  changed:

   What|Removed |Added

 CC||ngomp...@gmail.com
   Assignee|nob...@fedoraproject.org|ngomp...@gmail.com
  Flags||fedora-review?
   ||needinfo?(tcallawa@redhat.c
   ||om)



--- Comment #4 from Neal Gompa  ---
I'll take this review, but I'd like for spot to okay the cleanup script.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1374898] Review Request: quasselc - API to access a Quassel Core in pure C

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1374898

Fedora Update System  changed:

   What|Removed |Added

 Status|MODIFIED|ON_QA



--- Comment #13 from Fedora Update System  ---
quasselc-0-1.20160909gitfcd9669.el7 has been pushed to the Fedora EPEL 7
testing repository. If problems still persist, please make note of it in this
bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-944a599e8f

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397089] Review Request: DNSCryptClient - qt gui for dnscrypt proxy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397089



--- Comment #6 from Fl@sh  ---
INFO for reviewer or testers: after application using need RESTORE system
resolver settings. Click 'Restore' (third) button for it or restore resolv.conf
manually.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350029] Review Request: libi40iw - userspace rdma library for Intel Ethernet Connection X722

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350029



--- Comment #31 from tatyana  ---
Thank you for the information.

Just to clarify this package was released as part of RedHat 7.3. There is
another libi40iw bug report (id=1381746) which targets RehHat 7.4. We are still
working on preparing patches for the new libi40iw package. Are you referring to
a new package for RedHat 7.4?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1376940] Review Request: python3-urllib3 - Python 3 HTTP library with thread-safe connection pooling and file post

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1376940



--- Comment #4 from Orion Poplawski  ---
Spec URL: http://www.cora.nwra.com/~orion/fedora/python3-urllib3.spec
SRPM URL:
http://www.cora.nwra.com/~orion/fedora/python3-urllib3-1.19.1-1.el7.src.rpm

* Tue Nov 22 2016 Orion Poplawski  - 1.19.1-1
- Update to 1.19.1

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350029] Review Request: libi40iw - userspace rdma library for Intel Ethernet Connection X722

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350029



--- Comment #30 from Igor Gnatenko  ---
(In reply to tatyana from comment #29)
> I thought that this package has been released and no further action was
> required. I don't know who needs to update the bug status.
http://koji.fedoraproject.org/koji/packageinfo?packageID=22609

I don't see any builds of this package in Fedora. So you need to:
1. import spec and oter stuff into git repo
2. build in koji
3. submit updates in bodhi

You can always ask someone who sponsored you into packagers group as it's his
duty to help.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #19 from Orion Poplawski  ---
Oh, and thanks for the review!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909



--- Comment #18 from Orion Poplawski  ---
Shifted to github source to get the LICENSE file.  sphinx-build fails (too old
I think), so waiting for sphinx-build-3.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595



--- Comment #4 from Derek Ditch  ---
Radovan, thanks for the update. That review was submitted after I submitted
this one. I do need this package in EPEL if possible until it is included
upstream. There are other packages that I'd like to submit but they depend on
librdkafka.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350029] Review Request: libi40iw - userspace rdma library for Intel Ethernet Connection X722

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350029

tatyana  changed:

   What|Removed |Added

  Flags|needinfo?(tatyana.e.nikolov |
   |a...@intel.com)|



--- Comment #29 from tatyana  ---
I thought that this package has been released and no further action was
required. I don't know who needs to update the bug status.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1309909] Review Request: python3-tornado - Scalable, non-blocking web server and tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1309909

Raphael Groner  changed:

   What|Removed |Added

 Status|ASSIGNED|POST
  Flags|fedora-review?  |fedora-review+



--- Comment #17 from Raphael Groner  ---
APPROVED

But at least, note the missing %license as explained below. Please fix while
importing the package.


MUST

* Please add '%license LICENSE' to both %files.
  https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text


SHOULD

* python3-pkgversion-macros needs to be installed to let fedora-review
  properly parse the spec file. Maybe consider to add it as BuildRequires.

* Please make the sphinx documentation in the doc subfolder and add the 
  generated files to doc subpackage.




Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://fedoraproject.org/wiki/Packaging:Guidelines
- Package contains BR: python2-devel or python3-devel


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
 Note: Unversioned so-files in private %_libdir subdirectory (see
 attachment). Verify they are not in ld path.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[!]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Apache (v2.0)", "Unknown or generated", "*No copyright* Apache
 (v2.0)". 49 files have unknown license. Detailed output of
 licensecheck in /home/builder/fedora-
 review/1309909-python3-tornado/licensecheck.txt
[!]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[?]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 1 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec 

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793



--- Comment #32 from Fedora Update System  ---
hyperrogue-8.3-2.j.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-beb538eef6

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx-gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396

Orion Poplawski  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-sphinx_gallery - |python-sphinx-gallery -
   |Sphinx extension to |Sphinx extension to
   |automatically generate an   |automatically generate an
   |examples gallery|examples gallery



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #7 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-sphinx_gallery

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388396



--- Comment #11 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-pynlpl

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388945] Review Request: gnome-shell-extension-media-player-indicator - Control MPRIS2 capable media players : Rhythmbox, Banshee, Clementine and more

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388945



--- Comment #6 from MartinKG  ---
because it easier to update (spectool -g 

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396

Athos Ribeiro  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #6 from Athos Ribeiro  ---
(In reply to Orion Poplawski from comment #5)
> Shouldn't be too hard to figure out :)
> 
> SRPM URL:
> https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery-0.1.5-3.fc26.
> src.rpm

I was getting a 404 on that link before...

There's still one error when executing tests:

/tmp/tmp1g4aadqb/raise.py failed to execute correctly:Traceback (most recent
call last):
  File "/builddir/build/BUILD/sphinx-gallery-0.1.5/sphinx_gallery/gen_rst.py",
line 514, in execute_code_block
exec(code_block, example_globals)
  File "", line 1, in 
NameError: name 'First_test_fail' is not defined

But tests are passing.

The pointed issues were solved, package looks good to me. Approved

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261



--- Comment #3 from Yaakov Selkowitz  ---
Spec URL: https://yselkowitz.fedorapeople.org/gstreamer1-plugins-ugly-free.spec
SRPM URL:
https://yselkowitz.fedorapeople.org/gstreamer1-plugins-ugly-free-1.10.0-4.fc26.src.rpm
Description: GStreamer streaming media framework "ugly" plugins
Fedora Account System Username: yselkowi

koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=16566350

Cleanup script:
https://yselkowitz.fedorapeople.org/gst-p-ugly-cleanup.sh

This is based on gstreamer1-plugins-bad-free.  As libmad is still under review
(bug 1396139), I have temporarily omitted that plugin.  Perhaps we should wait
to ultimately import this until that is ready, to avoid a second potential
conflict with the external repository's package.

In the meantime, spot, could you sign off on this cleanup?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1350884] Review Request: mspgcc - Rebase of GCC for the MSP430 to TI / Red Hat upstream

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1350884



--- Comment #6 from Brandon Nielsen  ---
Did a few informal reviews:

https://bugzilla.redhat.com/show_bug.cgi?id=1387927
https://bugzilla.redhat.com/show_bug.cgi?id=1378095
https://bugzilla.redhat.com/show_bug.cgi?id=1382850

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378095] Review Request: rst2odp - Converter for rst to OpenOffice Impress

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378095

Brandon Nielsen  changed:

   What|Removed |Added

 CC||niels...@jetfuse.net



--- Comment #1 from Brandon Nielsen  ---
Informal review:

Unnecessary whitespace on line 10 of the specfile.


Change summary to "Converter from rst to OpenOffice Impress", it reads better
that way.


"Packaging" is misspelled as "Packacking" in the description. Fixing this will
clean up the SRPM rpmlint warning below.


rpmlint warning when checking SRPM:

rst2odp.src: W: spelling-error %description -l en_US Packacking -> Packaging,
Backpacking, Packing


rpmlint errors and warnings checking rst2odp-0.3.1-1.fc25.noarch.rpm:

rst2odp.noarch: W: spelling-error %description -l en_US Packacking ->
Packaging, Backpacking, Packing
rst2odp.noarch: E: script-without-shebang /usr/bin/otptweak
rst2odp.noarch: E: script-without-shebang /usr/bin/odpstyles
rst2odp.noarch: W: no-manual-page-for-binary rst2odp
rst2odp.noarch: W: no-manual-page-for-binary odpstyles
rst2odp.noarch: W: no-manual-page-for-binary otptweak

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1351115] Review Request: python-betamax-matchers - Group of experimental matchers for Betamax

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1351115

Iryna Shcherbina  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ishch...@redhat.com
  Flags||fedora-review?



--- Comment #2 from Iryna Shcherbina  ---
I have been sponsored and now I can continue with the formal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1372836] Review Request: python-hug - A Python framework that makes developing APIs simple

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1372836

Iryna Shcherbina  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ishch...@redhat.com



--- Comment #7 from Iryna Shcherbina  ---
I would like to mention, that I have been sponsored and now I can continue with
the formal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370621] Review Request: python-django-ipware - Returns user' s real IP address in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370621



--- Comment #3 from Igor Gnatenko  ---
(In reply to Iryna Shcherbina from comment #2)
> I have been sponsored and now I can continue with the formal review.
I will update & fix the stuff in upcoming days.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804

Iryna Shcherbina  changed:

   What|Removed |Added

   Assignee|nob...@fedoraproject.org|ishch...@redhat.com
  Flags||fedora-review?



--- Comment #8 from Iryna Shcherbina  ---
I would like to add, that I have been sponsored and now I can approve packages.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1370621] Review Request: python-django-ipware - Returns user' s real IP address in Django

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1370621

Iryna Shcherbina  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|ishch...@redhat.com
  Flags||fedora-review?



--- Comment #2 from Iryna Shcherbina  ---
I have been sponsored and now I can continue with the formal review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955

Neal Gompa  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #8 from Neal Gompa  ---
Ignoring the autotools check from fedora-review, the package looks good to me.

PACKAGE APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395955] Review Request: fatresize - FAT16/FAT32 resizer

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395955



--- Comment #7 from Neal Gompa  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "MIT/X11 (BSD like)", "GPL (v3 or later)", "Unknown or
 generated". 19 files have unknown license. Detailed output of
 licensecheck in /home/makerpm/1395955-fatresize/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
 Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
 fatresize-debuginfo
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[-]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in 

[Bug 1383416] Review Request: python-influxdb - InfluxDB Python client

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1383416



--- Comment #6 from Iryna Shcherbina  ---
Hi Parag,

thank you for your concern, I should not have assigned it to myself.

However, I have been sponsored and now I can approve packages and continue with
the review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1388396] Review Request: python-pynlpl - A Python library for Natural Language Processing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1388396

Miro Hrončok  changed:

   What|Removed |Added

 Blocks|177841 (FE-NEEDSPONSOR) |



--- Comment #10 from Miro Hrončok  ---
Sponsored. Good luck.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1387927] Review Request: numcosmo - Numerical cosmology tools

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1387927

Brandon Nielsen  changed:

   What|Removed |Added

 CC||niels...@jetfuse.net



--- Comment #2 from Brandon Nielsen  ---
Informal review:

Start description with "NumCosmo is a..." not "The NumCosmo is a...", it reads
better that way.

Add a space after "(CMB)" in the "cosmic microwave background
(CMB),supernovae..." line in the description.


rpmlint warnings checking SRPM:

numcosmo.src: W: spelling-error %description -l en_US baryonic -> baryon,
Nicobar


rpmlint warnings checking numcosmo-0.13.3-1.fc25.x86_64.rpm:

numcosmo.x86_64: W: spelling-error %description -l en_US baryonic -> baryon,
Nicobar
numcosmo.x86_64: W: no-manual-page-for-binary mset_gen
numcosmo.x86_64: W: no-manual-page-for-binary mcat_analyze


rpmlint errors and warnings checking
numcosmo-examples-0.13.3-1.fc25.x86_64.rpm:

numcosmo-examples.x86_64: W: summary-not-capitalized C numcosmo examples
numcosmo-examples.x86_64: E: script-without-shebang
/usr/share/numcosmo-0.13.3/examples/py_hiprim_example.py
numcosmo-examples.x86_64: E: script-without-shebang
/usr/share/numcosmo-0.13.3/examples/pydata_simple/py_sline_model.py
numcosmo-examples.x86_64: W: devel-file-in-non-devel-package
/usr/share/numcosmo-0.13.3/examples/example_simple.c
numcosmo-examples.x86_64: W: devel-file-in-non-devel-package
/usr/share/numcosmo-0.13.3/examples/example_ca.c
numcosmo-examples.x86_64: E: script-without-shebang
/usr/share/numcosmo-0.13.3/examples/pydata_simple/py_sline_data.py


rpmlint warnings checking numcosmo-libs-devel-0.13.3-1.fc25.x86_64.rpm:

numcosmo-libs-devel.x86_64: W: only-non-binary-in-usr-lib
numcosmo-libs-devel.x86_64: W: no-documentation


Manpage compression method may change, don't assume .gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389404] Review Request: python-Flask-PyMongo - PyMongo support for Flask applications

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389404



--- Comment #3 from Athos Ribeiro  ---
Hi David,

Naming:

- All the Flask related packages are named with lower case. Did you consider
that when naming this package?

License:

- The license file you are using belongs to the "Flask Sphinx Style" used in
the documentation, not to this package.

- Note that since this package is shipped under a BSD license, it must contain
the full license text. The text is present in both files shipped in the package
(__init__.py and wrappers.py), but it would be really nice if you considered
asking upstream to also include the text in a separate file (like LICENSE or
COPYING). This is not a blocker for this review, since the text is already
available in the files I mentioned.

Tests:

- Upstream provides a test suite. Is there any reason for not running the tests
in %check?

Documentation:

- There are some import errors being raised while building documentation, did
you check that?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140



--- Comment #3 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mrrescue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397140] Review Request: mrrescue - Arcade-style fire fighting game

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397140



--- Comment #2 from Jeremy Newton  ---
Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #5 from Orion Poplawski  ---
Shouldn't be too hard to figure out :)

SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python-sphinx-gallery-0.1.5-3.fc26.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395554] Review Request: python-astral - Calculations for the position of the sun and moon

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395554



--- Comment #8 from Athos Ribeiro  ---
Hi Fabian,

Package looks great now!

There are 2 issues left before we can have this approved:

1 - Python2 package has no license (you only included it in the python3
package).

2 - The %{sum} macro was not defined, but it is used in all 3 Summary tags.

Here is the fedora-review checklist, already filled. As soon as oyu fix the
issues above, I will consider this review done!

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

= MUST items =

Generic:
[!]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
[!]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[!]: Macros in Summary, %description expandable at SRPM build time.
 Note: Macros in: python2-astral (summary), python3-astral (summary)
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
 process.
[x]: A package which is used by another package via an egg interface should
 provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

= SHOULD items =

Generic:
[x]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: 

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #7 from Iryna Shcherbina  ---
Hi Fabian,

Thank you for creating the issue and for your responses.

Please make sure to add the %check section with the next release when the issue
is resolved.

Also the spec file [0] does not reflect the %description change yet, so please
push the change. Other than that, I approve the package.

[0] https://fab.fedorapeople.org/packages/SRPMS/python-batinfo.spec

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1389985] Review Request: http-builder - HTTP client framework for Groovy

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389985

gil cattaneo  changed:

   What|Removed |Added

 Blocks||1397307




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1397307
[Bug 1397307] Gradle 3.1 is available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1382850] Review Request: libtoml - Fast C parser using Ragel to generate the state machine

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1382850

Brandon Nielsen  changed:

   What|Removed |Added

 CC||niels...@jetfuse.net



--- Comment #1 from Brandon Nielsen  ---
Informal review:

Unable to build the SRPM:

Error during basic setup:

Neither directory contains a build file meson.build.
error: Bad exit status from /var/tmp/rpm-tmp.c42CN3 (%build)


RPM build errors:
Bad exit status from /var/tmp/rpm-tmp.c42CN3 (%build)


rpmlint warnings when checking SRPM:

libtoml.src: W: summary-ended-with-dot C Fast C parser using Ragel to generate
the state machine.
libtoml.src: E: no-changelogname-tag


The description should expand upon the summary.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395396] Review Request: python-sphinx_gallery - Sphinx extension to automatically generate an examples gallery

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395396



--- Comment #4 from Athos Ribeiro  ---
The SRPM URL points to release 1, but the SPEC file uses release 3, could you
provide the link for 0.1.5-3?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030



--- Comment #5 from Fedora Update System  ---
mingw-libidn2-0.11-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-aa90590a28

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030



--- Comment #6 from Fedora Update System  ---
mingw-libidn2-0.11-1.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-bfdd1401b0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030

Fedora Update System  changed:

   What|Removed |Added

 Status|NEW |MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1353169] Review Request: python-nikola - A static website and blog generator

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1353169

José Matos  changed:

   What|Removed |Added

  Flags|needinfo?(jama...@fc.up.pt) |



--- Comment #18 from José Matos  ---
I am, but right now I am at a time where real live is getting in the way. Lots
of exams and tests to assess. :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595



--- Comment #3 from Piotr Popieluch  ---
(In reply to Radovan Sroka from comment #2)
> There is another finished review for this package: 1394275, so this review
> can be closed. I add that reviewed package into the fedora repository, but
> not into EPEL. librdkafka will most likely be in next RHEL7.

Good to hear. With "next" do you mean current 7.3 beta or next 7.4? If it will
be 7.4 it would be nice if EPEL7 would provide it for the time being.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397261

Tom "spot" Callaway  changed:

   What|Removed |Added

 CC||tcall...@redhat.com



--- Comment #2 from Tom "spot" Callaway  ---
cdio, dvdread, mad, mpg123 are all fine. It is worth noting to random people
who stumble across this that libdvdread does not natively support reading CSS
encrypted DVDs, but if libdvdcss is present, it can (we cannot include
libdvdcss in Fedora).

asfdemux, dvdlpcmdec, dvdsub, realmedia are not permissible.

Side Note: If someone in 2016+ really cares about realmedia, speak up. I can't
imagine there are that many people who care about that format.

xingmux is permissible.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394952] Review Request: python-avocado - Framework with tools and libraries for Automated Testing

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394952



--- Comment #10 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/python-avocado

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #15 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/librdkafka

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1155793] Review Request: hyperrogue - An SDL roguelike in a non-euclidean world

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1155793



--- Comment #31 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/hyperrogue

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397030] Review Request: mingw-libidn2 - MinGW Windows Internationalized Domain Name 2008 support library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397030



--- Comment #4 from Jon Ciesla  ---
Package request has been approved:
https://admin.fedoraproject.org/pkgdb/package/rpms/mingw-libidn2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396923] Review Request: python-yarl - A Python module to handle URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396923

Fabian Affolter  changed:

   What|Removed |Added

 Status|NEW |CLOSED
 Resolution|--- |DUPLICATE
Last Closed||2016-11-22 08:52:37



--- Comment #1 from Fabian Affolter  ---


*** This bug has been marked as a duplicate of bug 1396922 ***

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1396922] Review Request: python-yarl - A Python module to handle URLs

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1396922

Fabian Affolter  changed:

   What|Removed |Added

 Blocks||1391287



--- Comment #2 from Fabian Affolter  ---
*** Bug 1396923 has been marked as a duplicate of this bug. ***


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1391287
[Bug 1391287] python3-aiohttp requires async_timeout
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354



--- Comment #6 from Fedora Update System  ---
python-colorlog-2.7.0-2.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-36675307ed

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #14 from Jakub Jelen  ---
Thanks for the explanation. I though there was something like this, but I was
unable to find it. So it is certainly bug in fedora-review, which would be good
to resolve. For the reference, there is already a ticket in the fedora-review
[1], but it was not touched yet.

[1] https://fedorahosted.org/FedoraReview/ticket/278

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275



--- Comment #13 from Igor Gnatenko  ---
(In reply to Jakub Jelen from comment #10)
> Igor, thanks for amendment.
> 
> The compilers (gcc, gcc-c++) are not needed according to Fedora review tool,
> but I can't find the actual paragraph in the Guidelines. Can you point to
> this one? If so, we should probably fix the tool not to report this kind of
> issue.
There were changes in guidelines couple of months ago. There was section about
BRs which you don't need to include, now you have:
"It is important that your package list all necessary build dependencies using
the BuildRequires: tag. You may assume that enough of an environment exists for
RPM to function, to build packages and execute basic shell scripts, but you
should not assume any other packages are present as RPM dependencies and
anything brought into the buildroot by the build system may change over time."

I'm not sure if there is open ticket for fedora-review.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354

Fedora Update System  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395354] Review Request: python-colorlog - A colored formatter for the python logging module

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395354



--- Comment #5 from Fedora Update System  ---
python-colorlog-2.7.0-2.fc25 has been submitted as an update to Fedora 25.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-e496b469bb

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #10 from gil cattaneo  ---
Created attachment 1222731
  --> https://bugzilla.redhat.com/attachment.cgi?id=1222731=edit
spec file

i done some changes in Your spec files, i had wrote as early, guava extension
sub module is not buildable, with the guava release in our repository

Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=16562990

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #6 from Fabian Affolter  ---
i meant: No Py3 on EPEL.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1395804] Review Request: python-batinfo - A Python module to retrieve battery information

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1395804



--- Comment #5 from Fabian Affolter  ---
(In reply to Iryna Shcherbina from comment #3)
> The spec file looks good to me, but I would suggest to do another small
> change.
> The %description is missing one sentence comparing to the one in package
> documentation and therefore seems incomplete.
> Please change it to the original one:
> 
> A simple Python module to retrieve battery information on Linux-based
> operating system. No ACPI or external software is needed. Only the Linux
> kernel and its /sys/class/power_supply folder.

Changed

> Also, could you please explain to me why you define the following:
> 
> > %if 0%{?fedora}
> > %bcond_without python3
> > %else
> > %bcond_with python3
> > %endif

Needed to build the package for EPEL as there is Py3. 

(In reply to Iryna Shcherbina from comment #4)
> Another thing is that batinfo contains tests, they are just 
> not included into the tarball:
> 
> https://github.com/nicolargo/batinfo/blob/master/test_batinfo.py
> 
> You should either get the tests from github or create an issue to include
> them, and run them in %check section.

https://github.com/nicolargo/batinfo/issues/12

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1390595] Review Request: librdkafka - The Apache Kafka C Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1390595

Radovan Sroka  changed:

   What|Removed |Added

 CC||rsr...@redhat.com



--- Comment #2 from Radovan Sroka  ---
There is another finished review for this package: 1394275, so this review can
be closed. I add that reviewed package into the fedora repository, but not into
EPEL. librdkafka will most likely be in next RHEL7.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #9 from gil cattaneo  ---
(In reply to Tomas Repik from comment #8)
> Spec URL: https://trepik.fedorapeople.org/caffeine/v1/caffeine.spec
> SRPM URL:
> https://trepik.fedorapeople.org/caffeine/v1/caffeine-2.3.5-1.fc24.src.rpm
> 
> - added maven-plugin-bundle
> - changed Source0
> - version updated to latest upstream version
> - patch removed

Are still present jar/class files. Please, remove them adding
find -name "*.jar" -delete
in %prep section

> I don't need the extension modules (guava, jcache) therefore I don't build
> those. Do you need them for something?


At the moment I do not remember, but if possible, it is possible to enable them
the same?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394275] Review Request: librdkafka - C/ C++ library implementation of the Apache Kafka protocol

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394275

Jakub Jelen  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #12 from Jakub Jelen  ---
Now it looks good.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
===
- All build dependencies are listed in BuildRequires, except for any that
  are listed in the exceptions section of Packaging Guidelines.
  Note: These BR are not needed: gcc gcc-c++
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

>>> Missing reference to evaluate this item, but not a blocker

= MUST items =

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: ldconfig called in %post and %postun if required.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
[x]: Development (unversioned) .so files in -devel subpackage, if present.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated", "BSD (2 clause) MIT/X11 (BSD like)",
 "zlib/libpng", "BSD (2 clause) ISC", "BSD (3 clause)", "BSD (2
 clause)". 100 files have unknown license.

>>> Please, make sure with upstream that the licence headers are added to the 
>>> missing files (src/rdkafka_queue.c, src/rdkafka_queue.h, tests/test.h, ...).

[x]: License file installed when any subpackage combination is installed.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 51200 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully 

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #8 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/caffeine/v1/caffeine.spec
SRPM URL:
https://trepik.fedorapeople.org/caffeine/v1/caffeine-2.3.5-1.fc24.src.rpm

- added maven-plugin-bundle
- changed Source0
- version updated to latest upstream version
- patch removed

I don't need the extension modules (guava, jcache) therefore I don't build
those. Do you need them for something?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1397051] Review Request: caffeine - High performance java 8 caching library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1397051



--- Comment #7 from Tomas Repik  ---
Spec URL: https://trepik.fedorapeople.org/caffeine/v0/caffeine.spec
SRPM URL:
https://trepik.fedorapeople.org/caffeine/v0/caffeine-2.3.5-1.fc24.src.rpm

- added maven-plugin-bundle
- changed Source0
- version updated to latest upstream version
- patch removed

I don't need the extension modules (guava, jcache) therefore I don't build
those. Do you need them for something?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org