[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #49 from Yunying Sun --- (In reply to Björn "besser82" Esser from comment #42) > Created attachment 1214569 [details] > License-file contained in upstream-tarball > > Well, the license-file shipped with the sources contains some possible > restrictions on the user's freedom of use… > > Raising fedora-legal here to clarify, before starting the review… Hi Bjorn, since the license issue has been fixed, could you help to do a formal review of this package? I'd be happy to see more comments, or approval for sure. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369720] Review Request: tpm2-tools - a TPM2.0 testing tool build upon TPM2.0-TSS
https://bugzilla.redhat.com/show_bug.cgi?id=1369720 --- Comment #17 from Yunying Sun --- Done some reviews, see comments in 1385331, 1366047, 1395522, 1394789, 1399648, 1398922. Will try to do more reviews in future. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack
https://bugzilla.redhat.com/show_bug.cgi?id=1369708 --- Comment #48 from Yunying Sun --- More reviews are done on 1395522, 1394789, 1399648, 1398922. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 673096] Review Request: bamf-qt - Qt bindings and QML plugin for Bamf DBus server
https://bugzilla.redhat.com/show_bug.cgi?id=673096 John Skeoch changed: What|Removed |Added Assignee|rnova...@redhat.com |ova...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 673115] Review Request: dee-qt - Qt bindings and QML plugin for Dee
https://bugzilla.redhat.com/show_bug.cgi?id=673115 John Skeoch changed: What|Removed |Added Assignee|rnova...@redhat.com |ova...@redhat.com -- You are receiving this mail because: You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Jared Wallace changed: What|Removed |Added Flags|needinfo?(jared-wallace@us. | |ibm.com)| --- Comment #20 from Jared Wallace --- Cool beans. Last review is here: https://bugzilla.redhat.com/show_bug.cgi?id=1374510#c4 Specfile: https://bitbucket.org/jared-wallace/orpie/raw/e147c118290433c0db7c7df3a6cb3857f54df718/SPECS/orpie.spec SRPM: https://bitbucket.org/jared-wallace/orpie/raw/e147c118290433c0db7c7df3a6cb3857f54df718/SRPMS/orpie-1.5.2-3.fc24.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1374510] Review Request: lv2-ir-plugins - LV2 Plugin: low-latency, realtime, high performance signal convolver
https://bugzilla.redhat.com/show_bug.cgi?id=1374510
Jared Wallace changed:
What|Removed |Added
CC||jared-wall...@us.ibm.com
--- Comment #4 from Jared Wallace ---
*** This is an unofficial review ***
Quick take:
1) You don't need to specify gcc as a build dependency
2) The incorrect-fsf-address errors from rpmlint should be reported upstream.
3) There are two unversioned libraries included - pretty sure these ought to be
moved to a devel package based on:
https://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries
but I could be mistaken.
4) Fedora-review showed a build failure - the koji build you linked to is for
Fedora 24. You have to make sure it builds on 25 and Rawhide as well, and
speaking from experience, that can be a fun journey.
I'd say work on those, and then we'll see where we stand. The SPEC file looks
good btw. You can review the stuff below if you want as well.
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
===
- Package installs properly.
Note: Installation errors (see attachment)
See: https://fedoraproject.org/wiki/Packaging:Guidelines
- All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
Note: These BR are not needed: gcc-c++
See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2
= MUST items =
C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
Note: Unversioned so-files in private %_libdir subdirectory (see
attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[ ]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[ ]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "GPL (v2 or later) (with incorrect FSF address)", "LGPL (v2.1
or later)", "LGPL (v2 or later) (with incorrect FSF address)",
"Unknown or generated". 4 files have unknown license. Detailed output
of licensecheck in /home/jwallace/1374510-lv2-ir-
plugins/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: Package consistently uses macros (instead of hard-coded directory
names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 2 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only
[Bug 1375765] Review Request: yosys - Yosys Open SYnthesis Suite, including Verilog synthesizer
https://bugzilla.redhat.com/show_bug.cgi?id=1375765
Randy Barlow changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #10 from Randy Barlow ---
Looks good, nice work!
Package Review
==
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
= MUST items =
C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[-]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "ISC", "MIT/X11 (BSD like)", "LGPL (v2.1 or later)", "GPL (v3
or later)", "Unknown or generated". 573 files have unknown license.
Detailed output of licensecheck in
/home/rbarlow/reviews/yosys/licensecheck.txt
[-]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 20480 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
= SHOULD items =
Generic:
[x]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in yosys-
doc , yosys-share , yosys-devel , yosys-debuginfo
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/co
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 --- Comment #19 from Randy Barlow --- P.S. The two reviews you've done so far are great. I especially liked that you took the time to help one of them write a man page! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1382152] Review Request: orpie - scientific calculator
https://bugzilla.redhat.com/show_bug.cgi?id=1382152 Randy Barlow changed: What|Removed |Added Flags||needinfo?(jared-wallace@us. ||ibm.com) --- Comment #18 from Randy Barlow --- Hey Jared! We're almost there with this spec file, there's one last thing I think we should do: let's add comments over the Patch# lines in the spec file explaining what each patch is for, and either a) a link to an upstream pull request that has the patch, or b) an explanation why the patch doesn't need to go upstream. Once you've got that, can you do one more unofficial review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library
https://bugzilla.redhat.com/show_bug.cgi?id=1392309 Steve Linabery changed: What|Removed |Added Blocks||1400278 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400278 [Bug 1400278] Review Request: python-os-faults - OpenStack fault-injection library -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400278] New: Review Request: python-os-faults - OpenStack fault-injection library
https://bugzilla.redhat.com/show_bug.cgi?id=1400278 Bug ID: 1400278 Summary: Review Request: python-os-faults - OpenStack fault-injection library Product: Red Hat OpenStack Version: 11.0 (Ocata) Component: distribution Severity: medium Priority: medium Assignee: l...@redhat.com Reporter: slina...@redhat.com QA Contact: ushka...@redhat.com CC: chku...@redhat.com, jp...@redhat.com, mar...@redhat.com, package-review@lists.fedoraproject.org, srev...@redhat.com Depends On: 1392309 Blocks: 1373513 (RDO-OCATA) New Requires and BuildRequires of openstack-rally in ocata. +++ This bug was initially created as a clone of Bug #1392309 +++ Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1373513 [Bug 1373513] Tracker: Blockers and Review requests for new RDO Ocata packages https://bugzilla.redhat.com/show_bug.cgi?id=1392309 [Bug 1392309] Review Request: python-os-faults - OpenStack fault-injection library -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME
https://bugzilla.redhat.com/show_bug.cgi?id=1283327 Steve Linabery changed: What|Removed |Added Blocks||1400271 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400271 [Bug 1400271] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400271] New: Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME
https://bugzilla.redhat.com/show_bug.cgi?id=1400271 Bug ID: 1400271 Summary: Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME Product: Red Hat OpenStack Version: 11.0 (Ocata) Component: distribution Severity: medium Priority: medium Assignee: l...@redhat.com Reporter: slina...@redhat.com QA Contact: ushka...@redhat.com CC: extras...@fedoraproject.org, gauvain.pocen...@objectif-libre.com, jp...@redhat.com, l...@lukos.org, mar...@redhat.com, pabelan...@redhat.com, package-review@lists.fedoraproject.org, srev...@redhat.com, stu...@stuartcampbell.me, zbys...@in.waw.pl Depends On: 1283327 Group: private BuildRequires *only* for openstack-mistral in ocata (do not ship) +++ This bug was initially created as a clone of Bug #1283327 +++ Spec URL: https://jpena.fedorapeople.org/python-sphinxcontrib-pecanwsme/python-sphinxcontrib-pecanwsme.spec SRPM URL: https://jpena.fedorapeople.org/python-sphinxcontrib-pecanwsme/python-sphinxcontrib-pecanwsme-0.8.0-1.fc24.src.rpm Description: Extension to Sphinx for documenting APIs built with Pecan and WSME Fedora Account System Username: jpena Koji scratch build available at http://koji.fedoraproject.org/koji/taskinfo?taskID=11893963 Please note the Python 3 subpackage is currently disabled, due to lack of upstream support (see https://github.com/dreamhost/sphinxcontrib-pecanwsme/pull/14). Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1283327 [Bug 1283327] Review Request: python-sphinxcontrib-pecanwsme - Extension to Sphinx for documenting APIs built with Pecan and WSME -- You are receiving this mail because: You are on the CC list for the bug. ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400261] New: Review Request (rename): qrmumps - A multithreaded multifrontal QR solver
https://bugzilla.redhat.com/show_bug.cgi?id=1400261
Bug ID: 1400261
Summary: Review Request (rename): qrmumps - A multithreaded
multifrontal QR solver
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nob...@fedoraproject.org
Reporter: anto.tra...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org
Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm
Description:
qr_mumps is a software package for the solution of sparse,
linear systems on multicore computers.
It implements a direct solution method based on the QR
factorization of the input matrix. Therefore, it is suited
to solving sparse least-squares problems and to computing
the minimum-norm solution of sparse, underdetermined problems.
It can obviously be used for solving square problems in which
case the stability provided by the use of orthogonal transformations
comes at the cost of a higher operation count with respect to solvers
based on, e.g., the LU factorization.
qr_mumps supports real and complex, single or double precision arithmetic.
Fedora Account System Username: sagitter
This package is for Fedora and EPEL7.
Note:
This is a re-review of 'qr_mumps' already packed with the scope of rename the
package without 'underscore'.
Guidelines: https://fedoraproject.org/wiki/Package_Renaming_Process
I have set Provides Obsoletes tags:
Provides: qr_mumps = 0:%{version}-%{release}
Obsoletes: qr_mumps < 0:2.0-4
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations
https://bugzilla.redhat.com/show_bug.cgi?id=1398400 --- Comment #15 from Antonio Trande --- >SuperLU (and all other supernodal packages) are closer to upstream if they are > named as they are now. I agree. Also, 'repoquery' (or 'dnf') looks be not sensible to capitalized names: repoquery --search SuperLU or repoquery --search superlu give same result. Ultimately, i vote for SuperLU, SuperLUMT, and SuperLUDIST (like upstream). Waiting for Björn opinion. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400236] Review Request: python-podcastparser - Simplified, fast RSS parsing library
https://bugzilla.redhat.com/show_bug.cgi?id=1400236 Jon Ciesla changed: What|Removed |Added Blocks||1400141 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400141 [Bug 1400141] gpodder-3.9.2 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1400236] New: Review Request: python-podcastparser - Simplified, fast RSS parsing library
https://bugzilla.redhat.com/show_bug.cgi?id=1400236 Bug ID: 1400236 Summary: Review Request: python-podcastparser - Simplified, fast RSS parsing library Product: Fedora Version: rawhide Component: Package Review Assignee: nob...@fedoraproject.org Reporter: limburg...@gmail.com QA Contact: extras...@fedoraproject.org CC: package-review@lists.fedoraproject.org Description: Simplified, fast RSS parsing library SPRM: https://fedorapeople.org/~limb/review/python-podcastparser/python-podcastparser-0.6.0-1.fc25.src.rpm SPEC: https://fedorapeople.org/~limb/review/python-podcastparser/python-podcastparser.spec Needed for gpodder>=3.9.2 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations
https://bugzilla.redhat.com/show_bug.cgi?id=1398400
--- Comment #14 from Zbigniew Jędrzejewski-Szmek ---
(In reply to Dave Love from comment #13)
> (In reply to Zbigniew Jędrzejewski-Szmek from comment #10)
> > Neither is prohibited. Both are just guidelines stated as "SHOULD".
>
> Right, which is presumably why fedora-review doesn't object. I assume the
> guideline is against introducing underscores to separate name parts, not to
> expurgate them.
I interpret the guideline as also replacing underscores in the name with
dashes.
The issue is that many projects are inconsistent (for example the tarball name
contains an underscore, but the web page a dash, etc.), so it's often
impossible to know a priori if the package will have a dash or an underscore,
and the guideline to always use dashes emerged to allow people not to guess.
> The good reason is to spell the name correctly, regardless of
> capitalization. If I want to search the archive for what the author calls
> SuperLU_MT, I'd expect "repoquery --search superlu_mt" to find it, and it
> doesn't. Likewise for DL_POLY, which I lower-cased but spelt correctly (as
> a veteran of DL).
Yes, that's a good point. But we already have SuperLUMT.
Aside from the name:
find -name \*.[oa] | xargs rm 2>/dev/null || true
→ find -name \*.[oa] -delete
make → %make_build (to get parallelized build)
> %{!?_licensedir:%global license %doc}
%_licensedir is now defined pretty much everywhere, so this is probably
unneeded.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358149] Review Request: php-zendframework-zend-json-server - Zend Json-Server is a JSON-RPC server implementation
https://bugzilla.redhat.com/show_bug.cgi?id=1358149 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:22:16 --- Comment #7 from Remi Collet --- Package:php-zendframework-zend-json-server-3.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358143] Review Request: php-zendframework-zend-mvc-console - Zend Framework Mvc-Console component
https://bugzilla.redhat.com/show_bug.cgi?id=1358143 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:21:58 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-console-1.1.10-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358153] Review Request: php-zendframework-zend-mvc-form - Zend Framework Mvc-Form component
https://bugzilla.redhat.com/show_bug.cgi?id=1358153 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:21:42 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-form-1.0.0-2.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358155] Review Request: php-zendframework-zend-mvc-i18n - Zend Framework Mvc-I18n component
https://bugzilla.redhat.com/show_bug.cgi?id=1358155 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:21:24 --- Comment #7 from Remi Collet --- Package:php-zendframework-zend-mvc-i18n-1.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358157] Review Request: php-zendframework-zend-mvc-plugin-fileprg - Zend Framework Mvc-Plugin-FilePrg component
https://bugzilla.redhat.com/show_bug.cgi?id=1358157 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:21:04 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-plugin-fileprg-1.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358162] Review Request: php-zendframework-zend-mvc-plugin-identity - Zend Framework Mvc-Plugin-Identity component
https://bugzilla.redhat.com/show_bug.cgi?id=1358162 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:20:18 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-plugin-identity-1.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358145] Review Request: php-zendframework-zend-mvc-plugin-flashmessenger - Zend Framework Mvc-Plugin-FlashMessenger component
https://bugzilla.redhat.com/show_bug.cgi?id=1358145 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:20:41 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-plugin-flashmessenger-1.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358163] Review Request: php-zendframework-zend-mvc-plugin-prg - Zend Framework Mvc-Plugin-Prg component
https://bugzilla.redhat.com/show_bug.cgi?id=1358163 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:19:57 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-plugin-prg-1.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358164] Review Request: php-zendframework-zend-mvc-plugins - Zend Framework Mvc-Plugins component
https://bugzilla.redhat.com/show_bug.cgi?id=1358164 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:19:38 --- Comment #6 from Remi Collet --- Package:php-zendframework-zend-mvc-plugins-1.0.1-2.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358165] Review Request: php-zendframework-zend-xml2json - Provides functionality for converting XML to JSON
https://bugzilla.redhat.com/show_bug.cgi?id=1358165 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:18:25 --- Comment #7 from Remi Collet --- Package:php-zendframework-zend-xml2json-3.0.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358147] Review Request: php-zendframework-zend-servicemanager-di - Zend Framework ServiceManager-Di component
https://bugzilla.redhat.com/show_bug.cgi?id=1358147 Remi Collet changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |RAWHIDE Last Closed||2016-11-30 12:18:50 --- Comment #7 from Remi Collet --- Package:php-zendframework-zend-servicemanager-di-1.1.0-1.fc26 Status: complete -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398400] Review Request: superlu_dist - Solution of large, sparse, nonsymmetric systems of linear equations
https://bugzilla.redhat.com/show_bug.cgi?id=1398400 --- Comment #13 from Dave Love --- (In reply to Zbigniew Jędrzejewski-Szmek from comment #10) > Neither is prohibited. Both are just guidelines stated as "SHOULD". Right, which is presumably why fedora-review doesn't object. I assume the guideline is against introducing underscores to separate name parts, not to expurgate them. > This > means that it's OK to deviate, if there's a good reason. The good reason is to spell the name correctly, regardless of capitalization. If I want to search the archive for what the author calls SuperLU_MT, I'd expect "repoquery --search superlu_mt" to find it, and it doesn't. Likewise for DL_POLY, which I lower-cased but spelt correctly (as a veteran of DL). > OK, so on second thought, consistency is more important. So "SuperLUDIST" > seems best, unless you want to rename the order two packages to "superlu-mt" > and "superlu". Renaming would of course be best in the long run. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950 Hanns-Joachim Uhl changed: What|Removed |Added CC||bugpr...@us.ibm.com External Bug ID||IBM Linux Technology Center ||149296 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1397842 --- Comment #15 from Fedora Update System --- python-cccolutils-1.4-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7d58f0527d -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1397842 Fedora Update System changed: What|Removed |Added Status|ASSIGNED|MODIFIED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1397842 --- Comment #14 from Fedora Update System --- python-cccolutils-1.4-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-aae672950a -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1397842 --- Comment #12 from Fedora Update System --- python-cccolutils-1.4-1.el6 has been submitted as an update to Fedora EPEL 6. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-96a64de312 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397842] Review Request: python-cccolutils - Python Kerberos Credential Cache Collection Utilities
https://bugzilla.redhat.com/show_bug.cgi?id=1397842 --- Comment #13 from Fedora Update System --- python-cccolutils-1.4-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-6b558aab55 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1312301] Review Request: perl-Net-LDAP-Server - Net::LDAP:: Server Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=1312301 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/perl-Net-LDAP-Server -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358163] Review Request: php-zendframework-zend-mvc-plugin-prg - Zend Framework Mvc-Plugin-Prg component
https://bugzilla.redhat.com/show_bug.cgi?id=1358163 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-mvc-plugin-prg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358162] Review Request: php-zendframework-zend-mvc-plugin-identity - Zend Framework Mvc-Plugin-Identity component
https://bugzilla.redhat.com/show_bug.cgi?id=1358162 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-mvc-plugin-identity -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358157] Review Request: php-zendframework-zend-mvc-plugin-fileprg - Zend Framework Mvc-Plugin-FilePrg component
https://bugzilla.redhat.com/show_bug.cgi?id=1358157 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-mvc-plugin-fileprg -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358147] Review Request: php-zendframework-zend-servicemanager-di - Zend Framework ServiceManager-Di component
https://bugzilla.redhat.com/show_bug.cgi?id=1358147 --- Comment #6 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-servicemanager-di -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358145] Review Request: php-zendframework-zend-mvc-plugin-flashmessenger - Zend Framework Mvc-Plugin-FlashMessenger component
https://bugzilla.redhat.com/show_bug.cgi?id=1358145 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-mvc-plugin-flashmessenger -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1358143] Review Request: php-zendframework-zend-mvc-console - Zend Framework Mvc-Console component
https://bugzilla.redhat.com/show_bug.cgi?id=1358143 --- Comment #5 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-zendframework-zend-mvc-console -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397643] Review Request: dapl - Library providing access to the DAT 2.0 API
https://bugzilla.redhat.com/show_bug.cgi?id=1397643 --- Comment #9 from Jon Ciesla --- Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/dapl -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950
--- Comment #3 from Dan Horák ---
formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
e0a0c4c73a63c6a8c5281bab9508dc634f39925a qclib-1.2.0.tgz
OK package meets naming and versioning guidelines.
OK* specfile is properly named, is cleanly written and uses macros
consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (BSD). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
BAD compiler flags are appropriate.
OK package builds in mock (Rawhide/s390x).
OK debuginfo package looks complete.
OK* rpmlint is silent.
BAD final provides and requires look sane.
OK %check is present and all tests pass.
OK shared libraries are added to the regular linker search paths.
BAD owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
BAD correct scriptlets present.
OK code, not content.
OK* documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK headers in devel
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- you can drop the Group tag, it isn't used
- Source0 should be in %{name}-%{version}.tgz form
- Summary could be simplified a bit to "Library for extraction of system
information for Linux on z Systems"
- the build is "silent" (no visible compile commands), but seems that upstream
not distro CFLAGS are used
- rpmlint complains a bit
qclib-static.s390x: W: no-documentation
qclib.s390x: W: no-documentation
qclib.src:23: W: macro-in-comment %{name}
qclib.src:23: W: macro-in-comment %{version}
qclib.src:23: W: macro-in-comment %{release}
qclib.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 1)
qclib-devel.s390x: W: only-non-binary-in-usr-lib
qclib-devel.s390x: W: no-documentation
6 packages and 0 specfiles checked; 0 errors, 8 warnings.
-> drop the commented out line 23 and fix the mixed tabs and spaces
- foo-static is Provided in the static subpackage, should be %{name}-static
- the devel package should Require the base package with %{_isa}
(https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Requiring_Base_Package)
- /usr/share/doc/packages/qclib/ is created, but not owned by the doc
subpackage
- you can drop the scriptlets for the devel subpackage, ldconfig makes sense
only for the runtime lib
- my personal opinion is that the separate doc subpackage is not needed if the
rpm sizes are in low 100kB and can be merged with the devel subpackage
- I would add the README as documentation into the base package
- the path in the doc package shouldn't contain the "packages" part (debianism
in upstream Makefile?)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov changed: What|Removed |Added Blocks||1400109 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400109 [Bug 1400109] qmmp: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov changed: What|Removed |Added Blocks||1400104 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400104 [Bug 1400104] sox: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov changed: What|Removed |Added Blocks||1400100 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400100 [Bug 1400100] sonic-visualiser: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Nicolas Chauvet (kwizart) changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE Last Closed||2016-11-30 07:51:05 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1397261] Review Request: gstreamer1-plugins-ugly-free - GStreamer ugly plugins
https://bugzilla.redhat.com/show_bug.cgi?id=1397261 Bug 1397261 depends on bug 1396139, which changed state. Bug 1396139 Summary: Review Request: libmad - MPEG audio decoder library https://bugzilla.redhat.com/show_bug.cgi?id=1396139 What|Removed |Added Status|ASSIGNED|CLOSED Resolution|--- |CURRENTRELEASE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Nicolas Chauvet (kwizart) changed: What|Removed |Added Blocks||1400089 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400089 [Bug 1400089] qtractor: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950 Hanns-Joachim Uhl changed: What|Removed |Added Hardware|All |s390x Blocks||467765 (ZedoraTracker) Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=467765 [Bug 467765] Fedora for System z (s390): Bug Tracker -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950 --- Comment #2 from Dan Horák --- (In reply to Thomas Andrejak from comment #1) > Hello > > I'm not a packager yet, hence the review is unofficial. Also, I do not have > s390 or s390x so I can't build it but I have some comments. > you should be able to run "s390-koji build --scratch f26 your.src.rpm", there are also "arm-koji" and "ppc-koji" for F < 26 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950 Dan Horák changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1392950] Review Request: qclib - Provides a C API for extraction of system information for Linux on z Systems
https://bugzilla.redhat.com/show_bug.cgi?id=1392950 Dan Horák changed: What|Removed |Added CC||d...@danny.cz Blocks||1306280 Assignee|nob...@fedoraproject.org|d...@danny.cz Flags||fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov changed: What|Removed |Added Blocks||1400073 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400073 [Bug 1400073] ocp: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1396139] Review Request: libmad - MPEG audio decoder library
https://bugzilla.redhat.com/show_bug.cgi?id=1396139 Peter Lemenkov changed: What|Removed |Added Blocks||1400069 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1400069 [Bug 1400069] scummvm: re-enable Mp3 support -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 970213] Review Request: fros - Universal screencasting fronted with pluggable support for various backends
https://bugzilla.redhat.com/show_bug.cgi?id=970213 Jakub Filak changed: What|Removed |Added Assignee|jfi...@redhat.com |ja...@thefilaks.net -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1312301] Review Request: perl-Net-LDAP-Server - Net::LDAP:: Server Perl module
https://bugzilla.redhat.com/show_bug.cgi?id=1312301
Jitka Plesnikova changed:
What|Removed |Added
Flags|fedora-review? |fedora-review+
--- Comment #4 from Jitka Plesnikova ---
(In reply to Jitka Plesnikova from comment #2)
> BuildRequires
> FIX: Please add following BRs:
> - make
> - perl
> - perl-generators
+BuildRequires: perl
+BuildRequires: perl-generators
...
+BuildRequires: %{__make}
Ok.
> FIX: Binary requires and provides are not complete due to missing BR
> perl-generators
$ rpm -qp --requires perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq
-c
1 perl(:MODULE_COMPAT_5.24.0)
1 perl(Convert::ASN1)
1 perl(Data::Dumper)
1 perl(Net::LDAP::ASN)
1 perl(Net::LDAP::Constant)
1 perl(Net::LDAP::Entry)
1 perl(fields)
1 perl(strict)
1 perl(warnings)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -qp --provides perl-Net-LDAP-Server-0.43-2.fc26.noarch.rpm | sort | uniq
-c
1 perl(Net::LDAP::Server) = 0.43
1 perl-Net-LDAP-Server = 0.43-2.fc26
Binary provides are Ok.
> TODO: Please replace PERL_INSTALL_ROOT with more common DESTDIR.
-make pure_install PERL_INSTALL_ROOT=$RPM_BUILD_ROOT
+%{__make} pure_install DESTDIR=$RPM_BUILD_ROOT
Ok.
> TODO: Please add 'examples' to %doc.
+%doc examples
Ok.
The package looks good.
Approved
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
[Bug 1398922] Review Request: uftrace - User-space function call tracer for C and C++ programs
https://bugzilla.redhat.com/show_bug.cgi?id=1398922 --- Comment #5 from Benjamin Kircher --- > Sorry, as a new packager myself, I misunderstood the rules about .so files. Oh, no problem. The question what these libraries are doing is quite justified. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component ___ package-review mailing list -- package-review@lists.fedoraproject.org To unsubscribe send an email to package-review-le...@lists.fedoraproject.org
