[Bug 1400489] Review Request: perl-BSON - BSON serialization and deserialization

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400489

Petr Pisar  changed:

   What|Removed |Added

 Status|ASSIGNED|MODIFIED
   Fixed In Version||perl-BSON-1.2.2-1.fc25



--- Comment #3 from Petr Pisar  ---
Thank you for the review and the repository.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951



--- Comment #18 from Fedora Update System  ---
php-cs-fixer-2.0.0-1.fc24 has been submitted as an update to Fedora 24.
https://bodhi.fedoraproject.org/updates/FEDORA-2016-eff2120f31

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1391951] Review Request: php-cs-fixer - A tool to automatically fix PHP code style

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1391951



--- Comment #17 from Fedora Update System  ---
php-cs-fixer-2.0.0-1.el7 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-0f90e4d0d8

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401365] Review Request: bladerf - A Software Defined Radio (SDR) platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401365

Frank Ballentine, Jr.  changed:

   What|Removed |Added

 Blocks||177841 (FE-NEEDSPONSOR)



--- Comment #1 from Frank Ballentine, Jr.  ---
This is my first package, so I need a sponsor.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841
[Bug 177841] Tracker: Review requests from new Fedora packagers who need a
sponsor
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401365] New: Review Request: bladerf - A Software Defined Radio (SDR ) platform

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401365

Bug ID: 1401365
   Summary: Review Request: bladerf - A Software Defined Radio
(SDR) platform
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Assignee: nob...@fedoraproject.org
  Reporter: art.ballent...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: http://qsl.net/kb1qzh/fedora-pkgs-review/bladerf/bladerf.spec
SRPM URL:
http://qsl.net/kb1qzh/fedora-pkgs-review/bladerf/bladerf-2016.06-1.fc25.src.rpm
Description: 
bladeRF is a Software Defined Radio (SDR) platform designed to enable a
community of hobbyists, and professionals to explore and experiment with the
multidisciplinary facets of RF communication.

Fedora Account System Username: fballjr

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401352] Re-Review Request: CuraEngine - Engine for processing 3D models into G-code instructions for 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401352

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401344] Review Request: CuraEngine-lulzbot - Engine for processing 3D models into G-code instructions for 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401344



--- Comment #1 from Miro Hrončok  ---
(There are no Provides and Obsoletes, because CuraEngine will stay in Fedora
but will get updated.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401352] New: Re-Review Request: CuraEngine - Engine for processing 3D models into G-code instructions for 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401352

Bug ID: 1401352
   Summary: Re-Review Request: CuraEngine - Engine for processing
3D models into G-code instructions for 3D printers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/CuraEngine-2.3.1-1.fc25.src.rpm

Description:

CuraEngine is a C++ console application for 3D printing G-code generation. It
has been made as a better and faster alternative to the old Skeinforge engine.

This is just a console application for G-code generation. For a full graphical
application look at cura with is the graphical frontend for CuraEngine.

Fedora Account System Username: churchyard

Note: This package is already in Fedora, but I now basically rewrote the spec
and would love a formal review to double check everything is OK.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401344] Review Request: CuraEngine-lulzbot - Engine for processing 3D models into G-code instructions for 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401344

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401344] New: Review Request: CuraEngine-lulzbot - Engine for processing 3D models into G-code instructions for 3D printers

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401344

Bug ID: 1401344
   Summary: Review Request: CuraEngine-lulzbot - Engine for
processing 3D models into G-code instructions for 3D
printers
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/CuraEngine-lulzbot-15.04-5.fc25.src.rpm

Description:

CuraEngine-lulzbot is a C++ console application for 3D printing G-code
generation. It
has been made as a better and faster alternative to the old Skeinforge engine.

This is just a console application for G-code generation. For a full graphical
application look at cura-lulzbot with is the graphical frontend for
CuraEngine-lulzbot.

Fedora Account System Username: churchyard

This is package rename from CuraEngine to CuraEngine-lulzbot.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401337] New: Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401337

Bug ID: 1401337
   Summary: Review Request: python-zeroconf - Pure Python
Multicast DNS Service Discovery Library
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-zeroconf.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-zeroconf-0.17.6-1.fc25.src.rpm

Description:

A pure Python implementation of multicast DNS service discovery
supporting Bonjour/Avahi.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401337] Review Request: python-zeroconf - Pure Python Multicast DNS Service Discovery Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401337

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1346038] Review Request: python-blivet1 - python2/ blivet-1.x compatibility package

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1346038

Dan Kenigsberg  changed:

   What|Removed |Added

  Flags||needinfo?(dougsland@redhat.
   ||com)



--- Comment #24 from Dan Kenigsberg  ---
Douglas, David: would you push the f25 package via bodhi?

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401335] Review Request: python-numpy-stl - Library for reading, writing and modifying STL files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401335

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1393176




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1393176
[Bug 1393176] Upstream has changed and there is a newer version available
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401335] Review Request: python-numpy-stl - Library for reading, writing and modifying STL files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401335

Miro Hrončok  changed:

   What|Removed |Added

Summary|Review Request: |Review Request:
   |python-numpy-stl - Library  |python-numpy-stl - Library
   |to make reading, writing|for reading, writing and
   |and modifying STL files |modifying STL files



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334

Miro Hrončok  changed:

   What|Removed |Added

 Blocks||1401335




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401335
[Bug 1401335] Review Request: python-numpy-stl - Library to make reading,
writing and modifying STL files
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401335] Review Request: python-numpy-stl - Library to make reading, writing and modifying STL files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401335

Miro Hrončok  changed:

   What|Removed |Added

 Depends On||1401334




Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1401334
[Bug 1401334] Review Request: python-utils - Python Utils is a module with
some convenient utilities
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401335] New: Review Request: python-numpy-stl - Library to make reading, writing and modifying STL files

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401335

Bug ID: 1401335
   Summary: Review Request: python-numpy-stl - Library to make
reading, writing and modifying STL files
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-numpy-stl.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-numpy-stl-2.0.0-1.fc25.src.rpm

Description:

Simple library to make working with STL files (and 3D objects in general) fast
and easy. Due to all operations heavily relying on NumPy this is one of the
fastest STL editing libraries for Python available.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401334] New: Review Request: python-utils - Python Utils is a module with some convenient utilities

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401334

Bug ID: 1401334
   Summary: Review Request: python-utils - Python Utils is a
module with some convenient utilities
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-utils.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/python-utils-2.0.0-1.fc25.src.rpm

Description:

Python Utils is a collection of small Python functions and classes which
make common patterns shorter and easier. This module makes it easy to
execute common tasks in Python scripts such as converting text to numbers
and making sure a string is in unicode or bytes format.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1399337] Review Request: python3-requests - HTTP library, written in Python, for human beings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1399337



--- Comment #4 from Orion Poplawski  ---
Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-requests.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-requests-2.12.3-1.el7.src.rpm

* Sun Dec 4 2016 Orion Poplwski  - 2.12.3-1
- Update to 2.12.3

python-idna update for EPEL7 -
https://bodhi.fedoraproject.org/updates/python-idna-2.1-2.el7

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1399337] Review Request: python3-requests - HTTP library, written in Python, for human beings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1399337



--- Comment #3 from Tim Orling  ---
Mockbuild failed to install: Runtime dependency on python34-idna cannot be met
on EPEL7 (and no python*-idna package on EL6, FWIW).

Latest version is 2.12.3

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261

Jerry James  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #9 from Jerry James  ---
(In reply to Antonio Trande from comment #8)
> This is a private source link provided by upstream directly.

If there is no public link for the sources, then Source0 should refer to just
the filename, not to a URL.

That's a minor issue.  This package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401329] Review Request: beesu - Graphical wrapper for su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401329



--- Comment #1 from Wolfgang Ulbrich  ---
This is a review for retired package.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401329] New: Review Request: beesu - Graphical wrapper for su

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401329

Bug ID: 1401329
   Summary: Review Request: beesu - Graphical wrapper for su
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: chat-to...@raveit.de
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://raveit65.fedorapeople.org/Others/SPECS/beesu.spec
SRPM URL:
https://raveit65.fedorapeople.org/Others/SRPM/beesu-2.7-28.fc24.src.rpm
Description: Beesu is a wrapper around su and works with consolehelper under
Fedora to let you have a graphic interface like gksu.
Fedora Account System Username: raveit65

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1359412] Review Request: gawkextlib - library providing support functions for gawk extension libraries

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1359412

Andrew J. Schorr  changed:

   What|Removed |Added

 CC||aschorr@telemetry-investmen
   ||ts.com
  Flags|needinfo?   |



--- Comment #4 from Andrew J. Schorr  ---
Hi, sorry for the long delay -- I have been extremely busy with regular work. I
uploaded a new version of the spec file and my responses to your 24 comments
are interspersed below:

> 0) Is this project already packaged for some other distributions? Which ones?
> Could you please provide the links those packages?

No. This will be the first distribution to include it.

> 1) Is there any specific reason, why the project is named gawkextlib? I see
> your second review request for gawk-xml. If I should follow the Fedora
> packaging naming guidelines, I would prefer that this (current) package would
> be named gawk-extlib, so there will be uniformity between other gawk packages
> as well...

I am open to other names, but please consider that comparing gawkextlib
to gawk-xml is like comparing apples to oranges. The gawkextlib package
provides a support library, not an actual gawk extenstion. The gawkextlib
shared library provides APIs that are used by various gawk extension
libraries such as gawk-xml, gawk-pgsql, etc. So it's really a different
beast. The gawkextlib rpm provides no end-user functionality. It provides
only a header file and shared library for use by actual gawk extension
libraries.

> 2) Please, remove the TABs in the specfile, so the indentation is same for
> everyone. Use whitespaces instead.

Done.

> 3) Try to keep the 'Summary' more simple, like for example:
> >  Extension libraries for gawk
> ... Current summarry seems to me to vague, because using word library 2 times
> in a simple sentence is kind of confusing.

Hmmm. "Extension libraries for gawk" is not accurate. This is a library that
provides APIs for use by gawk extension libraries. I'm not sure how else to say
it. Would it be more clear if "gawk extension libraries" were replaced by "gawk
extension modules"? I could also replace "infrastructure" if that's somehow
problematic. Here's a possible rewrite: "Library providing support functions
used by several gawk extension modules." Is that better than "Library providing
common infrastructure for gawk extension libraries"?

> 4) The Group tag is no longer necessary, and it shouldn't be in new specfiles.
> For more info, please, see:
> https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections

Thanks. I removed it.

> 5) Unless you have multiple sources, it's less confusing to use 'Source' tag
> instead of 'Source0'.

I changed "Source0" to "Source".

> 6) (In reply to Andrew Schorr from comment #1)
> > FYI, I updated the spec file to make this minor change:
> > 
> > @@ -5,7 +5,7 @@ Release:1%{?dist}
> >  License:   GPLv3+
> >  Group: Development/Libraries
> >  URL:   http://sourceforge.net/projects/gawkextlib
> > -Source0:  
> > http://sourceforge.net/projects/gawkextlib/files/%{name}-%{version}.tar.gz
> > +Source0:   %{url}/files/%{name}-%{version}.tar.gz
> >  BuildRequires: /usr/include/gawkapi.h
> >  Requires:  gawk
> 
> Actually, I think this change make the Source URL shorter, but for new
> maintainers in the future, it might be a little bit obfuscating. My personal
> preference is to keep the full URL for the source tarball, with only %{name}
> and %{version} in it. However, this is just my opinion, the final decision
> about this will be on you... :)

I made this change because I searched for other new packages currently in the
review process and noted that another maintainer had requested that this change
be made. I can't remember the name of that package at the moment. It seems that
this may be a matter of personal preference. I prefer to avoid repetition, so I
like using %{url} in the Source definition.

> 7) I see you have used the /usr/include/gawkapi.h as the BuildRequires. Again,
> this is too much obfuscated, because other people would have to find out from
> where this header file comes from (is it from gawk or gawkextlib?). Since this
> is normally part of the gawk package (according to 'dnf whatprovides
> ), you should just use simple form of:
> > BuildRequires:  gawk
> 
> UPDATE: Looking at the gawk package itself, I will most likely split it into
> base package and devel supbackage. The /usr/include/gawkapi.h will be located
> inside the gawk-devel subpackage.

I am changing this to say "BuildRequires: gawk-devel".

> 8) %description - it is generally more save to use the name of 'gawkextlib' in
> the description. According to Fedora Package Guidelines (FPG), there might be
> instances where the %{name} might not 

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #2 from Miro Hrončok  ---
Spec URL: https://churchyard.fedorapeople.org/SRPMS/libarcus.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/libarcus-2.3.1-1.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401302] Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302



--- Comment #1 from Miro Hrončok  ---
Accidentally packaged 2.1.3 instead of 2.3.1, will fix this.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1399337] Review Request: python3-requests - HTTP library, written in Python, for human beings

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1399337



--- Comment #2 from Orion Poplawski  ---
Yup.

Spec URL: https://www.cora.nwra.com/~orion/fedora/python3-requests.spec
SRPM URL:
https://www.cora.nwra.com/~orion/fedora/python3-requests-2.12.1-2.el7.src.rpm

* Sun Dec 4 2016 Orion Poplwski  - 2.12.1-2
- Add missing BR on setuptools

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 755510] Review Request: gnome-shell-extension-system-monitor-applet - Gnome shell system monitor extension

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=755510



--- Comment #93 from nicolas.vievi...@univ-valenciennes.fr ---
Hello Community,

As F-25 landed on my laptop here is the last packages for this gnome-shell
extension for F-25 and Rawhide. As nothing new from upstream has been pushed,
git commit number and date are still the same as my previous message. 

New SPEC, SRPMS files and noarch RPMS packages for testing are provided (F-22,
F-23, F-24, ***new*** F-25 and Rawhide - see above #55 to know how to compose
the URL to download RPMS noarch files). New rpmlint reports provided too.
Previous RPMS, SRPMS en SPEC files for F-23, F-24 and Rawhide are no longer
available.
As F-22 reached EOL, corresponding files won't be updated any more, and will
still in a previous version.

Rawhide Spec URL:
https://dl.dropboxusercontent.com/u/25699833/Fedora/Rawhide/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet.spec

Rawhide SRPM URL:
https://dl.dropboxusercontent.com/u/25699833/Fedora/Rawhide/gnome-shell-extension-system-monitor-applet/gnome-shell-extension-system-monitor-applet-0.0.1-0.1.20160405git8b31f07.fc26.src.rpm

Project URL: https://github.com/paradoxxxzero/gnome-shell-system-monitor-applet

rpmlint for Rawhide

rpmlint gnome-shell-extension-system-monitor-applet.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

rpmlint
gnome-shell-extension-system-monitor-applet-0.0.1-0.1.20160405git8b31f07.fc26.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Cordially,


-- 
NVieville

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378526] Review Request: gap-pkg-hapcryst - Integral cohomology computations of Bieberbach groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378526

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #1 from Antonio Trande  ---
Package approved.

Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "Unknown or generated". 107 files have unknown license.
 Detailed output of licensecheck in /home/sagitter/1378526-gap-pkg-
 hapcryst/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 20480 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless 

[Bug 1389971] Review Request: elemental - distributed-memory dense and sparse-direct linear algebra and optimizatio

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1389971

Antonio Trande  changed:

   What|Removed |Added

  Flags|fedora-review?  |fedora-review+



--- Comment #43 from Antonio Trande  ---
Following line can be removed: 


> %files -n python2-elemental-mpich 
> %{python2_sitearch}/mpich/*
>
%license debian/copyright <
>
> %changelog
...

Package approved.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1378526] Review Request: gap-pkg-hapcryst - Integral cohomology computations of Bieberbach groups

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1378526

Antonio Trande  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|nob...@fedoraproject.org|anto.tra...@gmail.com
  Flags||fedora-review?



-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1399365] Review Request: gap-pkg-xmod - Crossed Modules and Cat1-Groups for GAP

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1399365



--- Comment #1 from Antonio Trande  ---
Package Review
==

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

== Issues ==

'URL' and 'Source0' look unreachable.

https://gap-packages.github.io/xmod/ (with
a newer version (2.58))?

= MUST items =

Generic:
[x]: Package is licensed with an open-source compatible license and meets
 other legal requirements as defined in the legal section of Packaging
 Guidelines.
[x]: License field in the package spec file matches the actual license.
 Note: Checking patched sources after %prep for licenses. Licenses
 found: "GPL (v2 or later)", "Unknown or generated". 136 files have
 unknown license. Detailed output of licensecheck in
 /home/sagitter/1399365-gap-pkg-xmod/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
 names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
 Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
 (~1MB) or number of files.
 Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
 one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
 Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
 license(s) in its own file, then that file, containing the text of the
 license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
 that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
 beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
 work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
 provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
 %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

= SHOULD items =

Generic:
[!]: Sources can be downloaded from URI in Source: tag
 Note: Could not download Source0:
 http://pages.bangor.ac.uk/~mas023/chda/xmod/xmod-2.56.tar.gz
 See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags
[-]: If the source package does not include license text(s) as a separate
 file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
 Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
 translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
 architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
 files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
 $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, 

[Bug 1401302] New: Review Request: libarcus - Communication library between internal components for Ultimaker software

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401302

Bug ID: 1401302
   Summary: Review Request: libarcus - Communication library
between internal components for Ultimaker software
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: mhron...@redhat.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://churchyard.fedorapeople.org/SRPMS/libarcus.spec
SRPM URL:
https://churchyard.fedorapeople.org/SRPMS/libarcus-2.1.3-1.fc25.src.rpm

Description:
Arcus library contains C++ code and Python 3 bindings for creating a socket in
a thread and using this socket to send and receive messages based on the
Protocol Buffers library. It is designed to facilitate the communication
between Cura and its backend and similar code.

Fedora Account System Username: churchyard

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1400261] Review Request (rename): qrmumps - A multithreaded multifrontal QR solver

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1400261



--- Comment #8 from Antonio Trande  ---
(In reply to Jerry James from comment #7)
> Issues
> ==
> 1. The Source0 URL is not correct.  The webserver returns an HTTP 404 for
> that
>URL.
>

This is a private source link provided by upstream directly.

> 2. The license should be LGPLv3+ instead of LGPLv3, as the source files
> contain
>the "any later version" language.
> 

Fixed.

> 3. Can make be invoked with %{?_smp_mflags}?
> 

It's not supported.

Spec URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps.spec
SRPM URL: https://sagitter.fedorapeople.org/qrmumps/qrmumps-2.0-4.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1401276] New: Review Request: python-grako - Python grammer compiler

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1401276

Bug ID: 1401276
   Summary: Review Request: python-grako - Python grammer compiler
   Product: Fedora
   Version: rawhide
 Component: Package Review
  Severity: medium
  Priority: medium
  Assignee: nob...@fedoraproject.org
  Reporter: space...@gmail.com
QA Contact: extras...@fedoraproject.org
CC: package-review@lists.fedoraproject.org



Spec URL: https://fedorapeople.org/~brouhaha/python-grako/python-grako.spec
SRPM URL:
https://fedorapeople.org/~brouhaha/python-grako/python-grako-3.17.0-1.fc24.src.rpm
Description: Grako (for "grammar compiler") takes a grammar in a variation of
EBNF
as input, and outputs a memoizing PEG/Packrat parser in Python.
Fedora Account System Username: brouhaha

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org

[Bug 1394502] Review Request: daq - Data Acquisition Library

[bugzilla]

https://bugzilla.redhat.com/show_bug.cgi?id=1394502



--- Comment #21 from Fedora Update System  ---
daq-2.0.6-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If
problems still persist, please make note of it in this bug report.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
___
package-review mailing list -- package-review@lists.fedoraproject.org
To unsubscribe send an email to package-review-le...@lists.fedoraproject.org